[INFO] cloning repository https://github.com/meliosu/spellsolver [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/meliosu/spellsolver" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmeliosu%2Fspellsolver", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmeliosu%2Fspellsolver'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 459accd81c545c07ef2b630481cbf30bded15ed3 [INFO] linting meliosu/spellsolver against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmeliosu%2Fspellsolver" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/meliosu/spellsolver [INFO] finished tweaking git repo https://github.com/meliosu/spellsolver [INFO] tweaked toml for git repo https://github.com/meliosu/spellsolver written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/meliosu/spellsolver on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/meliosu/spellsolver already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded shuttle-service v0.48.0 [INFO] [stderr] Downloaded shuttle-runtime v0.48.0 [INFO] [stderr] Downloaded typeshare v1.0.4 [INFO] [stderr] Downloaded strfmt v0.2.4 [INFO] [stderr] Downloaded async-trait v0.1.85 [INFO] [stderr] Downloaded askama_axum v0.4.0 [INFO] [stderr] Downloaded shuttle-api-client v0.48.0 [INFO] [stderr] Downloaded shuttle-common v0.48.2 [INFO] [stderr] Downloaded shuttle-axum v0.48.0 [INFO] [stderr] Downloaded shuttle-codegen v0.48.0 [INFO] [stderr] Downloaded shuttle-proto v0.48.0 [INFO] [stderr] Downloaded pin-project v1.1.8 [INFO] [stderr] Downloaded basic-toml v0.1.9 [INFO] [stderr] Downloaded comfy-table v6.2.0 [INFO] [stderr] Downloaded pin-project-internal v1.1.8 [INFO] [stderr] Downloaded opentelemetry-http v0.10.0 [INFO] [stderr] Downloaded typeshare-annotation v1.0.4 [INFO] [stderr] Downloaded uuid v1.11.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 85ebc055b5f609c7ff85451e8463e4219e07df205c6c49bdc2233d685cd6f2e3 [INFO] running `Command { std: "docker" "start" "-a" "85ebc055b5f609c7ff85451e8463e4219e07df205c6c49bdc2233d685cd6f2e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "85ebc055b5f609c7ff85451e8463e4219e07df205c6c49bdc2233d685cd6f2e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "85ebc055b5f609c7ff85451e8463e4219e07df205c6c49bdc2233d685cd6f2e3", kill_on_drop: false }` [INFO] [stdout] 85ebc055b5f609c7ff85451e8463e4219e07df205c6c49bdc2233d685cd6f2e3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e88ede02c22f41fb4ed7eebbc59925a919d1195d0773a64be369bf9550a2ecd9 [INFO] running `Command { std: "docker" "start" "-a" "e88ede02c22f41fb4ed7eebbc59925a919d1195d0773a64be369bf9550a2ecd9", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.93 [INFO] [stderr] Compiling serde v1.0.217 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Checking socket2 v0.5.8 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling rustversion v1.0.19 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling cc v1.2.9 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Compiling serde_json v1.0.135 [INFO] [stderr] Compiling anyhow v1.0.95 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Compiling syn v2.0.96 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking webpki-roots v0.25.4 [INFO] [stderr] Checking crossbeam-channel v0.5.14 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking ordered-float v4.6.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking glob v0.3.2 [INFO] [stderr] Compiling semver v1.0.24 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking crossterm v0.26.1 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Compiling axum-core v0.3.4 [INFO] [stderr] Checking strum v0.24.1 [INFO] [stderr] Checking bitflags v2.7.0 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Compiling axum v0.6.20 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Compiling libm v0.2.11 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking headers-core v0.2.0 [INFO] [stderr] Checking task-local-extensions v0.1.4 [INFO] [stderr] Compiling mime v0.3.17 [INFO] [stderr] Checking headers v0.3.9 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Checking strfmt v0.2.4 [INFO] [stderr] Checking anstyle-parse v0.2.6 [INFO] [stderr] Checking humansize v2.1.3 [INFO] [stderr] Checking anstyle-query v1.1.2 [INFO] [stderr] Compiling strum_macros v0.24.3 [INFO] [stderr] Checking askama_escape v0.10.3 [INFO] [stderr] Checking colorchoice v1.0.3 [INFO] [stderr] Checking anstyle v1.0.10 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking anstream v0.6.18 [INFO] [stderr] Checking env_logger v0.11.6 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Checking comfy-table v6.2.0 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Compiling askama_parser v0.2.1 [INFO] [stderr] Compiling serde_derive v1.0.217 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling zerofrom-derive v0.1.5 [INFO] [stderr] Compiling tracing-attributes v0.1.28 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Checking tokio v1.43.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Checking zerofrom v0.1.5 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling async-trait v0.1.85 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling pin-project-internal v1.1.8 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking opentelemetry v0.21.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking pin-project v1.1.8 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Compiling typeshare-annotation v1.0.4 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Compiling prost-derive v0.12.6 [INFO] [stderr] Checking opentelemetry-http v0.10.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Checking opentelemetry_sdk v0.21.2 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking axum-core v0.4.5 [INFO] [stderr] Compiling shuttle-codegen v0.48.0 [INFO] [stderr] Checking tokio-util v0.7.13 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking prost v0.12.6 [INFO] [stderr] Checking tokio-io-timeout v1.2.0 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-stream v0.1.17 [INFO] [stderr] Checking prost-types v0.12.6 [INFO] [stderr] Checking hyper v1.5.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking tracing-serde v0.2.0 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking chrono v0.4.39 [INFO] [stderr] Checking uuid v1.11.1 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Checking hyper-util v0.1.10 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking tracing-subscriber v0.3.19 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking serde_path_to_error v0.1.16 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Compiling basic-toml v0.1.9 [INFO] [stderr] Checking typeshare v1.0.4 [INFO] [stderr] Checking axum v0.7.9 [INFO] [stderr] Checking tungstenite v0.20.1 [INFO] [stderr] Compiling askama_derive v0.12.5 [INFO] [stderr] Checking tracing-opentelemetry v0.22.0 [INFO] [stderr] Checking tokio-tungstenite v0.20.1 [INFO] [stderr] Checking askama v0.12.1 [INFO] [stderr] Checking askama_axum v0.4.0 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking hyper-timeout v0.4.1 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking shuttle-common v0.48.2 [INFO] [stderr] Checking reqwest-middleware v0.2.5 [INFO] [stderr] Checking shuttle-service v0.48.0 [INFO] [stderr] Checking shuttle-api-client v0.48.0 [INFO] [stderr] Checking tonic v0.10.2 [INFO] [stderr] Checking shuttle-proto v0.48.0 [INFO] [stderr] Checking shuttle-runtime v0.48.0 [INFO] [stderr] Checking shuttle-axum v0.48.0 [INFO] [stderr] Checking spellcast v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: you should consider adding a `Default` implementation for `TrieNode` [INFO] [stdout] --> src/trie.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | / pub fn new() -> Self { [INFO] [stdout] 37 | | Self { [INFO] [stdout] 38 | | terminal: false, [INFO] [stdout] 39 | | children: [const { None }; ALPHABET_SIZE], [INFO] [stdout] 40 | | } [INFO] [stdout] 41 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 35 + impl Default for TrieNode { [INFO] [stdout] 36 + fn default() -> Self { [INFO] [stdout] 37 + Self::new() [INFO] [stdout] 38 + } [INFO] [stdout] 39 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual check for common ascii range [INFO] [stdout] --> src/trie.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | / ('a'..='z') [INFO] [stdout] 53 | | .contains(&c) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_ascii_check [INFO] [stdout] = note: `#[warn(clippy::manual_is_ascii_check)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 52 - ('a'..='z') [INFO] [stdout] 53 - .contains(&c) [INFO] [stdout] 52 + c.is_ascii_lowercase() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/trie.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | / if let Some(child) = child.as_deref() { [INFO] [stdout] 61 | | Some((char::from_u32(i as u32 + 'a' as u32).unwrap(), child)) [INFO] [stdout] 62 | | } else { [INFO] [stdout] 63 | | None [INFO] [stdout] 64 | | } [INFO] [stdout] | |_____________^ help: try: `child.as_deref().map(|child| (char::from_u32(i as u32 + 'a' as u32).unwrap(), child))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:81:16 [INFO] [stdout] | [INFO] [stdout] 81 | if !words.worst().is_some_and(|(_, worst)| score <= *worst) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `words.worst().is_none_or(|(_, worst)| score > *worst)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used with `bool::then` [INFO] [stdout] --> src/lib.rs:109:17 [INFO] [stdout] | [INFO] [stdout] 109 | / (nx >= 0 && nx < WIDTH as isize && ny >= 0 && ny < HEIGHT as isize) [INFO] [stdout] 110 | | .then(|| (nx as usize, ny as usize)) [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `then_some` instead [INFO] [stdout] | [INFO] [stdout] 110 - .then(|| (nx as usize, ny as usize)) [INFO] [stdout] 110 + .then_some((nx as usize, ny as usize)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `TrieNode` [INFO] [stdout] --> src/trie.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | / pub fn new() -> Self { [INFO] [stdout] 37 | | Self { [INFO] [stdout] 38 | | terminal: false, [INFO] [stdout] 39 | | children: [const { None }; ALPHABET_SIZE], [INFO] [stdout] 40 | | } [INFO] [stdout] 41 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 35 + impl Default for TrieNode { [INFO] [stdout] 36 + fn default() -> Self { [INFO] [stdout] 37 + Self::new() [INFO] [stdout] 38 + } [INFO] [stdout] 39 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual check for common ascii range [INFO] [stdout] --> src/trie.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | / ('a'..='z') [INFO] [stdout] 53 | | .contains(&c) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_ascii_check [INFO] [stdout] = note: `#[warn(clippy::manual_is_ascii_check)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 52 - ('a'..='z') [INFO] [stdout] 53 - .contains(&c) [INFO] [stdout] 52 + c.is_ascii_lowercase() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/trie.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | / if let Some(child) = child.as_deref() { [INFO] [stdout] 61 | | Some((char::from_u32(i as u32 + 'a' as u32).unwrap(), child)) [INFO] [stdout] 62 | | } else { [INFO] [stdout] 63 | | None [INFO] [stdout] 64 | | } [INFO] [stdout] | |_____________^ help: try: `child.as_deref().map(|child| (char::from_u32(i as u32 + 'a' as u32).unwrap(), child))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:81:16 [INFO] [stdout] | [INFO] [stdout] 81 | if !words.worst().is_some_and(|(_, worst)| score <= *worst) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `words.worst().is_none_or(|(_, worst)| score > *worst)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used with `bool::then` [INFO] [stdout] --> src/lib.rs:109:17 [INFO] [stdout] | [INFO] [stdout] 109 | / (nx >= 0 && nx < WIDTH as isize && ny >= 0 && ny < HEIGHT as isize) [INFO] [stdout] 110 | | .then(|| (nx as usize, ny as usize)) [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `then_some` instead [INFO] [stdout] | [INFO] [stdout] 110 - .then(|| (nx as usize, ny as usize)) [INFO] [stdout] 110 + .then_some((nx as usize, ny as usize)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual check for common ascii range [INFO] [stdout] --> src/main.rs:68:17 [INFO] [stdout] | [INFO] [stdout] 68 | if !('a'..='z').contains(&letter.character) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_ascii_check [INFO] [stdout] = note: `#[warn(clippy::manual_is_ascii_check)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 68 - if !('a'..='z').contains(&letter.character) { [INFO] [stdout] 68 + if !letter.character.is_ascii_lowercase() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual check for common ascii range [INFO] [stdout] --> src/main.rs:68:17 [INFO] [stdout] | [INFO] [stdout] 68 | if !('a'..='z').contains(&letter.character) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_ascii_check [INFO] [stdout] = note: `#[warn(clippy::manual_is_ascii_check)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 68 - if !('a'..='z').contains(&letter.character) { [INFO] [stdout] 68 + if !letter.character.is_ascii_lowercase() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 08s [INFO] running `Command { std: "docker" "inspect" "e88ede02c22f41fb4ed7eebbc59925a919d1195d0773a64be369bf9550a2ecd9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e88ede02c22f41fb4ed7eebbc59925a919d1195d0773a64be369bf9550a2ecd9", kill_on_drop: false }` [INFO] [stdout] e88ede02c22f41fb4ed7eebbc59925a919d1195d0773a64be369bf9550a2ecd9