[INFO] cloning repository https://github.com/mekadomus/mekadomus-api [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/mekadomus/mekadomus-api" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmekadomus%2Fmekadomus-api", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmekadomus%2Fmekadomus-api'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2abdccdc88b1446bc23852c1a3622fa65dd6e63c [INFO] linting mekadomus/mekadomus-api against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmekadomus%2Fmekadomus-api" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/mekadomus/mekadomus-api [INFO] finished tweaking git repo https://github.com/mekadomus/mekadomus-api [INFO] tweaked toml for git repo https://github.com/mekadomus/mekadomus-api written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/mekadomus/mekadomus-api on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/mekadomus/mekadomus-api already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.99 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.99 [INFO] [stderr] Downloaded wasm-bindgen v0.2.99 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.99 [INFO] [stderr] Downloaded bcrypt v0.16.0 [INFO] [stderr] Downloaded json5 v0.4.1 [INFO] [stderr] Downloaded const-random-macro v0.1.16 [INFO] [stderr] Downloaded const-random v0.1.18 [INFO] [stderr] Downloaded thiserror v2.0.9 [INFO] [stderr] Downloaded dlv-list v0.5.2 [INFO] [stderr] Downloaded config v0.14.1 [INFO] [stderr] Downloaded rustls-pki-types v1.10.1 [INFO] [stderr] Downloaded sqlx-sqlite v0.8.3 [INFO] [stderr] Downloaded indexmap v2.7.0 [INFO] [stderr] Downloaded sqlx-core v0.8.3 [INFO] [stderr] Downloaded sqlx-postgres v0.8.3 [INFO] [stderr] Downloaded winnow v0.6.22 [INFO] [stderr] Downloaded h2 v0.4.7 [INFO] [stderr] Downloaded sqlx v0.8.3 [INFO] [stderr] Downloaded hyper v1.5.2 [INFO] [stderr] Downloaded serde_json v1.0.135 [INFO] [stderr] Downloaded yaml-rust2 v0.8.1 [INFO] [stderr] Downloaded fancy-regex v0.13.0 [INFO] [stderr] Downloaded rsa v0.9.7 [INFO] [stderr] Downloaded sqlx-mysql v0.8.3 [INFO] [stderr] Downloaded miniz_oxide v0.8.2 [INFO] [stderr] Downloaded rustls v0.23.20 [INFO] [stderr] Downloaded time v0.3.37 [INFO] [stderr] Downloaded js-sys v0.3.76 [INFO] [stderr] Downloaded zxcvbn v3.1.0 [INFO] [stderr] Downloaded ordered-multimap v0.7.3 [INFO] [stderr] Downloaded rust-ini v0.20.0 [INFO] [stderr] Downloaded arraydeque v0.5.1 [INFO] [stderr] Downloaded sqlx-macros-core v0.8.3 [INFO] [stderr] Downloaded whoami v1.5.2 [INFO] [stderr] Downloaded thiserror-impl v2.0.9 [INFO] [stderr] Downloaded email_address v0.2.9 [INFO] [stderr] Downloaded test-log v0.2.16 [INFO] [stderr] Downloaded wasm-bindgen-backend v0.2.99 [INFO] [stderr] Downloaded wasm-bindgen-futures v0.4.49 [INFO] [stderr] Downloaded sqlx-macros v0.8.3 [INFO] [stderr] Downloaded web-sys v0.3.76 [INFO] [stderr] Downloaded test-log-macros v0.2.16 [INFO] [stderr] Downloaded tokio v1.43.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 48ed545534bc408d03466d8bd9deb2b5321eb2773dea4670e2ffe0c385e07e42 [INFO] running `Command { std: "docker" "start" "-a" "48ed545534bc408d03466d8bd9deb2b5321eb2773dea4670e2ffe0c385e07e42", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "48ed545534bc408d03466d8bd9deb2b5321eb2773dea4670e2ffe0c385e07e42", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "48ed545534bc408d03466d8bd9deb2b5321eb2773dea4670e2ffe0c385e07e42", kill_on_drop: false }` [INFO] [stdout] 48ed545534bc408d03466d8bd9deb2b5321eb2773dea4670e2ffe0c385e07e42 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fb8af7e9597bb53a47f1a7d8c1abc4d36b21bd47609dc7bb90f6291840fe268a [INFO] running `Command { std: "docker" "start" "-a" "fb8af7e9597bb53a47f1a7d8c1abc4d36b21bd47609dc7bb90f6291840fe268a", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.92 [INFO] [stderr] Compiling unicode-ident v1.0.14 [INFO] [stderr] Compiling serde v1.0.217 [INFO] [stderr] Compiling libc v0.2.169 [INFO] [stderr] Compiling cc v1.2.19 [INFO] [stderr] Checking itoa v1.0.14 [INFO] [stderr] Checking bytes v1.9.0 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Compiling thiserror v2.0.9 [INFO] [stderr] Compiling stable_deref_trait v1.2.0 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling openssl v0.10.72 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking foldhash v0.1.4 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Compiling serde_json v1.0.135 [INFO] [stderr] Checking hashbrown v0.15.2 [INFO] [stderr] Compiling writeable v0.5.5 [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Compiling litemap v0.7.4 [INFO] [stderr] Compiling syn v2.0.95 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking indexmap v2.7.0 [INFO] [stderr] Compiling icu_locid_transform_data v1.5.0 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Checking http v1.2.0 [INFO] [stderr] Compiling subtle v2.6.1 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.5.8 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Compiling icu_properties_data v1.5.0 [INFO] [stderr] Compiling block-buffer v0.10.4 [INFO] [stderr] Compiling pin-project-lite v0.2.16 [INFO] [stderr] Compiling digest v0.10.7 [INFO] [stderr] Compiling openssl-sys v0.9.107 [INFO] [stderr] Compiling utf8_iter v1.0.4 [INFO] [stderr] Compiling futures-core v0.3.31 [INFO] [stderr] Compiling icu_normalizer_data v1.5.0 [INFO] [stderr] Compiling write16 v1.0.0 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Compiling utf16_iter v1.0.5 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling scopeguard v1.2.0 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling foreign-types-shared v0.1.1 [INFO] [stderr] Compiling allocator-api2 v0.2.21 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Compiling foreign-types v0.3.2 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling tinyvec_macros v0.1.1 [INFO] [stderr] Compiling form_urlencoded v1.2.1 [INFO] [stderr] Compiling tinyvec v1.8.1 [INFO] [stderr] Compiling concurrent-queue v2.5.0 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling tokio v1.43.1 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling openssl-probe v0.1.5 [INFO] [stderr] Compiling parking v2.2.1 [INFO] [stderr] Compiling futures-task v0.3.31 [INFO] [stderr] Compiling crc-catalog v2.4.0 [INFO] [stderr] Compiling rustix v0.38.43 [INFO] [stderr] Compiling cpufeatures v0.2.16 [INFO] [stderr] Compiling ucd-trie v0.1.7 [INFO] [stderr] Compiling iana-time-zone v0.1.61 [INFO] [stderr] Compiling futures-util v0.3.31 [INFO] [stderr] Compiling sha2 v0.10.8 [INFO] [stderr] Compiling crc v3.2.1 [INFO] [stderr] Compiling event-listener v5.4.0 [INFO] [stderr] Compiling unicode-normalization v0.1.24 [INFO] [stderr] Compiling chrono v0.4.39 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Compiling hashlink v0.10.0 [INFO] [stderr] Compiling crossbeam-queue v0.3.12 [INFO] [stderr] Compiling hmac v0.12.1 [INFO] [stderr] Compiling unicode-bidi v0.3.18 [INFO] [stderr] Compiling linux-raw-sys v0.4.15 [INFO] [stderr] Compiling unicode-properties v0.1.3 [INFO] [stderr] Compiling hkdf v0.12.4 [INFO] [stderr] Compiling stringprep v0.1.5 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Compiling atoi v2.0.0 [INFO] [stderr] Compiling futures-channel v0.3.31 [INFO] [stderr] Compiling md-5 v0.10.6 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling hex v0.4.3 [INFO] [stderr] Compiling fastrand v2.3.0 [INFO] [stderr] Compiling whoami v1.5.2 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling rustversion v1.0.19 [INFO] [stderr] Compiling home v0.5.11 [INFO] [stderr] Compiling base64 v0.22.1 [INFO] [stderr] Compiling dotenvy v0.15.7 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking dlv-list v0.5.2 [INFO] [stderr] Compiling tempfile v3.15.0 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking predicates-core v1.0.9 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Compiling mockall_derive v0.13.1 [INFO] [stderr] Checking winnow v0.6.22 [INFO] [stderr] Compiling serde_derive v1.0.217 [INFO] [stderr] Compiling zerofrom-derive v0.1.5 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tracing-attributes v0.1.28 [INFO] [stderr] Compiling zerofrom v0.1.5 [INFO] [stderr] Compiling yoke v0.7.5 [INFO] [stderr] Compiling thiserror-impl v2.0.9 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Compiling ppv-lite86 v0.2.20 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Compiling pest v2.7.15 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Compiling tokio-stream v0.1.17 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling pest_meta v2.7.15 [INFO] [stderr] Compiling derive_builder_core v0.20.2 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Compiling futures-intrusive v0.5.0 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.8 [INFO] [stderr] Compiling pest_generator v2.7.15 [INFO] [stderr] Checking toml_edit v0.22.22 [INFO] [stderr] Compiling derive_builder_macro v0.20.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking ordered-multimap v0.7.3 [INFO] [stderr] Compiling pest_derive v2.7.15 [INFO] [stderr] Compiling sqlx-core v0.8.3 [INFO] [stderr] Checking hashlink v0.8.4 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Compiling pin-project-internal v1.1.8 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking rustls-pki-types v1.10.1 [INFO] [stderr] Checking arraydeque v0.5.1 [INFO] [stderr] Checking unicode-segmentation v1.12.0 [INFO] [stderr] Checking termtree v0.5.1 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking predicates-tree v1.0.12 [INFO] [stderr] Checking axum-core v0.5.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking yaml-rust2 v0.8.1 [INFO] [stderr] Checking rustls-pemfile v2.2.0 [INFO] [stderr] Checking time v0.3.37 [INFO] [stderr] Checking convert_case v0.6.0 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking blowfish v0.9.1 [INFO] [stderr] Checking pin-project v1.1.8 [INFO] [stderr] Checking fancy-regex v0.13.0 [INFO] [stderr] Checking json5 v0.4.1 [INFO] [stderr] Checking rust-ini v0.20.0 [INFO] [stderr] Checking derive_builder v0.20.2 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking tokio-util v0.7.13 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking h2 v0.4.7 [INFO] [stderr] Checking serde_path_to_error v0.1.16 [INFO] [stderr] Checking tracing-serde v0.2.0 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Compiling axum-macros v0.5.0 [INFO] [stderr] Compiling async-trait v0.1.85 [INFO] [stderr] Compiling sqlx-postgres v0.8.3 [INFO] [stderr] Checking predicates v3.1.3 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking downcast v0.11.0 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking fragile v2.0.0 [INFO] [stderr] Checking pathdiff v0.2.3 [INFO] [stderr] Checking anstream v0.6.18 [INFO] [stderr] Checking config v0.14.1 [INFO] [stderr] Checking bcrypt v0.16.0 [INFO] [stderr] Checking tracing-subscriber v0.3.19 [INFO] [stderr] Checking zxcvbn v3.1.0 [INFO] [stderr] Checking mockall v0.13.1 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tower-http v0.5.2 [INFO] [stderr] Checking email_address v0.2.9 [INFO] [stderr] Checking uuid v1.12.1 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Checking env_logger v0.11.6 [INFO] [stderr] Compiling test-log-macros v0.2.16 [INFO] [stderr] Checking test-log v0.2.16 [INFO] [stderr] Checking hyper v1.5.2 [INFO] [stderr] Checking hyper-util v0.1.10 [INFO] [stderr] Compiling sqlx-macros-core v0.8.3 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking axum v0.8.1 [INFO] [stderr] Checking reqwest v0.12.12 [INFO] [stderr] Compiling sqlx-macros v0.8.3 [INFO] [stderr] Checking sqlx v0.8.3 [INFO] [stderr] Checking mekadomus_api v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/handler/alert.rs:13:39 [INFO] [stdout] | [INFO] [stdout] 13 | pub const ALERTS_MAX_FREQUENCY_MINS: &'static i64 = &20; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&i64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/handler/alert.rs:14:23 [INFO] [stdout] | [INFO] [stdout] 14 | pub const DT_FORMAT: &'static str = "%Y-%m-%d %H:%M:%S%.f"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/handler/alert.rs:15:33 [INFO] [stdout] | [INFO] [stdout] 15 | pub const LAST_ALERTS_RUN_KEY: &'static str = "last-alerts-run"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/handler/alert.rs:16:30 [INFO] [stdout] | [INFO] [stdout] 16 | pub const METERS_PAGE_SIZE: &'static u8 = &100; [INFO] [stdout] | -^^^^^^^--- help: consider removing `'static`: `&u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/api/common.rs:4:31 [INFO] [stdout] | [INFO] [stdout] 4 | pub const DEFAULT_PAGE_SIZE: &'static u8 = &25; [INFO] [stdout] | -^^^^^^^--- help: consider removing `'static`: `&u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/api/common.rs:5:27 [INFO] [stdout] | [INFO] [stdout] 5 | pub const MAX_PAGE_SIZE: &'static u8 = &100; [INFO] [stdout] | -^^^^^^^--- help: consider removing `'static`: `&u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/helper/alert.rs:32:37 [INFO] [stdout] | [INFO] [stdout] 32 | pub const CONSTANT_FLOW_THRESHOLD: &'static usize = &5; [INFO] [stdout] | -^^^^^^^------ help: consider removing `'static`: `&usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/helper/alert.rs:33:36 [INFO] [stdout] | [INFO] [stdout] 33 | pub const MEASUREMENTS_PAGE_SIZE: &'static u8 = &10; [INFO] [stdout] | -^^^^^^^--- help: consider removing `'static`: `&u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/helper/alert.rs:34:34 [INFO] [stdout] | [INFO] [stdout] 34 | pub const NO_REPORTS_THRESHOLD: &'static Duration = &Duration::days(1); [INFO] [stdout] | -^^^^^^^--------- help: consider removing `'static`: `&Duration` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/helper/mail.rs:13:35 [INFO] [stdout] | [INFO] [stdout] 13 | pub const BYTES_PER_METER_ALERT: &'static u16 = &300; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&u16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/helper/token.rs:3:28 [INFO] [stdout] | [INFO] [stdout] 3 | pub const AUTH_TOKEN_LEN: &'static usize = &100; [INFO] [stdout] | -^^^^^^^------ help: consider removing `'static`: `&usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/handler/alert.rs:13:39 [INFO] [stdout] | [INFO] [stdout] 13 | pub const ALERTS_MAX_FREQUENCY_MINS: &'static i64 = &20; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&i64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/handler/alert.rs:14:23 [INFO] [stdout] | [INFO] [stdout] 14 | pub const DT_FORMAT: &'static str = "%Y-%m-%d %H:%M:%S%.f"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/handler/alert.rs:15:33 [INFO] [stdout] | [INFO] [stdout] 15 | pub const LAST_ALERTS_RUN_KEY: &'static str = "last-alerts-run"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/handler/alert.rs:16:30 [INFO] [stdout] | [INFO] [stdout] 16 | pub const METERS_PAGE_SIZE: &'static u8 = &100; [INFO] [stdout] | -^^^^^^^--- help: consider removing `'static`: `&u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/api/common.rs:4:31 [INFO] [stdout] | [INFO] [stdout] 4 | pub const DEFAULT_PAGE_SIZE: &'static u8 = &25; [INFO] [stdout] | -^^^^^^^--- help: consider removing `'static`: `&u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/api/common.rs:5:27 [INFO] [stdout] | [INFO] [stdout] 5 | pub const MAX_PAGE_SIZE: &'static u8 = &100; [INFO] [stdout] | -^^^^^^^--- help: consider removing `'static`: `&u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/helper/alert.rs:32:37 [INFO] [stdout] | [INFO] [stdout] 32 | pub const CONSTANT_FLOW_THRESHOLD: &'static usize = &5; [INFO] [stdout] | -^^^^^^^------ help: consider removing `'static`: `&usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/helper/alert.rs:33:36 [INFO] [stdout] | [INFO] [stdout] 33 | pub const MEASUREMENTS_PAGE_SIZE: &'static u8 = &10; [INFO] [stdout] | -^^^^^^^--- help: consider removing `'static`: `&u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/helper/alert.rs:34:34 [INFO] [stdout] | [INFO] [stdout] 34 | pub const NO_REPORTS_THRESHOLD: &'static Duration = &Duration::days(1); [INFO] [stdout] | -^^^^^^^--------- help: consider removing `'static`: `&Duration` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/helper/mail.rs:13:35 [INFO] [stdout] | [INFO] [stdout] 13 | pub const BYTES_PER_METER_ALERT: &'static u16 = &300; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&u16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/helper/token.rs:3:28 [INFO] [stdout] | [INFO] [stdout] 3 | pub const AUTH_TOKEN_LEN: &'static usize = &100; [INFO] [stdout] | -^^^^^^^------ help: consider removing `'static`: `&usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `last_run` after checking its variant with `is_some` [INFO] [stdout] --> src/handler/alert.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 27 | if last_run.is_some() [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] ... [INFO] [stdout] 33 | last_run.unwrap().value [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/handler/alert.rs:19:53 [INFO] [stdout] | [INFO] [stdout] 19 | let last_run = match state.storage.get_metadata(&LAST_ALERTS_RUN_KEY).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `LAST_ALERTS_RUN_KEY` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/handler/alert.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 64 | if meters.items.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `meters.items.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/handler/alert.rs:80:24 [INFO] [stdout] | [INFO] [stdout] 80 | if a.alerts.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!a.alerts.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/handler/alert.rs:81:25 [INFO] [stdout] | [INFO] [stdout] 81 | / if alerts.contains_key(&m.owner_id) { [INFO] [stdout] 82 | | alerts.get_mut(&m.owner_id).unwrap().push(a); [INFO] [stdout] 83 | | } else { [INFO] [stdout] 84 | | alerts.insert(m.owner_id, vec![a]); [INFO] [stdout] 85 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: consider using the `Entry` API: https://doc.rust-lang.org/std/collections/struct.HashMap.html#entry-api [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] = note: `#[warn(clippy::map_entry)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/fluid_meter.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | return Ok(Extractor(resp)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return Ok(Extractor(resp)); [INFO] [stdout] 65 + Ok(Extractor(resp)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/fluid_meter.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | return Ok(Extractor(meter)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 - return Ok(Extractor(meter)); [INFO] [stdout] 102 + Ok(Extractor(meter)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/handler/fluid_meter.rs:77:8 [INFO] [stdout] | [INFO] [stdout] 77 | if name.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/fluid_meter.rs:124:13 [INFO] [stdout] | [INFO] [stdout] 124 | return Ok(Extractor(())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 124 - return Ok(Extractor(())); [INFO] [stdout] 124 + Ok(Extractor(())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/fluid_meter.rs:128:13 [INFO] [stdout] | [INFO] [stdout] 128 | return internal_error(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 128 - return internal_error(); [INFO] [stdout] 128 + internal_error() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/fluid_meter.rs:157:13 [INFO] [stdout] | [INFO] [stdout] 157 | return Ok(Extractor(m.unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 157 - return Ok(Extractor(m.unwrap())); [INFO] [stdout] 157 + Ok(Extractor(m.unwrap())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/fluid_meter.rs:161:13 [INFO] [stdout] | [INFO] [stdout] 161 | return internal_error(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 161 - return internal_error(); [INFO] [stdout] 161 + internal_error() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/fluid_meter.rs:185:13 [INFO] [stdout] | [INFO] [stdout] 185 | return Ok(Extractor(())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 185 - return Ok(Extractor(())); [INFO] [stdout] 185 + Ok(Extractor(())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/fluid_meter.rs:189:13 [INFO] [stdout] | [INFO] [stdout] 189 | return internal_error(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 189 - return internal_error(); [INFO] [stdout] 189 + internal_error() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/fluid_meter.rs:213:13 [INFO] [stdout] | [INFO] [stdout] 213 | return Ok(Extractor(())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 213 - return Ok(Extractor(())); [INFO] [stdout] 213 + Ok(Extractor(())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/fluid_meter.rs:217:13 [INFO] [stdout] | [INFO] [stdout] 217 | return internal_error(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 217 - return internal_error(); [INFO] [stdout] 217 + internal_error() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/measurement.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 62 | / return validation_error(vec![FailedValidation { [INFO] [stdout] 63 | | field: "device_id".to_string(), [INFO] [stdout] 64 | | issue: Invalid, [INFO] [stdout] 65 | | }]); [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 ~ validation_error(vec![FailedValidation { [INFO] [stdout] 63 + field: "device_id".to_string(), [INFO] [stdout] 64 + issue: Invalid, [INFO] [stdout] 65 ~ }]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/handler/measurement.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | / if m.status == Active { [INFO] [stdout] 36 | | let measurement = Measurement { [INFO] [stdout] 37 | | id: Uuid::new_v4().to_string(), [INFO] [stdout] 38 | | device_id: input.device_id, [INFO] [stdout] ... | [INFO] [stdout] 56 | | return Ok(Extractor(measurement)); [INFO] [stdout] 57 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 34 ~ Some(m) [INFO] [stdout] 35 ~ if m.status == Active => { [INFO] [stdout] 36 | let measurement = Measurement { [INFO] [stdout] ... [INFO] [stdout] 56 | return Ok(Extractor(measurement)); [INFO] [stdout] 57 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/handler/measurement.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | / match meter { [INFO] [stdout] 34 | | Some(m) => { [INFO] [stdout] 35 | | if m.status == Active { [INFO] [stdout] 36 | | let measurement = Measurement { [INFO] [stdout] ... | [INFO] [stdout] 59 | | None => {} [INFO] [stdout] 60 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 33 ~ if let Some(m) = meter { [INFO] [stdout] 34 + if m.status == Active { [INFO] [stdout] 35 + let measurement = Measurement { [INFO] [stdout] 36 + id: Uuid::new_v4().to_string(), [INFO] [stdout] 37 + device_id: input.device_id, [INFO] [stdout] 38 + measurement: input.measurement, [INFO] [stdout] 39 + recorded_at: Utc::now().naive_utc(), [INFO] [stdout] 40 + }; [INFO] [stdout] 41 + match state.storage.save_measurement(&measurement).await { [INFO] [stdout] 42 + Ok(_) => {} [INFO] [stdout] 43 + Err(e) => { [INFO] [stdout] 44 + if e.code == RateLimitError { [INFO] [stdout] 45 + let validation_errors = vec![FailedValidation { [INFO] [stdout] 46 + field: "request".to_string(), [INFO] [stdout] 47 + issue: TooFrequent, [INFO] [stdout] 48 + }]; [INFO] [stdout] 49 + return validation_error(validation_errors); [INFO] [stdout] 50 + } [INFO] [stdout] 51 + return internal_error(); [INFO] [stdout] 52 + } [INFO] [stdout] 53 + } [INFO] [stdout] 54 + [INFO] [stdout] 55 + return Ok(Extractor(measurement)); [INFO] [stdout] 56 + } [INFO] [stdout] 57 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/handler/user.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 41 | if input.name.trim().len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.name.trim().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/user.rs:121:13 [INFO] [stdout] | [INFO] [stdout] 121 | / return Ok(Extractor(User { [INFO] [stdout] 122 | | id: u.id, [INFO] [stdout] 123 | | provider: u.provider, [INFO] [stdout] 124 | | email: u.email, [INFO] [stdout] ... | [INFO] [stdout] 128 | | recorded_at: u.recorded_at, [INFO] [stdout] 129 | | })); [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 121 ~ Ok(Extractor(User { [INFO] [stdout] 122 + id: u.id, [INFO] [stdout] 123 + provider: u.provider, [INFO] [stdout] 124 + email: u.email, [INFO] [stdout] 125 + name: u.name, [INFO] [stdout] 126 + password: None, [INFO] [stdout] 127 + email_verified_at: u.email_verified_at, [INFO] [stdout] 128 + recorded_at: u.recorded_at, [INFO] [stdout] 129 ~ })) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/user.rs:139:13 [INFO] [stdout] | [INFO] [stdout] 139 | return internal_error(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 139 - return internal_error(); [INFO] [stdout] 139 + internal_error() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/handler/user.rs:111:8 [INFO] [stdout] | [INFO] [stdout] 111 | if input.token.trim().len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.token.trim().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/user.rs:196:5 [INFO] [stdout] | [INFO] [stdout] 196 | return Ok(Extractor(session_token)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 196 - return Ok(Extractor(session_token)); [INFO] [stdout] 196 + Ok(Extractor(session_token)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/user.rs:215:19 [INFO] [stdout] | [INFO] [stdout] 215 | Err(_) => return internal_error(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 215 - Err(_) => return internal_error(), [INFO] [stdout] 215 + Err(_) => internal_error(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/user.rs:263:5 [INFO] [stdout] | [INFO] [stdout] 263 | return Ok(Extractor(RecoverPasswordResponse {})); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 263 - return Ok(Extractor(RecoverPasswordResponse {})); [INFO] [stdout] 263 + Ok(Extractor(RecoverPasswordResponse {})) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/user.rs:297:13 [INFO] [stdout] | [INFO] [stdout] 297 | return internal_error(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 297 - return internal_error(); [INFO] [stdout] 297 + internal_error() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/error/app_error.rs:145:5 [INFO] [stdout] | [INFO] [stdout] 145 | return Err(AppError::ServerError); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 145 - return Err(AppError::ServerError); [INFO] [stdout] 145 + Err(AppError::ServerError) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/error/app_error.rs:149:5 [INFO] [stdout] | [INFO] [stdout] 149 | return Err(AppError::ValidationError(validation_errors)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 149 - return Err(AppError::ValidationError(validation_errors)); [INFO] [stdout] 149 + Err(AppError::ValidationError(validation_errors)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/error/app_error.rs:154:5 [INFO] [stdout] | [INFO] [stdout] 154 | return Err(AppError::ValidationError(vec![])); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 154 - return Err(AppError::ValidationError(vec![])); [INFO] [stdout] 154 + Err(AppError::ValidationError(vec![])) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/error/app_error.rs:158:5 [INFO] [stdout] | [INFO] [stdout] 158 | return Err(AppError::Unauthorized); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 158 - return Err(AppError::Unauthorized); [INFO] [stdout] 158 + Err(AppError::Unauthorized) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/helper/alert.rs:27:47 [INFO] [stdout] | [INFO] [stdout] 27 | fn has_constant_flow(&self, measurements: &Vec) -> bool; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Measurement]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/helper/alert.rs:29:70 [INFO] [stdout] | [INFO] [stdout] 29 | fn isnt_reporting(&self, fluid_meter: &FluidMeter, measurements: &Vec) -> bool; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Measurement]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/helper/alert.rs:77:32 [INFO] [stdout] | [INFO] [stdout] 77 | if self.isnt_reporting(&fluid_meter, &measurements) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `fluid_meter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helper/alert.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - return true; [INFO] [stdout] 97 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `n` is only used to index `measurements` [INFO] [stdout] --> src/helper/alert.rs:91:18 [INFO] [stdout] | [INFO] [stdout] 91 | for n in 0..*CONSTANT_FLOW_THRESHOLD { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 91 - for n in 0..*CONSTANT_FLOW_THRESHOLD { [INFO] [stdout] 91 + for in measurements.iter().take(*CONSTANT_FLOW_THRESHOLD) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helper/alert.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 110 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 110 - return false; [INFO] [stdout] 110 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/helper/alert.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 106 | if measurements.len() == 0 || now - measurements[0].recorded_at > *NO_REPORTS_THRESHOLD { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `measurements.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/helper/mail.rs:22:17 [INFO] [stdout] | [INFO] [stdout] 22 | alerts: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&'life3 [FluidMeterAlerts]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/helper/mail.rs:195:13 [INFO] [stdout] | [INFO] [stdout] 195 | &user, [INFO] [stdout] | ^^^^^ help: change this to: `user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/helper/mail.rs:196:13 [INFO] [stdout] | [INFO] [stdout] 196 | &alerts, [INFO] [stdout] | ^^^^^^^ help: change this to: `alerts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helper/measurement.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | return Series { granularity, items }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return Series { granularity, items }; [INFO] [stdout] 51 + Series { granularity, items } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/helper/measurement.rs:12:36 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn create_series(measurements: &Vec, granularity: SeriesGranularity) -> Series { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 12 - pub fn create_series(measurements: &Vec, granularity: SeriesGranularity) -> Series { [INFO] [stdout] 12 + pub fn create_series(measurements: &[Measurement], granularity: SeriesGranularity) -> Series { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/helper/measurement.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | if measurements.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `measurements.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/helper/measurement.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | total = total + measurements[i].measurement.parse::().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total += measurements[i].measurement.parse::().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/helper/measurement.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/helper/measurement.rs:40:17 [INFO] [stdout] | [INFO] [stdout] 40 | current_start = current_start - Duration::days(30); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_start -= Duration::days(30)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/helper/measurement.rs:43:17 [INFO] [stdout] | [INFO] [stdout] 43 | current_start = current_start - Duration::days(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_start -= Duration::days(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/helper/measurement.rs:46:17 [INFO] [stdout] | [INFO] [stdout] 46 | current_start = current_start - Duration::hours(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_start -= Duration::hours(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helper/user.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | return strength.score() < Three; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return strength.score() < Three; [INFO] [stdout] 36 + strength.score() < Three [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helper/user.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | / return match bcrypt::hash(input, bcrypt::DEFAULT_COST) { [INFO] [stdout] 63 | | Ok(h) => Ok(h), [INFO] [stdout] 64 | | Err(e) => { [INFO] [stdout] 65 | | error!("Failed to hash password. {}", e); [INFO] [stdout] ... | [INFO] [stdout] 68 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 ~ match bcrypt::hash(input, bcrypt::DEFAULT_COST) { [INFO] [stdout] 63 + Ok(h) => Ok(h), [INFO] [stdout] 64 + Err(e) => { [INFO] [stdout] 65 + error!("Failed to hash password. {}", e); [INFO] [stdout] 66 + Err(AppError::ServerError) [INFO] [stdout] 67 + } [INFO] [stdout] 68 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helper/user.rs:75:22 [INFO] [stdout] | [INFO] [stdout] 75 | Ok(v) => return Ok(v), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 ~ Ok(v) => Ok(v), [INFO] [stdout] 76 | Err(_) => { [INFO] [stdout] 77 | return Err(AppError::ServerError); [INFO] [stdout] 78 | } [INFO] [stdout] 79 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helper/user.rs:77:17 [INFO] [stdout] | [INFO] [stdout] 77 | return Err(AppError::ServerError); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 ~ Err(AppError::ServerError) [INFO] [stdout] 78 | } [INFO] [stdout] 79 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/helper/user.rs:88:19 [INFO] [stdout] | [INFO] [stdout] 88 | return Ok(!Uuid::try_parse(&meter_id).is_err() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Uuid::try_parse(&meter_id).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/helper/user.rs:88:36 [INFO] [stdout] | [INFO] [stdout] 88 | return Ok(!Uuid::try_parse(&meter_id).is_err() [INFO] [stdout] | ^^^^^^^^^ help: change this to: `meter_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/helper/user.rs:89:45 [INFO] [stdout] | [INFO] [stdout] 89 | && storage.is_fluid_meter_owner(&meter_id, &user_id).await?); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `meter_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/helper/user.rs:89:56 [INFO] [stdout] | [INFO] [stdout] 89 | && storage.is_fluid_meter_owner(&meter_id, &user_id).await?); [INFO] [stdout] | ^^^^^^^^ help: change this to: `user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/http_client/cloudflare.rs:32:17 [INFO] [stdout] | [INFO] [stdout] 32 | return Ok(j.success); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return Ok(j.success); [INFO] [stdout] 32 + Ok(j.success) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/http_client/cloudflare.rs:36:17 [INFO] [stdout] | [INFO] [stdout] 36 | return Err(Box::new(err)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return Err(Box::new(err)); [INFO] [stdout] 36 + Err(Box::new(err)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/http_client/cloudflare.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | return Err(Box::new(err)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return Err(Box::new(err)); [INFO] [stdout] 41 + Err(Box::new(err)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/middleware/auth.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | return m; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return m; [INFO] [stdout] 31 + m [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/middleware/auth.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | return Ok(next.run(request).await); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - return Ok(next.run(request).await); [INFO] [stdout] 100 + Ok(next.run(request).await) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/middleware/auth.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | return unauthorized(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 - return unauthorized(); [INFO] [stdout] 102 + unauthorized() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/settings.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod settings; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Settings` [INFO] [stdout] --> src/settings/settings.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | / pub fn new() -> Self { [INFO] [stdout] 58 | | let s = match Config::builder() [INFO] [stdout] 59 | | .add_source(Environment::with_prefix("APP").separator("__")) [INFO] [stdout] 60 | | .build() [INFO] [stdout] ... | [INFO] [stdout] 70 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 56 + impl Default for Settings { [INFO] [stdout] 57 + fn default() -> Self { [INFO] [stdout] 58 + Self::new() [INFO] [stdout] 59 + } [INFO] [stdout] 60 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/storage/postgres/fluid_meter.rs:38:38 [INFO] [stdout] | [INFO] [stdout] 38 | match sqlx::query_as(&query) [INFO] [stdout] | ^^^^^^ help: change this to: `query` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/storage/postgres/fluid_meter.rs:40:27 [INFO] [stdout] | [INFO] [stdout] 40 | .bind(&pc) [INFO] [stdout] | ^^^ help: change this to: `pc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/storage/postgres/fluid_meter.rs:63:38 [INFO] [stdout] | [INFO] [stdout] 63 | match sqlx::query_as(&query) [INFO] [stdout] | ^^^^^^ help: change this to: `query` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/storage/postgres/fluid_meter.rs:219:19 [INFO] [stdout] | [INFO] [stdout] 219 | .bind(&id) [INFO] [stdout] | ^^^ help: change this to: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/storage/postgres/fluid_meter.rs:234:19 [INFO] [stdout] | [INFO] [stdout] 234 | .bind(&id) [INFO] [stdout] | ^^^ help: change this to: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/storage/postgres/fluid_meter.rs:240:17 [INFO] [stdout] | [INFO] [stdout] 240 | / match e { [INFO] [stdout] 241 | | sqlx::Error::RowNotFound => { [INFO] [stdout] 242 | | return Ok(None); [INFO] [stdout] ... | [INFO] [stdout] 245 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 240 ~ if let sqlx::Error::RowNotFound = e { [INFO] [stdout] 241 + return Ok(None); [INFO] [stdout] 242 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/storage/postgres/fluid_meter.rs:259:19 [INFO] [stdout] | [INFO] [stdout] 259 | .bind(&fluid_meter_id) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `fluid_meter_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/storage/postgres/fluid_meter.rs:260:19 [INFO] [stdout] | [INFO] [stdout] 260 | .bind(&account_id) [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `account_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/storage/postgres/fluid_meter.rs:266:17 [INFO] [stdout] | [INFO] [stdout] 266 | / match e { [INFO] [stdout] 267 | | sqlx::Error::RowNotFound => { [INFO] [stdout] 268 | | return Ok(false); [INFO] [stdout] ... | [INFO] [stdout] 271 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 266 ~ if let sqlx::Error::RowNotFound = e { [INFO] [stdout] 267 + return Ok(false); [INFO] [stdout] 268 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/storage/postgres/fluid_meter.rs:282:19 [INFO] [stdout] | [INFO] [stdout] 282 | .bind(&meter_id) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `meter_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/storage/postgres/fluid_meter.rs:300:19 [INFO] [stdout] | [INFO] [stdout] 300 | .bind(&meter_id) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `meter_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `last` after checking its variant with `is_some` [INFO] [stdout] --> src/storage/postgres/measurement.rs:56:17 [INFO] [stdout] | [INFO] [stdout] 50 | if last.is_some() [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 56 | last.unwrap().recorded_at, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/storage/postgres/measurement.rs:66:15 [INFO] [stdout] | [INFO] [stdout] 66 | .bind(&measurement.recorded_at) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `measurement.recorded_at` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/storage/postgres/user.rs:33:15 [INFO] [stdout] | [INFO] [stdout] 33 | .bind(&user.email_verified_at) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `user.email_verified_at` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/storage/postgres/user.rs:34:15 [INFO] [stdout] | [INFO] [stdout] 34 | .bind(&user.recorded_at) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `user.recorded_at` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/storage/postgres/user.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 120 | / match e { [INFO] [stdout] 121 | | sqlx::Error::RowNotFound => { [INFO] [stdout] 122 | | return Ok(None); [INFO] [stdout] ... | [INFO] [stdout] 125 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 120 ~ if let sqlx::Error::RowNotFound = e { [INFO] [stdout] 121 + return Ok(None); [INFO] [stdout] 122 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/storage/postgres/user.rs:153:17 [INFO] [stdout] | [INFO] [stdout] 153 | / match e { [INFO] [stdout] 154 | | sqlx::Error::RowNotFound => { [INFO] [stdout] 155 | | return Ok(None); [INFO] [stdout] ... | [INFO] [stdout] 158 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 153 ~ if let sqlx::Error::RowNotFound = e { [INFO] [stdout] 154 + return Ok(None); [INFO] [stdout] 155 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/storage/postgres/user.rs:193:17 [INFO] [stdout] | [INFO] [stdout] 193 | / match e { [INFO] [stdout] 194 | | sqlx::Error::RowNotFound => { [INFO] [stdout] 195 | | error!("No verification matches token {}", &token); [INFO] [stdout] 196 | | return not_found(); [INFO] [stdout] 197 | | } [INFO] [stdout] 198 | | _ => {} [INFO] [stdout] 199 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 193 ~ if let sqlx::Error::RowNotFound = e { [INFO] [stdout] 194 + error!("No verification matches token {}", &token); [INFO] [stdout] 195 + return not_found(); [INFO] [stdout] 196 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/storage/postgres/user.rs:209:19 [INFO] [stdout] | [INFO] [stdout] 209 | .bind(&user.email_verified_at) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `user.email_verified_at` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/storage/postgres/user.rs:234:17 [INFO] [stdout] | [INFO] [stdout] 234 | / match e { [INFO] [stdout] 235 | | sqlx::Error::RowNotFound => { [INFO] [stdout] 236 | | return Ok(None); [INFO] [stdout] ... | [INFO] [stdout] 239 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 234 ~ if let sqlx::Error::RowNotFound = e { [INFO] [stdout] 235 + return Ok(None); [INFO] [stdout] 236 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/storage/postgres/user.rs:259:15 [INFO] [stdout] | [INFO] [stdout] 259 | .bind(&token.expires_at) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `token.expires_at` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/storage/postgres/user.rs:273:19 [INFO] [stdout] | [INFO] [stdout] 273 | .bind(&token) [INFO] [stdout] | ^^^^^^ help: change this to: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/storage/postgres/user.rs:345:51 [INFO] [stdout] | [INFO] [stdout] 345 | .password_recovery(&settings, &user, &token) [INFO] [stdout] | ^^^^^ help: change this to: `user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/storage/postgres/user.rs:368:19 [INFO] [stdout] | [INFO] [stdout] 368 | .bind(&user_id) [INFO] [stdout] | ^^^^^^^^ help: change this to: `user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/storage/postgres/user.rs:374:17 [INFO] [stdout] | [INFO] [stdout] 374 | / match e { [INFO] [stdout] 375 | | sqlx::Error::RowNotFound => { [INFO] [stdout] 376 | | error!("No password recovery for user {}", &user_id); [INFO] [stdout] 377 | | return Ok(None); [INFO] [stdout] 378 | | } [INFO] [stdout] 379 | | _ => {} [INFO] [stdout] 380 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 374 ~ if let sqlx::Error::RowNotFound = e { [INFO] [stdout] 375 + error!("No password recovery for user {}", &user_id); [INFO] [stdout] 376 + return Ok(None); [INFO] [stdout] 377 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/storage/postgres/user.rs:406:17 [INFO] [stdout] | [INFO] [stdout] 406 | / match e { [INFO] [stdout] 407 | | sqlx::Error::RowNotFound => { [INFO] [stdout] 408 | | error!("No password recovery matches token {}", &input.token); [INFO] [stdout] 409 | | return not_found(); [INFO] [stdout] 410 | | } [INFO] [stdout] 411 | | _ => {} [INFO] [stdout] 412 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 406 ~ if let sqlx::Error::RowNotFound = e { [INFO] [stdout] 407 + error!("No password recovery matches token {}", &input.token); [INFO] [stdout] 408 + return not_found(); [INFO] [stdout] 409 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/storage/postgres.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return PostgresStorage { pool }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return PostgresStorage { pool }; [INFO] [stdout] 40 + PostgresStorage { pool } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | / return CorsLayer::new() [INFO] [stdout] 77 | | .allow_methods([Method::DELETE, Method::GET, Method::POST, Method::PUT]) [INFO] [stdout] 78 | | .allow_headers([ [INFO] [stdout] 79 | | "Content-Type".parse().unwrap(), [INFO] [stdout] 80 | | "Authorization".parse().unwrap(), [INFO] [stdout] 81 | | ]) [INFO] [stdout] 82 | | .allow_origin(AllowOrigin::list(cors_domains)); [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 ~ CorsLayer::new() [INFO] [stdout] 77 + .allow_methods([Method::DELETE, Method::GET, Method::POST, Method::PUT]) [INFO] [stdout] 78 + .allow_headers([ [INFO] [stdout] 79 + "Content-Type".parse().unwrap(), [INFO] [stdout] 80 + "Authorization".parse().unwrap(), [INFO] [stdout] 81 + ]) [INFO] [stdout] 82 ~ .allow_origin(AllowOrigin::list(cors_domains)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `last_run` after checking its variant with `is_some` [INFO] [stdout] --> src/handler/alert.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 27 | if last_run.is_some() [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] ... [INFO] [stdout] 33 | last_run.unwrap().value [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/handler/alert.rs:19:53 [INFO] [stdout] | [INFO] [stdout] 19 | let last_run = match state.storage.get_metadata(&LAST_ALERTS_RUN_KEY).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `LAST_ALERTS_RUN_KEY` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/handler/alert.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 64 | if meters.items.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `meters.items.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/handler/alert.rs:80:24 [INFO] [stdout] | [INFO] [stdout] 80 | if a.alerts.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!a.alerts.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/handler/alert.rs:81:25 [INFO] [stdout] | [INFO] [stdout] 81 | / if alerts.contains_key(&m.owner_id) { [INFO] [stdout] 82 | | alerts.get_mut(&m.owner_id).unwrap().push(a); [INFO] [stdout] 83 | | } else { [INFO] [stdout] 84 | | alerts.insert(m.owner_id, vec![a]); [INFO] [stdout] 85 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: consider using the `Entry` API: https://doc.rust-lang.org/std/collections/struct.HashMap.html#entry-api [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] = note: `#[warn(clippy::map_entry)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/fluid_meter.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | return Ok(Extractor(resp)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return Ok(Extractor(resp)); [INFO] [stdout] 65 + Ok(Extractor(resp)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/fluid_meter.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | return Ok(Extractor(meter)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 - return Ok(Extractor(meter)); [INFO] [stdout] 102 + Ok(Extractor(meter)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/handler/fluid_meter.rs:77:8 [INFO] [stdout] | [INFO] [stdout] 77 | if name.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/fluid_meter.rs:124:13 [INFO] [stdout] | [INFO] [stdout] 124 | return Ok(Extractor(())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 124 - return Ok(Extractor(())); [INFO] [stdout] 124 + Ok(Extractor(())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/fluid_meter.rs:128:13 [INFO] [stdout] | [INFO] [stdout] 128 | return internal_error(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 128 - return internal_error(); [INFO] [stdout] 128 + internal_error() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/fluid_meter.rs:157:13 [INFO] [stdout] | [INFO] [stdout] 157 | return Ok(Extractor(m.unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 157 - return Ok(Extractor(m.unwrap())); [INFO] [stdout] 157 + Ok(Extractor(m.unwrap())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/fluid_meter.rs:161:13 [INFO] [stdout] | [INFO] [stdout] 161 | return internal_error(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 161 - return internal_error(); [INFO] [stdout] 161 + internal_error() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/fluid_meter.rs:185:13 [INFO] [stdout] | [INFO] [stdout] 185 | return Ok(Extractor(())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 185 - return Ok(Extractor(())); [INFO] [stdout] 185 + Ok(Extractor(())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/fluid_meter.rs:189:13 [INFO] [stdout] | [INFO] [stdout] 189 | return internal_error(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 189 - return internal_error(); [INFO] [stdout] 189 + internal_error() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/fluid_meter.rs:213:13 [INFO] [stdout] | [INFO] [stdout] 213 | return Ok(Extractor(())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 213 - return Ok(Extractor(())); [INFO] [stdout] 213 + Ok(Extractor(())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/fluid_meter.rs:217:13 [INFO] [stdout] | [INFO] [stdout] 217 | return internal_error(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 217 - return internal_error(); [INFO] [stdout] 217 + internal_error() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/measurement.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 62 | / return validation_error(vec![FailedValidation { [INFO] [stdout] 63 | | field: "device_id".to_string(), [INFO] [stdout] 64 | | issue: Invalid, [INFO] [stdout] 65 | | }]); [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 ~ validation_error(vec![FailedValidation { [INFO] [stdout] 63 + field: "device_id".to_string(), [INFO] [stdout] 64 + issue: Invalid, [INFO] [stdout] 65 ~ }]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/handler/measurement.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | / if m.status == Active { [INFO] [stdout] 36 | | let measurement = Measurement { [INFO] [stdout] 37 | | id: Uuid::new_v4().to_string(), [INFO] [stdout] 38 | | device_id: input.device_id, [INFO] [stdout] ... | [INFO] [stdout] 56 | | return Ok(Extractor(measurement)); [INFO] [stdout] 57 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 34 ~ Some(m) [INFO] [stdout] 35 ~ if m.status == Active => { [INFO] [stdout] 36 | let measurement = Measurement { [INFO] [stdout] ... [INFO] [stdout] 56 | return Ok(Extractor(measurement)); [INFO] [stdout] 57 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/handler/measurement.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | / match meter { [INFO] [stdout] 34 | | Some(m) => { [INFO] [stdout] 35 | | if m.status == Active { [INFO] [stdout] 36 | | let measurement = Measurement { [INFO] [stdout] ... | [INFO] [stdout] 59 | | None => {} [INFO] [stdout] 60 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 33 ~ if let Some(m) = meter { [INFO] [stdout] 34 + if m.status == Active { [INFO] [stdout] 35 + let measurement = Measurement { [INFO] [stdout] 36 + id: Uuid::new_v4().to_string(), [INFO] [stdout] 37 + device_id: input.device_id, [INFO] [stdout] 38 + measurement: input.measurement, [INFO] [stdout] 39 + recorded_at: Utc::now().naive_utc(), [INFO] [stdout] 40 + }; [INFO] [stdout] 41 + match state.storage.save_measurement(&measurement).await { [INFO] [stdout] 42 + Ok(_) => {} [INFO] [stdout] 43 + Err(e) => { [INFO] [stdout] 44 + if e.code == RateLimitError { [INFO] [stdout] 45 + let validation_errors = vec![FailedValidation { [INFO] [stdout] 46 + field: "request".to_string(), [INFO] [stdout] 47 + issue: TooFrequent, [INFO] [stdout] 48 + }]; [INFO] [stdout] 49 + return validation_error(validation_errors); [INFO] [stdout] 50 + } [INFO] [stdout] 51 + return internal_error(); [INFO] [stdout] 52 + } [INFO] [stdout] 53 + } [INFO] [stdout] 54 + [INFO] [stdout] 55 + return Ok(Extractor(measurement)); [INFO] [stdout] 56 + } [INFO] [stdout] 57 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/handler/user.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 41 | if input.name.trim().len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.name.trim().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/user.rs:121:13 [INFO] [stdout] | [INFO] [stdout] 121 | / return Ok(Extractor(User { [INFO] [stdout] 122 | | id: u.id, [INFO] [stdout] 123 | | provider: u.provider, [INFO] [stdout] 124 | | email: u.email, [INFO] [stdout] ... | [INFO] [stdout] 128 | | recorded_at: u.recorded_at, [INFO] [stdout] 129 | | })); [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 121 ~ Ok(Extractor(User { [INFO] [stdout] 122 + id: u.id, [INFO] [stdout] 123 + provider: u.provider, [INFO] [stdout] 124 + email: u.email, [INFO] [stdout] 125 + name: u.name, [INFO] [stdout] 126 + password: None, [INFO] [stdout] 127 + email_verified_at: u.email_verified_at, [INFO] [stdout] 128 + recorded_at: u.recorded_at, [INFO] [stdout] 129 ~ })) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/user.rs:139:13 [INFO] [stdout] | [INFO] [stdout] 139 | return internal_error(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 139 - return internal_error(); [INFO] [stdout] 139 + internal_error() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/handler/user.rs:111:8 [INFO] [stdout] | [INFO] [stdout] 111 | if input.token.trim().len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.token.trim().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/user.rs:196:5 [INFO] [stdout] | [INFO] [stdout] 196 | return Ok(Extractor(session_token)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 196 - return Ok(Extractor(session_token)); [INFO] [stdout] 196 + Ok(Extractor(session_token)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/user.rs:215:19 [INFO] [stdout] | [INFO] [stdout] 215 | Err(_) => return internal_error(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 215 - Err(_) => return internal_error(), [INFO] [stdout] 215 + Err(_) => internal_error(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/user.rs:263:5 [INFO] [stdout] | [INFO] [stdout] 263 | return Ok(Extractor(RecoverPasswordResponse {})); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 263 - return Ok(Extractor(RecoverPasswordResponse {})); [INFO] [stdout] 263 + Ok(Extractor(RecoverPasswordResponse {})) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/user.rs:297:13 [INFO] [stdout] | [INFO] [stdout] 297 | return internal_error(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 297 - return internal_error(); [INFO] [stdout] 297 + internal_error() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> tests/handler/measurement.rs:37:23 [INFO] [stdout] | [INFO] [stdout] 37 | pub const DEVICE_ID: &'static str = "3fe50206-25d0-4830-9de1-b48cc2a89001"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> tests/handler/measurement.rs:38:24 [INFO] [stdout] | [INFO] [stdout] 38 | pub const DEVICE_ID2: &'static str = "3fe50206-25d0-4830-9de1-b48cc2a89002"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> tests/handler/measurement.rs:39:32 [INFO] [stdout] | [INFO] [stdout] 39 | pub const INACTIVE_DEVICE_ID: &'static str = "3fe50206-25d0-4830-9de1-b48cc2a89003"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> tests/handler/measurement.rs:40:28 [INFO] [stdout] | [INFO] [stdout] 40 | pub const MEASUREMENT_ID: &'static str = "3fe50206-25d0-4830-9de1-b48cc2a89004"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/error/app_error.rs:145:5 [INFO] [stdout] | [INFO] [stdout] 145 | return Err(AppError::ServerError); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 145 - return Err(AppError::ServerError); [INFO] [stdout] 145 + Err(AppError::ServerError) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/error/app_error.rs:149:5 [INFO] [stdout] | [INFO] [stdout] 149 | return Err(AppError::ValidationError(validation_errors)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 149 - return Err(AppError::ValidationError(validation_errors)); [INFO] [stdout] 149 + Err(AppError::ValidationError(validation_errors)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/error/app_error.rs:154:5 [INFO] [stdout] | [INFO] [stdout] 154 | return Err(AppError::ValidationError(vec![])); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 154 - return Err(AppError::ValidationError(vec![])); [INFO] [stdout] 154 + Err(AppError::ValidationError(vec![])) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/error/app_error.rs:158:5 [INFO] [stdout] | [INFO] [stdout] 158 | return Err(AppError::Unauthorized); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 158 - return Err(AppError::Unauthorized); [INFO] [stdout] 158 + Err(AppError::Unauthorized) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/helper/alert.rs:27:47 [INFO] [stdout] | [INFO] [stdout] 27 | fn has_constant_flow(&self, measurements: &Vec) -> bool; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Measurement]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/helper/alert.rs:29:70 [INFO] [stdout] | [INFO] [stdout] 29 | fn isnt_reporting(&self, fluid_meter: &FluidMeter, measurements: &Vec) -> bool; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Measurement]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/helper/alert.rs:77:32 [INFO] [stdout] | [INFO] [stdout] 77 | if self.isnt_reporting(&fluid_meter, &measurements) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `fluid_meter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helper/alert.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - return true; [INFO] [stdout] 97 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `n` is only used to index `measurements` [INFO] [stdout] --> src/helper/alert.rs:91:18 [INFO] [stdout] | [INFO] [stdout] 91 | for n in 0..*CONSTANT_FLOW_THRESHOLD { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 91 - for n in 0..*CONSTANT_FLOW_THRESHOLD { [INFO] [stdout] 91 + for in measurements.iter().take(*CONSTANT_FLOW_THRESHOLD) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helper/alert.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 110 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 110 - return false; [INFO] [stdout] 110 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/helper/alert.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 106 | if measurements.len() == 0 || now - measurements[0].recorded_at > *NO_REPORTS_THRESHOLD { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `measurements.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/helper/mail.rs:22:17 [INFO] [stdout] | [INFO] [stdout] 22 | alerts: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&'life3 [FluidMeterAlerts]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/helper/mail.rs:195:13 [INFO] [stdout] | [INFO] [stdout] 195 | &user, [INFO] [stdout] | ^^^^^ help: change this to: `user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/helper/mail.rs:196:13 [INFO] [stdout] | [INFO] [stdout] 196 | &alerts, [INFO] [stdout] | ^^^^^^^ help: change this to: `alerts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helper/measurement.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | return Series { granularity, items }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return Series { granularity, items }; [INFO] [stdout] 51 + Series { granularity, items } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/helper/measurement.rs:12:36 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn create_series(measurements: &Vec, granularity: SeriesGranularity) -> Series { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 12 - pub fn create_series(measurements: &Vec, granularity: SeriesGranularity) -> Series { [INFO] [stdout] 12 + pub fn create_series(measurements: &[Measurement], granularity: SeriesGranularity) -> Series { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/helper/measurement.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | if measurements.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `measurements.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/helper/measurement.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | total = total + measurements[i].measurement.parse::().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total += measurements[i].measurement.parse::().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/helper/measurement.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/helper/measurement.rs:40:17 [INFO] [stdout] | [INFO] [stdout] 40 | current_start = current_start - Duration::days(30); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_start -= Duration::days(30)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/helper/measurement.rs:43:17 [INFO] [stdout] | [INFO] [stdout] 43 | current_start = current_start - Duration::days(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_start -= Duration::days(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/helper/measurement.rs:46:17 [INFO] [stdout] | [INFO] [stdout] 46 | current_start = current_start - Duration::hours(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_start -= Duration::hours(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/helper/measurement.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | hour = hour - Duration::hours(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hour -= Duration::hours(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/helper/measurement.rs:121:9 [INFO] [stdout] | [INFO] [stdout] 121 | hour = hour - Duration::hours(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hour -= Duration::hours(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helper/user.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | return strength.score() < Three; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return strength.score() < Three; [INFO] [stdout] 36 + strength.score() < Three [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helper/user.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | / return match bcrypt::hash(input, bcrypt::DEFAULT_COST) { [INFO] [stdout] 63 | | Ok(h) => Ok(h), [INFO] [stdout] 64 | | Err(e) => { [INFO] [stdout] 65 | | error!("Failed to hash password. {}", e); [INFO] [stdout] ... | [INFO] [stdout] 68 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 ~ match bcrypt::hash(input, bcrypt::DEFAULT_COST) { [INFO] [stdout] 63 + Ok(h) => Ok(h), [INFO] [stdout] 64 + Err(e) => { [INFO] [stdout] 65 + error!("Failed to hash password. {}", e); [INFO] [stdout] 66 + Err(AppError::ServerError) [INFO] [stdout] 67 + } [INFO] [stdout] 68 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helper/user.rs:75:22 [INFO] [stdout] | [INFO] [stdout] 75 | Ok(v) => return Ok(v), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 ~ Ok(v) => Ok(v), [INFO] [stdout] 76 | Err(_) => { [INFO] [stdout] 77 | return Err(AppError::ServerError); [INFO] [stdout] 78 | } [INFO] [stdout] 79 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helper/user.rs:77:17 [INFO] [stdout] | [INFO] [stdout] 77 | return Err(AppError::ServerError); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 ~ Err(AppError::ServerError) [INFO] [stdout] 78 | } [INFO] [stdout] 79 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/helper/user.rs:88:19 [INFO] [stdout] | [INFO] [stdout] 88 | return Ok(!Uuid::try_parse(&meter_id).is_err() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Uuid::try_parse(&meter_id).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/helper/user.rs:88:36 [INFO] [stdout] | [INFO] [stdout] 88 | return Ok(!Uuid::try_parse(&meter_id).is_err() [INFO] [stdout] | ^^^^^^^^^ help: change this to: `meter_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/helper/user.rs:89:45 [INFO] [stdout] | [INFO] [stdout] 89 | && storage.is_fluid_meter_owner(&meter_id, &user_id).await?); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `meter_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/helper/user.rs:89:56 [INFO] [stdout] | [INFO] [stdout] 89 | && storage.is_fluid_meter_owner(&meter_id, &user_id).await?); [INFO] [stdout] | ^^^^^^^^ help: change this to: `user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/http_client/cloudflare.rs:32:17 [INFO] [stdout] | [INFO] [stdout] 32 | return Ok(j.success); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return Ok(j.success); [INFO] [stdout] 32 + Ok(j.success) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/http_client/cloudflare.rs:36:17 [INFO] [stdout] | [INFO] [stdout] 36 | return Err(Box::new(err)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return Err(Box::new(err)); [INFO] [stdout] 36 + Err(Box::new(err)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/http_client/cloudflare.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | return Err(Box::new(err)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return Err(Box::new(err)); [INFO] [stdout] 41 + Err(Box::new(err)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/middleware/auth.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | return m; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return m; [INFO] [stdout] 31 + m [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/middleware/auth.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | return Ok(next.run(request).await); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - return Ok(next.run(request).await); [INFO] [stdout] 100 + Ok(next.run(request).await) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/middleware/auth.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | return unauthorized(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 - return unauthorized(); [INFO] [stdout] 102 + unauthorized() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/settings.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod settings; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Settings` [INFO] [stdout] --> src/settings/settings.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | / pub fn new() -> Self { [INFO] [stdout] 58 | | let s = match Config::builder() [INFO] [stdout] 59 | | .add_source(Environment::with_prefix("APP").separator("__")) [INFO] [stdout] 60 | | .build() [INFO] [stdout] ... | [INFO] [stdout] 70 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 56 + impl Default for Settings { [INFO] [stdout] 57 + fn default() -> Self { [INFO] [stdout] 58 + Self::new() [INFO] [stdout] 59 + } [INFO] [stdout] 60 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> tests/handler/alert.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | m.recorded_at = m.recorded_at + Duration::minutes(20); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `m.recorded_at += Duration::minutes(20)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> tests/handler/alert.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | m.recorded_at = m.recorded_at + Duration::minutes(20); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `m.recorded_at += Duration::minutes(20)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> tests/handler/alert.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | m.recorded_at = m.recorded_at + Duration::minutes(20); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `m.recorded_at += Duration::minutes(20)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> tests/handler/alert.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | m.recorded_at = m.recorded_at + Duration::minutes(20); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `m.recorded_at += Duration::minutes(20)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> tests/handler/alert.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | m.recorded_at = m.recorded_at + Duration::minutes(20); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `m.recorded_at += Duration::minutes(20)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> tests/handler/alert.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 69 | m.recorded_at = m.recorded_at + Duration::minutes(20); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `m.recorded_at += Duration::minutes(20)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> tests/handler/alert.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | m.recorded_at = m.recorded_at + Duration::minutes(20); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `m.recorded_at += Duration::minutes(20)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> tests/handler/alert.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | m.recorded_at = m.recorded_at + Duration::minutes(20); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `m.recorded_at += Duration::minutes(20)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/storage/postgres/fluid_meter.rs:38:38 [INFO] [stdout] | [INFO] [stdout] 38 | match sqlx::query_as(&query) [INFO] [stdout] | ^^^^^^ help: change this to: `query` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/storage/postgres/fluid_meter.rs:40:27 [INFO] [stdout] | [INFO] [stdout] 40 | .bind(&pc) [INFO] [stdout] | ^^^ help: change this to: `pc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/handler/measurement.rs:112:5 [INFO] [stdout] | [INFO] [stdout] 112 | / return ( [INFO] [stdout] 113 | | mekadomus_api::app( [INFO] [stdout] 114 | | Arc::new(MockAlertHelper::new()), [INFO] [stdout] 115 | | Arc::new(authorizer), [INFO] [stdout] ... | [INFO] [stdout] 122 | | storage, [INFO] [stdout] 123 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 112 ~ ( [INFO] [stdout] 113 + mekadomus_api::app( [INFO] [stdout] 114 + Arc::new(MockAlertHelper::new()), [INFO] [stdout] 115 + Arc::new(authorizer), [INFO] [stdout] 116 + mail_helper, [INFO] [stdout] 117 + settings, [INFO] [stdout] 118 + storage.clone(), [INFO] [stdout] 119 + user_helper, [INFO] [stdout] 120 + ) [INFO] [stdout] 121 + .await, [INFO] [stdout] 122 + storage, [INFO] [stdout] 123 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/storage/postgres/fluid_meter.rs:63:38 [INFO] [stdout] | [INFO] [stdout] 63 | match sqlx::query_as(&query) [INFO] [stdout] | ^^^^^^ help: change this to: `query` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/storage/postgres/fluid_meter.rs:219:19 [INFO] [stdout] | [INFO] [stdout] 219 | .bind(&id) [INFO] [stdout] | ^^^ help: change this to: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/storage/postgres/fluid_meter.rs:234:19 [INFO] [stdout] | [INFO] [stdout] 234 | .bind(&id) [INFO] [stdout] | ^^^ help: change this to: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/storage/postgres/fluid_meter.rs:240:17 [INFO] [stdout] | [INFO] [stdout] 240 | / match e { [INFO] [stdout] 241 | | sqlx::Error::RowNotFound => { [INFO] [stdout] 242 | | return Ok(None); [INFO] [stdout] ... | [INFO] [stdout] 245 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 240 ~ if let sqlx::Error::RowNotFound = e { [INFO] [stdout] 241 + return Ok(None); [INFO] [stdout] 242 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/storage/postgres/fluid_meter.rs:259:19 [INFO] [stdout] | [INFO] [stdout] 259 | .bind(&fluid_meter_id) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `fluid_meter_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/storage/postgres/fluid_meter.rs:260:19 [INFO] [stdout] | [INFO] [stdout] 260 | .bind(&account_id) [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `account_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/storage/postgres/fluid_meter.rs:266:17 [INFO] [stdout] | [INFO] [stdout] 266 | / match e { [INFO] [stdout] 267 | | sqlx::Error::RowNotFound => { [INFO] [stdout] 268 | | return Ok(false); [INFO] [stdout] ... | [INFO] [stdout] 271 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 266 ~ if let sqlx::Error::RowNotFound = e { [INFO] [stdout] 267 + return Ok(false); [INFO] [stdout] 268 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/helper/app.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | / return create_app( [INFO] [stdout] 23 | | Arc::new(authorizer), [INFO] [stdout] 24 | | Arc::new(mail_helper), [INFO] [stdout] 25 | | Arc::new(user_helper), [INFO] [stdout] 26 | | ) [INFO] [stdout] 27 | | .await; [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 ~ create_app( [INFO] [stdout] 23 + Arc::new(authorizer), [INFO] [stdout] 24 + Arc::new(mail_helper), [INFO] [stdout] 25 + Arc::new(user_helper), [INFO] [stdout] 26 + ) [INFO] [stdout] 27 ~ .await [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/helper/app.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | / return create_app( [INFO] [stdout] 34 | | Arc::new(authorizer), [INFO] [stdout] 35 | | Arc::new(mail_helper), [INFO] [stdout] 36 | | user_helper.clone(), [INFO] [stdout] 37 | | ) [INFO] [stdout] 38 | | .await; [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 ~ create_app( [INFO] [stdout] 34 + Arc::new(authorizer), [INFO] [stdout] 35 + Arc::new(mail_helper), [INFO] [stdout] 36 + user_helper.clone(), [INFO] [stdout] 37 + ) [INFO] [stdout] 38 ~ .await [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/helper/app.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | / return create_app( [INFO] [stdout] 45 | | Arc::new(authorizer), [INFO] [stdout] 46 | | mail_helper.clone(), [INFO] [stdout] 47 | | Arc::new(user_helper), [INFO] [stdout] 48 | | ) [INFO] [stdout] 49 | | .await; [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 ~ create_app( [INFO] [stdout] 45 + Arc::new(authorizer), [INFO] [stdout] 46 + mail_helper.clone(), [INFO] [stdout] 47 + Arc::new(user_helper), [INFO] [stdout] 48 + ) [INFO] [stdout] 49 ~ .await [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/storage/postgres/fluid_meter.rs:282:19 [INFO] [stdout] | [INFO] [stdout] 282 | .bind(&meter_id) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `meter_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/helper/app.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 91 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 91 - return true; [INFO] [stdout] 91 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/helper/app.rs:106:5 [INFO] [stdout] | [INFO] [stdout] 106 | / return mekadomus_api::app( [INFO] [stdout] 107 | | Arc::new(DefaultAlertHelper {}), [INFO] [stdout] 108 | | authorizer, [INFO] [stdout] 109 | | mail_helper, [INFO] [stdout] ... | [INFO] [stdout] 114 | | .await; [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 106 ~ mekadomus_api::app( [INFO] [stdout] 107 + Arc::new(DefaultAlertHelper {}), [INFO] [stdout] 108 + authorizer, [INFO] [stdout] 109 + mail_helper, [INFO] [stdout] 110 + settings, [INFO] [stdout] 111 + storage.clone(), [INFO] [stdout] 112 + user_helper, [INFO] [stdout] 113 + ) [INFO] [stdout] 114 ~ .await [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/storage/postgres/fluid_meter.rs:300:19 [INFO] [stdout] | [INFO] [stdout] 300 | .bind(&meter_id) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `meter_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `last` after checking its variant with `is_some` [INFO] [stdout] --> src/storage/postgres/measurement.rs:56:17 [INFO] [stdout] | [INFO] [stdout] 50 | if last.is_some() [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 56 | last.unwrap().recorded_at, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `NaiveDateTime` which implements the `Copy` trait [INFO] [stdout] --> tests/helper/fluid_meter.rs:27:22 [INFO] [stdout] | [INFO] [stdout] 27 | recorded_at: creation_time.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `creation_time` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/storage/postgres/measurement.rs:66:15 [INFO] [stdout] | [INFO] [stdout] 66 | .bind(&measurement.recorded_at) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `measurement.recorded_at` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/storage/postgres/user.rs:33:15 [INFO] [stdout] | [INFO] [stdout] 33 | .bind(&user.email_verified_at) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `user.email_verified_at` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/storage/postgres/user.rs:34:15 [INFO] [stdout] | [INFO] [stdout] 34 | .bind(&user.recorded_at) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `user.recorded_at` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/storage/postgres/user.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 120 | / match e { [INFO] [stdout] 121 | | sqlx::Error::RowNotFound => { [INFO] [stdout] 122 | | return Ok(None); [INFO] [stdout] ... | [INFO] [stdout] 125 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 120 ~ if let sqlx::Error::RowNotFound = e { [INFO] [stdout] 121 + return Ok(None); [INFO] [stdout] 122 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/storage/postgres/user.rs:153:17 [INFO] [stdout] | [INFO] [stdout] 153 | / match e { [INFO] [stdout] 154 | | sqlx::Error::RowNotFound => { [INFO] [stdout] 155 | | return Ok(None); [INFO] [stdout] ... | [INFO] [stdout] 158 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 153 ~ if let sqlx::Error::RowNotFound = e { [INFO] [stdout] 154 + return Ok(None); [INFO] [stdout] 155 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/storage/postgres/user.rs:193:17 [INFO] [stdout] | [INFO] [stdout] 193 | / match e { [INFO] [stdout] 194 | | sqlx::Error::RowNotFound => { [INFO] [stdout] 195 | | error!("No verification matches token {}", &token); [INFO] [stdout] 196 | | return not_found(); [INFO] [stdout] 197 | | } [INFO] [stdout] 198 | | _ => {} [INFO] [stdout] 199 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 193 ~ if let sqlx::Error::RowNotFound = e { [INFO] [stdout] 194 + error!("No verification matches token {}", &token); [INFO] [stdout] 195 + return not_found(); [INFO] [stdout] 196 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/storage/postgres/user.rs:209:19 [INFO] [stdout] | [INFO] [stdout] 209 | .bind(&user.email_verified_at) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `user.email_verified_at` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/storage/postgres/user.rs:234:17 [INFO] [stdout] | [INFO] [stdout] 234 | / match e { [INFO] [stdout] 235 | | sqlx::Error::RowNotFound => { [INFO] [stdout] 236 | | return Ok(None); [INFO] [stdout] ... | [INFO] [stdout] 239 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 234 ~ if let sqlx::Error::RowNotFound = e { [INFO] [stdout] 235 + return Ok(None); [INFO] [stdout] 236 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/storage/postgres/user.rs:259:15 [INFO] [stdout] | [INFO] [stdout] 259 | .bind(&token.expires_at) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `token.expires_at` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/storage/postgres/user.rs:273:19 [INFO] [stdout] | [INFO] [stdout] 273 | .bind(&token) [INFO] [stdout] | ^^^^^^ help: change this to: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/storage/postgres/user.rs:345:51 [INFO] [stdout] | [INFO] [stdout] 345 | .password_recovery(&settings, &user, &token) [INFO] [stdout] | ^^^^^ help: change this to: `user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/storage/postgres/user.rs:368:19 [INFO] [stdout] | [INFO] [stdout] 368 | .bind(&user_id) [INFO] [stdout] | ^^^^^^^^ help: change this to: `user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/storage/postgres/user.rs:374:17 [INFO] [stdout] | [INFO] [stdout] 374 | / match e { [INFO] [stdout] 375 | | sqlx::Error::RowNotFound => { [INFO] [stdout] 376 | | error!("No password recovery for user {}", &user_id); [INFO] [stdout] 377 | | return Ok(None); [INFO] [stdout] 378 | | } [INFO] [stdout] 379 | | _ => {} [INFO] [stdout] 380 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 374 ~ if let sqlx::Error::RowNotFound = e { [INFO] [stdout] 375 + error!("No password recovery for user {}", &user_id); [INFO] [stdout] 376 + return Ok(None); [INFO] [stdout] 377 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/storage/postgres/user.rs:406:17 [INFO] [stdout] | [INFO] [stdout] 406 | / match e { [INFO] [stdout] 407 | | sqlx::Error::RowNotFound => { [INFO] [stdout] 408 | | error!("No password recovery matches token {}", &input.token); [INFO] [stdout] 409 | | return not_found(); [INFO] [stdout] 410 | | } [INFO] [stdout] 411 | | _ => {} [INFO] [stdout] 412 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 406 ~ if let sqlx::Error::RowNotFound = e { [INFO] [stdout] 407 + error!("No password recovery matches token {}", &input.token); [INFO] [stdout] 408 + return not_found(); [INFO] [stdout] 409 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/storage/postgres.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return PostgresStorage { pool }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return PostgresStorage { pool }; [INFO] [stdout] 40 + PostgresStorage { pool } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | / return CorsLayer::new() [INFO] [stdout] 77 | | .allow_methods([Method::DELETE, Method::GET, Method::POST, Method::PUT]) [INFO] [stdout] 78 | | .allow_headers([ [INFO] [stdout] 79 | | "Content-Type".parse().unwrap(), [INFO] [stdout] 80 | | "Authorization".parse().unwrap(), [INFO] [stdout] 81 | | ]) [INFO] [stdout] 82 | | .allow_origin(AllowOrigin::list(cors_domains)); [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 ~ CorsLayer::new() [INFO] [stdout] 77 + .allow_methods([Method::DELETE, Method::GET, Method::POST, Method::PUT]) [INFO] [stdout] 78 + .allow_headers([ [INFO] [stdout] 79 + "Content-Type".parse().unwrap(), [INFO] [stdout] 80 + "Authorization".parse().unwrap(), [INFO] [stdout] 81 + ]) [INFO] [stdout] 82 ~ .allow_origin(AllowOrigin::list(cors_domains)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3m 12s [INFO] running `Command { std: "docker" "inspect" "fb8af7e9597bb53a47f1a7d8c1abc4d36b21bd47609dc7bb90f6291840fe268a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fb8af7e9597bb53a47f1a7d8c1abc4d36b21bd47609dc7bb90f6291840fe268a", kill_on_drop: false }` [INFO] [stdout] fb8af7e9597bb53a47f1a7d8c1abc4d36b21bd47609dc7bb90f6291840fe268a