[INFO] cloning repository https://github.com/megakite/tab-o-txt
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/megakite/tab-o-txt" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmegakite%2Ftab-o-txt", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmegakite%2Ftab-o-txt'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 397894677293e84ff78174026a256261de978f51
[INFO] linting megakite/tab-o-txt against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmegakite%2Ftab-o-txt" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'...
[INFO] [stderr] done.
[INFO] removed /workspace/builds/worker-0-tc1/source/.cargo/config.toml
[INFO] started tweaking git repo https://github.com/megakite/tab-o-txt
[INFO] finished tweaking git repo https://github.com/megakite/tab-o-txt
[INFO] tweaked toml for git repo https://github.com/megakite/tab-o-txt written to /workspace/builds/worker-0-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/megakite/tab-o-txt on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/megakite/tab-o-txt already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 6fa7d366585c91456ff1342d190962317b8159465204654094202ba1adb76fcc
[INFO] running `Command { std: "docker" "start" "-a" "6fa7d366585c91456ff1342d190962317b8159465204654094202ba1adb76fcc", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "6fa7d366585c91456ff1342d190962317b8159465204654094202ba1adb76fcc", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "6fa7d366585c91456ff1342d190962317b8159465204654094202ba1adb76fcc", kill_on_drop: false }`
[INFO] [stdout] 6fa7d366585c91456ff1342d190962317b8159465204654094202ba1adb76fcc
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 570ace50fec24e882b5f5539c09c5deb32d24a23924ae2d63f0b2b8617a7cfed
[INFO] running `Command { std: "docker" "start" "-a" "570ace50fec24e882b5f5539c09c5deb32d24a23924ae2d63f0b2b8617a7cfed", kill_on_drop: false }`
[INFO] [stderr]    Compiling libc v0.2.134
[INFO] [stderr]    Compiling parking_lot_core v0.9.5
[INFO] [stderr]    Compiling signal-hook v0.3.14
[INFO] [stderr]     Checking unicode-width v0.1.10
[INFO] [stderr]     Checking signal-hook-registry v1.4.0
[INFO] [stderr]     Checking mio v0.8.5
[INFO] [stderr]     Checking parking_lot v0.12.1
[INFO] [stderr]     Checking signal-hook-mio v0.2.3
[INFO] [stderr]     Checking crossterm v0.25.0
[INFO] [stderr]     Checking tab-o-txt v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]    --> src/sheet.rs:121:30
[INFO] [stdout]     |
[INFO] [stdout] 121 |                 .and_modify(|mut unit| {
[INFO] [stdout]     |                              ----^^^^
[INFO] [stdout]     |                              |
[INFO] [stdout]     |                              help: remove this `mut`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `Editor`
[INFO] [stdout]   --> src/editor.rs:26:5
[INFO] [stdout]    |
[INFO] [stdout] 26 | /     pub fn new() -> Self {
[INFO] [stdout] 27 | |         Self {
[INFO] [stdout] 28 | |             mode: Mode::Navigate,
[INFO] [stdout] 29 | |             file_path: None,
[INFO] [stdout] ...  |
[INFO] [stdout] 34 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 25 + impl Default for Editor {
[INFO] [stdout] 26 +     fn default() -> Self {
[INFO] [stdout] 27 +         Self::new()
[INFO] [stdout] 28 +     }
[INFO] [stdout] 29 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this loop could be written as a `for` loop
[INFO] [stdout]    --> src/editor.rs:287:9
[INFO] [stdout]     |
[INFO] [stdout] 287 |         while let Some(c) = iter.next() {
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for c in iter`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stdout]     = note: `#[warn(clippy::while_let_on_iterator)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str`
[INFO] [stdout]    --> src/sheet.rs:69:5
[INFO] [stdout]     |
[INFO] [stdout]  69 | /     pub fn from_str(buf: &str) -> Self {
[INFO] [stdout]  70 | |         let widths = Self::get_widths(buf, DEFAULT_TAB_SIZE);
[INFO] [stdout]  71 | |         let mut accum_widths = vec![0];
[INFO] [stdout]  72 | |         for i in 0..widths.len() {
[INFO] [stdout] ...   |
[INFO] [stdout] 106 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stdout]     = note: `#[warn(clippy::should_implement_trait)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/sheet.rs:159:12
[INFO] [stdout]     |
[INFO] [stdout] 159 |         if !(index < self.size.0) {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^ help: try: `(index >= self.size.0)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/sheet.rs:177:12
[INFO] [stdout]     |
[INFO] [stdout] 177 |         if !(index < self.size.1) {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^ help: try: `(index >= self.size.1)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` can be collapsed into the outer `match`
[INFO] [stdout]   --> src/util.rs:43:21
[INFO] [stdout]    |
[INFO] [stdout] 43 | /                     if chars.pop().is_some() {
[INFO] [stdout] 44 | |                         execute!(stdout(), MoveLeft(1), Clear(ClearType::UntilNewLine))?;
[INFO] [stdout] 45 | |                     }
[INFO] [stdout]    | |_____________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
[INFO] [stdout]    = note: `#[warn(clippy::collapsible_match)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 42 ~                 }
[INFO] [stdout] 43 ~                     if chars.pop().is_some() => {
[INFO] [stdout] 44 |                         execute!(stdout(), MoveLeft(1), Clear(ClearType::UntilNewLine))?;
[INFO] [stdout] 45 ~                     }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]    --> src/sheet.rs:121:30
[INFO] [stdout]     |
[INFO] [stdout] 121 |                 .and_modify(|mut unit| {
[INFO] [stdout]     |                              ----^^^^
[INFO] [stdout]     |                              |
[INFO] [stdout]     |                              help: remove this `mut`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `Editor`
[INFO] [stdout]   --> src/editor.rs:26:5
[INFO] [stdout]    |
[INFO] [stdout] 26 | /     pub fn new() -> Self {
[INFO] [stdout] 27 | |         Self {
[INFO] [stdout] 28 | |             mode: Mode::Navigate,
[INFO] [stdout] 29 | |             file_path: None,
[INFO] [stdout] ...  |
[INFO] [stdout] 34 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 25 + impl Default for Editor {
[INFO] [stdout] 26 +     fn default() -> Self {
[INFO] [stdout] 27 +         Self::new()
[INFO] [stdout] 28 +     }
[INFO] [stdout] 29 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this loop could be written as a `for` loop
[INFO] [stdout]    --> src/editor.rs:287:9
[INFO] [stdout]     |
[INFO] [stdout] 287 |         while let Some(c) = iter.next() {
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for c in iter`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stdout]     = note: `#[warn(clippy::while_let_on_iterator)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str`
[INFO] [stdout]    --> src/sheet.rs:69:5
[INFO] [stdout]     |
[INFO] [stdout]  69 | /     pub fn from_str(buf: &str) -> Self {
[INFO] [stdout]  70 | |         let widths = Self::get_widths(buf, DEFAULT_TAB_SIZE);
[INFO] [stdout]  71 | |         let mut accum_widths = vec![0];
[INFO] [stdout]  72 | |         for i in 0..widths.len() {
[INFO] [stdout] ...   |
[INFO] [stdout] 106 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stdout]     = note: `#[warn(clippy::should_implement_trait)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/sheet.rs:159:12
[INFO] [stdout]     |
[INFO] [stdout] 159 |         if !(index < self.size.0) {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^ help: try: `(index >= self.size.0)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/sheet.rs:177:12
[INFO] [stdout]     |
[INFO] [stdout] 177 |         if !(index < self.size.1) {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^ help: try: `(index >= self.size.1)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` can be collapsed into the outer `match`
[INFO] [stdout]   --> src/util.rs:43:21
[INFO] [stdout]    |
[INFO] [stdout] 43 | /                     if chars.pop().is_some() {
[INFO] [stdout] 44 | |                         execute!(stdout(), MoveLeft(1), Clear(ClearType::UntilNewLine))?;
[INFO] [stdout] 45 | |                     }
[INFO] [stdout]    | |_____________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
[INFO] [stdout]    = note: `#[warn(clippy::collapsible_match)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 42 ~                 }
[INFO] [stdout] 43 ~                     if chars.pop().is_some() => {
[INFO] [stdout] 44 |                         execute!(stdout(), MoveLeft(1), Clear(ClearType::UntilNewLine))?;
[INFO] [stdout] 45 ~                     }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.37s
[INFO] running `Command { std: "docker" "inspect" "570ace50fec24e882b5f5539c09c5deb32d24a23924ae2d63f0b2b8617a7cfed", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "570ace50fec24e882b5f5539c09c5deb32d24a23924ae2d63f0b2b8617a7cfed", kill_on_drop: false }`
[INFO] [stdout] 570ace50fec24e882b5f5539c09c5deb32d24a23924ae2d63f0b2b8617a7cfed