[INFO] cloning repository https://github.com/meemo/hasher [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/meemo/hasher" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmeemo%2Fhasher", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmeemo%2Fhasher'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f65f7ca0d243ffa75e36dd8351bacf9d2466dadf [INFO] linting meemo/hasher against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmeemo%2Fhasher" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/meemo/hasher [INFO] finished tweaking git repo https://github.com/meemo/hasher [INFO] tweaked toml for git repo https://github.com/meemo/hasher written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/meemo/hasher on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/meemo/hasher already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded sm3 v0.4.2 [INFO] [stderr] Downloaded cxxbridge-flags v1.0.87 [INFO] [stderr] Downloaded dotenvy v0.15.6 [INFO] [stderr] Downloaded clap-verbosity-flag v3.0.2 [INFO] [stderr] Downloaded backtrace v0.3.72 [INFO] [stderr] Downloaded belt-block v0.1.1 [INFO] [stderr] Downloaded md4 v0.10.2 [INFO] [stderr] Downloaded shabal v0.4.1 [INFO] [stderr] Downloaded blocking v1.4.1 [INFO] [stderr] Downloaded tiger v0.2.1 [INFO] [stderr] Downloaded cxxbridge-macro v1.0.87 [INFO] [stderr] Downloaded whirlpool v0.10.4 [INFO] [stderr] Downloaded cxx-build v1.0.87 [INFO] [stderr] Downloaded quinn v0.11.6 [INFO] [stderr] Downloaded belt-hash v0.1.1 [INFO] [stderr] Downloaded gost94 v0.10.4 [INFO] [stderr] Downloaded md2 v0.10.2 [INFO] [stderr] Downloaded serde_json v1.0.137 [INFO] [stderr] Downloaded async-global-executor v2.3.1 [INFO] [stderr] Downloaded groestl v0.10.1 [INFO] [stderr] Downloaded quinn-proto v0.11.9 [INFO] [stderr] Downloaded reqwest v0.12.12 [INFO] [stderr] Downloaded rustls v0.23.16 [INFO] [stderr] Downloaded fsb v0.1.3 [INFO] [stderr] Downloaded rustix v0.37.3 [INFO] [stderr] Downloaded object v0.35.0 [INFO] [stderr] Downloaded async-std v1.12.0 [INFO] [stderr] Downloaded streebog v0.10.2 [INFO] [stderr] Downloaded cxx v1.0.87 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ed90cc56efdb819289ccf8bc3d8eb3807ea188dc4b12a34878f032341c9bbee2 [INFO] running `Command { std: "docker" "start" "-a" "ed90cc56efdb819289ccf8bc3d8eb3807ea188dc4b12a34878f032341c9bbee2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ed90cc56efdb819289ccf8bc3d8eb3807ea188dc4b12a34878f032341c9bbee2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ed90cc56efdb819289ccf8bc3d8eb3807ea188dc4b12a34878f032341c9bbee2", kill_on_drop: false }` [INFO] [stdout] ed90cc56efdb819289ccf8bc3d8eb3807ea188dc4b12a34878f032341c9bbee2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d22d557dfbf86f0f7f6c4bc5a7b02291e40e25ac14a4bb088737020987246484 [INFO] running `Command { std: "docker" "start" "-a" "d22d557dfbf86f0f7f6c4bc5a7b02291e40e25ac14a4bb088737020987246484", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling cc v1.2.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.14 [INFO] [stderr] Checking value-bag v1.9.0 [INFO] [stderr] Compiling serde v1.0.217 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.3 [INFO] [stderr] Compiling futures-core v0.3.31 [INFO] [stderr] Compiling io-lifetimes v1.0.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking bytes v1.8.0 [INFO] [stderr] Compiling stable_deref_trait v1.2.0 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Compiling rustix v0.37.3 [INFO] [stderr] Checking log v0.4.25 [INFO] [stderr] Checking allocator-api2 v0.2.20 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling writeable v0.5.5 [INFO] [stderr] Compiling scopeguard v1.1.0 [INFO] [stderr] Compiling litemap v0.7.3 [INFO] [stderr] Compiling rustls v0.23.16 [INFO] [stderr] Checking hashbrown v0.15.1 [INFO] [stderr] Compiling futures-io v0.3.31 [INFO] [stderr] Compiling lock_api v0.4.9 [INFO] [stderr] Compiling concurrent-queue v2.5.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling smallvec v1.13.2 [INFO] [stderr] Compiling slab v0.4.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling syn v2.0.87 [INFO] [stderr] Compiling event-listener v2.5.3 [INFO] [stderr] Compiling fastrand v2.2.0 [INFO] [stderr] Compiling icu_locid_transform_data v1.5.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling typenum v1.16.0 [INFO] [stderr] Compiling thiserror v2.0.3 [INFO] [stderr] Compiling fastrand v1.9.0 [INFO] [stderr] Compiling waker-fn v1.2.0 [INFO] [stderr] Checking indexmap v2.6.0 [INFO] [stderr] Compiling crossbeam-queue v0.3.8 [INFO] [stderr] Checking rustls-pki-types v1.10.0 [INFO] [stderr] Compiling serde_json v1.0.137 [INFO] [stderr] Compiling icu_properties_data v1.5.0 [INFO] [stderr] Compiling futures-lite v1.13.0 [INFO] [stderr] Compiling async-lock v2.8.0 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling openssl-sys v0.9.104 [INFO] [stderr] Compiling generic-array v0.14.6 [INFO] [stderr] Compiling icu_normalizer_data v1.5.0 [INFO] [stderr] Compiling write16 v1.0.0 [INFO] [stderr] Compiling linux-raw-sys v0.3.8 [INFO] [stderr] Compiling async-task v4.7.1 [INFO] [stderr] Compiling utf16_iter v1.0.5 [INFO] [stderr] Compiling atomic-waker v1.1.2 [INFO] [stderr] Compiling utf8_iter v1.0.4 [INFO] [stderr] Compiling piper v0.2.3 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling libsqlite3-sys v0.30.1 [INFO] [stderr] Compiling async-channel v1.9.0 [INFO] [stderr] Compiling futures-lite v2.3.0 [INFO] [stderr] Compiling socket2 v0.4.7 [INFO] [stderr] Compiling rustix v0.38.41 [INFO] [stderr] Compiling async-executor v1.12.0 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling itoa v1.0.5 [INFO] [stderr] Compiling ryu v1.0.12 [INFO] [stderr] Compiling futures-task v0.3.31 [INFO] [stderr] Compiling parking_lot v0.12.3 [INFO] [stderr] Compiling futures-util v0.3.31 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling kv-log-macro v1.0.7 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Compiling cpufeatures v0.2.5 [INFO] [stderr] Compiling crc-catalog v2.2.0 [INFO] [stderr] Compiling openssl v0.10.68 [INFO] [stderr] Checking rustls-webpki v0.102.8 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Compiling crc v3.0.1 [INFO] [stderr] Compiling sha2 v0.10.8 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling futures-intrusive v0.5.0 [INFO] [stderr] Compiling hashlink v0.10.0 [INFO] [stderr] Compiling rustls-pemfile v2.2.0 [INFO] [stderr] Compiling webpki-roots v0.26.6 [INFO] [stderr] Compiling event-listener v5.3.1 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Compiling bitflags v2.5.0 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Compiling atoi v2.0.0 [INFO] [stderr] Compiling zerofrom-derive v0.1.4 [INFO] [stderr] Compiling yoke-derive v0.7.4 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling serde_derive v1.0.217 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling thiserror-impl v2.0.3 [INFO] [stderr] Compiling zerofrom v0.1.4 [INFO] [stderr] Compiling yoke v0.7.4 [INFO] [stderr] Compiling zerovec v0.10.4 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking tokio v1.43.0 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Compiling blocking v1.4.1 [INFO] [stderr] Compiling async-global-executor v2.3.1 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Compiling async-std v1.12.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking h2 v0.4.7 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.3 [INFO] [stderr] Compiling futures-executor v0.3.31 [INFO] [stderr] Compiling flume v0.11.0 [INFO] [stderr] Compiling futures-channel v0.3.31 [INFO] [stderr] Compiling either v1.8.1 [INFO] [stderr] Compiling serde_urlencoded v0.7.1 [INFO] [stderr] Compiling tempfile v3.15.0 [INFO] [stderr] Checking aho-corasick v0.7.20 [INFO] [stderr] Compiling dotenvy v0.15.6 [INFO] [stderr] Checking regex-syntax v0.6.28 [INFO] [stderr] Checking clap_builder v4.5.26 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Compiling sqlx-core v0.8.3 [INFO] [stderr] Checking serde_spanned v0.6.8 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Compiling clap_derive v4.5.24 [INFO] [stderr] Checking regex v1.7.1 [INFO] [stderr] Checking winnow v0.6.20 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking whirlpool v0.10.4 [INFO] [stderr] Checking iana-time-zone v0.1.53 [INFO] [stderr] Checking hyper v1.5.1 [INFO] [stderr] Checking belt-block v0.1.1 [INFO] [stderr] Checking keccak v0.1.5 [INFO] [stderr] Checking ipnet v2.10.1 [INFO] [stderr] Checking belt-hash v0.1.1 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking env_logger v0.11.6 [INFO] [stderr] Checking chrono v0.4.39 [INFO] [stderr] Checking flate2 v1.0.35 [INFO] [stderr] Checking fsb v0.1.3 [INFO] [stderr] Checking toml_edit v0.22.22 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking tiger v0.2.1 [INFO] [stderr] Checking ripemd v0.1.3 [INFO] [stderr] Checking groestl v0.10.1 [INFO] [stderr] Checking sm3 v0.4.2 [INFO] [stderr] Checking clap v4.5.26 [INFO] [stderr] Checking streebog v0.10.2 [INFO] [stderr] Checking clap-verbosity-flag v3.0.2 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking md4 v0.10.2 [INFO] [stderr] Checking hyper-util v0.1.10 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking gost94 v0.10.4 [INFO] [stderr] Checking sqlx-sqlite v0.8.3 [INFO] [stderr] Checking md2 v0.10.2 [INFO] [stderr] Checking shabal v0.4.1 [INFO] [stderr] Checking hyper-rustls v0.27.3 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking reqwest v0.12.12 [INFO] [stderr] Compiling sqlx-macros-core v0.8.3 [INFO] [stderr] Compiling sqlx-macros v0.8.3 [INFO] [stderr] Checking sqlx v0.8.3 [INFO] [stderr] Checking hasher v0.8.18 (/opt/rustwide/workdir) [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/lib.rs:128:13 [INFO] [stdout] | [INFO] [stdout] 128 | hashes: Vec<(&'static str, Arc>>)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `.write(true)` because there is `.append(true)` [INFO] [stdout] --> src/lib.rs:358:17 [INFO] [stdout] | [INFO] [stdout] 358 | .write(true) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove `.write(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options [INFO] [stdout] = note: `#[warn(clippy::ineffective_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/lib.rs:128:13 [INFO] [stdout] | [INFO] [stdout] 128 | hashes: Vec<(&'static str, Arc>>)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/utils.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | use sqlx; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/utils.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | use sqlx; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands/copy.rs:147:26 [INFO] [stdout] | [INFO] [stdout] 147 | let source_data = if (source_compressed && args.hash_options.decompress) [INFO] [stdout] | __________________________^ [INFO] [stdout] 148 | | || (source_compressed && args.hash_options.hash_uncompressed) [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 147 - let source_data = if (source_compressed && args.hash_options.decompress) [INFO] [stdout] 148 - || (source_compressed && args.hash_options.hash_uncompressed) [INFO] [stdout] 147 + let source_data = if !(!source_compressed || !args.hash_options.decompress && !args.hash_options.hash_uncompressed) [INFO] [stdout] | [INFO] [stdout] 147 - let source_data = if (source_compressed && args.hash_options.decompress) [INFO] [stdout] 148 - || (source_compressed && args.hash_options.hash_uncompressed) [INFO] [stdout] 147 + let source_data = if (args.hash_options.hash_uncompressed || args.hash_options.decompress) && source_compressed [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands/copy.rs:173:24 [INFO] [stdout] | [INFO] [stdout] 173 | let dest_data = if (dest_compressed && args.hash_options.decompress) [INFO] [stdout] | ________________________^ [INFO] [stdout] 174 | | || (dest_compressed && args.hash_options.hash_uncompressed) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 173 - let dest_data = if (dest_compressed && args.hash_options.decompress) [INFO] [stdout] 174 - || (dest_compressed && args.hash_options.hash_uncompressed) [INFO] [stdout] 173 + let dest_data = if !(!dest_compressed || !args.hash_options.decompress && !args.hash_options.hash_uncompressed) [INFO] [stdout] | [INFO] [stdout] 173 - let dest_data = if (dest_compressed && args.hash_options.decompress) [INFO] [stdout] 174 - || (dest_compressed && args.hash_options.hash_uncompressed) [INFO] [stdout] 173 + let dest_data = if (args.hash_options.hash_uncompressed || args.hash_options.decompress) && dest_compressed [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands/copy.rs:147:26 [INFO] [stdout] | [INFO] [stdout] 147 | let source_data = if (source_compressed && args.hash_options.decompress) [INFO] [stdout] | __________________________^ [INFO] [stdout] 148 | | || (source_compressed && args.hash_options.hash_uncompressed) [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 147 - let source_data = if (source_compressed && args.hash_options.decompress) [INFO] [stdout] 148 - || (source_compressed && args.hash_options.hash_uncompressed) [INFO] [stdout] 147 + let source_data = if !(!source_compressed || !args.hash_options.decompress && !args.hash_options.hash_uncompressed) [INFO] [stdout] | [INFO] [stdout] 147 - let source_data = if (source_compressed && args.hash_options.decompress) [INFO] [stdout] 148 - || (source_compressed && args.hash_options.hash_uncompressed) [INFO] [stdout] 147 + let source_data = if (args.hash_options.hash_uncompressed || args.hash_options.decompress) && source_compressed [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands/copy.rs:173:24 [INFO] [stdout] | [INFO] [stdout] 173 | let dest_data = if (dest_compressed && args.hash_options.decompress) [INFO] [stdout] | ________________________^ [INFO] [stdout] 174 | | || (dest_compressed && args.hash_options.hash_uncompressed) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 173 - let dest_data = if (dest_compressed && args.hash_options.decompress) [INFO] [stdout] 174 - || (dest_compressed && args.hash_options.hash_uncompressed) [INFO] [stdout] 173 + let dest_data = if !(!dest_compressed || !args.hash_options.decompress && !args.hash_options.hash_uncompressed) [INFO] [stdout] | [INFO] [stdout] 173 - let dest_data = if (dest_compressed && args.hash_options.decompress) [INFO] [stdout] 174 - || (dest_compressed && args.hash_options.hash_uncompressed) [INFO] [stdout] 173 + let dest_data = if (args.hash_options.hash_uncompressed || args.hash_options.decompress) && dest_compressed [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/hash.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | &config, [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/hash.rs:33:68 [INFO] [stdout] | [INFO] [stdout] 33 | output::process_directory(&input_path, &args.hash_options, &config).await [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/verify.rs:107:40 [INFO] [stdout] | [INFO] [stdout] 107 | .unwrap_or_else(|| hex::encode(&Vec::new())); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `Vec::new()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/compression.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | / path.extension() [INFO] [stdout] 11 | | .map_or(false, |ext| ext == self.extension().trim_start_matches('.')) [INFO] [stdout] | |_________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 11 - .map_or(false, |ext| ext == self.extension().trim_start_matches('.')) [INFO] [stdout] 11 + .is_some_and(|ext| ext == self.extension().trim_start_matches('.')) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant slicing of the whole range [INFO] [stdout] --> src/compression.rs:63:22 [INFO] [stdout] | [INFO] [stdout] 63 | let mut reader = &bytes[..]; [INFO] [stdout] | ^^^^^^^^^^ help: use the original value instead: `bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing [INFO] [stdout] = note: `#[warn(clippy::redundant_slicing)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant slicing of the whole range [INFO] [stdout] --> src/compression.rs:71:22 [INFO] [stdout] | [INFO] [stdout] 71 | let mut reader = &bytes[..]; [INFO] [stdout] | ^^^^^^^^^^ help: use the original value instead: `bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/hash.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | &config, [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/hash.rs:33:68 [INFO] [stdout] | [INFO] [stdout] 33 | output::process_directory(&input_path, &args.hash_options, &config).await [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/verify.rs:107:40 [INFO] [stdout] | [INFO] [stdout] 107 | .unwrap_or_else(|| hex::encode(&Vec::new())); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `Vec::new()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/compression.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | / path.extension() [INFO] [stdout] 11 | | .map_or(false, |ext| ext == self.extension().trim_start_matches('.')) [INFO] [stdout] | |_________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 11 - .map_or(false, |ext| ext == self.extension().trim_start_matches('.')) [INFO] [stdout] 11 + .is_some_and(|ext| ext == self.extension().trim_start_matches('.')) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant slicing of the whole range [INFO] [stdout] --> src/compression.rs:63:22 [INFO] [stdout] | [INFO] [stdout] 63 | let mut reader = &bytes[..]; [INFO] [stdout] | ^^^^^^^^^^ help: use the original value instead: `bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing [INFO] [stdout] = note: `#[warn(clippy::redundant_slicing)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant slicing of the whole range [INFO] [stdout] --> src/compression.rs:71:22 [INFO] [stdout] | [INFO] [stdout] 71 | let mut reader = &bytes[..]; [INFO] [stdout] | ^^^^^^^^^^ help: use the original value instead: `bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/database.rs:128:17 [INFO] [stdout] | [INFO] [stdout] 128 | / if let Some(hash) = hash { [INFO] [stdout] 129 | | if !hash.is_empty() { [INFO] [stdout] 130 | | results.push((name.to_string(), (size, hash))); [INFO] [stdout] 131 | | } [INFO] [stdout] 132 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/database.rs:127:23 [INFO] [stdout] | [INFO] [stdout] 127 | if let Ok(hash) = row.try_get::>, _>(name) { [INFO] [stdout] | ^^^^ replace this binding [INFO] [stdout] 128 | if let Some(hash) = hash { [INFO] [stdout] | ^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/downloader.rs:72:22 [INFO] [stdout] | [INFO] [stdout] 72 | .map_err(|e| io::Error::new(io::ErrorKind::Other, e))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 72 - .map_err(|e| io::Error::new(io::ErrorKind::Other, e))? [INFO] [stdout] 72 + .map_err(|e| io::Error::other(e))? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/downloader.rs:97:16 [INFO] [stdout] | [INFO] [stdout] 97 | if downloaded % (5 * 1024 * 1024) == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `downloaded.is_multiple_of(5 * 1024 * 1024)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/downloader.rs:212:20 [INFO] [stdout] | [INFO] [stdout] 212 | let filename = url.split('/').last().unwrap_or("download"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 212 - let filename = url.split('/').last().unwrap_or("download"); [INFO] [stdout] 212 + let filename = url.split('/').next_back().unwrap_or("download"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/output.rs:261:5 [INFO] [stdout] | [INFO] [stdout] 261 | / for entry in walker { [INFO] [stdout] 262 | | if let Ok(entry) = entry { [INFO] [stdout] 263 | | if !entry.path().is_dir() { [INFO] [stdout] 264 | | file_count += 1; [INFO] [stdout] ... | [INFO] [stdout] 269 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/output.rs:262:9 [INFO] [stdout] | [INFO] [stdout] 262 | / if let Ok(entry) = entry { [INFO] [stdout] 263 | | if !entry.path().is_dir() { [INFO] [stdout] 264 | | file_count += 1; [INFO] [stdout] 265 | | last_hash_info = [INFO] [stdout] ... | [INFO] [stdout] 268 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 261 ~ for entry in walker.into_iter().flatten() { [INFO] [stdout] 262 + if !entry.path().is_dir() { [INFO] [stdout] 263 + file_count += 1; [INFO] [stdout] 264 + last_hash_info = [INFO] [stdout] 265 + process_single_file(entry.path(), config, args, &mut db_conn).await?; [INFO] [stdout] 266 + } [INFO] [stdout] 267 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/database.rs:128:17 [INFO] [stdout] | [INFO] [stdout] 128 | / if let Some(hash) = hash { [INFO] [stdout] 129 | | if !hash.is_empty() { [INFO] [stdout] 130 | | results.push((name.to_string(), (size, hash))); [INFO] [stdout] 131 | | } [INFO] [stdout] 132 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/database.rs:127:23 [INFO] [stdout] | [INFO] [stdout] 127 | if let Ok(hash) = row.try_get::>, _>(name) { [INFO] [stdout] | ^^^^ replace this binding [INFO] [stdout] 128 | if let Some(hash) = hash { [INFO] [stdout] | ^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/downloader.rs:72:22 [INFO] [stdout] | [INFO] [stdout] 72 | .map_err(|e| io::Error::new(io::ErrorKind::Other, e))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 72 - .map_err(|e| io::Error::new(io::ErrorKind::Other, e))? [INFO] [stdout] 72 + .map_err(|e| io::Error::other(e))? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/downloader.rs:97:16 [INFO] [stdout] | [INFO] [stdout] 97 | if downloaded % (5 * 1024 * 1024) == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `downloaded.is_multiple_of(5 * 1024 * 1024)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/downloader.rs:212:20 [INFO] [stdout] | [INFO] [stdout] 212 | let filename = url.split('/').last().unwrap_or("download"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 212 - let filename = url.split('/').last().unwrap_or("download"); [INFO] [stdout] 212 + let filename = url.split('/').next_back().unwrap_or("download"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/output.rs:261:5 [INFO] [stdout] | [INFO] [stdout] 261 | / for entry in walker { [INFO] [stdout] 262 | | if let Ok(entry) = entry { [INFO] [stdout] 263 | | if !entry.path().is_dir() { [INFO] [stdout] 264 | | file_count += 1; [INFO] [stdout] ... | [INFO] [stdout] 269 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/output.rs:262:9 [INFO] [stdout] | [INFO] [stdout] 262 | / if let Ok(entry) = entry { [INFO] [stdout] 263 | | if !entry.path().is_dir() { [INFO] [stdout] 264 | | file_count += 1; [INFO] [stdout] 265 | | last_hash_info = [INFO] [stdout] ... | [INFO] [stdout] 268 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 261 ~ for entry in walker.into_iter().flatten() { [INFO] [stdout] 262 + if !entry.path().is_dir() { [INFO] [stdout] 263 + file_count += 1; [INFO] [stdout] 264 + last_hash_info = [INFO] [stdout] 265 + process_single_file(entry.path(), config, args, &mut db_conn).await?; [INFO] [stdout] 266 + } [INFO] [stdout] 267 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 49s [INFO] running `Command { std: "docker" "inspect" "d22d557dfbf86f0f7f6c4bc5a7b02291e40e25ac14a4bb088737020987246484", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d22d557dfbf86f0f7f6c4bc5a7b02291e40e25ac14a4bb088737020987246484", kill_on_drop: false }` [INFO] [stdout] d22d557dfbf86f0f7f6c4bc5a7b02291e40e25ac14a4bb088737020987246484