[INFO] cloning repository https://github.com/medelman17/language-virtual-machine [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/medelman17/language-virtual-machine" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmedelman17%2Flanguage-virtual-machine", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmedelman17%2Flanguage-virtual-machine'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d7e96f1fd32cf05e4809750c4f4ec3a3a599c6bc [INFO] linting medelman17/language-virtual-machine against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmedelman17%2Flanguage-virtual-machine" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/medelman17/language-virtual-machine [INFO] finished tweaking git repo https://github.com/medelman17/language-virtual-machine [INFO] tweaked toml for git repo https://github.com/medelman17/language-virtual-machine written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/medelman17/language-virtual-machine on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/medelman17/language-virtual-machine already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serde_json v1.0.69 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 64a32df37accdbc89d935e1db18438cdba151ca29b8e3126cf2f81e05f3b308d [INFO] running `Command { std: "docker" "start" "-a" "64a32df37accdbc89d935e1db18438cdba151ca29b8e3126cf2f81e05f3b308d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "64a32df37accdbc89d935e1db18438cdba151ca29b8e3126cf2f81e05f3b308d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "64a32df37accdbc89d935e1db18438cdba151ca29b8e3126cf2f81e05f3b308d", kill_on_drop: false }` [INFO] [stdout] 64a32df37accdbc89d935e1db18438cdba151ca29b8e3126cf2f81e05f3b308d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2562f854cc00362cdbafa9c3e79d7b95315c3aed3bdd80858ad9daad2ac6c0d5 [INFO] running `Command { std: "docker" "start" "-a" "2562f854cc00362cdbafa9c3e79d7b95315c3aed3bdd80858ad9daad2ac6c0d5", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.107 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling semver v1.0.4 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling proc-macro2 v1.0.32 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Compiling syn v1.0.81 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Compiling cast v0.2.7 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Compiling serde_json v1.0.69 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Compiling nom v4.2.3 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking plotters-backend v0.3.2 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking plotters-svg v0.3.1 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking itertools v0.10.1 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking criterion-plot v0.4.4 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Checking plotters v0.3.1 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking criterion v0.3.5 [INFO] [stderr] Checking iridium v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/assembler/program_parsers.rs:26:17 [INFO] [stdout] | [INFO] [stdout] 26 | instructions: instructions [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instructions` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/assembler/symbols.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/assembler/symbols.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | symbol_type: symbol_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `symbol_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/assembler/symbols.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 62 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/assembler/symbols.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | symbol_type: symbol_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `symbol_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/instruction.rs:109:23 [INFO] [stdout] | [INFO] [stdout] 109 | Instruction { opcode: opcode } [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `buf` is never read [INFO] [stdout] --> src/assembler/mod.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 38 | pub struct Assembler { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 48 | buf: [u8; 4], [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Assembler` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `symbol_type` is never read [INFO] [stdout] --> src/assembler/symbols.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 45 | pub struct Symbol { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 48 | symbol_type: SymbolType, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Symbol` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `at` and `application_id` are never read [INFO] [stdout] --> src/vm.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 40 | pub struct VMEvent { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 41 | pub event: VMEventType, [INFO] [stdout] 42 | at: DateTime, [INFO] [stdout] | ^^ [INFO] [stdout] 43 | application_id: Uuid, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VMEvent` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/assembler/instruction_parsers.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | return results; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return results; [INFO] [stdout] 64 + results [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> src/assembler/instruction_parsers.rs:42:41 [INFO] [stdout] | [INFO] [stdout] 42 | Some(Token::Op { code }) => match code { [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 43 | | _ => { [INFO] [stdout] 44 | | results.push(code as u8); [INFO] [stdout] 45 | | } [INFO] [stdout] 46 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 42 ~ Some(Token::Op { code }) => { [INFO] [stdout] 43 + results.push(code as u8); [INFO] [stdout] 44 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | / match operand { [INFO] [stdout] 55 | | Some(t) => AssemblerInstruction::extract_operand(t, &mut results, symbols), [INFO] [stdout] 56 | | None => {} [INFO] [stdout] 57 | | } [INFO] [stdout] | |_____________^ help: try: `if let Some(t) = operand { AssemblerInstruction::extract_operand(t, &mut results, symbols) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:86:39 [INFO] [stdout] | [INFO] [stdout] 86 | Token::Op { code } => match code { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 87 | | instruction::Opcode::LOAD => { [INFO] [stdout] 88 | | if let Some(ref first_half) = self.operand_two { [INFO] [stdout] 89 | | match first_half { [INFO] [stdout] ... | [INFO] [stdout] 106 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/assembler/instruction_parsers.rs:86:29 [INFO] [stdout] | [INFO] [stdout] 86 | Token::Op { code } => match code { [INFO] [stdout] | ^^^^ replace this binding [INFO] [stdout] 87 | instruction::Opcode::LOAD => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern, prefixed by `code: ` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:127:36 [INFO] [stdout] | [INFO] [stdout] 127 | Some(ref reg_token) => match reg_token { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 128 | | Token::Register { ref reg_num } => Some(reg_num.clone()), [INFO] [stdout] 129 | | _ => None, [INFO] [stdout] 130 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/assembler/instruction_parsers.rs:127:18 [INFO] [stdout] | [INFO] [stdout] 127 | Some(ref reg_token) => match reg_token { [INFO] [stdout] | ^^^^^^^^^^^^^ replace this binding [INFO] [stdout] 128 | Token::Register { ref reg_num } => Some(reg_num.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/assembler/instruction_parsers.rs:128:57 [INFO] [stdout] | [INFO] [stdout] 128 | Token::Register { ref reg_num } => Some(reg_num.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*reg_num` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:145:24 [INFO] [stdout] | [INFO] [stdout] 145 | Some(d) => match d { [INFO] [stdout] | ________________________^ [INFO] [stdout] 146 | | Token::Directive { name } => Some(name.to_string()), [INFO] [stdout] 147 | | _ => None, [INFO] [stdout] 148 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/assembler/instruction_parsers.rs:145:18 [INFO] [stdout] | [INFO] [stdout] 145 | Some(d) => match d { [INFO] [stdout] | ^ replace this binding [INFO] [stdout] 146 | Token::Directive { name } => Some(name.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:155:24 [INFO] [stdout] | [INFO] [stdout] 155 | Some(d) => match d { [INFO] [stdout] | ________________________^ [INFO] [stdout] 156 | | Token::IrString { name } => Some(name.to_string()), [INFO] [stdout] 157 | | _ => None, [INFO] [stdout] 158 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/assembler/instruction_parsers.rs:155:18 [INFO] [stdout] | [INFO] [stdout] 155 | Some(d) => match d { [INFO] [stdout] | ^ replace this binding [INFO] [stdout] 156 | Token::IrString { name } => Some(name.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:165:24 [INFO] [stdout] | [INFO] [stdout] 165 | Some(d) => match d { [INFO] [stdout] | ________________________^ [INFO] [stdout] 166 | | Token::IntegerOperand { value } => Some(*value), [INFO] [stdout] 167 | | _ => None, [INFO] [stdout] 168 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/assembler/instruction_parsers.rs:165:18 [INFO] [stdout] | [INFO] [stdout] 165 | Some(d) => match d { [INFO] [stdout] | ^ replace this binding [INFO] [stdout] 166 | Token::IntegerOperand { value } => Some(*value), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:175:24 [INFO] [stdout] | [INFO] [stdout] 175 | Some(l) => match l { [INFO] [stdout] | ________________________^ [INFO] [stdout] 176 | | Token::LabelDeclaration { name } => Some(name.clone()), [INFO] [stdout] 177 | | _ => None, [INFO] [stdout] 178 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/assembler/instruction_parsers.rs:175:18 [INFO] [stdout] | [INFO] [stdout] 175 | Some(l) => match l { [INFO] [stdout] | ^ replace this binding [INFO] [stdout] 176 | Token::LabelDeclaration { name } => Some(name.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/assembler/mod.rs:109:25 [INFO] [stdout] | [INFO] [stdout] 109 | header.push(byte.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `byte` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/assembler/mod.rs:113:25 [INFO] [stdout] | [INFO] [stdout] 113 | header.push(0 as u8); [INFO] [stdout] | ^^^^^^^ help: try: `0_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/assembler/mod.rs:160:52 [INFO] [stdout] | [INFO] [stdout] 160 | self.process_label_declaration(&i); [INFO] [stdout] | ^^ help: change this to: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/assembler/mod.rs:256:21 [INFO] [stdout] | [INFO] [stdout] 256 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 255 - }); [INFO] [stdout] 256 - return; [INFO] [stdout] 255 + }); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/assembler/mod.rs:317:1 [INFO] [stdout] | [INFO] [stdout] 317 | / impl Default for AssemblerPhase { [INFO] [stdout] 318 | | fn default() -> Self { [INFO] [stdout] 319 | | AssemblerPhase::First [INFO] [stdout] 320 | | } [INFO] [stdout] 321 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 312 + #[derive(Default)] [INFO] [stdout] 313 | pub enum AssemblerPhase { [INFO] [stdout] 314 ~ #[default] [INFO] [stdout] 315 ~ First, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/assembler/mod.rs:330:1 [INFO] [stdout] | [INFO] [stdout] 330 | / impl Default for AssemblerSection { [INFO] [stdout] 331 | | fn default() -> Self { [INFO] [stdout] 332 | | AssemblerSection::Unknown [INFO] [stdout] 333 | | } [INFO] [stdout] 334 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 324 + #[derive(Default)] [INFO] [stdout] 325 | pub enum AssemblerSection { [INFO] [stdout] 326 | Data { starting_instruction: Option }, [INFO] [stdout] 327 | Code { starting_instruction: Option }, [INFO] [stdout] 328 ~ #[default] [INFO] [stdout] 329 ~ Unknown, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/assembler/mod.rs:336:6 [INFO] [stdout] | [INFO] [stdout] 336 | impl<'a> From<&'a str> for AssemblerSection { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 336 - impl<'a> From<&'a str> for AssemblerSection { [INFO] [stdout] 336 + impl From<&str> for AssemblerSection { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:40:18 [INFO] [stdout] | [INFO] [stdout] 40 | 0 => return Opcode::LOAD, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - 0 => return Opcode::LOAD, [INFO] [stdout] 40 + 0 => Opcode::LOAD, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:41:18 [INFO] [stdout] | [INFO] [stdout] 41 | 1 => return Opcode::ADD, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - 1 => return Opcode::ADD, [INFO] [stdout] 41 + 1 => Opcode::ADD, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:42:18 [INFO] [stdout] | [INFO] [stdout] 42 | 2 => return Opcode::SUB, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - 2 => return Opcode::SUB, [INFO] [stdout] 42 + 2 => Opcode::SUB, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:43:18 [INFO] [stdout] | [INFO] [stdout] 43 | 3 => return Opcode::MUL, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - 3 => return Opcode::MUL, [INFO] [stdout] 43 + 3 => Opcode::MUL, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:44:18 [INFO] [stdout] | [INFO] [stdout] 44 | 4 => return Opcode::DIV, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - 4 => return Opcode::DIV, [INFO] [stdout] 44 + 4 => Opcode::DIV, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:45:18 [INFO] [stdout] | [INFO] [stdout] 45 | 5 => return Opcode::HLT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - 5 => return Opcode::HLT, [INFO] [stdout] 45 + 5 => Opcode::HLT, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:46:18 [INFO] [stdout] | [INFO] [stdout] 46 | 6 => return Opcode::JMP, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - 6 => return Opcode::JMP, [INFO] [stdout] 46 + 6 => Opcode::JMP, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:47:18 [INFO] [stdout] | [INFO] [stdout] 47 | 7 => return Opcode::JMPF, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - 7 => return Opcode::JMPF, [INFO] [stdout] 47 + 7 => Opcode::JMPF, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:48:18 [INFO] [stdout] | [INFO] [stdout] 48 | 8 => return Opcode::JMPB, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - 8 => return Opcode::JMPB, [INFO] [stdout] 48 + 8 => Opcode::JMPB, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:49:18 [INFO] [stdout] | [INFO] [stdout] 49 | 9 => return Opcode::EQ, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - 9 => return Opcode::EQ, [INFO] [stdout] 49 + 9 => Opcode::EQ, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:50:19 [INFO] [stdout] | [INFO] [stdout] 50 | 10 => return Opcode::NEQ, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 - 10 => return Opcode::NEQ, [INFO] [stdout] 50 + 10 => Opcode::NEQ, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:51:19 [INFO] [stdout] | [INFO] [stdout] 51 | 11 => return Opcode::GTQ, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - 11 => return Opcode::GTQ, [INFO] [stdout] 51 + 11 => Opcode::GTQ, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:52:19 [INFO] [stdout] | [INFO] [stdout] 52 | 12 => return Opcode::LTQ, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - 12 => return Opcode::LTQ, [INFO] [stdout] 52 + 12 => Opcode::LTQ, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:53:19 [INFO] [stdout] | [INFO] [stdout] 53 | 13 => return Opcode::LT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - 13 => return Opcode::LT, [INFO] [stdout] 53 + 13 => Opcode::LT, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:54:19 [INFO] [stdout] | [INFO] [stdout] 54 | 14 => return Opcode::GT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - 14 => return Opcode::GT, [INFO] [stdout] 54 + 14 => Opcode::GT, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:55:19 [INFO] [stdout] | [INFO] [stdout] 55 | 15 => return Opcode::JEQ, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - 15 => return Opcode::JEQ, [INFO] [stdout] 55 + 15 => Opcode::JEQ, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:56:19 [INFO] [stdout] | [INFO] [stdout] 56 | 16 => return Opcode::JNEQ, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - 16 => return Opcode::JNEQ, [INFO] [stdout] 56 + 16 => Opcode::JNEQ, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:57:19 [INFO] [stdout] | [INFO] [stdout] 57 | 17 => return Opcode::ALOC, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - 17 => return Opcode::ALOC, [INFO] [stdout] 57 + 17 => Opcode::ALOC, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:58:19 [INFO] [stdout] | [INFO] [stdout] 58 | 18 => return Opcode::INC, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - 18 => return Opcode::INC, [INFO] [stdout] 58 + 18 => Opcode::INC, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:59:19 [INFO] [stdout] | [INFO] [stdout] 59 | 19 => return Opcode::DEC, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - 19 => return Opcode::DEC, [INFO] [stdout] 59 + 19 => Opcode::DEC, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:60:19 [INFO] [stdout] | [INFO] [stdout] 60 | 21 => return Opcode::PRTS, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 - 21 => return Opcode::PRTS, [INFO] [stdout] 60 + 21 => Opcode::PRTS, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:61:19 [INFO] [stdout] | [INFO] [stdout] 61 | 39 => return Opcode::LUI, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 - 39 => return Opcode::LUI, [INFO] [stdout] 61 + 39 => Opcode::LUI, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:66:18 [INFO] [stdout] | [INFO] [stdout] 66 | _ => return Opcode::IGL, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 66 - _ => return Opcode::IGL, [INFO] [stdout] 66 + _ => Opcode::IGL, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `REPL` [INFO] [stdout] --> src/repl/mod.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / pub fn new() -> Self { [INFO] [stdout] 22 | | REPL { [INFO] [stdout] 23 | | vm: VirtualMachine::new(), [INFO] [stdout] 24 | | command_buffer: vec![], [INFO] [stdout] ... | [INFO] [stdout] 27 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 20 + impl Default for REPL { [INFO] [stdout] 21 + fn default() -> Self { [INFO] [stdout] 22 + Self::new() [INFO] [stdout] 23 + } [INFO] [stdout] 24 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/repl/mod.rs:90:24 [INFO] [stdout] | [INFO] [stdout] 90 | if !parsed_program.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parsed_program.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/repl/mod.rs:110:43 [INFO] [stdout] | [INFO] [stdout] 110 | let byte = u8::from_str_radix(&hex_string, 16); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `hex_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 16 [INFO] [stdout] --> src/utils/mod.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | c.is_digit(16) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_hexdigit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `VirtualMachine` [INFO] [stdout] --> src/vm.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 77 | / pub fn new() -> Self { [INFO] [stdout] 78 | | VirtualMachine { [INFO] [stdout] 79 | | id: Uuid::new_v4(), [INFO] [stdout] 80 | | events: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 96 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 76 + impl Default for VirtualMachine { [INFO] [stdout] 77 + fn default() -> Self { [INFO] [stdout] 78 + Self::new() [INFO] [stdout] 79 + } [INFO] [stdout] 80 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/vm.rs:99:12 [INFO] [stdout] | [INFO] [stdout] 99 | if alias == "" { [INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `alias.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/vm.rs:196:30 [INFO] [stdout] | [INFO] [stdout] 196 | let number = self.next_sixteen_bits() as u16; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.next_sixteen_bits()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/vm.rs:218:17 [INFO] [stdout] | [INFO] [stdout] 218 | / if register_one == register_two { [INFO] [stdout] 219 | | self.equal_flag = true; [INFO] [stdout] 220 | | } else { [INFO] [stdout] 221 | | self.equal_flag = false; [INFO] [stdout] 222 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `self.equal_flag = register_one == register_two;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] = note: `#[warn(clippy::needless_bool_assign)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:333:9 [INFO] [stdout] | [INFO] [stdout] 333 | return opcode; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 333 - return opcode; [INFO] [stdout] 333 + opcode [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:350:9 [INFO] [stdout] | [INFO] [stdout] 350 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 350 - return result; [INFO] [stdout] 350 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:356:9 [INFO] [stdout] | [INFO] [stdout] 356 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 356 - return result; [INFO] [stdout] 356 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/vm.rs:362:29 [INFO] [stdout] | [INFO] [stdout] 362 | prepension.push(byte.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `byte` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:68:21 [INFO] [stdout] | [INFO] [stdout] 68 | return contents; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - return contents; [INFO] [stdout] 68 + contents [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:53:24 [INFO] [stdout] | [INFO] [stdout] 53 | for operand in vec![&self.operand_one, &self.operand_two, &self.operand_three] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[&self.operand_one, &self.operand_two, &self.operand_three]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/assembler/program_parsers.rs:26:17 [INFO] [stdout] | [INFO] [stdout] 26 | instructions: instructions [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instructions` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/assembler/symbols.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/assembler/symbols.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | symbol_type: symbol_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `symbol_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/assembler/symbols.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 62 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/assembler/symbols.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | symbol_type: symbol_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `symbol_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/instruction.rs:109:23 [INFO] [stdout] | [INFO] [stdout] 109 | Instruction { opcode: opcode } [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `buf` is never read [INFO] [stdout] --> src/assembler/mod.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 38 | pub struct Assembler { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 48 | buf: [u8; 4], [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Assembler` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `symbol_type` is never read [INFO] [stdout] --> src/assembler/symbols.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 45 | pub struct Symbol { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 48 | symbol_type: SymbolType, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Symbol` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `at` and `application_id` are never read [INFO] [stdout] --> src/vm.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 40 | pub struct VMEvent { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 41 | pub event: VMEventType, [INFO] [stdout] 42 | at: DateTime, [INFO] [stdout] | ^^ [INFO] [stdout] 43 | application_id: Uuid, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VMEvent` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/directive_parsers.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 63 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 63 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/directive_parsers.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 76 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 76 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/assembler/instruction_parsers.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | return results; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return results; [INFO] [stdout] 64 + results [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> src/assembler/instruction_parsers.rs:42:41 [INFO] [stdout] | [INFO] [stdout] 42 | Some(Token::Op { code }) => match code { [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 43 | | _ => { [INFO] [stdout] 44 | | results.push(code as u8); [INFO] [stdout] 45 | | } [INFO] [stdout] 46 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 42 ~ Some(Token::Op { code }) => { [INFO] [stdout] 43 + results.push(code as u8); [INFO] [stdout] 44 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | / match operand { [INFO] [stdout] 55 | | Some(t) => AssemblerInstruction::extract_operand(t, &mut results, symbols), [INFO] [stdout] 56 | | None => {} [INFO] [stdout] 57 | | } [INFO] [stdout] | |_____________^ help: try: `if let Some(t) = operand { AssemblerInstruction::extract_operand(t, &mut results, symbols) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:86:39 [INFO] [stdout] | [INFO] [stdout] 86 | Token::Op { code } => match code { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 87 | | instruction::Opcode::LOAD => { [INFO] [stdout] 88 | | if let Some(ref first_half) = self.operand_two { [INFO] [stdout] 89 | | match first_half { [INFO] [stdout] ... | [INFO] [stdout] 106 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/assembler/instruction_parsers.rs:86:29 [INFO] [stdout] | [INFO] [stdout] 86 | Token::Op { code } => match code { [INFO] [stdout] | ^^^^ replace this binding [INFO] [stdout] 87 | instruction::Opcode::LOAD => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern, prefixed by `code: ` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:127:36 [INFO] [stdout] | [INFO] [stdout] 127 | Some(ref reg_token) => match reg_token { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 128 | | Token::Register { ref reg_num } => Some(reg_num.clone()), [INFO] [stdout] 129 | | _ => None, [INFO] [stdout] 130 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/assembler/instruction_parsers.rs:127:18 [INFO] [stdout] | [INFO] [stdout] 127 | Some(ref reg_token) => match reg_token { [INFO] [stdout] | ^^^^^^^^^^^^^ replace this binding [INFO] [stdout] 128 | Token::Register { ref reg_num } => Some(reg_num.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/assembler/instruction_parsers.rs:128:57 [INFO] [stdout] | [INFO] [stdout] 128 | Token::Register { ref reg_num } => Some(reg_num.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*reg_num` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:145:24 [INFO] [stdout] | [INFO] [stdout] 145 | Some(d) => match d { [INFO] [stdout] | ________________________^ [INFO] [stdout] 146 | | Token::Directive { name } => Some(name.to_string()), [INFO] [stdout] 147 | | _ => None, [INFO] [stdout] 148 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/assembler/instruction_parsers.rs:145:18 [INFO] [stdout] | [INFO] [stdout] 145 | Some(d) => match d { [INFO] [stdout] | ^ replace this binding [INFO] [stdout] 146 | Token::Directive { name } => Some(name.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:155:24 [INFO] [stdout] | [INFO] [stdout] 155 | Some(d) => match d { [INFO] [stdout] | ________________________^ [INFO] [stdout] 156 | | Token::IrString { name } => Some(name.to_string()), [INFO] [stdout] 157 | | _ => None, [INFO] [stdout] 158 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/assembler/instruction_parsers.rs:155:18 [INFO] [stdout] | [INFO] [stdout] 155 | Some(d) => match d { [INFO] [stdout] | ^ replace this binding [INFO] [stdout] 156 | Token::IrString { name } => Some(name.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:165:24 [INFO] [stdout] | [INFO] [stdout] 165 | Some(d) => match d { [INFO] [stdout] | ________________________^ [INFO] [stdout] 166 | | Token::IntegerOperand { value } => Some(*value), [INFO] [stdout] 167 | | _ => None, [INFO] [stdout] 168 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/assembler/instruction_parsers.rs:165:18 [INFO] [stdout] | [INFO] [stdout] 165 | Some(d) => match d { [INFO] [stdout] | ^ replace this binding [INFO] [stdout] 166 | Token::IntegerOperand { value } => Some(*value), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:175:24 [INFO] [stdout] | [INFO] [stdout] 175 | Some(l) => match l { [INFO] [stdout] | ________________________^ [INFO] [stdout] 176 | | Token::LabelDeclaration { name } => Some(name.clone()), [INFO] [stdout] 177 | | _ => None, [INFO] [stdout] 178 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/assembler/instruction_parsers.rs:175:18 [INFO] [stdout] | [INFO] [stdout] 175 | Some(l) => match l { [INFO] [stdout] | ^ replace this binding [INFO] [stdout] 176 | Token::LabelDeclaration { name } => Some(name.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/label_parsers.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 38 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 38 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/label_parsers.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | assert_eq!(result.is_ok(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 47 - assert_eq!(result.is_ok(), false); [INFO] [stdout] 47 + assert!(!result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/label_parsers.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 53 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 53 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/label_parsers.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | assert_eq!(result.is_ok(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 62 - assert_eq!(result.is_ok(), false); [INFO] [stdout] 62 + assert!(!result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/opcode_parsers.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 27 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 27 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/operand_parsers.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 40 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 40 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/operand_parsers.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | assert_eq!(result.is_ok(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 47 - assert_eq!(result.is_ok(), false); [INFO] [stdout] 47 + assert!(!result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/operand_parsers.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 53 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 53 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/program_parsers.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 39 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 39 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/program_parsers.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 48 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 48 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/program_parsers.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 59 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 59 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/register_parsers.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 28 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 28 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/register_parsers.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | assert_eq!(result.is_ok(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 30 - assert_eq!(result.is_ok(), false); [INFO] [stdout] 30 + assert!(!result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/register_parsers.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | assert_eq!(result.is_ok(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 32 - assert_eq!(result.is_ok(), false); [INFO] [stdout] 32 + assert!(!result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/symbols.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | assert_eq!(true, v.is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 87 - assert_eq!(true, v.is_some()); [INFO] [stdout] 87 + assert!(v.is_some()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/symbols.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | assert_eq!(v.is_some(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 91 - assert_eq!(v.is_some(), false); [INFO] [stdout] 91 + assert!(!v.is_some()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/assembler/mod.rs:109:25 [INFO] [stdout] | [INFO] [stdout] 109 | header.push(byte.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `byte` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/assembler/mod.rs:113:25 [INFO] [stdout] | [INFO] [stdout] 113 | header.push(0 as u8); [INFO] [stdout] | ^^^^^^^ help: try: `0_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/assembler/mod.rs:160:52 [INFO] [stdout] | [INFO] [stdout] 160 | self.process_label_declaration(&i); [INFO] [stdout] | ^^ help: change this to: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/assembler/mod.rs:256:21 [INFO] [stdout] | [INFO] [stdout] 256 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 255 - }); [INFO] [stdout] 256 - return; [INFO] [stdout] 255 + }); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/assembler/mod.rs:317:1 [INFO] [stdout] | [INFO] [stdout] 317 | / impl Default for AssemblerPhase { [INFO] [stdout] 318 | | fn default() -> Self { [INFO] [stdout] 319 | | AssemblerPhase::First [INFO] [stdout] 320 | | } [INFO] [stdout] 321 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 312 + #[derive(Default)] [INFO] [stdout] 313 | pub enum AssemblerPhase { [INFO] [stdout] 314 ~ #[default] [INFO] [stdout] 315 ~ First, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/assembler/mod.rs:330:1 [INFO] [stdout] | [INFO] [stdout] 330 | / impl Default for AssemblerSection { [INFO] [stdout] 331 | | fn default() -> Self { [INFO] [stdout] 332 | | AssemblerSection::Unknown [INFO] [stdout] 333 | | } [INFO] [stdout] 334 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 324 + #[derive(Default)] [INFO] [stdout] 325 | pub enum AssemblerSection { [INFO] [stdout] 326 | Data { starting_instruction: Option }, [INFO] [stdout] 327 | Code { starting_instruction: Option }, [INFO] [stdout] 328 ~ #[default] [INFO] [stdout] 329 ~ Unknown, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/assembler/mod.rs:336:6 [INFO] [stdout] | [INFO] [stdout] 336 | impl<'a> From<&'a str> for AssemblerSection { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 336 - impl<'a> From<&'a str> for AssemblerSection { [INFO] [stdout] 336 + impl From<&str> for AssemblerSection { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/mod.rs:384:9 [INFO] [stdout] | [INFO] [stdout] 384 | assert_eq!(true, v.is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 384 - assert_eq!(true, v.is_some()); [INFO] [stdout] 384 + assert!(v.is_some()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/mod.rs:388:9 [INFO] [stdout] | [INFO] [stdout] 388 | assert_eq!(v.is_some(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 388 - assert_eq!(v.is_some(), false); [INFO] [stdout] 388 + assert!(!v.is_some()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/mod.rs:449:9 [INFO] [stdout] | [INFO] [stdout] 449 | assert_eq!(program.is_ok(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 449 - assert_eq!(program.is_ok(), false); [INFO] [stdout] 449 + assert!(!program.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/mod.rs:458:9 [INFO] [stdout] | [INFO] [stdout] 458 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 458 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 458 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/mod.rs:473:9 [INFO] [stdout] | [INFO] [stdout] 473 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 473 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 473 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:40:18 [INFO] [stdout] | [INFO] [stdout] 40 | 0 => return Opcode::LOAD, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - 0 => return Opcode::LOAD, [INFO] [stdout] 40 + 0 => Opcode::LOAD, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:41:18 [INFO] [stdout] | [INFO] [stdout] 41 | 1 => return Opcode::ADD, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - 1 => return Opcode::ADD, [INFO] [stdout] 41 + 1 => Opcode::ADD, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:42:18 [INFO] [stdout] | [INFO] [stdout] 42 | 2 => return Opcode::SUB, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - 2 => return Opcode::SUB, [INFO] [stdout] 42 + 2 => Opcode::SUB, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:43:18 [INFO] [stdout] | [INFO] [stdout] 43 | 3 => return Opcode::MUL, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - 3 => return Opcode::MUL, [INFO] [stdout] 43 + 3 => Opcode::MUL, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:44:18 [INFO] [stdout] | [INFO] [stdout] 44 | 4 => return Opcode::DIV, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - 4 => return Opcode::DIV, [INFO] [stdout] 44 + 4 => Opcode::DIV, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:45:18 [INFO] [stdout] | [INFO] [stdout] 45 | 5 => return Opcode::HLT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - 5 => return Opcode::HLT, [INFO] [stdout] 45 + 5 => Opcode::HLT, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:46:18 [INFO] [stdout] | [INFO] [stdout] 46 | 6 => return Opcode::JMP, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - 6 => return Opcode::JMP, [INFO] [stdout] 46 + 6 => Opcode::JMP, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:47:18 [INFO] [stdout] | [INFO] [stdout] 47 | 7 => return Opcode::JMPF, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - 7 => return Opcode::JMPF, [INFO] [stdout] 47 + 7 => Opcode::JMPF, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:48:18 [INFO] [stdout] | [INFO] [stdout] 48 | 8 => return Opcode::JMPB, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - 8 => return Opcode::JMPB, [INFO] [stdout] 48 + 8 => Opcode::JMPB, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:49:18 [INFO] [stdout] | [INFO] [stdout] 49 | 9 => return Opcode::EQ, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - 9 => return Opcode::EQ, [INFO] [stdout] 49 + 9 => Opcode::EQ, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:50:19 [INFO] [stdout] | [INFO] [stdout] 50 | 10 => return Opcode::NEQ, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 - 10 => return Opcode::NEQ, [INFO] [stdout] 50 + 10 => Opcode::NEQ, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:51:19 [INFO] [stdout] | [INFO] [stdout] 51 | 11 => return Opcode::GTQ, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - 11 => return Opcode::GTQ, [INFO] [stdout] 51 + 11 => Opcode::GTQ, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:52:19 [INFO] [stdout] | [INFO] [stdout] 52 | 12 => return Opcode::LTQ, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - 12 => return Opcode::LTQ, [INFO] [stdout] 52 + 12 => Opcode::LTQ, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:53:19 [INFO] [stdout] | [INFO] [stdout] 53 | 13 => return Opcode::LT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - 13 => return Opcode::LT, [INFO] [stdout] 53 + 13 => Opcode::LT, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:54:19 [INFO] [stdout] | [INFO] [stdout] 54 | 14 => return Opcode::GT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - 14 => return Opcode::GT, [INFO] [stdout] 54 + 14 => Opcode::GT, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:55:19 [INFO] [stdout] | [INFO] [stdout] 55 | 15 => return Opcode::JEQ, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - 15 => return Opcode::JEQ, [INFO] [stdout] 55 + 15 => Opcode::JEQ, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:56:19 [INFO] [stdout] | [INFO] [stdout] 56 | 16 => return Opcode::JNEQ, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - 16 => return Opcode::JNEQ, [INFO] [stdout] 56 + 16 => Opcode::JNEQ, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:57:19 [INFO] [stdout] | [INFO] [stdout] 57 | 17 => return Opcode::ALOC, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - 17 => return Opcode::ALOC, [INFO] [stdout] 57 + 17 => Opcode::ALOC, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:58:19 [INFO] [stdout] | [INFO] [stdout] 58 | 18 => return Opcode::INC, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - 18 => return Opcode::INC, [INFO] [stdout] 58 + 18 => Opcode::INC, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:59:19 [INFO] [stdout] | [INFO] [stdout] 59 | 19 => return Opcode::DEC, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - 19 => return Opcode::DEC, [INFO] [stdout] 59 + 19 => Opcode::DEC, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:60:19 [INFO] [stdout] | [INFO] [stdout] 60 | 21 => return Opcode::PRTS, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 - 21 => return Opcode::PRTS, [INFO] [stdout] 60 + 21 => Opcode::PRTS, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:61:19 [INFO] [stdout] | [INFO] [stdout] 61 | 39 => return Opcode::LUI, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 - 39 => return Opcode::LUI, [INFO] [stdout] 61 + 39 => Opcode::LUI, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:66:18 [INFO] [stdout] | [INFO] [stdout] 66 | _ => return Opcode::IGL, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 66 - _ => return Opcode::IGL, [INFO] [stdout] 66 + _ => Opcode::IGL, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `REPL` [INFO] [stdout] --> src/repl/mod.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / pub fn new() -> Self { [INFO] [stdout] 22 | | REPL { [INFO] [stdout] 23 | | vm: VirtualMachine::new(), [INFO] [stdout] 24 | | command_buffer: vec![], [INFO] [stdout] ... | [INFO] [stdout] 27 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 20 + impl Default for REPL { [INFO] [stdout] 21 + fn default() -> Self { [INFO] [stdout] 22 + Self::new() [INFO] [stdout] 23 + } [INFO] [stdout] 24 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/repl/mod.rs:90:24 [INFO] [stdout] | [INFO] [stdout] 90 | if !parsed_program.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parsed_program.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/repl/mod.rs:110:43 [INFO] [stdout] | [INFO] [stdout] 110 | let byte = u8::from_str_radix(&hex_string, 16); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `hex_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 16 [INFO] [stdout] --> src/utils/mod.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | c.is_digit(16) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_hexdigit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `VirtualMachine` [INFO] [stdout] --> src/vm.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 77 | / pub fn new() -> Self { [INFO] [stdout] 78 | | VirtualMachine { [INFO] [stdout] 79 | | id: Uuid::new_v4(), [INFO] [stdout] 80 | | events: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 96 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 76 + impl Default for VirtualMachine { [INFO] [stdout] 77 + fn default() -> Self { [INFO] [stdout] 78 + Self::new() [INFO] [stdout] 79 + } [INFO] [stdout] 80 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/vm.rs:99:12 [INFO] [stdout] | [INFO] [stdout] 99 | if alias == "" { [INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `alias.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/vm.rs:196:30 [INFO] [stdout] | [INFO] [stdout] 196 | let number = self.next_sixteen_bits() as u16; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.next_sixteen_bits()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/vm.rs:218:17 [INFO] [stdout] | [INFO] [stdout] 218 | / if register_one == register_two { [INFO] [stdout] 219 | | self.equal_flag = true; [INFO] [stdout] 220 | | } else { [INFO] [stdout] 221 | | self.equal_flag = false; [INFO] [stdout] 222 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `self.equal_flag = register_one == register_two;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] = note: `#[warn(clippy::needless_bool_assign)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:333:9 [INFO] [stdout] | [INFO] [stdout] 333 | return opcode; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 333 - return opcode; [INFO] [stdout] 333 + opcode [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:350:9 [INFO] [stdout] | [INFO] [stdout] 350 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 350 - return result; [INFO] [stdout] 350 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:356:9 [INFO] [stdout] | [INFO] [stdout] 356 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 356 - return result; [INFO] [stdout] 356 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/vm.rs:362:29 [INFO] [stdout] | [INFO] [stdout] 362 | prepension.push(byte.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `byte` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:481:9 [INFO] [stdout] | [INFO] [stdout] 481 | assert_eq!(vm.equal_flag, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 481 - assert_eq!(vm.equal_flag, true); [INFO] [stdout] 481 + assert!(vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:484:9 [INFO] [stdout] | [INFO] [stdout] 484 | assert_eq!(vm.equal_flag, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 484 - assert_eq!(vm.equal_flag, false); [INFO] [stdout] 484 + assert!(!vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:494:9 [INFO] [stdout] | [INFO] [stdout] 494 | assert_eq!(vm.equal_flag, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 494 - assert_eq!(vm.equal_flag, true); [INFO] [stdout] 494 + assert!(vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:497:9 [INFO] [stdout] | [INFO] [stdout] 497 | assert_eq!(vm.equal_flag, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 497 - assert_eq!(vm.equal_flag, false); [INFO] [stdout] 497 + assert!(!vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:507:9 [INFO] [stdout] | [INFO] [stdout] 507 | assert_eq!(vm.equal_flag, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 507 - assert_eq!(vm.equal_flag, true); [INFO] [stdout] 507 + assert!(vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:510:9 [INFO] [stdout] | [INFO] [stdout] 510 | assert_eq!(vm.equal_flag, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 510 - assert_eq!(vm.equal_flag, false); [INFO] [stdout] 510 + assert!(!vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:513:9 [INFO] [stdout] | [INFO] [stdout] 513 | assert_eq!(vm.equal_flag, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 513 - assert_eq!(vm.equal_flag, false); [INFO] [stdout] 513 + assert!(!vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:523:9 [INFO] [stdout] | [INFO] [stdout] 523 | assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 523 - assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] 523 + assert!(test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:526:9 [INFO] [stdout] | [INFO] [stdout] 526 | assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 526 - assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] 526 + assert!(test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:529:9 [INFO] [stdout] | [INFO] [stdout] 529 | assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 529 - assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] 529 + assert!(!test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:539:9 [INFO] [stdout] | [INFO] [stdout] 539 | assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 539 - assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] 539 + assert!(!test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:542:9 [INFO] [stdout] | [INFO] [stdout] 542 | assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 542 - assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] 542 + assert!(test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:545:9 [INFO] [stdout] | [INFO] [stdout] 545 | assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 545 - assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] 545 + assert!(test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:68:21 [INFO] [stdout] | [INFO] [stdout] 68 | return contents; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - return contents; [INFO] [stdout] 68 + contents [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:53:24 [INFO] [stdout] | [INFO] [stdout] 53 | for operand in vec![&self.operand_one, &self.operand_two, &self.operand_three] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[&self.operand_one, &self.operand_two, &self.operand_three]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 31.00s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: criterion v0.3.5, nom v4.2.3 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "2562f854cc00362cdbafa9c3e79d7b95315c3aed3bdd80858ad9daad2ac6c0d5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2562f854cc00362cdbafa9c3e79d7b95315c3aed3bdd80858ad9daad2ac6c0d5", kill_on_drop: false }` [INFO] [stdout] 2562f854cc00362cdbafa9c3e79d7b95315c3aed3bdd80858ad9daad2ac6c0d5