[INFO] cloning repository https://github.com/mdg1019/folder-sync [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/mdg1019/folder-sync" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmdg1019%2Ffolder-sync", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmdg1019%2Ffolder-sync'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 628f446554adac25842ad88aa3be9ccc386fc893 [INFO] linting mdg1019/folder-sync against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmdg1019%2Ffolder-sync" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/mdg1019/folder-sync [INFO] finished tweaking git repo https://github.com/mdg1019/folder-sync [INFO] tweaked toml for git repo https://github.com/mdg1019/folder-sync written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/mdg1019/folder-sync on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/mdg1019/folder-sync already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 203e5868257e0bbb92df43a398ba60e821d8c37ff521d42d085f804620c17da2 [INFO] running `Command { std: "docker" "start" "-a" "203e5868257e0bbb92df43a398ba60e821d8c37ff521d42d085f804620c17da2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "203e5868257e0bbb92df43a398ba60e821d8c37ff521d42d085f804620c17da2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "203e5868257e0bbb92df43a398ba60e821d8c37ff521d42d085f804620c17da2", kill_on_drop: false }` [INFO] [stdout] 203e5868257e0bbb92df43a398ba60e821d8c37ff521d42d085f804620c17da2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b270f707e5119ad6e0125947e8eeef51daa82894c44b20e09e4fffdcc19a5074 [INFO] running `Command { std: "docker" "start" "-a" "b270f707e5119ad6e0125947e8eeef51daa82894c44b20e09e4fffdcc19a5074", kill_on_drop: false }` [INFO] [stderr] Checking folder-sync v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/file_system.rs:57:28 [INFO] [stdout] | [INFO] [stdout] 57 | fs::create_dir_all(&destination_path)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `destination_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/file_system.rs:97:20 [INFO] [stdout] | [INFO] [stdout] 97 | if !fs::metadata(&new_dest_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&new_dest_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/file_system.rs:70:52 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn copy_files(children: &Vec, dest_path: &PathBuf) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 70 - pub fn copy_files(children: &Vec, dest_path: &PathBuf) -> Result<()> { [INFO] [stdout] 70 + pub fn copy_files(children: &Vec, dest_path: &Path) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/file_system.rs:135:25 [INFO] [stdout] | [INFO] [stdout] 135 | / if let Node::Directory { name, children, .. } = src_node { [INFO] [stdout] 136 | | if name == &dest_name { [INFO] [stdout] 137 | | remove_extra_files(children, &dest_path)?; [INFO] [stdout] 138 | | break; [INFO] [stdout] 139 | | } [INFO] [stdout] 140 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 135 ~ if let Node::Directory { name, children, .. } = src_node [INFO] [stdout] 136 ~ && name == &dest_name { [INFO] [stdout] 137 | remove_extra_files(children, &dest_path)?; [INFO] [stdout] 138 | break; [INFO] [stdout] 139 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:3:25 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn parse_args(args: &Vec) -> Result<(Box, Box, bool), String> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - pub fn parse_args(args: &Vec) -> Result<(Box, Box, bool), String> { [INFO] [stdout] 3 + pub fn parse_args(args: &[String]) -> Result<(Box, Box, bool), String> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/utils.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | if source_path.exists() == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!source_path.exists()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/utils.rs:16:20 [INFO] [stdout] | [INFO] [stdout] 16 | return Err(format!("Source folder {} does not exist", source).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("Source folder {} does not exist", source)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/utils.rs:20:20 [INFO] [stdout] | [INFO] [stdout] 20 | return Err(format!("Source {} must be a folder", source).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("Source {} must be a folder", source)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/file_system.rs:57:28 [INFO] [stdout] | [INFO] [stdout] 57 | fs::create_dir_all(&destination_path)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `destination_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/file_system.rs:97:20 [INFO] [stdout] | [INFO] [stdout] 97 | if !fs::metadata(&new_dest_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&new_dest_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/file_system.rs:70:52 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn copy_files(children: &Vec, dest_path: &PathBuf) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 70 - pub fn copy_files(children: &Vec, dest_path: &PathBuf) -> Result<()> { [INFO] [stdout] 70 + pub fn copy_files(children: &Vec, dest_path: &Path) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/file_system.rs:135:25 [INFO] [stdout] | [INFO] [stdout] 135 | / if let Node::Directory { name, children, .. } = src_node { [INFO] [stdout] 136 | | if name == &dest_name { [INFO] [stdout] 137 | | remove_extra_files(children, &dest_path)?; [INFO] [stdout] 138 | | break; [INFO] [stdout] 139 | | } [INFO] [stdout] 140 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 135 ~ if let Node::Directory { name, children, .. } = src_node [INFO] [stdout] 136 ~ && name == &dest_name { [INFO] [stdout] 137 | remove_extra_files(children, &dest_path)?; [INFO] [stdout] 138 | break; [INFO] [stdout] 139 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:3:25 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn parse_args(args: &Vec) -> Result<(Box, Box, bool), String> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - pub fn parse_args(args: &Vec) -> Result<(Box, Box, bool), String> { [INFO] [stdout] 3 + pub fn parse_args(args: &[String]) -> Result<(Box, Box, bool), String> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/utils.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | if source_path.exists() == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!source_path.exists()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/utils.rs:16:20 [INFO] [stdout] | [INFO] [stdout] 16 | return Err(format!("Source folder {} does not exist", source).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("Source folder {} does not exist", source)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/utils.rs:20:20 [INFO] [stdout] | [INFO] [stdout] 20 | return Err(format!("Source {} must be a folder", source).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("Source {} must be a folder", source)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.34s [INFO] running `Command { std: "docker" "inspect" "b270f707e5119ad6e0125947e8eeef51daa82894c44b20e09e4fffdcc19a5074", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b270f707e5119ad6e0125947e8eeef51daa82894c44b20e09e4fffdcc19a5074", kill_on_drop: false }` [INFO] [stdout] b270f707e5119ad6e0125947e8eeef51daa82894c44b20e09e4fffdcc19a5074