[INFO] cloning repository https://github.com/mdelmans/sshlack [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/mdelmans/sshlack" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmdelmans%2Fsshlack", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmdelmans%2Fsshlack'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 74bc1457b8808f9d8192d1e6c3239ff1515c6df4 [INFO] linting mdelmans/sshlack against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmdelmans%2Fsshlack" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/mdelmans/sshlack [INFO] finished tweaking git repo https://github.com/mdelmans/sshlack [INFO] tweaked toml for git repo https://github.com/mdelmans/sshlack written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/mdelmans/sshlack on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/mdelmans/sshlack already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded russh-util v0.52.0 [INFO] [stderr] Downloaded terminal-keycode v1.1.1 [INFO] [stderr] Downloaded ssh-encoding v0.2.0 [INFO] [stderr] Downloaded russh-cryptovec v0.52.0 [INFO] [stderr] Downloaded errno v0.3.12 [INFO] [stderr] Downloaded bcrypt-pbkdf v0.10.0 [INFO] [stderr] Downloaded ssh-cipher v0.2.0 [INFO] [stderr] Downloaded pageant v0.0.3 [INFO] [stderr] Downloaded instability v0.3.7 [INFO] [stderr] Downloaded enum_dispatch v0.3.13 [INFO] [stderr] Downloaded delegate v0.13.3 [INFO] [stderr] Downloaded tracing-attributes v0.1.29 [INFO] [stderr] Downloaded compact_str v0.8.1 [INFO] [stderr] Downloaded bumpalo v3.18.1 [INFO] [stderr] Downloaded russh v0.52.1 [INFO] [stderr] Downloaded cc v1.2.26 [INFO] [stderr] Downloaded internal-russh-forked-ssh-key v0.6.10+upstream-0.6.7 [INFO] [stderr] Downloaded emojic v0.4.1 [INFO] [stderr] Downloaded ratatui v0.29.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 229816e4bcb09f078e3550161f74c84ba02c21bc0fa4dc045f350c632f4d9488 [INFO] running `Command { std: "docker" "start" "-a" "229816e4bcb09f078e3550161f74c84ba02c21bc0fa4dc045f350c632f4d9488", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "229816e4bcb09f078e3550161f74c84ba02c21bc0fa4dc045f350c632f4d9488", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "229816e4bcb09f078e3550161f74c84ba02c21bc0fa4dc045f350c632f4d9488", kill_on_drop: false }` [INFO] [stdout] 229816e4bcb09f078e3550161f74c84ba02c21bc0fa4dc045f350c632f4d9488 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a346bd02500f4bdd49a9dec380badfd4e3c5f8f5eb9f4b26928240c91c744597 [INFO] running `Command { std: "docker" "start" "-a" "a346bd02500f4bdd49a9dec380badfd4e3c5f8f5eb9f4b26928240c91c744597", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.172 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Checking base64ct v1.8.0 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Compiling stable_deref_trait v1.2.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling lock_api v0.4.13 [INFO] [stderr] Compiling syn v2.0.101 [INFO] [stderr] Compiling libm v0.2.15 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling writeable v0.6.1 [INFO] [stderr] Compiling smallvec v1.15.1 [INFO] [stderr] Compiling litemap v0.8.0 [INFO] [stderr] Compiling typenum v1.18.0 [INFO] [stderr] Compiling serde_json v1.0.140 [INFO] [stderr] Compiling zerocopy v0.8.25 [INFO] [stderr] Compiling cc v1.2.26 [INFO] [stderr] Compiling icu_properties_data v2.0.1 [INFO] [stderr] Compiling icu_normalizer_data v2.0.0 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Checking foldhash v0.1.5 [INFO] [stderr] Compiling hashbrown v0.15.3 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking der v0.7.10 [INFO] [stderr] Compiling itoa v1.0.15 [INFO] [stderr] Compiling socket2 v0.5.10 [INFO] [stderr] Compiling mio v1.0.4 [INFO] [stderr] Compiling parking_lot_core v0.9.11 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking block-padding v0.3.3 [INFO] [stderr] Compiling bytes v1.10.1 [INFO] [stderr] Compiling rustversion v1.0.21 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Compiling ryu v1.0.20 [INFO] [stderr] Compiling parking_lot v0.12.4 [INFO] [stderr] Compiling tracing-core v0.1.34 [INFO] [stderr] Checking bitflags v2.9.1 [INFO] [stderr] Compiling log v0.4.27 [INFO] [stderr] Compiling event-listener v5.4.0 [INFO] [stderr] Compiling futures-util v0.3.31 [INFO] [stderr] Compiling futures-intrusive v0.5.0 [INFO] [stderr] Compiling hashlink v0.10.0 [INFO] [stderr] Compiling indexmap v2.9.0 [INFO] [stderr] Compiling crypto-common v0.1.6 [INFO] [stderr] Compiling tokio v1.45.1 [INFO] [stderr] Compiling crc v3.3.0 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Compiling digest v0.10.7 [INFO] [stderr] Compiling signal-hook v0.3.18 [INFO] [stderr] Compiling sha2 v0.10.9 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Compiling libsqlite3-sys v0.30.1 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Compiling flume v0.11.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling atoi v2.0.0 [INFO] [stderr] Checking signal-hook-registry v1.4.5 [INFO] [stderr] Checking ff v0.13.1 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Checking anstyle-query v1.1.3 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking anstream v0.6.19 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking cbc v0.1.2 [INFO] [stderr] Checking salsa20 v0.10.2 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking ssh-encoding v0.2.0 [INFO] [stderr] Checking scrypt v0.11.0 [INFO] [stderr] Checking blowfish v0.9.1 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking password-hash v0.5.0 [INFO] [stderr] Checking pkcs5 v0.7.1 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Checking ssh-cipher v0.2.0 [INFO] [stderr] Checking argon2 v0.5.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking miniz_oxide v0.8.8 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking bcrypt-pbkdf v0.10.0 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking castaway v0.2.3 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling indoc v2.0.6 [INFO] [stderr] Checking clap_lex v0.7.5 [INFO] [stderr] Compiling anyhow v1.0.98 [INFO] [stderr] Checking compact_str v0.8.1 [INFO] [stderr] Compiling futures-executor v0.3.31 [INFO] [stderr] Checking flate2 v1.1.1 [INFO] [stderr] Checking clap_builder v4.5.40 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking russh-cryptovec v0.52.0 [INFO] [stderr] Checking lru v0.12.5 [INFO] [stderr] Checking home v0.5.11 [INFO] [stderr] Checking data-encoding v2.9.0 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Checking hex-literal v0.4.1 [INFO] [stderr] Checking unicode-width v0.2.0 [INFO] [stderr] Checking emojic v0.4.1 [INFO] [stderr] Checking terminal-keycode v1.1.1 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking primeorder v0.13.6 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking p384 v0.13.1 [INFO] [stderr] Checking p256 v0.13.2 [INFO] [stderr] Checking p521 v0.13.3 [INFO] [stderr] Checking rsa v0.9.8 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling tracing-attributes v0.1.29 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling delegate v0.13.3 [INFO] [stderr] Compiling clap_derive v4.5.40 [INFO] [stderr] Compiling enum_dispatch v0.3.13 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling tokio-stream v0.1.17 [INFO] [stderr] Compiling thiserror v2.0.12 [INFO] [stderr] Compiling tracing v0.1.41 [INFO] [stderr] Compiling zerofrom v0.1.6 [INFO] [stderr] Compiling yoke v0.8.0 [INFO] [stderr] Compiling zerovec v0.11.2 [INFO] [stderr] Compiling zerotrie v0.2.2 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking ed25519-dalek v2.1.1 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Checking internal-russh-forked-ssh-key v0.6.10+upstream-0.6.7 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling instability v0.3.7 [INFO] [stderr] Checking clap v4.5.40 [INFO] [stderr] Compiling tinystr v0.8.1 [INFO] [stderr] Compiling potential_utf v0.1.2 [INFO] [stderr] Compiling icu_collections v2.0.0 [INFO] [stderr] Compiling icu_locale_core v2.0.0 [INFO] [stderr] Compiling icu_provider v2.0.0 [INFO] [stderr] Compiling icu_normalizer v2.0.0 [INFO] [stderr] Compiling icu_properties v2.0.1 [INFO] [stderr] Checking russh-util v0.52.0 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking russh v0.52.1 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling idna v1.0.3 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking sqlx-core v0.8.6 [INFO] [stderr] Checking unicode-truncate v1.1.0 [INFO] [stderr] Checking ratatui v0.29.0 [INFO] [stderr] Checking sqlx-sqlite v0.8.6 [INFO] [stderr] Compiling sqlx-macros-core v0.8.6 [INFO] [stderr] Compiling sqlx-macros v0.8.6 [INFO] [stderr] Checking sqlx v0.8.6 [INFO] [stderr] Checking sshlack v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/app/app_controller.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | channel_id: channel_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `channel_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/app/app_state.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | user: user, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/app_server.rs:49:21 [INFO] [stdout] | [INFO] [stdout] 49 | db_pool: db_pool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `db_pool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/app/app_controller.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | channel_id: channel_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `channel_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/app/app_state.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | user: user, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/app_server.rs:49:21 [INFO] [stdout] | [INFO] [stdout] 49 | db_pool: db_pool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `db_pool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/app/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod app; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/app/app_controller.rs:116:13 [INFO] [stdout] | [INFO] [stdout] 116 | self.app_state.scroll_offset = self.app_state.scroll_offset - count; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.app_state.scroll_offset -= count` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/app/app_controller.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | self.app_state.scroll_offset = self.app_state.scroll_offset + count; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.app_state.scroll_offset += count` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app/app_input_parse.rs:31:37 [INFO] [stdout] | [INFO] [stdout] 31 | / ... if !input_message.is_empty() { [INFO] [stdout] 32 | | ... if let Ok(_) = controller.send_message(input_message).await [INFO] [stdout] 33 | | ... { [INFO] [stdout] 34 | | ... controller.clear_input(); [INFO] [stdout] 35 | | ... }; [INFO] [stdout] 36 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 31 ~ if !input_message.is_empty() [INFO] [stdout] 32 ~ && let Ok(_) = controller.send_message(input_message).await [INFO] [stdout] 33 | { [INFO] [stdout] 34 | controller.clear_input(); [INFO] [stdout] 35 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/app/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod app; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/app/app_input_parse.rs:32:48 [INFO] [stdout] | [INFO] [stdout] 32 | ... if let Ok(_) = controller.send_message(input_message).await [INFO] [stdout] | -------^^^^^----------------------------------------------- help: try: `if controller.send_message(input_message).await.is_ok()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `result` after checking its variant with `is_err` [INFO] [stdout] --> src/app/terminal.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 39 | if result.is_err() { [INFO] [stdout] | ------------------ help: try: `if let Err() = result` [INFO] [stdout] ... [INFO] [stdout] 42 | result.unwrap_err(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/app_server.rs:67:14 [INFO] [stdout] | [INFO] [stdout] 67 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/app_server.rs:68:19 [INFO] [stdout] | [INFO] [stdout] 68 | .open(&path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `user_row` after checking its variant with `is_ok` [INFO] [stdout] --> src/app_server.rs:127:33 [INFO] [stdout] | [INFO] [stdout] 126 | if user_row.is_ok() { [INFO] [stdout] | ------------------- help: try: `if let Ok() = user_row` [INFO] [stdout] 127 | let password_hash = user_row.unwrap().get::("password_hash"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/app/app_controller.rs:116:13 [INFO] [stdout] | [INFO] [stdout] 116 | self.app_state.scroll_offset = self.app_state.scroll_offset - count; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.app_state.scroll_offset -= count` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/app/app_controller.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | self.app_state.scroll_offset = self.app_state.scroll_offset + count; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.app_state.scroll_offset += count` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app/app_input_parse.rs:31:37 [INFO] [stdout] | [INFO] [stdout] 31 | / ... if !input_message.is_empty() { [INFO] [stdout] 32 | | ... if let Ok(_) = controller.send_message(input_message).await [INFO] [stdout] 33 | | ... { [INFO] [stdout] 34 | | ... controller.clear_input(); [INFO] [stdout] 35 | | ... }; [INFO] [stdout] 36 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 31 ~ if !input_message.is_empty() [INFO] [stdout] 32 ~ && let Ok(_) = controller.send_message(input_message).await [INFO] [stdout] 33 | { [INFO] [stdout] 34 | controller.clear_input(); [INFO] [stdout] 35 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/app/app_input_parse.rs:32:48 [INFO] [stdout] | [INFO] [stdout] 32 | ... if let Ok(_) = controller.send_message(input_message).await [INFO] [stdout] | -------^^^^^----------------------------------------------- help: try: `if controller.send_message(input_message).await.is_ok()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `result` after checking its variant with `is_err` [INFO] [stdout] --> src/app/terminal.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 39 | if result.is_err() { [INFO] [stdout] | ------------------ help: try: `if let Err() = result` [INFO] [stdout] ... [INFO] [stdout] 42 | result.unwrap_err(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/app_server.rs:67:14 [INFO] [stdout] | [INFO] [stdout] 67 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/app_server.rs:68:19 [INFO] [stdout] | [INFO] [stdout] 68 | .open(&path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `user_row` after checking its variant with `is_ok` [INFO] [stdout] --> src/app_server.rs:127:33 [INFO] [stdout] | [INFO] [stdout] 126 | if user_row.is_ok() { [INFO] [stdout] | ------------------- help: try: `if let Ok() = user_row` [INFO] [stdout] 127 | let password_hash = user_row.unwrap().get::("password_hash"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 25s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: num-bigint-dig v0.8.4 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 3` [INFO] running `Command { std: "docker" "inspect" "a346bd02500f4bdd49a9dec380badfd4e3c5f8f5eb9f4b26928240c91c744597", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a346bd02500f4bdd49a9dec380badfd4e3c5f8f5eb9f4b26928240c91c744597", kill_on_drop: false }` [INFO] [stdout] a346bd02500f4bdd49a9dec380badfd4e3c5f8f5eb9f4b26928240c91c744597