[INFO] cloning repository https://github.com/maxvonhippel/KORG_RUST [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/maxvonhippel/KORG_RUST" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmaxvonhippel%2FKORG_RUST", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmaxvonhippel%2FKORG_RUST'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c155ad899a6d388b9beb525c3cc053c2d7fb2792 [INFO] linting maxvonhippel/KORG_RUST against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmaxvonhippel%2FKORG_RUST" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/maxvonhippel/KORG_RUST [INFO] finished tweaking git repo https://github.com/maxvonhippel/KORG_RUST [INFO] tweaked toml for git repo https://github.com/maxvonhippel/KORG_RUST written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/maxvonhippel/KORG_RUST on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/maxvonhippel/KORG_RUST already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serial_test v3.4.0 [INFO] [stderr] Downloaded sdd v3.0.10 [INFO] [stderr] Downloaded serial_test_derive v3.4.0 [INFO] [stderr] Downloaded scc v2.4.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1ac926cadf76b640e6c7804be0214721c3b48326df99901486f397e1906bd330 [INFO] running `Command { std: "docker" "start" "-a" "1ac926cadf76b640e6c7804be0214721c3b48326df99901486f397e1906bd330", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1ac926cadf76b640e6c7804be0214721c3b48326df99901486f397e1906bd330", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ac926cadf76b640e6c7804be0214721c3b48326df99901486f397e1906bd330", kill_on_drop: false }` [INFO] [stdout] 1ac926cadf76b640e6c7804be0214721c3b48326df99901486f397e1906bd330 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] af5044bc82f64ba9a0a1e709d84a0d8d0f0de3329f94e30a7323d4905e6624be [INFO] running `Command { std: "docker" "start" "-a" "af5044bc82f64ba9a0a1e709d84a0d8d0f0de3329f94e30a7323d4905e6624be", kill_on_drop: false }` [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking futures-core v0.3.32 [INFO] [stderr] Checking slab v0.4.12 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Checking futures-task v0.3.32 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking sdd v3.0.10 [INFO] [stderr] Compiling serial_test_derive v3.4.0 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking clap_builder v4.5.60 [INFO] [stderr] Checking scc v2.4.0 [INFO] [stderr] Checking clap v4.5.60 [INFO] [stderr] Checking futures-executor v0.3.32 [INFO] [stderr] Checking korg-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking serial_test v3.4.0 [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/characterize.rs:38:15 [INFO] [stdout] | [INFO] [stdout] 38 | .args(&args) [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/characterize.rs:360:13 [INFO] [stdout] | [INFO] [stdout] 360 | assert!(!(a && !e), "If A-attack then also E-attack"); [INFO] [stdout] | ^^^^^^^^^^ help: try: `!a || e` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/characterize.rs:420:85 [INFO] [stdout] | [INFO] [stdout] 420 | let check_text = make_attack_transfer_check(&attacker_model, p, &phi, recovery); [INFO] [stdout] | ^^^^ help: change this to: `phi` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/korg.rs:95:1 [INFO] [stdout] | [INFO] [stdout] 95 | / pub fn body( [INFO] [stdout] 96 | | model: Option<&str>, [INFO] [stdout] 97 | | phi: Option<&str>, [INFO] [stdout] 98 | | q: Option<&str>, [INFO] [stdout] ... | [INFO] [stdout] 103 | | characterize: bool, [INFO] [stdout] 104 | | ) -> i32 { [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/korg.rs:120:1 [INFO] [stdout] | [INFO] [stdout] 120 | / pub fn body_full( [INFO] [stdout] 121 | | model: Option<&str>, [INFO] [stdout] 122 | | phi: Option<&str>, [INFO] [stdout] 123 | | q: Option<&str>, [INFO] [stdout] ... | [INFO] [stdout] 130 | | do_test_remaining: bool, [INFO] [stdout] 131 | | ) -> i32 { [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/korg.rs:222:5 [INFO] [stdout] | [INFO] [stdout] 222 | let ret: i32; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `ret` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 222 ~ [INFO] [stdout] 223 ~ let ret: i32 = if characterize { [INFO] [stdout] 224 | let (e, a) = characterize_attacks(model_str, phi.unwrap_or(""), with_recovery, &attacker_name); [INFO] [stdout] 225 | clean_up(); [INFO] [stdout] 226 ~ if (e + a) > 0 { 0 } else { -1 } [INFO] [stdout] 227 | } else { [INFO] [stdout] 228 | clean_up(); [INFO] [stdout] 229 ~ 0 [INFO] [stdout] 230 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/korg.rs:238:25 [INFO] [stdout] | [INFO] [stdout] 238 | let prop_filename = phi_str.split('/').last().unwrap_or(""); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 238 - let prop_filename = phi_str.split('/').last().unwrap_or(""); [INFO] [stdout] 238 + let prop_filename = phi_str.split('/').next_back().unwrap_or(""); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/characterize.rs:38:15 [INFO] [stdout] | [INFO] [stdout] 38 | .args(&args) [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/characterize.rs:360:13 [INFO] [stdout] | [INFO] [stdout] 360 | assert!(!(a && !e), "If A-attack then also E-attack"); [INFO] [stdout] | ^^^^^^^^^^ help: try: `!a || e` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/characterize.rs:420:85 [INFO] [stdout] | [INFO] [stdout] 420 | let check_text = make_attack_transfer_check(&attacker_model, p, &phi, recovery); [INFO] [stdout] | ^^^^ help: change this to: `phi` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/korg.rs:95:1 [INFO] [stdout] | [INFO] [stdout] 95 | / pub fn body( [INFO] [stdout] 96 | | model: Option<&str>, [INFO] [stdout] 97 | | phi: Option<&str>, [INFO] [stdout] 98 | | q: Option<&str>, [INFO] [stdout] ... | [INFO] [stdout] 103 | | characterize: bool, [INFO] [stdout] 104 | | ) -> i32 { [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/korg.rs:120:1 [INFO] [stdout] | [INFO] [stdout] 120 | / pub fn body_full( [INFO] [stdout] 121 | | model: Option<&str>, [INFO] [stdout] 122 | | phi: Option<&str>, [INFO] [stdout] 123 | | q: Option<&str>, [INFO] [stdout] ... | [INFO] [stdout] 130 | | do_test_remaining: bool, [INFO] [stdout] 131 | | ) -> i32 { [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/korg.rs:222:5 [INFO] [stdout] | [INFO] [stdout] 222 | let ret: i32; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `ret` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 222 ~ [INFO] [stdout] 223 ~ let ret: i32 = if characterize { [INFO] [stdout] 224 | let (e, a) = characterize_attacks(model_str, phi.unwrap_or(""), with_recovery, &attacker_name); [INFO] [stdout] 225 | clean_up(); [INFO] [stdout] 226 ~ if (e + a) > 0 { 0 } else { -1 } [INFO] [stdout] 227 | } else { [INFO] [stdout] 228 | clean_up(); [INFO] [stdout] 229 ~ 0 [INFO] [stdout] 230 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/korg.rs:238:25 [INFO] [stdout] | [INFO] [stdout] 238 | let prop_filename = phi_str.split('/').last().unwrap_or(""); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 238 - let prop_filename = phi_str.split('/').last().unwrap_or(""); [INFO] [stdout] 238 + let prop_filename = phi_str.split('/').next_back().unwrap_or(""); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.94s [INFO] running `Command { std: "docker" "inspect" "af5044bc82f64ba9a0a1e709d84a0d8d0f0de3329f94e30a7323d4905e6624be", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "af5044bc82f64ba9a0a1e709d84a0d8d0f0de3329f94e30a7323d4905e6624be", kill_on_drop: false }` [INFO] [stdout] af5044bc82f64ba9a0a1e709d84a0d8d0f0de3329f94e30a7323d4905e6624be