[INFO] cloning repository https://github.com/max-lt/k-bucket
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/max-lt/k-bucket" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmax-lt%2Fk-bucket", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmax-lt%2Fk-bucket'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 281edac2b47c1751031453f5933010043512941e
[INFO] linting max-lt/k-bucket against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmax-lt%2Fk-bucket" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/max-lt/k-bucket
[INFO] finished tweaking git repo https://github.com/max-lt/k-bucket
[INFO] tweaked toml for git repo https://github.com/max-lt/k-bucket written to /workspace/builds/worker-2-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/max-lt/k-bucket on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/max-lt/k-bucket already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] d13d351fcb49a03f9f4ec5d74693963bb371699162a5acd9ee103825d5abc07c
[INFO] running `Command { std: "docker" "start" "-a" "d13d351fcb49a03f9f4ec5d74693963bb371699162a5acd9ee103825d5abc07c", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "d13d351fcb49a03f9f4ec5d74693963bb371699162a5acd9ee103825d5abc07c", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "d13d351fcb49a03f9f4ec5d74693963bb371699162a5acd9ee103825d5abc07c", kill_on_drop: false }`
[INFO] [stdout] d13d351fcb49a03f9f4ec5d74693963bb371699162a5acd9ee103825d5abc07c
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] f93d580e52bbd0ad90af47123cf00ee4878de3c54325f9cd90a72383d3ac55fd
[INFO] running `Command { std: "docker" "start" "-a" "f93d580e52bbd0ad90af47123cf00ee4878de3c54325f9cd90a72383d3ac55fd", kill_on_drop: false }`
[INFO] [stderr]     Checking hex-conservative v0.2.1
[INFO] [stderr]     Checking anstream v0.6.15
[INFO] [stderr]     Checking env_filter v0.1.2
[INFO] [stderr]     Checking env_logger v0.11.5
[INFO] [stderr]     Checking k-bucket v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: the loop variable `i` is only used to index `self`
[INFO] [stdout]   --> src/default.rs:44:18
[INFO] [stdout]    |
[INFO] [stdout] 44 |         for i in 0..N {
[INFO] [stdout]    |                  ^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout]    = note: `#[warn(clippy::needless_range_loop)]` on by default
[INFO] [stdout] help: consider using an iterator
[INFO] [stdout]    |
[INFO] [stdout] 44 -         for i in 0..N {
[INFO] [stdout] 44 +         for <item> in self.iter().take(N) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/bucket.rs:71:13
[INFO] [stdout]    |
[INFO] [stdout] 71 |             return;
[INFO] [stdout]    |             ^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 70 -             items.push(value);
[INFO] [stdout] 71 -             return;
[INFO] [stdout] 70 +             items.push(value);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `or_insert` to construct default value
[INFO] [stdout]   --> src/bucket.rs:45:54
[INFO] [stdout]    |
[INFO] [stdout] 45 |         let items = self.buckets.entry(bucket_index).or_insert(Vec::new());
[INFO] [stdout]    |                                                      ^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
[INFO] [stdout]    = note: `#[warn(clippy::unwrap_or_default)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`)
[INFO] [stdout]   --> src/bucket.rs:98:21
[INFO] [stdout]    |
[INFO] [stdout] 98 |         let index = bucket_key.distance(key).leading_zeros() as u8;
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `bucket_key.distance(key).leading_zeros()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/bucket.rs:125:47
[INFO] [stdout]     |
[INFO] [stdout] 125 |         result.sort_by(|(a, _), (b, _)| a.cmp(&b));
[INFO] [stdout]     |                                               ^^ help: change this to: `b`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is only used to index `self`
[INFO] [stdout]   --> src/default.rs:44:18
[INFO] [stdout]    |
[INFO] [stdout] 44 |         for i in 0..N {
[INFO] [stdout]    |                  ^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout]    = note: `#[warn(clippy::needless_range_loop)]` on by default
[INFO] [stdout] help: consider using an iterator
[INFO] [stdout]    |
[INFO] [stdout] 44 -         for i in 0..N {
[INFO] [stdout] 44 +         for <item> in self.iter().take(N) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> examples/playground-r2.rs:29:8
[INFO] [stdout]    |
[INFO] [stdout] 29 |     if !std::env::var("RUST_LOG").is_ok() {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::env::var("RUST_LOG").is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/bucket.rs:71:13
[INFO] [stdout]    |
[INFO] [stdout] 71 |             return;
[INFO] [stdout]    |             ^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 70 -             items.push(value);
[INFO] [stdout] 71 -             return;
[INFO] [stdout] 70 +             items.push(value);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `or_insert` to construct default value
[INFO] [stdout]   --> src/bucket.rs:45:54
[INFO] [stdout]    |
[INFO] [stdout] 45 |         let items = self.buckets.entry(bucket_index).or_insert(Vec::new());
[INFO] [stdout]    |                                                      ^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
[INFO] [stdout]    = note: `#[warn(clippy::unwrap_or_default)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`)
[INFO] [stdout]   --> src/bucket.rs:98:21
[INFO] [stdout]    |
[INFO] [stdout] 98 |         let index = bucket_key.distance(key).leading_zeros() as u8;
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `bucket_key.distance(key).leading_zeros()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/bucket.rs:125:47
[INFO] [stdout]     |
[INFO] [stdout] 125 |         result.sort_by(|(a, _), (b, _)| a.cmp(&b));
[INFO] [stdout]     |                                               ^^ help: change this to: `b`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> examples/playground-b2.rs:64:8
[INFO] [stdout]    |
[INFO] [stdout] 64 |     if !std::env::var("RUST_LOG").is_ok() {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::env::var("RUST_LOG").is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> examples/playground-u8.rs:69:8
[INFO] [stdout]    |
[INFO] [stdout] 69 |     if !std::env::var("RUST_LOG").is_ok() {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::env::var("RUST_LOG").is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.32s
[INFO] running `Command { std: "docker" "inspect" "f93d580e52bbd0ad90af47123cf00ee4878de3c54325f9cd90a72383d3ac55fd", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "f93d580e52bbd0ad90af47123cf00ee4878de3c54325f9cd90a72383d3ac55fd", kill_on_drop: false }`
[INFO] [stdout] f93d580e52bbd0ad90af47123cf00ee4878de3c54325f9cd90a72383d3ac55fd