[INFO] cloning repository https://github.com/matt-nowakowski/chainreactor-doom [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/matt-nowakowski/chainreactor-doom" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmatt-nowakowski%2Fchainreactor-doom", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmatt-nowakowski%2Fchainreactor-doom'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7ea03c4a40c47b5f3ae77113e36f3ed91e029820 [INFO] linting matt-nowakowski/chainreactor-doom against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmatt-nowakowski%2Fchainreactor-doom" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/matt-nowakowski/chainreactor-doom [INFO] finished tweaking git repo https://github.com/matt-nowakowski/chainreactor-doom [INFO] tweaked toml for git repo https://github.com/matt-nowakowski/chainreactor-doom written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/matt-nowakowski/chainreactor-doom on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/matt-nowakowski/chainreactor-doom already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: profiles for the non root package will be ignored, specify profiles at the workspace root: [INFO] [stderr] package: /workspace/builds/worker-7-tc1/source/wasm/Cargo.toml [INFO] [stderr] workspace: /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] [stderr] Updating git repository `https://github.com/paritytech/polkadot-sdk` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded keccak v0.1.6 [INFO] [stderr] Downloaded getrandom_or_panic v0.0.3 [INFO] [stderr] Downloaded substrate-bip39 v0.4.6 [INFO] [stderr] Downloaded proc-macro-warning v0.4.2 [INFO] [stderr] Downloaded dyn-clonable-impl v0.9.2 [INFO] [stderr] Downloaded wasmtime-jit-debug v8.0.1 [INFO] [stderr] Downloaded macro_magic_macros v0.4.2 [INFO] [stderr] Downloaded cranelift-entity v0.95.1 [INFO] [stderr] Downloaded include_dir v0.7.4 [INFO] [stderr] Downloaded include_dir_macros v0.7.4 [INFO] [stderr] Downloaded file-guard v0.2.0 [INFO] [stderr] Downloaded memory-db v0.32.0 [INFO] [stderr] Downloaded trie-root v0.18.0 [INFO] [stderr] Downloaded expander v2.2.1 [INFO] [stderr] Downloaded common-path v1.0.0 [INFO] [stderr] Downloaded tt-call v1.0.9 [INFO] [stderr] Downloaded fs-err v2.11.0 [INFO] [stderr] Downloaded derive-syn-parse v0.2.0 [INFO] [stderr] Downloaded trie-db v0.27.1 [INFO] [stderr] Downloaded ed25519-dalek v2.2.0 [INFO] [stderr] Downloaded secp256k1 v0.24.3 [INFO] [stderr] Downloaded wasmtime-environ v8.0.1 [INFO] [stderr] Downloaded wasmparser v0.102.0 [INFO] [stderr] Downloaded wasmtime-runtime v8.0.1 [INFO] [stderr] Downloaded schnorrkel v0.11.5 [INFO] [stderr] Downloaded libsecp256k1 v0.7.2 [INFO] [stderr] Downloaded wasmtime v8.0.1 [INFO] [stderr] Downloaded scale-info v2.11.6 [INFO] [stderr] Downloaded array-bytes v6.2.3 [INFO] [stderr] Downloaded rustix v0.36.17 [INFO] [stderr] Downloaded bounded-collections v0.1.9 [INFO] [stderr] Downloaded psm v0.1.23 [INFO] [stderr] Downloaded frame-metadata v16.0.0 [INFO] [stderr] Downloaded wasmtime-jit v8.0.1 [INFO] [stderr] Downloaded wasmtime-types v8.0.1 [INFO] [stderr] Downloaded docify v0.2.9 [INFO] [stderr] Downloaded macro_magic_core v0.4.2 [INFO] [stderr] Downloaded macro_magic v0.4.2 [INFO] [stderr] Downloaded hash-db v0.16.0 [INFO] [stderr] Downloaded scale-info-derive v2.11.6 [INFO] [stderr] Downloaded wasmtime-jit-icache-coherence v8.0.1 [INFO] [stderr] Downloaded dyn-clonable v0.9.2 [INFO] [stderr] Downloaded wasmtime-asm-macros v8.0.1 [INFO] [stderr] Downloaded docify_macros v0.2.9 [INFO] [stderr] Downloaded macro_magic_core_macros v0.4.3 [INFO] [stderr] Downloaded memfd v0.6.5 [INFO] [stderr] Downloaded ss58-registry v1.51.0 [INFO] [stderr] Downloaded aquamarine v0.3.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b44f169dad0f17aa48a593a16d2742dcde0a22656e538e53cb426c19836b6253 [INFO] running `Command { std: "docker" "start" "-a" "b44f169dad0f17aa48a593a16d2742dcde0a22656e538e53cb426c19836b6253", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b44f169dad0f17aa48a593a16d2742dcde0a22656e538e53cb426c19836b6253", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b44f169dad0f17aa48a593a16d2742dcde0a22656e538e53cb426c19836b6253", kill_on_drop: false }` [INFO] [stdout] b44f169dad0f17aa48a593a16d2742dcde0a22656e538e53cb426c19836b6253 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9596ee439fec74455e5a4311a316cd26f20d03cbf0ef550874aaf472a07b5316 [INFO] running `Command { std: "docker" "start" "-a" "9596ee439fec74455e5a4311a316cd26f20d03cbf0ef550874aaf472a07b5316", kill_on_drop: false }` [INFO] [stderr] warning: profiles for the non root package will be ignored, specify profiles at the workspace root: [INFO] [stderr] package: /opt/rustwide/workdir/wasm/Cargo.toml [INFO] [stderr] workspace: /opt/rustwide/workdir/Cargo.toml [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Compiling toml_write v0.1.2 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling generic-array v0.14.9 [INFO] [stderr] Compiling indexmap v2.7.1 [INFO] [stderr] Compiling winnow v0.7.15 [INFO] [stderr] Compiling unicode-xid v0.2.6 [INFO] [stderr] Compiling zerocopy v0.8.40 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking stable_deref_trait v1.2.1 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Compiling parity-scale-codec v3.7.5 [INFO] [stderr] Checking bytes v1.11.1 [INFO] [stderr] Checking byte-slice-cast v1.2.3 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Compiling crunchy v0.2.4 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling aho-corasick v1.1.4 [INFO] [stderr] Compiling regex-syntax v0.8.10 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling const_format_proc_macros v0.2.34 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking percent-encoding v2.3.2 [INFO] [stderr] Compiling anyhow v1.0.102 [INFO] [stderr] Compiling crc32fast v1.5.0 [INFO] [stderr] Compiling rustix v1.1.4 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Compiling target-lexicon v0.12.16 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling memoffset v0.8.0 [INFO] [stderr] Compiling rustix v0.36.17 [INFO] [stderr] Checking pin-project-lite v0.2.17 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Checking sp-std v8.0.0 (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Checking linux-raw-sys v0.12.1 [INFO] [stderr] Checking const_format v0.2.35 [INFO] [stderr] Checking keccak v0.1.6 [INFO] [stderr] Compiling semver v1.0.27 [INFO] [stderr] Compiling digest v0.9.0 [INFO] [stderr] Compiling wasmtime-runtime v8.0.1 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking rustc-demangle v0.1.27 [INFO] [stderr] Compiling cpp_demangle v0.3.5 [INFO] [stderr] Checking linux-raw-sys v0.1.4 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Compiling libsecp256k1-core v0.3.0 [INFO] [stderr] Compiling psm v0.1.23 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking io-lifetimes v1.0.11 [INFO] [stderr] Checking generic-array v0.12.4 [INFO] [stderr] Checking wasmtime-asm-macros v8.0.1 [INFO] [stderr] Checking wasmtime-jit-debug v8.0.1 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Checking wasmtime-jit-icache-coherence v8.0.1 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking futures-core v0.3.32 [INFO] [stderr] Compiling wasmtime v8.0.1 [INFO] [stderr] Checking futures-sink v0.3.32 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Checking digest v0.8.1 [INFO] [stderr] Checking matchers v0.0.1 [INFO] [stderr] Checking tracing-log v0.1.4 [INFO] [stderr] Compiling secp256k1-sys v0.6.1 [INFO] [stderr] Checking slab v0.4.12 [INFO] [stderr] Checking hash-db v0.16.0 [INFO] [stderr] Checking uint v0.9.5 [INFO] [stderr] Compiling regex-automata v0.4.14 [INFO] [stderr] Checking memfd v0.6.5 [INFO] [stderr] Compiling libsecp256k1-gen-ecmult v0.3.0 [INFO] [stderr] Compiling libsecp256k1-gen-genmult v0.3.0 [INFO] [stderr] Checking block-buffer v0.7.3 [INFO] [stderr] Checking getrandom_or_panic v0.0.3 [INFO] [stderr] Compiling libsecp256k1 v0.7.2 [INFO] [stderr] Checking environmental v1.1.4 [INFO] [stderr] Checking blake2b_simd v1.0.2 [INFO] [stderr] Checking sha2 v0.8.2 [INFO] [stderr] Checking unicode-normalization v0.1.25 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking num-format v0.4.4 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking hash256-std-hasher v0.15.2 [INFO] [stderr] Compiling block-buffer v0.10.4 [INFO] [stderr] Compiling crypto-common v0.1.6 [INFO] [stderr] Checking array-bytes v6.2.3 [INFO] [stderr] Checking bs58 v0.5.1 [INFO] [stderr] Compiling object v0.37.3 [INFO] [stderr] Compiling digest v0.10.7 [INFO] [stderr] Checking gimli v0.32.3 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking trie-root v0.18.0 [INFO] [stderr] Checking memory-db v0.32.0 [INFO] [stderr] Checking nohash-hasher v0.2.0 [INFO] [stderr] Compiling sp-io v23.0.0 (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stderr] Checking integer-sqrt v0.1.5 [INFO] [stderr] Compiling prettyplease v0.2.37 [INFO] [stderr] Compiling fs-err v2.11.0 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling static_assertions v1.1.0 [INFO] [stderr] Compiling arrayref v0.3.9 [INFO] [stderr] Compiling expander v2.2.1 [INFO] [stderr] Compiling constant_time_eq v0.3.1 [INFO] [stderr] Compiling twox-hash v1.6.3 [INFO] [stderr] Compiling sha2 v0.10.9 [INFO] [stderr] Compiling sha3 v0.10.8 [INFO] [stderr] Compiling blake2 v0.10.6 [INFO] [stderr] Compiling file-guard v0.2.0 [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.114 [INFO] [stderr] Compiling libm v0.2.16 [INFO] [stderr] Checking parity-wasm v0.45.0 [INFO] [stderr] Checking ff v0.13.1 [INFO] [stderr] Compiling sp-core-hashing v9.0.0 (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Compiling bumpalo v3.20.2 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Compiling proc-macro-warning v0.4.2 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling include_dir_macros v0.7.4 [INFO] [stderr] Compiling wasm-bindgen v0.2.114 [INFO] [stderr] Checking unicode-ident v1.0.24 [INFO] [stderr] Compiling const-random v0.1.18 [INFO] [stderr] Compiling common-path v1.0.0 [INFO] [stderr] Compiling termcolor v1.4.1 [INFO] [stderr] Compiling cfg-expr v0.15.8 [INFO] [stderr] Checking tt-call v1.0.9 [INFO] [stderr] Compiling include_dir v0.7.4 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.114 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling regex v1.12.3 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking schnellru v0.2.4 [INFO] [stderr] Checking secp256k1 v0.24.3 [INFO] [stderr] Checking trie-db v0.27.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zeroize_derive v1.4.3 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling impl-trait-for-tuples v0.2.3 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling derive_more-impl v1.0.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling Inflector v0.11.4 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling ref-cast-impl v1.0.25 [INFO] [stderr] Compiling sp-debug-derive v8.0.0 (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stderr] Compiling futures-macro v0.3.32 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking ref-cast v1.0.25 [INFO] [stderr] Checking crypto-mac v0.11.1 [INFO] [stderr] Checking crypto-mac v0.8.0 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking merlin v3.0.0 [INFO] [stderr] Checking fixed-hash v0.8.0 [INFO] [stderr] Checking pbkdf2 v0.8.0 [INFO] [stderr] Checking hmac v0.8.1 [INFO] [stderr] Checking hmac v0.11.0 [INFO] [stderr] Checking curve25519-dalek v3.2.0 [INFO] [stderr] Checking merlin v2.0.1 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking hmac-drbg v0.3.0 [INFO] [stderr] Checking pbkdf2 v0.11.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking derive_more v1.0.0 [INFO] [stderr] Checking curve25519-dalek v2.1.3 [INFO] [stderr] Compiling dyn-clonable-impl v0.9.2 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking tiny-bip39 v1.0.0 [INFO] [stderr] Checking secrecy v0.8.0 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking addr2line v0.25.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking der v0.7.10 [INFO] [stderr] Compiling derive-syn-parse v0.1.5 [INFO] [stderr] Compiling sp-core-hashing-proc-macro v9.0.0 (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stderr] Compiling macro_magic_core_macros v0.4.3 [INFO] [stderr] Checking dyn-clonable v0.9.2 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking ed25519-zebra v3.1.0 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking schnorrkel v0.9.1 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Compiling frame-support-procedural-tools-derive v3.0.0 (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stderr] Compiling derive-syn-parse v0.2.0 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling aquamarine v0.3.3 [INFO] [stderr] Checking backtrace v0.3.76 [INFO] [stderr] Checking schnorrkel v0.11.5 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking ed25519-dalek v2.2.0 [INFO] [stderr] Checking substrate-bip39 v0.4.6 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Compiling macro_magic_core v0.4.2 [INFO] [stderr] Checking sp-panic-handler v8.0.0 (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.114 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Compiling macro_magic_macros v0.4.2 [INFO] [stderr] Checking cranelift-entity v0.95.1 [INFO] [stderr] Checking impl-serde v0.4.0 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Compiling macro_magic v0.4.2 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking tracing-subscriber v0.2.25 [INFO] [stderr] Compiling toml_datetime v0.6.11 [INFO] [stderr] Compiling serde_spanned v0.6.9 [INFO] [stderr] Compiling ss58-registry v1.51.0 [INFO] [stderr] Checking gimli v0.27.3 [INFO] [stderr] Checking object v0.30.4 [INFO] [stderr] Checking k256 v0.13.4 [INFO] [stderr] Compiling toml_edit v0.22.27 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Checking futures-executor v0.3.32 [INFO] [stderr] Checking js-sys v0.3.91 [INFO] [stderr] Checking futures v0.3.32 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking wasmparser v0.102.0 [INFO] [stderr] Compiling proc-macro-crate v3.2.0 [INFO] [stderr] Compiling toml v0.8.23 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Compiling parity-scale-codec-derive v3.7.5 [INFO] [stderr] Compiling scale-info-derive v2.11.6 [INFO] [stderr] Compiling frame-support-procedural-tools v4.0.0-dev (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stderr] Compiling sp-runtime-interface-proc-macro v11.0.0 (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stderr] Compiling sp-api-proc-macro v4.0.0-dev (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stderr] Compiling frame-support-procedural v4.0.0-dev (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stderr] Compiling docify_macros v0.2.9 [INFO] [stderr] Checking addr2line v0.19.0 [INFO] [stderr] Checking docify v0.2.9 [INFO] [stderr] Compiling sp-version-proc-macro v8.0.0 (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stderr] Checking scale-info v2.11.6 [INFO] [stderr] Checking impl-codec v0.6.0 [INFO] [stderr] Checking sp-storage v13.0.0 (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stderr] Checking sp-tracing v10.0.0 (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stderr] Checking sp-externalities v0.19.0 (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stderr] Checking wasmtime-types v8.0.1 [INFO] [stderr] Checking wasmtime-environ v8.0.1 [INFO] [stderr] Checking primitive-types v0.12.2 [INFO] [stderr] Checking bounded-collections v0.1.9 [INFO] [stderr] Checking sp-arithmetic v16.0.0 (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stderr] Checking frame-metadata v16.0.0 [INFO] [stderr] Checking doom-engine v0.1.0 (/opt/rustwide/workdir/engine) [INFO] [stderr] Checking sp-metadata-ir v0.1.0 (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> engine/src/assets/textures.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | / /// Each texture is (name, width, height, RGBA data). [INFO] [stdout] 3 | | [INFO] [stdout] | |_^ [INFO] [stdout] 4 | pub const TEX_BROWN1_W: u16 = 128; [INFO] [stdout] | ---------------------- the comment documents this constant item [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! Wall textures extracted from Freedoom WAD. [INFO] [stdout] 2 ~ //! Each texture is (name, width, height, RGBA data). [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> engine/src/assets/textures.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | / /// Each texture is (name, width, height, RGBA data). [INFO] [stdout] 3 | | [INFO] [stdout] | |_^ [INFO] [stdout] 4 | pub const TEX_BROWN1_W: u16 = 128; [INFO] [stdout] | ---------------------- the comment documents this constant item [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! Wall textures extracted from Freedoom WAD. [INFO] [stdout] 2 ~ //! Each texture is (name, width, height, RGBA data). [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking wasmtime-jit v8.0.1 [INFO] [stderr] Checking web-sys v0.3.91 [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> engine/src/assets/flats.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / /// Floor/ceiling textures (64×64 RGBA) from Freedoom. [INFO] [stdout] 2 | | [INFO] [stdout] | |_^ [INFO] [stdout] 3 | pub const FLAT_CEIL3_5: &[u8] = &[55, 55, 55, 255, 59, 59, 59, 255, 55, 55, 55, 255, 55, 55, 55, 255, 55, 55, 55, 255, 55, 55, 55, ... [INFO] [stdout] | ---------------------- the comment documents this constant item [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 - /// Floor/ceiling textures (64×64 RGBA) from Freedoom. [INFO] [stdout] 1 + //! Floor/ceiling textures (64×64 RGBA) from Freedoom. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> engine/src/assets/flats.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / /// Floor/ceiling textures (64×64 RGBA) from Freedoom. [INFO] [stdout] 2 | | [INFO] [stdout] | |_^ [INFO] [stdout] 3 | pub const FLAT_CEIL3_5: &[u8] = &[55, 55, 55, 255, 59, 59, 59, 255, 55, 55, 55, 255, 55, 55, 55, 255, 55, 55, 55, 255, 55, 55, 55, ... [INFO] [stdout] | ---------------------- the comment documents this constant item [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 - /// Floor/ceiling textures (64×64 RGBA) from Freedoom. [INFO] [stdout] 1 + //! Floor/ceiling textures (64×64 RGBA) from Freedoom. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> engine/src/assets/sprites.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / /// Sprites extracted from Freedoom WAD. [INFO] [stdout] 2 | | [INFO] [stdout] | |_^ [INFO] [stdout] 3 | pub const SPR_SARGA1_W: u16 = 38; [INFO] [stdout] | ---------------------- the comment documents this constant item [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 - /// Sprites extracted from Freedoom WAD. [INFO] [stdout] 1 + //! Sprites extracted from Freedoom WAD. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> engine/src/assets/sprites.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / /// Sprites extracted from Freedoom WAD. [INFO] [stdout] 2 | | [INFO] [stdout] | |_^ [INFO] [stdout] 3 | pub const SPR_SARGA1_W: u16 = 38; [INFO] [stdout] | ---------------------- the comment documents this constant item [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 - /// Sprites extracted from Freedoom WAD. [INFO] [stdout] 1 + //! Sprites extracted from Freedoom WAD. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> engine/src/assets/sttnum.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / /// STTNUM digit sprites from Freedoom WAD (big red numbers for status bar). [INFO] [stdout] 2 | | [INFO] [stdout] | |_^ [INFO] [stdout] 3 | pub const STTNUM0_W: u16 = 13; [INFO] [stdout] | ------------------- the comment documents this constant item [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 - /// STTNUM digit sprites from Freedoom WAD (big red numbers for status bar). [INFO] [stdout] 1 + //! STTNUM digit sprites from Freedoom WAD (big red numbers for status bar). [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> engine/src/assets/sttnum.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / /// STTNUM digit sprites from Freedoom WAD (big red numbers for status bar). [INFO] [stdout] 2 | | [INFO] [stdout] | |_^ [INFO] [stdout] 3 | pub const STTNUM0_W: u16 = 13; [INFO] [stdout] | ------------------- the comment documents this constant item [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 - /// STTNUM digit sprites from Freedoom WAD (big red numbers for status bar). [INFO] [stdout] 1 + //! STTNUM digit sprites from Freedoom WAD (big red numbers for status bar). [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking sp-wasm-interface v14.0.0 (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stdout] warning: unused variable: `a` [INFO] [stdout] --> engine/src/map.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 86 | let a = angle as f64 / 1000.0; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `side` is never read [INFO] [stdout] --> engine/src/map.rs:118:28 [INFO] [stdout] | [INFO] [stdout] 118 | let mut side: u8 = 0; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking sp-runtime-interface v17.0.0 (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stderr] Checking sp-core v21.0.0 (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stdout] warning: function `render_overlay_text` is never used [INFO] [stdout] --> engine/src/renderer.rs:1364:4 [INFO] [stdout] | [INFO] [stdout] 1364 | fn render_overlay_text(fb: &mut Framebuffer, text: &str, r: u8, g: u8, b: u8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> engine/src/game.rs:273:35 [INFO] [stdout] | [INFO] [stdout] 273 | let spread = (i as i32 - 3) * 30; // ±90 millirad spread [INFO] [stdout] | ^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> engine/src/game.rs:353:34 [INFO] [stdout] | [INFO] [stdout] 353 | let angle_to_enemy = fixmath::fp_atan2(dy, dx) as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fixmath::fp_atan2(dy, dx)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> engine/src/game.rs:465:17 [INFO] [stdout] | [INFO] [stdout] 465 | / if self.player.has_red_key { [INFO] [stdout] 466 | | self.map.tiles[idx] = TileType::Door(DoorState::Opening(0)); [INFO] [stdout] 467 | | self.events.push(GameEvent::DoorOpened { x: gx, y: gy }); [INFO] [stdout] 468 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 464 ~ TileType::Door(DoorState::LockedRed) [INFO] [stdout] 465 ~ if self.player.has_red_key => { [INFO] [stdout] 466 | self.map.tiles[idx] = TileType::Door(DoorState::Opening(0)); [INFO] [stdout] 467 | self.events.push(GameEvent::DoorOpened { x: gx, y: gy }); [INFO] [stdout] 468 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> engine/src/game.rs:471:17 [INFO] [stdout] | [INFO] [stdout] 471 | / if self.player.has_blue_key { [INFO] [stdout] 472 | | self.map.tiles[idx] = TileType::Door(DoorState::Opening(0)); [INFO] [stdout] 473 | | self.events.push(GameEvent::DoorOpened { x: gx, y: gy }); [INFO] [stdout] 474 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 470 ~ TileType::Door(DoorState::LockedBlue) [INFO] [stdout] 471 ~ if self.player.has_blue_key => { [INFO] [stdout] 472 | self.map.tiles[idx] = TileType::Door(DoorState::Opening(0)); [INFO] [stdout] 473 | self.events.push(GameEvent::DoorOpened { x: gx, y: gy }); [INFO] [stdout] 474 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> engine/src/game.rs:670:35 [INFO] [stdout] | [INFO] [stdout] 670 | let angle_to_player = fixmath::fp_atan2(dy, dx) as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fixmath::fp_atan2(dy, dx)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> engine/src/game.rs:712:42 [INFO] [stdout] | [INFO] [stdout] 712 | let base_angle = fixmath::fp_atan2(target_dy, target_dx) as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fixmath::fp_atan2(target_dy, target_dx)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> engine/src/types.rs:121:20 [INFO] [stdout] | [INFO] [stdout] 121 | if (tick / 4) % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace with: `(tick / 4).is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `a` [INFO] [stdout] --> engine/src/map.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 86 | let a = angle as f64 / 1000.0; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `side` is never read [INFO] [stdout] --> engine/src/map.rs:118:28 [INFO] [stdout] | [INFO] [stdout] 118 | let mut side: u8 = 0; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DoomRng` [INFO] [stdout] --> engine/src/types.rs:559:5 [INFO] [stdout] | [INFO] [stdout] 559 | / pub fn new() -> Self { [INFO] [stdout] 560 | | Self { index: 0 } [INFO] [stdout] 561 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 535 + impl Default for DoomRng { [INFO] [stdout] 536 + fn default() -> Self { [INFO] [stdout] 537 + Self::new() [INFO] [stdout] 538 + } [INFO] [stdout] 539 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `next` can be confused for the standard trait method `std::iter::Iterator::next` [INFO] [stdout] --> engine/src/types.rs:564:5 [INFO] [stdout] | [INFO] [stdout] 564 | / pub fn next(&mut self) -> u8 { [INFO] [stdout] 565 | | self.index = self.index.wrapping_add(1); [INFO] [stdout] 566 | | Self::TABLE[self.index as usize] [INFO] [stdout] 567 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::iter::Iterator` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `render_overlay_text` is never used [INFO] [stdout] --> engine/src/renderer.rs:1364:4 [INFO] [stdout] | [INFO] [stdout] 1364 | fn render_overlay_text(fb: &mut Framebuffer, text: &str, r: u8, g: u8, b: u8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> engine/src/game.rs:273:35 [INFO] [stdout] | [INFO] [stdout] 273 | let spread = (i as i32 - 3) * 30; // ±90 millirad spread [INFO] [stdout] | ^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> engine/src/game.rs:353:34 [INFO] [stdout] | [INFO] [stdout] 353 | let angle_to_enemy = fixmath::fp_atan2(dy, dx) as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fixmath::fp_atan2(dy, dx)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> engine/src/game.rs:465:17 [INFO] [stdout] | [INFO] [stdout] 465 | / if self.player.has_red_key { [INFO] [stdout] 466 | | self.map.tiles[idx] = TileType::Door(DoorState::Opening(0)); [INFO] [stdout] 467 | | self.events.push(GameEvent::DoorOpened { x: gx, y: gy }); [INFO] [stdout] 468 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 464 ~ TileType::Door(DoorState::LockedRed) [INFO] [stdout] 465 ~ if self.player.has_red_key => { [INFO] [stdout] 466 | self.map.tiles[idx] = TileType::Door(DoorState::Opening(0)); [INFO] [stdout] 467 | self.events.push(GameEvent::DoorOpened { x: gx, y: gy }); [INFO] [stdout] 468 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> engine/src/game.rs:471:17 [INFO] [stdout] | [INFO] [stdout] 471 | / if self.player.has_blue_key { [INFO] [stdout] 472 | | self.map.tiles[idx] = TileType::Door(DoorState::Opening(0)); [INFO] [stdout] 473 | | self.events.push(GameEvent::DoorOpened { x: gx, y: gy }); [INFO] [stdout] 474 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 470 ~ TileType::Door(DoorState::LockedBlue) [INFO] [stdout] 471 ~ if self.player.has_blue_key => { [INFO] [stdout] 472 | self.map.tiles[idx] = TileType::Door(DoorState::Opening(0)); [INFO] [stdout] 473 | self.events.push(GameEvent::DoorOpened { x: gx, y: gy }); [INFO] [stdout] 474 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> engine/src/game.rs:670:35 [INFO] [stdout] | [INFO] [stdout] 670 | let angle_to_player = fixmath::fp_atan2(dy, dx) as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fixmath::fp_atan2(dy, dx)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> engine/src/game.rs:712:42 [INFO] [stdout] | [INFO] [stdout] 712 | let base_angle = fixmath::fp_atan2(target_dy, target_dx) as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fixmath::fp_atan2(target_dy, target_dx)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> engine/src/types.rs:121:20 [INFO] [stdout] | [INFO] [stdout] 121 | if (tick / 4) % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace with: `(tick / 4).is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DoomRng` [INFO] [stdout] --> engine/src/types.rs:559:5 [INFO] [stdout] | [INFO] [stdout] 559 | / pub fn new() -> Self { [INFO] [stdout] 560 | | Self { index: 0 } [INFO] [stdout] 561 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 535 + impl Default for DoomRng { [INFO] [stdout] 536 + fn default() -> Self { [INFO] [stdout] 537 + Self::new() [INFO] [stdout] 538 + } [INFO] [stdout] 539 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `next` can be confused for the standard trait method `std::iter::Iterator::next` [INFO] [stdout] --> engine/src/types.rs:564:5 [INFO] [stdout] | [INFO] [stdout] 564 | / pub fn next(&mut self) -> u8 { [INFO] [stdout] 565 | | self.index = self.index.wrapping_add(1); [INFO] [stdout] 566 | | Self::TABLE[self.index as usize] [INFO] [stdout] 567 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::iter::Iterator` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking sp-trie v22.0.0 (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stderr] Checking sp-keystore v0.27.0 (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stderr] Checking sp-weights v20.0.0 (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stderr] Checking sp-state-machine v0.28.0 (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stderr] Checking sp-application-crypto v23.0.0 (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stderr] Checking sp-runtime v24.0.0 (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Framebuffer` [INFO] [stdout] --> engine/src/renderer.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | / pub fn new() -> Self { [INFO] [stdout] 39 | | Self { [INFO] [stdout] 40 | | rgba: vec![0u8; FRAMEBUFFER_SIZE * 4], [INFO] [stdout] 41 | | } [INFO] [stdout] 42 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 37 + impl Default for Framebuffer { [INFO] [stdout] 38 + fn default() -> Self { [INFO] [stdout] 39 + Self::new() [INFO] [stdout] 40 + } [INFO] [stdout] 41 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `col` is used to index `depth_buf` [INFO] [stdout] --> engine/src/renderer.rs:131:16 [INFO] [stdout] | [INFO] [stdout] 131 | for col in 0..SCREEN_WIDTH { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 131 - for col in 0..SCREEN_WIDTH { [INFO] [stdout] 131 + for (col, ) in depth_buf.iter_mut().enumerate().take(SCREEN_WIDTH) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `col` is used to index `wall_cols` [INFO] [stdout] --> engine/src/renderer.rs:201:16 [INFO] [stdout] | [INFO] [stdout] 201 | for col in 0..SCREEN_WIDTH { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 201 - for col in 0..SCREEN_WIDTH { [INFO] [stdout] 201 + for (col, ) in wall_cols.iter().enumerate().take(SCREEN_WIDTH) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual checked division [INFO] [stdout] --> engine/src/renderer.rs:211:28 [INFO] [stdout] | [INFO] [stdout] 211 | let tex_v = if wc.wall_height > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ check performed here [INFO] [stdout] 212 | (y_in_wall * tex_h / wc.wall_height) % tex_h [INFO] [stdout] | ------------------------------------ division performed here [INFO] [stdout] | [INFO] [stdout] = help: consider using `checked_div` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_checked_ops [INFO] [stdout] = note: `#[warn(clippy::manual_checked_ops)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `col` is used to index `wall_cols` [INFO] [stdout] --> engine/src/renderer.rs:228:16 [INFO] [stdout] | [INFO] [stdout] 228 | for col in 0..SCREEN_WIDTH { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 228 - for col in 0..SCREEN_WIDTH { [INFO] [stdout] 228 + for (col, ) in wall_cols.iter().enumerate().take(SCREEN_WIDTH) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> engine/src/renderer.rs:342:33 [INFO] [stdout] | [INFO] [stdout] 342 | let pulse = ((state.tick as f64 * 0.15).sin() * 0.3 + 0.7) as f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((state.tick as f64 * 0.15).sin() * 0.3 + 0.7)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> engine/src/renderer.rs:710:5 [INFO] [stdout] | [INFO] [stdout] 710 | sprite_list.sort_by(|a, b| b.distance.cmp(&a.distance)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 710 - sprite_list.sort_by(|a, b| b.distance.cmp(&a.distance)); [INFO] [stdout] 710 + sprite_list.sort_by_key(|b| std::cmp::Reverse(b.distance)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `digits` [INFO] [stdout] --> engine/src/renderer.rs:973:14 [INFO] [stdout] | [INFO] [stdout] 973 | for i in 0..num_digits { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 973 - for i in 0..num_digits { [INFO] [stdout] 973 + for in digits.iter().take(num_digits) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> engine/src/renderer.rs:1019:15 [INFO] [stdout] | [INFO] [stdout] 1019 | let val = value.max(0).min(999); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `value.clamp(0, 999)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `row` is used to index `glyph` [INFO] [stdout] --> engine/src/renderer.rs:1053:16 [INFO] [stdout] | [INFO] [stdout] 1053 | for row in 0..5 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 1053 - for row in 0..5 { [INFO] [stdout] 1053 + for (row, ) in glyph.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> engine/src/renderer.rs:1079:22 [INFO] [stdout] | [INFO] [stdout] 1079 | let dir = if angle_norm < 1047 || angle_norm > 5236 { "0" } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(1047..=5236).contains(&angle_norm)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> engine/src/renderer.rs:1325:1 [INFO] [stdout] | [INFO] [stdout] 1325 | fn automap_line(fb: &mut Framebuffer, x0: usize, y0: usize, x1: usize, y1: usize, r: u8, g: u8, b: u8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> engine/src/renderer.rs:1377:17 [INFO] [stdout] | [INFO] [stdout] 1377 | fb.rgba[off] = fb.rgba[off] / 3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fb.rgba[off] /= 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> engine/src/renderer.rs:1378:17 [INFO] [stdout] | [INFO] [stdout] 1378 | fb.rgba[off + 1] = fb.rgba[off + 1] / 3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fb.rgba[off + 1] /= 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> engine/src/renderer.rs:1379:17 [INFO] [stdout] | [INFO] [stdout] 1379 | fb.rgba[off + 2] = fb.rgba[off + 2] / 3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fb.rgba[off + 2] /= 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `row` is used to index `bitmap` [INFO] [stdout] --> engine/src/renderer.rs:1387:20 [INFO] [stdout] | [INFO] [stdout] 1387 | for row in 0..7 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 1387 - for row in 0..7 { [INFO] [stdout] 1387 + for (row, ) in bitmap.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> engine/src/renderer.rs:1482:32 [INFO] [stdout] | [INFO] [stdout] 1482 | let intensity: u8 = if y < 68 || y > 132 { 15 } else { 30 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `!(68..=132).contains(&y)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> engine/src/renderer.rs:1521:8 [INFO] [stdout] | [INFO] [stdout] 1521 | if (tick / 8) % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace with: `(tick / 8).is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `row` is used to index `bitmap` [INFO] [stdout] --> engine/src/renderer.rs:1535:20 [INFO] [stdout] | [INFO] [stdout] 1535 | for row in 0..7 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 1535 - for row in 0..7 { [INFO] [stdout] 1535 + for (row, ) in bitmap.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> engine/src/renderer.rs:1549:1 [INFO] [stdout] | [INFO] [stdout] 1549 | / fn draw_title_letter( [INFO] [stdout] 1550 | | fb: &mut Framebuffer, [INFO] [stdout] 1551 | | x: usize, y: usize, [INFO] [stdout] 1552 | | glyph: &[u16], [INFO] [stdout] ... | [INFO] [stdout] 1555 | | tick: u64, [INFO] [stdout] 1556 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking doom-wasm v0.1.0 (/opt/rustwide/workdir/wasm) [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DoomGame` [INFO] [stdout] --> wasm/src/lib.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | / pub fn new() -> Self { [INFO] [stdout] 31 | | let map = DoomMap::e1m1(); [INFO] [stdout] 32 | | let state = GameState::new(map); [INFO] [stdout] 33 | | Self { [INFO] [stdout] ... | [INFO] [stdout] 39 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 28 + impl Default for DoomGame { [INFO] [stdout] 29 + fn default() -> Self { [INFO] [stdout] 30 + Self::new() [INFO] [stdout] 31 + } [INFO] [stdout] 32 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DoomGame` [INFO] [stdout] --> wasm/src/lib.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | / pub fn new() -> Self { [INFO] [stdout] 31 | | let map = DoomMap::e1m1(); [INFO] [stdout] 32 | | let state = GameState::new(map); [INFO] [stdout] 33 | | Self { [INFO] [stdout] ... | [INFO] [stdout] 39 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 28 + impl Default for DoomGame { [INFO] [stdout] 29 + fn default() -> Self { [INFO] [stdout] 30 + Self::new() [INFO] [stdout] 31 + } [INFO] [stdout] 32 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> engine/tests/engine_tests.rs:316:13 [INFO] [stdout] | [INFO] [stdout] 316 | assert!(state.player.x <= old_x || state.player.y != old_y || (state.player.x == old_x && state.player.y == old_y)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 316 - assert!(state.player.x <= old_x || state.player.y != old_y || (state.player.x == old_x && state.player.y == old_y)); [INFO] [stdout] 316 + assert!(!(state.player.x > old_x && state.player.y == old_y && state.player.x != old_x)); [INFO] [stdout] | [INFO] [stdout] 316 - assert!(state.player.x <= old_x || state.player.y != old_y || (state.player.x == old_x && state.player.y == old_y)); [INFO] [stdout] 316 + assert!(state.player.x <= old_x || state.player.y != old_y || state.player.x == old_x); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> engine/tests/engine_tests.rs:546:9 [INFO] [stdout] | [INFO] [stdout] 546 | state.effects.len() > 0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!state.effects.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Framebuffer` [INFO] [stdout] --> engine/src/renderer.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | / pub fn new() -> Self { [INFO] [stdout] 39 | | Self { [INFO] [stdout] 40 | | rgba: vec![0u8; FRAMEBUFFER_SIZE * 4], [INFO] [stdout] 41 | | } [INFO] [stdout] 42 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 37 + impl Default for Framebuffer { [INFO] [stdout] 38 + fn default() -> Self { [INFO] [stdout] 39 + Self::new() [INFO] [stdout] 40 + } [INFO] [stdout] 41 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `col` is used to index `depth_buf` [INFO] [stdout] --> engine/src/renderer.rs:131:16 [INFO] [stdout] | [INFO] [stdout] 131 | for col in 0..SCREEN_WIDTH { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 131 - for col in 0..SCREEN_WIDTH { [INFO] [stdout] 131 + for (col, ) in depth_buf.iter_mut().enumerate().take(SCREEN_WIDTH) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `col` is used to index `wall_cols` [INFO] [stdout] --> engine/src/renderer.rs:201:16 [INFO] [stdout] | [INFO] [stdout] 201 | for col in 0..SCREEN_WIDTH { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 201 - for col in 0..SCREEN_WIDTH { [INFO] [stdout] 201 + for (col, ) in wall_cols.iter().enumerate().take(SCREEN_WIDTH) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual checked division [INFO] [stdout] --> engine/src/renderer.rs:211:28 [INFO] [stdout] | [INFO] [stdout] 211 | let tex_v = if wc.wall_height > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ check performed here [INFO] [stdout] 212 | (y_in_wall * tex_h / wc.wall_height) % tex_h [INFO] [stdout] | ------------------------------------ division performed here [INFO] [stdout] | [INFO] [stdout] = help: consider using `checked_div` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_checked_ops [INFO] [stdout] = note: `#[warn(clippy::manual_checked_ops)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `col` is used to index `wall_cols` [INFO] [stdout] --> engine/src/renderer.rs:228:16 [INFO] [stdout] | [INFO] [stdout] 228 | for col in 0..SCREEN_WIDTH { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 228 - for col in 0..SCREEN_WIDTH { [INFO] [stdout] 228 + for (col, ) in wall_cols.iter().enumerate().take(SCREEN_WIDTH) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> engine/src/renderer.rs:342:33 [INFO] [stdout] | [INFO] [stdout] 342 | let pulse = ((state.tick as f64 * 0.15).sin() * 0.3 + 0.7) as f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((state.tick as f64 * 0.15).sin() * 0.3 + 0.7)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> engine/src/renderer.rs:710:5 [INFO] [stdout] | [INFO] [stdout] 710 | sprite_list.sort_by(|a, b| b.distance.cmp(&a.distance)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 710 - sprite_list.sort_by(|a, b| b.distance.cmp(&a.distance)); [INFO] [stdout] 710 + sprite_list.sort_by_key(|b| std::cmp::Reverse(b.distance)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `digits` [INFO] [stdout] --> engine/src/renderer.rs:973:14 [INFO] [stdout] | [INFO] [stdout] 973 | for i in 0..num_digits { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 973 - for i in 0..num_digits { [INFO] [stdout] 973 + for in digits.iter().take(num_digits) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> engine/src/renderer.rs:1019:15 [INFO] [stdout] | [INFO] [stdout] 1019 | let val = value.max(0).min(999); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `value.clamp(0, 999)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `row` is used to index `glyph` [INFO] [stdout] --> engine/src/renderer.rs:1053:16 [INFO] [stdout] | [INFO] [stdout] 1053 | for row in 0..5 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 1053 - for row in 0..5 { [INFO] [stdout] 1053 + for (row, ) in glyph.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> engine/src/renderer.rs:1079:22 [INFO] [stdout] | [INFO] [stdout] 1079 | let dir = if angle_norm < 1047 || angle_norm > 5236 { "0" } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(1047..=5236).contains(&angle_norm)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> engine/src/renderer.rs:1325:1 [INFO] [stdout] | [INFO] [stdout] 1325 | fn automap_line(fb: &mut Framebuffer, x0: usize, y0: usize, x1: usize, y1: usize, r: u8, g: u8, b: u8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> engine/src/renderer.rs:1377:17 [INFO] [stdout] | [INFO] [stdout] 1377 | fb.rgba[off] = fb.rgba[off] / 3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fb.rgba[off] /= 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> engine/src/renderer.rs:1378:17 [INFO] [stdout] | [INFO] [stdout] 1378 | fb.rgba[off + 1] = fb.rgba[off + 1] / 3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fb.rgba[off + 1] /= 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> engine/src/renderer.rs:1379:17 [INFO] [stdout] | [INFO] [stdout] 1379 | fb.rgba[off + 2] = fb.rgba[off + 2] / 3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fb.rgba[off + 2] /= 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `row` is used to index `bitmap` [INFO] [stdout] --> engine/src/renderer.rs:1387:20 [INFO] [stdout] | [INFO] [stdout] 1387 | for row in 0..7 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 1387 - for row in 0..7 { [INFO] [stdout] 1387 + for (row, ) in bitmap.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> engine/src/renderer.rs:1482:32 [INFO] [stdout] | [INFO] [stdout] 1482 | let intensity: u8 = if y < 68 || y > 132 { 15 } else { 30 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `!(68..=132).contains(&y)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> engine/src/renderer.rs:1521:8 [INFO] [stdout] | [INFO] [stdout] 1521 | if (tick / 8) % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace with: `(tick / 8).is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `row` is used to index `bitmap` [INFO] [stdout] --> engine/src/renderer.rs:1535:20 [INFO] [stdout] | [INFO] [stdout] 1535 | for row in 0..7 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 1535 - for row in 0..7 { [INFO] [stdout] 1535 + for (row, ) in bitmap.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> engine/src/renderer.rs:1549:1 [INFO] [stdout] | [INFO] [stdout] 1549 | / fn draw_title_letter( [INFO] [stdout] 1550 | | fb: &mut Framebuffer, [INFO] [stdout] 1551 | | x: usize, y: usize, [INFO] [stdout] 1552 | | glyph: &[u16], [INFO] [stdout] ... | [INFO] [stdout] 1555 | | tick: u64, [INFO] [stdout] 1556 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking sp-version v22.0.0 (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stderr] Checking sp-staking v4.0.0-dev (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stderr] Checking sp-inherents v4.0.0-dev (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stderr] Checking sp-api v4.0.0-dev (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stderr] Checking sp-genesis-builder v0.1.0 (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stderr] Checking doom-runtime-api v0.1.0 (/opt/rustwide/workdir/doom-runtime-api) [INFO] [stderr] Checking frame-support v4.0.0-dev (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stderr] Checking frame-system v4.0.0-dev (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.1.0#e57fad1b) [INFO] [stderr] Checking pallet-doom v0.1.0 (/opt/rustwide/workdir/pallet-doom) [INFO] [stdout] warning: unused import: `alloc::vec` [INFO] [stdout] --> pallet-doom/src/lib.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use alloc::vec; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `alloc::vec` [INFO] [stdout] --> pallet-doom/src/lib.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use alloc::vec; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 29s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: trie-db v0.27.1 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "9596ee439fec74455e5a4311a316cd26f20d03cbf0ef550874aaf472a07b5316", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9596ee439fec74455e5a4311a316cd26f20d03cbf0ef550874aaf472a07b5316", kill_on_drop: false }` [INFO] [stdout] 9596ee439fec74455e5a4311a316cd26f20d03cbf0ef550874aaf472a07b5316