[INFO] cloning repository https://github.com/matklad/quadheap [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/matklad/quadheap" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmatklad%2Fquadheap", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmatklad%2Fquadheap'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 91eb33870fc49280dda1e9be1fa904fc93d7364c [INFO] linting matklad/quadheap against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmatklad%2Fquadheap" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/matklad/quadheap [INFO] finished tweaking git repo https://github.com/matklad/quadheap [INFO] tweaked toml for git repo https://github.com/matklad/quadheap written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/matklad/quadheap on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/matklad/quadheap already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded fastrand v1.3.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 463ca8ad6b0e2d7d693b36cba37d2371e57249b172ea0bc3f6eeba3cf590364f [INFO] running `Command { std: "docker" "start" "-a" "463ca8ad6b0e2d7d693b36cba37d2371e57249b172ea0bc3f6eeba3cf590364f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "463ca8ad6b0e2d7d693b36cba37d2371e57249b172ea0bc3f6eeba3cf590364f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "463ca8ad6b0e2d7d693b36cba37d2371e57249b172ea0bc3f6eeba3cf590364f", kill_on_drop: false }` [INFO] [stdout] 463ca8ad6b0e2d7d693b36cba37d2371e57249b172ea0bc3f6eeba3cf590364f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4b8bc8393e4fa22514651e0d160254f46f95e3c791e0857dce114b6b7ba23459 [INFO] running `Command { std: "docker" "start" "-a" "4b8bc8393e4fa22514651e0d160254f46f95e3c791e0857dce114b6b7ba23459", kill_on_drop: false }` [INFO] [stderr] Checking fastrand v1.3.5 [INFO] [stderr] Checking heaps v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin_heap.rs:37:16 [INFO] [stdout] | [INFO] [stdout] 37 | if !(c2_idx < self.vec.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(c2_idx >= self.vec.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin_heap.rs:38:47 [INFO] [stdout] | [INFO] [stdout] 38 | if c1_idx < self.vec.len() && !(self.vec[idx] <= self.vec[c1_idx]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.vec[idx] > self.vec[c1_idx])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/quad_heap.rs:51:16 [INFO] [stdout] | [INFO] [stdout] 51 | if !(c4_idx < self.vec.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(c4_idx >= self.vec.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/quad_heap.rs:60:24 [INFO] [stdout] | [INFO] [stdout] 60 | if !(self.vec[idx] <= self.vec[c1_idx + c_idx]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.vec[idx] > self.vec[c1_idx + c_idx])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HEAP` contains a capitalized acronym [INFO] [stdout] --> src/main.rs:7:6 [INFO] [stdout] | [INFO] [stdout] 7 | type HEAP = quad_heap::QuadHeap; [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Heap` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin_heap.rs:37:16 [INFO] [stdout] | [INFO] [stdout] 37 | if !(c2_idx < self.vec.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(c2_idx >= self.vec.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin_heap.rs:38:47 [INFO] [stdout] | [INFO] [stdout] 38 | if c1_idx < self.vec.len() && !(self.vec[idx] <= self.vec[c1_idx]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.vec[idx] > self.vec[c1_idx])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/quad_heap.rs:51:16 [INFO] [stdout] | [INFO] [stdout] 51 | if !(c4_idx < self.vec.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(c4_idx >= self.vec.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/quad_heap.rs:60:24 [INFO] [stdout] | [INFO] [stdout] 60 | if !(self.vec[idx] <= self.vec[c1_idx + c_idx]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.vec[idx] > self.vec[c1_idx + c_idx])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HEAP` contains a capitalized acronym [INFO] [stdout] --> src/main.rs:7:6 [INFO] [stdout] | [INFO] [stdout] 7 | type HEAP = quad_heap::QuadHeap; [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Heap` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.33s [INFO] running `Command { std: "docker" "inspect" "4b8bc8393e4fa22514651e0d160254f46f95e3c791e0857dce114b6b7ba23459", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4b8bc8393e4fa22514651e0d160254f46f95e3c791e0857dce114b6b7ba23459", kill_on_drop: false }` [INFO] [stdout] 4b8bc8393e4fa22514651e0d160254f46f95e3c791e0857dce114b6b7ba23459