[INFO] cloning repository https://github.com/materusPL/currency-exchange-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/materusPL/currency-exchange-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FmaterusPL%2Fcurrency-exchange-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FmaterusPL%2Fcurrency-exchange-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d0ea16c0b068085fb994f1c2abadcadb5520535d [INFO] linting materusPL/currency-exchange-rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FmaterusPL%2Fcurrency-exchange-rust" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/materusPL/currency-exchange-rust [INFO] finished tweaking git repo https://github.com/materusPL/currency-exchange-rust [INFO] tweaked toml for git repo https://github.com/materusPL/currency-exchange-rust written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/materusPL/currency-exchange-rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/materusPL/currency-exchange-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rkyv_derive v0.7.44 [INFO] [stderr] Downloaded rend v0.4.2 [INFO] [stderr] Downloaded uuid v1.8.0 [INFO] [stderr] Downloaded proc-macro2 v1.0.79 [INFO] [stderr] Downloaded rust_decimal_macros v1.34.2 [INFO] [stderr] Downloaded bytecheck_derive v0.6.12 [INFO] [stderr] Downloaded bytecheck v0.6.12 [INFO] [stderr] Downloaded rusty-money v0.4.1 [INFO] [stderr] Downloaded clap_derive v4.5.3 [INFO] [stderr] Downloaded clap v4.5.3 [INFO] [stderr] Downloaded hashlink v0.9.0 [INFO] [stderr] Downloaded openssl-sys v0.9.101 [INFO] [stderr] Downloaded rkyv v0.7.44 [INFO] [stderr] Downloaded rust_decimal v1.34.3 [INFO] [stderr] Downloaded cc v1.0.90 [INFO] [stderr] Downloaded h2 v0.4.3 [INFO] [stderr] Downloaded reqwest v0.12.0 [INFO] [stderr] Downloaded rusqlite v0.31.0 [INFO] [stderr] Downloaded hyper v1.2.0 [INFO] [stderr] Downloaded indexmap v2.2.5 [INFO] [stderr] Downloaded syn v2.0.53 [INFO] [stderr] Downloaded borsh v1.3.1 [INFO] [stderr] Downloaded borsh-derive v1.3.1 [INFO] [stderr] Downloaded tokio v1.36.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1ab53ca6e0e9092aec9b249051c4aabf4cf2df74b59db2f2d335f921ea3f1e3f [INFO] running `Command { std: "docker" "start" "-a" "1ab53ca6e0e9092aec9b249051c4aabf4cf2df74b59db2f2d335f921ea3f1e3f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1ab53ca6e0e9092aec9b249051c4aabf4cf2df74b59db2f2d335f921ea3f1e3f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ab53ca6e0e9092aec9b249051c4aabf4cf2df74b59db2f2d335f921ea3f1e3f", kill_on_drop: false }` [INFO] [stdout] 1ab53ca6e0e9092aec9b249051c4aabf4cf2df74b59db2f2d335f921ea3f1e3f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bc5ab08e7266bc0b6d258accc65ce1a99f65bff94e39359b1d57e556c3e626ac [INFO] running `Command { std: "docker" "start" "-a" "bc5ab08e7266bc0b6d258accc65ce1a99f65bff94e39359b1d57e556c3e626ac", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking allocator-api2 v0.2.16 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling rust_decimal v1.34.3 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Compiling arrayvec v0.7.4 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Compiling syn v2.0.53 [INFO] [stderr] Compiling openssl-sys v0.9.101 [INFO] [stderr] Compiling libsqlite3-sys v0.28.0 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking indexmap v2.2.5 [INFO] [stderr] Checking hashlink v0.9.0 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Compiling rust_decimal_macros v1.34.2 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling clap_derive v4.5.3 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking h2 v0.4.3 [INFO] [stderr] Checking clap v4.5.3 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking rusty-money v0.4.1 [INFO] [stderr] Checking hyper v1.2.0 [INFO] [stderr] Checking hyper-util v0.1.3 [INFO] [stderr] Checking rusqlite v0.31.0 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.0 [INFO] [stderr] Checking currency-exchange v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: accessing first element with `code.get(0)` [INFO] [stdout] --> src/cache.rs:142:10 [INFO] [stdout] | [INFO] [stdout] 142 | [code.get(0), code.get(1)], [INFO] [stdout] | ^^^^^^^^^^^ help: try: `code.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/config.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | let ret: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `ret` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 23 ~ [INFO] [stdout] 24 ~ let ret: String = match var_os(REST_ENDPOINT_ENV_NAME) { [INFO] [stdout] 25 ~ Some(val) => val.to_str().unwrap().to_string(), [INFO] [stdout] 26 ~ None => REST_ENDPOINT.to_string(), [INFO] [stdout] 27 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/exchange.rs:56:40 [INFO] [stdout] | [INFO] [stdout] 56 | let dec_amount = Decimal::from_str(&value).unwrap(); [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: items after a test module [INFO] [stdout] --> src/requests.rs:32:1 [INFO] [stdout] | [INFO] [stdout] 32 | mod test { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 79 | pub fn get_rates(code: &String) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 112 | pub fn get_currencies() -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_test_module [INFO] [stdout] = note: `#[warn(clippy::items_after_test_module)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INVALID` contains a capitalized acronym [INFO] [stdout] --> src/requests.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | INVALID, [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Invalid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LIMIT` contains a capitalized acronym [INFO] [stdout] --> src/requests.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | LIMIT, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Limit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ERROR` contains a capitalized acronym [INFO] [stdout] --> src/requests.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | ERROR, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Error` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `code.get(0)` [INFO] [stdout] --> src/cache.rs:142:10 [INFO] [stdout] | [INFO] [stdout] 142 | [code.get(0), code.get(1)], [INFO] [stdout] | ^^^^^^^^^^^ help: try: `code.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/requests.rs:33:33 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn mock_get_rates(code: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 33 ~ pub fn mock_get_rates(code: &str) -> Result { [INFO] [stdout] 34 ~ let response: super::ConversionRates = match code { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/requests.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | return Ok(super::Status::OK); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return Ok(super::Status::OK); [INFO] [stdout] 75 + Ok(super::Status::OK) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/config.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | let ret: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `ret` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 23 ~ [INFO] [stdout] 24 ~ let ret: String = match var_os(REST_ENDPOINT_ENV_NAME) { [INFO] [stdout] 25 ~ Some(val) => val.to_str().unwrap().to_string(), [INFO] [stdout] 26 ~ None => REST_ENDPOINT.to_string(), [INFO] [stdout] 27 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/exchange.rs:56:40 [INFO] [stdout] | [INFO] [stdout] 56 | let dec_amount = Decimal::from_str(&value).unwrap(); [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INVALID` contains a capitalized acronym [INFO] [stdout] --> src/requests.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | INVALID, [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Invalid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LIMIT` contains a capitalized acronym [INFO] [stdout] --> src/requests.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | LIMIT, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Limit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ERROR` contains a capitalized acronym [INFO] [stdout] --> src/requests.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | ERROR, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Error` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/requests.rs:79:24 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn get_rates(code: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 79 - pub fn get_rates(code: &String) -> Result { [INFO] [stdout] 79 + pub fn get_rates(code: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:116:12 [INFO] [stdout] | [INFO] [stdout] 116 | if !(cache::get_api_key() [INFO] [stdout] | ____________^ [INFO] [stdout] 117 | | .expect("Error while getting api key") [INFO] [stdout] 118 | | .len() [INFO] [stdout] 119 | | > 0) [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 116 ~ if (cache::get_api_key() [INFO] [stdout] 117 + .expect("Error while getting api key") [INFO] [stdout] 118 + .len() <= 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:116:14 [INFO] [stdout] | [INFO] [stdout] 116 | if !(cache::get_api_key() [INFO] [stdout] | ______________^ [INFO] [stdout] 117 | | .expect("Error while getting api key") [INFO] [stdout] 118 | | .len() [INFO] [stdout] 119 | | > 0) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] help: using `!is_empty` is clearer and more explicit [INFO] [stdout] | [INFO] [stdout] 116 ~ if !(!cache::get_api_key() [INFO] [stdout] 117 ~ .expect("Error while getting api key").is_empty()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:165:25 [INFO] [stdout] | [INFO] [stdout] 165 | let mut key_setup = cache::get_api_key() [INFO] [stdout] | _________________________^ [INFO] [stdout] 166 | | .expect("Error while getting api key") [INFO] [stdout] 167 | | .len() [INFO] [stdout] 168 | | > 0; [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] help: using `!is_empty` is clearer and more explicit [INFO] [stdout] | [INFO] [stdout] 165 ~ let mut key_setup = !cache::get_api_key() [INFO] [stdout] 166 ~ .expect("Error while getting api key").is_empty(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:178:21 [INFO] [stdout] | [INFO] [stdout] 178 | key_setup = cache::get_api_key() [INFO] [stdout] | _____________________^ [INFO] [stdout] 179 | | .expect("Error while getting api key") [INFO] [stdout] 180 | | .len() [INFO] [stdout] 181 | | > 0; [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] help: using `!is_empty` is clearer and more explicit [INFO] [stdout] | [INFO] [stdout] 178 ~ key_setup = !cache::get_api_key() [INFO] [stdout] 179 ~ .expect("Error while getting api key").is_empty(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:116:12 [INFO] [stdout] | [INFO] [stdout] 116 | if !(cache::get_api_key() [INFO] [stdout] | ____________^ [INFO] [stdout] 117 | | .expect("Error while getting api key") [INFO] [stdout] 118 | | .len() [INFO] [stdout] 119 | | > 0) [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 116 ~ if (cache::get_api_key() [INFO] [stdout] 117 + .expect("Error while getting api key") [INFO] [stdout] 118 + .len() <= 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:116:14 [INFO] [stdout] | [INFO] [stdout] 116 | if !(cache::get_api_key() [INFO] [stdout] | ______________^ [INFO] [stdout] 117 | | .expect("Error while getting api key") [INFO] [stdout] 118 | | .len() [INFO] [stdout] 119 | | > 0) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] help: using `!is_empty` is clearer and more explicit [INFO] [stdout] | [INFO] [stdout] 116 ~ if !(!cache::get_api_key() [INFO] [stdout] 117 ~ .expect("Error while getting api key").is_empty()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:165:25 [INFO] [stdout] | [INFO] [stdout] 165 | let mut key_setup = cache::get_api_key() [INFO] [stdout] | _________________________^ [INFO] [stdout] 166 | | .expect("Error while getting api key") [INFO] [stdout] 167 | | .len() [INFO] [stdout] 168 | | > 0; [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] help: using `!is_empty` is clearer and more explicit [INFO] [stdout] | [INFO] [stdout] 165 ~ let mut key_setup = !cache::get_api_key() [INFO] [stdout] 166 ~ .expect("Error while getting api key").is_empty(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:178:21 [INFO] [stdout] | [INFO] [stdout] 178 | key_setup = cache::get_api_key() [INFO] [stdout] | _____________________^ [INFO] [stdout] 179 | | .expect("Error while getting api key") [INFO] [stdout] 180 | | .len() [INFO] [stdout] 181 | | > 0; [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] help: using `!is_empty` is clearer and more explicit [INFO] [stdout] | [INFO] [stdout] 178 ~ key_setup = !cache::get_api_key() [INFO] [stdout] 179 ~ .expect("Error while getting api key").is_empty(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 29.33s [INFO] running `Command { std: "docker" "inspect" "bc5ab08e7266bc0b6d258accc65ce1a99f65bff94e39359b1d57e556c3e626ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bc5ab08e7266bc0b6d258accc65ce1a99f65bff94e39359b1d57e556c3e626ac", kill_on_drop: false }` [INFO] [stdout] bc5ab08e7266bc0b6d258accc65ce1a99f65bff94e39359b1d57e556c3e626ac