[INFO] cloning repository https://github.com/martian17/uniscale
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/martian17/uniscale" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmartian17%2Funiscale", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmartian17%2Funiscale'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 724a0e1fc9e928a51d9027fba20210f592aac422
[INFO] linting martian17/uniscale against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmartian17%2Funiscale" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/martian17/uniscale
[INFO] finished tweaking git repo https://github.com/martian17/uniscale
[INFO] tweaked toml for git repo https://github.com/martian17/uniscale written to /workspace/builds/worker-7-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/martian17/uniscale on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/martian17/uniscale already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 4e86ac358ce1b356a45fd13fc745da4c6c0b7e783f9001571c7a7947b0763110
[INFO] running `Command { std: "docker" "start" "-a" "4e86ac358ce1b356a45fd13fc745da4c6c0b7e783f9001571c7a7947b0763110", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "4e86ac358ce1b356a45fd13fc745da4c6c0b7e783f9001571c7a7947b0763110", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "4e86ac358ce1b356a45fd13fc745da4c6c0b7e783f9001571c7a7947b0763110", kill_on_drop: false }`
[INFO] [stdout] 4e86ac358ce1b356a45fd13fc745da4c6c0b7e783f9001571c7a7947b0763110
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 65ee5d9476f5ed6729ba820a6ff2986bbfd1a8997a19a10cccde8cfe5c8abf16
[INFO] running `Command { std: "docker" "start" "-a" "65ee5d9476f5ed6729ba820a6ff2986bbfd1a8997a19a10cccde8cfe5c8abf16", kill_on_drop: false }`
[INFO] [stderr]     Checking nicer-ticks v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/lib.rs:69:13
[INFO] [stdout]    |
[INFO] [stdout] 69 |             scale_builder: scale_builder,
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scale_builder`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/lib.rs:70:13
[INFO] [stdout]    |
[INFO] [stdout] 70 |             size: size,
[INFO] [stdout]    |             ^^^^^^^^^^ help: replace it with: `size`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lib.rs:129:13
[INFO] [stdout]     |
[INFO] [stdout] 129 |             name: name,
[INFO] [stdout]     |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/lib.rs:69:13
[INFO] [stdout]    |
[INFO] [stdout] 69 |             scale_builder: scale_builder,
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scale_builder`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/lib.rs:70:13
[INFO] [stdout]    |
[INFO] [stdout] 70 |             size: size,
[INFO] [stdout]    |             ^^^^^^^^^^ help: replace it with: `size`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lib.rs:129:13
[INFO] [stdout]     |
[INFO] [stdout] 129 |             name: name,
[INFO] [stdout]     |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lib.rs:16:5
[INFO] [stdout]    |
[INFO] [stdout] 16 |     return radix*n;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 16 -     return radix*n;
[INFO] [stdout] 16 +     radix*n
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lib.rs:37:9
[INFO] [stdout]    |
[INFO] [stdout] 37 |         return self.values.iter();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 37 -         return self.values.iter();
[INFO] [stdout] 37 +         self.values.iter()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lib.rs:67:9
[INFO] [stdout]    |
[INFO] [stdout] 67 | /         return Self{
[INFO] [stdout] 68 | |             name: "",
[INFO] [stdout] 69 | |             scale_builder: scale_builder,
[INFO] [stdout] 70 | |             size: size,
[INFO] [stdout] ...  |
[INFO] [stdout] 73 | |             starts_at: 0,
[INFO] [stdout] 74 | |         };
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 67 ~         Self{
[INFO] [stdout] 68 +             name: "",
[INFO] [stdout] 69 +             scale_builder: scale_builder,
[INFO] [stdout] 70 +             size: size,
[INFO] [stdout] 71 +             fmt_fn: None,
[INFO] [stdout] 72 +             tick_base: vec![2,5,10],
[INFO] [stdout] 73 +             starts_at: 0,
[INFO] [stdout] 74 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:107:9
[INFO] [stdout]     |
[INFO] [stdout] 107 | /         return Unit{
[INFO] [stdout] 108 | |             name: self.name,
[INFO] [stdout] 109 | |             tick_base: self.tick_base,
[INFO] [stdout] 110 | |             fmt_fn: self.fmt_fn,
[INFO] [stdout] 111 | |             size: self.size,
[INFO] [stdout] 112 | |             starts_at: self.starts_at,
[INFO] [stdout] 113 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 107 ~         Unit{
[INFO] [stdout] 108 +             name: self.name,
[INFO] [stdout] 109 +             tick_base: self.tick_base,
[INFO] [stdout] 110 +             fmt_fn: self.fmt_fn,
[INFO] [stdout] 111 +             size: self.size,
[INFO] [stdout] 112 +             starts_at: self.starts_at,
[INFO] [stdout] 113 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stdout]    --> src/lib.rs:121:26
[INFO] [stdout]     |
[INFO] [stdout] 121 |     from_unit_counts_fn: Option<fn(&CompositeUnit) -> Result<BaseNumType, ScaleError>>,
[INFO] [stdout]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stdout]     = note: `#[warn(clippy::type_complexity)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:128:9
[INFO] [stdout]     |
[INFO] [stdout] 128 | /         return Self {
[INFO] [stdout] 129 | |             name: name,
[INFO] [stdout] 130 | |             to_unit_counts_fn: None,
[INFO] [stdout] 131 | |             from_unit_counts_fn: None,
[INFO] [stdout] 132 | |             fmt_fn: None,
[INFO] [stdout] 133 | |             units: Vec::new(),
[INFO] [stdout] 134 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 128 ~         Self {
[INFO] [stdout] 129 +             name: name,
[INFO] [stdout] 130 +             to_unit_counts_fn: None,
[INFO] [stdout] 131 +             from_unit_counts_fn: None,
[INFO] [stdout] 132 +             fmt_fn: None,
[INFO] [stdout] 133 +             units: Vec::new(),
[INFO] [stdout] 134 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:160:9
[INFO] [stdout]     |
[INFO] [stdout] 160 | /         return Scale{
[INFO] [stdout] 161 | |             name: self.name,
[INFO] [stdout] 162 | |             to_unit_counts_fn: self.to_unit_counts_fn,
[INFO] [stdout] 163 | |             from_unit_counts_fn: self.from_unit_counts_fn,
[INFO] [stdout] 164 | |             fmt_fn: self.fmt_fn,
[INFO] [stdout] 165 | |             units: self.units.clone(),
[INFO] [stdout] 166 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 160 ~         Scale{
[INFO] [stdout] 161 +             name: self.name,
[INFO] [stdout] 162 +             to_unit_counts_fn: self.to_unit_counts_fn,
[INFO] [stdout] 163 +             from_unit_counts_fn: self.from_unit_counts_fn,
[INFO] [stdout] 164 +             fmt_fn: self.fmt_fn,
[INFO] [stdout] 165 +             units: self.units.clone(),
[INFO] [stdout] 166 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:171:9
[INFO] [stdout]     |
[INFO] [stdout] 171 |         return self.units.last();
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 171 -         return self.units.last();
[INFO] [stdout] 171 +         self.units.last()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:179:9
[INFO] [stdout]     |
[INFO] [stdout] 179 |         return None;
[INFO] [stdout]     |         ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 179 -         return None;
[INFO] [stdout] 179 +         None
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Iterator::find`
[INFO] [stdout]    --> src/lib.rs:174:9
[INFO] [stdout]     |
[INFO] [stdout] 174 | /         for unit in self.units.iter() {
[INFO] [stdout] 175 | |             if unit.name == name {
[INFO] [stdout] 176 | |                 return Some(unit);
[INFO] [stdout] ...   |
[INFO] [stdout] 179 | |         return None;
[INFO] [stdout]     | |____________________^ help: replace with an iterator: `self.units.iter().find(|&unit| unit.name == name).map(|v| v as _)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find
[INFO] [stdout]     = note: `#[warn(clippy::manual_find)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stdout]    --> src/lib.rs:187:26
[INFO] [stdout]     |
[INFO] [stdout] 187 |     from_unit_counts_fn: Option<fn(&CompositeUnit) -> Result<BaseNumType, ScaleError>>,
[INFO] [stdout]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:223:9
[INFO] [stdout]     |
[INFO] [stdout] 223 |         return None;
[INFO] [stdout]     |         ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 223 -         return None;
[INFO] [stdout] 223 +         None
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Iterator::find`
[INFO] [stdout]    --> src/lib.rs:218:9
[INFO] [stdout]     |
[INFO] [stdout] 218 | /         for unit in self.units.iter() {
[INFO] [stdout] 219 | |             if unit.name == name {
[INFO] [stdout] 220 | |                 return Some(unit);
[INFO] [stdout] ...   |
[INFO] [stdout] 223 | |         return None;
[INFO] [stdout]     | |____________________^ help: replace with an iterator: `self.units.iter().find(|&unit| unit.name == name).map(|v| v as _)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:237:9
[INFO] [stdout]     |
[INFO] [stdout] 237 |         return result;
[INFO] [stdout]     |         ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 237 -         return result;
[INFO] [stdout] 237 +         result
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait
[INFO] [stdout]    --> src/lib.rs:231:25
[INFO] [stdout]     |
[INFO] [stdout] 231 |         let mut value = value.clone();
[INFO] [stdout]     |                         ^^^^^^^^^^^^^ help: try removing the `clone` call: `value`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]     = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:248:9
[INFO] [stdout]     |
[INFO] [stdout] 248 |         return Ok(result);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 248 -         return Ok(result);
[INFO] [stdout] 248 +         Ok(result)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:264:9
[INFO] [stdout]     |
[INFO] [stdout] 264 |         return result;
[INFO] [stdout]     |         ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 264 -         return result;
[INFO] [stdout] 264 +         result
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lib.rs:259:16
[INFO] [stdout]     |
[INFO] [stdout] 259 |             if result.len() != 0 {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!result.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]     = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:267:9
[INFO] [stdout]     |
[INFO] [stdout] 267 |         return self.fmt_composite(&self.to_composite(value));
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 267 -         return self.fmt_composite(&self.to_composite(value));
[INFO] [stdout] 267 +         self.fmt_composite(&self.to_composite(value))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:271:13
[INFO] [stdout]     |
[INFO] [stdout] 271 |             return self.to_composite(value) == *composite_unit;
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 271 -             return self.to_composite(value) == *composite_unit;
[INFO] [stdout] 271 +             self.to_composite(value) == *composite_unit
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:273:13
[INFO] [stdout]     |
[INFO] [stdout] 273 |             return false;
[INFO] [stdout]     |             ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 273 -             return false;
[INFO] [stdout] 273 +             false
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:290:9
[INFO] [stdout]     |
[INFO] [stdout] 290 |         return composite;
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 290 -         return composite;
[INFO] [stdout] 290 +         composite
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:337:9
[INFO] [stdout]     |
[INFO] [stdout] 337 |         return ticks;
[INFO] [stdout]     |         ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 337 -         return ticks;
[INFO] [stdout] 337 +         ticks
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lib.rs:16:5
[INFO] [stdout]    |
[INFO] [stdout] 16 |     return radix*n;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 16 -     return radix*n;
[INFO] [stdout] 16 +     radix*n
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lib.rs:37:9
[INFO] [stdout]    |
[INFO] [stdout] 37 |         return self.values.iter();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 37 -         return self.values.iter();
[INFO] [stdout] 37 +         self.values.iter()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lib.rs:67:9
[INFO] [stdout]    |
[INFO] [stdout] 67 | /         return Self{
[INFO] [stdout] 68 | |             name: "",
[INFO] [stdout] 69 | |             scale_builder: scale_builder,
[INFO] [stdout] 70 | |             size: size,
[INFO] [stdout] ...  |
[INFO] [stdout] 73 | |             starts_at: 0,
[INFO] [stdout] 74 | |         };
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 67 ~         Self{
[INFO] [stdout] 68 +             name: "",
[INFO] [stdout] 69 +             scale_builder: scale_builder,
[INFO] [stdout] 70 +             size: size,
[INFO] [stdout] 71 +             fmt_fn: None,
[INFO] [stdout] 72 +             tick_base: vec![2,5,10],
[INFO] [stdout] 73 +             starts_at: 0,
[INFO] [stdout] 74 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:107:9
[INFO] [stdout]     |
[INFO] [stdout] 107 | /         return Unit{
[INFO] [stdout] 108 | |             name: self.name,
[INFO] [stdout] 109 | |             tick_base: self.tick_base,
[INFO] [stdout] 110 | |             fmt_fn: self.fmt_fn,
[INFO] [stdout] 111 | |             size: self.size,
[INFO] [stdout] 112 | |             starts_at: self.starts_at,
[INFO] [stdout] 113 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 107 ~         Unit{
[INFO] [stdout] 108 +             name: self.name,
[INFO] [stdout] 109 +             tick_base: self.tick_base,
[INFO] [stdout] 110 +             fmt_fn: self.fmt_fn,
[INFO] [stdout] 111 +             size: self.size,
[INFO] [stdout] 112 +             starts_at: self.starts_at,
[INFO] [stdout] 113 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stdout]    --> src/lib.rs:121:26
[INFO] [stdout]     |
[INFO] [stdout] 121 |     from_unit_counts_fn: Option<fn(&CompositeUnit) -> Result<BaseNumType, ScaleError>>,
[INFO] [stdout]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stdout]     = note: `#[warn(clippy::type_complexity)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:128:9
[INFO] [stdout]     |
[INFO] [stdout] 128 | /         return Self {
[INFO] [stdout] 129 | |             name: name,
[INFO] [stdout] 130 | |             to_unit_counts_fn: None,
[INFO] [stdout] 131 | |             from_unit_counts_fn: None,
[INFO] [stdout] 132 | |             fmt_fn: None,
[INFO] [stdout] 133 | |             units: Vec::new(),
[INFO] [stdout] 134 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 128 ~         Self {
[INFO] [stdout] 129 +             name: name,
[INFO] [stdout] 130 +             to_unit_counts_fn: None,
[INFO] [stdout] 131 +             from_unit_counts_fn: None,
[INFO] [stdout] 132 +             fmt_fn: None,
[INFO] [stdout] 133 +             units: Vec::new(),
[INFO] [stdout] 134 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:160:9
[INFO] [stdout]     |
[INFO] [stdout] 160 | /         return Scale{
[INFO] [stdout] 161 | |             name: self.name,
[INFO] [stdout] 162 | |             to_unit_counts_fn: self.to_unit_counts_fn,
[INFO] [stdout] 163 | |             from_unit_counts_fn: self.from_unit_counts_fn,
[INFO] [stdout] 164 | |             fmt_fn: self.fmt_fn,
[INFO] [stdout] 165 | |             units: self.units.clone(),
[INFO] [stdout] 166 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 160 ~         Scale{
[INFO] [stdout] 161 +             name: self.name,
[INFO] [stdout] 162 +             to_unit_counts_fn: self.to_unit_counts_fn,
[INFO] [stdout] 163 +             from_unit_counts_fn: self.from_unit_counts_fn,
[INFO] [stdout] 164 +             fmt_fn: self.fmt_fn,
[INFO] [stdout] 165 +             units: self.units.clone(),
[INFO] [stdout] 166 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:171:9
[INFO] [stdout]     |
[INFO] [stdout] 171 |         return self.units.last();
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 171 -         return self.units.last();
[INFO] [stdout] 171 +         self.units.last()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:179:9
[INFO] [stdout]     |
[INFO] [stdout] 179 |         return None;
[INFO] [stdout]     |         ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 179 -         return None;
[INFO] [stdout] 179 +         None
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Iterator::find`
[INFO] [stdout]    --> src/lib.rs:174:9
[INFO] [stdout]     |
[INFO] [stdout] 174 | /         for unit in self.units.iter() {
[INFO] [stdout] 175 | |             if unit.name == name {
[INFO] [stdout] 176 | |                 return Some(unit);
[INFO] [stdout] ...   |
[INFO] [stdout] 179 | |         return None;
[INFO] [stdout]     | |____________________^ help: replace with an iterator: `self.units.iter().find(|&unit| unit.name == name).map(|v| v as _)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find
[INFO] [stdout]     = note: `#[warn(clippy::manual_find)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stdout]    --> src/lib.rs:187:26
[INFO] [stdout]     |
[INFO] [stdout] 187 |     from_unit_counts_fn: Option<fn(&CompositeUnit) -> Result<BaseNumType, ScaleError>>,
[INFO] [stdout]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:223:9
[INFO] [stdout]     |
[INFO] [stdout] 223 |         return None;
[INFO] [stdout]     |         ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 223 -         return None;
[INFO] [stdout] 223 +         None
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Iterator::find`
[INFO] [stdout]    --> src/lib.rs:218:9
[INFO] [stdout]     |
[INFO] [stdout] 218 | /         for unit in self.units.iter() {
[INFO] [stdout] 219 | |             if unit.name == name {
[INFO] [stdout] 220 | |                 return Some(unit);
[INFO] [stdout] ...   |
[INFO] [stdout] 223 | |         return None;
[INFO] [stdout]     | |____________________^ help: replace with an iterator: `self.units.iter().find(|&unit| unit.name == name).map(|v| v as _)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:237:9
[INFO] [stdout]     |
[INFO] [stdout] 237 |         return result;
[INFO] [stdout]     |         ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 237 -         return result;
[INFO] [stdout] 237 +         result
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait
[INFO] [stdout]    --> src/lib.rs:231:25
[INFO] [stdout]     |
[INFO] [stdout] 231 |         let mut value = value.clone();
[INFO] [stdout]     |                         ^^^^^^^^^^^^^ help: try removing the `clone` call: `value`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]     = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:248:9
[INFO] [stdout]     |
[INFO] [stdout] 248 |         return Ok(result);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 248 -         return Ok(result);
[INFO] [stdout] 248 +         Ok(result)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:264:9
[INFO] [stdout]     |
[INFO] [stdout] 264 |         return result;
[INFO] [stdout]     |         ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 264 -         return result;
[INFO] [stdout] 264 +         result
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lib.rs:259:16
[INFO] [stdout]     |
[INFO] [stdout] 259 |             if result.len() != 0 {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!result.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]     = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:267:9
[INFO] [stdout]     |
[INFO] [stdout] 267 |         return self.fmt_composite(&self.to_composite(value));
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 267 -         return self.fmt_composite(&self.to_composite(value));
[INFO] [stdout] 267 +         self.fmt_composite(&self.to_composite(value))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:271:13
[INFO] [stdout]     |
[INFO] [stdout] 271 |             return self.to_composite(value) == *composite_unit;
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 271 -             return self.to_composite(value) == *composite_unit;
[INFO] [stdout] 271 +             self.to_composite(value) == *composite_unit
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:273:13
[INFO] [stdout]     |
[INFO] [stdout] 273 |             return false;
[INFO] [stdout]     |             ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 273 -             return false;
[INFO] [stdout] 273 +             false
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:290:9
[INFO] [stdout]     |
[INFO] [stdout] 290 |         return composite;
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 290 -         return composite;
[INFO] [stdout] 290 +         composite
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:337:9
[INFO] [stdout]     |
[INFO] [stdout] 337 |         return ticks;
[INFO] [stdout]     |         ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 337 -         return ticks;
[INFO] [stdout] 337 +         ticks
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> examples/datetime.rs:39:32
[INFO] [stdout]    |
[INFO] [stdout] 39 |               let is_leap_year = (year.rem_euclid(4) == 0)
[INFO] [stdout]    |  ________________________________^
[INFO] [stdout] 40 | |                 && !((year.rem_euclid(100) == 0) && !(year.rem_euclid(400) == 0));
[INFO] [stdout]    | |_________________________________________________________________________________^ help: try: `((year.rem_euclid(400) == 0) || year.rem_euclid(100) != 0) && (year.rem_euclid(4) == 0)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> examples/datetime.rs:40:20
[INFO] [stdout]    |
[INFO] [stdout] 40 |                 && !((year.rem_euclid(100) == 0) && !(year.rem_euclid(400) == 0));
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `year.rem_euclid(100) != 0 || (year.rem_euclid(400) == 0)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> examples/datetime.rs:40:53
[INFO] [stdout]    |
[INFO] [stdout] 40 |                 && !((year.rem_euclid(100) == 0) && !(year.rem_euclid(400) == 0));
[INFO] [stdout]    |                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(year.rem_euclid(400) != 0)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> examples/datetime.rs:67:13
[INFO] [stdout]    |
[INFO] [stdout] 67 |             return Ok(time_ms);
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 67 -             return Ok(time_ms);
[INFO] [stdout] 67 +             Ok(time_ms)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> examples/datetime.rs:94:32
[INFO] [stdout]    |
[INFO] [stdout] 94 |               let is_leap_year = (res_year.rem_euclid(4) == 0)
[INFO] [stdout]    |  ________________________________^
[INFO] [stdout] 95 | |                 && !((res_year.rem_euclid(100) == 0) && !(res_year.rem_euclid(400) == 0));
[INFO] [stdout]    | |_________________________________________________________________________________________^ help: try: `((res_year.rem_euclid(400) == 0) || res_year.rem_euclid(100) != 0) && (res_year.rem_euclid(4) == 0)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> examples/datetime.rs:95:20
[INFO] [stdout]    |
[INFO] [stdout] 95 |                 && !((res_year.rem_euclid(100) == 0) && !(res_year.rem_euclid(400) == 0));
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `res_year.rem_euclid(100) != 0 || (res_year.rem_euclid(400) == 0)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> examples/datetime.rs:95:57
[INFO] [stdout]    |
[INFO] [stdout] 95 |                 && !((res_year.rem_euclid(100) == 0) && !(res_year.rem_euclid(400) == 0));
[INFO] [stdout]    |                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(res_year.rem_euclid(400) != 0)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> examples/datetime.rs:125:13
[INFO] [stdout]     |
[INFO] [stdout] 125 | /             return CompositeUnit {
[INFO] [stdout] 126 | |                 values: vec![res_year, res_month, res_day, res_hour, res_minute, res_second, res_millisecond],
[INFO] [stdout] 127 | |                 sign: Sign::Positive,
[INFO] [stdout] 128 | |             };
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 125 ~             CompositeUnit {
[INFO] [stdout] 126 +                 values: vec![res_year, res_month, res_day, res_hour, res_minute, res_second, res_millisecond],
[INFO] [stdout] 127 +                 sign: Sign::Positive,
[INFO] [stdout] 128 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]    --> examples/datetime.rs:118:13
[INFO] [stdout]     |
[INFO] [stdout] 118 |             ms_tmp = ms_tmp%(60*60*1000);
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ms_tmp %= (60*60*1000)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout]     = note: `#[warn(clippy::assign_op_pattern)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]    --> examples/datetime.rs:120:13
[INFO] [stdout]     |
[INFO] [stdout] 120 |             ms_tmp = ms_tmp%(60*1000);
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ms_tmp %= (60*1000)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]    --> examples/datetime.rs:122:13
[INFO] [stdout]     |
[INFO] [stdout] 122 |             ms_tmp = ms_tmp%(1000);
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ms_tmp %= (1000)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.33s
[INFO] running `Command { std: "docker" "inspect" "65ee5d9476f5ed6729ba820a6ff2986bbfd1a8997a19a10cccde8cfe5c8abf16", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "65ee5d9476f5ed6729ba820a6ff2986bbfd1a8997a19a10cccde8cfe5c8abf16", kill_on_drop: false }`
[INFO] [stdout] 65ee5d9476f5ed6729ba820a6ff2986bbfd1a8997a19a10cccde8cfe5c8abf16