[INFO] cloning repository https://github.com/markmckeown/digby [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/markmckeown/digby" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmarkmckeown%2Fdigby", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmarkmckeown%2Fdigby'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] aeea62a250baefd690ab385ea72b4f508ab7da63 [INFO] linting markmckeown/digby against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmarkmckeown%2Fdigby" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/markmckeown/digby [INFO] finished tweaking git repo https://github.com/markmckeown/digby [INFO] tweaked toml for git repo https://github.com/markmckeown/digby written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/markmckeown/digby on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/markmckeown/digby already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a3209fc7d290c6f2fba99b16a0cd3a091ecea1cd5a1b9a381cf06c9714ed8771 [INFO] running `Command { std: "docker" "start" "-a" "a3209fc7d290c6f2fba99b16a0cd3a091ecea1cd5a1b9a381cf06c9714ed8771", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a3209fc7d290c6f2fba99b16a0cd3a091ecea1cd5a1b9a381cf06c9714ed8771", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a3209fc7d290c6f2fba99b16a0cd3a091ecea1cd5a1b9a381cf06c9714ed8771", kill_on_drop: false }` [INFO] [stdout] a3209fc7d290c6f2fba99b16a0cd3a091ecea1cd5a1b9a381cf06c9714ed8771 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2fcc9a76a017a8cbe6a80656668f66cb639e2be5446c6c05d77983a8c2bc549d [INFO] running `Command { std: "docker" "start" "-a" "2fcc9a76a017a8cbe6a80656668f66cb639e2be5446c6c05d77983a8c2bc549d", kill_on_drop: false }` [INFO] [stderr] Checking twox-hash v2.1.2 [INFO] [stderr] Checking xxhash-rust v0.8.15 [INFO] [stderr] Compiling generic-array v0.14.9 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking rustix v1.1.2 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking lz4_flex v0.11.5 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking tempfile v3.23.0 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking digby v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/file_layer.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | file_size % block_size as u64 == 0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `file_size.is_multiple_of(block_size as u64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `dir_page.left_key` after checking its variant with `is_none` [INFO] [stdout] --> src/store_tuple_processor.rs:202:35 [INFO] [stdout] | [INFO] [stdout] 194 | let tree_dir_entry: TreeDirEntry = if dir_page.left_key.is_none() { [INFO] [stdout] | ------------------------------ help: try: `if let Some() = dir_page.left_key` [INFO] [stdout] ... [INFO] [stdout] 202 | TreeDirEntry::new(dir_page.left_key.unwrap(), dir_page.page.get_page_number()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> tests/test_write.rs:59:51 [INFO] [stdout] | [INFO] [stdout] 59 | let mut file = OpenOptions::new().write(true).create(true).open(path)?; [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/page_cache.rs:68:52 [INFO] [stdout] | [INFO] [stdout] 68 | let file_layer = FileLayer::new(temp_file, PAGE_SIZE as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `PAGE_SIZE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/page_cache.rs:69:55 [INFO] [stdout] | [INFO] [stdout] 69 | let block_layer = BlockLayer::new(file_layer, PAGE_SIZE as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `PAGE_SIZE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `tuples.get(0)` [INFO] [stdout] --> src/tree_leaf_page.rs:399:17 [INFO] [stdout] | [INFO] [stdout] 399 | assert!(tuples.get(0).unwrap().get_key() == b"c".to_vec()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `tuples.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/file_layer.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | file_size % block_size as u64 == 0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `file_size.is_multiple_of(block_size as u64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/file_layer.rs:101:19 [INFO] [stdout] | [INFO] [stdout] 101 | .take(BLOCK_SIZE as usize) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `BLOCK_SIZE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `write_page_to_disk` doesn't need a mutable reference [INFO] [stdout] --> src/file_layer.rs:109:33 [INFO] [stdout] | [INFO] [stdout] 109 | .write_page_to_disk(&mut page, 0) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 109 - .write_page_to_disk(&mut page, 0) [INFO] [stdout] 109 + .write_page_to_disk(&page, 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/free_dir_page.rs:187:17 [INFO] [stdout] | [INFO] [stdout] 187 | count = count + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/free_page_tracker.rs:163:14 [INFO] [stdout] | [INFO] [stdout] 163 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/free_page_tracker.rs:169:44 [INFO] [stdout] | [INFO] [stdout] 169 | crate::FileLayer::new(db_file, crate::Db::BLOCK_SIZE as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `crate::Db::BLOCK_SIZE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/free_page_tracker.rs:171:48 [INFO] [stdout] | [INFO] [stdout] 171 | crate::BlockLayer::new(file_layer, crate::Db::BLOCK_SIZE as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `crate::Db::BLOCK_SIZE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `page_cache.generate_free_pages(1).get(0)` [INFO] [stdout] --> src/free_page_tracker.rs:174:33 [INFO] [stdout] | [INFO] [stdout] 174 | let free_dir_page_no = *page_cache.generate_free_pages(1).get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `page_cache.generate_free_pages(1).first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/leaf_page_handler.rs:139:13 [INFO] [stdout] | [INFO] [stdout] 139 | new_version = new_version + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_version += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/leaf_page_handler.rs:184:13 [INFO] [stdout] | [INFO] [stdout] 184 | new_version = new_version + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_version += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/leaf_page_handler.rs:215:13 [INFO] [stdout] | [INFO] [stdout] 215 | new_version = new_version + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_version += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/leaf_page_handler.rs:246:13 [INFO] [stdout] | [INFO] [stdout] 246 | new_version = new_version + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_version += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/leaf_page_handler.rs:247:13 [INFO] [stdout] | [INFO] [stdout] 247 | let value: Vec; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `value` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 247 ~ [INFO] [stdout] 248 ~ let value: Vec = if i == 0 { [INFO] [stdout] 249 ~ vec![0u8; 8] [INFO] [stdout] 250 | } else { [INFO] [stdout] 251 ~ vec![0u8; 2048] [INFO] [stdout] 252 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/leaf_page_handler.rs:280:13 [INFO] [stdout] | [INFO] [stdout] 280 | new_version = new_version + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_version += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/leaf_page_handler.rs:281:13 [INFO] [stdout] | [INFO] [stdout] 281 | let value: Vec; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `value` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 281 ~ [INFO] [stdout] 282 ~ let value: Vec = if i == 1 { [INFO] [stdout] 283 ~ vec![0u8; 8] [INFO] [stdout] 284 | } else { [INFO] [stdout] 285 ~ vec![0u8; 2048] [INFO] [stdout] 286 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/leaf_page_handler.rs:317:13 [INFO] [stdout] | [INFO] [stdout] 317 | new_version = new_version + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_version += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/leaf_page_handler.rs:319:13 [INFO] [stdout] | [INFO] [stdout] 319 | let value: Vec; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `value` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 319 ~ [INFO] [stdout] 320 ~ let value: Vec = if j == 3 { [INFO] [stdout] 321 ~ vec![0u8; 8] [INFO] [stdout] 322 | } else { [INFO] [stdout] 323 ~ vec![0u8; 2048] [INFO] [stdout] 324 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/tree_dir_handler.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | / let mut leaf_pages: Vec = Vec::new(); [INFO] [stdout] 145 | | leaf_pages.push(tree_leaf_page); [INFO] [stdout] 146 | | leaf_pages.push(tree_leaf_page1); [INFO] [stdout] | |_________________________________________^ help: consider using the `vec![]` macro: `let mut leaf_pages: Vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/tree_dir_handler.rs:170:9 [INFO] [stdout] | [INFO] [stdout] 170 | / leaf_pages = Vec::new(); [INFO] [stdout] 171 | | leaf_pages.push(tree_leaf_page); [INFO] [stdout] | |________________________________________^ help: consider using the `vec![]` macro: `leaf_pages = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/tree_dir_page.rs:451:9 [INFO] [stdout] | [INFO] [stdout] 451 | / let mut entries: Vec = Vec::new(); [INFO] [stdout] 452 | | entries.push(tree_dir_entry_1); [INFO] [stdout] 453 | | entries.push(tree_dir_entry_2); [INFO] [stdout] | |_______________________________________^ help: consider using the `vec![]` macro: `let mut entries: Vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/tree_dir_page.rs:466:9 [INFO] [stdout] | [INFO] [stdout] 466 | / entries = Vec::new(); [INFO] [stdout] 467 | | entries.push(tree_dir_entry_3); [INFO] [stdout] | |_______________________________________^ help: consider using the `vec![]` macro: `mut entries = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/tree_dir_page.rs:474:9 [INFO] [stdout] | [INFO] [stdout] 474 | / entries = Vec::new(); [INFO] [stdout] 475 | | entries.push(tree_dir_entry_4); [INFO] [stdout] | |_______________________________________^ help: consider using the `vec![]` macro: `entries = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/tree_dir_page.rs:487:9 [INFO] [stdout] | [INFO] [stdout] 487 | / let mut entries: Vec = Vec::new(); [INFO] [stdout] 488 | | entries.push(tree_dir_entry_1); [INFO] [stdout] 489 | | entries.push(tree_dir_entry_2); [INFO] [stdout] | |_______________________________________^ help: consider using the `vec![]` macro: `let mut entries: Vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `tree_dir_page [INFO] [stdout] .get_all_dir_entries().get(0)` [INFO] [stdout] --> src/tree_dir_page.rs:494:13 [INFO] [stdout] | [INFO] [stdout] 494 | / tree_dir_page [INFO] [stdout] 495 | | .get_all_dir_entries() [INFO] [stdout] 496 | | .get(0) [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 494 ~ tree_dir_page [INFO] [stdout] 495 + .get_all_dir_entries().first() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/tree_dir_page.rs:505:9 [INFO] [stdout] | [INFO] [stdout] 505 | / entries = Vec::new(); [INFO] [stdout] 506 | | entries.push(tree_dir_entry_3); [INFO] [stdout] 507 | | entries.push(tree_dir_entry_4); [INFO] [stdout] | |_______________________________________^ help: consider using the `vec![]` macro: `mut entries = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `tree_dir_page [INFO] [stdout] .get_all_dir_entries().get(0)` [INFO] [stdout] --> src/tree_dir_page.rs:511:13 [INFO] [stdout] | [INFO] [stdout] 511 | / tree_dir_page [INFO] [stdout] 512 | | .get_all_dir_entries() [INFO] [stdout] 513 | | .get(0) [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 511 ~ tree_dir_page [INFO] [stdout] 512 + .get_all_dir_entries().first() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/tree_dir_page.rs:533:9 [INFO] [stdout] | [INFO] [stdout] 533 | / entries = Vec::new(); [INFO] [stdout] 534 | | entries.push(tree_dir_entry_5); [INFO] [stdout] | |_______________________________________^ help: consider using the `vec![]` macro: `entries = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/tree_dir_page.rs:545:9 [INFO] [stdout] | [INFO] [stdout] 545 | / let mut entries: Vec = Vec::new(); [INFO] [stdout] 546 | | entries.push(tree_dir_entry_1); [INFO] [stdout] 547 | | entries.push(tree_dir_entry_2); [INFO] [stdout] 548 | | entries.push(tree_dir_entry_3); [INFO] [stdout] | |_______________________________________^ help: consider using the `vec![]` macro: `let mut entries: Vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `tree_dir_page [INFO] [stdout] .get_all_dir_entries().get(0)` [INFO] [stdout] --> src/tree_dir_page.rs:553:13 [INFO] [stdout] | [INFO] [stdout] 553 | / tree_dir_page [INFO] [stdout] 554 | | .get_all_dir_entries() [INFO] [stdout] 555 | | .get(0) [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 553 ~ tree_dir_page [INFO] [stdout] 554 + .get_all_dir_entries().first() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/tree_dir_page.rs:573:9 [INFO] [stdout] | [INFO] [stdout] 573 | / entries = Vec::new(); [INFO] [stdout] 574 | | entries.push(tree_dir_entry_4); [INFO] [stdout] 575 | | entries.push(tree_dir_entry_5); [INFO] [stdout] | |_______________________________________^ help: consider using the `vec![]` macro: `entries = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `tree_dir_page [INFO] [stdout] .get_all_dir_entries().get(0)` [INFO] [stdout] --> src/tree_dir_page.rs:579:13 [INFO] [stdout] | [INFO] [stdout] 579 | / tree_dir_page [INFO] [stdout] 580 | | .get_all_dir_entries() [INFO] [stdout] 581 | | .get(0) [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 579 ~ tree_dir_page [INFO] [stdout] 580 + .get_all_dir_entries().first() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/tree_dir_page.rs:614:9 [INFO] [stdout] | [INFO] [stdout] 614 | / let mut entries: Vec = Vec::new(); [INFO] [stdout] 615 | | entries.push(tree_dir_entry_1); [INFO] [stdout] 616 | | entries.push(tree_dir_entry_2); [INFO] [stdout] | |_______________________________________^ help: consider using the `vec![]` macro: `let entries: Vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/tree_dir_page.rs:620:39 [INFO] [stdout] | [INFO] [stdout] 620 | tree_dir_page.remove_key_page(&b"d".to_vec(), 45); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use: `b"d".as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/tree_dir_page.rs:623:39 [INFO] [stdout] | [INFO] [stdout] 623 | tree_dir_page.remove_key_page(&b"t".to_vec(), 75); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use: `b"t".as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/tree_dir_page.rs:633:9 [INFO] [stdout] | [INFO] [stdout] 633 | / let mut entries: Vec = Vec::new(); [INFO] [stdout] 634 | | entries.push(tree_dir_entry_1); [INFO] [stdout] 635 | | entries.push(tree_dir_entry_2); [INFO] [stdout] 636 | | entries.push(tree_dir_entry_3); [INFO] [stdout] | |_______________________________________^ help: consider using the `vec![]` macro: `let entries: Vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/tree_dir_page.rs:641:39 [INFO] [stdout] | [INFO] [stdout] 641 | tree_dir_page.remove_key_page(&b"t".to_vec(), 75); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use: `b"t".as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/tree_dir_page.rs:645:39 [INFO] [stdout] | [INFO] [stdout] 645 | tree_dir_page.remove_key_page(&b"e".to_vec(), 45); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use: `b"e".as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/tree_dir_page.rs:650:39 [INFO] [stdout] | [INFO] [stdout] 650 | tree_dir_page.remove_key_page(&b"z".to_vec(), 105); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use: `b"z".as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `dir_page.left_key` after checking its variant with `is_none` [INFO] [stdout] --> src/store_tuple_processor.rs:202:35 [INFO] [stdout] | [INFO] [stdout] 194 | let tree_dir_entry: TreeDirEntry = if dir_page.left_key.is_none() { [INFO] [stdout] | ------------------------------ help: try: `if let Some() = dir_page.left_key` [INFO] [stdout] ... [INFO] [stdout] 202 | TreeDirEntry::new(dir_page.left_key.unwrap(), dir_page.page.get_page_number()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/store_tuple_processor.rs:322:14 [INFO] [stdout] | [INFO] [stdout] 322 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/store_tuple_processor.rs:327:44 [INFO] [stdout] | [INFO] [stdout] 327 | crate::FileLayer::new(db_file, crate::Db::BLOCK_SIZE as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `crate::Db::BLOCK_SIZE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/store_tuple_processor.rs:329:48 [INFO] [stdout] | [INFO] [stdout] 329 | crate::BlockLayer::new(file_layer, crate::Db::BLOCK_SIZE as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `crate::Db::BLOCK_SIZE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `page_cache.generate_free_pages(1).get(0)` [INFO] [stdout] --> src/store_tuple_processor.rs:332:33 [INFO] [stdout] | [INFO] [stdout] 332 | let free_dir_page_no = *page_cache.generate_free_pages(1).get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `page_cache.generate_free_pages(1).first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `page_cache.generate_free_pages(1).get(0)` [INFO] [stdout] --> src/store_tuple_processor.rs:337:34 [INFO] [stdout] | [INFO] [stdout] 337 | let root_tree_page_no = *page_cache.generate_free_pages(1).get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `page_cache.generate_free_pages(1).first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/store_tuple_processor.rs:375:14 [INFO] [stdout] | [INFO] [stdout] 375 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/store_tuple_processor.rs:380:44 [INFO] [stdout] | [INFO] [stdout] 380 | crate::FileLayer::new(db_file, crate::Db::BLOCK_SIZE as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `crate::Db::BLOCK_SIZE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/store_tuple_processor.rs:382:48 [INFO] [stdout] | [INFO] [stdout] 382 | crate::BlockLayer::new(file_layer, crate::Db::BLOCK_SIZE as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `crate::Db::BLOCK_SIZE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `page_cache.generate_free_pages(1).get(0)` [INFO] [stdout] --> src/store_tuple_processor.rs:385:37 [INFO] [stdout] | [INFO] [stdout] 385 | let mut free_dir_page_no = *page_cache.generate_free_pages(1).get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `page_cache.generate_free_pages(1).first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `page_cache.generate_free_pages(1).get(0)` [INFO] [stdout] --> src/store_tuple_processor.rs:390:38 [INFO] [stdout] | [INFO] [stdout] 390 | let mut root_tree_page_no = *page_cache.generate_free_pages(1).get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `page_cache.generate_free_pages(1).first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/store_tuple_processor.rs:399:13 [INFO] [stdout] | [INFO] [stdout] 399 | version = version + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `version += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/store_tuple_processor.rs:501:17 [INFO] [stdout] | [INFO] [stdout] 501 | assert!(!tuple.is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `tuple.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/store_tuple_processor.rs:442:14 [INFO] [stdout] | [INFO] [stdout] 442 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/store_tuple_processor.rs:447:44 [INFO] [stdout] | [INFO] [stdout] 447 | crate::FileLayer::new(db_file, crate::Db::BLOCK_SIZE as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `crate::Db::BLOCK_SIZE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/store_tuple_processor.rs:449:48 [INFO] [stdout] | [INFO] [stdout] 449 | crate::BlockLayer::new(file_layer, crate::Db::BLOCK_SIZE as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `crate::Db::BLOCK_SIZE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `page_cache.generate_free_pages(1).get(0)` [INFO] [stdout] --> src/store_tuple_processor.rs:452:37 [INFO] [stdout] | [INFO] [stdout] 452 | let mut free_dir_page_no = *page_cache.generate_free_pages(1).get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `page_cache.generate_free_pages(1).first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `page_cache.generate_free_pages(1).get(0)` [INFO] [stdout] --> src/store_tuple_processor.rs:457:38 [INFO] [stdout] | [INFO] [stdout] 457 | let mut root_tree_page_no = *page_cache.generate_free_pages(1).get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `page_cache.generate_free_pages(1).first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/store_tuple_processor.rs:464:13 [INFO] [stdout] | [INFO] [stdout] 464 | version = version + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `version += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/overflow_page_handler.rs:112:14 [INFO] [stdout] | [INFO] [stdout] 112 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/overflow_page_handler.rs:121:44 [INFO] [stdout] | [INFO] [stdout] 121 | crate::FileLayer::new(db_file, crate::Db::BLOCK_SIZE as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `crate::Db::BLOCK_SIZE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/overflow_page_handler.rs:123:48 [INFO] [stdout] | [INFO] [stdout] 123 | crate::BlockLayer::new(file_layer, crate::Db::BLOCK_SIZE as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `crate::Db::BLOCK_SIZE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `page_cache.generate_free_pages(1).get(0)` [INFO] [stdout] --> src/overflow_page_handler.rs:127:33 [INFO] [stdout] | [INFO] [stdout] 127 | let free_dir_page_no = *page_cache.generate_free_pages(1).get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `page_cache.generate_free_pages(1).first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.77s [INFO] running `Command { std: "docker" "inspect" "2fcc9a76a017a8cbe6a80656668f66cb639e2be5446c6c05d77983a8c2bc549d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2fcc9a76a017a8cbe6a80656668f66cb639e2be5446c6c05d77983a8c2bc549d", kill_on_drop: false }` [INFO] [stdout] 2fcc9a76a017a8cbe6a80656668f66cb639e2be5446c6c05d77983a8c2bc549d