[INFO] cloning repository https://github.com/marioparaschiv/define [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/marioparaschiv/define" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmarioparaschiv%2Fdefine", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmarioparaschiv%2Fdefine'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3ee81f4cca84d28d31a15bc3d522a6a6a7971204 [INFO] linting marioparaschiv/define against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmarioparaschiv%2Fdefine" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/marioparaschiv/define [INFO] finished tweaking git repo https://github.com/marioparaschiv/define [INFO] tweaked toml for git repo https://github.com/marioparaschiv/define written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/marioparaschiv/define on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/marioparaschiv/define already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rustls-pki-types v1.8.0 [INFO] [stderr] Downloaded serde_derive v1.0.206 [INFO] [stderr] Downloaded clap v4.5.15 [INFO] [stderr] Downloaded cc v1.1.10 [INFO] [stderr] Downloaded indexmap v2.3.0 [INFO] [stderr] Downloaded serde v1.0.206 [INFO] [stderr] Downloaded syn v2.0.73 [INFO] [stderr] Downloaded object v0.36.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 50cc90f6f6cb718d01bf1aa554f57cea502ff159989894edef0c4da5b65b83ad [INFO] running `Command { std: "docker" "start" "-a" "50cc90f6f6cb718d01bf1aa554f57cea502ff159989894edef0c4da5b65b83ad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "50cc90f6f6cb718d01bf1aa554f57cea502ff159989894edef0c4da5b65b83ad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "50cc90f6f6cb718d01bf1aa554f57cea502ff159989894edef0c4da5b65b83ad", kill_on_drop: false }` [INFO] [stdout] 50cc90f6f6cb718d01bf1aa554f57cea502ff159989894edef0c4da5b65b83ad [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a540e5c1c9f9f0cadac444d860d7cdce3a2c443ace9d1734a3a6b6ce87fc99dc [INFO] running `Command { std: "docker" "start" "-a" "a540e5c1c9f9f0cadac444d860d7cdce3a2c443ace9d1734a3a6b6ce87fc99dc", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling cc v1.1.10 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking indexmap v2.3.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling syn v2.0.73 [INFO] [stderr] Compiling serde v1.0.206 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Compiling serde_json v1.0.122 [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking rustls-pemfile v2.1.3 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Compiling serde_derive v1.0.206 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking clap v4.5.15 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.5 [INFO] [stderr] Checking define v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use tokio; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use tokio; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/format.rs:15:2 [INFO] [stdout] | [INFO] [stdout] 15 | return value; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return value; [INFO] [stdout] 15 + value [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/format.rs:7:56 [INFO] [stdout] | [INFO] [stdout] 7 | let example = definition.example.as_deref().unwrap_or("".into()); [INFO] [stdout] | ^^^^^^^^^ help: consider removing `.into()`: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/format.rs:8:50 [INFO] [stdout] | [INFO] [stdout] 8 | let string: String = format!("\n\"{}\"", example.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/format.rs:10:36 [INFO] [stdout] | [INFO] [stdout] 10 | if (args.examples|| args.full) && example.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!example.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/format.rs:19:58 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn format_definitions(args: &Arguments, definitions: &Vec) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 19 - pub fn format_definitions(args: &Arguments, definitions: &Vec) -> String { [INFO] [stdout] 19 + pub fn format_definitions(args: &Arguments, definitions: &[Definition]) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/format.rs:24:15 [INFO] [stdout] | [INFO] [stdout] 24 | .join("\n".into()) [INFO] [stdout] | ^^^^^^^^^^^ help: consider removing `.into()`: `"\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/format.rs:31:52 [INFO] [stdout] | [INFO] [stdout] 31 | let synonyms = if (args.synonyms || args.full) && meaning.synonyms.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!meaning.synonyms.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/format.rs:39:52 [INFO] [stdout] | [INFO] [stdout] 39 | let antonyms = if (args.antonyms || args.full) && meaning.antonyms.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!meaning.antonyms.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/format.rs:56:52 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn format_meanings(args: &Arguments, meanings: &Vec) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 56 - pub fn format_meanings(args: &Arguments, meanings: &Vec) -> String { [INFO] [stdout] 56 + pub fn format_meanings(args: &Arguments, meanings: &[Meaning]) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/format.rs:61:15 [INFO] [stdout] | [INFO] [stdout] 61 | .join("\n\n".into()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `"\n\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/format.rs:79:71 [INFO] [stdout] | [INFO] [stdout] 79 | phonetic = format_phonetic(args, item.phonetic.as_deref().unwrap_or("".into()).to_string()), [INFO] [stdout] | ^^^^^^^^^ help: consider removing `.into()`: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/api.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | if !json.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `json.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/format.rs:15:2 [INFO] [stdout] | [INFO] [stdout] 15 | return value; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return value; [INFO] [stdout] 15 + value [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/format.rs:7:56 [INFO] [stdout] | [INFO] [stdout] 7 | let example = definition.example.as_deref().unwrap_or("".into()); [INFO] [stdout] | ^^^^^^^^^ help: consider removing `.into()`: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/format.rs:8:50 [INFO] [stdout] | [INFO] [stdout] 8 | let string: String = format!("\n\"{}\"", example.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/format.rs:10:36 [INFO] [stdout] | [INFO] [stdout] 10 | if (args.examples|| args.full) && example.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!example.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/format.rs:19:58 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn format_definitions(args: &Arguments, definitions: &Vec) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 19 - pub fn format_definitions(args: &Arguments, definitions: &Vec) -> String { [INFO] [stdout] 19 + pub fn format_definitions(args: &Arguments, definitions: &[Definition]) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/format.rs:24:15 [INFO] [stdout] | [INFO] [stdout] 24 | .join("\n".into()) [INFO] [stdout] | ^^^^^^^^^^^ help: consider removing `.into()`: `"\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/format.rs:31:52 [INFO] [stdout] | [INFO] [stdout] 31 | let synonyms = if (args.synonyms || args.full) && meaning.synonyms.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!meaning.synonyms.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/format.rs:39:52 [INFO] [stdout] | [INFO] [stdout] 39 | let antonyms = if (args.antonyms || args.full) && meaning.antonyms.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!meaning.antonyms.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/format.rs:56:52 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn format_meanings(args: &Arguments, meanings: &Vec) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 56 - pub fn format_meanings(args: &Arguments, meanings: &Vec) -> String { [INFO] [stdout] 56 + pub fn format_meanings(args: &Arguments, meanings: &[Meaning]) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/format.rs:61:15 [INFO] [stdout] | [INFO] [stdout] 61 | .join("\n\n".into()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `"\n\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/format.rs:79:71 [INFO] [stdout] | [INFO] [stdout] 79 | phonetic = format_phonetic(args, item.phonetic.as_deref().unwrap_or("".into()).to_string()), [INFO] [stdout] | ^^^^^^^^^ help: consider removing `.into()`: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/api.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | if !json.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `json.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 49.25s [INFO] running `Command { std: "docker" "inspect" "a540e5c1c9f9f0cadac444d860d7cdce3a2c443ace9d1734a3a6b6ce87fc99dc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a540e5c1c9f9f0cadac444d860d7cdce3a2c443ace9d1734a3a6b6ce87fc99dc", kill_on_drop: false }` [INFO] [stdout] a540e5c1c9f9f0cadac444d860d7cdce3a2c443ace9d1734a3a6b6ce87fc99dc