[INFO] cloning repository https://github.com/marcus0x62/quixotic [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/marcus0x62/quixotic" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmarcus0x62%2Fquixotic", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmarcus0x62%2Fquixotic'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 34577171e83e3407c96271ed783169933773cb07 [INFO] linting marcus0x62/quixotic against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmarcus0x62%2Fquixotic" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/marcus0x62/quixotic [INFO] finished tweaking git repo https://github.com/marcus0x62/quixotic [INFO] tweaked toml for git repo https://github.com/marcus0x62/quixotic written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/marcus0x62/quixotic on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/marcus0x62/quixotic already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded match_token v0.35.0 [INFO] [stderr] Downloaded markup5ever v0.35.0 [INFO] [stderr] Downloaded web_atoms v0.1.3 [INFO] [stderr] Downloaded actix-http v3.11.1 [INFO] [stderr] Downloaded html5ever v0.35.0 [INFO] [stderr] Downloaded regex-lite v0.1.7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ef1c81a262ffefaeacb983d44387b887e5c336f228aabe6dde555dafe265dfdf [INFO] running `Command { std: "docker" "start" "-a" "ef1c81a262ffefaeacb983d44387b887e5c336f228aabe6dde555dafe265dfdf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ef1c81a262ffefaeacb983d44387b887e5c336f228aabe6dde555dafe265dfdf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ef1c81a262ffefaeacb983d44387b887e5c336f228aabe6dde555dafe265dfdf", kill_on_drop: false }` [INFO] [stdout] ef1c81a262ffefaeacb983d44387b887e5c336f228aabe6dde555dafe265dfdf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3e047a0e59e23cf1a8b48bb97c4905418b4f9016b7217c2267540c71d8fb006b [INFO] running `Command { std: "docker" "start" "-a" "3e047a0e59e23cf1a8b48bb97c4905418b4f9016b7217c2267540c71d8fb006b", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Compiling libc v0.2.175 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking signal-hook-registry v1.4.6 [INFO] [stderr] Checking socket2 v0.6.0 [INFO] [stderr] Compiling phf_shared v0.11.3 [INFO] [stderr] Compiling serde_json v1.0.143 [INFO] [stderr] Checking regex-automata v0.4.10 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Compiling tracing-core v0.1.34 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Checking anstream v0.6.20 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking phf v0.11.3 [INFO] [stderr] Compiling regex-lite v0.1.7 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking bitflags v2.9.3 [INFO] [stderr] Compiling cfg-if v1.0.3 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Compiling phf_generator v0.11.3 [INFO] [stderr] Checking cookie v0.16.2 [INFO] [stderr] Checking clap_builder v4.5.46 [INFO] [stderr] Compiling phf_codegen v0.11.3 [INFO] [stderr] Compiling string_cache_codegen v0.5.4 [INFO] [stderr] Compiling tracing v0.1.41 [INFO] [stderr] Checking half v2.6.0 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking tokio v1.47.1 [INFO] [stderr] Checking flate2 v1.1.2 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Compiling web_atoms v0.1.3 [INFO] [stderr] Compiling actix-router v0.5.3 [INFO] [stderr] Checking indexmap v2.11.0 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Compiling cc v1.2.34 [INFO] [stderr] Checking criterion-plot v0.6.0 [INFO] [stderr] Checking regex v1.11.2 [INFO] [stderr] Compiling zstd-sys v2.0.15+zstd.1.5.7 [INFO] [stderr] Checking tokio-util v0.7.16 [INFO] [stderr] Checking actix-rt v2.11.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling derive_more-impl v2.0.1 [INFO] [stderr] Compiling clap_derive v4.5.45 [INFO] [stderr] Compiling match_token v0.35.0 [INFO] [stderr] Compiling actix-macros v0.2.4 [INFO] [stderr] Compiling actix-web-codegen v4.3.0 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking actix-codec v0.5.2 [INFO] [stderr] Checking actix-server v2.6.0 [INFO] [stderr] Checking clap v4.5.46 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.3 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking derive_more v2.0.1 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking actix-http v3.11.1 [INFO] [stderr] Checking string_cache v0.8.9 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking markup5ever v0.35.0 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking html5ever v0.35.0 [INFO] [stderr] Checking criterion v0.7.0 [INFO] [stderr] Checking actix-web v4.11.0 [INFO] [stderr] Checking quixotic v0.1.13 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/markov.rs:217:21 [INFO] [stdout] | [INFO] [stdout] 217 | assert!(!tok.is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `tok.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.filter_map(..)` can be written more simply using `.filter(..)` [INFO] [stdout] --> src/markov.rs:202:22 [INFO] [stdout] | [INFO] [stdout] 202 | .filter_map(|x| match x { [INFO] [stdout] | ______________________^ [INFO] [stdout] 203 | | ',' | '.' | '!' | '?' | ':' | ';' => Some(x), [INFO] [stdout] 204 | | '\n' | '\r' | '"' | '\'' => None, [INFO] [stdout] 205 | | _ => Some(x), [INFO] [stdout] 206 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stdout] = note: `#[warn(clippy::unnecessary_filter_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/rcdom.rs:136:26 [INFO] [stdout] | [INFO] [stdout] 136 | nodes.extend(children.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/collect.rs:416:17 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 136 - nodes.extend(children.into_iter()); [INFO] [stdout] 136 + nodes.extend(children); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/rcdom.rs:136:26 [INFO] [stdout] | [INFO] [stdout] 136 | nodes.extend(children.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/collect.rs:416:17 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 136 - nodes.extend(children.into_iter()); [INFO] [stdout] 136 + nodes.extend(children); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `black_box` [INFO] [stdout] --> benches/quixotic_benchmarks.rs:2:17 [INFO] [stdout] | [INFO] [stdout] 2 | use criterion::{black_box, criterion_group, criterion_main, Criterion}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `criterion::black_box`: use `std::hint::black_box()` instead [INFO] [stdout] --> benches/quixotic_benchmarks.rs:2:17 [INFO] [stdout] | [INFO] [stdout] 2 | use criterion::{black_box, criterion_group, criterion_main, Criterion}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 36.16s [INFO] running `Command { std: "docker" "inspect" "3e047a0e59e23cf1a8b48bb97c4905418b4f9016b7217c2267540c71d8fb006b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3e047a0e59e23cf1a8b48bb97c4905418b4f9016b7217c2267540c71d8fb006b", kill_on_drop: false }` [INFO] [stdout] 3e047a0e59e23cf1a8b48bb97c4905418b4f9016b7217c2267540c71d8fb006b