[INFO] cloning repository https://github.com/marcroberts/adventofcode2020
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/marcroberts/adventofcode2020" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmarcroberts%2Fadventofcode2020", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmarcroberts%2Fadventofcode2020'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] f06761d5b424e67a12ab960be0e776a5ce70abf0
[INFO] linting marcroberts/adventofcode2020 against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmarcroberts%2Fadventofcode2020" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/marcroberts/adventofcode2020
[INFO] finished tweaking git repo https://github.com/marcroberts/adventofcode2020
[INFO] tweaked toml for git repo https://github.com/marcroberts/adventofcode2020 written to /workspace/builds/worker-6-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/marcroberts/adventofcode2020 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/marcroberts/adventofcode2020 already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 95611ca6903b6c9bbd82987003d3a8793167dda638f2350b1b85ec7e7005c802
[INFO] running `Command { std: "docker" "start" "-a" "95611ca6903b6c9bbd82987003d3a8793167dda638f2350b1b85ec7e7005c802", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "95611ca6903b6c9bbd82987003d3a8793167dda638f2350b1b85ec7e7005c802", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "95611ca6903b6c9bbd82987003d3a8793167dda638f2350b1b85ec7e7005c802", kill_on_drop: false }`
[INFO] [stdout] 95611ca6903b6c9bbd82987003d3a8793167dda638f2350b1b85ec7e7005c802
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 26c37475a2339722c0ee46b2fc42dbf4ae754a17b6a0ed5776bfcdd45f9bf0ac
[INFO] running `Command { std: "docker" "start" "-a" "26c37475a2339722c0ee46b2fc42dbf4ae754a17b6a0ed5776bfcdd45f9bf0ac", kill_on_drop: false }`
[INFO] [stderr]    Compiling memchr v2.3.4
[INFO] [stderr]     Checking regex-syntax v0.6.21
[INFO] [stderr]     Checking thread_local v1.0.1
[INFO] [stderr]     Checking aho-corasick v0.7.15
[INFO] [stderr]     Checking regex v1.4.2
[INFO] [stderr]     Checking adventofcode2020 v0.0.1 (/opt/rustwide/workdir)
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/bin/day4.rs:40:10
[INFO] [stdout]    |
[INFO] [stdout] 40 |       if true && valid_data {
[INFO] [stdout]    |          ^^^^^^^^^^^^^^^^^^ help: try: `valid_data`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/bin/day4.rs:28:10
[INFO] [stdout]    |
[INFO] [stdout] 28 |       if field.len() == 0 {
[INFO] [stdout]    |          ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `field.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation
[INFO] [stdout]   --> src/bin/day4.rs:47:31
[INFO] [stdout]    |
[INFO] [stdout] 47 |           if (key == "byr" && (year < 1920 || year > 2002))
[INFO] [stdout]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(1920..=2002).contains(&year)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
[INFO] [stdout]    = note: `#[warn(clippy::manual_range_contains)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation
[INFO] [stdout]   --> src/bin/day4.rs:48:33
[INFO] [stdout]    |
[INFO] [stdout] 48 |             || (key == "iyr" && (year < 2010 || year > 2020))
[INFO] [stdout]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(2010..=2020).contains(&year)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation
[INFO] [stdout]   --> src/bin/day4.rs:49:33
[INFO] [stdout]    |
[INFO] [stdout] 49 |             || (key == "eyr" && (year < 2020 || year > 2030)) {
[INFO] [stdout]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(2020..=2030).contains(&year)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow
[INFO] [stdout]   --> src/bin/day4.rs:59:31
[INFO] [stdout]    |
[INFO] [stdout] 59 |             let height: u16 = (&value[0..(len-2)]).parse().unwrap();
[INFO] [stdout]    |                               ^^^^^^^^^^^^^^^^^^^^ help: change this to: `value[0..(len-2)]`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation
[INFO] [stdout]   --> src/bin/day4.rs:62:40
[INFO] [stdout]    |
[INFO] [stdout] 62 |             if (height_type == "in" && (height < 59 || height > 76))
[INFO] [stdout]    |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(59..=76).contains(&height)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation
[INFO] [stdout]   --> src/bin/day4.rs:63:42
[INFO] [stdout]    |
[INFO] [stdout] 63 |               || (height_type == "cm" && (height < 150 || height > 193)) {
[INFO] [stdout]    |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(150..=193).contains(&height)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]   --> src/bin/day4.rs:69:9
[INFO] [stdout]    |
[INFO] [stdout] 69 | /         if key == "hcl" {
[INFO] [stdout] 70 | |           if !re_hcl.is_match(value) {
[INFO] [stdout] 71 | |             valid_data = false;
[INFO] [stdout] 72 | |           }
[INFO] [stdout] 73 | |         }
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]    = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 69 ~         if key == "hcl"
[INFO] [stdout] 70 ~           && !re_hcl.is_match(value) {
[INFO] [stdout] 71 |             valid_data = false;
[INFO] [stdout] 72 ~           }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]   --> src/bin/day4.rs:75:9
[INFO] [stdout]    |
[INFO] [stdout] 75 | /         if key == "ecl" {
[INFO] [stdout] 76 | |           if !re_ecl.is_match(value) {
[INFO] [stdout] 77 | |             valid_data = false;
[INFO] [stdout] 78 | |           }
[INFO] [stdout] 79 | |         }
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 75 ~         if key == "ecl"
[INFO] [stdout] 76 ~           && !re_ecl.is_match(value) {
[INFO] [stdout] 77 |             valid_data = false;
[INFO] [stdout] 78 ~           }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]   --> src/bin/day4.rs:81:9
[INFO] [stdout]    |
[INFO] [stdout] 81 | /         if key == "pid" {
[INFO] [stdout] 82 | |           if !re_pid.is_match(value) {
[INFO] [stdout] 83 | |             valid_data = false;
[INFO] [stdout] 84 | |           }
[INFO] [stdout] 85 | |         }
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 81 ~         if key == "pid"
[INFO] [stdout] 82 ~           && !re_pid.is_match(value) {
[INFO] [stdout] 83 |             valid_data = false;
[INFO] [stdout] 84 ~           }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/bin/day3.rs:81:3
[INFO] [stdout]    |
[INFO] [stdout] 81 |   return trees_count;
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 81 -   return trees_count;
[INFO] [stdout] 81 +   trees_count
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow
[INFO] [stdout]   --> src/bin/day2pt2.rs:24:22
[INFO] [stdout]    |
[INFO] [stdout] 24 |       let a: usize = (&cap[1]).to_string().parse().unwrap();
[INFO] [stdout]    |                      ^^^^^^^^^ help: change this to: `cap[1]`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow
[INFO] [stdout]   --> src/bin/day2pt2.rs:25:22
[INFO] [stdout]    |
[INFO] [stdout] 25 |       let b: usize = (&cap[2]).to_string().parse().unwrap();
[INFO] [stdout]    |                      ^^^^^^^^^ help: change this to: `cap[2]`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement
[INFO] [stdout]   --> src/bin/day2pt2.rs:22:16
[INFO] [stdout]    |
[INFO] [stdout] 22 |     for cap in re.captures(&str) {
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(for_loops_over_fallibles)]` on by default
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]    |
[INFO] [stdout] 22 -     for cap in re.captures(&str) {
[INFO] [stdout] 22 +     while let Some(cap) = re.captures(&str) {
[INFO] [stdout]    |
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]    |
[INFO] [stdout] 22 -     for cap in re.captures(&str) {
[INFO] [stdout] 22 +     if let Some(cap) = re.captures(&str) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/bin/day4.rs:40:10
[INFO] [stdout]    |
[INFO] [stdout] 40 |       if true && valid_data {
[INFO] [stdout]    |          ^^^^^^^^^^^^^^^^^^ help: try: `valid_data`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/bin/day4.rs:28:10
[INFO] [stdout]    |
[INFO] [stdout] 28 |       if field.len() == 0 {
[INFO] [stdout]    |          ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `field.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation
[INFO] [stdout]   --> src/bin/day4.rs:47:31
[INFO] [stdout]    |
[INFO] [stdout] 47 |           if (key == "byr" && (year < 1920 || year > 2002))
[INFO] [stdout]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(1920..=2002).contains(&year)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
[INFO] [stdout]    = note: `#[warn(clippy::manual_range_contains)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation
[INFO] [stdout]   --> src/bin/day4.rs:48:33
[INFO] [stdout]    |
[INFO] [stdout] 48 |             || (key == "iyr" && (year < 2010 || year > 2020))
[INFO] [stdout]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(2010..=2020).contains(&year)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation
[INFO] [stdout]   --> src/bin/day4.rs:49:33
[INFO] [stdout]    |
[INFO] [stdout] 49 |             || (key == "eyr" && (year < 2020 || year > 2030)) {
[INFO] [stdout]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(2020..=2030).contains(&year)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow
[INFO] [stdout]   --> src/bin/day4.rs:59:31
[INFO] [stdout]    |
[INFO] [stdout] 59 |             let height: u16 = (&value[0..(len-2)]).parse().unwrap();
[INFO] [stdout]    |                               ^^^^^^^^^^^^^^^^^^^^ help: change this to: `value[0..(len-2)]`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation
[INFO] [stdout]   --> src/bin/day4.rs:62:40
[INFO] [stdout]    |
[INFO] [stdout] 62 |             if (height_type == "in" && (height < 59 || height > 76))
[INFO] [stdout]    |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(59..=76).contains(&height)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation
[INFO] [stdout]   --> src/bin/day4.rs:63:42
[INFO] [stdout]    |
[INFO] [stdout] 63 |               || (height_type == "cm" && (height < 150 || height > 193)) {
[INFO] [stdout]    |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(150..=193).contains(&height)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]   --> src/bin/day4.rs:69:9
[INFO] [stdout]    |
[INFO] [stdout] 69 | /         if key == "hcl" {
[INFO] [stdout] 70 | |           if !re_hcl.is_match(value) {
[INFO] [stdout] 71 | |             valid_data = false;
[INFO] [stdout] 72 | |           }
[INFO] [stdout] 73 | |         }
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]    = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 69 ~         if key == "hcl"
[INFO] [stdout] 70 ~           && !re_hcl.is_match(value) {
[INFO] [stdout] 71 |             valid_data = false;
[INFO] [stdout] 72 ~           }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]   --> src/bin/day4.rs:75:9
[INFO] [stdout]    |
[INFO] [stdout] 75 | /         if key == "ecl" {
[INFO] [stdout] 76 | |           if !re_ecl.is_match(value) {
[INFO] [stdout] 77 | |             valid_data = false;
[INFO] [stdout] 78 | |           }
[INFO] [stdout] 79 | |         }
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 75 ~         if key == "ecl"
[INFO] [stdout] 76 ~           && !re_ecl.is_match(value) {
[INFO] [stdout] 77 |             valid_data = false;
[INFO] [stdout] 78 ~           }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]   --> src/bin/day4.rs:81:9
[INFO] [stdout]    |
[INFO] [stdout] 81 | /         if key == "pid" {
[INFO] [stdout] 82 | |           if !re_pid.is_match(value) {
[INFO] [stdout] 83 | |             valid_data = false;
[INFO] [stdout] 84 | |           }
[INFO] [stdout] 85 | |         }
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 81 ~         if key == "pid"
[INFO] [stdout] 82 ~           && !re_pid.is_match(value) {
[INFO] [stdout] 83 |             valid_data = false;
[INFO] [stdout] 84 ~           }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/bin/day3.rs:81:3
[INFO] [stdout]    |
[INFO] [stdout] 81 |   return trees_count;
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 81 -   return trees_count;
[INFO] [stdout] 81 +   trees_count
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow
[INFO] [stdout]   --> src/bin/day2.rs:24:21
[INFO] [stdout]    |
[INFO] [stdout] 24 |       let min: u8 = (&cap[1]).to_string().parse().unwrap();
[INFO] [stdout]    |                     ^^^^^^^^^ help: change this to: `cap[1]`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow
[INFO] [stdout]   --> src/bin/day2.rs:25:21
[INFO] [stdout]    |
[INFO] [stdout] 25 |       let max: u8 = (&cap[2]).to_string().parse().unwrap();
[INFO] [stdout]    |                     ^^^^^^^^^ help: change this to: `cap[2]`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow
[INFO] [stdout]   --> src/bin/day2.rs:28:30
[INFO] [stdout]    |
[INFO] [stdout] 28 |       let password: String = (&cap[4]).to_string();
[INFO] [stdout]    |                              ^^^^^^^^^ help: change this to: `cap[4]`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement
[INFO] [stdout]   --> src/bin/day2.rs:22:16
[INFO] [stdout]    |
[INFO] [stdout] 22 |     for cap in re.captures(&str) {
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(for_loops_over_fallibles)]` on by default
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]    |
[INFO] [stdout] 22 -     for cap in re.captures(&str) {
[INFO] [stdout] 22 +     while let Some(cap) = re.captures(&str) {
[INFO] [stdout]    |
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]    |
[INFO] [stdout] 22 -     for cap in re.captures(&str) {
[INFO] [stdout] 22 +     if let Some(cap) = re.captures(&str) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow
[INFO] [stdout]   --> src/bin/day2.rs:24:21
[INFO] [stdout]    |
[INFO] [stdout] 24 |       let min: u8 = (&cap[1]).to_string().parse().unwrap();
[INFO] [stdout]    |                     ^^^^^^^^^ help: change this to: `cap[1]`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow
[INFO] [stdout]   --> src/bin/day2pt2.rs:24:22
[INFO] [stdout]    |
[INFO] [stdout] 24 |       let a: usize = (&cap[1]).to_string().parse().unwrap();
[INFO] [stdout]    |                      ^^^^^^^^^ help: change this to: `cap[1]`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow
[INFO] [stdout]   --> src/bin/day2pt2.rs:25:22
[INFO] [stdout]    |
[INFO] [stdout] 25 |       let b: usize = (&cap[2]).to_string().parse().unwrap();
[INFO] [stdout]    |                      ^^^^^^^^^ help: change this to: `cap[2]`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow
[INFO] [stdout]   --> src/bin/day2.rs:25:21
[INFO] [stdout]    |
[INFO] [stdout] 25 |       let max: u8 = (&cap[2]).to_string().parse().unwrap();
[INFO] [stdout]    |                     ^^^^^^^^^ help: change this to: `cap[2]`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow
[INFO] [stdout]   --> src/bin/day2.rs:28:30
[INFO] [stdout]    |
[INFO] [stdout] 28 |       let password: String = (&cap[4]).to_string();
[INFO] [stdout]    |                              ^^^^^^^^^ help: change this to: `cap[4]`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement
[INFO] [stdout]   --> src/bin/day2.rs:22:16
[INFO] [stdout]    |
[INFO] [stdout] 22 |     for cap in re.captures(&str) {
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(for_loops_over_fallibles)]` on by default
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]    |
[INFO] [stdout] 22 -     for cap in re.captures(&str) {
[INFO] [stdout] 22 +     while let Some(cap) = re.captures(&str) {
[INFO] [stdout]    |
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]    |
[INFO] [stdout] 22 -     for cap in re.captures(&str) {
[INFO] [stdout] 22 +     if let Some(cap) = re.captures(&str) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement
[INFO] [stdout]   --> src/bin/day2pt2.rs:22:16
[INFO] [stdout]    |
[INFO] [stdout] 22 |     for cap in re.captures(&str) {
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(for_loops_over_fallibles)]` on by default
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]    |
[INFO] [stdout] 22 -     for cap in re.captures(&str) {
[INFO] [stdout] 22 +     while let Some(cap) = re.captures(&str) {
[INFO] [stdout]    |
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]    |
[INFO] [stdout] 22 -     for cap in re.captures(&str) {
[INFO] [stdout] 22 +     if let Some(cap) = re.captures(&str) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.18s
[INFO] running `Command { std: "docker" "inspect" "26c37475a2339722c0ee46b2fc42dbf4ae754a17b6a0ed5776bfcdd45f9bf0ac", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "26c37475a2339722c0ee46b2fc42dbf4ae754a17b6a0ed5776bfcdd45f9bf0ac", kill_on_drop: false }`
[INFO] [stdout] 26c37475a2339722c0ee46b2fc42dbf4ae754a17b6a0ed5776bfcdd45f9bf0ac