[INFO] cloning repository https://github.com/marcos-brito/theris [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/marcos-brito/theris" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmarcos-brito%2Ftheris", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmarcos-brito%2Ftheris'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9229bdbda1fc2a40de40996185e0063e45fcb2bb [INFO] linting marcos-brito/theris against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmarcos-brito%2Ftheris" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/marcos-brito/theris [INFO] finished tweaking git repo https://github.com/marcos-brito/theris [INFO] tweaked toml for git repo https://github.com/marcos-brito/theris written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/marcos-brito/theris on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/marcos-brito/theris already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded unic-ucd-segment v0.9.0 [INFO] [stderr] Downloaded pest_derive v2.7.11 [INFO] [stderr] Downloaded filetime v0.2.23 [INFO] [stderr] Downloaded xattr v1.3.1 [INFO] [stderr] Downloaded unic-segment v0.9.0 [INFO] [stderr] Downloaded slug v0.1.5 [INFO] [stderr] Downloaded pest_generator v2.7.11 [INFO] [stderr] Downloaded os_info v3.8.2 [INFO] [stderr] Downloaded human-panic v2.0.0 [INFO] [stderr] Downloaded clap v4.5.8 [INFO] [stderr] Downloaded tar v0.4.41 [INFO] [stderr] Downloaded cc v1.0.104 [INFO] [stderr] Downloaded tera v1.20.0 [INFO] [stderr] Downloaded pest v2.7.11 [INFO] [stderr] Downloaded serde_json v1.0.120 [INFO] [stderr] Downloaded clap_builder v4.5.8 [INFO] [stderr] Downloaded deunicode v1.6.0 [INFO] [stderr] Downloaded pest_meta v2.7.11 [INFO] [stderr] Downloaded syn v2.0.68 [INFO] [stderr] Downloaded object v0.36.1 [INFO] [stderr] Downloaded bstr v1.9.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5348eea5c252aebc1786c057ac9d49a0e76b09d3f03aaa06a439ef52af3d472c [INFO] running `Command { std: "docker" "start" "-a" "5348eea5c252aebc1786c057ac9d49a0e76b09d3f03aaa06a439ef52af3d472c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5348eea5c252aebc1786c057ac9d49a0e76b09d3f03aaa06a439ef52af3d472c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5348eea5c252aebc1786c057ac9d49a0e76b09d3f03aaa06a439ef52af3d472c", kill_on_drop: false }` [INFO] [stdout] 5348eea5c252aebc1786c057ac9d49a0e76b09d3f03aaa06a439ef52af3d472c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1eed134c9ac6a6e0ef89f1ccd2cf5e350e1b1100609d12ee8afd3926190f5a65 [INFO] running `Command { std: "docker" "start" "-a" "1eed134c9ac6a6e0ef89f1ccd2cf5e350e1b1100609d12ee8afd3926190f5a65", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling phf v0.11.2 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking unic-char-range v0.9.0 [INFO] [stderr] Compiling cc v1.0.104 [INFO] [stderr] Checking unic-common v0.9.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking unic-char-property v0.9.0 [INFO] [stderr] Checking unic-ucd-version v0.9.0 [INFO] [stderr] Checking phf_shared v0.11.2 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking unic-ucd-segment v0.9.0 [INFO] [stderr] Checking object v0.36.1 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking deunicode v1.6.0 [INFO] [stderr] Checking ucd-trie v0.1.6 [INFO] [stderr] Checking clap_builder v4.5.8 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking slug v0.1.5 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking uuid v1.9.1 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking unic-segment v0.9.0 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking humansize v2.1.3 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Checking clap v4.5.8 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Compiling regex v1.10.5 [INFO] [stderr] Checking tar v0.4.41 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking ignore v0.4.22 [INFO] [stderr] Compiling parse-zoneinfo v0.3.1 [INFO] [stderr] Checking pest v2.7.11 [INFO] [stderr] Checking globwalk v0.9.1 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Compiling chrono-tz-build v0.3.0 [INFO] [stderr] Compiling chrono-tz v0.9.0 [INFO] [stderr] Compiling pest_meta v2.7.11 [INFO] [stderr] Compiling pest_generator v2.7.11 [INFO] [stderr] Compiling pest_derive v2.7.11 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking os_info v3.8.2 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking toml_edit v0.22.14 [INFO] [stderr] Checking tera v1.20.0 [INFO] [stderr] Checking toml v0.8.14 [INFO] [stderr] Checking human-panic v2.0.0 [INFO] [stderr] Checking theris v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/applier/delimeter.rs:18:26 [INFO] [stdout] | [INFO] [stdout] 18 | .find(|line| line.trim() == &self.start) [INFO] [stdout] | ^^^^^^^^^^^^^^^----------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `self.start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/applier/delimeter.rs:22:32 [INFO] [stdout] | [INFO] [stdout] 22 | .skip_while(|line| line.trim() == &self.start) [INFO] [stdout] | ^^^^^^^^^^^^^^^----------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `self.start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/applier/delimeter.rs:23:26 [INFO] [stdout] | [INFO] [stdout] 23 | .find(|line| line.trim() == &self.end) [INFO] [stdout] | ^^^^^^^^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `self.end` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/applier/delimeter.rs:30:40 [INFO] [stdout] | [INFO] [stdout] 30 | Ok(match self.is_template_file(&context) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/applier.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | / write!( [INFO] [stdout] 58 | | f, [INFO] [stdout] 59 | | "{}\n{}\n{}", [INFO] [stdout] 60 | | self.name.magenta().bold(), [INFO] [stdout] 61 | | format!(" {}: {}", "config file".bold(), self.path.display()), [INFO] [stdout] 62 | | format!(" {}: {}", "method".bold(), self.method), [INFO] [stdout] 63 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/applier/delimeter.rs:18:26 [INFO] [stdout] | [INFO] [stdout] 18 | .find(|line| line.trim() == &self.start) [INFO] [stdout] | ^^^^^^^^^^^^^^^----------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `self.start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/applier/delimeter.rs:22:32 [INFO] [stdout] | [INFO] [stdout] 22 | .skip_while(|line| line.trim() == &self.start) [INFO] [stdout] | ^^^^^^^^^^^^^^^----------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `self.start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/applier/delimeter.rs:23:26 [INFO] [stdout] | [INFO] [stdout] 23 | .find(|line| line.trim() == &self.end) [INFO] [stdout] | ^^^^^^^^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `self.end` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/applier/delimeter.rs:30:40 [INFO] [stdout] | [INFO] [stdout] 30 | Ok(match self.is_template_file(&context) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `context` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.find_map(..)` can be written more simply using `.find(..)` [INFO] [stdout] --> src/backup.rs:26:27 [INFO] [stdout] | [INFO] [stdout] 26 | self.pairs.iter().find_map(|pair| { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 27 | | if Path::new(&pair.name) == name.as_ref() { [INFO] [stdout] 28 | | return Some(pair); [INFO] [stdout] ... | [INFO] [stdout] 31 | | None [INFO] [stdout] 32 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_find_map [INFO] [stdout] = note: `#[warn(clippy::unnecessary_find_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Backup` [INFO] [stdout] --> src/backup.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | / pub fn new() -> Self { [INFO] [stdout] 48 | | Self { [INFO] [stdout] 49 | | manifest: Manifest { pairs: vec![] }, [INFO] [stdout] 50 | | } [INFO] [stdout] 51 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 46 + impl Default for Backup { [INFO] [stdout] 47 + fn default() -> Self { [INFO] [stdout] 48 + Self::new() [INFO] [stdout] 49 + } [INFO] [stdout] 50 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/backup.rs:135:16 [INFO] [stdout] | [INFO] [stdout] 135 | if !(entry.path().ok()? == Path::new(MANIFEST_NAME)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(entry.path().ok()? != Path::new(MANIFEST_NAME))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Some` and `?` operator are unneeded [INFO] [stdout] --> src/backup.rs:142:13 [INFO] [stdout] | [INFO] [stdout] 142 | Some(serde_yaml::from_str::(&yaml).ok()?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Some` and `?` operator [INFO] [stdout] | [INFO] [stdout] 142 - Some(serde_yaml::from_str::(&yaml).ok()?) [INFO] [stdout] 142 + serde_yaml::from_str::(&yaml).ok() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/cmd/apply.rs:24:29 [INFO] [stdout] | [INFO] [stdout] 24 | appliers_names: matches [INFO] [stdout] | _____________________________^ [INFO] [stdout] 25 | | .get_many::("appliers") [INFO] [stdout] 26 | | .and_then(|names| Some(names.map(|n| n.to_string()).collect::>())), [INFO] [stdout] | |______________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 24 ~ appliers_names: matches [INFO] [stdout] 25 ~ .get_many::("appliers").map(|names| names.map(|n| n.to_string()).collect::>()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cmd/apply.rs:36:27 [INFO] [stdout] | [INFO] [stdout] 36 | applier.apply(&theme, &self.app.templater)?; [INFO] [stdout] | ^^^^^^ help: change this to: `theme` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/cmd/apply.rs:42:59 [INFO] [stdout] | [INFO] [stdout] 42 | fn apply_all_except(&self, theme: &Theme, exceptions: &Vec) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 42 - fn apply_all_except(&self, theme: &Theme, exceptions: &Vec) -> Result<()> { [INFO] [stdout] 42 + fn apply_all_except(&self, theme: &Theme, exceptions: &[Applier]) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cmd/apply.rs:60:27 [INFO] [stdout] | [INFO] [stdout] 60 | applier.apply(&theme, &self.app.templater)?; [INFO] [stdout] | ^^^^^^ help: change this to: `theme` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/cmd/apply.rs:66:42 [INFO] [stdout] | [INFO] [stdout] 66 | fn appliers_from_names(&self, names: &Vec) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 66 - fn appliers_from_names(&self, names: &Vec) -> Result> { [INFO] [stdout] 66 + fn appliers_from_names(&self, names: &[String]) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cmd/apply.rs:70:49 [INFO] [stdout] | [INFO] [stdout] 70 | let applier = self.app.find_applier(&name); [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/cmd/apply.rs:82:43 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn create_backup(&self, appliers: &Vec) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 82 - pub fn create_backup(&self, appliers: &Vec) -> Result<()> { [INFO] [stdout] 82 + pub fn create_backup(&self, appliers: &[Applier]) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cmd/apply.rs:107:57 [INFO] [stdout] | [INFO] [stdout] 107 | let appliers = self.appliers_from_names(&names)?; [INFO] [stdout] | ^^^^^^ help: change this to: `names` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/applier.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | / write!( [INFO] [stdout] 58 | | f, [INFO] [stdout] 59 | | "{}\n{}\n{}", [INFO] [stdout] 60 | | self.name.magenta().bold(), [INFO] [stdout] 61 | | format!(" {}: {}", "config file".bold(), self.path.display()), [INFO] [stdout] 62 | | format!(" {}: {}", "method".bold(), self.method), [INFO] [stdout] 63 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/cmd/restore.rs:19:26 [INFO] [stdout] | [INFO] [stdout] 19 | backup_path: matches [INFO] [stdout] | __________________________^ [INFO] [stdout] 20 | | .get_one::("backup_path") [INFO] [stdout] 21 | | .and_then(|p| Some(PathBuf::from(p))) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ backup_path: matches [INFO] [stdout] 20 + .get_one::("backup_path").map(|p| PathBuf::from(p)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/cmd/restore.rs:23:19 [INFO] [stdout] | [INFO] [stdout] 23 | dest: matches [INFO] [stdout] | ___________________^ [INFO] [stdout] 24 | | .get_one::("dest") [INFO] [stdout] 25 | | .and_then(|p| Some(PathBuf::from(p))), [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 23 ~ dest: matches [INFO] [stdout] 24 ~ .get_one::("dest").map(|p| PathBuf::from(p)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cmd/restore.rs:38:60 [INFO] [stdout] | [INFO] [stdout] 38 | Some(dest) => Backup::restore_to(&backup_path, &dest).context(format!( [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/cmd.rs:82:23 [INFO] [stdout] | [INFO] [stdout] 82 | let config_path = matches [INFO] [stdout] | _______________________^ [INFO] [stdout] 83 | | .get_one::("config_path") [INFO] [stdout] 84 | | .and_then(|path| Some(path.clone())) [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 82 ~ let config_path = matches [INFO] [stdout] 83 + .get_one::("config_path").map(|path| path.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/cmd.rs:86:26 [INFO] [stdout] | [INFO] [stdout] 86 | let templates_path = matches [INFO] [stdout] | __________________________^ [INFO] [stdout] 87 | | .get_one::("templates_path") [INFO] [stdout] 88 | | .and_then(|path| Some(path.clone())) [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 86 ~ let templates_path = matches [INFO] [stdout] 87 + .get_one::("templates_path").map(|path| path.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/cmd.rs:90:23 [INFO] [stdout] | [INFO] [stdout] 90 | let backup_path = matches [INFO] [stdout] | _______________________^ [INFO] [stdout] 91 | | .get_one::("backup_path") [INFO] [stdout] 92 | | .and_then(|path| Some(path.clone())) [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 90 ~ let backup_path = matches [INFO] [stdout] 91 + .get_one::("backup_path").map(|path| path.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.find_map(..)` can be written more simply using `.find(..)` [INFO] [stdout] --> src/backup.rs:26:27 [INFO] [stdout] | [INFO] [stdout] 26 | self.pairs.iter().find_map(|pair| { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 27 | | if Path::new(&pair.name) == name.as_ref() { [INFO] [stdout] 28 | | return Some(pair); [INFO] [stdout] ... | [INFO] [stdout] 31 | | None [INFO] [stdout] 32 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_find_map [INFO] [stdout] = note: `#[warn(clippy::unnecessary_find_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | return self.themes.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return self.themes.clone(); [INFO] [stdout] 29 + self.themes.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | return self.appliers.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return self.appliers.clone(); [INFO] [stdout] 33 + self.appliers.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/config.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | / Ok(serde_yaml::from_str::(&yaml) [INFO] [stdout] 48 | | .context(anyhow!("Failed to parse {}", path.display()))?) [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 47 ~ serde_yaml::from_str::(&yaml) [INFO] [stdout] 48 ~ .context(anyhow!("Failed to parse {}", path.display())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/template.rs:35:21 [INFO] [stdout] | [INFO] [stdout] 35 | .render(&template_name, &Templater::create_context(theme))?) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `template_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Backup` [INFO] [stdout] --> src/backup.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | / pub fn new() -> Self { [INFO] [stdout] 48 | | Self { [INFO] [stdout] 49 | | manifest: Manifest { pairs: vec![] }, [INFO] [stdout] 50 | | } [INFO] [stdout] 51 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 46 + impl Default for Backup { [INFO] [stdout] 47 + fn default() -> Self { [INFO] [stdout] 48 + Self::new() [INFO] [stdout] 49 + } [INFO] [stdout] 50 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/template.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | / match &theme.extra { [INFO] [stdout] 47 | | Some(extra) => { [INFO] [stdout] 48 | | for (key, value) in extra.iter() { [INFO] [stdout] 49 | | context.insert(key, value); [INFO] [stdout] ... | [INFO] [stdout] 52 | | None => (), [INFO] [stdout] 53 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 46 ~ if let Some(extra) = &theme.extra { [INFO] [stdout] 47 + for (key, value) in extra.iter() { [INFO] [stdout] 48 + context.insert(key, value); [INFO] [stdout] 49 + } [INFO] [stdout] 50 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/template.rs:76:38 [INFO] [stdout] | [INFO] [stdout] 76 | self.engine.add_raw_template(&name, &template)?; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/template.rs:76:45 [INFO] [stdout] | [INFO] [stdout] 76 | self.engine.add_raw_template(&name, &template)?; [INFO] [stdout] | ^^^^^^^^^ help: change this to: `template` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/template.rs:84:25 [INFO] [stdout] | [INFO] [stdout] 84 | .render_str(&template, &Templater::create_context(&theme))?) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `template` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/template.rs:84:63 [INFO] [stdout] | [INFO] [stdout] 84 | .render_str(&template, &Templater::create_context(&theme))?) [INFO] [stdout] | ^^^^^^ help: change this to: `theme` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:14:67 [INFO] [stdout] | [INFO] [stdout] 14 | let rgb = <[u8; 3]>::from_hex(hex.strip_prefix("#").unwrap_or(&hex)).ok()?; [INFO] [stdout] | ^^^^ help: change this to: `hex` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/backup.rs:135:16 [INFO] [stdout] | [INFO] [stdout] 135 | if !(entry.path().ok()? == Path::new(MANIFEST_NAME)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(entry.path().ok()? != Path::new(MANIFEST_NAME))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Some` and `?` operator are unneeded [INFO] [stdout] --> src/backup.rs:142:13 [INFO] [stdout] | [INFO] [stdout] 142 | Some(serde_yaml::from_str::(&yaml).ok()?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Some` and `?` operator [INFO] [stdout] | [INFO] [stdout] 142 - Some(serde_yaml::from_str::(&yaml).ok()?) [INFO] [stdout] 142 + serde_yaml::from_str::(&yaml).ok() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/lib.rs:32:37 [INFO] [stdout] | [INFO] [stdout] 32 | write!(f, "{}", " ")?; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stdout] = note: `#[warn(clippy::write_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 32 - write!(f, "{}", " ")?; [INFO] [stdout] 32 + write!(f, " ")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | / match &self.extra { [INFO] [stdout] 41 | | Some(extra) => { [INFO] [stdout] 42 | | for (key, value) in extra.iter() { [INFO] [stdout] 43 | | write!(f, "\n - {}: {}", key.italic(), value)?; [INFO] [stdout] ... | [INFO] [stdout] 46 | | None => (), [INFO] [stdout] 47 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 40 ~ if let Some(extra) = &self.extra { [INFO] [stdout] 41 + for (key, value) in extra.iter() { [INFO] [stdout] 42 + write!(f, "\n - {}: {}", key.italic(), value)?; [INFO] [stdout] 43 + } [INFO] [stdout] 44 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/cmd/apply.rs:24:29 [INFO] [stdout] | [INFO] [stdout] 24 | appliers_names: matches [INFO] [stdout] | _____________________________^ [INFO] [stdout] 25 | | .get_many::("appliers") [INFO] [stdout] 26 | | .and_then(|names| Some(names.map(|n| n.to_string()).collect::>())), [INFO] [stdout] | |______________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 24 ~ appliers_names: matches [INFO] [stdout] 25 ~ .get_many::("appliers").map(|names| names.map(|n| n.to_string()).collect::>()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cmd/apply.rs:36:27 [INFO] [stdout] | [INFO] [stdout] 36 | applier.apply(&theme, &self.app.templater)?; [INFO] [stdout] | ^^^^^^ help: change this to: `theme` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/cmd/apply.rs:42:59 [INFO] [stdout] | [INFO] [stdout] 42 | fn apply_all_except(&self, theme: &Theme, exceptions: &Vec) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 42 - fn apply_all_except(&self, theme: &Theme, exceptions: &Vec) -> Result<()> { [INFO] [stdout] 42 + fn apply_all_except(&self, theme: &Theme, exceptions: &[Applier]) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cmd/apply.rs:60:27 [INFO] [stdout] | [INFO] [stdout] 60 | applier.apply(&theme, &self.app.templater)?; [INFO] [stdout] | ^^^^^^ help: change this to: `theme` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/cmd/apply.rs:66:42 [INFO] [stdout] | [INFO] [stdout] 66 | fn appliers_from_names(&self, names: &Vec) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 66 - fn appliers_from_names(&self, names: &Vec) -> Result> { [INFO] [stdout] 66 + fn appliers_from_names(&self, names: &[String]) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cmd/apply.rs:70:49 [INFO] [stdout] | [INFO] [stdout] 70 | let applier = self.app.find_applier(&name); [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/cmd/apply.rs:82:43 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn create_backup(&self, appliers: &Vec) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 82 - pub fn create_backup(&self, appliers: &Vec) -> Result<()> { [INFO] [stdout] 82 + pub fn create_backup(&self, appliers: &[Applier]) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cmd/apply.rs:107:57 [INFO] [stdout] | [INFO] [stdout] 107 | let appliers = self.appliers_from_names(&names)?; [INFO] [stdout] | ^^^^^^ help: change this to: `names` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/cmd/restore.rs:19:26 [INFO] [stdout] | [INFO] [stdout] 19 | backup_path: matches [INFO] [stdout] | __________________________^ [INFO] [stdout] 20 | | .get_one::("backup_path") [INFO] [stdout] 21 | | .and_then(|p| Some(PathBuf::from(p))) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ backup_path: matches [INFO] [stdout] 20 + .get_one::("backup_path").map(|p| PathBuf::from(p)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/cmd/restore.rs:23:19 [INFO] [stdout] | [INFO] [stdout] 23 | dest: matches [INFO] [stdout] | ___________________^ [INFO] [stdout] 24 | | .get_one::("dest") [INFO] [stdout] 25 | | .and_then(|p| Some(PathBuf::from(p))), [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 23 ~ dest: matches [INFO] [stdout] 24 ~ .get_one::("dest").map(|p| PathBuf::from(p)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cmd/restore.rs:38:60 [INFO] [stdout] | [INFO] [stdout] 38 | Some(dest) => Backup::restore_to(&backup_path, &dest).context(format!( [INFO] [stdout] | ^^^^^ help: change this to: `dest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/cmd.rs:82:23 [INFO] [stdout] | [INFO] [stdout] 82 | let config_path = matches [INFO] [stdout] | _______________________^ [INFO] [stdout] 83 | | .get_one::("config_path") [INFO] [stdout] 84 | | .and_then(|path| Some(path.clone())) [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 82 ~ let config_path = matches [INFO] [stdout] 83 + .get_one::("config_path").map(|path| path.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/cmd.rs:86:26 [INFO] [stdout] | [INFO] [stdout] 86 | let templates_path = matches [INFO] [stdout] | __________________________^ [INFO] [stdout] 87 | | .get_one::("templates_path") [INFO] [stdout] 88 | | .and_then(|path| Some(path.clone())) [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 86 ~ let templates_path = matches [INFO] [stdout] 87 + .get_one::("templates_path").map(|path| path.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/cmd.rs:90:23 [INFO] [stdout] | [INFO] [stdout] 90 | let backup_path = matches [INFO] [stdout] | _______________________^ [INFO] [stdout] 91 | | .get_one::("backup_path") [INFO] [stdout] 92 | | .and_then(|path| Some(path.clone())) [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 90 ~ let backup_path = matches [INFO] [stdout] 91 + .get_one::("backup_path").map(|path| path.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | return self.themes.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return self.themes.clone(); [INFO] [stdout] 29 + self.themes.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | return self.appliers.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return self.appliers.clone(); [INFO] [stdout] 33 + self.appliers.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/config.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | / Ok(serde_yaml::from_str::(&yaml) [INFO] [stdout] 48 | | .context(anyhow!("Failed to parse {}", path.display()))?) [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 47 ~ serde_yaml::from_str::(&yaml) [INFO] [stdout] 48 ~ .context(anyhow!("Failed to parse {}", path.display())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/template.rs:35:21 [INFO] [stdout] | [INFO] [stdout] 35 | .render(&template_name, &Templater::create_context(theme))?) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `template_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/template.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | / match &theme.extra { [INFO] [stdout] 47 | | Some(extra) => { [INFO] [stdout] 48 | | for (key, value) in extra.iter() { [INFO] [stdout] 49 | | context.insert(key, value); [INFO] [stdout] ... | [INFO] [stdout] 52 | | None => (), [INFO] [stdout] 53 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 46 ~ if let Some(extra) = &theme.extra { [INFO] [stdout] 47 + for (key, value) in extra.iter() { [INFO] [stdout] 48 + context.insert(key, value); [INFO] [stdout] 49 + } [INFO] [stdout] 50 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/template.rs:76:38 [INFO] [stdout] | [INFO] [stdout] 76 | self.engine.add_raw_template(&name, &template)?; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/template.rs:76:45 [INFO] [stdout] | [INFO] [stdout] 76 | self.engine.add_raw_template(&name, &template)?; [INFO] [stdout] | ^^^^^^^^^ help: change this to: `template` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/template.rs:84:25 [INFO] [stdout] | [INFO] [stdout] 84 | .render_str(&template, &Templater::create_context(&theme))?) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `template` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/template.rs:84:63 [INFO] [stdout] | [INFO] [stdout] 84 | .render_str(&template, &Templater::create_context(&theme))?) [INFO] [stdout] | ^^^^^^ help: change this to: `theme` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:14:67 [INFO] [stdout] | [INFO] [stdout] 14 | let rgb = <[u8; 3]>::from_hex(hex.strip_prefix("#").unwrap_or(&hex)).ok()?; [INFO] [stdout] | ^^^^ help: change this to: `hex` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/lib.rs:32:37 [INFO] [stdout] | [INFO] [stdout] 32 | write!(f, "{}", " ")?; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stdout] = note: `#[warn(clippy::write_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 32 - write!(f, "{}", " ")?; [INFO] [stdout] 32 + write!(f, " ")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | / match &self.extra { [INFO] [stdout] 41 | | Some(extra) => { [INFO] [stdout] 42 | | for (key, value) in extra.iter() { [INFO] [stdout] 43 | | write!(f, "\n - {}: {}", key.italic(), value)?; [INFO] [stdout] ... | [INFO] [stdout] 46 | | None => (), [INFO] [stdout] 47 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 40 ~ if let Some(extra) = &self.extra { [INFO] [stdout] 41 + for (key, value) in extra.iter() { [INFO] [stdout] 42 + write!(f, "\n - {}: {}", key.italic(), value)?; [INFO] [stdout] 43 + } [INFO] [stdout] 44 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::array::::map` that must be used [INFO] [stdout] --> src/backup.rs:245:9 [INFO] [stdout] | [INFO] [stdout] 245 | / files.map(|file| { [INFO] [stdout] 246 | | assert_eq!( [INFO] [stdout] 247 | | fs::read_to_string(dir.path().join(file)).unwrap(), [INFO] [stdout] 248 | | "some text here" [INFO] [stdout] 249 | | ) [INFO] [stdout] 250 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 245 | let _ = files.map(|file| { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::array::::map` that must be used [INFO] [stdout] --> src/backup.rs:273:9 [INFO] [stdout] | [INFO] [stdout] 273 | / files.map(|file| { [INFO] [stdout] 274 | | assert_eq!( [INFO] [stdout] 275 | | fs::read_to_string(dest.path().join(file)).unwrap(), [INFO] [stdout] 276 | | "some text here" [INFO] [stdout] 277 | | ) [INFO] [stdout] 278 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 273 | let _ = files.map(|file| { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 31.14s [INFO] running `Command { std: "docker" "inspect" "1eed134c9ac6a6e0ef89f1ccd2cf5e350e1b1100609d12ee8afd3926190f5a65", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1eed134c9ac6a6e0ef89f1ccd2cf5e350e1b1100609d12ee8afd3926190f5a65", kill_on_drop: false }` [INFO] [stdout] 1eed134c9ac6a6e0ef89f1ccd2cf5e350e1b1100609d12ee8afd3926190f5a65