[INFO] cloning repository https://github.com/manorajesh/rem [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/manorajesh/rem" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmanorajesh%2Frem", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmanorajesh%2Frem'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a34ce5f2ac6d9eb7701ea79ce2385ef12f6b7499 [INFO] linting manorajesh/rem against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmanorajesh%2Frem" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/manorajesh/rem [INFO] finished tweaking git repo https://github.com/manorajesh/rem [INFO] tweaked toml for git repo https://github.com/manorajesh/rem written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/manorajesh/rem on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/manorajesh/rem already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded libloading v0.8.1 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.91 [INFO] [stderr] Downloaded bitflags v2.4.2 [INFO] [stderr] Downloaded thiserror-impl v1.0.57 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.91 [INFO] [stderr] Downloaded wasm-bindgen-backend v0.2.91 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.91 [INFO] [stderr] Downloaded svg_fmt v0.4.1 [INFO] [stderr] Downloaded downcast-rs v1.2.0 [INFO] [stderr] Downloaded self_cell v1.0.3 [INFO] [stderr] Downloaded font-types v0.4.2 [INFO] [stderr] Downloaded xml-rs v0.8.19 [INFO] [stderr] Downloaded bytes v1.5.0 [INFO] [stderr] Downloaded polling v3.5.0 [INFO] [stderr] Downloaded fontdb v0.15.0 [INFO] [stderr] Downloaded wgpu v0.19.1 [INFO] [stderr] Downloaded combine v4.6.6 [INFO] [stderr] Downloaded ttf-parser v0.19.2 [INFO] [stderr] Downloaded wasm-bindgen v0.2.91 [INFO] [stderr] Downloaded js-sys v0.3.68 [INFO] [stderr] Downloaded glyphon v0.5.0 [INFO] [stderr] Downloaded wgpu-core v0.19.0 [INFO] [stderr] Downloaded rustybuzz v0.11.0 [INFO] [stderr] Downloaded swash v0.1.12 [INFO] [stderr] Downloaded wgpu-hal v0.19.1 [INFO] [stderr] Downloaded read-fonts v0.15.6 [INFO] [stderr] Downloaded syn v2.0.52 [INFO] [stderr] Downloaded rustix v0.38.31 [INFO] [stderr] Downloaded bumpalo v3.15.3 [INFO] [stderr] Downloaded allocator-api2 v0.2.16 [INFO] [stderr] Downloaded indexmap v2.2.4 [INFO] [stderr] Downloaded cc v1.0.88 [INFO] [stderr] Downloaded wgpu-types v0.19.0 [INFO] [stderr] Downloaded ash v0.37.3+1.3.251 [INFO] [stderr] Downloaded core-graphics v0.23.1 [INFO] [stderr] Downloaded bytemuck v1.14.3 [INFO] [stderr] Downloaded smallvec v1.13.1 [INFO] [stderr] Downloaded proc-macro2 v1.0.78 [INFO] [stderr] Downloaded naga v0.19.0 [INFO] [stderr] Downloaded winit v0.29.11 [INFO] [stderr] Downloaded d3d12 v0.19.0 [INFO] [stderr] Downloaded gpu-allocator v0.25.0 [INFO] [stderr] Downloaded unicode-width v0.1.11 [INFO] [stderr] Downloaded walkdir v2.4.0 [INFO] [stderr] Downloaded ahash v0.8.10 [INFO] [stderr] Downloaded objc-sys v0.3.2 [INFO] [stderr] Downloaded ab_glyph v0.2.23 [INFO] [stderr] Downloaded thiserror v1.0.57 [INFO] [stderr] Downloaded web-sys v0.3.68 [INFO] [stderr] Downloaded sys-locale v0.3.1 [INFO] [stderr] Downloaded etagere v0.2.10 [INFO] [stderr] Downloaded gpu-descriptor-types v0.1.2 [INFO] [stderr] Downloaded gpu-descriptor v0.2.4 [INFO] [stderr] Downloaded renderdoc-sys v1.0.0 [INFO] [stderr] Downloaded pollster v0.3.0 [INFO] [stderr] Downloaded profiling v1.0.15 [INFO] [stderr] Downloaded range-alloc v0.1.3 [INFO] [stderr] Downloaded wasm-bindgen-futures v0.4.41 [INFO] [stderr] Downloaded cosmic-text v0.10.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b2fd42180c6c91ccbfec470f34b77f6a079d9deb8ede2028382f76bfde1f5377 [INFO] running `Command { std: "docker" "start" "-a" "b2fd42180c6c91ccbfec470f34b77f6a079d9deb8ede2028382f76bfde1f5377", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b2fd42180c6c91ccbfec470f34b77f6a079d9deb8ede2028382f76bfde1f5377", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b2fd42180c6c91ccbfec470f34b77f6a079d9deb8ede2028382f76bfde1f5377", kill_on_drop: false }` [INFO] [stdout] b2fd42180c6c91ccbfec470f34b77f6a079d9deb8ede2028382f76bfde1f5377 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 26727c6a2837acd108d378a456e54d215a3d4e56bcaa608fd5a04ad8f2d49cef [INFO] running `Command { std: "docker" "start" "-a" "26727c6a2837acd108d378a456e54d215a3d4e56bcaa608fd5a04ad8f2d49cef", kill_on_drop: false }` [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking libloading v0.8.1 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Compiling cc v1.0.88 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Checking downcast-rs v1.2.0 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Compiling memchr v2.7.1 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking allocator-api2 v0.2.16 [INFO] [stderr] Checking ttf-parser v0.20.0 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling ahash v0.8.10 [INFO] [stderr] Checking bytemuck v1.14.3 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Compiling ash v0.37.3+1.3.251 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling wayland-sys v0.31.1 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking codespan-reporting v0.11.1 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Checking gpu-alloc-types v0.3.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking spirv v0.3.0+sdk-1.3.268.0 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking gpu-descriptor-types v0.1.2 [INFO] [stderr] Compiling wgpu-hal v0.19.1 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking libloading v0.7.4 [INFO] [stderr] Checking unicode-xid v0.2.4 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling quick-xml v0.31.0 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking raw-window-handle v0.6.0 [INFO] [stderr] Checking gpu-alloc v0.6.0 [INFO] [stderr] Checking wgpu-types v0.19.0 [INFO] [stderr] Compiling wgpu-core v0.19.0 [INFO] [stderr] Checking xcursor v0.3.5 [INFO] [stderr] Checking xkeysym v0.2.0 [INFO] [stderr] Checking arrayref v0.3.7 [INFO] [stderr] Checking cursor-icon v1.1.0 [INFO] [stderr] Checking font-types v0.4.2 [INFO] [stderr] Checking strict-num v0.1.1 [INFO] [stderr] Compiling wayland-backend v0.3.3 [INFO] [stderr] Compiling smithay-client-toolkit v0.18.1 [INFO] [stderr] Checking roxmltree v0.19.0 [INFO] [stderr] Checking renderdoc-sys v1.0.0 [INFO] [stderr] Checking profiling v1.0.15 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking khronos-egl v6.0.0 [INFO] [stderr] Checking glow v0.13.1 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling wayland-scanner v0.31.1 [INFO] [stderr] Checking memmap2 v0.8.0 [INFO] [stderr] Checking read-fonts v0.15.6 [INFO] [stderr] Checking fontconfig-parser v0.5.6 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Compiling wgpu v0.19.1 [INFO] [stderr] Checking ttf-parser v0.19.2 [INFO] [stderr] Checking unicode-bidi-mirroring v0.1.0 [INFO] [stderr] Checking unicode-script v0.5.6 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.8 [INFO] [stderr] Checking yazi v0.1.6 [INFO] [stderr] Checking zeno v0.2.3 [INFO] [stderr] Checking unicode-properties v0.1.1 [INFO] [stderr] Checking unicode-ccc v0.1.2 [INFO] [stderr] Checking euclid v0.22.9 [INFO] [stderr] Checking owned_ttf_parser v0.20.0 [INFO] [stderr] Checking ab_glyph v0.2.23 [INFO] [stderr] Compiling winit v0.29.11 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking rustybuzz v0.11.0 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking svg_fmt v0.4.1 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking indexmap v2.2.4 [INFO] [stderr] Checking gpu-descriptor v0.2.4 [INFO] [stderr] Checking rangemap v1.5.1 [INFO] [stderr] Checking x11rb-protocol v0.13.0 [INFO] [stderr] Checking sys-locale v0.3.1 [INFO] [stderr] Checking self_cell v1.0.3 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Checking lru v0.12.3 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking smol_str v0.2.1 [INFO] [stderr] Checking pollster v0.3.0 [INFO] [stderr] Checking etagere v0.2.10 [INFO] [stderr] Checking fontdb v0.15.0 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Checking naga v0.19.0 [INFO] [stderr] Checking polling v3.5.0 [INFO] [stderr] Checking calloop v0.12.4 [INFO] [stderr] Checking swash v0.1.12 [INFO] [stderr] Checking wayland-client v0.31.2 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking wayland-protocols v0.31.2 [INFO] [stderr] Checking calloop-wayland-source v0.2.0 [INFO] [stderr] Checking wayland-cursor v0.31.1 [INFO] [stderr] Checking cosmic-text v0.10.0 [INFO] [stderr] Checking wayland-protocols-wlr v0.2.0 [INFO] [stderr] Checking wayland-protocols-plasma v0.2.0 [INFO] [stderr] Checking sctk-adwaita v0.8.1 [INFO] [stderr] Checking x11rb v0.13.0 [INFO] [stderr] Checking glyphon v0.5.0 [INFO] [stderr] Checking rem v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/main.rs:57:29 [INFO] [stdout] | [INFO] [stdout] 26 | ... KeyEvent { state, logical_key, .. } => { [INFO] [stdout] | ----------------------------------- matches any value [INFO] [stdout] ... [INFO] [stdout] 57 | ... _ => {} [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `close` is never used [INFO] [stdout] --> src/renderer.rs:204:12 [INFO] [stdout] | [INFO] [stdout] 54 | impl Renderer<'static> { [INFO] [stdout] | ---------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 204 | pub fn close(&self) {} [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/renderer.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | / return Self { [INFO] [stdout] 119 | | text_renderer, [INFO] [stdout] 120 | | device, [INFO] [stdout] 121 | | queue, [INFO] [stdout] ... | [INFO] [stdout] 129 | | text: String::new(), [INFO] [stdout] 130 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 ~ Self { [INFO] [stdout] 119 + text_renderer, [INFO] [stdout] 120 + device, [INFO] [stdout] 121 + queue, [INFO] [stdout] 122 + surface, [INFO] [stdout] 123 + config, [INFO] [stdout] 124 + atlas, [INFO] [stdout] 125 + font_system, [INFO] [stdout] 126 + buffer, [INFO] [stdout] 127 + cache, [INFO] [stdout] 128 + window, [INFO] [stdout] 129 + text: String::new(), [INFO] [stdout] 130 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:25:25 [INFO] [stdout] | [INFO] [stdout] 25 | / match event { [INFO] [stdout] 26 | | KeyEvent { state, logical_key, .. } => { [INFO] [stdout] 27 | | if state == winit::event::ElementState::Pressed { [INFO] [stdout] 28 | | match logical_key { [INFO] [stdout] ... | [INFO] [stdout] 57 | | _ => {} [INFO] [stdout] 58 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/main.rs:24:50 [INFO] [stdout] | [INFO] [stdout] 24 | WindowEvent::KeyboardInput { event, .. } => { [INFO] [stdout] | ^^^^^ replace this binding [INFO] [stdout] 25 | match event { [INFO] [stdout] 26 | KeyEvent { state, logical_key, .. } => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern, prefixed by `event: ` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:27:33 [INFO] [stdout] | [INFO] [stdout] 27 | / ... if state == winit::event::ElementState::Pressed { [INFO] [stdout] 28 | | ... match logical_key { [INFO] [stdout] 29 | | ... Key::Character(c) => { [INFO] [stdout] ... | [INFO] [stdout] 54 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 26 ~ KeyEvent { state, logical_key, .. } [INFO] [stdout] 27 ~ if state == winit::event::ElementState::Pressed => { [INFO] [stdout] 28 | match logical_key { [INFO] [stdout] ... [INFO] [stdout] 53 | } [INFO] [stdout] 54 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:25:25 [INFO] [stdout] | [INFO] [stdout] 25 | / match event { [INFO] [stdout] 26 | | KeyEvent { state, logical_key, .. } => { [INFO] [stdout] 27 | | if state == winit::event::ElementState::Pressed { [INFO] [stdout] 28 | | match logical_key { [INFO] [stdout] ... | [INFO] [stdout] 57 | | _ => {} [INFO] [stdout] 58 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 25 ~ if let KeyEvent { state, logical_key, .. } = event { [INFO] [stdout] 26 + if state == winit::event::ElementState::Pressed { [INFO] [stdout] 27 + match logical_key { [INFO] [stdout] 28 + Key::Character(c) => { [INFO] [stdout] 29 + // println!("Pressed character: {}", c); [INFO] [stdout] 30 + renderer.push_str(c.as_str()); [INFO] [stdout] 31 + renderer.redraw(); [INFO] [stdout] 32 + } [INFO] [stdout] 33 + Key::Named(c) => { [INFO] [stdout] 34 + // println!("Pressed named: {:?}", c); [INFO] [stdout] 35 + match c { [INFO] [stdout] 36 + NamedKey::Backspace => { [INFO] [stdout] 37 + renderer.pop_char(); [INFO] [stdout] 38 + } [INFO] [stdout] 39 + NamedKey::Escape => { [INFO] [stdout] 40 + renderer.clear(); [INFO] [stdout] 41 + } [INFO] [stdout] 42 + _ => { [INFO] [stdout] 43 + renderer.push_str(c.to_text().unwrap_or("")); [INFO] [stdout] 44 + } [INFO] [stdout] 45 + } [INFO] [stdout] 46 + renderer.redraw(); [INFO] [stdout] 47 + } [INFO] [stdout] 48 + Key::Unidentified(c) => { [INFO] [stdout] 49 + println!("Pressed unidentified: {:?}", c); [INFO] [stdout] 50 + } [INFO] [stdout] 51 + _ => {} [INFO] [stdout] 52 + } [INFO] [stdout] 53 + } [INFO] [stdout] 54 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/main.rs:57:29 [INFO] [stdout] | [INFO] [stdout] 26 | ... KeyEvent { state, logical_key, .. } => { [INFO] [stdout] | ----------------------------------- matches any value [INFO] [stdout] ... [INFO] [stdout] 57 | ... _ => {} [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `close` is never used [INFO] [stdout] --> src/renderer.rs:204:12 [INFO] [stdout] | [INFO] [stdout] 54 | impl Renderer<'static> { [INFO] [stdout] | ---------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 204 | pub fn close(&self) {} [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/renderer.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | / return Self { [INFO] [stdout] 119 | | text_renderer, [INFO] [stdout] 120 | | device, [INFO] [stdout] 121 | | queue, [INFO] [stdout] ... | [INFO] [stdout] 129 | | text: String::new(), [INFO] [stdout] 130 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 ~ Self { [INFO] [stdout] 119 + text_renderer, [INFO] [stdout] 120 + device, [INFO] [stdout] 121 + queue, [INFO] [stdout] 122 + surface, [INFO] [stdout] 123 + config, [INFO] [stdout] 124 + atlas, [INFO] [stdout] 125 + font_system, [INFO] [stdout] 126 + buffer, [INFO] [stdout] 127 + cache, [INFO] [stdout] 128 + window, [INFO] [stdout] 129 + text: String::new(), [INFO] [stdout] 130 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:25:25 [INFO] [stdout] | [INFO] [stdout] 25 | / match event { [INFO] [stdout] 26 | | KeyEvent { state, logical_key, .. } => { [INFO] [stdout] 27 | | if state == winit::event::ElementState::Pressed { [INFO] [stdout] 28 | | match logical_key { [INFO] [stdout] ... | [INFO] [stdout] 57 | | _ => {} [INFO] [stdout] 58 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/main.rs:24:50 [INFO] [stdout] | [INFO] [stdout] 24 | WindowEvent::KeyboardInput { event, .. } => { [INFO] [stdout] | ^^^^^ replace this binding [INFO] [stdout] 25 | match event { [INFO] [stdout] 26 | KeyEvent { state, logical_key, .. } => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern, prefixed by `event: ` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:27:33 [INFO] [stdout] | [INFO] [stdout] 27 | / ... if state == winit::event::ElementState::Pressed { [INFO] [stdout] 28 | | ... match logical_key { [INFO] [stdout] 29 | | ... Key::Character(c) => { [INFO] [stdout] ... | [INFO] [stdout] 54 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 26 ~ KeyEvent { state, logical_key, .. } [INFO] [stdout] 27 ~ if state == winit::event::ElementState::Pressed => { [INFO] [stdout] 28 | match logical_key { [INFO] [stdout] ... [INFO] [stdout] 53 | } [INFO] [stdout] 54 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:25:25 [INFO] [stdout] | [INFO] [stdout] 25 | / match event { [INFO] [stdout] 26 | | KeyEvent { state, logical_key, .. } => { [INFO] [stdout] 27 | | if state == winit::event::ElementState::Pressed { [INFO] [stdout] 28 | | match logical_key { [INFO] [stdout] ... | [INFO] [stdout] 57 | | _ => {} [INFO] [stdout] 58 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 25 ~ if let KeyEvent { state, logical_key, .. } = event { [INFO] [stdout] 26 + if state == winit::event::ElementState::Pressed { [INFO] [stdout] 27 + match logical_key { [INFO] [stdout] 28 + Key::Character(c) => { [INFO] [stdout] 29 + // println!("Pressed character: {}", c); [INFO] [stdout] 30 + renderer.push_str(c.as_str()); [INFO] [stdout] 31 + renderer.redraw(); [INFO] [stdout] 32 + } [INFO] [stdout] 33 + Key::Named(c) => { [INFO] [stdout] 34 + // println!("Pressed named: {:?}", c); [INFO] [stdout] 35 + match c { [INFO] [stdout] 36 + NamedKey::Backspace => { [INFO] [stdout] 37 + renderer.pop_char(); [INFO] [stdout] 38 + } [INFO] [stdout] 39 + NamedKey::Escape => { [INFO] [stdout] 40 + renderer.clear(); [INFO] [stdout] 41 + } [INFO] [stdout] 42 + _ => { [INFO] [stdout] 43 + renderer.push_str(c.to_text().unwrap_or("")); [INFO] [stdout] 44 + } [INFO] [stdout] 45 + } [INFO] [stdout] 46 + renderer.redraw(); [INFO] [stdout] 47 + } [INFO] [stdout] 48 + Key::Unidentified(c) => { [INFO] [stdout] 49 + println!("Pressed unidentified: {:?}", c); [INFO] [stdout] 50 + } [INFO] [stdout] 51 + _ => {} [INFO] [stdout] 52 + } [INFO] [stdout] 53 + } [INFO] [stdout] 54 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 00s [INFO] running `Command { std: "docker" "inspect" "26727c6a2837acd108d378a456e54d215a3d4e56bcaa608fd5a04ad8f2d49cef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "26727c6a2837acd108d378a456e54d215a3d4e56bcaa608fd5a04ad8f2d49cef", kill_on_drop: false }` [INFO] [stdout] 26727c6a2837acd108d378a456e54d215a3d4e56bcaa608fd5a04ad8f2d49cef