[INFO] cloning repository https://github.com/manhlinhfs/docsync
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/manhlinhfs/docsync" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmanhlinhfs%2Fdocsync", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmanhlinhfs%2Fdocsync'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 00f52f74aee3f6acc695a5e7992461b15a1a187c
[INFO] linting manhlinhfs/docsync against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmanhlinhfs%2Fdocsync" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/manhlinhfs/docsync
[INFO] finished tweaking git repo https://github.com/manhlinhfs/docsync
[INFO] tweaked toml for git repo https://github.com/manhlinhfs/docsync written to /workspace/builds/worker-5-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/manhlinhfs/docsync on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/manhlinhfs/docsync already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded clap_complete v4.5.66
[INFO] [stderr]   Downloaded ipnet v2.12.0
[INFO] [stderr]   Downloaded html2md v0.2.15
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 2f344642c0e618efc3c85c4344808df66e77eda1e8e8576ce0e12ab04707c1be
[INFO] running `Command { std: "docker" "start" "-a" "2f344642c0e618efc3c85c4344808df66e77eda1e8e8576ce0e12ab04707c1be", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "2f344642c0e618efc3c85c4344808df66e77eda1e8e8576ce0e12ab04707c1be", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "2f344642c0e618efc3c85c4344808df66e77eda1e8e8576ce0e12ab04707c1be", kill_on_drop: false }`
[INFO] [stdout] 2f344642c0e618efc3c85c4344808df66e77eda1e8e8576ce0e12ab04707c1be
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] bc01255bced275c9741b32ec02b2266a151577397c93b215dc89e1ff5d238a39
[INFO] running `Command { std: "docker" "start" "-a" "bc01255bced275c9741b32ec02b2266a151577397c93b215dc89e1ff5d238a39", kill_on_drop: false }`
[INFO] [stderr]    Compiling quote v1.0.45
[INFO] [stderr]    Compiling siphasher v1.0.2
[INFO] [stderr]     Checking socket2 v0.6.3
[INFO] [stderr]     Checking parking_lot_core v0.9.12
[INFO] [stderr]     Checking getrandom v0.2.17
[INFO] [stderr]     Checking futf v0.1.5
[INFO] [stderr]     Checking futures-util v0.3.32
[INFO] [stderr]     Checking tracing-core v0.1.36
[INFO] [stderr]     Checking ipnet v2.12.0
[INFO] [stderr]     Checking clap_builder v4.5.60
[INFO] [stderr]     Checking regex-automata v0.4.14
[INFO] [stderr]     Checking bitflags v2.11.0
[INFO] [stderr]     Checking serde_json v1.0.149
[INFO] [stderr]     Checking http-body-util v0.1.3
[INFO] [stderr]     Checking phf_shared v0.11.3
[INFO] [stderr]     Checking quick-xml v0.38.4
[INFO] [stderr]     Checking ring v0.17.14
[INFO] [stderr]     Checking parking_lot v0.12.5
[INFO] [stderr]     Checking phf v0.11.3
[INFO] [stderr]     Checking tendril v0.4.3
[INFO] [stderr]    Compiling phf_generator v0.11.3
[INFO] [stderr]     Checking tokio v1.50.0
[INFO] [stderr]     Checking tracing v0.1.44
[INFO] [stderr]    Compiling syn v2.0.117
[INFO] [stderr]    Compiling string_cache_codegen v0.5.4
[INFO] [stderr]    Compiling phf_codegen v0.11.3
[INFO] [stderr]    Compiling markup5ever v0.12.1
[INFO] [stderr]     Checking rustls-webpki v0.103.9
[INFO] [stderr]     Checking regex v1.12.3
[INFO] [stderr]     Checking rustls v0.23.37
[INFO] [stderr]     Checking hyper v1.8.1
[INFO] [stderr]     Checking tower v0.5.3
[INFO] [stderr]    Compiling synstructure v0.13.2
[INFO] [stderr]     Checking tower-http v0.6.8
[INFO] [stderr]     Checking hyper-util v0.1.20
[INFO] [stderr]    Compiling zerovec-derive v0.11.2
[INFO] [stderr]    Compiling displaydoc v0.2.5
[INFO] [stderr]    Compiling serde_derive v1.0.228
[INFO] [stderr]    Compiling html5ever v0.27.0
[INFO] [stderr]    Compiling clap_derive v4.5.55
[INFO] [stderr]    Compiling zerofrom-derive v0.1.6
[INFO] [stderr]    Compiling yoke-derive v0.8.1
[INFO] [stderr]     Checking tokio-rustls v0.26.4
[INFO] [stderr]     Checking zerofrom v0.1.6
[INFO] [stderr]     Checking yoke v0.8.1
[INFO] [stderr]     Checking zerovec v0.11.5
[INFO] [stderr]     Checking zerotrie v0.2.3
[INFO] [stderr]     Checking hyper-rustls v0.27.7
[INFO] [stderr]     Checking clap v4.5.60
[INFO] [stderr]     Checking clap_complete v4.5.66
[INFO] [stderr]     Checking tinystr v0.8.2
[INFO] [stderr]     Checking potential_utf v0.1.4
[INFO] [stderr]     Checking icu_collections v2.1.1
[INFO] [stderr]     Checking icu_locale_core v2.1.1
[INFO] [stderr]     Checking icu_provider v2.1.1
[INFO] [stderr]     Checking serde v1.0.228
[INFO] [stderr]     Checking icu_normalizer v2.1.1
[INFO] [stderr]     Checking icu_properties v2.1.2
[INFO] [stderr]     Checking string_cache v0.8.9
[INFO] [stderr]     Checking serde_urlencoded v0.7.1
[INFO] [stderr]     Checking chrono v0.4.44
[INFO] [stderr]     Checking idna_adapter v1.2.1
[INFO] [stderr]     Checking xml5ever v0.18.1
[INFO] [stderr]     Checking idna v1.1.0
[INFO] [stderr]     Checking url v2.5.8
[INFO] [stderr]     Checking markup5ever_rcdom v0.3.0
[INFO] [stderr]     Checking html2md v0.2.15
[INFO] [stderr]     Checking reqwest v0.12.28
[INFO] [stderr]     Checking docsync v1.4.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/dashboard.rs:146:9
[INFO] [stdout]     |
[INFO] [stdout] 146 | /         if let Some(fetch) = entry.manifest.fetch.as_ref() {
[INFO] [stdout] 147 | |             if let Some(quality) = fetch.quality.as_ref() {
[INFO] [stdout] 148 | |                 pages_shown += quality.pages_scored;
[INFO] [stdout] 149 | |                 high_quality_pages += quality.high_quality_pages;
[INFO] [stdout] ...   |
[INFO] [stdout] 153 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 146 ~         if let Some(fetch) = entry.manifest.fetch.as_ref()
[INFO] [stdout] 147 ~             && let Some(quality) = fetch.quality.as_ref() {
[INFO] [stdout] 148 |                 pages_shown += quality.pages_scored;
[INFO] [stdout] ...
[INFO] [stdout] 151 |                 low_quality_pages += quality.low_quality_pages;
[INFO] [stdout] 152 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]     --> src/dashboard.rs:1050:17
[INFO] [stdout]      |
[INFO] [stdout] 1050 | /                 if let Ok(text) = std::str::from_utf8(&hex) {
[INFO] [stdout] 1051 | |                     if let Ok(value) = u8::from_str_radix(text, 16) {
[INFO] [stdout] 1052 | |                         bytes.push(value);
[INFO] [stdout] 1053 | |                         continue;
[INFO] [stdout] 1054 | |                     }
[INFO] [stdout] 1055 | |                 }
[INFO] [stdout]      | |_________________^
[INFO] [stdout]      |
[INFO] [stdout]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]      |
[INFO] [stdout] 1050 ~                 if let Ok(text) = std::str::from_utf8(&hex)
[INFO] [stdout] 1051 ~                     && let Ok(value) = u8::from_str_radix(text, 16) {
[INFO] [stdout] 1052 |                         bytes.push(value);
[INFO] [stdout] 1053 |                         continue;
[INFO] [stdout] 1054 ~                     }
[INFO] [stdout]      |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]     --> src/dashboard.rs:1161:9
[INFO] [stdout]      |
[INFO] [stdout] 1161 |         return Ok(child.id());
[INFO] [stdout]      |         ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]      |
[INFO] [stdout]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]      = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]      |
[INFO] [stdout] 1161 -         return Ok(child.id());
[INFO] [stdout] 1161 +         Ok(child.id())
[INFO] [stdout]      |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/discovery.rs:94:13
[INFO] [stdout]     |
[INFO] [stdout]  94 | /             if report.llms.available {
[INFO] [stdout]  95 | |                 if let Some(url) = llms_index_url.as_deref() {
[INFO] [stdout]  96 | |                     frontier.extend(fetch_llms_frontier(
[INFO] [stdout]  97 | |                         &client,
[INFO] [stdout] ...   |
[INFO] [stdout] 102 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout]  94 ~             if report.llms.available
[INFO] [stdout]  95 ~                 && let Some(url) = llms_index_url.as_deref() {
[INFO] [stdout]  96 |                     frontier.extend(fetch_llms_frontier(
[INFO] [stdout] ...
[INFO] [stdout] 100 |                     )?);
[INFO] [stdout] 101 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (9/7)
[INFO] [stdout]   --> src/fetch.rs:30:1
[INFO] [stdout]    |
[INFO] [stdout] 30 | / pub fn fetch_snapshot_pages(
[INFO] [stdout] 31 | |     snapshot_dir: &Path,
[INFO] [stdout] 32 | |     source: &SourceDefinition,
[INFO] [stdout] 33 | |     source_ref: &str,
[INFO] [stdout] ...  |
[INFO] [stdout] 39 | |     chunking: ChunkingConfig,
[INFO] [stdout] 40 | | ) -> Result<FetchOutcome> {
[INFO] [stdout]    | |_________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout]    = note: `#[warn(clippy::too_many_arguments)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (12/7)
[INFO] [stdout]    --> src/fetch.rs:154:1
[INFO] [stdout]     |
[INFO] [stdout] 154 | / fn fetch_one_page(
[INFO] [stdout] 155 | |     client: &reqwest::blocking::Client,
[INFO] [stdout] 156 | |     pages_root: &Path,
[INFO] [stdout] 157 | |     raw_root: &Path,
[INFO] [stdout] ...   |
[INFO] [stdout] 166 | |     chunking: ChunkingConfig,
[INFO] [stdout] 167 | | ) -> Result<PageManifestEntry> {
[INFO] [stdout]     | |______________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/fetch.rs:200:5
[INFO] [stdout]     |
[INFO] [stdout] 200 | /     if response.status() == StatusCode::NOT_MODIFIED {
[INFO] [stdout] 201 | |         if let Some(previous) = previous {
[INFO] [stdout] 202 | |             let content_hash = previous.content_hash.clone().or_else(|| {
[INFO] [stdout] 203 | |                 previous
[INFO] [stdout] ...   |
[INFO] [stdout] 296 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 200 ~     if response.status() == StatusCode::NOT_MODIFIED
[INFO] [stdout] 201 ~         && let Some(previous) = previous {
[INFO] [stdout] 202 |             let content_hash = previous.content_hash.clone().or_else(|| {
[INFO] [stdout] ...
[INFO] [stdout] 294 |             });
[INFO] [stdout] 295 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/fetch.rs:382:9
[INFO] [stdout]     |
[INFO] [stdout] 382 | /         if let Some(browser_cmd) = browser_cmd {
[INFO] [stdout] 383 | |             if should_try_headless(&html, &fallback_markdown) {
[INFO] [stdout] 384 | |                 if let Ok(rendered_html) = render_url(browser_cmd, final_url.as_str(), proxy_url) {
[INFO] [stdout] 385 | |                     write_bytes(&rendered_raw_path, rendered_html.as_bytes())?;
[INFO] [stdout] ...   |
[INFO] [stdout] 391 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 382 ~         if let Some(browser_cmd) = browser_cmd
[INFO] [stdout] 383 ~             && should_try_headless(&html, &fallback_markdown) {
[INFO] [stdout] 384 |                 if let Ok(rendered_html) = render_url(browser_cmd, final_url.as_str(), proxy_url) {
[INFO] [stdout] ...
[INFO] [stdout] 389 |                 }
[INFO] [stdout] 390 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/fetch.rs:383:13
[INFO] [stdout]     |
[INFO] [stdout] 383 | /             if should_try_headless(&html, &fallback_markdown) {
[INFO] [stdout] 384 | |                 if let Ok(rendered_html) = render_url(browser_cmd, final_url.as_str(), proxy_url) {
[INFO] [stdout] 385 | |                     write_bytes(&rendered_raw_path, rendered_html.as_bytes())?;
[INFO] [stdout] 386 | |                     final_markdown = html_to_markdown(rendered_html.as_bytes());
[INFO] [stdout] ...   |
[INFO] [stdout] 390 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 383 ~             if should_try_headless(&html, &fallback_markdown)
[INFO] [stdout] 384 ~                 && let Ok(rendered_html) = render_url(browser_cmd, final_url.as_str(), proxy_url) {
[INFO] [stdout] 385 |                     write_bytes(&rendered_raw_path, rendered_html.as_bytes())?;
[INFO] [stdout] ...
[INFO] [stdout] 388 |                     rendered_raw_output_path = Some(rendered_raw_path.clone());
[INFO] [stdout] 389 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (9/7)
[INFO] [stdout]   --> src/git_sync.rs:40:1
[INFO] [stdout]    |
[INFO] [stdout] 40 | / pub fn sync_git_source(
[INFO] [stdout] 41 | |     snapshot_dir: &Path,
[INFO] [stdout] 42 | |     source: &SourceDefinition,
[INFO] [stdout] 43 | |     source_ref: &str,
[INFO] [stdout] ...  |
[INFO] [stdout] 49 | |     chunking: ChunkingConfig,
[INFO] [stdout] 50 | | ) -> Result<GitSyncOutcome> {
[INFO] [stdout]    | |___________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (11/7)
[INFO] [stdout]    --> src/git_sync.rs:189:1
[INFO] [stdout]     |
[INFO] [stdout] 189 | / fn snapshot_git_pages(
[INFO] [stdout] 190 | |     snapshot_dir: &Path,
[INFO] [stdout] 191 | |     source: &SourceDefinition,
[INFO] [stdout] 192 | |     source_ref: &str,
[INFO] [stdout] ...   |
[INFO] [stdout] 200 | |     chunking: ChunkingConfig,
[INFO] [stdout] 201 | | ) -> Result<(FetchSummary, Vec<PageManifestEntry>)> {
[INFO] [stdout]     | |___________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/headless.rs:44:5
[INFO] [stdout]    |
[INFO] [stdout] 44 |     (script_count >= 5 && thin_markdown) || (has_dynamic_marker && thin_markdown)
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 44 -     (script_count >= 5 && thin_markdown) || (has_dynamic_marker && thin_markdown)
[INFO] [stdout] 44 +     !(!thin_markdown || script_count < 5 && !has_dynamic_marker)
[INFO] [stdout]    |
[INFO] [stdout] 44 -     (script_count >= 5 && thin_markdown) || (has_dynamic_marker && thin_markdown)
[INFO] [stdout] 44 +     (has_dynamic_marker || script_count >= 5) && thin_markdown
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/incremental.rs:124:5
[INFO] [stdout]     |
[INFO] [stdout] 124 | /     if entry.fetch_method == "git_checkout" {
[INFO] [stdout] 125 | |         if let Some(page_path) = entry.page_path.as_deref() {
[INFO] [stdout] 126 | |             if let Some(root) = snapshot_dir {
[INFO] [stdout] 127 | |                 let pages_root = root.join("pages");
[INFO] [stdout] ...   |
[INFO] [stdout] 133 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 124 ~     if entry.fetch_method == "git_checkout"
[INFO] [stdout] 125 ~         && let Some(page_path) = entry.page_path.as_deref() {
[INFO] [stdout] 126 |             if let Some(root) = snapshot_dir {
[INFO] [stdout] ...
[INFO] [stdout] 131 |             }
[INFO] [stdout] 132 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/incremental.rs:125:9
[INFO] [stdout]     |
[INFO] [stdout] 125 | /         if let Some(page_path) = entry.page_path.as_deref() {
[INFO] [stdout] 126 | |             if let Some(root) = snapshot_dir {
[INFO] [stdout] 127 | |                 let pages_root = root.join("pages");
[INFO] [stdout] 128 | |                 if let Ok(relative) = page_path.strip_prefix(&pages_root) {
[INFO] [stdout] ...   |
[INFO] [stdout] 132 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 125 ~         if let Some(page_path) = entry.page_path.as_deref()
[INFO] [stdout] 126 ~             && let Some(root) = snapshot_dir {
[INFO] [stdout] 127 |                 let pages_root = root.join("pages");
[INFO] [stdout] ...
[INFO] [stdout] 130 |                 }
[INFO] [stdout] 131 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/incremental.rs:147:5
[INFO] [stdout]     |
[INFO] [stdout] 147 | /     if let Some(path) = entry.page_path.as_deref() {
[INFO] [stdout] 148 | |         if path.is_file() {
[INFO] [stdout] 149 | |             return Ok(Some(sha256_hex(
[INFO] [stdout] 150 | |                 &fs::read(path).with_context(|| format!("failed to read {}", path.display()))?,
[INFO] [stdout] ...   |
[INFO] [stdout] 153 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 147 ~     if let Some(path) = entry.page_path.as_deref()
[INFO] [stdout] 148 ~         && path.is_file() {
[INFO] [stdout] 149 |             return Ok(Some(sha256_hex(
[INFO] [stdout] 150 |                 &fs::read(path).with_context(|| format!("failed to read {}", path.display()))?,
[INFO] [stdout] 151 |             )));
[INFO] [stdout] 152 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/dashboard.rs:146:9
[INFO] [stdout]     |
[INFO] [stdout] 146 | /         if let Some(fetch) = entry.manifest.fetch.as_ref() {
[INFO] [stdout] 147 | |             if let Some(quality) = fetch.quality.as_ref() {
[INFO] [stdout] 148 | |                 pages_shown += quality.pages_scored;
[INFO] [stdout] 149 | |                 high_quality_pages += quality.high_quality_pages;
[INFO] [stdout] ...   |
[INFO] [stdout] 153 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 146 ~         if let Some(fetch) = entry.manifest.fetch.as_ref()
[INFO] [stdout] 147 ~             && let Some(quality) = fetch.quality.as_ref() {
[INFO] [stdout] 148 |                 pages_shown += quality.pages_scored;
[INFO] [stdout] ...
[INFO] [stdout] 151 |                 low_quality_pages += quality.low_quality_pages;
[INFO] [stdout] 152 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]     --> src/dashboard.rs:1050:17
[INFO] [stdout]      |
[INFO] [stdout] 1050 | /                 if let Ok(text) = std::str::from_utf8(&hex) {
[INFO] [stdout] 1051 | |                     if let Ok(value) = u8::from_str_radix(text, 16) {
[INFO] [stdout] 1052 | |                         bytes.push(value);
[INFO] [stdout] 1053 | |                         continue;
[INFO] [stdout] 1054 | |                     }
[INFO] [stdout] 1055 | |                 }
[INFO] [stdout]      | |_________________^
[INFO] [stdout]      |
[INFO] [stdout]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]      |
[INFO] [stdout] 1050 ~                 if let Ok(text) = std::str::from_utf8(&hex)
[INFO] [stdout] 1051 ~                     && let Ok(value) = u8::from_str_radix(text, 16) {
[INFO] [stdout] 1052 |                         bytes.push(value);
[INFO] [stdout] 1053 |                         continue;
[INFO] [stdout] 1054 ~                     }
[INFO] [stdout]      |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]     --> src/dashboard.rs:1161:9
[INFO] [stdout]      |
[INFO] [stdout] 1161 |         return Ok(child.id());
[INFO] [stdout]      |         ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]      |
[INFO] [stdout]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]      = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]      |
[INFO] [stdout] 1161 -         return Ok(child.id());
[INFO] [stdout] 1161 +         Ok(child.id())
[INFO] [stdout]      |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/discovery.rs:94:13
[INFO] [stdout]     |
[INFO] [stdout]  94 | /             if report.llms.available {
[INFO] [stdout]  95 | |                 if let Some(url) = llms_index_url.as_deref() {
[INFO] [stdout]  96 | |                     frontier.extend(fetch_llms_frontier(
[INFO] [stdout]  97 | |                         &client,
[INFO] [stdout] ...   |
[INFO] [stdout] 102 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout]  94 ~             if report.llms.available
[INFO] [stdout]  95 ~                 && let Some(url) = llms_index_url.as_deref() {
[INFO] [stdout]  96 |                     frontier.extend(fetch_llms_frontier(
[INFO] [stdout] ...
[INFO] [stdout] 100 |                     )?);
[INFO] [stdout] 101 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (9/7)
[INFO] [stdout]   --> src/fetch.rs:30:1
[INFO] [stdout]    |
[INFO] [stdout] 30 | / pub fn fetch_snapshot_pages(
[INFO] [stdout] 31 | |     snapshot_dir: &Path,
[INFO] [stdout] 32 | |     source: &SourceDefinition,
[INFO] [stdout] 33 | |     source_ref: &str,
[INFO] [stdout] ...  |
[INFO] [stdout] 39 | |     chunking: ChunkingConfig,
[INFO] [stdout] 40 | | ) -> Result<FetchOutcome> {
[INFO] [stdout]    | |_________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout]    = note: `#[warn(clippy::too_many_arguments)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (12/7)
[INFO] [stdout]    --> src/fetch.rs:154:1
[INFO] [stdout]     |
[INFO] [stdout] 154 | / fn fetch_one_page(
[INFO] [stdout] 155 | |     client: &reqwest::blocking::Client,
[INFO] [stdout] 156 | |     pages_root: &Path,
[INFO] [stdout] 157 | |     raw_root: &Path,
[INFO] [stdout] ...   |
[INFO] [stdout] 166 | |     chunking: ChunkingConfig,
[INFO] [stdout] 167 | | ) -> Result<PageManifestEntry> {
[INFO] [stdout]     | |______________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/fetch.rs:200:5
[INFO] [stdout]     |
[INFO] [stdout] 200 | /     if response.status() == StatusCode::NOT_MODIFIED {
[INFO] [stdout] 201 | |         if let Some(previous) = previous {
[INFO] [stdout] 202 | |             let content_hash = previous.content_hash.clone().or_else(|| {
[INFO] [stdout] 203 | |                 previous
[INFO] [stdout] ...   |
[INFO] [stdout] 296 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 200 ~     if response.status() == StatusCode::NOT_MODIFIED
[INFO] [stdout] 201 ~         && let Some(previous) = previous {
[INFO] [stdout] 202 |             let content_hash = previous.content_hash.clone().or_else(|| {
[INFO] [stdout] ...
[INFO] [stdout] 294 |             });
[INFO] [stdout] 295 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/fetch.rs:382:9
[INFO] [stdout]     |
[INFO] [stdout] 382 | /         if let Some(browser_cmd) = browser_cmd {
[INFO] [stdout] 383 | |             if should_try_headless(&html, &fallback_markdown) {
[INFO] [stdout] 384 | |                 if let Ok(rendered_html) = render_url(browser_cmd, final_url.as_str(), proxy_url) {
[INFO] [stdout] 385 | |                     write_bytes(&rendered_raw_path, rendered_html.as_bytes())?;
[INFO] [stdout] ...   |
[INFO] [stdout] 391 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 382 ~         if let Some(browser_cmd) = browser_cmd
[INFO] [stdout] 383 ~             && should_try_headless(&html, &fallback_markdown) {
[INFO] [stdout] 384 |                 if let Ok(rendered_html) = render_url(browser_cmd, final_url.as_str(), proxy_url) {
[INFO] [stdout] ...
[INFO] [stdout] 389 |                 }
[INFO] [stdout] 390 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/fetch.rs:383:13
[INFO] [stdout]     |
[INFO] [stdout] 383 | /             if should_try_headless(&html, &fallback_markdown) {
[INFO] [stdout] 384 | |                 if let Ok(rendered_html) = render_url(browser_cmd, final_url.as_str(), proxy_url) {
[INFO] [stdout] 385 | |                     write_bytes(&rendered_raw_path, rendered_html.as_bytes())?;
[INFO] [stdout] 386 | |                     final_markdown = html_to_markdown(rendered_html.as_bytes());
[INFO] [stdout] ...   |
[INFO] [stdout] 390 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 383 ~             if should_try_headless(&html, &fallback_markdown)
[INFO] [stdout] 384 ~                 && let Ok(rendered_html) = render_url(browser_cmd, final_url.as_str(), proxy_url) {
[INFO] [stdout] 385 |                     write_bytes(&rendered_raw_path, rendered_html.as_bytes())?;
[INFO] [stdout] ...
[INFO] [stdout] 388 |                     rendered_raw_output_path = Some(rendered_raw_path.clone());
[INFO] [stdout] 389 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (9/7)
[INFO] [stdout]   --> src/git_sync.rs:40:1
[INFO] [stdout]    |
[INFO] [stdout] 40 | / pub fn sync_git_source(
[INFO] [stdout] 41 | |     snapshot_dir: &Path,
[INFO] [stdout] 42 | |     source: &SourceDefinition,
[INFO] [stdout] 43 | |     source_ref: &str,
[INFO] [stdout] ...  |
[INFO] [stdout] 49 | |     chunking: ChunkingConfig,
[INFO] [stdout] 50 | | ) -> Result<GitSyncOutcome> {
[INFO] [stdout]    | |___________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (11/7)
[INFO] [stdout]    --> src/git_sync.rs:189:1
[INFO] [stdout]     |
[INFO] [stdout] 189 | / fn snapshot_git_pages(
[INFO] [stdout] 190 | |     snapshot_dir: &Path,
[INFO] [stdout] 191 | |     source: &SourceDefinition,
[INFO] [stdout] 192 | |     source_ref: &str,
[INFO] [stdout] ...   |
[INFO] [stdout] 200 | |     chunking: ChunkingConfig,
[INFO] [stdout] 201 | | ) -> Result<(FetchSummary, Vec<PageManifestEntry>)> {
[INFO] [stdout]     | |___________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/headless.rs:44:5
[INFO] [stdout]    |
[INFO] [stdout] 44 |     (script_count >= 5 && thin_markdown) || (has_dynamic_marker && thin_markdown)
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 44 -     (script_count >= 5 && thin_markdown) || (has_dynamic_marker && thin_markdown)
[INFO] [stdout] 44 +     !(!thin_markdown || script_count < 5 && !has_dynamic_marker)
[INFO] [stdout]    |
[INFO] [stdout] 44 -     (script_count >= 5 && thin_markdown) || (has_dynamic_marker && thin_markdown)
[INFO] [stdout] 44 +     (has_dynamic_marker || script_count >= 5) && thin_markdown
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/incremental.rs:124:5
[INFO] [stdout]     |
[INFO] [stdout] 124 | /     if entry.fetch_method == "git_checkout" {
[INFO] [stdout] 125 | |         if let Some(page_path) = entry.page_path.as_deref() {
[INFO] [stdout] 126 | |             if let Some(root) = snapshot_dir {
[INFO] [stdout] 127 | |                 let pages_root = root.join("pages");
[INFO] [stdout] ...   |
[INFO] [stdout] 133 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 124 ~     if entry.fetch_method == "git_checkout"
[INFO] [stdout] 125 ~         && let Some(page_path) = entry.page_path.as_deref() {
[INFO] [stdout] 126 |             if let Some(root) = snapshot_dir {
[INFO] [stdout] ...
[INFO] [stdout] 131 |             }
[INFO] [stdout] 132 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/incremental.rs:125:9
[INFO] [stdout]     |
[INFO] [stdout] 125 | /         if let Some(page_path) = entry.page_path.as_deref() {
[INFO] [stdout] 126 | |             if let Some(root) = snapshot_dir {
[INFO] [stdout] 127 | |                 let pages_root = root.join("pages");
[INFO] [stdout] 128 | |                 if let Ok(relative) = page_path.strip_prefix(&pages_root) {
[INFO] [stdout] ...   |
[INFO] [stdout] 132 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 125 ~         if let Some(page_path) = entry.page_path.as_deref()
[INFO] [stdout] 126 ~             && let Some(root) = snapshot_dir {
[INFO] [stdout] 127 |                 let pages_root = root.join("pages");
[INFO] [stdout] ...
[INFO] [stdout] 130 |                 }
[INFO] [stdout] 131 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/incremental.rs:147:5
[INFO] [stdout]     |
[INFO] [stdout] 147 | /     if let Some(path) = entry.page_path.as_deref() {
[INFO] [stdout] 148 | |         if path.is_file() {
[INFO] [stdout] 149 | |             return Ok(Some(sha256_hex(
[INFO] [stdout] 150 | |                 &fs::read(path).with_context(|| format!("failed to read {}", path.display()))?,
[INFO] [stdout] ...   |
[INFO] [stdout] 153 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 147 ~     if let Some(path) = entry.page_path.as_deref()
[INFO] [stdout] 148 ~         && path.is_file() {
[INFO] [stdout] 149 |             return Ok(Some(sha256_hex(
[INFO] [stdout] 150 |                 &fs::read(path).with_context(|| format!("failed to read {}", path.display()))?,
[INFO] [stdout] 151 |             )));
[INFO] [stdout] 152 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: items after a test module
[INFO] [stdout]    --> src/migrate.rs:95:1
[INFO] [stdout]     |
[INFO] [stdout]  95 |   mod tests {
[INFO] [stdout]     |   ^^^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 209 | / fn diff_summary_from_pages(
[INFO] [stdout] 210 | |     pages: &[crate::models::PageManifestEntry],
[INFO] [stdout] 211 | |     previous_snapshot_label: Option<&str>,
[INFO] [stdout] 212 | | ) -> DiffSummary {
[INFO] [stdout]     | |________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_test_module
[INFO] [stdout]     = note: `#[warn(clippy::items_after_test_module)]` on by default
[INFO] [stdout]     = help: move the items to before the test module was defined
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (8/7)
[INFO] [stdout]    --> src/omnimem.rs:93:1
[INFO] [stdout]     |
[INFO] [stdout]  93 | / pub fn import_snapshot(
[INFO] [stdout]  94 | |     paths: &AppPaths,
[INFO] [stdout]  95 | |     source_name: &str,
[INFO] [stdout]  96 | |     reference: Option<String>,
[INFO] [stdout] ...   |
[INFO] [stdout] 101 | |     include_low_signal: bool,
[INFO] [stdout] 102 | | ) -> Result<ImportResult> {
[INFO] [stdout]     | |_________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (12/7)
[INFO] [stdout]   --> src/sync.rs:44:1
[INFO] [stdout]    |
[INFO] [stdout] 44 | / pub fn sync_source(
[INFO] [stdout] 45 | |     config: &AppConfig,
[INFO] [stdout] 46 | |     paths: &AppPaths,
[INFO] [stdout] 47 | |     name: &str,
[INFO] [stdout] ...  |
[INFO] [stdout] 56 | |     chunking: ChunkingConfig,
[INFO] [stdout] 57 | | ) -> Result<SyncResult> {
[INFO] [stdout]    | |_______________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (17/7)
[INFO] [stdout]    --> src/sync.rs:123:1
[INFO] [stdout]     |
[INFO] [stdout] 123 | / fn sync_http_mode(
[INFO] [stdout] 124 | |     source: &SourceDefinition,
[INFO] [stdout] 125 | |     raw_label: &str,
[INFO] [stdout] 126 | |     snapshot_label: &str,
[INFO] [stdout] ...   |
[INFO] [stdout] 142 | |     chunking: ChunkingConfig,
[INFO] [stdout] 143 | | ) -> Result<SyncResult> {
[INFO] [stdout]     | |_______________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
[INFO] [stdout]    --> src/sync.rs:127:19
[INFO] [stdout]     |
[INFO] [stdout] 127 |     snapshot_dir: &PathBuf,
[INFO] [stdout]     |                   ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 127 ~     snapshot_dir: &Path,
[INFO] [stdout] 128 |     manifest_path: &PathBuf,
[INFO] [stdout] ...
[INFO] [stdout] 207 |             snapshot_label: snapshot_label.to_string(),
[INFO] [stdout] 208 ~             snapshot_dir: snapshot_dir.to_path_buf(),
[INFO] [stdout] 209 |             status: if fetched_pages > 0 {
[INFO] [stdout] ...
[INFO] [stdout] 261 |         snapshot_label: snapshot_label.to_string(),
[INFO] [stdout] 262 ~         snapshot_dir: snapshot_dir.to_path_buf(),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (16/7)
[INFO] [stdout]    --> src/sync.rs:279:1
[INFO] [stdout]     |
[INFO] [stdout] 279 | / fn sync_git_mode(
[INFO] [stdout] 280 | |     source: &SourceDefinition,
[INFO] [stdout] 281 | |     raw_label: &str,
[INFO] [stdout] 282 | |     snapshot_label: &str,
[INFO] [stdout] ...   |
[INFO] [stdout] 297 | |     chunking: ChunkingConfig,
[INFO] [stdout] 298 | | ) -> Result<SyncResult> {
[INFO] [stdout]     | |_______________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
[INFO] [stdout]    --> src/sync.rs:283:19
[INFO] [stdout]     |
[INFO] [stdout] 283 |     snapshot_dir: &PathBuf,
[INFO] [stdout]     |                   ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 283 ~     snapshot_dir: &Path,
[INFO] [stdout] 284 |     manifest_path: &PathBuf,
[INFO] [stdout] ...
[INFO] [stdout] 342 |             snapshot_label: snapshot_label.to_string(),
[INFO] [stdout] 343 ~             snapshot_dir: snapshot_dir.to_path_buf(),
[INFO] [stdout] 344 |             status: if outcome.fetch.stored_pages > 0 {
[INFO] [stdout] ...
[INFO] [stdout] 398 |         snapshot_label: snapshot_label.to_string(),
[INFO] [stdout] 399 ~         snapshot_dir: snapshot_dir.to_path_buf(),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.as_ref().map(PathBuf::as_path)` on an `Option` value
[INFO] [stdout]   --> src/main.rs:53:25
[INFO] [stdout]    |
[INFO] [stdout] 53 |     let home_override = cli.home.as_ref().map(PathBuf::as_path);
[INFO] [stdout]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `cli.home.as_deref()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref
[INFO] [stdout]    = note: `#[warn(clippy::option_as_ref_deref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (8/7)
[INFO] [stdout]    --> src/omnimem.rs:93:1
[INFO] [stdout]     |
[INFO] [stdout]  93 | / pub fn import_snapshot(
[INFO] [stdout]  94 | |     paths: &AppPaths,
[INFO] [stdout]  95 | |     source_name: &str,
[INFO] [stdout]  96 | |     reference: Option<String>,
[INFO] [stdout] ...   |
[INFO] [stdout] 101 | |     include_low_signal: bool,
[INFO] [stdout] 102 | | ) -> Result<ImportResult> {
[INFO] [stdout]     | |_________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
[INFO] [stdout]    --> src/sources.rs:187:25
[INFO] [stdout]     |
[INFO] [stdout] 187 |     fn make_paths(root: &PathBuf) -> AppPaths {
[INFO] [stdout]     |                         ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 187 ~     fn make_paths(root: &Path) -> AppPaths {
[INFO] [stdout] 188 |         AppPaths {
[INFO] [stdout] 189 ~             home: root.to_path_buf(),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (12/7)
[INFO] [stdout]   --> src/sync.rs:44:1
[INFO] [stdout]    |
[INFO] [stdout] 44 | / pub fn sync_source(
[INFO] [stdout] 45 | |     config: &AppConfig,
[INFO] [stdout] 46 | |     paths: &AppPaths,
[INFO] [stdout] 47 | |     name: &str,
[INFO] [stdout] ...  |
[INFO] [stdout] 56 | |     chunking: ChunkingConfig,
[INFO] [stdout] 57 | | ) -> Result<SyncResult> {
[INFO] [stdout]    | |_______________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (17/7)
[INFO] [stdout]    --> src/sync.rs:123:1
[INFO] [stdout]     |
[INFO] [stdout] 123 | / fn sync_http_mode(
[INFO] [stdout] 124 | |     source: &SourceDefinition,
[INFO] [stdout] 125 | |     raw_label: &str,
[INFO] [stdout] 126 | |     snapshot_label: &str,
[INFO] [stdout] ...   |
[INFO] [stdout] 142 | |     chunking: ChunkingConfig,
[INFO] [stdout] 143 | | ) -> Result<SyncResult> {
[INFO] [stdout]     | |_______________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
[INFO] [stdout]    --> src/sync.rs:127:19
[INFO] [stdout]     |
[INFO] [stdout] 127 |     snapshot_dir: &PathBuf,
[INFO] [stdout]     |                   ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 127 ~     snapshot_dir: &Path,
[INFO] [stdout] 128 |     manifest_path: &PathBuf,
[INFO] [stdout] ...
[INFO] [stdout] 207 |             snapshot_label: snapshot_label.to_string(),
[INFO] [stdout] 208 ~             snapshot_dir: snapshot_dir.to_path_buf(),
[INFO] [stdout] 209 |             status: if fetched_pages > 0 {
[INFO] [stdout] ...
[INFO] [stdout] 261 |         snapshot_label: snapshot_label.to_string(),
[INFO] [stdout] 262 ~         snapshot_dir: snapshot_dir.to_path_buf(),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (16/7)
[INFO] [stdout]    --> src/sync.rs:279:1
[INFO] [stdout]     |
[INFO] [stdout] 279 | / fn sync_git_mode(
[INFO] [stdout] 280 | |     source: &SourceDefinition,
[INFO] [stdout] 281 | |     raw_label: &str,
[INFO] [stdout] 282 | |     snapshot_label: &str,
[INFO] [stdout] ...   |
[INFO] [stdout] 297 | |     chunking: ChunkingConfig,
[INFO] [stdout] 298 | | ) -> Result<SyncResult> {
[INFO] [stdout]     | |_______________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
[INFO] [stdout]    --> src/sync.rs:283:19
[INFO] [stdout]     |
[INFO] [stdout] 283 |     snapshot_dir: &PathBuf,
[INFO] [stdout]     |                   ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 283 ~     snapshot_dir: &Path,
[INFO] [stdout] 284 |     manifest_path: &PathBuf,
[INFO] [stdout] ...
[INFO] [stdout] 342 |             snapshot_label: snapshot_label.to_string(),
[INFO] [stdout] 343 ~             snapshot_dir: snapshot_dir.to_path_buf(),
[INFO] [stdout] 344 |             status: if outcome.fetch.stored_pages > 0 {
[INFO] [stdout] ...
[INFO] [stdout] 398 |         snapshot_label: snapshot_label.to_string(),
[INFO] [stdout] 399 ~         snapshot_dir: snapshot_dir.to_path_buf(),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.as_ref().map(PathBuf::as_path)` on an `Option` value
[INFO] [stdout]   --> src/main.rs:53:25
[INFO] [stdout]    |
[INFO] [stdout] 53 |     let home_override = cli.home.as_ref().map(PathBuf::as_path);
[INFO] [stdout]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `cli.home.as_deref()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref
[INFO] [stdout]    = note: `#[warn(clippy::option_as_ref_deref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 29.43s
[INFO] running `Command { std: "docker" "inspect" "bc01255bced275c9741b32ec02b2266a151577397c93b215dc89e1ff5d238a39", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "bc01255bced275c9741b32ec02b2266a151577397c93b215dc89e1ff5d238a39", kill_on_drop: false }`
[INFO] [stdout] bc01255bced275c9741b32ec02b2266a151577397c93b215dc89e1ff5d238a39