[INFO] cloning repository https://github.com/mangeption/rws [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/mangeption/rws" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmangeption%2Frws", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmangeption%2Frws'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cfeb3a546f31cb5e64276148a83513c86dfe2abe [INFO] linting mangeption/rws against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmangeption%2Frws" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/mangeption/rws [INFO] finished tweaking git repo https://github.com/mangeption/rws [INFO] tweaked toml for git repo https://github.com/mangeption/rws written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/mangeption/rws on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/mangeption/rws already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4b4c7174decd2d1b1439aa90a07803330bdc2d034003477b00676aba124e862b [INFO] running `Command { std: "docker" "start" "-a" "4b4c7174decd2d1b1439aa90a07803330bdc2d034003477b00676aba124e862b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4b4c7174decd2d1b1439aa90a07803330bdc2d034003477b00676aba124e862b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4b4c7174decd2d1b1439aa90a07803330bdc2d034003477b00676aba124e862b", kill_on_drop: false }` [INFO] [stdout] 4b4c7174decd2d1b1439aa90a07803330bdc2d034003477b00676aba124e862b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 56b3f9594ddeae7260dfc4d83e3251923d89a3555d6213fbfe48174cc72038e4 [INFO] running `Command { std: "docker" "start" "-a" "56b3f9594ddeae7260dfc4d83e3251923d89a3555d6213fbfe48174cc72038e4", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.93 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling thiserror v2.0.11 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking simdutf8 v0.1.5 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.98 [INFO] [stderr] Compiling thiserror-impl v2.0.11 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking rws v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `TcpStream` [INFO] [stdout] --> src/main.rs:2:31 [INFO] [stdout] | [INFO] [stdout] 2 | use tokio::net::{TcpListener, TcpStream}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::Binary` [INFO] [stdout] --> src/reader.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt::Binary; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/reader.rs:3:20 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::frame::{self, Frame, FrameError, Opcode}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/reader.rs:219:13 [INFO] [stdout] | [INFO] [stdout] 219 | fin: fin, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `fin` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/reader.rs:220:13 [INFO] [stdout] | [INFO] [stdout] 220 | opcode: opcode, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TcpStream` [INFO] [stdout] --> src/main.rs:2:31 [INFO] [stdout] | [INFO] [stdout] 2 | use tokio::net::{TcpListener, TcpStream}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::Binary` [INFO] [stdout] --> src/reader.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt::Binary; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/reader.rs:3:20 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::frame::{self, Frame, FrameError, Opcode}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/reader.rs:219:13 [INFO] [stdout] | [INFO] [stdout] 219 | fin: fin, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `fin` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/reader.rs:220:13 [INFO] [stdout] | [INFO] [stdout] 220 | opcode: opcode, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/handler.rs:32:21 [INFO] [stdout] | [INFO] [stdout] 32 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/handler.rs:39:32 [INFO] [stdout] | [INFO] [stdout] 39 | if let Err(e) = Writer::write_frame(&frame, &mut write_half).await { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/handler.rs:51:32 [INFO] [stdout] | [INFO] [stdout] 51 | if let Err(e) = Writer::write_frame(&pong_frame, &mut write_half).await { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/handler.rs:57:32 [INFO] [stdout] | [INFO] [stdout] 57 | if let Err(e) = Writer::write_frame(&frame, &mut write_half).await { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/handler.rs:62:32 [INFO] [stdout] | [INFO] [stdout] 62 | if let Err(e) = Writer::write_frame(&frame, &mut write_half).await { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `InvalidPayloadLength` is never constructed [INFO] [stdout] --> src/frame.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 45 | pub enum FrameError { [INFO] [stdout] | ---------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 57 | InvalidPayloadLength(u64), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FrameError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `is_*` usually take `self` by mutable reference or `self` by reference or no `self` [INFO] [stdout] --> src/frame.rs:91:23 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn is_allowed(self) -> bool { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/frame.rs:170:38 [INFO] [stdout] | [INFO] [stdout] 170 | if data.len() > 2 && !simdutf8::basic::from_utf8(&data[2..]).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `simdutf8::basic::from_utf8(&data[2..]).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/frame.rs:184:9 [INFO] [stdout] | [INFO] [stdout] 184 | return Self { fin: true, opcode: Opcode::Close, len: payload.len(), data: payload } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 184 - return Self { fin: true, opcode: Opcode::Close, len: payload.len(), data: payload } [INFO] [stdout] 184 + Self { fin: true, opcode: Opcode::Close, len: payload.len(), data: payload } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handshake.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | return Ok(headers); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return Ok(headers); [INFO] [stdout] 59 + Ok(headers) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/reader.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | / return Fragments { [INFO] [stdout] 33 | | fragments: None, [INFO] [stdout] 34 | | op_code: Opcode::Close, [INFO] [stdout] 35 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 ~ Fragments { [INFO] [stdout] 33 + fragments: None, [INFO] [stdout] 34 + op_code: Opcode::Close, [INFO] [stdout] 35 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/reader.rs:45:56 [INFO] [stdout] | [INFO] [stdout] 45 | if frame.opcode == Opcode::Text && !simdutf8::basic::from_utf8(&frame.data).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `simdutf8::basic::from_utf8(&frame.data).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tokio::io::AsyncReadExt` [INFO] [stdout] --> src/reader.rs:231:9 [INFO] [stdout] | [INFO] [stdout] 231 | use tokio::io::AsyncReadExt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/handler.rs:32:21 [INFO] [stdout] | [INFO] [stdout] 32 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/handler.rs:39:32 [INFO] [stdout] | [INFO] [stdout] 39 | if let Err(e) = Writer::write_frame(&frame, &mut write_half).await { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/handler.rs:51:32 [INFO] [stdout] | [INFO] [stdout] 51 | if let Err(e) = Writer::write_frame(&pong_frame, &mut write_half).await { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/handler.rs:57:32 [INFO] [stdout] | [INFO] [stdout] 57 | if let Err(e) = Writer::write_frame(&frame, &mut write_half).await { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/handler.rs:62:32 [INFO] [stdout] | [INFO] [stdout] 62 | if let Err(e) = Writer::write_frame(&frame, &mut write_half).await { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `InvalidPayloadLength` is never constructed [INFO] [stdout] --> src/frame.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 45 | pub enum FrameError { [INFO] [stdout] | ---------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 57 | InvalidPayloadLength(u64), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FrameError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `is_*` usually take `self` by mutable reference or `self` by reference or no `self` [INFO] [stdout] --> src/frame.rs:91:23 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn is_allowed(self) -> bool { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/frame.rs:170:38 [INFO] [stdout] | [INFO] [stdout] 170 | if data.len() > 2 && !simdutf8::basic::from_utf8(&data[2..]).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `simdutf8::basic::from_utf8(&data[2..]).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/frame.rs:184:9 [INFO] [stdout] | [INFO] [stdout] 184 | return Self { fin: true, opcode: Opcode::Close, len: payload.len(), data: payload } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 184 - return Self { fin: true, opcode: Opcode::Close, len: payload.len(), data: payload } [INFO] [stdout] 184 + Self { fin: true, opcode: Opcode::Close, len: payload.len(), data: payload } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handshake.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | return Ok(headers); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return Ok(headers); [INFO] [stdout] 59 + Ok(headers) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-binding `let` on a future [INFO] [stdout] --> src/handshake.rs:151:13 [INFO] [stdout] | [INFO] [stdout] 151 | let _ = self.stream.shutdown(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider awaiting the future or dropping explicitly with `std::mem::drop` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future [INFO] [stdout] = note: `#[warn(clippy::let_underscore_future)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/reader.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | / return Fragments { [INFO] [stdout] 33 | | fragments: None, [INFO] [stdout] 34 | | op_code: Opcode::Close, [INFO] [stdout] 35 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 ~ Fragments { [INFO] [stdout] 33 + fragments: None, [INFO] [stdout] 34 + op_code: Opcode::Close, [INFO] [stdout] 35 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/reader.rs:45:56 [INFO] [stdout] | [INFO] [stdout] 45 | if frame.opcode == Opcode::Text && !simdutf8::basic::from_utf8(&frame.data).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `simdutf8::basic::from_utf8(&frame.data).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.12s [INFO] running `Command { std: "docker" "inspect" "56b3f9594ddeae7260dfc4d83e3251923d89a3555d6213fbfe48174cc72038e4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "56b3f9594ddeae7260dfc4d83e3251923d89a3555d6213fbfe48174cc72038e4", kill_on_drop: false }` [INFO] [stdout] 56b3f9594ddeae7260dfc4d83e3251923d89a3555d6213fbfe48174cc72038e4