[INFO] cloning repository https://github.com/malteharms/file_converter [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/malteharms/file_converter" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmalteharms%2Ffile_converter", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmalteharms%2Ffile_converter'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0261f7a28df2360877bb04052d790b8aed921cac [INFO] linting malteharms/file_converter against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmalteharms%2Ffile_converter" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/malteharms/file_converter [INFO] finished tweaking git repo https://github.com/malteharms/file_converter [INFO] tweaked toml for git repo https://github.com/malteharms/file_converter written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/malteharms/file_converter on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/malteharms/file_converter already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 692c6949065e1497e4626c7a10e3a6aab37b7fe2fc824447739f94378a320f06 [INFO] running `Command { std: "docker" "start" "-a" "692c6949065e1497e4626c7a10e3a6aab37b7fe2fc824447739f94378a320f06", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "692c6949065e1497e4626c7a10e3a6aab37b7fe2fc824447739f94378a320f06", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "692c6949065e1497e4626c7a10e3a6aab37b7fe2fc824447739f94378a320f06", kill_on_drop: false }` [INFO] [stdout] 692c6949065e1497e4626c7a10e3a6aab37b7fe2fc824447739f94378a320f06 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 354b8462804c25d2d7638bb3cc84293b0743bc458ded98330184f1a0ae11c8ca [INFO] running `Command { std: "docker" "start" "-a" "354b8462804c25d2d7638bb3cc84293b0743bc458ded98330184f1a0ae11c8ca", kill_on_drop: false }` [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Checking anstyle-query v1.1.2 [INFO] [stderr] Checking anstyle v1.0.10 [INFO] [stderr] Checking anstyle-parse v0.2.6 [INFO] [stderr] Checking colorchoice v1.0.3 [INFO] [stderr] Checking iana-time-zone v0.1.61 [INFO] [stderr] Checking chrono v0.4.39 [INFO] [stderr] Checking anstream v0.6.18 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Checking env_logger v0.11.6 [INFO] [stderr] Checking file_converter v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unknown lint: `clippy::duplicate_code` [INFO] [stdout] --> src/models/settings.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | #[allow(clippy::duplicate_code)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: did you mean: `clippy::duplicate_mod` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unknown_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unknown lint: `clippy::duplicate_code` [INFO] [stdout] --> src/models/settings.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | #[allow(clippy::duplicate_code)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: did you mean: `clippy::duplicate_mod` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unknown_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/models/settings.rs:27:56 [INFO] [stdout] | [INFO] [stdout] 27 | self.log_level = LevelFilter::from_str(&*value).unwrap_or_else(|_| { [INFO] [stdout] | ^^^^^^^ help: try: `&value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/dispatcher.rs:8:17 [INFO] [stdout] | [INFO] [stdout] 8 | input_file: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 8 ~ input_file: &Path, [INFO] [stdout] 9 | output_file: &PathBuf [INFO] [stdout] ... [INFO] [stdout] 24 | "txt" => { [INFO] [stdout] 25 ~ TextFileConverter::new(input_file.to_path_buf(), output_file.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/dispatcher.rs:9:18 [INFO] [stdout] | [INFO] [stdout] 9 | output_file: &PathBuf [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 9 ~ output_file: &Path [INFO] [stdout] 10 | ) -> Result { [INFO] [stdout] ... [INFO] [stdout] 24 | "txt" => { [INFO] [stdout] 25 ~ TextFileConverter::new(input_file.clone(), output_file.to_path_buf()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 53 | if !args.input.extension().is_some() || !args.output.extension().is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.input.extension().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:53:45 [INFO] [stdout] | [INFO] [stdout] 53 | if !args.input.extension().is_some() || !args.output.extension().is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.output.extension().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/models/settings.rs:27:56 [INFO] [stdout] | [INFO] [stdout] 27 | self.log_level = LevelFilter::from_str(&*value).unwrap_or_else(|_| { [INFO] [stdout] | ^^^^^^^ help: try: `&value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/dispatcher.rs:8:17 [INFO] [stdout] | [INFO] [stdout] 8 | input_file: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 8 ~ input_file: &Path, [INFO] [stdout] 9 | output_file: &PathBuf [INFO] [stdout] ... [INFO] [stdout] 24 | "txt" => { [INFO] [stdout] 25 ~ TextFileConverter::new(input_file.to_path_buf(), output_file.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/dispatcher.rs:9:18 [INFO] [stdout] | [INFO] [stdout] 9 | output_file: &PathBuf [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 9 ~ output_file: &Path [INFO] [stdout] 10 | ) -> Result { [INFO] [stdout] ... [INFO] [stdout] 24 | "txt" => { [INFO] [stdout] 25 ~ TextFileConverter::new(input_file.clone(), output_file.to_path_buf()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 53 | if !args.input.extension().is_some() || !args.output.extension().is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.input.extension().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:53:45 [INFO] [stdout] | [INFO] [stdout] 53 | if !args.input.extension().is_some() || !args.output.extension().is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.output.extension().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.66s [INFO] running `Command { std: "docker" "inspect" "354b8462804c25d2d7638bb3cc84293b0743bc458ded98330184f1a0ae11c8ca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "354b8462804c25d2d7638bb3cc84293b0743bc458ded98330184f1a0ae11c8ca", kill_on_drop: false }` [INFO] [stdout] 354b8462804c25d2d7638bb3cc84293b0743bc458ded98330184f1a0ae11c8ca