[INFO] cloning repository https://github.com/major75/rusty-gossip [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/major75/rusty-gossip" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmajor75%2Frusty-gossip", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmajor75%2Frusty-gossip'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 35d487ca24a6e213c6f57e7f8df9f556d81c9dc4 [INFO] linting major75/rusty-gossip against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmajor75%2Frusty-gossip" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/major75/rusty-gossip [INFO] finished tweaking git repo https://github.com/major75/rusty-gossip [INFO] tweaked toml for git repo https://github.com/major75/rusty-gossip written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/major75/rusty-gossip on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/major75/rusty-gossip already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded colored v1.9.4 [INFO] [stderr] Downloaded settimeout v0.1.2 [INFO] [stderr] Downloaded rustix v0.38.15 [INFO] [stderr] Downloaded linux-raw-sys v0.4.8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a23d5d882af2ff2ea725be3a9dcbb7716c9c126d156006c331bc13db608298ae [INFO] running `Command { std: "docker" "start" "-a" "a23d5d882af2ff2ea725be3a9dcbb7716c9c126d156006c331bc13db608298ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a23d5d882af2ff2ea725be3a9dcbb7716c9c126d156006c331bc13db608298ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a23d5d882af2ff2ea725be3a9dcbb7716c9c126d156006c331bc13db608298ae", kill_on_drop: false }` [INFO] [stdout] a23d5d882af2ff2ea725be3a9dcbb7716c9c126d156006c331bc13db608298ae [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1c70958bca08256de3e5ff3aeb6df7e0442a0d5b67bc8f1c13f009e60b52b95e [INFO] running `Command { std: "docker" "start" "-a" "1c70958bca08256de3e5ff3aeb6df7e0442a0d5b67bc8f1c13f009e60b52b95e", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Compiling rustix v0.38.15 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Checking linux-raw-sys v0.4.8 [INFO] [stderr] Compiling syn v2.0.37 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking clap_lex v0.5.1 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking settimeout v0.1.2 [INFO] [stderr] Checking dotenv v0.15.0 [INFO] [stderr] Checking anstream v0.6.4 [INFO] [stderr] Checking clap_builder v4.4.6 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking colored v1.9.4 [INFO] [stderr] Checking fern v0.6.2 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling pin-project-internal v1.1.3 [INFO] [stderr] Compiling enum-ordinalize v3.1.15 [INFO] [stderr] Compiling clap_derive v4.4.2 [INFO] [stderr] Checking futures-util v0.3.28 [INFO] [stderr] Compiling educe v0.4.23 [INFO] [stderr] Checking tokio v1.32.0 [INFO] [stderr] Checking pin-project v1.1.3 [INFO] [stderr] Checking clap v4.4.6 [INFO] [stderr] Checking serde v1.0.188 [INFO] [stderr] Checking futures-executor v0.3.28 [INFO] [stderr] Checking futures v0.3.28 [INFO] [stderr] Checking tokio-util v0.7.9 [INFO] [stderr] Checking serde_json v1.0.107 [INFO] [stderr] Checking tokio-serde v0.8.0 [INFO] [stderr] Checking rusty-gossip v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/common.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return since_the_epoch.as_secs(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return since_the_epoch.as_secs(); [INFO] [stdout] 25 + since_the_epoch.as_secs() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/heartbeat.rs:26:25 [INFO] [stdout] | [INFO] [stdout] 26 | if connected && (((ticks * BEAT_DURATION_MSEC) % period) == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(ticks * BEAT_DURATION_MSEC).is_multiple_of(period)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/heartbeat.rs:29:19 [INFO] [stdout] | [INFO] [stdout] 29 | } else if ((ticks * BEAT_DURATION_MSEC) % HEART_BEAT_DURATION_MSEC) == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(ticks * BEAT_DURATION_MSEC).is_multiple_of(HEART_BEAT_DURATION_MSEC)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/heartbeat.rs:77:8 [INFO] [stdout] | [INFO] [stdout] 77 | if !(my_network_state.peers.len() > 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(my_network_state.peers.len() <= 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/heartbeat.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 94 | return item.id == my_network_state.sender; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 94 - return item.id == my_network_state.sender; [INFO] [stdout] 94 + item.id == my_network_state.sender [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/heartbeat.rs:99:16 [INFO] [stdout] | [INFO] [stdout] 99 | if let Some(_) = payload { [INFO] [stdout] | -------^^^^^^^---------- help: try: `if payload.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/heartbeat.rs:182:5 [INFO] [stdout] | [INFO] [stdout] 182 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 182 - return None; [INFO] [stdout] 182 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/heartbeat.rs:152:41 [INFO] [stdout] | [INFO] [stdout] 152 | let json = serde_json::to_value(&state).expect("To JSON serialization error"); [INFO] [stdout] | ^^^^^^ help: change this to: `state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/heartbeat.rs:205:17 [INFO] [stdout] | [INFO] [stdout] 205 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 205 - return true; [INFO] [stdout] 205 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sync.rs:13:13 [INFO] [stdout] | [INFO] [stdout] 13 | return fi.id == ti.id; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return fi.id == ti.id; [INFO] [stdout] 13 + fi.id == ti.id [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sync.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 106 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 106 - return true; [INFO] [stdout] 106 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sync.rs:111:13 [INFO] [stdout] | [INFO] [stdout] 111 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 111 - return false; [INFO] [stdout] 111 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/sync.rs:100:16 [INFO] [stdout] | [INFO] [stdout] 100 | if updated == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `!updated` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/main.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 52 | let port = env::var("port").expect("Listening port must be set"); [INFO] [stdout] | ----------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 53 | port [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 52 ~ [INFO] [stdout] 53 ~ env::var("port").expect("Listening port must be set") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:97:8 [INFO] [stdout] | [INFO] [stdout] 97 | if seed_node.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!seed_node.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `ColoredLevelConfig` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:137:24 [INFO] [stdout] | [INFO] [stdout] 137 | let colors_level = palette.clone().info(Color::Green); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `palette` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/common.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return since_the_epoch.as_secs(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return since_the_epoch.as_secs(); [INFO] [stdout] 25 + since_the_epoch.as_secs() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/heartbeat.rs:26:25 [INFO] [stdout] | [INFO] [stdout] 26 | if connected && (((ticks * BEAT_DURATION_MSEC) % period) == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(ticks * BEAT_DURATION_MSEC).is_multiple_of(period)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/heartbeat.rs:29:19 [INFO] [stdout] | [INFO] [stdout] 29 | } else if ((ticks * BEAT_DURATION_MSEC) % HEART_BEAT_DURATION_MSEC) == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(ticks * BEAT_DURATION_MSEC).is_multiple_of(HEART_BEAT_DURATION_MSEC)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/heartbeat.rs:77:8 [INFO] [stdout] | [INFO] [stdout] 77 | if !(my_network_state.peers.len() > 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(my_network_state.peers.len() <= 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/heartbeat.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 94 | return item.id == my_network_state.sender; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 94 - return item.id == my_network_state.sender; [INFO] [stdout] 94 + item.id == my_network_state.sender [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/heartbeat.rs:99:16 [INFO] [stdout] | [INFO] [stdout] 99 | if let Some(_) = payload { [INFO] [stdout] | -------^^^^^^^---------- help: try: `if payload.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/heartbeat.rs:182:5 [INFO] [stdout] | [INFO] [stdout] 182 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 182 - return None; [INFO] [stdout] 182 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/heartbeat.rs:152:41 [INFO] [stdout] | [INFO] [stdout] 152 | let json = serde_json::to_value(&state).expect("To JSON serialization error"); [INFO] [stdout] | ^^^^^^ help: change this to: `state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/heartbeat.rs:205:17 [INFO] [stdout] | [INFO] [stdout] 205 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 205 - return true; [INFO] [stdout] 205 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sync.rs:13:13 [INFO] [stdout] | [INFO] [stdout] 13 | return fi.id == ti.id; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return fi.id == ti.id; [INFO] [stdout] 13 + fi.id == ti.id [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sync.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 106 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 106 - return true; [INFO] [stdout] 106 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sync.rs:111:13 [INFO] [stdout] | [INFO] [stdout] 111 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 111 - return false; [INFO] [stdout] 111 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/sync.rs:100:16 [INFO] [stdout] | [INFO] [stdout] 100 | if updated == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `!updated` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/main.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 52 | let port = env::var("port").expect("Listening port must be set"); [INFO] [stdout] | ----------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 53 | port [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 52 ~ [INFO] [stdout] 53 ~ env::var("port").expect("Listening port must be set") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:97:8 [INFO] [stdout] | [INFO] [stdout] 97 | if seed_node.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!seed_node.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `ColoredLevelConfig` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:137:24 [INFO] [stdout] | [INFO] [stdout] 137 | let colors_level = palette.clone().info(Color::Green); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `palette` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 15.91s [INFO] running `Command { std: "docker" "inspect" "1c70958bca08256de3e5ff3aeb6df7e0442a0d5b67bc8f1c13f009e60b52b95e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1c70958bca08256de3e5ff3aeb6df7e0442a0d5b67bc8f1c13f009e60b52b95e", kill_on_drop: false }` [INFO] [stdout] 1c70958bca08256de3e5ff3aeb6df7e0442a0d5b67bc8f1c13f009e60b52b95e