[INFO] cloning repository https://github.com/madman321000/PNGMe [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/madman321000/PNGMe" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmadman321000%2FPNGMe", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmadman321000%2FPNGMe'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 674b313fa508f41b1be7f3a197c93912c283775e [INFO] linting madman321000/PNGMe against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmadman321000%2FPNGMe" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/madman321000/PNGMe [INFO] finished tweaking git repo https://github.com/madman321000/PNGMe [INFO] tweaked toml for git repo https://github.com/madman321000/PNGMe written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/madman321000/PNGMe on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/madman321000/PNGMe already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8b95b5ac76345053b8c6245864472846b083fd006634421283c8df655bd7701e [INFO] running `Command { std: "docker" "start" "-a" "8b95b5ac76345053b8c6245864472846b083fd006634421283c8df655bd7701e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8b95b5ac76345053b8c6245864472846b083fd006634421283c8df655bd7701e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8b95b5ac76345053b8c6245864472846b083fd006634421283c8df655bd7701e", kill_on_drop: false }` [INFO] [stdout] 8b95b5ac76345053b8c6245864472846b083fd006634421283c8df655bd7701e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1a56801bd2563fd21fe490f84ed047f8055f8889989f7a2e8c3e644b9143f2ab [INFO] running `Command { std: "docker" "start" "-a" "1a56801bd2563fd21fe490f84ed047f8055f8889989f7a2e8c3e644b9143f2ab", kill_on_drop: false }` [INFO] [stderr] Checking pngme v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `ChunkType` is never constructed [INFO] [stdout] --> src/chunk_type.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct ChunkType { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/chunk_type.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 8 | impl ChunkType { [INFO] [stdout] | -------------- associated items in this implementation [INFO] [stdout] 9 | fn bytes(&self) -> [u8; 4] { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 12 | fn is_valid(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 15 | fn is_critical(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 18 | fn is_public(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 21 | fn is_reserved_bit_valid(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 24 | fn is_safe_to_copy(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 27 | fn byte_in_range(byte: u8) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `ChunkTypeReadingError` is never used [INFO] [stdout] --> src/chunk_type.rs:33:10 [INFO] [stdout] | [INFO] [stdout] 33 | pub enum ChunkTypeReadingError { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/chunk_type.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | !((self.bytes[3] & (1 << 5)) == 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((self.bytes[3] & (1 << 5)) != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/chunk_type.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | (65 <= byte && byte <= 90) || (97 <= byte && byte <= 122) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(65..=90).contains(&byte)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/chunk_type.rs:28:39 [INFO] [stdout] | [INFO] [stdout] 28 | (65 <= byte && byte <= 90) || (97 <= byte && byte <= 122) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(97..=122).contains(&byte)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/chunk_type.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | !((self.bytes[3] & (1 << 5)) == 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((self.bytes[3] & (1 << 5)) != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/chunk_type.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | (65 <= byte && byte <= 90) || (97 <= byte && byte <= 122) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(65..=90).contains(&byte)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/chunk_type.rs:28:39 [INFO] [stdout] | [INFO] [stdout] 28 | (65 <= byte && byte <= 90) || (97 <= byte && byte <= 122) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(97..=122).contains(&byte)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.15s [INFO] running `Command { std: "docker" "inspect" "1a56801bd2563fd21fe490f84ed047f8055f8889989f7a2e8c3e644b9143f2ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1a56801bd2563fd21fe490f84ed047f8055f8889989f7a2e8c3e644b9143f2ab", kill_on_drop: false }` [INFO] [stdout] 1a56801bd2563fd21fe490f84ed047f8055f8889989f7a2e8c3e644b9143f2ab