[INFO] cloning repository https://github.com/maciej-dudziak/exchange_rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/maciej-dudziak/exchange_rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmaciej-dudziak%2Fexchange_rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmaciej-dudziak%2Fexchange_rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 265bd3f9b6df73300244d5cc0570acc3a80c8881 [INFO] linting maciej-dudziak/exchange_rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmaciej-dudziak%2Fexchange_rust" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/maciej-dudziak/exchange_rust [INFO] finished tweaking git repo https://github.com/maciej-dudziak/exchange_rust [INFO] tweaked toml for git repo https://github.com/maciej-dudziak/exchange_rust written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/maciej-dudziak/exchange_rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/maciej-dudziak/exchange_rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1c6b73a85956f813dd1ec7dee4644930145b45c48f6b50f44ce78181f9b04690 [INFO] running `Command { std: "docker" "start" "-a" "1c6b73a85956f813dd1ec7dee4644930145b45c48f6b50f44ce78181f9b04690", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1c6b73a85956f813dd1ec7dee4644930145b45c48f6b50f44ce78181f9b04690", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1c6b73a85956f813dd1ec7dee4644930145b45c48f6b50f44ce78181f9b04690", kill_on_drop: false }` [INFO] [stdout] 1c6b73a85956f813dd1ec7dee4644930145b45c48f6b50f44ce78181f9b04690 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a9f671a62ccab59855ac4f65bfd3027c979cbe886d7f9b89e814ea3275588b59 [INFO] running `Command { std: "docker" "start" "-a" "a9f671a62ccab59855ac4f65bfd3027c979cbe886d7f9b89e814ea3275588b59", kill_on_drop: false }` [INFO] [stderr] Checking exchange v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `resting_bid` and `resting_ask` are never read [INFO] [stdout] --> src/order_book/mod.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct OrderBook { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 7 | resting_bid: BinaryHeap, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 8 | resting_ask: BinaryHeap> [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `OrderBook` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `add_order`, `match_asks`, and `match_bids` are never used [INFO] [stdout] --> src/order_book/mod.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl OrderBook { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 19 | pub fn add_order(&mut self, order: Order, is_buy: bool) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 37 | fn match_asks(&mut self, bid: &Order) -> i32 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 60 | fn match_bids(&mut self, ask: &Order) -> i32 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/order_book/order.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 9 | impl Order { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] 10 | pub fn new(price: i32, timestamp: u64, quantity: i32, instrument: String) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/order_book/mod.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | return matched_quantity; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - return matched_quantity; [INFO] [stdout] 57 + matched_quantity [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/order_book/mod.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | return matched_quantity; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return matched_quantity; [INFO] [stdout] 82 + matched_quantity [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/order_book/order.rs:99:17 [INFO] [stdout] | [INFO] [stdout] 99 | assert!(!(o1 == o2)); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(o1 != o2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/order_book/order.rs:100:17 [INFO] [stdout] | [INFO] [stdout] 100 | assert!(!(o1 == o3)); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(o1 != o3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/order_book/mod.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | return matched_quantity; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - return matched_quantity; [INFO] [stdout] 57 + matched_quantity [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/order_book/mod.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | return matched_quantity; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return matched_quantity; [INFO] [stdout] 82 + matched_quantity [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.24s [INFO] running `Command { std: "docker" "inspect" "a9f671a62ccab59855ac4f65bfd3027c979cbe886d7f9b89e814ea3275588b59", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a9f671a62ccab59855ac4f65bfd3027c979cbe886d7f9b89e814ea3275588b59", kill_on_drop: false }` [INFO] [stdout] a9f671a62ccab59855ac4f65bfd3027c979cbe886d7f9b89e814ea3275588b59