[INFO] cloning repository https://github.com/m-gail/findproject-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/m-gail/findproject-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fm-gail%2Ffindproject-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fm-gail%2Ffindproject-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] dc3d70919c24fa6314a98b366004d9efe554e54a [INFO] linting m-gail/findproject-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fm-gail%2Ffindproject-rs" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/m-gail/findproject-rs [INFO] finished tweaking git repo https://github.com/m-gail/findproject-rs [INFO] tweaked toml for git repo https://github.com/m-gail/findproject-rs written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/m-gail/findproject-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/m-gail/findproject-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded clap v4.4.12 [INFO] [stderr] Downloaded clap_lex v0.6.0 [INFO] [stderr] Downloaded unsafe-libyaml v0.2.10 [INFO] [stderr] Downloaded anstream v0.6.5 [INFO] [stderr] Downloaded clap_derive v4.4.7 [INFO] [stderr] Downloaded ryu v1.0.16 [INFO] [stderr] Downloaded serde_derive v1.0.194 [INFO] [stderr] Downloaded serde v1.0.194 [INFO] [stderr] Downloaded serde_yaml v0.9.30 [INFO] [stderr] Downloaded proc-macro2 v1.0.74 [INFO] [stderr] Downloaded itoa v1.0.10 [INFO] [stderr] Downloaded clap_builder v4.4.12 [INFO] [stderr] Downloaded syn v2.0.46 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0371b58a3fca7c70989cb6a088827930c62ee86483e3bd6082d67360923cf044 [INFO] running `Command { std: "docker" "start" "-a" "0371b58a3fca7c70989cb6a088827930c62ee86483e3bd6082d67360923cf044", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0371b58a3fca7c70989cb6a088827930c62ee86483e3bd6082d67360923cf044", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0371b58a3fca7c70989cb6a088827930c62ee86483e3bd6082d67360923cf044", kill_on_drop: false }` [INFO] [stdout] 0371b58a3fca7c70989cb6a088827930c62ee86483e3bd6082d67360923cf044 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2caee1a4ef546e687427adbdad4e27bc87c8cb714b4186afe0e7b63d24a002fe [INFO] running `Command { std: "docker" "start" "-a" "2caee1a4ef546e687427adbdad4e27bc87c8cb714b4186afe0e7b63d24a002fe", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.74 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Compiling serde v1.0.194 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking unsafe-libyaml v0.2.10 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking anstream v0.6.5 [INFO] [stderr] Checking indexmap v2.1.0 [INFO] [stderr] Checking clap_builder v4.4.12 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.46 [INFO] [stderr] Compiling serde_derive v1.0.194 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking clap v4.4.12 [INFO] [stderr] Checking serde_yaml v0.9.30 [INFO] [stderr] Checking findproject-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | / return match Path::new(&base_dir).join(config_path).to_str() { [INFO] [stdout] 24 | | Some(config_path) => config_path.to_string(), [INFO] [stdout] 25 | | None => full_config_path, [INFO] [stdout] 26 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 ~ match Path::new(&base_dir).join(config_path).to_str() { [INFO] [stdout] 24 + Some(config_path) => config_path.to_string(), [INFO] [stdout] 25 + None => full_config_path, [INFO] [stdout] 26 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | / return match home_dir_result { [INFO] [stdout] 64 | | Ok(home_dir) => string.replace("~", &home_dir), [INFO] [stdout] 65 | | Err(_) => string, [INFO] [stdout] 66 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 ~ match home_dir_result { [INFO] [stdout] 64 + Ok(home_dir) => string.replace("~", &home_dir), [INFO] [stdout] 65 + Err(_) => string, [INFO] [stdout] 66 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:120:12 [INFO] [stdout] | [INFO] [stdout] 120 | && !directory [INFO] [stdout] | ____________^ [INFO] [stdout] 121 | | .sub_directories [INFO] [stdout] 122 | | .iter() [INFO] [stdout] 123 | | .find(|sub_directory| sub_directory.path == file_name) [INFO] [stdout] 124 | | .is_some(); [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 120 ~ && directory [INFO] [stdout] 121 + .sub_directories [INFO] [stdout] 122 + .iter() [INFO] [stdout] 123 ~ .find(|sub_directory| sub_directory.path == file_name).is_none(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 118 | / return dir_entry.path().is_dir() [INFO] [stdout] 119 | | && !directory.exclude.contains(&file_name) [INFO] [stdout] 120 | | && !directory [INFO] [stdout] 121 | | .sub_directories [INFO] [stdout] 122 | | .iter() [INFO] [stdout] 123 | | .find(|sub_directory| sub_directory.path == file_name) [INFO] [stdout] 124 | | .is_some(); [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 ~ dir_entry.path().is_dir() [INFO] [stdout] 119 + && !directory.exclude.contains(&file_name) [INFO] [stdout] 120 + && !directory [INFO] [stdout] 121 + .sub_directories [INFO] [stdout] 122 + .iter() [INFO] [stdout] 123 + .find(|sub_directory| sub_directory.path == file_name) [INFO] [stdout] 124 ~ .is_some() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | / return match Path::new(&base_dir).join(config_path).to_str() { [INFO] [stdout] 24 | | Some(config_path) => config_path.to_string(), [INFO] [stdout] 25 | | None => full_config_path, [INFO] [stdout] 26 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 ~ match Path::new(&base_dir).join(config_path).to_str() { [INFO] [stdout] 24 + Some(config_path) => config_path.to_string(), [INFO] [stdout] 25 + None => full_config_path, [INFO] [stdout] 26 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | / return match home_dir_result { [INFO] [stdout] 64 | | Ok(home_dir) => string.replace("~", &home_dir), [INFO] [stdout] 65 | | Err(_) => string, [INFO] [stdout] 66 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 ~ match home_dir_result { [INFO] [stdout] 64 + Ok(home_dir) => string.replace("~", &home_dir), [INFO] [stdout] 65 + Err(_) => string, [INFO] [stdout] 66 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:120:12 [INFO] [stdout] | [INFO] [stdout] 120 | && !directory [INFO] [stdout] | ____________^ [INFO] [stdout] 121 | | .sub_directories [INFO] [stdout] 122 | | .iter() [INFO] [stdout] 123 | | .find(|sub_directory| sub_directory.path == file_name) [INFO] [stdout] 124 | | .is_some(); [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 120 ~ && directory [INFO] [stdout] 121 + .sub_directories [INFO] [stdout] 122 + .iter() [INFO] [stdout] 123 ~ .find(|sub_directory| sub_directory.path == file_name).is_none(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 118 | / return dir_entry.path().is_dir() [INFO] [stdout] 119 | | && !directory.exclude.contains(&file_name) [INFO] [stdout] 120 | | && !directory [INFO] [stdout] 121 | | .sub_directories [INFO] [stdout] 122 | | .iter() [INFO] [stdout] 123 | | .find(|sub_directory| sub_directory.path == file_name) [INFO] [stdout] 124 | | .is_some(); [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 ~ dir_entry.path().is_dir() [INFO] [stdout] 119 + && !directory.exclude.contains(&file_name) [INFO] [stdout] 120 + && !directory [INFO] [stdout] 121 + .sub_directories [INFO] [stdout] 122 + .iter() [INFO] [stdout] 123 + .find(|sub_directory| sub_directory.path == file_name) [INFO] [stdout] 124 ~ .is_some() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 14.59s [INFO] running `Command { std: "docker" "inspect" "2caee1a4ef546e687427adbdad4e27bc87c8cb714b4186afe0e7b63d24a002fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2caee1a4ef546e687427adbdad4e27bc87c8cb714b4186afe0e7b63d24a002fe", kill_on_drop: false }` [INFO] [stdout] 2caee1a4ef546e687427adbdad4e27bc87c8cb714b4186afe0e7b63d24a002fe