[INFO] cloning repository https://github.com/luv4bytes/trng [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/luv4bytes/trng" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fluv4bytes%2Ftrng", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fluv4bytes%2Ftrng'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] df2786135beda3d871851021c834b2bbd207d8c8 [INFO] linting luv4bytes/trng against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fluv4bytes%2Ftrng" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/luv4bytes/trng [INFO] finished tweaking git repo https://github.com/luv4bytes/trng [INFO] tweaked toml for git repo https://github.com/luv4bytes/trng written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/luv4bytes/trng on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/luv4bytes/trng already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] | [INFO] [stderr] = note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] = note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] = note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2faf1bec3daae03a7a9075260df214eeae5c88d687b7826a459fa959697a77d6 [INFO] running `Command { std: "docker" "start" "-a" "2faf1bec3daae03a7a9075260df214eeae5c88d687b7826a459fa959697a77d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2faf1bec3daae03a7a9075260df214eeae5c88d687b7826a459fa959697a77d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2faf1bec3daae03a7a9075260df214eeae5c88d687b7826a459fa959697a77d6", kill_on_drop: false }` [INFO] [stdout] 2faf1bec3daae03a7a9075260df214eeae5c88d687b7826a459fa959697a77d6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 673fc28cc6dae42aa6bf9778b3691a94af661e2a3668ccb8effc50f6ecc9c3d7 [INFO] running `Command { std: "docker" "start" "-a" "673fc28cc6dae42aa6bf9778b3691a94af661e2a3668ccb8effc50f6ecc9c3d7", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] | [INFO] [stderr] = note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] = note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] = note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Checking trng v0.1.0 (/opt/rustwide/workdir/trng) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/interpreter.rs:330:17 [INFO] [stdout] | [INFO] [stdout] 330 | assert!(!run_result.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `run_result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/interpreter.rs:344:17 [INFO] [stdout] | [INFO] [stdout] 344 | assert!(!run_result.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `run_result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/interpreter.rs:351:17 [INFO] [stdout] | [INFO] [stdout] 351 | assert!(!f.is_err()); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `f.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/interpreter.rs:356:17 [INFO] [stdout] | [INFO] [stdout] 356 | assert!(!run_result.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `run_result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/interpreter.rs:363:17 [INFO] [stdout] | [INFO] [stdout] 363 | assert!(!f.is_err()); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `f.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/interpreter.rs:368:17 [INFO] [stdout] | [INFO] [stdout] 368 | assert!(!run_result.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `run_result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/interpreter.rs:375:17 [INFO] [stdout] | [INFO] [stdout] 375 | assert!(!f.is_err()); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `f.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/interpreter.rs:380:17 [INFO] [stdout] | [INFO] [stdout] 380 | assert!(!run_result.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `run_result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/interpreter.rs:387:17 [INFO] [stdout] | [INFO] [stdout] 387 | assert!(!f.is_err()); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `f.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/interpreter.rs:392:17 [INFO] [stdout] | [INFO] [stdout] 392 | assert!(!run_result.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `run_result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/interpreter.rs:399:17 [INFO] [stdout] | [INFO] [stdout] 399 | assert!(!f.is_err()); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `f.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/interpreter.rs:404:17 [INFO] [stdout] | [INFO] [stdout] 404 | assert!(!run_result.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `run_result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/interpreter.rs:411:17 [INFO] [stdout] | [INFO] [stdout] 411 | assert!(!f.is_err()); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `f.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/interpreter.rs:416:17 [INFO] [stdout] | [INFO] [stdout] 416 | assert!(!run_result.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `run_result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling .bytes() is very inefficient when data is not in memory [INFO] [stdout] --> trng/src/lexer.rs:112:21 [INFO] [stdout] | [INFO] [stdout] 112 | for bres in read_from.bytes() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `BufReader` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unbuffered_bytes [INFO] [stdout] = note: `#[warn(clippy::unbuffered_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> trng/src/lexer.rs:113:24 [INFO] [stdout] | [INFO] [stdout] 113 | let byte = match bres { [INFO] [stdout] | ________________________^ [INFO] [stdout] 114 | | Ok(b) => b, [INFO] [stdout] 115 | | Err(e) => return Err(e), [INFO] [stdout] 116 | | }; [INFO] [stdout] | |_____________^ help: try instead: `bres?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> trng/src/lexer.rs:161:13 [INFO] [stdout] | [INFO] [stdout] 161 | / return match self.token_buffer.as_str() { [INFO] [stdout] 162 | | "pfw" => Some(self.token_from_internal(TokenType::Pfw)), [INFO] [stdout] 163 | | "pbw" => Some(self.token_from_internal(TokenType::Pbw)), [INFO] [stdout] 164 | | "inc" => Some(self.token_from_internal(TokenType::Inc)), [INFO] [stdout] ... | [INFO] [stdout] 194 | | &_ => Some(self.token_from_internal(TokenType::Unknown)), [INFO] [stdout] 195 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 161 ~ match self.token_buffer.as_str() { [INFO] [stdout] 162 + "pfw" => Some(self.token_from_internal(TokenType::Pfw)), [INFO] [stdout] 163 + "pbw" => Some(self.token_from_internal(TokenType::Pbw)), [INFO] [stdout] 164 + "inc" => Some(self.token_from_internal(TokenType::Inc)), [INFO] [stdout] 165 + "dec" => Some(self.token_from_internal(TokenType::Dec)), [INFO] [stdout] 166 + "lop" => Some(self.token_from_internal(TokenType::Lop)), [INFO] [stdout] 167 + "pol" => Some(self.token_from_internal(TokenType::Pol)), [INFO] [stdout] 168 + "wrt" => Some(self.token_from_internal(TokenType::Wrt)), [INFO] [stdout] 169 + "wrti8" => Some(self.token_from_internal(TokenType::Wrti8)), [INFO] [stdout] 170 + "wrti16" => Some(self.token_from_internal(TokenType::Wrti16)), [INFO] [stdout] 171 + "wrti32" => Some(self.token_from_internal(TokenType::Wrti32)), [INFO] [stdout] 172 + "wrti64" => Some(self.token_from_internal(TokenType::Wrti64)), [INFO] [stdout] 173 + "wrtu8" => Some(self.token_from_internal(TokenType::Wrtu8)), [INFO] [stdout] 174 + "wrtu16" => Some(self.token_from_internal(TokenType::Wrtu16)), [INFO] [stdout] 175 + "wrtu32" => Some(self.token_from_internal(TokenType::Wrtu32)), [INFO] [stdout] 176 + "wrtu64" => Some(self.token_from_internal(TokenType::Wrtu64)), [INFO] [stdout] 177 + "wrtf32" => Some(self.token_from_internal(TokenType::Wrtf32)), [INFO] [stdout] 178 + "wrtf64" => Some(self.token_from_internal(TokenType::Wrtf64)), [INFO] [stdout] 179 + "rdi" => Some(self.token_from_internal(TokenType::Rdi)), [INFO] [stdout] 180 + "rda" => Some(self.token_from_internal(TokenType::Rda)), [INFO] [stdout] 181 + "set" => Some(self.token_from_internal(TokenType::Set)), [INFO] [stdout] 182 + "seti8" => Some(self.token_from_internal(TokenType::Seti8)), [INFO] [stdout] 183 + "seti16" => Some(self.token_from_internal(TokenType::Seti16)), [INFO] [stdout] 184 + "seti32" => Some(self.token_from_internal(TokenType::Seti32)), [INFO] [stdout] 185 + "seti64" => Some(self.token_from_internal(TokenType::Seti64)), [INFO] [stdout] 186 + "setu8" => Some(self.token_from_internal(TokenType::Setu8)), [INFO] [stdout] 187 + "setu16" => Some(self.token_from_internal(TokenType::Setu16)), [INFO] [stdout] 188 + "setu32" => Some(self.token_from_internal(TokenType::Setu32)), [INFO] [stdout] 189 + "setu64" => Some(self.token_from_internal(TokenType::Setu64)), [INFO] [stdout] 190 + "wra" => Some(self.token_from_internal(TokenType::Wra)), [INFO] [stdout] 191 + "setf32" => Some(self.token_from_internal(TokenType::Setf32)), [INFO] [stdout] 192 + "setf64" => Some(self.token_from_internal(TokenType::Setf64)), [INFO] [stdout] 193 + "clr" => Some(self.token_from_internal(TokenType::Clr)), [INFO] [stdout] 194 + &_ => Some(self.token_from_internal(TokenType::Unknown)), [INFO] [stdout] 195 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> trng/src/lexer.rs:198:13 [INFO] [stdout] | [INFO] [stdout] 198 | return Some(self.token_from_internal(TokenType::Num)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 198 - return Some(self.token_from_internal(TokenType::Num)); [INFO] [stdout] 198 + Some(self.token_from_internal(TokenType::Num)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> trng/src/lexer.rs:200:13 [INFO] [stdout] | [INFO] [stdout] 200 | return Some(self.token_from_internal(TokenType::Unknown)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 200 - return Some(self.token_from_internal(TokenType::Unknown)); [INFO] [stdout] 200 + Some(self.token_from_internal(TokenType::Unknown)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/lexer.rs:225:17 [INFO] [stdout] | [INFO] [stdout] 225 | assert!(!tokens.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `tokens.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling .bytes() is very inefficient when data is not in memory [INFO] [stdout] --> trng/src/lexer.rs:112:21 [INFO] [stdout] | [INFO] [stdout] 112 | for bres in read_from.bytes() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `BufReader` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unbuffered_bytes [INFO] [stdout] = note: `#[warn(clippy::unbuffered_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> trng/src/lexer.rs:113:24 [INFO] [stdout] | [INFO] [stdout] 113 | let byte = match bres { [INFO] [stdout] | ________________________^ [INFO] [stdout] 114 | | Ok(b) => b, [INFO] [stdout] 115 | | Err(e) => return Err(e), [INFO] [stdout] 116 | | }; [INFO] [stdout] | |_____________^ help: try instead: `bres?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> trng/src/lexer.rs:161:13 [INFO] [stdout] | [INFO] [stdout] 161 | / return match self.token_buffer.as_str() { [INFO] [stdout] 162 | | "pfw" => Some(self.token_from_internal(TokenType::Pfw)), [INFO] [stdout] 163 | | "pbw" => Some(self.token_from_internal(TokenType::Pbw)), [INFO] [stdout] 164 | | "inc" => Some(self.token_from_internal(TokenType::Inc)), [INFO] [stdout] ... | [INFO] [stdout] 194 | | &_ => Some(self.token_from_internal(TokenType::Unknown)), [INFO] [stdout] 195 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 161 ~ match self.token_buffer.as_str() { [INFO] [stdout] 162 + "pfw" => Some(self.token_from_internal(TokenType::Pfw)), [INFO] [stdout] 163 + "pbw" => Some(self.token_from_internal(TokenType::Pbw)), [INFO] [stdout] 164 + "inc" => Some(self.token_from_internal(TokenType::Inc)), [INFO] [stdout] 165 + "dec" => Some(self.token_from_internal(TokenType::Dec)), [INFO] [stdout] 166 + "lop" => Some(self.token_from_internal(TokenType::Lop)), [INFO] [stdout] 167 + "pol" => Some(self.token_from_internal(TokenType::Pol)), [INFO] [stdout] 168 + "wrt" => Some(self.token_from_internal(TokenType::Wrt)), [INFO] [stdout] 169 + "wrti8" => Some(self.token_from_internal(TokenType::Wrti8)), [INFO] [stdout] 170 + "wrti16" => Some(self.token_from_internal(TokenType::Wrti16)), [INFO] [stdout] 171 + "wrti32" => Some(self.token_from_internal(TokenType::Wrti32)), [INFO] [stdout] 172 + "wrti64" => Some(self.token_from_internal(TokenType::Wrti64)), [INFO] [stdout] 173 + "wrtu8" => Some(self.token_from_internal(TokenType::Wrtu8)), [INFO] [stdout] 174 + "wrtu16" => Some(self.token_from_internal(TokenType::Wrtu16)), [INFO] [stdout] 175 + "wrtu32" => Some(self.token_from_internal(TokenType::Wrtu32)), [INFO] [stdout] 176 + "wrtu64" => Some(self.token_from_internal(TokenType::Wrtu64)), [INFO] [stdout] 177 + "wrtf32" => Some(self.token_from_internal(TokenType::Wrtf32)), [INFO] [stdout] 178 + "wrtf64" => Some(self.token_from_internal(TokenType::Wrtf64)), [INFO] [stdout] 179 + "rdi" => Some(self.token_from_internal(TokenType::Rdi)), [INFO] [stdout] 180 + "rda" => Some(self.token_from_internal(TokenType::Rda)), [INFO] [stdout] 181 + "set" => Some(self.token_from_internal(TokenType::Set)), [INFO] [stdout] 182 + "seti8" => Some(self.token_from_internal(TokenType::Seti8)), [INFO] [stdout] 183 + "seti16" => Some(self.token_from_internal(TokenType::Seti16)), [INFO] [stdout] 184 + "seti32" => Some(self.token_from_internal(TokenType::Seti32)), [INFO] [stdout] 185 + "seti64" => Some(self.token_from_internal(TokenType::Seti64)), [INFO] [stdout] 186 + "setu8" => Some(self.token_from_internal(TokenType::Setu8)), [INFO] [stdout] 187 + "setu16" => Some(self.token_from_internal(TokenType::Setu16)), [INFO] [stdout] 188 + "setu32" => Some(self.token_from_internal(TokenType::Setu32)), [INFO] [stdout] 189 + "setu64" => Some(self.token_from_internal(TokenType::Setu64)), [INFO] [stdout] 190 + "wra" => Some(self.token_from_internal(TokenType::Wra)), [INFO] [stdout] 191 + "setf32" => Some(self.token_from_internal(TokenType::Setf32)), [INFO] [stdout] 192 + "setf64" => Some(self.token_from_internal(TokenType::Setf64)), [INFO] [stdout] 193 + "clr" => Some(self.token_from_internal(TokenType::Clr)), [INFO] [stdout] 194 + &_ => Some(self.token_from_internal(TokenType::Unknown)), [INFO] [stdout] 195 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> trng/src/lexer.rs:198:13 [INFO] [stdout] | [INFO] [stdout] 198 | return Some(self.token_from_internal(TokenType::Num)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 198 - return Some(self.token_from_internal(TokenType::Num)); [INFO] [stdout] 198 + Some(self.token_from_internal(TokenType::Num)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> trng/src/lexer.rs:200:13 [INFO] [stdout] | [INFO] [stdout] 200 | return Some(self.token_from_internal(TokenType::Unknown)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 200 - return Some(self.token_from_internal(TokenType::Unknown)); [INFO] [stdout] 200 + Some(self.token_from_internal(TokenType::Unknown)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/tape/mod.rs:522:17 [INFO] [stdout] | [INFO] [stdout] 522 | assert!(!res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/tape/mod.rs:531:17 [INFO] [stdout] | [INFO] [stdout] 531 | assert!(!res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/tape/mod.rs:543:17 [INFO] [stdout] | [INFO] [stdout] 543 | assert!(!res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/tape/mod.rs:557:17 [INFO] [stdout] | [INFO] [stdout] 557 | assert!(!res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/tape/mod.rs:581:17 [INFO] [stdout] | [INFO] [stdout] 581 | assert!(!res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/tape/mod.rs:590:17 [INFO] [stdout] | [INFO] [stdout] 590 | assert!(!res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/tape/mod.rs:602:17 [INFO] [stdout] | [INFO] [stdout] 602 | assert!(!res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/tape/mod.rs:618:17 [INFO] [stdout] | [INFO] [stdout] 618 | assert!(!res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/tape/mod.rs:642:17 [INFO] [stdout] | [INFO] [stdout] 642 | assert!(!res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/tape/mod.rs:658:17 [INFO] [stdout] | [INFO] [stdout] 658 | assert!(!res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/tape/mod.rs:682:17 [INFO] [stdout] | [INFO] [stdout] 682 | assert!(!res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/tape/mod.rs:690:17 [INFO] [stdout] | [INFO] [stdout] 690 | assert!(!res.is_err()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/tape/mod.rs:698:17 [INFO] [stdout] | [INFO] [stdout] 698 | assert!(!res.is_err()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/tape/mod.rs:706:17 [INFO] [stdout] | [INFO] [stdout] 706 | assert!(!res.is_err()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/tape/mod.rs:714:17 [INFO] [stdout] | [INFO] [stdout] 714 | assert!(!res.is_err()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/tape/mod.rs:722:17 [INFO] [stdout] | [INFO] [stdout] 722 | assert!(!res.is_err()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/tape/mod.rs:730:17 [INFO] [stdout] | [INFO] [stdout] 730 | assert!(!res.is_err()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/tape/mod.rs:738:17 [INFO] [stdout] | [INFO] [stdout] 738 | assert!(!res.is_err()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/tape/mod.rs:746:17 [INFO] [stdout] | [INFO] [stdout] 746 | assert!(!res.is_err()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/tape/mod.rs:754:17 [INFO] [stdout] | [INFO] [stdout] 754 | assert!(!res.is_err()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/tape/mod.rs:762:17 [INFO] [stdout] | [INFO] [stdout] 762 | assert!(!res.is_err()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/tape/mod.rs:770:17 [INFO] [stdout] | [INFO] [stdout] 770 | assert!(!res.is_err()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/tape/mod.rs:778:17 [INFO] [stdout] | [INFO] [stdout] 778 | assert!(!res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/tape/mod.rs:783:17 [INFO] [stdout] | [INFO] [stdout] 783 | assert!(!res.is_err()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/tape/mod.rs:792:17 [INFO] [stdout] | [INFO] [stdout] 792 | assert!(!res.is_err()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/tape/mod.rs:800:17 [INFO] [stdout] | [INFO] [stdout] 800 | assert!(!res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/tape/mod.rs:825:17 [INFO] [stdout] | [INFO] [stdout] 825 | assert!(!rdi_res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `rdi_res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> trng/src/tape/mod.rs:828:17 [INFO] [stdout] | [INFO] [stdout] 828 | assert!(!wrt_res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `wrt_res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.43s [INFO] running `Command { std: "docker" "inspect" "673fc28cc6dae42aa6bf9778b3691a94af661e2a3668ccb8effc50f6ecc9c3d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "673fc28cc6dae42aa6bf9778b3691a94af661e2a3668ccb8effc50f6ecc9c3d7", kill_on_drop: false }` [INFO] [stdout] 673fc28cc6dae42aa6bf9778b3691a94af661e2a3668ccb8effc50f6ecc9c3d7