[INFO] cloning repository https://github.com/luser/fsm-test [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/luser/fsm-test" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fluser%2Ffsm-test", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fluser%2Ffsm-test'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 85d772cbe08e8f29946403a3e4fbd6164ea46987 [INFO] linting luser/fsm-test against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fluser%2Ffsm-test" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/luser/fsm-test [INFO] finished tweaking git repo https://github.com/luser/fsm-test [INFO] tweaked toml for git repo https://github.com/luser/fsm-test written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/luser/fsm-test on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/luser/fsm-test already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fb4bc671fd2c66892ef1900f54885699e856a5794588c5f91e8f6c590ff8fa06 [INFO] running `Command { std: "docker" "start" "-a" "fb4bc671fd2c66892ef1900f54885699e856a5794588c5f91e8f6c590ff8fa06", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fb4bc671fd2c66892ef1900f54885699e856a5794588c5f91e8f6c590ff8fa06", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fb4bc671fd2c66892ef1900f54885699e856a5794588c5f91e8f6c590ff8fa06", kill_on_drop: false }` [INFO] [stdout] fb4bc671fd2c66892ef1900f54885699e856a5794588c5f91e8f6c590ff8fa06 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2f0b5466277647bbb07f15972a2e5d9b971e5256f1eed7a77072ca73d6bed603 [INFO] running `Command { std: "docker" "start" "-a" "2f0b5466277647bbb07f15972a2e5d9b971e5256f1eed7a77072ca73d6bed603", kill_on_drop: false }` [INFO] [stderr] Checking fsm-test v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/fsm.rs:19:16 [INFO] [stdout] | [INFO] [stdout] 19 | if !(c == 'b' as i32) { break ; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(c != 'b' as i32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/fsm.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | return -(1 as libc::c_int) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 ~ -(1 as libc::c_int) [INFO] [stdout] 27 | } else if c == 'd' as i32 { [INFO] [stdout] ... [INFO] [stdout] 56 | return -(1 as libc::c_int) [INFO] [stdout] 57 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/fsm.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | return -(1 as libc::c_int) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 ~ -(1 as libc::c_int) [INFO] [stdout] 57 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `0 as *const _` detected [INFO] [stdout] --> src/fsm.rs:5:38 [INFO] [stdout] | [INFO] [stdout] 5 | let mut p: *const libc::c_char = 0 as *const libc::c_char; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::ptr::null::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stdout] = note: `#[warn(clippy::zero_ptr)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/fsm.rs:19:16 [INFO] [stdout] | [INFO] [stdout] 19 | if !(c == 'b' as i32) { break ; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(c != 'b' as i32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/fsm.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | return -(1 as libc::c_int) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 ~ -(1 as libc::c_int) [INFO] [stdout] 27 | } else if c == 'd' as i32 { [INFO] [stdout] ... [INFO] [stdout] 56 | return -(1 as libc::c_int) [INFO] [stdout] 57 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/fsm.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | return -(1 as libc::c_int) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 ~ -(1 as libc::c_int) [INFO] [stdout] 57 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.24s [INFO] [stdout] warning: `0 as *const _` detected [INFO] [stdout] --> src/fsm.rs:5:38 [INFO] [stdout] | [INFO] [stdout] 5 | let mut p: *const libc::c_char = 0 as *const libc::c_char; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::ptr::null::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stdout] = note: `#[warn(clippy::zero_ptr)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "2f0b5466277647bbb07f15972a2e5d9b971e5256f1eed7a77072ca73d6bed603", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2f0b5466277647bbb07f15972a2e5d9b971e5256f1eed7a77072ca73d6bed603", kill_on_drop: false }` [INFO] [stdout] 2f0b5466277647bbb07f15972a2e5d9b971e5256f1eed7a77072ca73d6bed603