[INFO] cloning repository https://github.com/lukrycyfa/warehouse-reservations-canister [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/lukrycyfa/warehouse-reservations-canister" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flukrycyfa%2Fwarehouse-reservations-canister", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flukrycyfa%2Fwarehouse-reservations-canister'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e3d3d52013a506ae307f745f2dc3889d55d60e47 [INFO] linting lukrycyfa/warehouse-reservations-canister against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flukrycyfa%2Fwarehouse-reservations-canister" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/lukrycyfa/warehouse-reservations-canister [INFO] finished tweaking git repo https://github.com/lukrycyfa/warehouse-reservations-canister [INFO] tweaked toml for git repo https://github.com/lukrycyfa/warehouse-reservations-canister written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/lukrycyfa/warehouse-reservations-canister on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/lukrycyfa/warehouse-reservations-canister already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] | [INFO] [stderr] = note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] = note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] = note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pretty v0.12.3 [INFO] [stderr] Downloaded candid_derive v0.6.4 [INFO] [stderr] Downloaded ic-cdk-macros v0.8.1 [INFO] [stderr] Downloaded ic-stable-structures v0.5.6 [INFO] [stderr] Downloaded ic-cdk v0.11.3 [INFO] [stderr] Downloaded candid v0.9.11 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] beaae999e956be21f4e6c3264a3dcc9a3dbe17306d46d4b04e33f3bc6fe9a795 [INFO] running `Command { std: "docker" "start" "-a" "beaae999e956be21f4e6c3264a3dcc9a3dbe17306d46d4b04e33f3bc6fe9a795", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "beaae999e956be21f4e6c3264a3dcc9a3dbe17306d46d4b04e33f3bc6fe9a795", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "beaae999e956be21f4e6c3264a3dcc9a3dbe17306d46d4b04e33f3bc6fe9a795", kill_on_drop: false }` [INFO] [stdout] beaae999e956be21f4e6c3264a3dcc9a3dbe17306d46d4b04e33f3bc6fe9a795 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 33251a00c834b30b5a77a730cd805ef566b1315dc0f9e6bbcbf4997d72728e76 [INFO] running `Command { std: "docker" "start" "-a" "33251a00c834b30b5a77a730cd805ef566b1315dc0f9e6bbcbf4997d72728e76", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] | [INFO] [stderr] = note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] = note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] = note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling hashbrown v0.14.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling toml_datetime v0.6.3 [INFO] [stderr] Compiling winnow v0.5.16 [INFO] [stderr] Compiling once_cell v1.18.0 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Compiling either v1.9.0 [INFO] [stderr] Compiling thiserror v1.0.49 [INFO] [stderr] Compiling candid v0.9.11 [INFO] [stderr] Compiling unicode-width v0.1.11 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling termcolor v1.3.0 [INFO] [stderr] Compiling typed-arena v2.0.2 [INFO] [stderr] Compiling arrayvec v0.5.2 [INFO] [stderr] Compiling sha2 v0.10.8 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling data-encoding v2.4.0 [INFO] [stderr] Compiling leb128 v0.2.5 [INFO] [stderr] Compiling pretty v0.12.3 [INFO] [stderr] Compiling codespan-reporting v0.11.1 [INFO] [stderr] Checking ic0 v0.21.1 [INFO] [stderr] Checking ic-stable-structures v0.5.6 [INFO] [stderr] Compiling indexmap v2.0.2 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Compiling psm v0.1.21 [INFO] [stderr] Compiling stacker v0.1.15 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling thiserror-impl v1.0.49 [INFO] [stderr] Compiling candid_derive v0.6.4 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Compiling num_enum_derive v0.6.1 [INFO] [stderr] Compiling binread_derive v2.1.0 [INFO] [stderr] Compiling num_enum v0.6.1 [INFO] [stderr] Compiling binread v2.2.0 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Checking serde_bytes v0.11.12 [INFO] [stderr] Checking serde_json v1.0.108 [INFO] [stderr] Compiling serde_tokenstream v0.1.7 [INFO] [stderr] Compiling ic-cdk-macros v0.8.1 [INFO] [stderr] Checking ic-cdk v0.11.3 [INFO] [stderr] Checking warehouse_reservations_canister v0.1.0 (/opt/rustwide/workdir/src/warehouse_reservations_canister) [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:288:17 [INFO] [stdout] | [INFO] [stdout] 288 | ... let ___ = _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_stri... [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] = note: `#[warn(clippy::just_underscores_and_digits)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:303:17 [INFO] [stdout] | [INFO] [stdout] 303 | ... let ___ = _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_stri... [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:332:17 [INFO] [stdout] | [INFO] [stdout] 332 | ... let ___ = _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_stri... [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:361:17 [INFO] [stdout] | [INFO] [stdout] 361 | ... let ___ = _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_stri... [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:376:9 [INFO] [stdout] | [INFO] [stdout] 376 | let __ = _ifvalid(&(staff.staff_address.is_some() && staff.first_name.len() > 0 && [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:407:9 [INFO] [stdout] | [INFO] [stdout] 407 | let __ = _ifvalid(&(client.first_name.len() > 0 && client.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:458:17 [INFO] [stdout] | [INFO] [stdout] 458 | let __ = _ifvalid(&(payload.reservations > 0), "Insufficent Payload For Reservations".to_string())?; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:484:17 [INFO] [stdout] | [INFO] [stdout] 484 | let ___ = _ifvalid(&(client.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:490:24 [INFO] [stdout] | [INFO] [stdout] 490 | let __ = _ifvalid(&(product.reservations - payload.reserve > 0), [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:532:25 [INFO] [stdout] | [INFO] [stdout] 532 | let __ = _ifvalid(&(idx.is_some()), "Invalid Reservation For the Client".to_string())?; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:535:32 [INFO] [stdout] | [INFO] [stdout] 535 | ... let __ = _ifvalid(&(!reservation.serve && reservation.invalid_at >= time()), "Reservation Has been Attended To Or Oudated".to... [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:585:17 [INFO] [stdout] | [INFO] [stdout] 585 | let __ = _ifvalid(&(payload.staff_address.is_some() && payload.first_name.len() > 0 && [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:607:17 [INFO] [stdout] | [INFO] [stdout] 607 | let __ = _ifvalid(&(payload.first_name.len() > 0 && payload.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:662:25 [INFO] [stdout] | [INFO] [stdout] 662 | ... let __ = _ifvalid(&(reservation.invalid_at > time() && !reservation.serve), "Reservation Outdated Or Has been Proccessed".to_... [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:666:33 [INFO] [stdout] | [INFO] [stdout] 666 | ... let ___ = _ifvalid(&(product.maximum_reservation >= payload.reserve && payload.reserve >= product.minimum_reservation [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:668:33 [INFO] [stdout] | [INFO] [stdout] 668 | ... let ____ = _ifvalid(&((product.reservations + reservation.reserve) - payload.reserve > 0 ), [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:772:25 [INFO] [stdout] | [INFO] [stdout] 772 | let __ = _ifvalid(&(!idx.is_some()), "This Product Still Holds a Valid Reservation".to_string())?; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:795:16 [INFO] [stdout] | [INFO] [stdout] 795 | let __ = _ifvalid(&(idx.is_some()), "Invalid Reservation For Caller".to_string())?; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:798:25 [INFO] [stdout] | [INFO] [stdout] 798 | ... let ___ = _ifvalid(&(reservation.client_address == client.client_address), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:799:25 [INFO] [stdout] | [INFO] [stdout] 799 | let ____ = _ifvalid(&(!reservation.serve && reservation.invalid_at > time()), [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:845:25 [INFO] [stdout] | [INFO] [stdout] 845 | ... let __ = _ifvalid(&(reservation.client_address == Some(caller())), "Unauthorized Operation for Caller()".to_string())?; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:846:25 [INFO] [stdout] | [INFO] [stdout] 846 | let ___ = _ifvalid(&(reservation.serve || reservation.invalid_at < time()), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:288:17 [INFO] [stdout] | [INFO] [stdout] 288 | ... let ___ = _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_stri... [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] = note: `#[warn(clippy::just_underscores_and_digits)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:303:17 [INFO] [stdout] | [INFO] [stdout] 303 | ... let ___ = _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_stri... [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:332:17 [INFO] [stdout] | [INFO] [stdout] 332 | ... let ___ = _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_stri... [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:361:17 [INFO] [stdout] | [INFO] [stdout] 361 | ... let ___ = _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_stri... [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:376:9 [INFO] [stdout] | [INFO] [stdout] 376 | let __ = _ifvalid(&(staff.staff_address.is_some() && staff.first_name.len() > 0 && [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:407:9 [INFO] [stdout] | [INFO] [stdout] 407 | let __ = _ifvalid(&(client.first_name.len() > 0 && client.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:458:17 [INFO] [stdout] | [INFO] [stdout] 458 | let __ = _ifvalid(&(payload.reservations > 0), "Insufficent Payload For Reservations".to_string())?; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:484:17 [INFO] [stdout] | [INFO] [stdout] 484 | let ___ = _ifvalid(&(client.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:490:24 [INFO] [stdout] | [INFO] [stdout] 490 | let __ = _ifvalid(&(product.reservations - payload.reserve > 0), [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:532:25 [INFO] [stdout] | [INFO] [stdout] 532 | let __ = _ifvalid(&(idx.is_some()), "Invalid Reservation For the Client".to_string())?; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:535:32 [INFO] [stdout] | [INFO] [stdout] 535 | ... let __ = _ifvalid(&(!reservation.serve && reservation.invalid_at >= time()), "Reservation Has been Attended To Or Oudated".to... [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:585:17 [INFO] [stdout] | [INFO] [stdout] 585 | let __ = _ifvalid(&(payload.staff_address.is_some() && payload.first_name.len() > 0 && [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:607:17 [INFO] [stdout] | [INFO] [stdout] 607 | let __ = _ifvalid(&(payload.first_name.len() > 0 && payload.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:662:25 [INFO] [stdout] | [INFO] [stdout] 662 | ... let __ = _ifvalid(&(reservation.invalid_at > time() && !reservation.serve), "Reservation Outdated Or Has been Proccessed".to_... [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:666:33 [INFO] [stdout] | [INFO] [stdout] 666 | ... let ___ = _ifvalid(&(product.maximum_reservation >= payload.reserve && payload.reserve >= product.minimum_reservation [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:668:33 [INFO] [stdout] | [INFO] [stdout] 668 | ... let ____ = _ifvalid(&((product.reservations + reservation.reserve) - payload.reserve > 0 ), [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:772:25 [INFO] [stdout] | [INFO] [stdout] 772 | let __ = _ifvalid(&(!idx.is_some()), "This Product Still Holds a Valid Reservation".to_string())?; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:795:16 [INFO] [stdout] | [INFO] [stdout] 795 | let __ = _ifvalid(&(idx.is_some()), "Invalid Reservation For Caller".to_string())?; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:798:25 [INFO] [stdout] | [INFO] [stdout] 798 | ... let ___ = _ifvalid(&(reservation.client_address == client.client_address), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:799:25 [INFO] [stdout] | [INFO] [stdout] 799 | let ____ = _ifvalid(&(!reservation.serve && reservation.invalid_at > time()), [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:845:25 [INFO] [stdout] | [INFO] [stdout] 845 | ... let __ = _ifvalid(&(reservation.client_address == Some(caller())), "Unauthorized Operation for Caller()".to_string())?; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider choosing a more descriptive name [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:846:25 [INFO] [stdout] | [INFO] [stdout] 846 | let ___ = _ifvalid(&(reservation.serve || reservation.invalid_at < time()), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: initializer for `thread_local` value can be made `const` [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:148:42 [INFO] [stdout] | [INFO] [stdout] 148 | static OWNER: OtherCell = OtherCell::new(Principal::from_slice(&[])); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `const { OtherCell::new(Principal::from_slice(&[])) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_thread_local [INFO] [stdout] = note: `#[warn(clippy::missing_const_for_thread_local)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:245:13 [INFO] [stdout] | [INFO] [stdout] 245 | ... let _ = _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 245 - let _ = _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 245 + _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:288:13 [INFO] [stdout] | [INFO] [stdout] 288 | ... let ___ = _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 288 - let ___ = _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 288 + _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:303:13 [INFO] [stdout] | [INFO] [stdout] 303 | ... let ___ = _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 303 - let ___ = _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 303 + _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:317:13 [INFO] [stdout] | [INFO] [stdout] 317 | let _ = _ifvalid(&(reservation.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 317 - let _ = _ifvalid(&(reservation.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 317 + _ifvalid(&(reservation.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:332:13 [INFO] [stdout] | [INFO] [stdout] 332 | ... let ___ = _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 332 - let ___ = _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 332 + _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:346:13 [INFO] [stdout] | [INFO] [stdout] 346 | let _ = _ifvalid(&(client.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 346 - let _ = _ifvalid(&(client.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 346 + _ifvalid(&(client.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:361:13 [INFO] [stdout] | [INFO] [stdout] 361 | ... let ___ = _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 361 - let ___ = _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 361 + _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:375:5 [INFO] [stdout] | [INFO] [stdout] 375 | let _ = _ifvalid(&(owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 375 - let _ = _ifvalid(&(owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 375 + _ifvalid(&(owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:376:5 [INFO] [stdout] | [INFO] [stdout] 376 | / let __ = _ifvalid(&(staff.staff_address.is_some() && staff.first_name.len() > 0 && [INFO] [stdout] 377 | | staff.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | |___________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 376 - let __ = _ifvalid(&(staff.staff_address.is_some() && staff.first_name.len() > 0 && [INFO] [stdout] 376 + _ifvalid(&(staff.staff_address.is_some() && staff.first_name.len() > 0 && [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:376:58 [INFO] [stdout] | [INFO] [stdout] 376 | let __ = _ifvalid(&(staff.staff_address.is_some() && staff.first_name.len() > 0 && [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!staff.first_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:377:9 [INFO] [stdout] | [INFO] [stdout] 377 | staff.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!staff.last_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:382:18 [INFO] [stdout] | [INFO] [stdout] 382 | msg: format!("could not create a staff")}), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"could not create a staff".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:407:5 [INFO] [stdout] | [INFO] [stdout] 407 | let __ = _ifvalid(&(client.first_name.len() > 0 && client.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 407 - let __ = _ifvalid(&(client.first_name.len() > 0 && client.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] 407 + _ifvalid(&(client.first_name.len() > 0 && client.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:407:25 [INFO] [stdout] | [INFO] [stdout] 407 | let __ = _ifvalid(&(client.first_name.len() > 0 && client.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!client.first_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:407:56 [INFO] [stdout] | [INFO] [stdout] 407 | let __ = _ifvalid(&(client.first_name.len() > 0 && client.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!client.last_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:427:13 [INFO] [stdout] | [INFO] [stdout] 427 | let _ = _ifvalid(&(staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 427 - let _ = _ifvalid(&(staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 427 + _ifvalid(&(staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:428:13 [INFO] [stdout] | [INFO] [stdout] 428 | / let _ = _ifvalid(&(product.name.len() > 0 && product.description.len() > 0 && product.minimum_reservation > 0 && [INFO] [stdout] 429 | | product.maximum_reservation > product.minimum_reservation && product.price_per_item > 0 && [INFO] [stdout] 430 | | product.reservation_valid_duration > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | |____________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 428 - let _ = _ifvalid(&(product.name.len() > 0 && product.description.len() > 0 && product.minimum_reservation > 0 && [INFO] [stdout] 428 + _ifvalid(&(product.name.len() > 0 && product.description.len() > 0 && product.minimum_reservation > 0 && [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:428:32 [INFO] [stdout] | [INFO] [stdout] 428 | let _ = _ifvalid(&(product.name.len() > 0 && product.description.len() > 0 && product.minimum_reservation > 0 && [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!product.name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:428:58 [INFO] [stdout] | [INFO] [stdout] 428 | let _ = _ifvalid(&(product.name.len() > 0 && product.description.len() > 0 && product.minimum_reservation > 0 && [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!product.description.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:457:13 [INFO] [stdout] | [INFO] [stdout] 457 | let _ = _ifvalid(&(staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 457 - let _ = _ifvalid(&(staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 457 + _ifvalid(&(staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:458:13 [INFO] [stdout] | [INFO] [stdout] 458 | let __ = _ifvalid(&(payload.reservations > 0), "Insufficent Payload For Reservations".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 458 - let __ = _ifvalid(&(payload.reservations > 0), "Insufficent Payload For Reservations".to_string())?; [INFO] [stdout] 458 + _ifvalid(&(payload.reservations > 0), "Insufficent Payload For Reservations".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:484:13 [INFO] [stdout] | [INFO] [stdout] 484 | let ___ = _ifvalid(&(client.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 484 - let ___ = _ifvalid(&(client.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 484 + _ifvalid(&(client.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:488:20 [INFO] [stdout] | [INFO] [stdout] 488 | / ... let _ = _ifvalid(&(product.maximum_reservation >= payload.reserve && payload.reserve >= product.minimum_reservation [INFO] [stdout] 489 | | ... && payload.description.len() > 0),"Invalid Payload For Reservations".to_string())?; [INFO] [stdout] | |__________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 488 - let _ = _ifvalid(&(product.maximum_reservation >= payload.reserve && payload.reserve >= product.minimum_reservation [INFO] [stdout] 488 + _ifvalid(&(product.maximum_reservation >= payload.reserve && payload.reserve >= product.minimum_reservation [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:489:24 [INFO] [stdout] | [INFO] [stdout] 489 | && payload.description.len() > 0),"Invalid Payload For Reservations".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!payload.description.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:490:20 [INFO] [stdout] | [INFO] [stdout] 490 | / let __ = _ifvalid(&(product.reservations - payload.reserve > 0), [INFO] [stdout] 491 | | "Insufficent Product In Reserve For Reservations".to_string())?; [INFO] [stdout] | |________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 490 - let __ = _ifvalid(&(product.reservations - payload.reserve > 0), [INFO] [stdout] 490 + _ifvalid(&(product.reservations - payload.reserve > 0), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:528:13 [INFO] [stdout] | [INFO] [stdout] 528 | let _ = _ifvalid(&(staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 528 - let _ = _ifvalid(&(staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 528 + _ifvalid(&(staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:532:21 [INFO] [stdout] | [INFO] [stdout] 532 | let __ = _ifvalid(&(idx.is_some()), "Invalid Reservation For the Client".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 532 - let __ = _ifvalid(&(idx.is_some()), "Invalid Reservation For the Client".to_string())?; [INFO] [stdout] 532 + _ifvalid(&(idx.is_some()), "Invalid Reservation For the Client".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:535:28 [INFO] [stdout] | [INFO] [stdout] 535 | ... let __ = _ifvalid(&(!reservation.serve && reservation.invalid_at >= time()), "Reservation Has been Attended To Or Oudated".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 535 - let __ = _ifvalid(&(!reservation.serve && reservation.invalid_at >= time()), "Reservation Has been Attended To Or Oudated".to_string())?; [INFO] [stdout] 535 + _ifvalid(&(!reservation.serve && reservation.invalid_at >= time()), "Reservation Has been Attended To Or Oudated".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:543:37 [INFO] [stdout] | [INFO] [stdout] 543 | / ... match idx { [INFO] [stdout] 544 | | ... Some(va) => { product.r_requests.remove(va); [INFO] [stdout] 545 | | ... product.r_requests.insert(va, reservation.clone()) [INFO] [stdout] 546 | | ... }, [INFO] [stdout] 547 | | ... None => ()}; [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 543 ~ if let Some(va) = idx { product.r_requests.remove(va); [INFO] [stdout] 544 + product.r_requests.insert(va, reservation.clone()) [INFO] [stdout] 545 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:549:37 [INFO] [stdout] | [INFO] [stdout] 549 | / ... match cidx { [INFO] [stdout] 550 | | ... Some(va) => {client.reservations.remove(va); [INFO] [stdout] 551 | | ... client.reservations.insert(va, reservation.clone());}, [INFO] [stdout] 552 | | ... None => ()}; [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 549 ~ if let Some(va) = cidx {client.reservations.remove(va); [INFO] [stdout] 550 ~ client.reservations.insert(va, reservation.clone());}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:584:13 [INFO] [stdout] | [INFO] [stdout] 584 | let _ = _ifvalid(&(Some(caller()) == staff.staff_address), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 584 - let _ = _ifvalid(&(Some(caller()) == staff.staff_address), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 584 + _ifvalid(&(Some(caller()) == staff.staff_address), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:585:13 [INFO] [stdout] | [INFO] [stdout] 585 | / let __ = _ifvalid(&(payload.staff_address.is_some() && payload.first_name.len() > 0 && [INFO] [stdout] 586 | | payload.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | |_________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 585 - let __ = _ifvalid(&(payload.staff_address.is_some() && payload.first_name.len() > 0 && [INFO] [stdout] 585 + _ifvalid(&(payload.staff_address.is_some() && payload.first_name.len() > 0 && [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:585:68 [INFO] [stdout] | [INFO] [stdout] 585 | let __ = _ifvalid(&(payload.staff_address.is_some() && payload.first_name.len() > 0 && [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!payload.first_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:586:13 [INFO] [stdout] | [INFO] [stdout] 586 | payload.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!payload.last_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:606:13 [INFO] [stdout] | [INFO] [stdout] 606 | let _ = _ifvalid(&(client.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 606 - let _ = _ifvalid(&(client.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 606 + _ifvalid(&(client.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:607:13 [INFO] [stdout] | [INFO] [stdout] 607 | let __ = _ifvalid(&(payload.first_name.len() > 0 && payload.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 607 - let __ = _ifvalid(&(payload.first_name.len() > 0 && payload.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] 607 + _ifvalid(&(payload.first_name.len() > 0 && payload.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:607:33 [INFO] [stdout] | [INFO] [stdout] 607 | let __ = _ifvalid(&(payload.first_name.len() > 0 && payload.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!payload.first_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:607:65 [INFO] [stdout] | [INFO] [stdout] 607 | let __ = _ifvalid(&(payload.first_name.len() > 0 && payload.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!payload.last_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:626:13 [INFO] [stdout] | [INFO] [stdout] 626 | let _ = _ifvalid(&(staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 626 - let _ = _ifvalid(&(staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 626 + _ifvalid(&(staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:627:13 [INFO] [stdout] | [INFO] [stdout] 627 | / let _ = _ifvalid(&(payload.name.len() > 0 && payload.description.len() > 0 && payload.minimum_reservation > 0 && [INFO] [stdout] 628 | | payload.maximum_reservation > payload.minimum_reservation && payload.price_per_item > 0 && [INFO] [stdout] 629 | | payload.reservation_valid_duration > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | |____________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 627 - let _ = _ifvalid(&(payload.name.len() > 0 && payload.description.len() > 0 && payload.minimum_reservation > 0 && [INFO] [stdout] 627 + _ifvalid(&(payload.name.len() > 0 && payload.description.len() > 0 && payload.minimum_reservation > 0 && [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:627:32 [INFO] [stdout] | [INFO] [stdout] 627 | let _ = _ifvalid(&(payload.name.len() > 0 && payload.description.len() > 0 && payload.minimum_reservation > 0 && [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!payload.name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:627:58 [INFO] [stdout] | [INFO] [stdout] 627 | let _ = _ifvalid(&(payload.name.len() > 0 && payload.description.len() > 0 && payload.minimum_reservation > 0 && [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!payload.description.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:661:21 [INFO] [stdout] | [INFO] [stdout] 661 | ... let _ = _ifvalid(&(Some(caller()) == reservation.client_address), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 661 - let _ = _ifvalid(&(Some(caller()) == reservation.client_address), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 661 + _ifvalid(&(Some(caller()) == reservation.client_address), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:662:21 [INFO] [stdout] | [INFO] [stdout] 662 | ... let __ = _ifvalid(&(reservation.invalid_at > time() && !reservation.serve), "Reservation Outdated Or Has been Proccessed".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 662 - let __ = _ifvalid(&(reservation.invalid_at > time() && !reservation.serve), "Reservation Outdated Or Has been Proccessed".to_string())?; [INFO] [stdout] 662 + _ifvalid(&(reservation.invalid_at > time() && !reservation.serve), "Reservation Outdated Or Has been Proccessed".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:666:29 [INFO] [stdout] | [INFO] [stdout] 666 | / ... let ___ = _ifvalid(&(product.maximum_reservation >= payload.reserve && payload.reserve >= product.minimum_reservation [INFO] [stdout] 667 | | ... && payload.description.len() > 0),"Invalid Payload For Reservations".to_string())?; [INFO] [stdout] | |_________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 666 - let ___ = _ifvalid(&(product.maximum_reservation >= payload.reserve && payload.reserve >= product.minimum_reservation [INFO] [stdout] 666 + _ifvalid(&(product.maximum_reservation >= payload.reserve && payload.reserve >= product.minimum_reservation [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:667:32 [INFO] [stdout] | [INFO] [stdout] 667 | ... && payload.description.len() > 0),"Invalid Payload For Reservations".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!payload.description.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:668:29 [INFO] [stdout] | [INFO] [stdout] 668 | / ... let ____ = _ifvalid(&((product.reservations + reservation.reserve) - payload.reserve > 0 ), [INFO] [stdout] 669 | | ... "Insufficent Product In Reserve For Reservations".to_string())?; [INFO] [stdout] | |______________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 668 - let ____ = _ifvalid(&((product.reservations + reservation.reserve) - payload.reserve > 0 ), [INFO] [stdout] 668 + _ifvalid(&((product.reservations + reservation.reserve) - payload.reserve > 0 ), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:677:29 [INFO] [stdout] | [INFO] [stdout] 677 | / ... match idx { [INFO] [stdout] 678 | | ... Some(va) => { product.r_requests.remove(va); [INFO] [stdout] 679 | | ... product.r_requests.insert(va, reservation.clone())}, [INFO] [stdout] 680 | | ... None => (), [INFO] [stdout] 681 | | ... }; [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 677 ~ if let Some(va) = idx { product.r_requests.remove(va); [INFO] [stdout] 678 ~ product.r_requests.insert(va, reservation.clone())}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:683:29 [INFO] [stdout] | [INFO] [stdout] 683 | / ... match cidx { [INFO] [stdout] 684 | | ... Some(va) => {client.reservations.remove(va); [INFO] [stdout] 685 | | ... client.reservations.insert(va, reservation.clone());}, [INFO] [stdout] 686 | | ... None => (), [INFO] [stdout] 687 | | ... }; [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 683 ~ if let Some(va) = cidx {client.reservations.remove(va); [INFO] [stdout] 684 ~ client.reservations.insert(va, reservation.clone());}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:716:13 [INFO] [stdout] | [INFO] [stdout] 716 | ... let _ = _ifvalid(&(owner == caller() || staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 716 - let _ = _ifvalid(&(owner == caller() || staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 716 + _ifvalid(&(owner == caller() || staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:733:13 [INFO] [stdout] | [INFO] [stdout] 733 | let _ = _ifvalid(&(client.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 733 - let _ = _ifvalid(&(client.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 733 + _ifvalid(&(client.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:736:21 [INFO] [stdout] | [INFO] [stdout] 736 | / match _get_product(&rev.product_id) { [INFO] [stdout] 737 | | Some (mut product) =>{ [INFO] [stdout] 738 | | let idx = product.r_requests.iter().position(|rv| rv.id == rev.id); [INFO] [stdout] 739 | | match idx { [INFO] [stdout] ... | [INFO] [stdout] 747 | | None => () [INFO] [stdout] 748 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 736 ~ if let Some (mut product) = _get_product(&rev.product_id) { [INFO] [stdout] 737 + let idx = product.r_requests.iter().position(|rv| rv.id == rev.id); [INFO] [stdout] 738 + match idx { [INFO] [stdout] 739 + Some(va) => { product.r_requests.remove(va);}, [INFO] [stdout] 740 + None => (), [INFO] [stdout] 741 + }; [INFO] [stdout] 742 + product.reservations += rev.reserve; [INFO] [stdout] 743 + product.reservations_requests -= rev.reserve; [INFO] [stdout] 744 + do_insert_product(&product); [INFO] [stdout] 745 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:739:29 [INFO] [stdout] | [INFO] [stdout] 739 | / ... match idx { [INFO] [stdout] 740 | | ... Some(va) => { product.r_requests.remove(va);}, [INFO] [stdout] 741 | | ... None => (), [INFO] [stdout] 742 | | ... }; [INFO] [stdout] | |_______________________^ help: try: `if let Some(va) = idx { product.r_requests.remove(va);}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:772:40 [INFO] [stdout] | [INFO] [stdout] 772 | let __ = _ifvalid(&(!idx.is_some()), "This Product Still Holds a Valid Reservation".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `idx.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:768:13 [INFO] [stdout] | [INFO] [stdout] 768 | let _ = _ifvalid(&(staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 768 - let _ = _ifvalid(&(staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 768 + _ifvalid(&(staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:772:21 [INFO] [stdout] | [INFO] [stdout] 772 | let __ = _ifvalid(&(!idx.is_some()), "This Product Still Holds a Valid Reservation".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 772 - let __ = _ifvalid(&(!idx.is_some()), "This Product Still Holds a Valid Reservation".to_string())?; [INFO] [stdout] 772 + _ifvalid(&(!idx.is_some()), "This Product Still Holds a Valid Reservation".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:793:13 [INFO] [stdout] | [INFO] [stdout] 793 | let _ = _ifvalid(&(Some(caller()) == client.client_address), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 793 - let _ = _ifvalid(&(Some(caller()) == client.client_address), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 793 + _ifvalid(&(Some(caller()) == client.client_address), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:795:12 [INFO] [stdout] | [INFO] [stdout] 795 | let __ = _ifvalid(&(idx.is_some()), "Invalid Reservation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 795 - let __ = _ifvalid(&(idx.is_some()), "Invalid Reservation For Caller".to_string())?; [INFO] [stdout] 795 + _ifvalid(&(idx.is_some()), "Invalid Reservation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:798:21 [INFO] [stdout] | [INFO] [stdout] 798 | ... let ___ = _ifvalid(&(reservation.client_address == client.client_address), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 798 - let ___ = _ifvalid(&(reservation.client_address == client.client_address), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 798 + _ifvalid(&(reservation.client_address == client.client_address), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:799:21 [INFO] [stdout] | [INFO] [stdout] 799 | / let ____ = _ifvalid(&(!reservation.serve && reservation.invalid_at > time()), [INFO] [stdout] 800 | | "Reservation has been attended to or outdated consider deleting".to_string())?; [INFO] [stdout] | |____________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 799 - let ____ = _ifvalid(&(!reservation.serve && reservation.invalid_at > time()), [INFO] [stdout] 799 + _ifvalid(&(!reservation.serve && reservation.invalid_at > time()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:805:53 [INFO] [stdout] | [INFO] [stdout] 805 | ... if idx.is_some(){_idx = match idx {None => 0, Some(va) => va}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `idx.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:810:55 [INFO] [stdout] | [INFO] [stdout] 810 | ... if cidx.is_some(){_cidx = match cidx {None => 0, Some(va) => va}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cidx.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:845:21 [INFO] [stdout] | [INFO] [stdout] 845 | ... let __ = _ifvalid(&(reservation.client_address == Some(caller())), "Unauthorized Operation for Caller()".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 845 - let __ = _ifvalid(&(reservation.client_address == Some(caller())), "Unauthorized Operation for Caller()".to_string())?; [INFO] [stdout] 845 + _ifvalid(&(reservation.client_address == Some(caller())), "Unauthorized Operation for Caller()".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:846:21 [INFO] [stdout] | [INFO] [stdout] 846 | / let ___ = _ifvalid(&(reservation.serve || reservation.invalid_at < time()), [INFO] [stdout] 847 | | "This Reservation Is Still Valid Consider Cancling The Reservation".to_string())?; [INFO] [stdout] | |__________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 846 - let ___ = _ifvalid(&(reservation.serve || reservation.invalid_at < time()), [INFO] [stdout] 846 + _ifvalid(&(reservation.serve || reservation.invalid_at < time()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:850:47 [INFO] [stdout] | [INFO] [stdout] 850 | if cidx.is_some(){_cidx = match cidx {None => 0, Some(va) => va}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cidx.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:882:24 [INFO] [stdout] | [INFO] [stdout] 882 | match _get_product(&id) { [INFO] [stdout] | ^^^ help: change this to: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:76:17 [INFO] [stdout] | [INFO] [stdout] 76 | fn to_bytes(&self) -> std::borrow::Cow<[u8]> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 76 | fn to_bytes(&self) -> std::borrow::Cow<'_, [u8]> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:86:17 [INFO] [stdout] | [INFO] [stdout] 86 | fn to_bytes(&self) -> std::borrow::Cow<[u8]> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 86 | fn to_bytes(&self) -> std::borrow::Cow<'_, [u8]> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:96:17 [INFO] [stdout] | [INFO] [stdout] 96 | fn to_bytes(&self) -> std::borrow::Cow<[u8]> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 96 | fn to_bytes(&self) -> std::borrow::Cow<'_, [u8]> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 106 | fn to_bytes(&self) -> std::borrow::Cow<[u8]> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 106 | fn to_bytes(&self) -> std::borrow::Cow<'_, [u8]> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: initializer for `thread_local` value can be made `const` [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:148:42 [INFO] [stdout] | [INFO] [stdout] 148 | static OWNER: OtherCell = OtherCell::new(Principal::from_slice(&[])); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `const { OtherCell::new(Principal::from_slice(&[])) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_thread_local [INFO] [stdout] = note: `#[warn(clippy::missing_const_for_thread_local)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:245:13 [INFO] [stdout] | [INFO] [stdout] 245 | ... let _ = _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 245 - let _ = _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 245 + _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:288:13 [INFO] [stdout] | [INFO] [stdout] 288 | ... let ___ = _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 288 - let ___ = _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 288 + _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:303:13 [INFO] [stdout] | [INFO] [stdout] 303 | ... let ___ = _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 303 - let ___ = _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 303 + _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:317:13 [INFO] [stdout] | [INFO] [stdout] 317 | let _ = _ifvalid(&(reservation.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 317 - let _ = _ifvalid(&(reservation.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 317 + _ifvalid(&(reservation.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:332:13 [INFO] [stdout] | [INFO] [stdout] 332 | ... let ___ = _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 332 - let ___ = _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 332 + _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:346:13 [INFO] [stdout] | [INFO] [stdout] 346 | let _ = _ifvalid(&(client.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 346 - let _ = _ifvalid(&(client.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 346 + _ifvalid(&(client.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:361:13 [INFO] [stdout] | [INFO] [stdout] 361 | ... let ___ = _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 361 - let ___ = _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 361 + _ifvalid(&(staff.staff_address == Some(caller()) || owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:375:5 [INFO] [stdout] | [INFO] [stdout] 375 | let _ = _ifvalid(&(owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 375 - let _ = _ifvalid(&(owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 375 + _ifvalid(&(owner == caller()), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:376:5 [INFO] [stdout] | [INFO] [stdout] 376 | / let __ = _ifvalid(&(staff.staff_address.is_some() && staff.first_name.len() > 0 && [INFO] [stdout] 377 | | staff.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | |___________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 376 - let __ = _ifvalid(&(staff.staff_address.is_some() && staff.first_name.len() > 0 && [INFO] [stdout] 376 + _ifvalid(&(staff.staff_address.is_some() && staff.first_name.len() > 0 && [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:376:58 [INFO] [stdout] | [INFO] [stdout] 376 | let __ = _ifvalid(&(staff.staff_address.is_some() && staff.first_name.len() > 0 && [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!staff.first_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:377:9 [INFO] [stdout] | [INFO] [stdout] 377 | staff.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!staff.last_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:382:18 [INFO] [stdout] | [INFO] [stdout] 382 | msg: format!("could not create a staff")}), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"could not create a staff".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:407:5 [INFO] [stdout] | [INFO] [stdout] 407 | let __ = _ifvalid(&(client.first_name.len() > 0 && client.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 407 - let __ = _ifvalid(&(client.first_name.len() > 0 && client.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] 407 + _ifvalid(&(client.first_name.len() > 0 && client.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:407:25 [INFO] [stdout] | [INFO] [stdout] 407 | let __ = _ifvalid(&(client.first_name.len() > 0 && client.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!client.first_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:407:56 [INFO] [stdout] | [INFO] [stdout] 407 | let __ = _ifvalid(&(client.first_name.len() > 0 && client.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!client.last_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:427:13 [INFO] [stdout] | [INFO] [stdout] 427 | let _ = _ifvalid(&(staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 427 - let _ = _ifvalid(&(staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 427 + _ifvalid(&(staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:428:13 [INFO] [stdout] | [INFO] [stdout] 428 | / let _ = _ifvalid(&(product.name.len() > 0 && product.description.len() > 0 && product.minimum_reservation > 0 && [INFO] [stdout] 429 | | product.maximum_reservation > product.minimum_reservation && product.price_per_item > 0 && [INFO] [stdout] 430 | | product.reservation_valid_duration > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | |____________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 428 - let _ = _ifvalid(&(product.name.len() > 0 && product.description.len() > 0 && product.minimum_reservation > 0 && [INFO] [stdout] 428 + _ifvalid(&(product.name.len() > 0 && product.description.len() > 0 && product.minimum_reservation > 0 && [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:428:32 [INFO] [stdout] | [INFO] [stdout] 428 | let _ = _ifvalid(&(product.name.len() > 0 && product.description.len() > 0 && product.minimum_reservation > 0 && [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!product.name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:428:58 [INFO] [stdout] | [INFO] [stdout] 428 | let _ = _ifvalid(&(product.name.len() > 0 && product.description.len() > 0 && product.minimum_reservation > 0 && [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!product.description.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:457:13 [INFO] [stdout] | [INFO] [stdout] 457 | let _ = _ifvalid(&(staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 457 - let _ = _ifvalid(&(staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 457 + _ifvalid(&(staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:458:13 [INFO] [stdout] | [INFO] [stdout] 458 | let __ = _ifvalid(&(payload.reservations > 0), "Insufficent Payload For Reservations".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 458 - let __ = _ifvalid(&(payload.reservations > 0), "Insufficent Payload For Reservations".to_string())?; [INFO] [stdout] 458 + _ifvalid(&(payload.reservations > 0), "Insufficent Payload For Reservations".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:484:13 [INFO] [stdout] | [INFO] [stdout] 484 | let ___ = _ifvalid(&(client.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 484 - let ___ = _ifvalid(&(client.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 484 + _ifvalid(&(client.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:488:20 [INFO] [stdout] | [INFO] [stdout] 488 | / ... let _ = _ifvalid(&(product.maximum_reservation >= payload.reserve && payload.reserve >= product.minimum_reservation [INFO] [stdout] 489 | | ... && payload.description.len() > 0),"Invalid Payload For Reservations".to_string())?; [INFO] [stdout] | |__________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 488 - let _ = _ifvalid(&(product.maximum_reservation >= payload.reserve && payload.reserve >= product.minimum_reservation [INFO] [stdout] 488 + _ifvalid(&(product.maximum_reservation >= payload.reserve && payload.reserve >= product.minimum_reservation [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:489:24 [INFO] [stdout] | [INFO] [stdout] 489 | && payload.description.len() > 0),"Invalid Payload For Reservations".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!payload.description.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:490:20 [INFO] [stdout] | [INFO] [stdout] 490 | / let __ = _ifvalid(&(product.reservations - payload.reserve > 0), [INFO] [stdout] 491 | | "Insufficent Product In Reserve For Reservations".to_string())?; [INFO] [stdout] | |________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 490 - let __ = _ifvalid(&(product.reservations - payload.reserve > 0), [INFO] [stdout] 490 + _ifvalid(&(product.reservations - payload.reserve > 0), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:528:13 [INFO] [stdout] | [INFO] [stdout] 528 | let _ = _ifvalid(&(staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 528 - let _ = _ifvalid(&(staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 528 + _ifvalid(&(staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:532:21 [INFO] [stdout] | [INFO] [stdout] 532 | let __ = _ifvalid(&(idx.is_some()), "Invalid Reservation For the Client".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 532 - let __ = _ifvalid(&(idx.is_some()), "Invalid Reservation For the Client".to_string())?; [INFO] [stdout] 532 + _ifvalid(&(idx.is_some()), "Invalid Reservation For the Client".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:535:28 [INFO] [stdout] | [INFO] [stdout] 535 | ... let __ = _ifvalid(&(!reservation.serve && reservation.invalid_at >= time()), "Reservation Has been Attended To Or Oudated".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 535 - let __ = _ifvalid(&(!reservation.serve && reservation.invalid_at >= time()), "Reservation Has been Attended To Or Oudated".to_string())?; [INFO] [stdout] 535 + _ifvalid(&(!reservation.serve && reservation.invalid_at >= time()), "Reservation Has been Attended To Or Oudated".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:543:37 [INFO] [stdout] | [INFO] [stdout] 543 | / ... match idx { [INFO] [stdout] 544 | | ... Some(va) => { product.r_requests.remove(va); [INFO] [stdout] 545 | | ... product.r_requests.insert(va, reservation.clone()) [INFO] [stdout] 546 | | ... }, [INFO] [stdout] 547 | | ... None => ()}; [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 543 ~ if let Some(va) = idx { product.r_requests.remove(va); [INFO] [stdout] 544 + product.r_requests.insert(va, reservation.clone()) [INFO] [stdout] 545 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:549:37 [INFO] [stdout] | [INFO] [stdout] 549 | / ... match cidx { [INFO] [stdout] 550 | | ... Some(va) => {client.reservations.remove(va); [INFO] [stdout] 551 | | ... client.reservations.insert(va, reservation.clone());}, [INFO] [stdout] 552 | | ... None => ()}; [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 549 ~ if let Some(va) = cidx {client.reservations.remove(va); [INFO] [stdout] 550 ~ client.reservations.insert(va, reservation.clone());}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:584:13 [INFO] [stdout] | [INFO] [stdout] 584 | let _ = _ifvalid(&(Some(caller()) == staff.staff_address), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 584 - let _ = _ifvalid(&(Some(caller()) == staff.staff_address), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 584 + _ifvalid(&(Some(caller()) == staff.staff_address), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:585:13 [INFO] [stdout] | [INFO] [stdout] 585 | / let __ = _ifvalid(&(payload.staff_address.is_some() && payload.first_name.len() > 0 && [INFO] [stdout] 586 | | payload.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | |_________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 585 - let __ = _ifvalid(&(payload.staff_address.is_some() && payload.first_name.len() > 0 && [INFO] [stdout] 585 + _ifvalid(&(payload.staff_address.is_some() && payload.first_name.len() > 0 && [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:585:68 [INFO] [stdout] | [INFO] [stdout] 585 | let __ = _ifvalid(&(payload.staff_address.is_some() && payload.first_name.len() > 0 && [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!payload.first_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:586:13 [INFO] [stdout] | [INFO] [stdout] 586 | payload.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!payload.last_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:606:13 [INFO] [stdout] | [INFO] [stdout] 606 | let _ = _ifvalid(&(client.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 606 - let _ = _ifvalid(&(client.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 606 + _ifvalid(&(client.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:607:13 [INFO] [stdout] | [INFO] [stdout] 607 | let __ = _ifvalid(&(payload.first_name.len() > 0 && payload.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 607 - let __ = _ifvalid(&(payload.first_name.len() > 0 && payload.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] 607 + _ifvalid(&(payload.first_name.len() > 0 && payload.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:607:33 [INFO] [stdout] | [INFO] [stdout] 607 | let __ = _ifvalid(&(payload.first_name.len() > 0 && payload.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!payload.first_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:607:65 [INFO] [stdout] | [INFO] [stdout] 607 | let __ = _ifvalid(&(payload.first_name.len() > 0 && payload.last_name.len() > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!payload.last_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:626:13 [INFO] [stdout] | [INFO] [stdout] 626 | let _ = _ifvalid(&(staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 626 - let _ = _ifvalid(&(staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 626 + _ifvalid(&(staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:627:13 [INFO] [stdout] | [INFO] [stdout] 627 | / let _ = _ifvalid(&(payload.name.len() > 0 && payload.description.len() > 0 && payload.minimum_reservation > 0 && [INFO] [stdout] 628 | | payload.maximum_reservation > payload.minimum_reservation && payload.price_per_item > 0 && [INFO] [stdout] 629 | | payload.reservation_valid_duration > 0), "Invalid Input Provided".to_string())?; [INFO] [stdout] | |____________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 627 - let _ = _ifvalid(&(payload.name.len() > 0 && payload.description.len() > 0 && payload.minimum_reservation > 0 && [INFO] [stdout] 627 + _ifvalid(&(payload.name.len() > 0 && payload.description.len() > 0 && payload.minimum_reservation > 0 && [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:627:32 [INFO] [stdout] | [INFO] [stdout] 627 | let _ = _ifvalid(&(payload.name.len() > 0 && payload.description.len() > 0 && payload.minimum_reservation > 0 && [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!payload.name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:627:58 [INFO] [stdout] | [INFO] [stdout] 627 | let _ = _ifvalid(&(payload.name.len() > 0 && payload.description.len() > 0 && payload.minimum_reservation > 0 && [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!payload.description.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:661:21 [INFO] [stdout] | [INFO] [stdout] 661 | ... let _ = _ifvalid(&(Some(caller()) == reservation.client_address), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 661 - let _ = _ifvalid(&(Some(caller()) == reservation.client_address), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 661 + _ifvalid(&(Some(caller()) == reservation.client_address), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:662:21 [INFO] [stdout] | [INFO] [stdout] 662 | ... let __ = _ifvalid(&(reservation.invalid_at > time() && !reservation.serve), "Reservation Outdated Or Has been Proccessed".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 662 - let __ = _ifvalid(&(reservation.invalid_at > time() && !reservation.serve), "Reservation Outdated Or Has been Proccessed".to_string())?; [INFO] [stdout] 662 + _ifvalid(&(reservation.invalid_at > time() && !reservation.serve), "Reservation Outdated Or Has been Proccessed".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:666:29 [INFO] [stdout] | [INFO] [stdout] 666 | / ... let ___ = _ifvalid(&(product.maximum_reservation >= payload.reserve && payload.reserve >= product.minimum_reservation [INFO] [stdout] 667 | | ... && payload.description.len() > 0),"Invalid Payload For Reservations".to_string())?; [INFO] [stdout] | |_________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 666 - let ___ = _ifvalid(&(product.maximum_reservation >= payload.reserve && payload.reserve >= product.minimum_reservation [INFO] [stdout] 666 + _ifvalid(&(product.maximum_reservation >= payload.reserve && payload.reserve >= product.minimum_reservation [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:667:32 [INFO] [stdout] | [INFO] [stdout] 667 | ... && payload.description.len() > 0),"Invalid Payload For Reservations".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!payload.description.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:668:29 [INFO] [stdout] | [INFO] [stdout] 668 | / ... let ____ = _ifvalid(&((product.reservations + reservation.reserve) - payload.reserve > 0 ), [INFO] [stdout] 669 | | ... "Insufficent Product In Reserve For Reservations".to_string())?; [INFO] [stdout] | |______________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 668 - let ____ = _ifvalid(&((product.reservations + reservation.reserve) - payload.reserve > 0 ), [INFO] [stdout] 668 + _ifvalid(&((product.reservations + reservation.reserve) - payload.reserve > 0 ), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:677:29 [INFO] [stdout] | [INFO] [stdout] 677 | / ... match idx { [INFO] [stdout] 678 | | ... Some(va) => { product.r_requests.remove(va); [INFO] [stdout] 679 | | ... product.r_requests.insert(va, reservation.clone())}, [INFO] [stdout] 680 | | ... None => (), [INFO] [stdout] 681 | | ... }; [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 677 ~ if let Some(va) = idx { product.r_requests.remove(va); [INFO] [stdout] 678 ~ product.r_requests.insert(va, reservation.clone())}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:683:29 [INFO] [stdout] | [INFO] [stdout] 683 | / ... match cidx { [INFO] [stdout] 684 | | ... Some(va) => {client.reservations.remove(va); [INFO] [stdout] 685 | | ... client.reservations.insert(va, reservation.clone());}, [INFO] [stdout] 686 | | ... None => (), [INFO] [stdout] 687 | | ... }; [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 683 ~ if let Some(va) = cidx {client.reservations.remove(va); [INFO] [stdout] 684 ~ client.reservations.insert(va, reservation.clone());}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:716:13 [INFO] [stdout] | [INFO] [stdout] 716 | ... let _ = _ifvalid(&(owner == caller() || staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 716 - let _ = _ifvalid(&(owner == caller() || staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 716 + _ifvalid(&(owner == caller() || staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:733:13 [INFO] [stdout] | [INFO] [stdout] 733 | let _ = _ifvalid(&(client.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 733 - let _ = _ifvalid(&(client.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 733 + _ifvalid(&(client.client_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:736:21 [INFO] [stdout] | [INFO] [stdout] 736 | / match _get_product(&rev.product_id) { [INFO] [stdout] 737 | | Some (mut product) =>{ [INFO] [stdout] 738 | | let idx = product.r_requests.iter().position(|rv| rv.id == rev.id); [INFO] [stdout] 739 | | match idx { [INFO] [stdout] ... | [INFO] [stdout] 747 | | None => () [INFO] [stdout] 748 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 736 ~ if let Some (mut product) = _get_product(&rev.product_id) { [INFO] [stdout] 737 + let idx = product.r_requests.iter().position(|rv| rv.id == rev.id); [INFO] [stdout] 738 + match idx { [INFO] [stdout] 739 + Some(va) => { product.r_requests.remove(va);}, [INFO] [stdout] 740 + None => (), [INFO] [stdout] 741 + }; [INFO] [stdout] 742 + product.reservations += rev.reserve; [INFO] [stdout] 743 + product.reservations_requests -= rev.reserve; [INFO] [stdout] 744 + do_insert_product(&product); [INFO] [stdout] 745 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:739:29 [INFO] [stdout] | [INFO] [stdout] 739 | / ... match idx { [INFO] [stdout] 740 | | ... Some(va) => { product.r_requests.remove(va);}, [INFO] [stdout] 741 | | ... None => (), [INFO] [stdout] 742 | | ... }; [INFO] [stdout] | |_______________________^ help: try: `if let Some(va) = idx { product.r_requests.remove(va);}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:772:40 [INFO] [stdout] | [INFO] [stdout] 772 | let __ = _ifvalid(&(!idx.is_some()), "This Product Still Holds a Valid Reservation".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `idx.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:768:13 [INFO] [stdout] | [INFO] [stdout] 768 | let _ = _ifvalid(&(staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 768 - let _ = _ifvalid(&(staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 768 + _ifvalid(&(staff.staff_address == Some(caller())), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:772:21 [INFO] [stdout] | [INFO] [stdout] 772 | let __ = _ifvalid(&(!idx.is_some()), "This Product Still Holds a Valid Reservation".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 772 - let __ = _ifvalid(&(!idx.is_some()), "This Product Still Holds a Valid Reservation".to_string())?; [INFO] [stdout] 772 + _ifvalid(&(!idx.is_some()), "This Product Still Holds a Valid Reservation".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:793:13 [INFO] [stdout] | [INFO] [stdout] 793 | let _ = _ifvalid(&(Some(caller()) == client.client_address), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 793 - let _ = _ifvalid(&(Some(caller()) == client.client_address), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 793 + _ifvalid(&(Some(caller()) == client.client_address), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:795:12 [INFO] [stdout] | [INFO] [stdout] 795 | let __ = _ifvalid(&(idx.is_some()), "Invalid Reservation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 795 - let __ = _ifvalid(&(idx.is_some()), "Invalid Reservation For Caller".to_string())?; [INFO] [stdout] 795 + _ifvalid(&(idx.is_some()), "Invalid Reservation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:798:21 [INFO] [stdout] | [INFO] [stdout] 798 | ... let ___ = _ifvalid(&(reservation.client_address == client.client_address), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 798 - let ___ = _ifvalid(&(reservation.client_address == client.client_address), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] 798 + _ifvalid(&(reservation.client_address == client.client_address), "Unauthorized Operation For Caller".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:799:21 [INFO] [stdout] | [INFO] [stdout] 799 | / let ____ = _ifvalid(&(!reservation.serve && reservation.invalid_at > time()), [INFO] [stdout] 800 | | "Reservation has been attended to or outdated consider deleting".to_string())?; [INFO] [stdout] | |____________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 799 - let ____ = _ifvalid(&(!reservation.serve && reservation.invalid_at > time()), [INFO] [stdout] 799 + _ifvalid(&(!reservation.serve && reservation.invalid_at > time()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:805:53 [INFO] [stdout] | [INFO] [stdout] 805 | ... if idx.is_some(){_idx = match idx {None => 0, Some(va) => va}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `idx.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:810:55 [INFO] [stdout] | [INFO] [stdout] 810 | ... if cidx.is_some(){_cidx = match cidx {None => 0, Some(va) => va}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cidx.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:845:21 [INFO] [stdout] | [INFO] [stdout] 845 | ... let __ = _ifvalid(&(reservation.client_address == Some(caller())), "Unauthorized Operation for Caller()".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 845 - let __ = _ifvalid(&(reservation.client_address == Some(caller())), "Unauthorized Operation for Caller()".to_string())?; [INFO] [stdout] 845 + _ifvalid(&(reservation.client_address == Some(caller())), "Unauthorized Operation for Caller()".to_string())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:846:21 [INFO] [stdout] | [INFO] [stdout] 846 | / let ___ = _ifvalid(&(reservation.serve || reservation.invalid_at < time()), [INFO] [stdout] 847 | | "This Reservation Is Still Valid Consider Cancling The Reservation".to_string())?; [INFO] [stdout] | |__________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 846 - let ___ = _ifvalid(&(reservation.serve || reservation.invalid_at < time()), [INFO] [stdout] 846 + _ifvalid(&(reservation.serve || reservation.invalid_at < time()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:850:47 [INFO] [stdout] | [INFO] [stdout] 850 | if cidx.is_some(){_cidx = match cidx {None => 0, Some(va) => va}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cidx.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:882:24 [INFO] [stdout] | [INFO] [stdout] 882 | match _get_product(&id) { [INFO] [stdout] | ^^^ help: change this to: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:76:17 [INFO] [stdout] | [INFO] [stdout] 76 | fn to_bytes(&self) -> std::borrow::Cow<[u8]> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 76 | fn to_bytes(&self) -> std::borrow::Cow<'_, [u8]> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:86:17 [INFO] [stdout] | [INFO] [stdout] 86 | fn to_bytes(&self) -> std::borrow::Cow<[u8]> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 86 | fn to_bytes(&self) -> std::borrow::Cow<'_, [u8]> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:96:17 [INFO] [stdout] | [INFO] [stdout] 96 | fn to_bytes(&self) -> std::borrow::Cow<[u8]> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 96 | fn to_bytes(&self) -> std::borrow::Cow<'_, [u8]> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/warehouse_reservations_canister/src/lib.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 106 | fn to_bytes(&self) -> std::borrow::Cow<[u8]> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 106 | fn to_bytes(&self) -> std::borrow::Cow<'_, [u8]> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 33.44s [INFO] running `Command { std: "docker" "inspect" "33251a00c834b30b5a77a730cd805ef566b1315dc0f9e6bbcbf4997d72728e76", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "33251a00c834b30b5a77a730cd805ef566b1315dc0f9e6bbcbf4997d72728e76", kill_on_drop: false }` [INFO] [stdout] 33251a00c834b30b5a77a730cd805ef566b1315dc0f9e6bbcbf4997d72728e76