[INFO] cloning repository https://github.com/lukegude/yacd [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/lukegude/yacd" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flukegude%2Fyacd", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flukegude%2Fyacd'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1ec629efae378486dcea351a74d8213a2131151e [INFO] linting lukegude/yacd against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flukegude%2Fyacd" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/lukegude/yacd [INFO] finished tweaking git repo https://github.com/lukegude/yacd [INFO] tweaked toml for git repo https://github.com/lukegude/yacd written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/lukegude/yacd on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/lukegude/yacd already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded shell-words v0.1.0 [INFO] [stderr] Downloaded serde_derive v1.0.200 [INFO] [stderr] Downloaded serde v1.0.200 [INFO] [stderr] Downloaded libc v0.2.154 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c6a1d4f0f7c6502ee6c1fde7112305598279bf93c5b3d5a015c6b74a5c039a3c [INFO] running `Command { std: "docker" "start" "-a" "c6a1d4f0f7c6502ee6c1fde7112305598279bf93c5b3d5a015c6b74a5c039a3c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c6a1d4f0f7c6502ee6c1fde7112305598279bf93c5b3d5a015c6b74a5c039a3c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c6a1d4f0f7c6502ee6c1fde7112305598279bf93c5b3d5a015c6b74a5c039a3c", kill_on_drop: false }` [INFO] [stdout] c6a1d4f0f7c6502ee6c1fde7112305598279bf93c5b3d5a015c6b74a5c039a3c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e6cdda38e7eabc19ba52efaa0e5327ada85d216aeb446e4fc44c0ad9245344fd [INFO] running `Command { std: "docker" "start" "-a" "e6cdda38e7eabc19ba52efaa0e5327ada85d216aeb446e4fc44c0ad9245344fd", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling serde v1.0.200 [INFO] [stderr] Checking unicode-width v0.1.12 [INFO] [stderr] Compiling serde_json v1.0.116 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking shell-words v0.1.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Compiling serde_derive v1.0.200 [INFO] [stderr] Checking yacd v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:44:8 [INFO] [stdout] | [INFO] [stdout] 44 | if !fs::metadata(pipelines_file).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(pipelines_file).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:246:17 [INFO] [stdout] | [INFO] [stdout] 246 | / &pipeline [INFO] [stdout] 247 | | .docker_image_flags [INFO] [stdout] 248 | | .get(0) [INFO] [stdout] 249 | | .unwrap_or(&"".to_string()), [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 246 ~ pipeline [INFO] [stdout] 247 + .docker_image_flags [INFO] [stdout] 248 + .get(0) [INFO] [stdout] 249 ~ .unwrap_or(&"".to_string()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `pipeline [INFO] [stdout] .docker_image_flags.get(0)` [INFO] [stdout] --> src/main.rs:246:18 [INFO] [stdout] | [INFO] [stdout] 246 | &pipeline [INFO] [stdout] | __________________^ [INFO] [stdout] 247 | | .docker_image_flags [INFO] [stdout] 248 | | .get(0) [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 246 ~ &pipeline [INFO] [stdout] 247 + .docker_image_flags.first() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:252:17 [INFO] [stdout] | [INFO] [stdout] 252 | / &pipeline [INFO] [stdout] 253 | | .docker_image_flags [INFO] [stdout] 254 | | .get(1) [INFO] [stdout] 255 | | .unwrap_or(&"".to_string()), [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 252 ~ pipeline [INFO] [stdout] 253 + .docker_image_flags [INFO] [stdout] 254 + .get(1) [INFO] [stdout] 255 ~ .unwrap_or(&"".to_string()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:44:8 [INFO] [stdout] | [INFO] [stdout] 44 | if !fs::metadata(pipelines_file).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(pipelines_file).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:246:17 [INFO] [stdout] | [INFO] [stdout] 246 | / &pipeline [INFO] [stdout] 247 | | .docker_image_flags [INFO] [stdout] 248 | | .get(0) [INFO] [stdout] 249 | | .unwrap_or(&"".to_string()), [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 246 ~ pipeline [INFO] [stdout] 247 + .docker_image_flags [INFO] [stdout] 248 + .get(0) [INFO] [stdout] 249 ~ .unwrap_or(&"".to_string()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `pipeline [INFO] [stdout] .docker_image_flags.get(0)` [INFO] [stdout] --> src/main.rs:246:18 [INFO] [stdout] | [INFO] [stdout] 246 | &pipeline [INFO] [stdout] | __________________^ [INFO] [stdout] 247 | | .docker_image_flags [INFO] [stdout] 248 | | .get(0) [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 246 ~ &pipeline [INFO] [stdout] 247 + .docker_image_flags.first() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:252:17 [INFO] [stdout] | [INFO] [stdout] 252 | / &pipeline [INFO] [stdout] 253 | | .docker_image_flags [INFO] [stdout] 254 | | .get(1) [INFO] [stdout] 255 | | .unwrap_or(&"".to_string()), [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 252 ~ pipeline [INFO] [stdout] 253 + .docker_image_flags [INFO] [stdout] 254 + .get(1) [INFO] [stdout] 255 ~ .unwrap_or(&"".to_string()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.50s [INFO] running `Command { std: "docker" "inspect" "e6cdda38e7eabc19ba52efaa0e5327ada85d216aeb446e4fc44c0ad9245344fd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e6cdda38e7eabc19ba52efaa0e5327ada85d216aeb446e4fc44c0ad9245344fd", kill_on_drop: false }` [INFO] [stdout] e6cdda38e7eabc19ba52efaa0e5327ada85d216aeb446e4fc44c0ad9245344fd