[INFO] cloning repository https://github.com/luisfr364/pipconfig [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/luisfr364/pipconfig" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fluisfr364%2Fpipconfig", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fluisfr364%2Fpipconfig'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8db868fbe8db91aa871e6e7c23ee8913fa722bfe [INFO] linting luisfr364/pipconfig against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fluisfr364%2Fpipconfig" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/luisfr364/pipconfig [INFO] finished tweaking git repo https://github.com/luisfr364/pipconfig [INFO] tweaked toml for git repo https://github.com/luisfr364/pipconfig written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/luisfr364/pipconfig on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/luisfr364/pipconfig already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded gobject-sys v0.19.5 [INFO] [stderr] Downloaded glib-macros v0.19.5 [INFO] [stderr] Downloaded pango v0.19.5 [INFO] [stderr] Downloaded cairo-sys-rs v0.19.2 [INFO] [stderr] Downloaded gdk-pixbuf-sys v0.19.5 [INFO] [stderr] Downloaded gdk-pixbuf v0.19.2 [INFO] [stderr] Downloaded graphene-rs v0.19.2 [INFO] [stderr] Downloaded cairo-rs v0.19.4 [INFO] [stderr] Downloaded glib-sys v0.19.5 [INFO] [stderr] Downloaded gsk4 v0.8.2 [INFO] [stderr] Downloaded toml_edit v0.22.12 [INFO] [stderr] Downloaded winnow v0.6.8 [INFO] [stderr] Downloaded glib v0.19.6 [INFO] [stderr] Downloaded gdk4 v0.8.2 [INFO] [stderr] Downloaded gdk4-sys v0.8.2 [INFO] [stderr] Downloaded gtk4-sys v0.8.2 [INFO] [stderr] Downloaded gio-sys v0.19.5 [INFO] [stderr] Downloaded gtk4-macros v0.8.2 [INFO] [stderr] Downloaded gtk4 v0.8.2 [INFO] [stderr] Downloaded gio v0.19.5 [INFO] [stderr] Downloaded pango-sys v0.19.5 [INFO] [stderr] Downloaded graphene-sys v0.19.5 [INFO] [stderr] Downloaded gsk4-sys v0.8.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 881c40e5401552fcabada8a88d1bf250486ff4512a0ed93329a33a67d4c47ad3 [INFO] running `Command { std: "docker" "start" "-a" "881c40e5401552fcabada8a88d1bf250486ff4512a0ed93329a33a67d4c47ad3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "881c40e5401552fcabada8a88d1bf250486ff4512a0ed93329a33a67d4c47ad3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "881c40e5401552fcabada8a88d1bf250486ff4512a0ed93329a33a67d4c47ad3", kill_on_drop: false }` [INFO] [stdout] 881c40e5401552fcabada8a88d1bf250486ff4512a0ed93329a33a67d4c47ad3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c8e3663aa7ade36b456baa4627448f9fddd4f2b616280665ca53f0b4924decf2 [INFO] running `Command { std: "docker" "start" "-a" "c8e3663aa7ade36b456baa4627448f9fddd4f2b616280665ca53f0b4924decf2", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.202 [INFO] [stderr] Compiling winnow v0.6.8 [INFO] [stderr] Compiling smallvec v1.13.2 [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling syn v2.0.63 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling gio v0.19.5 [INFO] [stderr] Compiling field-offset v0.3.6 [INFO] [stderr] Compiling cfg-expr v0.15.8 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Compiling toml_datetime v0.6.5 [INFO] [stderr] Compiling serde_spanned v0.6.5 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.60 [INFO] [stderr] Compiling serde_derive v1.0.202 [INFO] [stderr] Compiling toml_edit v0.22.12 [INFO] [stderr] Compiling toml_edit v0.21.1 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking thiserror v1.0.60 [INFO] [stderr] Compiling proc-macro-crate v3.1.0 [INFO] [stderr] Compiling toml v0.8.12 [INFO] [stderr] Compiling glib-macros v0.19.5 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Compiling gtk4-macros v0.8.2 [INFO] [stderr] Compiling system-deps v6.2.2 [INFO] [stderr] Compiling glib-sys v0.19.5 [INFO] [stderr] Compiling gobject-sys v0.19.5 [INFO] [stderr] Compiling gio-sys v0.19.5 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.19.5 [INFO] [stderr] Compiling cairo-sys-rs v0.19.2 [INFO] [stderr] Compiling pango-sys v0.19.5 [INFO] [stderr] Compiling graphene-sys v0.19.5 [INFO] [stderr] Compiling gdk4-sys v0.8.2 [INFO] [stderr] Compiling gsk4-sys v0.8.2 [INFO] [stderr] Compiling gtk4-sys v0.8.2 [INFO] [stderr] Checking glib v0.19.6 [INFO] [stderr] Checking serde_json v1.0.117 [INFO] [stderr] Checking cairo-rs v0.19.4 [INFO] [stderr] Checking graphene-rs v0.19.2 [INFO] [stderr] Checking gdk-pixbuf v0.19.2 [INFO] [stderr] Checking pango v0.19.5 [INFO] [stderr] Checking gdk4 v0.8.2 [INFO] [stderr] Checking gsk4 v0.8.2 [INFO] [stderr] Checking gtk4 v0.8.2 [INFO] [stderr] Checking test_pipconfig v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/utils/backup_file.rs:10:42 [INFO] [stdout] | [INFO] [stdout] 10 | fs::write("../../pipewire.conf", configs.to_string()).expect("error creating the backup"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use: `&configs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/config_file.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return false; [INFO] [stdout] 30 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils/config_file.rs:28:36 [INFO] [stdout] | [INFO] [stdout] 28 | fs::write("../../config.json", &INITIAL_CONFIG).expect("file not found"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `INITIAL_CONFIG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/config_file.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | return data; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return data; [INFO] [stdout] 46 + data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/os_config.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | / return Err(io::Error::new( [INFO] [stdout] 32 | | io::ErrorKind::NotFound, [INFO] [stdout] 33 | | "No config file found", [INFO] [stdout] 34 | | )); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 ~ Err(io::Error::new( [INFO] [stdout] 32 + io::ErrorKind::NotFound, [INFO] [stdout] 33 + "No config file found", [INFO] [stdout] 34 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/os_config.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | / return Err(io::Error::new( [INFO] [stdout] 45 | | io::ErrorKind::NotFound, [INFO] [stdout] 46 | | "No config file found", [INFO] [stdout] 47 | | )); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 ~ Err(io::Error::new( [INFO] [stdout] 45 + io::ErrorKind::NotFound, [INFO] [stdout] 46 + "No config file found", [INFO] [stdout] 47 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/os_config.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | return Ok(contents); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return Ok(contents); [INFO] [stdout] 49 + Ok(contents) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/os_config.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | return return_value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return return_value; [INFO] [stdout] 72 + return_value [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/os_config.rs:67:40 [INFO] [stdout] | [INFO] [stdout] 67 | let captures = re.captures(&line).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/os_config.rs:98:41 [INFO] [stdout] | [INFO] [stdout] 98 | let _captures = re.captures(&line).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils/os_config.rs:133:8 [INFO] [stdout] | [INFO] [stdout] 133 | if !command_status.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `command_status.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/os_config.rs:137:5 [INFO] [stdout] | [INFO] [stdout] 137 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 137 - return Ok(()); [INFO] [stdout] 137 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/utils/os_config.rs:134:20 [INFO] [stdout] | [INFO] [stdout] 134 | return Err(std::io::Error::new(std::io::ErrorKind::Other, "failed to run command")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 134 - return Err(std::io::Error::new(std::io::ErrorKind::Other, "failed to run command")) [INFO] [stdout] 134 + return Err(std::io::Error::other("failed to run command")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/horizontal_box.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | return hbox; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return hbox; [INFO] [stdout] 43 + hbox [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/components/horizontal_box.rs:17:46 [INFO] [stdout] | [INFO] [stdout] 17 | let configuration_file_clone = Rc::clone(&configuration_file); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `configuration_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/restore_button.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | return button; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return button; [INFO] [stdout] 41 + button [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/save_button.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return button; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return button; [INFO] [stdout] 16 + button [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/components/save_button.rs:10:46 [INFO] [stdout] | [INFO] [stdout] 10 | let configuration_file_clone = Rc::clone(&configuration_file); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `configuration_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/components/save_button.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | &message.to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `message.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/utils/backup_file.rs:10:42 [INFO] [stdout] | [INFO] [stdout] 10 | fs::write("../../pipewire.conf", configs.to_string()).expect("error creating the backup"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use: `&configs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/config_file.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return false; [INFO] [stdout] 30 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils/config_file.rs:28:36 [INFO] [stdout] | [INFO] [stdout] 28 | fs::write("../../config.json", &INITIAL_CONFIG).expect("file not found"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `INITIAL_CONFIG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/config_file.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | return data; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return data; [INFO] [stdout] 46 + data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/os_config.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | / return Err(io::Error::new( [INFO] [stdout] 32 | | io::ErrorKind::NotFound, [INFO] [stdout] 33 | | "No config file found", [INFO] [stdout] 34 | | )); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 ~ Err(io::Error::new( [INFO] [stdout] 32 + io::ErrorKind::NotFound, [INFO] [stdout] 33 + "No config file found", [INFO] [stdout] 34 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/os_config.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | / return Err(io::Error::new( [INFO] [stdout] 45 | | io::ErrorKind::NotFound, [INFO] [stdout] 46 | | "No config file found", [INFO] [stdout] 47 | | )); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 ~ Err(io::Error::new( [INFO] [stdout] 45 + io::ErrorKind::NotFound, [INFO] [stdout] 46 + "No config file found", [INFO] [stdout] 47 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/os_config.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | return Ok(contents); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return Ok(contents); [INFO] [stdout] 49 + Ok(contents) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/os_config.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | return return_value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return return_value; [INFO] [stdout] 72 + return_value [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/os_config.rs:67:40 [INFO] [stdout] | [INFO] [stdout] 67 | let captures = re.captures(&line).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/os_config.rs:98:41 [INFO] [stdout] | [INFO] [stdout] 98 | let _captures = re.captures(&line).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils/os_config.rs:133:8 [INFO] [stdout] | [INFO] [stdout] 133 | if !command_status.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `command_status.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/os_config.rs:137:5 [INFO] [stdout] | [INFO] [stdout] 137 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 137 - return Ok(()); [INFO] [stdout] 137 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/utils/os_config.rs:134:20 [INFO] [stdout] | [INFO] [stdout] 134 | return Err(std::io::Error::new(std::io::ErrorKind::Other, "failed to run command")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 134 - return Err(std::io::Error::new(std::io::ErrorKind::Other, "failed to run command")) [INFO] [stdout] 134 + return Err(std::io::Error::other("failed to run command")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/horizontal_box.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | return hbox; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return hbox; [INFO] [stdout] 43 + hbox [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/components/horizontal_box.rs:17:46 [INFO] [stdout] | [INFO] [stdout] 17 | let configuration_file_clone = Rc::clone(&configuration_file); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `configuration_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/restore_button.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | return button; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return button; [INFO] [stdout] 41 + button [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/components/save_button.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return button; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return button; [INFO] [stdout] 16 + button [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/components/save_button.rs:10:46 [INFO] [stdout] | [INFO] [stdout] 10 | let configuration_file_clone = Rc::clone(&configuration_file); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `configuration_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/components/save_button.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | &message.to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `message.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 33s [INFO] running `Command { std: "docker" "inspect" "c8e3663aa7ade36b456baa4627448f9fddd4f2b616280665ca53f0b4924decf2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c8e3663aa7ade36b456baa4627448f9fddd4f2b616280665ca53f0b4924decf2", kill_on_drop: false }` [INFO] [stdout] c8e3663aa7ade36b456baa4627448f9fddd4f2b616280665ca53f0b4924decf2