[INFO] cloning repository https://github.com/lucasmelodev1/spk [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/lucasmelodev1/spk" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flucasmelodev1%2Fspk", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flucasmelodev1%2Fspk'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b5d5afbd738d325421538d66ae06cce181a31dd8 [INFO] linting lucasmelodev1/spk against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flucasmelodev1%2Fspk" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/lucasmelodev1/spk [INFO] finished tweaking git repo https://github.com/lucasmelodev1/spk [INFO] tweaked toml for git repo https://github.com/lucasmelodev1/spk written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/lucasmelodev1/spk on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/lucasmelodev1/spk already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 532009b854381300d8fdcab024d0a79db885c83a7512df55a9e39d0c04a727ef [INFO] running `Command { std: "docker" "start" "-a" "532009b854381300d8fdcab024d0a79db885c83a7512df55a9e39d0c04a727ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "532009b854381300d8fdcab024d0a79db885c83a7512df55a9e39d0c04a727ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "532009b854381300d8fdcab024d0a79db885c83a7512df55a9e39d0c04a727ef", kill_on_drop: false }` [INFO] [stdout] 532009b854381300d8fdcab024d0a79db885c83a7512df55a9e39d0c04a727ef [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 620c4679fc5db91a3704881efbfa33fac84966e825bc8879e41ad1e426ab4dc0 [INFO] running `Command { std: "docker" "start" "-a" "620c4679fc5db91a3704881efbfa33fac84966e825bc8879e41ad1e426ab4dc0", kill_on_drop: false }` [INFO] [stderr] Checking spk v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | / return Flags { [INFO] [stdout] 32 | | enable_backslash_commands: false [INFO] [stdout] 33 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 ~ Flags { [INFO] [stdout] 32 + enable_backslash_commands: false [INFO] [stdout] 33 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:83:12 [INFO] [stdout] | [INFO] [stdout] 83 | if !(str[0] == b'-') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(str[0] != b'-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:78:16 [INFO] [stdout] | [INFO] [stdout] 78 | fn flags(args: &Vec) -> (Flags, Option) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 78 - fn flags(args: &Vec) -> (Flags, Option) { [INFO] [stdout] 78 + fn flags(args: &[String]) -> (Flags, Option) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | / match str[1..] { [INFO] [stdout] 88 | | [b'e'] => arguments.enable_backslash_commands = true, [INFO] [stdout] 89 | | _ => (), [INFO] [stdout] 90 | | } [INFO] [stdout] | |_________^ help: try: `if let [b'e'] = str[1..] { arguments.enable_backslash_commands = true }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:106:5 [INFO] [stdout] | [INFO] [stdout] 106 | / match args_start { [INFO] [stdout] 107 | | Some(start) => { [INFO] [stdout] 108 | | for arg in &args[start..] { [INFO] [stdout] 109 | | print!("{arg} ") [INFO] [stdout] ... | [INFO] [stdout] 112 | | None => (), [INFO] [stdout] 113 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 106 ~ if let Some(start) = args_start { [INFO] [stdout] 107 + for arg in &args[start..] { [INFO] [stdout] 108 + print!("{arg} ") [INFO] [stdout] 109 + } [INFO] [stdout] 110 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | / return Flags { [INFO] [stdout] 32 | | enable_backslash_commands: false [INFO] [stdout] 33 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 ~ Flags { [INFO] [stdout] 32 + enable_backslash_commands: false [INFO] [stdout] 33 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:83:12 [INFO] [stdout] | [INFO] [stdout] 83 | if !(str[0] == b'-') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(str[0] != b'-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:78:16 [INFO] [stdout] | [INFO] [stdout] 78 | fn flags(args: &Vec) -> (Flags, Option) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 78 - fn flags(args: &Vec) -> (Flags, Option) { [INFO] [stdout] 78 + fn flags(args: &[String]) -> (Flags, Option) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | / match str[1..] { [INFO] [stdout] 88 | | [b'e'] => arguments.enable_backslash_commands = true, [INFO] [stdout] 89 | | _ => (), [INFO] [stdout] 90 | | } [INFO] [stdout] | |_________^ help: try: `if let [b'e'] = str[1..] { arguments.enable_backslash_commands = true }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:106:5 [INFO] [stdout] | [INFO] [stdout] 106 | / match args_start { [INFO] [stdout] 107 | | Some(start) => { [INFO] [stdout] 108 | | for arg in &args[start..] { [INFO] [stdout] 109 | | print!("{arg} ") [INFO] [stdout] ... | [INFO] [stdout] 112 | | None => (), [INFO] [stdout] 113 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 106 ~ if let Some(start) = args_start { [INFO] [stdout] 107 + for arg in &args[start..] { [INFO] [stdout] 108 + print!("{arg} ") [INFO] [stdout] 109 + } [INFO] [stdout] 110 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.16s [INFO] running `Command { std: "docker" "inspect" "620c4679fc5db91a3704881efbfa33fac84966e825bc8879e41ad1e426ab4dc0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "620c4679fc5db91a3704881efbfa33fac84966e825bc8879e41ad1e426ab4dc0", kill_on_drop: false }` [INFO] [stdout] 620c4679fc5db91a3704881efbfa33fac84966e825bc8879e41ad1e426ab4dc0