[INFO] cloning repository https://github.com/lucasTanne/rcli-lib
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/lucasTanne/rcli-lib" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FlucasTanne%2Frcli-lib", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FlucasTanne%2Frcli-lib'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] d400e8c084f82eb7d8119fd98b293f5c0ee8de58
[INFO] linting lucasTanne/rcli-lib against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FlucasTanne%2Frcli-lib" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/lucasTanne/rcli-lib
[INFO] finished tweaking git repo https://github.com/lucasTanne/rcli-lib
[INFO] tweaked toml for git repo https://github.com/lucasTanne/rcli-lib written to /workspace/builds/worker-1-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/lucasTanne/rcli-lib on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/lucasTanne/rcli-lib already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 291fd600e9d48c7ee8095b89944f8617e173815d004d0226c3c2851ab0f4e45b
[INFO] running `Command { std: "docker" "start" "-a" "291fd600e9d48c7ee8095b89944f8617e173815d004d0226c3c2851ab0f4e45b", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "291fd600e9d48c7ee8095b89944f8617e173815d004d0226c3c2851ab0f4e45b", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "291fd600e9d48c7ee8095b89944f8617e173815d004d0226c3c2851ab0f4e45b", kill_on_drop: false }`
[INFO] [stdout] 291fd600e9d48c7ee8095b89944f8617e173815d004d0226c3c2851ab0f4e45b
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 00189b3281f334b0cc9882f77ea8c1dceb04c135b02f115e49acc166691f916e
[INFO] running `Command { std: "docker" "start" "-a" "00189b3281f334b0cc9882f77ea8c1dceb04c135b02f115e49acc166691f916e", kill_on_drop: false }`
[INFO] [stderr]     Checking rcli_lib v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/command.rs:13:19
[INFO] [stdout]    |
[INFO] [stdout] 13 |         Command { name: name, action }
[INFO] [stdout]    |                   ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `Rcli`
[INFO] [stdout]   --> src/rcli.rs:12:5
[INFO] [stdout]    |
[INFO] [stdout] 12 | /     pub fn new() -> Rcli{
[INFO] [stdout] 13 | |         Rcli { commands: HashMap::new() }
[INFO] [stdout] 14 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 11 + impl Default for Rcli {
[INFO] [stdout] 12 +     fn default() -> Self {
[INFO] [stdout] 13 +         Self::new()
[INFO] [stdout] 14 +     }
[INFO] [stdout] 15 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/rcli.rs:22:12
[INFO] [stdout]    |
[INFO] [stdout] 22 |         if !cmd.is_none() {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^ help: try: `cmd.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `cmd` after checking its variant with `is_none`
[INFO] [stdout]   --> src/rcli.rs:24:27
[INFO] [stdout]    |
[INFO] [stdout] 22 |         if !cmd.is_none() {
[INFO] [stdout]    |             ------------- the check is happening here
[INFO] [stdout] 23 |             println!("found: {}", context.command_name);
[INFO] [stdout] 24 |             let command = cmd.unwrap();
[INFO] [stdout]    |                           ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: methods called `new` usually return `Self`
[INFO] [stdout]   --> src/parser.rs:5:5
[INFO] [stdout]    |
[INFO] [stdout]  5 | /     pub fn new(args: &[String]) -> Result<Context, &str> {
[INFO] [stdout]  6 | |         if args.len() < 2 {
[INFO] [stdout]  7 | |             return Err("Not enough arguments");
[INFO] [stdout] ...  |
[INFO] [stdout] 20 | |         Ok(Context { command_name, argument })
[INFO] [stdout] 21 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stdout]    = note: `#[warn(clippy::new_ret_no_self)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/command.rs:13:19
[INFO] [stdout]    |
[INFO] [stdout] 13 |         Command { name: name, action }
[INFO] [stdout]    |                   ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `Rcli`
[INFO] [stdout]   --> src/rcli.rs:12:5
[INFO] [stdout]    |
[INFO] [stdout] 12 | /     pub fn new() -> Rcli{
[INFO] [stdout] 13 | |         Rcli { commands: HashMap::new() }
[INFO] [stdout] 14 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 11 + impl Default for Rcli {
[INFO] [stdout] 12 +     fn default() -> Self {
[INFO] [stdout] 13 +         Self::new()
[INFO] [stdout] 14 +     }
[INFO] [stdout] 15 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/rcli.rs:22:12
[INFO] [stdout]    |
[INFO] [stdout] 22 |         if !cmd.is_none() {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^ help: try: `cmd.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `cmd` after checking its variant with `is_none`
[INFO] [stdout]   --> src/rcli.rs:24:27
[INFO] [stdout]    |
[INFO] [stdout] 22 |         if !cmd.is_none() {
[INFO] [stdout]    |             ------------- the check is happening here
[INFO] [stdout] 23 |             println!("found: {}", context.command_name);
[INFO] [stdout] 24 |             let command = cmd.unwrap();
[INFO] [stdout]    |                           ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: methods called `new` usually return `Self`
[INFO] [stdout]   --> src/parser.rs:5:5
[INFO] [stdout]    |
[INFO] [stdout]  5 | /     pub fn new(args: &[String]) -> Result<Context, &str> {
[INFO] [stdout]  6 | |         if args.len() < 2 {
[INFO] [stdout]  7 | |             return Err("Not enough arguments");
[INFO] [stdout] ...  |
[INFO] [stdout] 20 | |         Ok(Context { command_name, argument })
[INFO] [stdout] 21 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stdout]    = note: `#[warn(clippy::new_ret_no_self)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.26s
[INFO] running `Command { std: "docker" "inspect" "00189b3281f334b0cc9882f77ea8c1dceb04c135b02f115e49acc166691f916e", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "00189b3281f334b0cc9882f77ea8c1dceb04c135b02f115e49acc166691f916e", kill_on_drop: false }`
[INFO] [stdout] 00189b3281f334b0cc9882f77ea8c1dceb04c135b02f115e49acc166691f916e