[INFO] cloning repository https://github.com/lucas-bogos/invaders-game [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/lucas-bogos/invaders-game" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flucas-bogos%2Finvaders-game", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flucas-bogos%2Finvaders-game'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1992190e2492120386a432207031b6c691b59262 [INFO] linting lucas-bogos/invaders-game against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flucas-bogos%2Finvaders-game" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/lucas-bogos/invaders-game [INFO] finished tweaking git repo https://github.com/lucas-bogos/invaders-game [INFO] tweaked toml for git repo https://github.com/lucas-bogos/invaders-game written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/lucas-bogos/invaders-game on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/lucas-bogos/invaders-game already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded symphonia v0.5.3 [INFO] [stderr] Downloaded symphonia-metadata v0.5.3 [INFO] [stderr] Downloaded rodio v0.17.1 [INFO] [stderr] Downloaded toml_datetime v0.6.3 [INFO] [stderr] Downloaded hound v3.5.0 [INFO] [stderr] Downloaded thiserror-impl v1.0.47 [INFO] [stderr] Downloaded crossterm_winapi v0.6.2 [INFO] [stderr] Downloaded coreaudio-sys v0.2.12 [INFO] [stderr] Downloaded lock_api v0.3.4 [INFO] [stderr] Downloaded parking_lot v0.10.2 [INFO] [stderr] Downloaded parking_lot_core v0.7.3 [INFO] [stderr] Downloaded symphonia-bundle-mp3 v0.5.3 [INFO] [stderr] Downloaded alsa v0.7.1 [INFO] [stderr] Downloaded claxon v0.4.3 [INFO] [stderr] Downloaded crossterm v0.17.7 [INFO] [stderr] Downloaded winnow v0.5.15 [INFO] [stderr] Downloaded hashbrown v0.14.0 [INFO] [stderr] Downloaded aho-corasick v1.0.4 [INFO] [stderr] Downloaded oboe-sys v0.5.0 [INFO] [stderr] Downloaded cpal v0.15.2 [INFO] [stderr] Downloaded regex v1.9.4 [INFO] [stderr] Downloaded toml_edit v0.19.14 [INFO] [stderr] Downloaded symphonia-core v0.5.3 [INFO] [stderr] Downloaded nix v0.24.3 [INFO] [stderr] Downloaded syn v2.0.29 [INFO] [stderr] Downloaded coreaudio-rs v0.11.2 [INFO] [stderr] Downloaded indexmap v2.0.0 [INFO] [stderr] Downloaded signal-hook v0.1.17 [INFO] [stderr] Downloaded regex-syntax v0.7.5 [INFO] [stderr] Downloaded mach2 v0.4.1 [INFO] [stderr] Downloaded rusty_audio v1.4.1 [INFO] [stderr] Downloaded thiserror v1.0.47 [INFO] [stderr] Downloaded jobserver v0.1.26 [INFO] [stderr] Downloaded oboe v0.5.0 [INFO] [stderr] Downloaded rusty_time v0.11.3 [INFO] [stderr] Downloaded regex-automata v0.3.7 [INFO] [stderr] Downloaded windows v0.46.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e7c3d275f3645b8b477b4f6599a8f4d63e05905c32f94124ae3c74f4ab01f19a [INFO] running `Command { std: "docker" "start" "-a" "e7c3d275f3645b8b477b4f6599a8f4d63e05905c32f94124ae3c74f4ab01f19a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e7c3d275f3645b8b477b4f6599a8f4d63e05905c32f94124ae3c74f4ab01f19a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e7c3d275f3645b8b477b4f6599a8f4d63e05905c32f94124ae3c74f4ab01f19a", kill_on_drop: false }` [INFO] [stdout] e7c3d275f3645b8b477b4f6599a8f4d63e05905c32f94124ae3c74f4ab01f19a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a3bf16cc621790515ed26f16d00282fa1baa03f73df04f2810b429acb35d6f78 [INFO] running `Command { std: "docker" "start" "-a" "a3bf16cc621790515ed26f16d00282fa1baa03f73df04f2810b429acb35d6f78", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking smallvec v1.11.0 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Checking bytemuck v1.13.1 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Compiling cpal v0.15.2 [INFO] [stderr] Checking dasp_sample v0.11.0 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Checking ogg v0.8.0 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking hound v3.5.0 [INFO] [stderr] Checking claxon v0.4.3 [INFO] [stderr] Checking rusty_time v0.11.3 [INFO] [stderr] Checking symphonia-core v0.5.3 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Checking lewton v0.10.2 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.7.14 [INFO] [stderr] Checking parking_lot_core v0.7.3 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking symphonia-metadata v0.5.3 [INFO] [stderr] Checking alsa v0.7.1 [INFO] [stderr] Checking signal-hook v0.1.17 [INFO] [stderr] Checking symphonia-bundle-mp3 v0.5.3 [INFO] [stderr] Checking parking_lot v0.10.2 [INFO] [stderr] Checking crossterm v0.17.7 [INFO] [stderr] Checking symphonia v0.5.3 [INFO] [stderr] Checking rodio v0.17.1 [INFO] [stderr] Checking rusty_audio v1.4.1 [INFO] [stderr] Checking invaders-game v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/frame.rs:12:13 [INFO] [stdout] | [INFO] [stdout] 12 | col.push(" "); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![" ";SIZE]` [INFO] [stdout] = help: or `col.extend(std::iter::repeat_n(" ", SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] = note: `#[warn(clippy::same_item_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Player` [INFO] [stdout] --> src/player.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn new() -> Self { [INFO] [stdout] 13 | | Self { [INFO] [stdout] 14 | | x: NUM_COLS / 2, [INFO] [stdout] 15 | | y: NUM_ROWS - 1, [INFO] [stdout] ... | [INFO] [stdout] 18 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 11 + impl Default for Player { [INFO] [stdout] 12 + fn default() -> Self { [INFO] [stdout] 13 + Self::new() [INFO] [stdout] 14 + } [INFO] [stdout] 15 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/player.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | / if !shot.exploding { [INFO] [stdout] 54 | | if invaders.kill_invader_at(shot.x, shot.y) { [INFO] [stdout] 55 | | hit_something = true; [INFO] [stdout] 56 | | shot.explode(); [INFO] [stdout] 57 | | } [INFO] [stdout] 58 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 53 ~ if !shot.exploding [INFO] [stdout] 54 ~ && invaders.kill_invader_at(shot.x, shot.y) { [INFO] [stdout] 55 | hit_something = true; [INFO] [stdout] 56 | shot.explode(); [INFO] [stdout] 57 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Invaders` [INFO] [stdout] --> src/invaders.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / pub fn new() -> Self { [INFO] [stdout] 19 | | let mut army = Vec::new(); [INFO] [stdout] 20 | | [INFO] [stdout] 21 | | for x in 0..NUM_COLS { [INFO] [stdout] ... | [INFO] [stdout] 39 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 17 + impl Default for Invaders { [INFO] [stdout] 18 + fn default() -> Self { [INFO] [stdout] 19 + Self::new() [INFO] [stdout] 20 + } [INFO] [stdout] 21 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/invaders.rs:23:20 [INFO] [stdout] | [INFO] [stdout] 23 | if (x > 0) [INFO] [stdout] | ____________________^ [INFO] [stdout] 24 | | && (x < NUM_COLS - 2) [INFO] [stdout] 25 | | && (y > 0) [INFO] [stdout] 26 | | && (y < 9) [INFO] [stdout] 27 | | && (y % 2 == 0) [INFO] [stdout] 28 | | && (y % 2 == 0) { [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 23 - if (x > 0) [INFO] [stdout] 24 - && (x < NUM_COLS - 2) [INFO] [stdout] 25 - && (y > 0) [INFO] [stdout] 26 - && (y < 9) [INFO] [stdout] 27 - && (y % 2 == 0) [INFO] [stdout] 28 - && (y % 2 == 0) { [INFO] [stdout] 23 + if !(x <= 0 || x >= NUM_COLS - 2 || y <= 0 || y >= 9 || y % 2 != 0) { [INFO] [stdout] | [INFO] [stdout] 23 - if (x > 0) [INFO] [stdout] 24 - && (x < NUM_COLS - 2) [INFO] [stdout] 25 - && (y > 0) [INFO] [stdout] 26 - && (y < 9) [INFO] [stdout] 27 - && (y % 2 == 0) [INFO] [stdout] 28 - && (y % 2 == 0) { [INFO] [stdout] 23 + if (x > 0) && (x < NUM_COLS - 2) && (y > 0) && (y < 9) && (y % 2 == 0) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/frame.rs:12:13 [INFO] [stdout] | [INFO] [stdout] 12 | col.push(" "); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![" ";SIZE]` [INFO] [stdout] = help: or `col.extend(std::iter::repeat_n(" ", SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] = note: `#[warn(clippy::same_item_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Player` [INFO] [stdout] --> src/player.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn new() -> Self { [INFO] [stdout] 13 | | Self { [INFO] [stdout] 14 | | x: NUM_COLS / 2, [INFO] [stdout] 15 | | y: NUM_ROWS - 1, [INFO] [stdout] ... | [INFO] [stdout] 18 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 11 + impl Default for Player { [INFO] [stdout] 12 + fn default() -> Self { [INFO] [stdout] 13 + Self::new() [INFO] [stdout] 14 + } [INFO] [stdout] 15 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/player.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | / if !shot.exploding { [INFO] [stdout] 54 | | if invaders.kill_invader_at(shot.x, shot.y) { [INFO] [stdout] 55 | | hit_something = true; [INFO] [stdout] 56 | | shot.explode(); [INFO] [stdout] 57 | | } [INFO] [stdout] 58 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 53 ~ if !shot.exploding [INFO] [stdout] 54 ~ && invaders.kill_invader_at(shot.x, shot.y) { [INFO] [stdout] 55 | hit_something = true; [INFO] [stdout] 56 | shot.explode(); [INFO] [stdout] 57 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Invaders` [INFO] [stdout] --> src/invaders.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / pub fn new() -> Self { [INFO] [stdout] 19 | | let mut army = Vec::new(); [INFO] [stdout] 20 | | [INFO] [stdout] 21 | | for x in 0..NUM_COLS { [INFO] [stdout] ... | [INFO] [stdout] 39 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 17 + impl Default for Invaders { [INFO] [stdout] 18 + fn default() -> Self { [INFO] [stdout] 19 + Self::new() [INFO] [stdout] 20 + } [INFO] [stdout] 21 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/invaders.rs:23:20 [INFO] [stdout] | [INFO] [stdout] 23 | if (x > 0) [INFO] [stdout] | ____________________^ [INFO] [stdout] 24 | | && (x < NUM_COLS - 2) [INFO] [stdout] 25 | | && (y > 0) [INFO] [stdout] 26 | | && (y < 9) [INFO] [stdout] 27 | | && (y % 2 == 0) [INFO] [stdout] 28 | | && (y % 2 == 0) { [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 23 - if (x > 0) [INFO] [stdout] 24 - && (x < NUM_COLS - 2) [INFO] [stdout] 25 - && (y > 0) [INFO] [stdout] 26 - && (y < 9) [INFO] [stdout] 27 - && (y % 2 == 0) [INFO] [stdout] 28 - && (y % 2 == 0) { [INFO] [stdout] 23 + if !(x <= 0 || x >= NUM_COLS - 2 || y <= 0 || y >= 9 || y % 2 != 0) { [INFO] [stdout] | [INFO] [stdout] 23 - if (x > 0) [INFO] [stdout] 24 - && (x < NUM_COLS - 2) [INFO] [stdout] 25 - && (y > 0) [INFO] [stdout] 26 - && (y < 9) [INFO] [stdout] 27 - && (y % 2 == 0) [INFO] [stdout] 28 - && (y % 2 == 0) { [INFO] [stdout] 23 + if (x > 0) && (x < NUM_COLS - 2) && (y > 0) && (y < 9) && (y % 2 == 0) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/main.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | / loop { [INFO] [stdout] 42 | | let current_frame = match render_rx.recv() { [INFO] [stdout] 43 | | Ok(x) => x, [INFO] [stdout] 44 | | Err(_) => break, [INFO] [stdout] ... | [INFO] [stdout] 48 | | last_frame = current_frame; [INFO] [stdout] 49 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 41 ~ while let Ok(x) = render_rx.recv() { [INFO] [stdout] 42 + let current_frame = x; [INFO] [stdout] 43 + .. [INFO] [stdout] 44 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:70:25 [INFO] [stdout] | [INFO] [stdout] 70 | / if player.shoot() { [INFO] [stdout] 71 | | audio.play("pew"); [INFO] [stdout] 72 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 69 ~ KeyCode::Char(' ') | KeyCode::Enter [INFO] [stdout] 70 ~ if player.shoot() => { [INFO] [stdout] 71 | audio.play("pew"); [INFO] [stdout] 72 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/main.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | / loop { [INFO] [stdout] 42 | | let current_frame = match render_rx.recv() { [INFO] [stdout] 43 | | Ok(x) => x, [INFO] [stdout] 44 | | Err(_) => break, [INFO] [stdout] ... | [INFO] [stdout] 48 | | last_frame = current_frame; [INFO] [stdout] 49 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 41 ~ while let Ok(x) = render_rx.recv() { [INFO] [stdout] 42 + let current_frame = x; [INFO] [stdout] 43 + .. [INFO] [stdout] 44 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:70:25 [INFO] [stdout] | [INFO] [stdout] 70 | / if player.shoot() { [INFO] [stdout] 71 | | audio.play("pew"); [INFO] [stdout] 72 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 69 ~ KeyCode::Char(' ') | KeyCode::Enter [INFO] [stdout] 70 ~ if player.shoot() => { [INFO] [stdout] 71 | audio.play("pew"); [INFO] [stdout] 72 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.44s [INFO] running `Command { std: "docker" "inspect" "a3bf16cc621790515ed26f16d00282fa1baa03f73df04f2810b429acb35d6f78", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a3bf16cc621790515ed26f16d00282fa1baa03f73df04f2810b429acb35d6f78", kill_on_drop: false }` [INFO] [stdout] a3bf16cc621790515ed26f16d00282fa1baa03f73df04f2810b429acb35d6f78