[INFO] cloning repository https://github.com/lsaa/wraith_engine [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/lsaa/wraith_engine" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flsaa%2Fwraith_engine", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flsaa%2Fwraith_engine'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 551462ee1dd87bfadc7be8848e2b3e35d0beb6f7 [INFO] linting lsaa/wraith_engine against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flsaa%2Fwraith_engine" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-4-tc1/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/lsaa/wraith_engine [INFO] finished tweaking git repo https://github.com/lsaa/wraith_engine [INFO] tweaked toml for git repo https://github.com/lsaa/wraith_engine written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/lsaa/wraith_engine on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/lsaa/wraith_engine already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded emscripten_main_loop v0.1.1 [INFO] [stderr] Downloaded sdl2 v0.34.5 [INFO] [stderr] Downloaded sdl2-sys v0.34.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fa05f0ea7663b28fcc3587377817114192cb875ed86bdc51f0dbe87d053a4ed6 [INFO] running `Command { std: "docker" "start" "-a" "fa05f0ea7663b28fcc3587377817114192cb875ed86bdc51f0dbe87d053a4ed6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fa05f0ea7663b28fcc3587377817114192cb875ed86bdc51f0dbe87d053a4ed6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fa05f0ea7663b28fcc3587377817114192cb875ed86bdc51f0dbe87d053a4ed6", kill_on_drop: false }` [INFO] [stdout] fa05f0ea7663b28fcc3587377817114192cb875ed86bdc51f0dbe87d053a4ed6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d30cec582434f5447b93f46db2cf6f33e115fc47eb6dbdf74c3fa61a644c57f1 [INFO] running `Command { std: "docker" "start" "-a" "d30cec582434f5447b93f46db2cf6f33e115fc47eb6dbdf74c3fa61a644c57f1", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.99 [INFO] [stderr] Compiling version-compare v0.0.10 [INFO] [stderr] Compiling sdl2 v0.34.5 [INFO] [stderr] Checking c_vec v2.0.0 [INFO] [stderr] Checking emscripten_main_loop v0.1.1 [INFO] [stderr] Checking rectangle-pack v0.4.2 [INFO] [stderr] Checking wraith_engine v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/util/color.rs:50:35 [INFO] [stdout] | [INFO] [stdout] 50 | ((value - (value * saturation * k.min(4.0 - k).min(1.0).max(0.0))) * 255.0) as u8 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `k.min(4.0 - k).clamp(0.0, 1.0)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/util/color.rs:50:35 [INFO] [stdout] | [INFO] [stdout] 50 | ((value - (value * saturation * k.min(4.0 - k).min(1.0).max(0.0))) * 255.0) as u8 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `k.min(4.0 - k).clamp(0.0, 1.0)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling sdl2-sys v0.34.5 [INFO] [stderr] Checking raw-window-handle v0.3.3 [INFO] [stderr] Checking wraith_sdl2 v0.1.0 (/opt/rustwide/workdir/crates/wraith_sdl2) [INFO] [stdout] warning: unused import: `sdl2::rect::Rect` [INFO] [stdout] --> crates/wraith_sdl2/src/lib.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use sdl2::rect::Rect; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sdl2::rect::Rect` [INFO] [stdout] --> crates/wraith_sdl2/src/lib.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use sdl2::rect::Rect; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `TextureManager` [INFO] [stdout] --> crates/wraith_sdl2/src/texture_manager.rs:15:2 [INFO] [stdout] | [INFO] [stdout] 15 | / pub fn new() -> Self { [INFO] [stdout] 16 | | Self { [INFO] [stdout] 17 | | cache: HashMap::new() [INFO] [stdout] 18 | | } [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 14 + impl Default for TextureManager { [INFO] [stdout] 15 + fn default() -> Self { [INFO] [stdout] 16 + Self::new() [INFO] [stdout] 17 + } [INFO] [stdout] 18 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> crates/wraith_sdl2/src/texture_manager.rs:24:6 [INFO] [stdout] | [INFO] [stdout] 24 | if !t.is_ok() { [INFO] [stdout] | ^^^^^^^^^^ help: try: `t.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/wraith_sdl2/src/texture_manager.rs:29:3 [INFO] [stdout] | [INFO] [stdout] 29 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return Ok(()); [INFO] [stdout] 29 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `removed` after checking its variant with `is_some` [INFO] [stdout] --> crates/wraith_sdl2/src/texture_manager.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 42 | if removed.is_some() { [INFO] [stdout] | -------------------- help: try: `if let Some() = removed` [INFO] [stdout] 43 | // YOLO [INFO] [stdout] 44 | unsafe { removed.unwrap().destroy() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `res` after checking its variant with `is_ok` [INFO] [stdout] --> crates/wraith_sdl2/src/texture_manager.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 52 | if res.is_ok() { [INFO] [stdout] | -------------- help: try: `if let Ok() = res` [INFO] [stdout] 53 | let t = res.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> crates/wraith_sdl2/src/atlas.rs:29:18 [INFO] [stdout] | [INFO] [stdout] 29 | self.rects.get(&path.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `max_size` after checking its variant with `is_some` [INFO] [stdout] --> crates/wraith_sdl2/src/atlas.rs:59:39 [INFO] [stdout] | [INFO] [stdout] 59 | let max_w = if max_size.is_some() { max_size.unwrap().0 } else { 4096 }; [INFO] [stdout] | --------------------- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: try: `if let Some() = max_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `max_size` after checking its variant with `is_some` [INFO] [stdout] --> crates/wraith_sdl2/src/atlas.rs:60:39 [INFO] [stdout] | [INFO] [stdout] 60 | let max_h = if max_size.is_some() { max_size.unwrap().1 } else { 4096 }; [INFO] [stdout] | --------------------- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: try: `if let Some() = max_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `pixel_format` after checking its variant with `is_some` [INFO] [stdout] --> crates/wraith_sdl2/src/atlas.rs:95:44 [INFO] [stdout] | [INFO] [stdout] 95 | let format = if pixel_format.is_some() { pixel_format.unwrap() } else { PixelFormatEnum::RGBA8888 }; [INFO] [stdout] | ------------------------- ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: try: `if let Some() = pixel_format` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `res` after checking its variant with `is_some` [INFO] [stdout] --> crates/wraith_sdl2/src/atlas.rs:124:26 [INFO] [stdout] | [INFO] [stdout] 123 | if res.is_some() { [INFO] [stdout] | ---------------- help: try: `if let Some() = res` [INFO] [stdout] 124 | return Ok((&self.img, res.unwrap().clone())); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `TextureManager` [INFO] [stdout] --> crates/wraith_sdl2/src/texture_manager.rs:15:2 [INFO] [stdout] | [INFO] [stdout] 15 | / pub fn new() -> Self { [INFO] [stdout] 16 | | Self { [INFO] [stdout] 17 | | cache: HashMap::new() [INFO] [stdout] 18 | | } [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 14 + impl Default for TextureManager { [INFO] [stdout] 15 + fn default() -> Self { [INFO] [stdout] 16 + Self::new() [INFO] [stdout] 17 + } [INFO] [stdout] 18 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> crates/wraith_sdl2/src/texture_manager.rs:24:6 [INFO] [stdout] | [INFO] [stdout] 24 | if !t.is_ok() { [INFO] [stdout] | ^^^^^^^^^^ help: try: `t.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/wraith_sdl2/src/texture_manager.rs:29:3 [INFO] [stdout] | [INFO] [stdout] 29 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return Ok(()); [INFO] [stdout] 29 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `removed` after checking its variant with `is_some` [INFO] [stdout] --> crates/wraith_sdl2/src/texture_manager.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 42 | if removed.is_some() { [INFO] [stdout] | -------------------- help: try: `if let Some() = removed` [INFO] [stdout] 43 | // YOLO [INFO] [stdout] 44 | unsafe { removed.unwrap().destroy() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `res` after checking its variant with `is_ok` [INFO] [stdout] --> crates/wraith_sdl2/src/texture_manager.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 52 | if res.is_ok() { [INFO] [stdout] | -------------- help: try: `if let Ok() = res` [INFO] [stdout] 53 | let t = res.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> crates/wraith_sdl2/src/atlas.rs:29:18 [INFO] [stdout] | [INFO] [stdout] 29 | self.rects.get(&path.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `max_size` after checking its variant with `is_some` [INFO] [stdout] --> crates/wraith_sdl2/src/atlas.rs:59:39 [INFO] [stdout] | [INFO] [stdout] 59 | let max_w = if max_size.is_some() { max_size.unwrap().0 } else { 4096 }; [INFO] [stdout] | --------------------- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: try: `if let Some() = max_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `max_size` after checking its variant with `is_some` [INFO] [stdout] --> crates/wraith_sdl2/src/atlas.rs:60:39 [INFO] [stdout] | [INFO] [stdout] 60 | let max_h = if max_size.is_some() { max_size.unwrap().1 } else { 4096 }; [INFO] [stdout] | --------------------- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: try: `if let Some() = max_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `pixel_format` after checking its variant with `is_some` [INFO] [stdout] --> crates/wraith_sdl2/src/atlas.rs:95:44 [INFO] [stdout] | [INFO] [stdout] 95 | let format = if pixel_format.is_some() { pixel_format.unwrap() } else { PixelFormatEnum::RGBA8888 }; [INFO] [stdout] | ------------------------- ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: try: `if let Some() = pixel_format` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `res` after checking its variant with `is_some` [INFO] [stdout] --> crates/wraith_sdl2/src/atlas.rs:124:26 [INFO] [stdout] | [INFO] [stdout] 123 | if res.is_some() { [INFO] [stdout] | ---------------- help: try: `if let Some() = res` [INFO] [stdout] 124 | return Ok((&self.img, res.unwrap().clone())); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Rect` which implements the `Copy` trait [INFO] [stdout] --> crates/wraith_sdl2/src/atlas.rs:124:26 [INFO] [stdout] | [INFO] [stdout] 124 | return Ok((&self.img, res.unwrap().clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*res.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Rect` which implements the `Copy` trait [INFO] [stdout] --> crates/wraith_sdl2/src/atlas.rs:124:26 [INFO] [stdout] | [INFO] [stdout] 124 | return Ok((&self.img, res.unwrap().clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*res.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.63s [INFO] running `Command { std: "docker" "inspect" "d30cec582434f5447b93f46db2cf6f33e115fc47eb6dbdf74c3fa61a644c57f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d30cec582434f5447b93f46db2cf6f33e115fc47eb6dbdf74c3fa61a644c57f1", kill_on_drop: false }` [INFO] [stdout] d30cec582434f5447b93f46db2cf6f33e115fc47eb6dbdf74c3fa61a644c57f1