[INFO] cloning repository https://github.com/lptstr/branch [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/lptstr/branch" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flptstr%2Fbranch", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flptstr%2Fbranch'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1b0a61ed3a51d7b94dba0b9e652390844879afb1 [INFO] linting lptstr/branch against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flptstr%2Fbranch" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/lptstr/branch [INFO] finished tweaking git repo https://github.com/lptstr/branch [INFO] tweaked toml for git repo https://github.com/lptstr/branch written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/lptstr/branch on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/lptstr/branch already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded crossbeam-queue v0.1.2 [INFO] [stderr] Downloaded cfg-if v0.1.10 [INFO] [stderr] Downloaded hermit-abi v0.1.3 [INFO] [stderr] Downloaded num_cpus v1.11.0 [INFO] [stderr] Downloaded crossbeam-utils v0.6.6 [INFO] [stderr] Downloaded either v1.5.3 [INFO] [stderr] Downloaded memoffset v0.5.2 [INFO] [stderr] Downloaded gitignore v1.0.6 [INFO] [stderr] Downloaded rayon-core v1.6.0 [INFO] [stderr] Downloaded bitflags v1.2.1 [INFO] [stderr] Downloaded crossbeam-epoch v0.8.0 [INFO] [stderr] Downloaded crossbeam-utils v0.7.0 [INFO] [stderr] Downloaded crossbeam-deque v0.7.2 [INFO] [stderr] Downloaded glob v0.2.11 [INFO] [stderr] Downloaded log v0.4.8 [INFO] [stderr] Downloaded scopeguard v1.0.0 [INFO] [stderr] Downloaded autocfg v0.1.7 [INFO] [stderr] Downloaded rayon v1.2.0 [INFO] [stderr] Downloaded libc v0.2.65 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 17e4f6c0a3ab492312d45536d40d24da8c7ab813547f94f31c8bc5b214a40eaf [INFO] running `Command { std: "docker" "start" "-a" "17e4f6c0a3ab492312d45536d40d24da8c7ab813547f94f31c8bc5b214a40eaf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "17e4f6c0a3ab492312d45536d40d24da8c7ab813547f94f31c8bc5b214a40eaf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "17e4f6c0a3ab492312d45536d40d24da8c7ab813547f94f31c8bc5b214a40eaf", kill_on_drop: false }` [INFO] [stdout] 17e4f6c0a3ab492312d45536d40d24da8c7ab813547f94f31c8bc5b214a40eaf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9a681455d7a227f93a6434d362a42cde8423f21ea3cec06cf0f73c3fee03ebf0 [INFO] running `Command { std: "docker" "start" "-a" "9a681455d7a227f93a6434d362a42cde8423f21ea3cec06cf0f73c3fee03ebf0", kill_on_drop: false }` [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling libc v0.2.65 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling rayon-core v1.6.0 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking glob v0.2.11 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling crossbeam-utils v0.7.0 [INFO] [stderr] Compiling crossbeam-epoch v0.8.0 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Checking gitignore v1.0.6 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling memoffset v0.5.2 [INFO] [stderr] Checking num_cpus v1.11.0 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking crossbeam-deque v0.7.2 [INFO] [stderr] Checking rayon v1.2.0 [INFO] [stderr] Checking branch v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/prog.rs:24:43 [INFO] [stdout] | [INFO] [stdout] 24 | let mut things: Vec<_> = fs::read_dir(&*directory)?.map(|e| { [INFO] [stdout] | ^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `directory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/prog.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | / if ! matches.is_present("all") { [INFO] [stdout] 42 | | if is_hidden(&thing) { [INFO] [stdout] 43 | | continue; [INFO] [stdout] 44 | | } [INFO] [stdout] 45 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 41 ~ if ! matches.is_present("all") [INFO] [stdout] 42 ~ && is_hidden(&thing) { [INFO] [stdout] 43 | continue; [INFO] [stdout] 44 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/prog.rs:68:34 [INFO] [stdout] | [INFO] [stdout] 68 | let mut max_level: u64 = std::u64::MAX; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 68 - let mut max_level: u64 = std::u64::MAX; [INFO] [stdout] 68 + let mut max_level: u64 = u64::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/prog.rs:82:25 [INFO] [stdout] | [INFO] [stdout] 82 | &mut treestat, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `treestat` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/prog.rs:104:8 [INFO] [stdout] | [INFO] [stdout] 104 | if ! fs::metadata(&directory).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&directory).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/prog.rs:24:43 [INFO] [stdout] | [INFO] [stdout] 24 | let mut things: Vec<_> = fs::read_dir(&*directory)?.map(|e| { [INFO] [stdout] | ^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `directory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/prog.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | / if ! matches.is_present("all") { [INFO] [stdout] 42 | | if is_hidden(&thing) { [INFO] [stdout] 43 | | continue; [INFO] [stdout] 44 | | } [INFO] [stdout] 45 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 41 ~ if ! matches.is_present("all") [INFO] [stdout] 42 ~ && is_hidden(&thing) { [INFO] [stdout] 43 | continue; [INFO] [stdout] 44 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/prog.rs:68:34 [INFO] [stdout] | [INFO] [stdout] 68 | let mut max_level: u64 = std::u64::MAX; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 68 - let mut max_level: u64 = std::u64::MAX; [INFO] [stdout] 68 + let mut max_level: u64 = u64::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/prog.rs:82:25 [INFO] [stdout] | [INFO] [stdout] 82 | &mut treestat, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `treestat` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.18s [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/prog.rs:104:8 [INFO] [stdout] | [INFO] [stdout] 104 | if ! fs::metadata(&directory).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&directory).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "9a681455d7a227f93a6434d362a42cde8423f21ea3cec06cf0f73c3fee03ebf0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9a681455d7a227f93a6434d362a42cde8423f21ea3cec06cf0f73c3fee03ebf0", kill_on_drop: false }` [INFO] [stdout] 9a681455d7a227f93a6434d362a42cde8423f21ea3cec06cf0f73c3fee03ebf0