[INFO] cloning repository https://github.com/louisstewart/AVLTreeRs
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/louisstewart/AVLTreeRs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flouisstewart%2FAVLTreeRs", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flouisstewart%2FAVLTreeRs'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 8cc29fa4ceb9ab215eda284bc08103892bd8f76a
[INFO] linting louisstewart/AVLTreeRs against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flouisstewart%2FAVLTreeRs" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/louisstewart/AVLTreeRs
[INFO] finished tweaking git repo https://github.com/louisstewart/AVLTreeRs
[INFO] tweaked toml for git repo https://github.com/louisstewart/AVLTreeRs written to /workspace/builds/worker-2-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/louisstewart/AVLTreeRs on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/louisstewart/AVLTreeRs already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded quickcheck_macros v1.0.0
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 1bd38bbb403b60966bb1a04d481312eab6e42d70819c8b1b51780f0338fff771
[INFO] running `Command { std: "docker" "start" "-a" "1bd38bbb403b60966bb1a04d481312eab6e42d70819c8b1b51780f0338fff771", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "1bd38bbb403b60966bb1a04d481312eab6e42d70819c8b1b51780f0338fff771", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "1bd38bbb403b60966bb1a04d481312eab6e42d70819c8b1b51780f0338fff771", kill_on_drop: false }`
[INFO] [stdout] 1bd38bbb403b60966bb1a04d481312eab6e42d70819c8b1b51780f0338fff771
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 4e9135326096321ff6aaa9270d5b313c4464eb105109f20b81924f1e1e2359d0
[INFO] running `Command { std: "docker" "start" "-a" "4e9135326096321ff6aaa9270d5b313c4464eb105109f20b81924f1e1e2359d0", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr]     Checking rand v0.3.15
[INFO] [stderr]     Checking itertools v0.12.0
[INFO] [stderr]     Checking rand_core v0.6.4
[INFO] [stderr]     Checking env_logger v0.8.4
[INFO] [stderr]    Compiling syn v1.0.109
[INFO] [stderr]     Checking rand v0.8.5
[INFO] [stderr]     Checking quickcheck v1.0.3
[INFO] [stderr]    Compiling quickcheck_macros v1.0.0
[INFO] [stderr]     Checking tree v0.2.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unused import: `tree::Node`
[INFO] [stdout]   --> src/lib.rs:14:13
[INFO] [stdout]    |
[INFO] [stdout] 14 |     pub use tree::Node;
[INFO] [stdout]    |             ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `Tree<T>`
[INFO] [stdout]   --> src/tree.rs:71:5
[INFO] [stdout]    |
[INFO] [stdout] 71 | /     pub fn new() -> Tree<T> {
[INFO] [stdout] 72 | |         Tree { root: None }
[INFO] [stdout] 73 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 70 + impl<T : PartialEq + Ord> Default for Tree<T> {
[INFO] [stdout] 71 +     fn default() -> Self {
[INFO] [stdout] 72 +         Self::new()
[INFO] [stdout] 73 +     }
[INFO] [stdout] 74 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stdout]    --> src/tree.rs:93:9
[INFO] [stdout]     |
[INFO] [stdout]  93 | /         match &self.root {
[INFO] [stdout]  94 | |             &Some(ref node) => {
[INFO] [stdout]  95 | |                 node.contains(val)
[INFO] [stdout]  96 | |             },
[INFO] [stdout] ...   |
[INFO] [stdout] 100 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stdout]     = note: `#[warn(clippy::match_ref_pats)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout]  93 ~         match self.root {
[INFO] [stdout]  94 ~             Some(ref node) => {
[INFO] [stdout]  95 |                 node.contains(val)
[INFO] [stdout]  96 |             },
[INFO] [stdout]  97 ~             None => {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference
[INFO] [stdout]   --> src/tree.rs:94:13
[INFO] [stdout]    |
[INFO] [stdout] 94 |             &Some(ref node) => {
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrowed_reference)]` on by default
[INFO] [stdout] help: try removing the `&` and `ref` parts
[INFO] [stdout]    |
[INFO] [stdout] 94 -             &Some(ref node) => {
[INFO] [stdout] 94 +             Some(node) => {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stdout]    --> src/tree.rs:168:17
[INFO] [stdout]     |
[INFO] [stdout] 168 | /                 match &self.left {
[INFO] [stdout] 169 | |                     &Some(ref node) => node.contains(val),
[INFO] [stdout] 170 | |                     &None => false
[INFO] [stdout] 171 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 168 ~                 match self.left {
[INFO] [stdout] 169 ~                     Some(ref node) => node.contains(val),
[INFO] [stdout] 170 ~                     None => false
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference
[INFO] [stdout]    --> src/tree.rs:169:21
[INFO] [stdout]     |
[INFO] [stdout] 169 |                     &Some(ref node) => node.contains(val),
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stdout] help: try removing the `&` and `ref` parts
[INFO] [stdout]     |
[INFO] [stdout] 169 -                     &Some(ref node) => node.contains(val),
[INFO] [stdout] 169 +                     Some(node) => node.contains(val),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stdout]    --> src/tree.rs:174:17
[INFO] [stdout]     |
[INFO] [stdout] 174 | /                 match &self.right {
[INFO] [stdout] 175 | |                     &Some(ref node) => node.contains(val),
[INFO] [stdout] 176 | |                     &None => false
[INFO] [stdout] 177 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 174 ~                 match self.right {
[INFO] [stdout] 175 ~                     Some(ref node) => node.contains(val),
[INFO] [stdout] 176 ~                     None => false
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference
[INFO] [stdout]    --> src/tree.rs:175:21
[INFO] [stdout]     |
[INFO] [stdout] 175 |                     &Some(ref node) => node.contains(val),
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stdout] help: try removing the `&` and `ref` parts
[INFO] [stdout]     |
[INFO] [stdout] 175 -                     &Some(ref node) => node.contains(val),
[INFO] [stdout] 175 +                     Some(node) => node.contains(val),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: deref which would be done by auto-deref
[INFO] [stdout]    --> src/tree.rs:186:13
[INFO] [stdout]     |
[INFO] [stdout] 186 |             (*node).value = val;
[INFO] [stdout]     |             ^^^^^^^ help: try: `node`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
[INFO] [stdout]     = note: `#[warn(clippy::explicit_auto_deref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/tree.rs:217:19
[INFO] [stdout]     |
[INFO] [stdout] 217 |         -1..=1 => return node,
[INFO] [stdout]     |                   ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 217 -         -1..=1 => return node,
[INFO] [stdout] 217 +         -1..=1 => node,
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stdout]    --> src/tree.rs:275:54
[INFO] [stdout]     |
[INFO] [stdout] 275 | fn remove_min<T: Ord>(node: Option<Box<Node<T>>>) -> (Option<Box<Node<T>>>, Option<Box<Node<T>>>) {
[INFO] [stdout]     |                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stdout]     = note: `#[warn(clippy::type_complexity)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/tree.rs:305:36
[INFO] [stdout]     |
[INFO] [stdout] 305 |     else if node.left.is_none() && !node.right.is_none() {
[INFO] [stdout]     |                                    ^^^^^^^^^^^^^^^^^^^^^ help: try: `node.right.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/tree.rs:308:37
[INFO] [stdout]     |
[INFO] [stdout] 308 |     else if node.right.is_none() && !node.left.is_none() {
[INFO] [stdout]     |                                     ^^^^^^^^^^^^^^^^^^^^ help: try: `node.left.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: local variable doesn't need to be boxed here
[INFO] [stdout]    --> src/tree.rs:300:34
[INFO] [stdout]     |
[INFO] [stdout] 300 | fn remove_in<T: PartialEq + Ord>(node : Box<Node<T>>)
[INFO] [stdout]     |                                  ^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local
[INFO] [stdout]     = note: `#[warn(clippy::boxed_local)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/tree.rs:303:9
[INFO] [stdout]     |
[INFO] [stdout] 303 |         return None;
[INFO] [stdout]     |         ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 303 -         return None;
[INFO] [stdout] 303 +         None
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/tree.rs:306:9
[INFO] [stdout]     |
[INFO] [stdout] 306 |         return node.right;
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 306 -         return node.right;
[INFO] [stdout] 306 +         node.right
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/tree.rs:309:9
[INFO] [stdout]     |
[INFO] [stdout] 309 |         return node.left;
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 309 -         return node.left;
[INFO] [stdout] 309 +         node.left
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `Tree<T>`
[INFO] [stdout]   --> src/tree.rs:71:5
[INFO] [stdout]    |
[INFO] [stdout] 71 | /     pub fn new() -> Tree<T> {
[INFO] [stdout] 72 | |         Tree { root: None }
[INFO] [stdout] 73 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 70 + impl<T : PartialEq + Ord> Default for Tree<T> {
[INFO] [stdout] 71 +     fn default() -> Self {
[INFO] [stdout] 72 +         Self::new()
[INFO] [stdout] 73 +     }
[INFO] [stdout] 74 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stdout]    --> src/tree.rs:93:9
[INFO] [stdout]     |
[INFO] [stdout]  93 | /         match &self.root {
[INFO] [stdout]  94 | |             &Some(ref node) => {
[INFO] [stdout]  95 | |                 node.contains(val)
[INFO] [stdout]  96 | |             },
[INFO] [stdout] ...   |
[INFO] [stdout] 100 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stdout]     = note: `#[warn(clippy::match_ref_pats)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout]  93 ~         match self.root {
[INFO] [stdout]  94 ~             Some(ref node) => {
[INFO] [stdout]  95 |                 node.contains(val)
[INFO] [stdout]  96 |             },
[INFO] [stdout]  97 ~             None => {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference
[INFO] [stdout]   --> src/tree.rs:94:13
[INFO] [stdout]    |
[INFO] [stdout] 94 |             &Some(ref node) => {
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrowed_reference)]` on by default
[INFO] [stdout] help: try removing the `&` and `ref` parts
[INFO] [stdout]    |
[INFO] [stdout] 94 -             &Some(ref node) => {
[INFO] [stdout] 94 +             Some(node) => {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stdout]    --> src/tree.rs:168:17
[INFO] [stdout]     |
[INFO] [stdout] 168 | /                 match &self.left {
[INFO] [stdout] 169 | |                     &Some(ref node) => node.contains(val),
[INFO] [stdout] 170 | |                     &None => false
[INFO] [stdout] 171 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 168 ~                 match self.left {
[INFO] [stdout] 169 ~                     Some(ref node) => node.contains(val),
[INFO] [stdout] 170 ~                     None => false
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference
[INFO] [stdout]    --> src/tree.rs:169:21
[INFO] [stdout]     |
[INFO] [stdout] 169 |                     &Some(ref node) => node.contains(val),
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stdout] help: try removing the `&` and `ref` parts
[INFO] [stdout]     |
[INFO] [stdout] 169 -                     &Some(ref node) => node.contains(val),
[INFO] [stdout] 169 +                     Some(node) => node.contains(val),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stdout]    --> src/tree.rs:174:17
[INFO] [stdout]     |
[INFO] [stdout] 174 | /                 match &self.right {
[INFO] [stdout] 175 | |                     &Some(ref node) => node.contains(val),
[INFO] [stdout] 176 | |                     &None => false
[INFO] [stdout] 177 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 174 ~                 match self.right {
[INFO] [stdout] 175 ~                     Some(ref node) => node.contains(val),
[INFO] [stdout] 176 ~                     None => false
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference
[INFO] [stdout]    --> src/tree.rs:175:21
[INFO] [stdout]     |
[INFO] [stdout] 175 |                     &Some(ref node) => node.contains(val),
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stdout] help: try removing the `&` and `ref` parts
[INFO] [stdout]     |
[INFO] [stdout] 175 -                     &Some(ref node) => node.contains(val),
[INFO] [stdout] 175 +                     Some(node) => node.contains(val),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: deref which would be done by auto-deref
[INFO] [stdout]    --> src/tree.rs:186:13
[INFO] [stdout]     |
[INFO] [stdout] 186 |             (*node).value = val;
[INFO] [stdout]     |             ^^^^^^^ help: try: `node`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
[INFO] [stdout]     = note: `#[warn(clippy::explicit_auto_deref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/tree.rs:217:19
[INFO] [stdout]     |
[INFO] [stdout] 217 |         -1..=1 => return node,
[INFO] [stdout]     |                   ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 217 -         -1..=1 => return node,
[INFO] [stdout] 217 +         -1..=1 => node,
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calls to `push` immediately after creation
[INFO] [stdout]    --> src/lib.rs:155:9
[INFO] [stdout]     |
[INFO] [stdout] 155 | /         let mut xs: Vec<i32> = Vec::new();
[INFO] [stdout] 156 | |         xs.push(0);
[INFO] [stdout] 157 | |         xs.push(-1);
[INFO] [stdout] 158 | |         xs.push(1);
[INFO] [stdout] 159 | |         xs.push(2);
[INFO] [stdout]     | |___________________^ help: consider using the `vec![]` macro: `let xs: Vec<i32> = vec![..];`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push
[INFO] [stdout]     = note: `#[warn(clippy::vec_init_then_push)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stdout]    --> src/tree.rs:275:54
[INFO] [stdout]     |
[INFO] [stdout] 275 | fn remove_min<T: Ord>(node: Option<Box<Node<T>>>) -> (Option<Box<Node<T>>>, Option<Box<Node<T>>>) {
[INFO] [stdout]     |                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stdout]     = note: `#[warn(clippy::type_complexity)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/tree.rs:305:36
[INFO] [stdout]     |
[INFO] [stdout] 305 |     else if node.left.is_none() && !node.right.is_none() {
[INFO] [stdout]     |                                    ^^^^^^^^^^^^^^^^^^^^^ help: try: `node.right.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/tree.rs:308:37
[INFO] [stdout]     |
[INFO] [stdout] 308 |     else if node.right.is_none() && !node.left.is_none() {
[INFO] [stdout]     |                                     ^^^^^^^^^^^^^^^^^^^^ help: try: `node.left.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: local variable doesn't need to be boxed here
[INFO] [stdout]    --> src/tree.rs:300:34
[INFO] [stdout]     |
[INFO] [stdout] 300 | fn remove_in<T: PartialEq + Ord>(node : Box<Node<T>>)
[INFO] [stdout]     |                                  ^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local
[INFO] [stdout]     = note: `#[warn(clippy::boxed_local)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/tree.rs:303:9
[INFO] [stdout]     |
[INFO] [stdout] 303 |         return None;
[INFO] [stdout]     |         ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 303 -         return None;
[INFO] [stdout] 303 +         None
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/tree.rs:306:9
[INFO] [stdout]     |
[INFO] [stdout] 306 |         return node.right;
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 306 -         return node.right;
[INFO] [stdout] 306 +         node.right
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/tree.rs:309:9
[INFO] [stdout]     |
[INFO] [stdout] 309 |         return node.left;
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 309 -         return node.left;
[INFO] [stdout] 309 +         node.left
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::ops::Range<i32>`
[INFO] [stdout]  --> src/main.rs:6:16
[INFO] [stdout]   |
[INFO] [stdout] 6 |     let tree = (1..10).into_iter().collect::<Tree<_>>();
[INFO] [stdout]   |                ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(1..10)`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]   = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::ops::Range<i32>`
[INFO] [stdout]  --> src/main.rs:6:16
[INFO] [stdout]   |
[INFO] [stdout] 6 |     let tree = (1..10).into_iter().collect::<Tree<_>>();
[INFO] [stdout]   |                ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(1..10)`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]   = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.45s
[INFO] running `Command { std: "docker" "inspect" "4e9135326096321ff6aaa9270d5b313c4464eb105109f20b81924f1e1e2359d0", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "4e9135326096321ff6aaa9270d5b313c4464eb105109f20b81924f1e1e2359d0", kill_on_drop: false }`
[INFO] [stdout] 4e9135326096321ff6aaa9270d5b313c4464eb105109f20b81924f1e1e2359d0