[INFO] cloning repository https://github.com/losdmi/howyoudoin [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/losdmi/howyoudoin" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flosdmi%2Fhowyoudoin", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flosdmi%2Fhowyoudoin'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 77ba13b682e421c97951a15b4727cfb7ec8f77ac [INFO] linting losdmi/howyoudoin against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flosdmi%2Fhowyoudoin" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/losdmi/howyoudoin [INFO] finished tweaking git repo https://github.com/losdmi/howyoudoin [INFO] tweaked toml for git repo https://github.com/losdmi/howyoudoin written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/losdmi/howyoudoin on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/losdmi/howyoudoin already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4296a7338308299e280fb7be9f6f33d22f4fc5b59ed9a04301b0480e6ed7611e [INFO] running `Command { std: "docker" "start" "-a" "4296a7338308299e280fb7be9f6f33d22f4fc5b59ed9a04301b0480e6ed7611e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4296a7338308299e280fb7be9f6f33d22f4fc5b59ed9a04301b0480e6ed7611e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4296a7338308299e280fb7be9f6f33d22f4fc5b59ed9a04301b0480e6ed7611e", kill_on_drop: false }` [INFO] [stdout] 4296a7338308299e280fb7be9f6f33d22f4fc5b59ed9a04301b0480e6ed7611e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8b835645f4cb03e48865912861c53b6ac533806ef456d91a674c8d4ccb5d1a15 [INFO] running `Command { std: "docker" "start" "-a" "8b835645f4cb03e48865912861c53b6ac533806ef456d91a674c8d4ccb5d1a15", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.172 [INFO] [stderr] Compiling getrandom v0.3.2 [INFO] [stderr] Compiling zerocopy v0.8.25 [INFO] [stderr] Compiling rustix v1.0.7 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Checking bitflags v2.9.0 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking tempfile v3.19.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.1 [INFO] [stderr] Checking howyoudoin v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.16s [INFO] [stdout] warning: items after a test module [INFO] [stdout] --> src/lib.rs:71:1 [INFO] [stdout] | [INFO] [stdout] 71 | mod test { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 174 | const EPISODES: [&str; 234] = [ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_test_module [INFO] [stdout] = note: `#[warn(clippy::items_after_test_module)]` on by default [INFO] [stdout] = help: move the items to before the test module was defined [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:79:17 [INFO] [stdout] | [INFO] [stdout] 79 | assert!(!result.is_err(), "result is error: {result:#?}"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/lib.rs:80:20 [INFO] [stdout] | [INFO] [stdout] 80 | assert_eq!(result.unwrap(), Vec::::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: consider using `expect()` to provide a better panic message [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] = note: requested on the command line with `-W clippy::unwrap-used` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:93:17 [INFO] [stdout] | [INFO] [stdout] 93 | assert!(!result.is_err(), "result is error: {result:#?}"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/lib.rs:85:23 [INFO] [stdout] | [INFO] [stdout] 85 | let tmpfile = NamedTempFile::new().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: consider using `expect()` to provide a better panic message [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `into_owned` [INFO] [stdout] --> src/lib.rs:90:35 [INFO] [stdout] | [INFO] [stdout] 90 | .to_string_lossy() [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 91 | | .into_owned(), [INFO] [stdout] | |_____________________________^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/lib.rs:94:20 [INFO] [stdout] | [INFO] [stdout] 94 | assert_eq!(result.unwrap(), Vec::::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: consider using `expect()` to provide a better panic message [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:108:17 [INFO] [stdout] | [INFO] [stdout] 108 | assert!(!result.is_err(), "result is error: {result:#?}"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/lib.rs:99:27 [INFO] [stdout] | [INFO] [stdout] 99 | let mut tmpfile = NamedTempFile::new().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: consider using `expect()` to provide a better panic message [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/lib.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | writeln!(tmpfile, "s01e02\ns01e01\n").unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: consider using `expect()` to provide a better panic message [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `into_owned` [INFO] [stdout] --> src/lib.rs:105:35 [INFO] [stdout] | [INFO] [stdout] 105 | .to_string_lossy() [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 106 | | .into_owned(), [INFO] [stdout] | |_____________________________^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/lib.rs:109:20 [INFO] [stdout] | [INFO] [stdout] 109 | assert_eq!(result.unwrap(), vec!("s01e01", "s01e02")); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: consider using `expect()` to provide a better panic message [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:139:17 [INFO] [stdout] | [INFO] [stdout] 139 | assert!(!result.is_err(), "result is error: {result:#?}"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/lib.rs:130:27 [INFO] [stdout] | [INFO] [stdout] 130 | let mut tmpfile = NamedTempFile::new().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: consider using `expect()` to provide a better panic message [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `into_owned` [INFO] [stdout] --> src/lib.rs:136:35 [INFO] [stdout] | [INFO] [stdout] 136 | .to_string_lossy() [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 137 | | .into_owned(), [INFO] [stdout] | |_____________________________^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/lib.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 142 | / tmpfile [INFO] [stdout] 143 | | .read_to_string(&mut tmpfile_content) [INFO] [stdout] 144 | | .unwrap(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: consider using `expect()` to provide a better panic message [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:164:17 [INFO] [stdout] | [INFO] [stdout] 164 | assert!(!result.is_err(), "result is error: {result:#?}"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/lib.rs:150:27 [INFO] [stdout] | [INFO] [stdout] 150 | let mut tmpfile = NamedTempFile::new().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: consider using `expect()` to provide a better panic message [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `into_owned` [INFO] [stdout] --> src/lib.rs:161:35 [INFO] [stdout] | [INFO] [stdout] 161 | .to_string_lossy() [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 162 | | .into_owned(), [INFO] [stdout] | |_____________________________^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `unwrap()` on a `Result` value [INFO] [stdout] --> src/lib.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 167 | / tmpfile [INFO] [stdout] 168 | | .read_to_string(&mut tmpfile_content) [INFO] [stdout] 169 | | .unwrap(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = note: if this value is an `Err`, it will panic [INFO] [stdout] = help: consider using `expect()` to provide a better panic message [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/lib.rs:152:29 [INFO] [stdout] | [INFO] [stdout] 152 | let seen_episodes = vec!["s01e01", "s01e02"] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["s01e01", "s01e02"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "8b835645f4cb03e48865912861c53b6ac533806ef456d91a674c8d4ccb5d1a15", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8b835645f4cb03e48865912861c53b6ac533806ef456d91a674c8d4ccb5d1a15", kill_on_drop: false }` [INFO] [stdout] 8b835645f4cb03e48865912861c53b6ac533806ef456d91a674c8d4ccb5d1a15