[INFO] cloning repository https://github.com/lorenzo-vecchio/quickbase [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/lorenzo-vecchio/quickbase" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Florenzo-vecchio%2Fquickbase", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Florenzo-vecchio%2Fquickbase'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4a465d124165f810d8bddd0dbe28026b8a0d3aad [INFO] linting lorenzo-vecchio/quickbase against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Florenzo-vecchio%2Fquickbase" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/lorenzo-vecchio/quickbase [INFO] finished tweaking git repo https://github.com/lorenzo-vecchio/quickbase [INFO] tweaked toml for git repo https://github.com/lorenzo-vecchio/quickbase written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/lorenzo-vecchio/quickbase on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/lorenzo-vecchio/quickbase already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded jsonwebtoken v10.3.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ed0f6ebd65b2209b4babbbad50aa6bf6c4709482b222d5614784d24c5825fea8 [INFO] running `Command { std: "docker" "start" "-a" "ed0f6ebd65b2209b4babbbad50aa6bf6c4709482b222d5614784d24c5825fea8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ed0f6ebd65b2209b4babbbad50aa6bf6c4709482b222d5614784d24c5825fea8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ed0f6ebd65b2209b4babbbad50aa6bf6c4709482b222d5614784d24c5825fea8", kill_on_drop: false }` [INFO] [stdout] ed0f6ebd65b2209b4babbbad50aa6bf6c4709482b222d5614784d24c5825fea8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 549647792e40ede5d8d24f407c9e0878a3b441f651f8ca4813813e6367897156 [INFO] running `Command { std: "docker" "start" "-a" "549647792e40ede5d8d24f407c9e0878a3b441f651f8ca4813813e6367897156", kill_on_drop: false }` [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling stable_deref_trait v1.2.1 [INFO] [stderr] Checking base64ct v1.8.3 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling libc v0.2.182 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling writeable v0.6.2 [INFO] [stderr] Compiling smallvec v1.15.1 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling litemap v0.8.1 [INFO] [stderr] Compiling thiserror v2.0.18 [INFO] [stderr] Checking futures-sink v0.3.32 [INFO] [stderr] Compiling pin-project-lite v0.2.17 [INFO] [stderr] Compiling futures-core v0.3.32 [INFO] [stderr] Compiling icu_properties_data v2.1.2 [INFO] [stderr] Compiling icu_normalizer_data v2.1.1 [INFO] [stderr] Compiling libsqlite3-sys v0.30.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Compiling percent-encoding v2.3.2 [INFO] [stderr] Compiling zerocopy v0.8.40 [INFO] [stderr] Checking ff v0.13.1 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling foldhash v0.1.5 [INFO] [stderr] Checking der v0.7.10 [INFO] [stderr] Compiling form_urlencoded v1.2.2 [INFO] [stderr] Compiling futures-io v0.3.32 [INFO] [stderr] Compiling allocator-api2 v0.2.21 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Compiling bytes v1.11.1 [INFO] [stderr] Compiling slab v0.4.12 [INFO] [stderr] Compiling futures-task v0.3.32 [INFO] [stderr] Compiling utf8_iter v1.0.4 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling concurrent-queue v2.5.0 [INFO] [stderr] Compiling socket2 v0.6.2 [INFO] [stderr] Compiling parking_lot_core v0.9.12 [INFO] [stderr] Compiling mio v1.1.1 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Compiling parking_lot v0.12.5 [INFO] [stderr] Compiling hashbrown v0.15.5 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Compiling tracing-core v0.1.36 [INFO] [stderr] Compiling zmij v1.0.21 [INFO] [stderr] Compiling tokio v1.50.0 [INFO] [stderr] Compiling parking v2.2.1 [INFO] [stderr] Compiling crc-catalog v2.4.0 [INFO] [stderr] Compiling cpufeatures v0.2.17 [INFO] [stderr] Compiling event-listener v5.4.1 [INFO] [stderr] Compiling crc v3.4.0 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Compiling indexmap v2.13.0 [INFO] [stderr] Compiling getrandom v0.4.2 [INFO] [stderr] Compiling hashlink v0.10.0 [INFO] [stderr] Compiling futures-intrusive v0.5.0 [INFO] [stderr] Compiling crossbeam-queue v0.3.12 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Compiling bitflags v2.11.0 [INFO] [stderr] Compiling linux-raw-sys v0.12.1 [INFO] [stderr] Compiling flume v0.11.1 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking rand_core v0.10.0 [INFO] [stderr] Compiling atoi v2.0.0 [INFO] [stderr] Compiling num-bigint-dig v0.8.6 [INFO] [stderr] Compiling num-conv v0.2.0 [INFO] [stderr] Compiling time-core v0.1.8 [INFO] [stderr] Compiling rustix v1.1.4 [INFO] [stderr] Checking deranged v0.5.8 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Compiling time-macros v0.2.27 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking primeorder v0.13.6 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Compiling dotenvy v0.15.7 [INFO] [stderr] Compiling hex v0.4.3 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking cpufeatures v0.3.0 [INFO] [stderr] Checking pem v3.0.6 [INFO] [stderr] Checking chacha20 v0.10.0 [INFO] [stderr] Checking p384 v0.13.1 [INFO] [stderr] Checking p256 v0.13.2 [INFO] [stderr] Checking serde_path_to_error v0.1.20 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking futures-executor v0.3.32 [INFO] [stderr] Checking password-hash v0.5.0 [INFO] [stderr] Compiling include_dir_macros v0.7.4 [INFO] [stderr] Checking tempfile v3.26.0 [INFO] [stderr] Checking rand v0.10.0 [INFO] [stderr] Checking include_dir v0.7.4 [INFO] [stderr] Checking argon2 v0.5.3 [INFO] [stderr] Checking time v0.3.47 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling tokio-macros v2.6.1 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking curve25519-dalek v4.1.3 [INFO] [stderr] Compiling zerofrom v0.1.6 [INFO] [stderr] Compiling yoke v0.8.1 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking axum-core v0.5.6 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking simple_asn1 v0.6.4 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking ed25519-dalek v2.2.0 [INFO] [stderr] Compiling tokio-stream v0.1.18 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking rsa v0.9.10 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Compiling serde_urlencoded v0.7.1 [INFO] [stderr] Checking jsonwebtoken v10.3.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking sqlx-core v0.8.3 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Checking axum v0.8.8 [INFO] [stderr] Checking sqlx-sqlite v0.8.3 [INFO] [stderr] Compiling sqlx-macros-core v0.8.3 [INFO] [stderr] Compiling sqlx-macros v0.8.3 [INFO] [stderr] Checking sqlx v0.8.3 [INFO] [stderr] Checking quickbase v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/models/collection.rs:15:1 [INFO] [stdout] | [INFO] [stdout] 15 | / impl Default for CollectionType { [INFO] [stdout] 16 | | fn default() -> Self { [INFO] [stdout] 17 | | Self::Base [INFO] [stdout] 18 | | } [INFO] [stdout] 19 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Default)] [INFO] [stdout] 10 | pub enum CollectionType { [INFO] [stdout] 11 ~ #[default] [INFO] [stdout] 12 ~ Base, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/models/record.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | / if let Some(v) = data.remove("id") { [INFO] [stdout] 124 | | if let Some(id) = v.as_str() { [INFO] [stdout] 125 | | self.base.id = id.to_string(); [INFO] [stdout] 126 | | self.base.mark_as_not_new(); [INFO] [stdout] 127 | | } [INFO] [stdout] 128 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 123 ~ if let Some(v) = data.remove("id") [INFO] [stdout] 124 ~ && let Some(id) = v.as_str() { [INFO] [stdout] 125 | self.base.id = id.to_string(); [INFO] [stdout] 126 | self.base.mark_as_not_new(); [INFO] [stdout] 127 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/models/record.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 129 | / if let Some(v) = data.remove("created") { [INFO] [stdout] 130 | | if let Some(s) = v.as_str() { [INFO] [stdout] 131 | | self.created = s.to_string(); [INFO] [stdout] 132 | | } [INFO] [stdout] 133 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 129 ~ if let Some(v) = data.remove("created") [INFO] [stdout] 130 ~ && let Some(s) = v.as_str() { [INFO] [stdout] 131 | self.created = s.to_string(); [INFO] [stdout] 132 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/models/record.rs:134:9 [INFO] [stdout] | [INFO] [stdout] 134 | / if let Some(v) = data.remove("updated") { [INFO] [stdout] 135 | | if let Some(s) = v.as_str() { [INFO] [stdout] 136 | | self.updated = s.to_string(); [INFO] [stdout] 137 | | } [INFO] [stdout] 138 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 134 ~ if let Some(v) = data.remove("updated") [INFO] [stdout] 135 ~ && let Some(s) = v.as_str() { [INFO] [stdout] 136 | self.updated = s.to_string(); [INFO] [stdout] 137 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/apis/records.rs:176:20 [INFO] [stdout] | [INFO] [stdout] 176 | let per_page = q.per_page.min(500).max(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `q.per_page.clamp(1, 500)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/apis/admin.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | / if let Ok(v) = serde_json::from_str::(&value) { [INFO] [stdout] 105 | | if let Some(obj) = settings.as_object_mut() { [INFO] [stdout] 106 | | // key format: "section.field" or "section" [INFO] [stdout] 107 | | let parts: Vec<&str> = key.splitn(2, '.').collect(); [INFO] [stdout] ... | [INFO] [stdout] 118 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 104 ~ if let Ok(v) = serde_json::from_str::(&value) [INFO] [stdout] 105 ~ && let Some(obj) = settings.as_object_mut() { [INFO] [stdout] 106 | // key format: "section.field" or "section" [INFO] [stdout] ... [INFO] [stdout] 116 | } [INFO] [stdout] 117 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/apis/admin.rs:109:25 [INFO] [stdout] | [INFO] [stdout] 109 | / if let Some(section) = obj.get_mut(parts[0]) { [INFO] [stdout] 110 | | if let Some(section_obj) = section.as_object_mut() { [INFO] [stdout] 111 | | section_obj.insert(parts[1].to_string(), v); [INFO] [stdout] 112 | | } [INFO] [stdout] 113 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 109 ~ if let Some(section) = obj.get_mut(parts[0]) [INFO] [stdout] 110 ~ && let Some(section_obj) = section.as_object_mut() { [INFO] [stdout] 111 | section_obj.insert(parts[1].to_string(), v); [INFO] [stdout] 112 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/apis/logs.rs:57:20 [INFO] [stdout] | [INFO] [stdout] 57 | let per_page = q.per_page.min(500).max(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `q.per_page.clamp(1, 500)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/models/collection.rs:15:1 [INFO] [stdout] | [INFO] [stdout] 15 | / impl Default for CollectionType { [INFO] [stdout] 16 | | fn default() -> Self { [INFO] [stdout] 17 | | Self::Base [INFO] [stdout] 18 | | } [INFO] [stdout] 19 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Default)] [INFO] [stdout] 10 | pub enum CollectionType { [INFO] [stdout] 11 ~ #[default] [INFO] [stdout] 12 ~ Base, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `FormError` [INFO] [stdout] --> src/forms/errors.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | / pub fn new() -> Self { [INFO] [stdout] 23 | | Self { [INFO] [stdout] 24 | | data: HashMap::new(), [INFO] [stdout] 25 | | } [INFO] [stdout] 26 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 21 + impl Default for FormError { [INFO] [stdout] 22 + fn default() -> Self { [INFO] [stdout] 23 + Self::new() [INFO] [stdout] 24 + } [INFO] [stdout] 25 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/forms/collection_upsert.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | / if let Some(t) = data.get("type").and_then(|v| v.as_str()) { [INFO] [stdout] 30 | | if let Ok(ct) = t.parse() { [INFO] [stdout] 31 | | self.collection.collection_type = ct; [INFO] [stdout] 32 | | } [INFO] [stdout] 33 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 29 ~ if let Some(t) = data.get("type").and_then(|v| v.as_str()) [INFO] [stdout] 30 ~ && let Ok(ct) = t.parse() { [INFO] [stdout] 31 | self.collection.collection_type = ct; [INFO] [stdout] 32 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/forms/collection_upsert.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | / if let Some(fields) = fields_val { [INFO] [stdout] 37 | | if let Ok(parsed) = serde_json::from_value::>(fields.clone()) { [INFO] [stdout] 38 | | self.collection.schema = crate::db::Json(parsed); [INFO] [stdout] 39 | | } [INFO] [stdout] 40 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 36 ~ if let Some(fields) = fields_val [INFO] [stdout] 37 ~ && let Ok(parsed) = serde_json::from_value::>(fields.clone()) { [INFO] [stdout] 38 | self.collection.schema = crate::db::Json(parsed); [INFO] [stdout] 39 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/models/record.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | / if let Some(v) = data.remove("id") { [INFO] [stdout] 124 | | if let Some(id) = v.as_str() { [INFO] [stdout] 125 | | self.base.id = id.to_string(); [INFO] [stdout] 126 | | self.base.mark_as_not_new(); [INFO] [stdout] 127 | | } [INFO] [stdout] 128 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 123 ~ if let Some(v) = data.remove("id") [INFO] [stdout] 124 ~ && let Some(id) = v.as_str() { [INFO] [stdout] 125 | self.base.id = id.to_string(); [INFO] [stdout] 126 | self.base.mark_as_not_new(); [INFO] [stdout] 127 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/models/record.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 129 | / if let Some(v) = data.remove("created") { [INFO] [stdout] 130 | | if let Some(s) = v.as_str() { [INFO] [stdout] 131 | | self.created = s.to_string(); [INFO] [stdout] 132 | | } [INFO] [stdout] 133 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 129 ~ if let Some(v) = data.remove("created") [INFO] [stdout] 130 ~ && let Some(s) = v.as_str() { [INFO] [stdout] 131 | self.created = s.to_string(); [INFO] [stdout] 132 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/models/record.rs:134:9 [INFO] [stdout] | [INFO] [stdout] 134 | / if let Some(v) = data.remove("updated") { [INFO] [stdout] 135 | | if let Some(s) = v.as_str() { [INFO] [stdout] 136 | | self.updated = s.to_string(); [INFO] [stdout] 137 | | } [INFO] [stdout] 138 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 134 ~ if let Some(v) = data.remove("updated") [INFO] [stdout] 135 ~ && let Some(s) = v.as_str() { [INFO] [stdout] 136 | self.updated = s.to_string(); [INFO] [stdout] 137 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/forms/record_upsert.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | / if self.record.collection.is_auth() { [INFO] [stdout] 109 | | if let (Some(pw), Some(confirm)) = (&self.password, &self.password_confirm) { [INFO] [stdout] 110 | | if pw != confirm { [INFO] [stdout] 111 | | err.add("passwordConfirm", "validation_mismatch", "passwords do not match.".to_string()); [INFO] [stdout] ... | [INFO] [stdout] 114 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 108 ~ if self.record.collection.is_auth() [INFO] [stdout] 109 ~ && let (Some(pw), Some(confirm)) = (&self.password, &self.password_confirm) { [INFO] [stdout] 110 | if pw != confirm { [INFO] [stdout] 111 | err.add("passwordConfirm", "validation_mismatch", "passwords do not match.".to_string()); [INFO] [stdout] 112 | } [INFO] [stdout] 113 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/forms/record_upsert.rs:109:13 [INFO] [stdout] | [INFO] [stdout] 109 | / if let (Some(pw), Some(confirm)) = (&self.password, &self.password_confirm) { [INFO] [stdout] 110 | | if pw != confirm { [INFO] [stdout] 111 | | err.add("passwordConfirm", "validation_mismatch", "passwords do not match.".to_string()); [INFO] [stdout] 112 | | } [INFO] [stdout] 113 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 109 ~ if let (Some(pw), Some(confirm)) = (&self.password, &self.password_confirm) [INFO] [stdout] 110 ~ && pw != confirm { [INFO] [stdout] 111 | err.add("passwordConfirm", "validation_mismatch", "passwords do not match.".to_string()); [INFO] [stdout] 112 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/apis/records.rs:176:20 [INFO] [stdout] | [INFO] [stdout] 176 | let per_page = q.per_page.min(500).max(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `q.per_page.clamp(1, 500)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/apis/admin.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | / if let Ok(v) = serde_json::from_str::(&value) { [INFO] [stdout] 105 | | if let Some(obj) = settings.as_object_mut() { [INFO] [stdout] 106 | | // key format: "section.field" or "section" [INFO] [stdout] 107 | | let parts: Vec<&str> = key.splitn(2, '.').collect(); [INFO] [stdout] ... | [INFO] [stdout] 118 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 104 ~ if let Ok(v) = serde_json::from_str::(&value) [INFO] [stdout] 105 ~ && let Some(obj) = settings.as_object_mut() { [INFO] [stdout] 106 | // key format: "section.field" or "section" [INFO] [stdout] ... [INFO] [stdout] 116 | } [INFO] [stdout] 117 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/apis/admin.rs:109:25 [INFO] [stdout] | [INFO] [stdout] 109 | / if let Some(section) = obj.get_mut(parts[0]) { [INFO] [stdout] 110 | | if let Some(section_obj) = section.as_object_mut() { [INFO] [stdout] 111 | | section_obj.insert(parts[1].to_string(), v); [INFO] [stdout] 112 | | } [INFO] [stdout] 113 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 109 ~ if let Some(section) = obj.get_mut(parts[0]) [INFO] [stdout] 110 ~ && let Some(section_obj) = section.as_object_mut() { [INFO] [stdout] 111 | section_obj.insert(parts[1].to_string(), v); [INFO] [stdout] 112 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/apis/logs.rs:57:20 [INFO] [stdout] | [INFO] [stdout] 57 | let per_page = q.per_page.min(500).max(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `q.per_page.clamp(1, 500)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `FormError` [INFO] [stdout] --> src/forms/errors.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | / pub fn new() -> Self { [INFO] [stdout] 23 | | Self { [INFO] [stdout] 24 | | data: HashMap::new(), [INFO] [stdout] 25 | | } [INFO] [stdout] 26 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 21 + impl Default for FormError { [INFO] [stdout] 22 + fn default() -> Self { [INFO] [stdout] 23 + Self::new() [INFO] [stdout] 24 + } [INFO] [stdout] 25 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/forms/collection_upsert.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | / if let Some(t) = data.get("type").and_then(|v| v.as_str()) { [INFO] [stdout] 30 | | if let Ok(ct) = t.parse() { [INFO] [stdout] 31 | | self.collection.collection_type = ct; [INFO] [stdout] 32 | | } [INFO] [stdout] 33 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 29 ~ if let Some(t) = data.get("type").and_then(|v| v.as_str()) [INFO] [stdout] 30 ~ && let Ok(ct) = t.parse() { [INFO] [stdout] 31 | self.collection.collection_type = ct; [INFO] [stdout] 32 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/forms/collection_upsert.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | / if let Some(fields) = fields_val { [INFO] [stdout] 37 | | if let Ok(parsed) = serde_json::from_value::>(fields.clone()) { [INFO] [stdout] 38 | | self.collection.schema = crate::db::Json(parsed); [INFO] [stdout] 39 | | } [INFO] [stdout] 40 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 36 ~ if let Some(fields) = fields_val [INFO] [stdout] 37 ~ && let Ok(parsed) = serde_json::from_value::>(fields.clone()) { [INFO] [stdout] 38 | self.collection.schema = crate::db::Json(parsed); [INFO] [stdout] 39 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/forms/record_upsert.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | / if self.record.collection.is_auth() { [INFO] [stdout] 109 | | if let (Some(pw), Some(confirm)) = (&self.password, &self.password_confirm) { [INFO] [stdout] 110 | | if pw != confirm { [INFO] [stdout] 111 | | err.add("passwordConfirm", "validation_mismatch", "passwords do not match.".to_string()); [INFO] [stdout] ... | [INFO] [stdout] 114 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 108 ~ if self.record.collection.is_auth() [INFO] [stdout] 109 ~ && let (Some(pw), Some(confirm)) = (&self.password, &self.password_confirm) { [INFO] [stdout] 110 | if pw != confirm { [INFO] [stdout] 111 | err.add("passwordConfirm", "validation_mismatch", "passwords do not match.".to_string()); [INFO] [stdout] 112 | } [INFO] [stdout] 113 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/forms/record_upsert.rs:109:13 [INFO] [stdout] | [INFO] [stdout] 109 | / if let (Some(pw), Some(confirm)) = (&self.password, &self.password_confirm) { [INFO] [stdout] 110 | | if pw != confirm { [INFO] [stdout] 111 | | err.add("passwordConfirm", "validation_mismatch", "passwords do not match.".to_string()); [INFO] [stdout] 112 | | } [INFO] [stdout] 113 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 109 ~ if let (Some(pw), Some(confirm)) = (&self.password, &self.password_confirm) [INFO] [stdout] 110 ~ && pw != confirm { [INFO] [stdout] 111 | err.add("passwordConfirm", "validation_mismatch", "passwords do not match.".to_string()); [INFO] [stdout] 112 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 08s [INFO] running `Command { std: "docker" "inspect" "549647792e40ede5d8d24f407c9e0878a3b441f651f8ca4813813e6367897156", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "549647792e40ede5d8d24f407c9e0878a3b441f651f8ca4813813e6367897156", kill_on_drop: false }` [INFO] [stdout] 549647792e40ede5d8d24f407c9e0878a3b441f651f8ca4813813e6367897156