[INFO] cloning repository https://github.com/logmatter/magic-pancakes [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/logmatter/magic-pancakes" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flogmatter%2Fmagic-pancakes", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flogmatter%2Fmagic-pancakes'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5c3f513449bfb7fbc25f14956da6c425f96d94f4 [INFO] linting logmatter/magic-pancakes against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flogmatter%2Fmagic-pancakes" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/logmatter/magic-pancakes [INFO] finished tweaking git repo https://github.com/logmatter/magic-pancakes [INFO] tweaked toml for git repo https://github.com/logmatter/magic-pancakes written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/logmatter/magic-pancakes on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/logmatter/magic-pancakes already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded clap_derive v3.0.2 [INFO] [stderr] Downloaded pbr v1.0.4 [INFO] [stderr] Downloaded clap v3.0.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] beb3bafb99237a3d7968122541a2614da35fdcb07a85893d8eb7d02ab75f7525 [INFO] running `Command { std: "docker" "start" "-a" "beb3bafb99237a3d7968122541a2614da35fdcb07a85893d8eb7d02ab75f7525", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "beb3bafb99237a3d7968122541a2614da35fdcb07a85893d8eb7d02ab75f7525", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "beb3bafb99237a3d7968122541a2614da35fdcb07a85893d8eb7d02ab75f7525", kill_on_drop: false }` [INFO] [stdout] beb3bafb99237a3d7968122541a2614da35fdcb07a85893d8eb7d02ab75f7525 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9c11f2b185ef414c1b696cee1810d73aa196e61ae5f2369007ff44bcf6a85350 [INFO] running `Command { std: "docker" "start" "-a" "9c11f2b185ef414c1b696cee1810d73aa196e61ae5f2369007ff44bcf6a85350", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.112 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling syn v1.0.84 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Compiling crc32fast v1.3.0 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Checking weezl v0.1.5 [INFO] [stderr] Compiling serde v1.0.133 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Compiling serde_derive v1.0.133 [INFO] [stderr] Compiling serde_json v1.0.74 [INFO] [stderr] Compiling anyhow v1.0.52 [INFO] [stderr] Checking gif v0.11.3 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Checking bytemuck v1.7.3 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking textwrap v0.14.2 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking crossbeam-epoch v0.9.5 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Compiling quote v1.0.14 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking pbr v1.0.4 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking tiff v0.6.1 [INFO] [stderr] Compiling clap_derive v3.0.2 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Checking clap v3.0.4 [INFO] [stderr] Checking pancakes v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/generate.rs:72:44 [INFO] [stdout] | [INFO] [stdout] 72 | uri: get_picked_layer_item_uri(&layers_path, &layer_name, &value.picked_layer_item), [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `layers_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/commands/generate.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 87 | items_sorted.sort_by(|a, b| a.priority.cmp(&b.priority)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 87 - items_sorted.sort_by(|a, b| a.priority.cmp(&b.priority)); [INFO] [stdout] 87 + items_sorted.sort_by_key(|a| a.priority); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `items_sorted` [INFO] [stdout] --> src/commands/generate.rs:107:22 [INFO] [stdout] | [INFO] [stdout] 107 | for i in 1..items_sorted.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 107 - for i in 1..items_sorted.len() { [INFO] [stdout] 107 + for in items_sorted.iter().skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/commands/generate.rs:154:1 [INFO] [stdout] | [INFO] [stdout] 154 | / fn generate_item( [INFO] [stdout] 155 | | layers_config: HashMap, [INFO] [stdout] 156 | | json_template: Metadata, [INFO] [stdout] 157 | | layers_path: &String, [INFO] [stdout] ... | [INFO] [stdout] 163 | | filter_type: FilterType, [INFO] [stdout] 164 | | ) -> Result<(Metadata, String, String)> { [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/generate.rs:171:9 [INFO] [stdout] | [INFO] [stdout] 171 | &file_name_no_ext, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `file_name_no_ext` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/generate.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 173 | &output_format, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `output_format` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/generate.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 181 | &file_name_no_ext, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `file_name_no_ext` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/generate.rs:184:9 [INFO] [stdout] | [INFO] [stdout] 184 | &output_format, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `output_format` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands/generate.rs:202:63 [INFO] [stdout] | [INFO] [stdout] 202 | if (output_format != "jpg" && output_format != "jpeg") && !unparsed_jpeg_quality.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unparsed_jpeg_quality.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands/generate.rs:204:41 [INFO] [stdout] | [INFO] [stdout] 204 | } else if output_format != "png" && !unparsed_png_compression_type.is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unparsed_png_compression_type.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands/generate.rs:205:12 [INFO] [stdout] | [INFO] [stdout] 205 | || !unparsed_png_filter_type.is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unparsed_png_filter_type.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/commands/generate.rs:190:1 [INFO] [stdout] | [INFO] [stdout] 190 | / pub fn exec( [INFO] [stdout] 191 | | amount: u32, [INFO] [stdout] 192 | | json_template_path: String, [INFO] [stdout] 193 | | layers_config_path: String, [INFO] [stdout] ... | [INFO] [stdout] 200 | | unparsed_png_filter_type: Option, [INFO] [stdout] 201 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> src/commands/generate.rs:210:19 [INFO] [stdout] | [INFO] [stdout] 210 | let quality = match unparsed_jpeg_quality { [INFO] [stdout] | ___________________^ [INFO] [stdout] 211 | | Some(quality) => quality, [INFO] [stdout] 212 | | None => 90, [INFO] [stdout] 213 | | }; [INFO] [stdout] | |_____^ help: replace with: `unparsed_jpeg_quality.unwrap_or(90)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/commands/generate.rs:256:5 [INFO] [stdout] | [INFO] [stdout] 256 | / match mkdirp(Path::new(&output_path)) { [INFO] [stdout] 257 | | Err(e) => panic!("Error mkdirp {}", e), [INFO] [stdout] 258 | | _ => (), [INFO] [stdout] 259 | | }; [INFO] [stdout] | |_____^ help: try: `if let Err(e) = mkdirp(Path::new(&output_path)) { panic!("Error mkdirp {}", e) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/commands/generate.rs:278:23 [INFO] [stdout] | [INFO] [stdout] 278 | let quality = quality.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `quality` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `CompressionType` which implements the `Copy` trait [INFO] [stdout] --> src/commands/generate.rs:279:27 [INFO] [stdout] | [INFO] [stdout] 279 | let compression = compression.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `compression` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `FilterType` which implements the `Copy` trait [INFO] [stdout] --> src/commands/generate.rs:280:22 [INFO] [stdout] | [INFO] [stdout] 280 | let filter = filter.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `filter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/tools/mkdirp.rs:25:24 [INFO] [stdout] | [INFO] [stdout] 25 | return Err(io::Error::new( [INFO] [stdout] | ________________________^ [INFO] [stdout] 26 | | io::ErrorKind::Other, [INFO] [stdout] 27 | | "failed to create whole tree", [INFO] [stdout] 28 | | )) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 25 ~ return Err(io::Error::other( [INFO] [stdout] 26 ~ "failed to create whole tree", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/generate.rs:72:44 [INFO] [stdout] | [INFO] [stdout] 72 | uri: get_picked_layer_item_uri(&layers_path, &layer_name, &value.picked_layer_item), [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `layers_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/commands/generate.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 87 | items_sorted.sort_by(|a, b| a.priority.cmp(&b.priority)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 87 - items_sorted.sort_by(|a, b| a.priority.cmp(&b.priority)); [INFO] [stdout] 87 + items_sorted.sort_by_key(|a| a.priority); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `items_sorted` [INFO] [stdout] --> src/commands/generate.rs:107:22 [INFO] [stdout] | [INFO] [stdout] 107 | for i in 1..items_sorted.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 107 - for i in 1..items_sorted.len() { [INFO] [stdout] 107 + for in items_sorted.iter().skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/commands/generate.rs:154:1 [INFO] [stdout] | [INFO] [stdout] 154 | / fn generate_item( [INFO] [stdout] 155 | | layers_config: HashMap, [INFO] [stdout] 156 | | json_template: Metadata, [INFO] [stdout] 157 | | layers_path: &String, [INFO] [stdout] ... | [INFO] [stdout] 163 | | filter_type: FilterType, [INFO] [stdout] 164 | | ) -> Result<(Metadata, String, String)> { [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/generate.rs:171:9 [INFO] [stdout] | [INFO] [stdout] 171 | &file_name_no_ext, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `file_name_no_ext` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/generate.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 173 | &output_format, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `output_format` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/generate.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 181 | &file_name_no_ext, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `file_name_no_ext` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/generate.rs:184:9 [INFO] [stdout] | [INFO] [stdout] 184 | &output_format, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `output_format` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands/generate.rs:202:63 [INFO] [stdout] | [INFO] [stdout] 202 | if (output_format != "jpg" && output_format != "jpeg") && !unparsed_jpeg_quality.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unparsed_jpeg_quality.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands/generate.rs:204:41 [INFO] [stdout] | [INFO] [stdout] 204 | } else if output_format != "png" && !unparsed_png_compression_type.is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unparsed_png_compression_type.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands/generate.rs:205:12 [INFO] [stdout] | [INFO] [stdout] 205 | || !unparsed_png_filter_type.is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unparsed_png_filter_type.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/commands/generate.rs:190:1 [INFO] [stdout] | [INFO] [stdout] 190 | / pub fn exec( [INFO] [stdout] 191 | | amount: u32, [INFO] [stdout] 192 | | json_template_path: String, [INFO] [stdout] 193 | | layers_config_path: String, [INFO] [stdout] ... | [INFO] [stdout] 200 | | unparsed_png_filter_type: Option, [INFO] [stdout] 201 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> src/commands/generate.rs:210:19 [INFO] [stdout] | [INFO] [stdout] 210 | let quality = match unparsed_jpeg_quality { [INFO] [stdout] | ___________________^ [INFO] [stdout] 211 | | Some(quality) => quality, [INFO] [stdout] 212 | | None => 90, [INFO] [stdout] 213 | | }; [INFO] [stdout] | |_____^ help: replace with: `unparsed_jpeg_quality.unwrap_or(90)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/commands/generate.rs:256:5 [INFO] [stdout] | [INFO] [stdout] 256 | / match mkdirp(Path::new(&output_path)) { [INFO] [stdout] 257 | | Err(e) => panic!("Error mkdirp {}", e), [INFO] [stdout] 258 | | _ => (), [INFO] [stdout] 259 | | }; [INFO] [stdout] | |_____^ help: try: `if let Err(e) = mkdirp(Path::new(&output_path)) { panic!("Error mkdirp {}", e) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/commands/generate.rs:278:23 [INFO] [stdout] | [INFO] [stdout] 278 | let quality = quality.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `quality` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `CompressionType` which implements the `Copy` trait [INFO] [stdout] --> src/commands/generate.rs:279:27 [INFO] [stdout] | [INFO] [stdout] 279 | let compression = compression.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `compression` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `FilterType` which implements the `Copy` trait [INFO] [stdout] --> src/commands/generate.rs:280:22 [INFO] [stdout] | [INFO] [stdout] 280 | let filter = filter.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `filter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/tools/mkdirp.rs:25:24 [INFO] [stdout] | [INFO] [stdout] 25 | return Err(io::Error::new( [INFO] [stdout] | ________________________^ [INFO] [stdout] 26 | | io::ErrorKind::Other, [INFO] [stdout] 27 | | "failed to create whole tree", [INFO] [stdout] 28 | | )) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 25 ~ return Err(io::Error::other( [INFO] [stdout] 26 ~ "failed to create whole tree", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 18.86s [INFO] running `Command { std: "docker" "inspect" "9c11f2b185ef414c1b696cee1810d73aa196e61ae5f2369007ff44bcf6a85350", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9c11f2b185ef414c1b696cee1810d73aa196e61ae5f2369007ff44bcf6a85350", kill_on_drop: false }` [INFO] [stdout] 9c11f2b185ef414c1b696cee1810d73aa196e61ae5f2369007ff44bcf6a85350