[INFO] cloning repository https://github.com/logan-gatlin/holdem [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/logan-gatlin/holdem" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flogan-gatlin%2Fholdem", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flogan-gatlin%2Fholdem'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 601ad6a5b67384273b95bed2b495354c2ce5a1c8 [INFO] linting logan-gatlin/holdem against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flogan-gatlin%2Fholdem" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/logan-gatlin/holdem [INFO] finished tweaking git repo https://github.com/logan-gatlin/holdem [INFO] tweaked toml for git repo https://github.com/logan-gatlin/holdem written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/logan-gatlin/holdem on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/logan-gatlin/holdem already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.104 [INFO] [stderr] Downloaded wasm-bindgen-backend v0.2.104 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.104 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.104 [INFO] [stderr] Downloaded wasm-bindgen v0.2.104 [INFO] [stderr] Downloaded wasm-bindgen-futures v0.4.54 [INFO] [stderr] Downloaded ordered-float v5.0.0 [INFO] [stderr] Downloaded accesskit_macos v0.22.1 [INFO] [stderr] Downloaded accesskit_consumer v0.30.1 [INFO] [stderr] Downloaded accesskit_windows v0.29.1 [INFO] [stderr] Downloaded flate2 v1.1.4 [INFO] [stderr] Downloaded cc v1.2.41 [INFO] [stderr] Downloaded js-sys v0.3.81 [INFO] [stderr] Downloaded accesskit_winit v0.29.1 [INFO] [stderr] Downloaded accesskit_atspi_common v0.14.1 [INFO] [stderr] Downloaded accesskit_unix v0.17.1 [INFO] [stderr] Downloaded moxcms v0.7.7 [INFO] [stderr] Downloaded syn v2.0.107 [INFO] [stderr] Downloaded wgpu-core v27.0.1 [INFO] [stderr] Downloaded wgpu-hal v27.0.2 [INFO] [stderr] Downloaded web-sys v0.3.81 [INFO] [stderr] Downloaded naga v27.0.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a1aa5445a232ee9a0f89b4f382f7243952c2a431571b85894ba9652a0869d37a [INFO] running `Command { std: "docker" "start" "-a" "a1aa5445a232ee9a0f89b4f382f7243952c2a431571b85894ba9652a0869d37a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a1aa5445a232ee9a0f89b4f382f7243952c2a431571b85894ba9652a0869d37a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a1aa5445a232ee9a0f89b4f382f7243952c2a431571b85894ba9652a0869d37a", kill_on_drop: false }` [INFO] [stdout] a1aa5445a232ee9a0f89b4f382f7243952c2a431571b85894ba9652a0869d37a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f9b18136b1529afc0410a9ec8c78ade1644677fcca0071733fef4630d77e1965 [INFO] running `Command { std: "docker" "start" "-a" "f9b18136b1529afc0410a9ec8c78ade1644677fcca0071733fef4630d77e1965", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Compiling quote v1.0.41 [INFO] [stderr] Compiling unicode-ident v1.0.19 [INFO] [stderr] Checking stable_deref_trait v1.2.1 [INFO] [stderr] Compiling cc v1.2.41 [INFO] [stderr] Checking async-io v2.6.0 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking async-lock v3.4.1 [INFO] [stderr] Checking async-executor v1.13.3 [INFO] [stderr] Compiling xml-rs v0.8.27 [INFO] [stderr] Checking flate2 v1.1.4 [INFO] [stderr] Checking accesskit_consumer v0.30.1 [INFO] [stderr] Checking moxcms v0.7.7 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Compiling litrs v0.4.2 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Compiling document-features v0.2.11 [INFO] [stderr] Checking png v0.18.0 [INFO] [stderr] Checking async-signal v0.2.13 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking async-process v2.5.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking syn v2.0.107 [INFO] [stderr] Compiling wayland-scanner v0.31.7 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling glutin_glx_sys v0.6.1 [INFO] [stderr] Compiling glutin_egl_sys v0.7.1 [INFO] [stderr] Compiling wayland-backend v0.3.11 [INFO] [stderr] Checking glutin v0.32.3 [INFO] [stderr] Checking wayland-client v0.31.11 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking wayland-protocols v0.32.9 [INFO] [stderr] Checking wayland-cursor v0.31.11 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking emath v0.33.0 [INFO] [stderr] Checking image v0.25.8 [INFO] [stderr] Checking ecolor v0.33.0 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.3 [INFO] [stderr] Checking epaint v0.33.0 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking egui v0.33.0 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking arboard v3.6.1 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.9 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.9 [INFO] [stderr] Compiling zvariant_utils v3.2.1 [INFO] [stderr] Compiling enumflags2 v0.7.12 [INFO] [stderr] Compiling quick-xml v0.36.2 [INFO] [stderr] Checking uuid v1.18.1 [INFO] [stderr] Compiling zvariant_derive v5.8.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Compiling zvariant v5.8.0 [INFO] [stderr] Checking webbrowser v1.0.6 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking smithay-clipboard v0.7.2 [INFO] [stderr] Checking winit v0.30.12 [INFO] [stderr] Checking zbus_names v4.2.0 [INFO] [stderr] Checking egui_glow v0.33.0 [INFO] [stderr] Checking zbus_xml v5.0.2 [INFO] [stderr] Checking zbus-lockstep v0.5.1 [INFO] [stderr] Compiling zbus_macros v5.12.0 [INFO] [stderr] Compiling zbus-lockstep-macros v0.5.1 [INFO] [stderr] Checking glutin-winit v0.5.0 [INFO] [stderr] Checking zbus v5.12.0 [INFO] [stderr] Checking atspi-common v0.9.0 [INFO] [stderr] Checking atspi-proxies v0.9.0 [INFO] [stderr] Checking accesskit_atspi_common v0.14.1 [INFO] [stderr] Checking atspi-connection v0.9.0 [INFO] [stderr] Checking atspi v0.25.0 [INFO] [stderr] Checking accesskit_unix v0.17.1 [INFO] [stderr] Checking accesskit_winit v0.29.1 [INFO] [stderr] Checking egui-winit v0.33.0 [INFO] [stderr] Checking eframe v0.33.0 [INFO] [stderr] Checking holdem v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused macro definition: `card` [INFO] [stdout] --> src/cards.rs:5:14 [INFO] [stdout] | [INFO] [stdout] 5 | macro_rules! card { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_macros)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused macro definition: `cards` [INFO] [stdout] --> src/cards.rs:11:14 [INFO] [stdout] | [INFO] [stdout] 11 | macro_rules! cards { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused macro definition: `card` [INFO] [stdout] --> src/cards.rs:5:14 [INFO] [stdout] | [INFO] [stdout] 5 | macro_rules! card { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_macros)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused macro definition: `cards` [INFO] [stdout] --> src/cards.rs:11:14 [INFO] [stdout] | [INFO] [stdout] 11 | macro_rules! cards { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `position` [INFO] [stdout] --> src/ai.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | position: Position, [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_position` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `position` [INFO] [stdout] --> src/ai.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | position: Position, [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_position` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `faces_iter` and `suites` are never used [INFO] [stdout] --> src/cards.rs:239:12 [INFO] [stdout] | [INFO] [stdout] 230 | impl Hand { [INFO] [stdout] | --------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 239 | pub fn faces_iter(&self) -> impl Iterator { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 243 | pub fn suites(&self) -> [Suite; 5] { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `tall_preflop` and `short_preflop` are never used [INFO] [stdout] --> src/preflop.rs:255:12 [INFO] [stdout] | [INFO] [stdout] 221 | impl Position { [INFO] [stdout] | ------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 255 | pub fn tall_preflop(self) -> HandChart { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 271 | pub fn short_preflop(self) -> HandChart { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cards.rs:59:18 [INFO] [stdout] | [INFO] [stdout] 59 | _ => return None, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - _ => return None, [INFO] [stdout] 59 + _ => None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cards.rs:140:18 [INFO] [stdout] | [INFO] [stdout] 140 | _ => return None, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 140 - _ => return None, [INFO] [stdout] 140 + _ => None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/ai.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / pub fn decide( [INFO] [stdout] 4 | | position: Position, [INFO] [stdout] 5 | | hand_strength: f64, [INFO] [stdout] 6 | | pot_odds: f64, [INFO] [stdout] ... | [INFO] [stdout] 11 | | blind: usize, [INFO] [stdout] 12 | | ) -> (Recommendation, usize) { [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `faces_iter` and `suites` are never used [INFO] [stdout] --> src/cards.rs:239:12 [INFO] [stdout] | [INFO] [stdout] 230 | impl Hand { [INFO] [stdout] | --------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 239 | pub fn faces_iter(&self) -> impl Iterator { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 243 | pub fn suites(&self) -> [Suite; 5] { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `tall_preflop` and `short_preflop` are never used [INFO] [stdout] --> src/preflop.rs:255:12 [INFO] [stdout] | [INFO] [stdout] 221 | impl Position { [INFO] [stdout] | ------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 255 | pub fn tall_preflop(self) -> HandChart { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 271 | pub fn short_preflop(self) -> HandChart { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cards.rs:59:18 [INFO] [stdout] | [INFO] [stdout] 59 | _ => return None, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - _ => return None, [INFO] [stdout] 59 + _ => None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/eval.rs:33:37 [INFO] [stdout] | [INFO] [stdout] 33 | Recommendation::Fold => 'f' as u8, [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'f'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cards.rs:140:18 [INFO] [stdout] | [INFO] [stdout] 140 | _ => return None, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 140 - _ => return None, [INFO] [stdout] 140 + _ => None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/eval.rs:34:37 [INFO] [stdout] | [INFO] [stdout] 34 | Recommendation::Call => 'c' as u8, [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'c'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/eval.rs:35:38 [INFO] [stdout] | [INFO] [stdout] 35 | Recommendation::Raise => 'r' as u8, [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'r'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/eval.rs:36:38 [INFO] [stdout] | [INFO] [stdout] 36 | Recommendation::AllIn => 'a' as u8, [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'a'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/ai.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / pub fn decide( [INFO] [stdout] 4 | | position: Position, [INFO] [stdout] 5 | | hand_strength: f64, [INFO] [stdout] 6 | | pot_odds: f64, [INFO] [stdout] ... | [INFO] [stdout] 11 | | blind: usize, [INFO] [stdout] 12 | | ) -> (Recommendation, usize) { [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DeckState` which implements the `Copy` trait [INFO] [stdout] --> src/eval.rs:65:49 [INFO] [stdout] | [INFO] [stdout] 65 | let (wins, ties, losses) = deck_without(self.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/eval.rs:71:53 [INFO] [stdout] | [INFO] [stdout] 71 | opponent_hand.into_iter().chain(self.board.into_iter()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 71 - opponent_hand.into_iter().chain(self.board.into_iter()), [INFO] [stdout] 71 + opponent_hand.into_iter().chain(self.board), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DeckState` which implements the `Copy` trait [INFO] [stdout] --> src/eval.rs:96:49 [INFO] [stdout] | [INFO] [stdout] 96 | let (wins, ties, losses) = deck_without(self.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DeckState` which implements the `Copy` trait [INFO] [stdout] --> src/eval.rs:105:46 [INFO] [stdout] | [INFO] [stdout] 105 | for flop in deck_without(self.clone().into_iter().chain(opponent_hand.clone())) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `(*self)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/eval.rs:33:37 [INFO] [stdout] | [INFO] [stdout] 33 | Recommendation::Fold => 'f' as u8, [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'f'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/eval.rs:34:37 [INFO] [stdout] | [INFO] [stdout] 34 | Recommendation::Call => 'c' as u8, [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'c'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/eval.rs:35:38 [INFO] [stdout] | [INFO] [stdout] 35 | Recommendation::Raise => 'r' as u8, [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'r'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/eval.rs:36:38 [INFO] [stdout] | [INFO] [stdout] 36 | Recommendation::AllIn => 'a' as u8, [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'a'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/preflop.rs:112:24 [INFO] [stdout] | [INFO] [stdout] 112 | if !next.is_some_and(|c| c == ',') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `next.is_none_or(|c| c != ',')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/preflop.rs:131:24 [INFO] [stdout] | [INFO] [stdout] 131 | if !next.is_some_and(|c| c == ',') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `next.is_none_or(|c| c != ',')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/preflop.rs:92:12 [INFO] [stdout] | [INFO] [stdout] 92 | if list == "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `list.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DeckState` which implements the `Copy` trait [INFO] [stdout] --> src/eval.rs:65:49 [INFO] [stdout] | [INFO] [stdout] 65 | let (wins, ties, losses) = deck_without(self.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/eval.rs:71:53 [INFO] [stdout] | [INFO] [stdout] 71 | opponent_hand.into_iter().chain(self.board.into_iter()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 71 - opponent_hand.into_iter().chain(self.board.into_iter()), [INFO] [stdout] 71 + opponent_hand.into_iter().chain(self.board), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/preflop.rs:213:28 [INFO] [stdout] | [INFO] [stdout] 213 | a.push('\n' as u8); [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\n'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DeckState` which implements the `Copy` trait [INFO] [stdout] --> src/eval.rs:96:49 [INFO] [stdout] | [INFO] [stdout] 96 | let (wins, ties, losses) = deck_without(self.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DeckState` which implements the `Copy` trait [INFO] [stdout] --> src/eval.rs:105:46 [INFO] [stdout] | [INFO] [stdout] 105 | for flop in deck_without(self.clone().into_iter().chain(opponent_hand.clone())) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `(*self)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/rank.rs:21:1 [INFO] [stdout] | [INFO] [stdout] 21 | / impl PartialOrd for Ranking { [INFO] [stdout] 22 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 23 | | use std::cmp::Ordering::*; [INFO] [stdout] 24 | | match self.kind.cmp(&other.kind) { [INFO] [stdout] ... | [INFO] [stdout] 30 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 22 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 23 - use std::cmp::Ordering::*; [INFO] [stdout] 24 - match self.kind.cmp(&other.kind) { [INFO] [stdout] 25 - Greater => Some(Greater), [INFO] [stdout] 26 - Less => Some(Less), [INFO] [stdout] 27 - Equal => Some(self.hand_descending.cmp(&other.hand_descending)), [INFO] [stdout] 28 - } [INFO] [stdout] 29 - } [INFO] [stdout] 22 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rank.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 120 | / return r(match (max, two_kind_count) { [INFO] [stdout] 121 | | (4, _) => RankKind::FourKind, [INFO] [stdout] 122 | | (3, 1) => RankKind::FullHouse, [INFO] [stdout] 123 | | (3, _) => RankKind::ThreeKind, [INFO] [stdout] ... | [INFO] [stdout] 126 | | (_, _) => RankKind::HighCard, [INFO] [stdout] 127 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 120 ~ r(match (max, two_kind_count) { [INFO] [stdout] 121 + (4, _) => RankKind::FourKind, [INFO] [stdout] 122 + (3, 1) => RankKind::FullHouse, [INFO] [stdout] 123 + (3, _) => RankKind::ThreeKind, [INFO] [stdout] 124 + (_, 2) => RankKind::TwoPairs, [INFO] [stdout] 125 + (2, _) => RankKind::OnePair, [INFO] [stdout] 126 + (_, _) => RankKind::HighCard, [INFO] [stdout] 127 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[usize; 5]` which implements the `Copy` trait [INFO] [stdout] --> src/rank.rs:80:35 [INFO] [stdout] | [INFO] [stdout] 80 | let mut hand_descending = face_values.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `face_values` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `UTG` contains a capitalized acronym [INFO] [stdout] --> src/state.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | UTG = 8, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Utg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/preflop.rs:112:24 [INFO] [stdout] | [INFO] [stdout] 112 | if !next.is_some_and(|c| c == ',') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `next.is_none_or(|c| c != ',')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/preflop.rs:131:24 [INFO] [stdout] | [INFO] [stdout] 131 | if !next.is_some_and(|c| c == ',') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `next.is_none_or(|c| c != ',')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/preflop.rs:92:12 [INFO] [stdout] | [INFO] [stdout] 92 | if list == "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `list.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/state.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 87 | / let i = match self { [INFO] [stdout] 88 | | Board::Flop(c) => c.to_vec(), [INFO] [stdout] 89 | | Board::Turn(c) => c.to_vec(), [INFO] [stdout] 90 | | Board::River(c) => c.to_vec(), [INFO] [stdout] ... | [INFO] [stdout] 93 | | .into_iter(); [INFO] [stdout] | |_____________________- unnecessary `let` binding [INFO] [stdout] 94 | i [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 87 ~ [INFO] [stdout] 88 ~ match self { [INFO] [stdout] 89 + Board::Flop(c) => c.to_vec(), [INFO] [stdout] 90 + Board::Turn(c) => c.to_vec(), [INFO] [stdout] 91 + Board::River(c) => c.to_vec(), [INFO] [stdout] 92 + Board::PreFlop => vec![], [INFO] [stdout] 93 + } [INFO] [stdout] 94 + .into_iter() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/preflop.rs:213:28 [INFO] [stdout] | [INFO] [stdout] 213 | a.push('\n' as u8); [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\n'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:84:26 [INFO] [stdout] | [INFO] [stdout] 84 | ui.label(format!("Players in the game:")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Players in the game:".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/rank.rs:21:1 [INFO] [stdout] | [INFO] [stdout] 21 | / impl PartialOrd for Ranking { [INFO] [stdout] 22 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 23 | | use std::cmp::Ordering::*; [INFO] [stdout] 24 | | match self.kind.cmp(&other.kind) { [INFO] [stdout] ... | [INFO] [stdout] 30 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 22 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 23 - use std::cmp::Ordering::*; [INFO] [stdout] 24 - match self.kind.cmp(&other.kind) { [INFO] [stdout] 25 - Greater => Some(Greater), [INFO] [stdout] 26 - Less => Some(Less), [INFO] [stdout] 27 - Equal => Some(self.hand_descending.cmp(&other.hand_descending)), [INFO] [stdout] 28 - } [INFO] [stdout] 29 - } [INFO] [stdout] 22 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rank.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 120 | / return r(match (max, two_kind_count) { [INFO] [stdout] 121 | | (4, _) => RankKind::FourKind, [INFO] [stdout] 122 | | (3, 1) => RankKind::FullHouse, [INFO] [stdout] 123 | | (3, _) => RankKind::ThreeKind, [INFO] [stdout] ... | [INFO] [stdout] 126 | | (_, _) => RankKind::HighCard, [INFO] [stdout] 127 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 120 ~ r(match (max, two_kind_count) { [INFO] [stdout] 121 + (4, _) => RankKind::FourKind, [INFO] [stdout] 122 + (3, 1) => RankKind::FullHouse, [INFO] [stdout] 123 + (3, _) => RankKind::ThreeKind, [INFO] [stdout] 124 + (_, 2) => RankKind::TwoPairs, [INFO] [stdout] 125 + (2, _) => RankKind::OnePair, [INFO] [stdout] 126 + (_, _) => RankKind::HighCard, [INFO] [stdout] 127 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[usize; 5]` which implements the `Copy` trait [INFO] [stdout] --> src/rank.rs:80:35 [INFO] [stdout] | [INFO] [stdout] 80 | let mut hand_descending = face_values.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `face_values` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:158:76 [INFO] [stdout] | [INFO] [stdout] 158 | if !ui.text_edit_singleline(&mut pot_input).has_focus() && pot_input == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `pot_input.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `UTG` contains a capitalized acronym [INFO] [stdout] --> src/state.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | UTG = 8, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Utg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:205:78 [INFO] [stdout] | [INFO] [stdout] 205 | if !ui.text_edit_singleline(&mut stack_input).has_focus() && stack_input == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack_input.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:252:17 [INFO] [stdout] | [INFO] [stdout] 252 | / if state.board == Board::PreFlop { [INFO] [stdout] 253 | | if position != Position::BigBlind { [INFO] [stdout] 254 | | ui.horizontal(|ui| { [INFO] [stdout] 255 | | ui.label("Opening move:"); [INFO] [stdout] ... | [INFO] [stdout] 277 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 252 ~ if state.board == Board::PreFlop [INFO] [stdout] 253 ~ && position != Position::BigBlind { [INFO] [stdout] 254 | ui.horizontal(|ui| { [INFO] [stdout] ... [INFO] [stdout] 275 | }); [INFO] [stdout] 276 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/state.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 87 | / let i = match self { [INFO] [stdout] 88 | | Board::Flop(c) => c.to_vec(), [INFO] [stdout] 89 | | Board::Turn(c) => c.to_vec(), [INFO] [stdout] 90 | | Board::River(c) => c.to_vec(), [INFO] [stdout] ... | [INFO] [stdout] 93 | | .into_iter(); [INFO] [stdout] | |_____________________- unnecessary `let` binding [INFO] [stdout] 94 | i [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 87 ~ [INFO] [stdout] 88 ~ match self { [INFO] [stdout] 89 + Board::Flop(c) => c.to_vec(), [INFO] [stdout] 90 + Board::Turn(c) => c.to_vec(), [INFO] [stdout] 91 + Board::River(c) => c.to_vec(), [INFO] [stdout] 92 + Board::PreFlop => vec![], [INFO] [stdout] 93 + } [INFO] [stdout] 94 + .into_iter() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:84:26 [INFO] [stdout] | [INFO] [stdout] 84 | ui.label(format!("Players in the game:")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Players in the game:".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: feature `iter_array_chunks` is declared but not used [INFO] [stdout] --> src/main.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | #![feature(iter_array_chunks, array_try_from_fn)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_features)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:158:76 [INFO] [stdout] | [INFO] [stdout] 158 | if !ui.text_edit_singleline(&mut pot_input).has_focus() && pot_input == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `pot_input.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:205:78 [INFO] [stdout] | [INFO] [stdout] 205 | if !ui.text_edit_singleline(&mut stack_input).has_focus() && stack_input == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack_input.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:252:17 [INFO] [stdout] | [INFO] [stdout] 252 | / if state.board == Board::PreFlop { [INFO] [stdout] 253 | | if position != Position::BigBlind { [INFO] [stdout] 254 | | ui.horizontal(|ui| { [INFO] [stdout] 255 | | ui.label("Opening move:"); [INFO] [stdout] ... | [INFO] [stdout] 277 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 252 ~ if state.board == Board::PreFlop [INFO] [stdout] 253 ~ && position != Position::BigBlind { [INFO] [stdout] 254 | ui.horizontal(|ui| { [INFO] [stdout] ... [INFO] [stdout] 275 | }); [INFO] [stdout] 276 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: feature `iter_array_chunks` is declared but not used [INFO] [stdout] --> src/main.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | #![feature(iter_array_chunks, array_try_from_fn)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_features)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 07s [INFO] running `Command { std: "docker" "inspect" "f9b18136b1529afc0410a9ec8c78ade1644677fcca0071733fef4630d77e1965", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f9b18136b1529afc0410a9ec8c78ade1644677fcca0071733fef4630d77e1965", kill_on_drop: false }` [INFO] [stdout] f9b18136b1529afc0410a9ec8c78ade1644677fcca0071733fef4630d77e1965