[INFO] cloning repository https://github.com/lndl/mos6502 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/lndl/mos6502" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flndl%2Fmos6502", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flndl%2Fmos6502'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9aef01915a5807ab06aa8f7b09a333275b98fe02 [INFO] linting lndl/mos6502 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flndl%2Fmos6502" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/lndl/mos6502 [INFO] finished tweaking git repo https://github.com/lndl/mos6502 [INFO] tweaked toml for git repo https://github.com/lndl/mos6502 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/lndl/mos6502 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/lndl/mos6502 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8fce281c2a40927e0a32d9fea84604716c6fbcd6f6a897c247e2f08ff13ef615 [INFO] running `Command { std: "docker" "start" "-a" "8fce281c2a40927e0a32d9fea84604716c6fbcd6f6a897c247e2f08ff13ef615", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8fce281c2a40927e0a32d9fea84604716c6fbcd6f6a897c247e2f08ff13ef615", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8fce281c2a40927e0a32d9fea84604716c6fbcd6f6a897c247e2f08ff13ef615", kill_on_drop: false }` [INFO] [stdout] 8fce281c2a40927e0a32d9fea84604716c6fbcd6f6a897c247e2f08ff13ef615 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 29898e85a5e76dc62bcd36c685d20adf6a3aed4d0f773c21f025b37052f9f067 [INFO] running `Command { std: "docker" "start" "-a" "29898e85a5e76dc62bcd36c685d20adf6a3aed4d0f773c21f025b37052f9f067", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking mos6502 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: methods called `from_*` usually take no `self` [INFO] [stdout] --> src/cpu.rs:68:18 [INFO] [stdout] | [INFO] [stdout] 68 | fn from_byte(&mut self, flagsbyte: u8) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CPU` [INFO] [stdout] --> src/cpu.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 113 | / pub fn new() -> Self { [INFO] [stdout] 114 | | let flags = CPUFlags::new(); [INFO] [stdout] 115 | | let mem = memory_map::MemoryMap::new(); [INFO] [stdout] ... | [INFO] [stdout] 128 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 112 + impl Default for CPU { [INFO] [stdout] 113 + fn default() -> Self { [INFO] [stdout] 114 + Self::new() [INFO] [stdout] 115 + } [INFO] [stdout] 116 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cpu.rs:195:44 [INFO] [stdout] | [INFO] [stdout] 195 | self.flags.set(Flag::Overflow, !(((reg_a ^ op) & 0x80) != 0) && (((reg_a ^ result) & 0x80) != 0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(((reg_a ^ op) & 0x80) == 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | self.a = self.a & m; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.a &= m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:422:9 [INFO] [stdout] | [INFO] [stdout] 422 | r = r | self.flags.bit(Flag::Carry); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `r |= self.flags.bit(Flag::Carry)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:433:9 [INFO] [stdout] | [INFO] [stdout] 433 | r = r | (self.flags.bit(Flag::Carry) << 7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `r |= (self.flags.bit(Flag::Carry) << 7)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/cpu.rs:692:17 [INFO] [stdout] | [INFO] [stdout] 691 | let address = address8to16(l, h); [INFO] [stdout] | --------------------------------- unnecessary `let` binding [INFO] [stdout] 692 | address [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 691 ~ [INFO] [stdout] 692 ~ address8to16(l, h) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/cpu.rs:696:17 [INFO] [stdout] | [INFO] [stdout] 695 | let address = address8to16(l, h).wrapping_add(address8to16(self.x, 0)); [INFO] [stdout] | ----------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 696 | address [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 695 ~ [INFO] [stdout] 696 ~ address8to16(l, h).wrapping_add(address8to16(self.x, 0)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/cpu.rs:700:17 [INFO] [stdout] | [INFO] [stdout] 699 | let address = address8to16(l, h).wrapping_add(address8to16(self.y, 0)); [INFO] [stdout] | ----------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 700 | address [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 699 ~ [INFO] [stdout] 700 ~ address8to16(l, h).wrapping_add(address8to16(self.y, 0)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/cpu.rs:704:17 [INFO] [stdout] | [INFO] [stdout] 703 | let address = address8to16(o, 0); [INFO] [stdout] | --------------------------------- unnecessary `let` binding [INFO] [stdout] 704 | address [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 703 ~ [INFO] [stdout] 704 ~ address8to16(o, 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/cpu.rs:708:17 [INFO] [stdout] | [INFO] [stdout] 707 | let address = address8to16(o.wrapping_add(self.x), 0); [INFO] [stdout] | ------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 708 | address [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 707 ~ [INFO] [stdout] 708 ~ address8to16(o.wrapping_add(self.x), 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/cpu.rs:712:17 [INFO] [stdout] | [INFO] [stdout] 711 | let address = address8to16(o.wrapping_add(self.y), 0); [INFO] [stdout] | ------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 712 | address [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 711 ~ [INFO] [stdout] 712 ~ address8to16(o.wrapping_add(self.y), 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/cpu.rs:716:17 [INFO] [stdout] | [INFO] [stdout] 715 | let address = self.pc.wrapping_add(o as u16); [INFO] [stdout] | --------------------------------------------- unnecessary `let` binding [INFO] [stdout] 716 | address [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 715 ~ [INFO] [stdout] 716 ~ self.pc.wrapping_add(o as u16) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/cpu.rs:723:17 [INFO] [stdout] | [INFO] [stdout] 722 | let address = address8to16(lo, hi); [INFO] [stdout] | ----------------------------------- unnecessary `let` binding [INFO] [stdout] 723 | address [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 722 ~ [INFO] [stdout] 723 ~ address8to16(lo, hi) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/cpu.rs:730:17 [INFO] [stdout] | [INFO] [stdout] 729 | let address = address8to16(lo, hi).wrapping_add(address8to16(self.y, 0)); [INFO] [stdout] | ------------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 730 | address [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 729 ~ [INFO] [stdout] 730 ~ address8to16(lo, hi).wrapping_add(address8to16(self.y, 0)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/cpu.rs:738:17 [INFO] [stdout] | [INFO] [stdout] 737 | let address = address8to16(lo, hi); [INFO] [stdout] | ----------------------------------- unnecessary `let` binding [INFO] [stdout] 738 | address [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 737 ~ [INFO] [stdout] 738 ~ address8to16(lo, hi) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ADC` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Adc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AND` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:10 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `And` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ASL` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:15 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Asl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BCC` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:20 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bcc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BCS` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:25 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bcs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BEQ` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:30 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Beq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BIT` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:35 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BMI` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:40 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bmi` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BNE` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:45 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bne` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BPL` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:50 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bpl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BRK` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:55 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Brk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BVC` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:60 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bvc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BVS` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:65 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bvs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLC` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:70 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Clc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLD` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:75 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cld` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLI` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:80 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cli` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLV` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Clv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CMP` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:10 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cmp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CPX` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:15 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CPY` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:20 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DCP` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:25 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dcp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEC` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:30 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEX` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:35 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dex` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEY` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:40 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dey` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EOR` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:45 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Eor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INC` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:50 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Inc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INX` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:55 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Inx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INY` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:60 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Iny` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ISB` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:65 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Isb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JMP` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:70 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jmp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JSR` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:75 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jsr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LAX` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:80 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Lax` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDA` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Lda` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDX` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:10 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ldx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDY` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:15 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ldy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LSR` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:20 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Lsr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NOP` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:25 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Nop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ORA` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:30 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ora` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PHA` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:35 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Pha` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PHP` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:40 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Php` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PLA` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:45 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Pla` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PLP` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:50 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Plp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RLA` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:55 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rla` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ROL` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:60 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rol` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ROR` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:65 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ror` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RRA` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:70 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rra` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RTI` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:75 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rti` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RTS` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:80 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SAX` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sax` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SBC` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:10 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sbc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SEC` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:15 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SED` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:20 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sed` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SEI` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:25 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sei` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SLO` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:30 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Slo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SRE` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:35 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sre` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STA` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:40 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sta` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STX` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:45 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Stx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STY` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:50 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sty` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TAX` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:55 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tax` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TAY` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:60 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tay` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TSX` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:65 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Tsx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TXA` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:70 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Txa` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TXS` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:75 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Txs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TYA` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:80 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tya` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/instruction.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | / match *self { [INFO] [stdout] 29 | | Abs { .. } | AbsX { .. } | AbsY { .. } | [INFO] [stdout] 30 | | ZeroPage { .. } | ZeroPageX { .. } | [INFO] [stdout] 31 | | ZeroPageY { .. } | Relative { .. } | [INFO] [stdout] ... | [INFO] [stdout] 34 | | _ => false [INFO] [stdout] 35 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 28 ~ matches!(*self, Abs { .. } | AbsX { .. } | AbsY { .. } | [INFO] [stdout] 29 + ZeroPage { .. } | ZeroPageX { .. } | [INFO] [stdout] 30 + ZeroPageY { .. } | Relative { .. } | [INFO] [stdout] 31 + Indirect { .. } | IndirectIndexed { .. } | [INFO] [stdout] 32 + IndexedIndirect { .. }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/instruction.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | / match *self { [INFO] [stdout] 41 | | AccA | AccX | AccY | AccSP => true, [INFO] [stdout] 42 | | _ => false [INFO] [stdout] 43 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 40 - match *self { [INFO] [stdout] 41 - AccA | AccX | AccY | AccSP => true, [INFO] [stdout] 42 - _ => false [INFO] [stdout] 43 - } [INFO] [stdout] 40 + matches!(*self, AccA | AccX | AccY | AccSP) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct pattern is not needed for a unit variant [INFO] [stdout] --> src/instruction.rs:119:17 [INFO] [stdout] | [INFO] [stdout] 119 | AccA { .. } | AccX { .. } | AccY { .. } | AccSP { .. } => 1, [INFO] [stdout] | ^^^^^^^ help: remove the struct pattern [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern [INFO] [stdout] = note: `#[warn(clippy::unneeded_struct_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct pattern is not needed for a unit variant [INFO] [stdout] --> src/instruction.rs:119:31 [INFO] [stdout] | [INFO] [stdout] 119 | AccA { .. } | AccX { .. } | AccY { .. } | AccSP { .. } => 1, [INFO] [stdout] | ^^^^^^^ help: remove the struct pattern [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct pattern is not needed for a unit variant [INFO] [stdout] --> src/instruction.rs:119:45 [INFO] [stdout] | [INFO] [stdout] 119 | AccA { .. } | AccX { .. } | AccY { .. } | AccSP { .. } => 1, [INFO] [stdout] | ^^^^^^^ help: remove the struct pattern [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct pattern is not needed for a unit variant [INFO] [stdout] --> src/instruction.rs:119:60 [INFO] [stdout] | [INFO] [stdout] 119 | AccA { .. } | AccX { .. } | AccY { .. } | AccSP { .. } => 1, [INFO] [stdout] | ^^^^^^^ help: remove the struct pattern [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `from_*` usually take no `self` [INFO] [stdout] --> src/cpu.rs:68:18 [INFO] [stdout] | [INFO] [stdout] 68 | fn from_byte(&mut self, flagsbyte: u8) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CPU` [INFO] [stdout] --> src/cpu.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 113 | / pub fn new() -> Self { [INFO] [stdout] 114 | | let flags = CPUFlags::new(); [INFO] [stdout] 115 | | let mem = memory_map::MemoryMap::new(); [INFO] [stdout] ... | [INFO] [stdout] 128 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 112 + impl Default for CPU { [INFO] [stdout] 113 + fn default() -> Self { [INFO] [stdout] 114 + Self::new() [INFO] [stdout] 115 + } [INFO] [stdout] 116 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cpu.rs:195:44 [INFO] [stdout] | [INFO] [stdout] 195 | self.flags.set(Flag::Overflow, !(((reg_a ^ op) & 0x80) != 0) && (((reg_a ^ result) & 0x80) != 0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(((reg_a ^ op) & 0x80) == 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | self.a = self.a & m; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.a &= m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:422:9 [INFO] [stdout] | [INFO] [stdout] 422 | r = r | self.flags.bit(Flag::Carry); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `r |= self.flags.bit(Flag::Carry)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:433:9 [INFO] [stdout] | [INFO] [stdout] 433 | r = r | (self.flags.bit(Flag::Carry) << 7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `r |= (self.flags.bit(Flag::Carry) << 7)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/memory_map.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / pub mod memory_map { [INFO] [stdout] 2 | | use std::fmt; [INFO] [stdout] 3 | | use std::ops::Range; [INFO] [stdout] 4 | | use std::collections::HashMap; [INFO] [stdout] ... | [INFO] [stdout] 95 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `MemoryMap` [INFO] [stdout] --> src/memory_map.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | / pub fn new() -> MemoryMap { [INFO] [stdout] 25 | | MemoryMap { [INFO] [stdout] 26 | | devices: HashMap::new(), [INFO] [stdout] 27 | | } [INFO] [stdout] 28 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 23 ~ impl Default for MemoryMap { [INFO] [stdout] 24 + fn default() -> Self { [INFO] [stdout] 25 + Self::new() [INFO] [stdout] 26 + } [INFO] [stdout] 27 + } [INFO] [stdout] 28 + [INFO] [stdout] 29 ~ impl MemoryMap { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/cpu.rs:692:17 [INFO] [stdout] | [INFO] [stdout] 691 | let address = address8to16(l, h); [INFO] [stdout] | --------------------------------- unnecessary `let` binding [INFO] [stdout] 692 | address [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 691 ~ [INFO] [stdout] 692 ~ address8to16(l, h) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/cpu.rs:696:17 [INFO] [stdout] | [INFO] [stdout] 695 | let address = address8to16(l, h).wrapping_add(address8to16(self.x, 0)); [INFO] [stdout] | ----------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 696 | address [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 695 ~ [INFO] [stdout] 696 ~ address8to16(l, h).wrapping_add(address8to16(self.x, 0)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/cpu.rs:700:17 [INFO] [stdout] | [INFO] [stdout] 699 | let address = address8to16(l, h).wrapping_add(address8to16(self.y, 0)); [INFO] [stdout] | ----------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 700 | address [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 699 ~ [INFO] [stdout] 700 ~ address8to16(l, h).wrapping_add(address8to16(self.y, 0)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/cpu.rs:704:17 [INFO] [stdout] | [INFO] [stdout] 703 | let address = address8to16(o, 0); [INFO] [stdout] | --------------------------------- unnecessary `let` binding [INFO] [stdout] 704 | address [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 703 ~ [INFO] [stdout] 704 ~ address8to16(o, 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/cpu.rs:708:17 [INFO] [stdout] | [INFO] [stdout] 707 | let address = address8to16(o.wrapping_add(self.x), 0); [INFO] [stdout] | ------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 708 | address [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 707 ~ [INFO] [stdout] 708 ~ address8to16(o.wrapping_add(self.x), 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/memory_map.rs:67:35 [INFO] [stdout] | [INFO] [stdout] 67 | for (mem_range, _) in &self.devices { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 67 - for (mem_range, _) in &self.devices { [INFO] [stdout] 67 + for mem_range in self.devices.keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/cpu.rs:712:17 [INFO] [stdout] | [INFO] [stdout] 711 | let address = address8to16(o.wrapping_add(self.y), 0); [INFO] [stdout] | ------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 712 | address [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 711 ~ [INFO] [stdout] 712 ~ address8to16(o.wrapping_add(self.y), 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/cpu.rs:716:17 [INFO] [stdout] | [INFO] [stdout] 715 | let address = self.pc.wrapping_add(o as u16); [INFO] [stdout] | --------------------------------------------- unnecessary `let` binding [INFO] [stdout] 716 | address [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 715 ~ [INFO] [stdout] 716 ~ self.pc.wrapping_add(o as u16) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/cpu.rs:723:17 [INFO] [stdout] | [INFO] [stdout] 722 | let address = address8to16(lo, hi); [INFO] [stdout] | ----------------------------------- unnecessary `let` binding [INFO] [stdout] 723 | address [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 722 ~ [INFO] [stdout] 723 ~ address8to16(lo, hi) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/memory_map.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | write!(f, "Memory Dump:\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 79 - write!(f, "Memory Dump:\n")?; [INFO] [stdout] 79 + writeln!(f, "Memory Dump:")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/memory_map.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 80 | write!(f, "================================================================================\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 80 - write!(f, "================================================================================\n")?; [INFO] [stdout] 80 + writeln!(f, "================================================================================")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/cpu.rs:730:17 [INFO] [stdout] | [INFO] [stdout] 729 | let address = address8to16(lo, hi).wrapping_add(address8to16(self.y, 0)); [INFO] [stdout] | ------------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 730 | address [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 729 ~ [INFO] [stdout] 730 ~ address8to16(lo, hi).wrapping_add(address8to16(self.y, 0)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/cpu.rs:738:17 [INFO] [stdout] | [INFO] [stdout] 737 | let address = address8to16(lo, hi); [INFO] [stdout] | ----------------------------------- unnecessary `let` binding [INFO] [stdout] 738 | address [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 737 ~ [INFO] [stdout] 738 ~ address8to16(lo, hi) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ADC` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Adc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AND` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:10 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `And` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ASL` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:15 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Asl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BCC` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:20 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bcc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BCS` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:25 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bcs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BEQ` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:30 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Beq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BIT` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:35 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BMI` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:40 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bmi` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BNE` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:45 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bne` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BPL` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:50 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bpl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BRK` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:55 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Brk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BVC` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:60 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bvc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BVS` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:65 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bvs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLC` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:70 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Clc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLD` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:75 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cld` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLI` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:7:80 [INFO] [stdout] | [INFO] [stdout] 7 | ADC, AND, ASL, BCC, BCS, BEQ, BIT, BMI, BNE, BPL, BRK, BVC, BVS, CLC, CLD, CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cli` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLV` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Clv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CMP` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:10 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cmp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CPX` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:15 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::collections::hash_map::Keys<'_, std::ops::Range, std::cell::RefCell>>` [INFO] [stdout] --> src/memory_map.rs:81:43 [INFO] [stdout] | [INFO] [stdout] 81 | let mut mem_ranges : Vec<_> = self.devices.keys().clone().into_iter().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `self.devices.keys().clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CPY` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:20 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DCP` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:25 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dcp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEC` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:30 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEX` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:35 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dex` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEY` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:40 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dey` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EOR` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:45 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Eor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INC` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:50 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Inc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/memory_map.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | mem_ranges.sort_by(|r1, r2| r1.start.cmp(&r2.start)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 82 - mem_ranges.sort_by(|r1, r2| r1.start.cmp(&r2.start)); [INFO] [stdout] 82 + mem_ranges.sort_by_key(|r1| r1.start); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INX` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:55 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Inx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INY` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:60 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Iny` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ISB` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:65 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Isb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JMP` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:70 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jmp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JSR` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:75 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jsr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/memory_map.rs:86:69 [INFO] [stdout] | [INFO] [stdout] 86 | let line : Vec = mem_chunk.into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/memory_map.rs:88:21 [INFO] [stdout] | [INFO] [stdout] 88 | write!(f, "{:04x}: {}\n", mem_chunk[0], line.join(" "))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 88 - write!(f, "{:04x}: {}\n", mem_chunk[0], line.join(" "))?; [INFO] [stdout] 88 + writeln!(f, "{:04x}: {}", mem_chunk[0], line.join(" "))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LAX` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:8:80 [INFO] [stdout] | [INFO] [stdout] 8 | CLV, CMP, CPX, CPY, DCP, DEC, DEX, DEY, EOR, INC, INX, INY, ISB, JMP, JSR, LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Lax` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDA` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Lda` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDX` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:10 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ldx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDY` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:15 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ldy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LSR` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:20 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Lsr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NOP` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:25 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Nop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ORA` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:30 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ora` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PHA` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:35 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Pha` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/memory_map.rs:90:17 [INFO] [stdout] | [INFO] [stdout] 90 | write!(f, "<<<<<<<<<<<<<< SKIP >>>>>>>>>>>>>>\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 90 - write!(f, "<<<<<<<<<<<<<< SKIP >>>>>>>>>>>>>>\n")?; [INFO] [stdout] 90 + writeln!(f, "<<<<<<<<<<<<<< SKIP >>>>>>>>>>>>>>")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PHP` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:40 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Php` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PLA` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:45 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Pla` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PLP` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:50 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Plp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RLA` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:55 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rla` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ROL` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:60 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rol` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/memory_map.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 92 | write!(f, "================================================================================\n") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 92 - write!(f, "================================================================================\n") [INFO] [stdout] 92 + writeln!(f, "================================================================================") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ROR` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:65 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ror` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RRA` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:70 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rra` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RTI` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:75 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rti` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RTS` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:9:80 [INFO] [stdout] | [INFO] [stdout] 9 | LDA, LDX, LDY, LSR, NOP, ORA, PHA, PHP, PLA, PLP, RLA, ROL, ROR, RRA, RTI, RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SAX` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sax` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SBC` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:10 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sbc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SEC` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:15 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SED` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:20 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sed` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SEI` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:25 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sei` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SLO` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:30 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Slo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SRE` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:35 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sre` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STA` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:40 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sta` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STX` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:45 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Stx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STY` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:50 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sty` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TAX` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:55 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tax` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TAY` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:60 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tay` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TSX` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:65 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Tsx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TXA` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:70 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Txa` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message contains an unused formatting placeholder [INFO] [stdout] --> src/cpu.rs:740:26 [INFO] [stdout] | [INFO] [stdout] 740 | _ => panic!("{} is not a memory type address mode") [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: this message is not used as a format string when given without arguments, but will be in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: add the missing argument [INFO] [stdout] | [INFO] [stdout] 740 | _ => panic!("{} is not a memory type address mode", ...) [INFO] [stdout] | +++++ [INFO] [stdout] help: or add a "{}" format string to use the message literally [INFO] [stdout] | [INFO] [stdout] 740 | _ => panic!("{}", "{} is not a memory type address mode") [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TXS` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:75 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Txs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TYA` contains a capitalized acronym [INFO] [stdout] --> src/instruction.rs:10:80 [INFO] [stdout] | [INFO] [stdout] 10 | SAX, SBC, SEC, SED, SEI, SLO, SRE, STA, STX, STY, TAX, TAY, TSX, TXA, TXS, TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tya` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/instruction.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | / match *self { [INFO] [stdout] 29 | | Abs { .. } | AbsX { .. } | AbsY { .. } | [INFO] [stdout] 30 | | ZeroPage { .. } | ZeroPageX { .. } | [INFO] [stdout] 31 | | ZeroPageY { .. } | Relative { .. } | [INFO] [stdout] ... | [INFO] [stdout] 34 | | _ => false [INFO] [stdout] 35 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 28 ~ matches!(*self, Abs { .. } | AbsX { .. } | AbsY { .. } | [INFO] [stdout] 29 + ZeroPage { .. } | ZeroPageX { .. } | [INFO] [stdout] 30 + ZeroPageY { .. } | Relative { .. } | [INFO] [stdout] 31 + Indirect { .. } | IndirectIndexed { .. } | [INFO] [stdout] 32 + IndexedIndirect { .. }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/instruction.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | / match *self { [INFO] [stdout] 41 | | AccA | AccX | AccY | AccSP => true, [INFO] [stdout] 42 | | _ => false [INFO] [stdout] 43 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 40 - match *self { [INFO] [stdout] 41 - AccA | AccX | AccY | AccSP => true, [INFO] [stdout] 42 - _ => false [INFO] [stdout] 43 - } [INFO] [stdout] 40 + matches!(*self, AccA | AccX | AccY | AccSP) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct pattern is not needed for a unit variant [INFO] [stdout] --> src/instruction.rs:119:17 [INFO] [stdout] | [INFO] [stdout] 119 | AccA { .. } | AccX { .. } | AccY { .. } | AccSP { .. } => 1, [INFO] [stdout] | ^^^^^^^ help: remove the struct pattern [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern [INFO] [stdout] = note: `#[warn(clippy::unneeded_struct_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct pattern is not needed for a unit variant [INFO] [stdout] --> src/instruction.rs:119:31 [INFO] [stdout] | [INFO] [stdout] 119 | AccA { .. } | AccX { .. } | AccY { .. } | AccSP { .. } => 1, [INFO] [stdout] | ^^^^^^^ help: remove the struct pattern [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct pattern is not needed for a unit variant [INFO] [stdout] --> src/instruction.rs:119:45 [INFO] [stdout] | [INFO] [stdout] 119 | AccA { .. } | AccX { .. } | AccY { .. } | AccSP { .. } => 1, [INFO] [stdout] | ^^^^^^^ help: remove the struct pattern [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct pattern is not needed for a unit variant [INFO] [stdout] --> src/instruction.rs:119:60 [INFO] [stdout] | [INFO] [stdout] 119 | AccA { .. } | AccX { .. } | AccY { .. } | AccSP { .. } => 1, [INFO] [stdout] | ^^^^^^^ help: remove the struct pattern [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/memory_map.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / pub mod memory_map { [INFO] [stdout] 2 | | use std::fmt; [INFO] [stdout] 3 | | use std::ops::Range; [INFO] [stdout] 4 | | use std::collections::HashMap; [INFO] [stdout] ... | [INFO] [stdout] 95 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `MemoryMap` [INFO] [stdout] --> src/memory_map.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | / pub fn new() -> MemoryMap { [INFO] [stdout] 25 | | MemoryMap { [INFO] [stdout] 26 | | devices: HashMap::new(), [INFO] [stdout] 27 | | } [INFO] [stdout] 28 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 23 ~ impl Default for MemoryMap { [INFO] [stdout] 24 + fn default() -> Self { [INFO] [stdout] 25 + Self::new() [INFO] [stdout] 26 + } [INFO] [stdout] 27 + } [INFO] [stdout] 28 + [INFO] [stdout] 29 ~ impl MemoryMap { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/memory_map.rs:67:35 [INFO] [stdout] | [INFO] [stdout] 67 | for (mem_range, _) in &self.devices { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 67 - for (mem_range, _) in &self.devices { [INFO] [stdout] 67 + for mem_range in self.devices.keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/memory_map.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | write!(f, "Memory Dump:\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 79 - write!(f, "Memory Dump:\n")?; [INFO] [stdout] 79 + writeln!(f, "Memory Dump:")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/memory_map.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 80 | write!(f, "================================================================================\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 80 - write!(f, "================================================================================\n")?; [INFO] [stdout] 80 + writeln!(f, "================================================================================")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::collections::hash_map::Keys<'_, std::ops::Range, std::cell::RefCell>>` [INFO] [stdout] --> src/memory_map.rs:81:43 [INFO] [stdout] | [INFO] [stdout] 81 | let mut mem_ranges : Vec<_> = self.devices.keys().clone().into_iter().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `self.devices.keys().clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/memory_map.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | mem_ranges.sort_by(|r1, r2| r1.start.cmp(&r2.start)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 82 - mem_ranges.sort_by(|r1, r2| r1.start.cmp(&r2.start)); [INFO] [stdout] 82 + mem_ranges.sort_by_key(|r1| r1.start); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/memory_map.rs:86:69 [INFO] [stdout] | [INFO] [stdout] 86 | let line : Vec = mem_chunk.into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/memory_map.rs:88:21 [INFO] [stdout] | [INFO] [stdout] 88 | write!(f, "{:04x}: {}\n", mem_chunk[0], line.join(" "))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 88 - write!(f, "{:04x}: {}\n", mem_chunk[0], line.join(" "))?; [INFO] [stdout] 88 + writeln!(f, "{:04x}: {}", mem_chunk[0], line.join(" "))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/memory_map.rs:90:17 [INFO] [stdout] | [INFO] [stdout] 90 | write!(f, "<<<<<<<<<<<<<< SKIP >>>>>>>>>>>>>>\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 90 - write!(f, "<<<<<<<<<<<<<< SKIP >>>>>>>>>>>>>>\n")?; [INFO] [stdout] 90 + writeln!(f, "<<<<<<<<<<<<<< SKIP >>>>>>>>>>>>>>")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/memory_map.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 92 | write!(f, "================================================================================\n") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 92 - write!(f, "================================================================================\n") [INFO] [stdout] 92 + writeln!(f, "================================================================================") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message contains an unused formatting placeholder [INFO] [stdout] --> src/cpu.rs:740:26 [INFO] [stdout] | [INFO] [stdout] 740 | _ => panic!("{} is not a memory type address mode") [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: this message is not used as a format string when given without arguments, but will be in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: add the missing argument [INFO] [stdout] | [INFO] [stdout] 740 | _ => panic!("{} is not a memory type address mode", ...) [INFO] [stdout] | +++++ [INFO] [stdout] help: or add a "{}" format string to use the message literally [INFO] [stdout] | [INFO] [stdout] 740 | _ => panic!("{}", "{} is not a memory type address mode") [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> examples/example1.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | rom: rom [INFO] [stdout] | ^^^^^^^^ help: replace it with: `rom` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> examples/example1.rs:28:18 [INFO] [stdout] | [INFO] [stdout] 28 | self.ram[address as usize] = value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `address` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.81s [INFO] running `Command { std: "docker" "inspect" "29898e85a5e76dc62bcd36c685d20adf6a3aed4d0f773c21f025b37052f9f067", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "29898e85a5e76dc62bcd36c685d20adf6a3aed4d0f773c21f025b37052f9f067", kill_on_drop: false }` [INFO] [stdout] 29898e85a5e76dc62bcd36c685d20adf6a3aed4d0f773c21f025b37052f9f067