[INFO] cloning repository https://github.com/lmzuccarelli/rust-release-upgradepath-tool [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/lmzuccarelli/rust-release-upgradepath-tool" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flmzuccarelli%2Frust-release-upgradepath-tool", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flmzuccarelli%2Frust-release-upgradepath-tool'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 43b07fd0942ee2ca122fef1ef591b536103b8c0a [INFO] linting lmzuccarelli/rust-release-upgradepath-tool against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flmzuccarelli%2Frust-release-upgradepath-tool" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/lmzuccarelli/rust-release-upgradepath-tool [INFO] finished tweaking git repo https://github.com/lmzuccarelli/rust-release-upgradepath-tool [INFO] tweaked toml for git repo https://github.com/lmzuccarelli/rust-release-upgradepath-tool written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/lmzuccarelli/rust-release-upgradepath-tool on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/lmzuccarelli/rust-release-upgradepath-tool already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating git repository `https://github.com/lmzuccarelli/rust-custom-logger` [INFO] [stderr] Updating git repository `https://github.com/lmzuccarelli/rust-mirror-error` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded xattr v1.3.1 [INFO] [stderr] Downloaded tar v0.4.40 [INFO] [stderr] Downloaded security-framework-sys v2.10.0 [INFO] [stderr] Downloaded cc v1.0.92 [INFO] [stderr] Downloaded serde_json v1.0.115 [INFO] [stderr] Downloaded chrono v0.4.37 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 58c26326b66985df4982a01e7156f25ccf269d6e97cb420ef1aa81c2d1e0a266 [INFO] running `Command { std: "docker" "start" "-a" "58c26326b66985df4982a01e7156f25ccf269d6e97cb420ef1aa81c2d1e0a266", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "58c26326b66985df4982a01e7156f25ccf269d6e97cb420ef1aa81c2d1e0a266", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "58c26326b66985df4982a01e7156f25ccf269d6e97cb420ef1aa81c2d1e0a266", kill_on_drop: false }` [INFO] [stdout] 58c26326b66985df4982a01e7156f25ccf269d6e97cb420ef1aa81c2d1e0a266 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 78ecab9e700ab496905e4385527f2fe6be99bd6f26c791fdb41e14d29fb5d7dd [INFO] running `Command { std: "docker" "start" "-a" "78ecab9e700ab496905e4385527f2fe6be99bd6f26c791fdb41e14d29fb5d7dd", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling cc v1.0.92 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling serde_json v1.0.115 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling semver v1.0.22 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking mirror-error v0.1.0 (https://github.com/lmzuccarelli/rust-mirror-error?branch=main#9d9c5dd3) [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.58 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Checking tar v0.4.40 [INFO] [stderr] Checking chrono v0.4.37 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking custom-logger v0.1.4 (https://github.com/lmzuccarelli/rust-custom-logger?branch=main#f0ab24a9) [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking hyper v0.14.28 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking release-introspection-tool v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/isc/generate.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 54 | let all = yaml + &body; [INFO] [stdout] | ----------------------- unnecessary `let` binding [INFO] [stdout] 55 | all [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 54 ~ [INFO] [stdout] 55 ~ yaml + &body [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/isc/generate.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 89 | let all = yaml + &body; [INFO] [stdout] | ----------------------- unnecessary `let` binding [INFO] [stdout] 90 | all [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 89 ~ [INFO] [stdout] 90 ~ yaml + &body [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/podman/process.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 27 | if output.stderr.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!output.stderr.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `idx` after checking its variant with `is_none` [INFO] [stdout] --> src/upgradepath/calculate.rs:126:21 [INFO] [stdout] | [INFO] [stdout] 119 | if idx.is_none() { [INFO] [stdout] | ---------------- help: try: `if let Some() = idx` [INFO] [stdout] ... [INFO] [stdout] 126 | index = idx.unwrap() as u32; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/upgradepath/calculate.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 96 | if to.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `to.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/upgradepath/calculate.rs:109:40 [INFO] [stdout] | [INFO] [stdout] 109 | .position(|x| x.version == last_version.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `last_version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/upgradepath/calculate.rs:111:9 [INFO] [stdout] | [INFO] [stdout] 111 | let index: u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `index` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 111 ~ [INFO] [stdout] 112 | let from_index = graphdata [INFO] [stdout] ... [INFO] [stdout] 118 | // find the index of the to_version [INFO] [stdout] 119 ~ let index: u32 = if idx.is_none() { [INFO] [stdout] 120 ~ graphdata [INFO] [stdout] 121 | .nodes [INFO] [stdout] 122 | .iter() [INFO] [stdout] 123 | .position(|x| x.version == to_version) [INFO] [stdout] 124 ~ .unwrap() as u32 [INFO] [stdout] 125 | } else { [INFO] [stdout] 126 ~ idx.unwrap() as u32 [INFO] [stdout] 127 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `res` after checking its variant with `is_ok` [INFO] [stdout] --> src/main.rs:76:25 [INFO] [stdout] | [INFO] [stdout] 75 | if res.is_ok() { [INFO] [stdout] | -------------- help: try: `if let Ok() = res` [INFO] [stdout] 76 | json_data = res.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `res` after checking its variant with `is_ok` [INFO] [stdout] --> src/main.rs:85:25 [INFO] [stdout] | [INFO] [stdout] 84 | if res.is_ok() { [INFO] [stdout] | -------------- help: try: `if let Ok() = res` [INFO] [stdout] 85 | json_data = res.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | if !Version::parse(&from_version).is_ok() || !Version::parse(&to_version).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Version::parse(&from_version).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:34:50 [INFO] [stdout] | [INFO] [stdout] 34 | if !Version::parse(&from_version).is_ok() || !Version::parse(&to_version).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Version::parse(&to_version).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:112:16 [INFO] [stdout] | [INFO] [stdout] 112 | log.debug(&format!("{}", v2_yml.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `v2_yml.clone().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:114:16 [INFO] [stdout] | [INFO] [stdout] 114 | log.debug(&format!("{}", v3_yml.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `v3_yml.clone().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/isc/generate.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 54 | let all = yaml + &body; [INFO] [stdout] | ----------------------- unnecessary `let` binding [INFO] [stdout] 55 | all [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 54 ~ [INFO] [stdout] 55 ~ yaml + &body [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/isc/generate.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 89 | let all = yaml + &body; [INFO] [stdout] | ----------------------- unnecessary `let` binding [INFO] [stdout] 90 | all [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 89 ~ [INFO] [stdout] 90 ~ yaml + &body [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/podman/process.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 27 | if output.stderr.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!output.stderr.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `idx` after checking its variant with `is_none` [INFO] [stdout] --> src/upgradepath/calculate.rs:126:21 [INFO] [stdout] | [INFO] [stdout] 119 | if idx.is_none() { [INFO] [stdout] | ---------------- help: try: `if let Some() = idx` [INFO] [stdout] ... [INFO] [stdout] 126 | index = idx.unwrap() as u32; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/upgradepath/calculate.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 96 | if to.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `to.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/upgradepath/calculate.rs:109:40 [INFO] [stdout] | [INFO] [stdout] 109 | .position(|x| x.version == last_version.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `last_version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/upgradepath/calculate.rs:111:9 [INFO] [stdout] | [INFO] [stdout] 111 | let index: u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `index` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 111 ~ [INFO] [stdout] 112 | let from_index = graphdata [INFO] [stdout] ... [INFO] [stdout] 118 | // find the index of the to_version [INFO] [stdout] 119 ~ let index: u32 = if idx.is_none() { [INFO] [stdout] 120 ~ graphdata [INFO] [stdout] 121 | .nodes [INFO] [stdout] 122 | .iter() [INFO] [stdout] 123 | .position(|x| x.version == to_version) [INFO] [stdout] 124 ~ .unwrap() as u32 [INFO] [stdout] 125 | } else { [INFO] [stdout] 126 ~ idx.unwrap() as u32 [INFO] [stdout] 127 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `res` after checking its variant with `is_ok` [INFO] [stdout] --> src/main.rs:76:25 [INFO] [stdout] | [INFO] [stdout] 75 | if res.is_ok() { [INFO] [stdout] | -------------- help: try: `if let Ok() = res` [INFO] [stdout] 76 | json_data = res.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `res` after checking its variant with `is_ok` [INFO] [stdout] --> src/main.rs:85:25 [INFO] [stdout] | [INFO] [stdout] 84 | if res.is_ok() { [INFO] [stdout] | -------------- help: try: `if let Ok() = res` [INFO] [stdout] 85 | json_data = res.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | if !Version::parse(&from_version).is_ok() || !Version::parse(&to_version).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Version::parse(&from_version).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:34:50 [INFO] [stdout] | [INFO] [stdout] 34 | if !Version::parse(&from_version).is_ok() || !Version::parse(&to_version).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Version::parse(&to_version).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:112:16 [INFO] [stdout] | [INFO] [stdout] 112 | log.debug(&format!("{}", v2_yml.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `v2_yml.clone().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:114:16 [INFO] [stdout] | [INFO] [stdout] 114 | log.debug(&format!("{}", v3_yml.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `v3_yml.clone().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 30.63s [INFO] running `Command { std: "docker" "inspect" "78ecab9e700ab496905e4385527f2fe6be99bd6f26c791fdb41e14d29fb5d7dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "78ecab9e700ab496905e4385527f2fe6be99bd6f26c791fdb41e14d29fb5d7dd", kill_on_drop: false }` [INFO] [stdout] 78ecab9e700ab496905e4385527f2fe6be99bd6f26c791fdb41e14d29fb5d7dd