[INFO] cloning repository https://github.com/lmburns/tern [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/lmburns/tern" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flmburns%2Ftern", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flmburns%2Ftern'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9a8366d59ac6747af23acf234a77fa66b8de0f8d [INFO] linting lmburns/tern against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flmburns%2Ftern" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/lmburns/tern [INFO] finished tweaking git repo https://github.com/lmburns/tern [INFO] tweaked toml for git repo https://github.com/lmburns/tern written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/lmburns/tern on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/lmburns/tern already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9867859059b9d685aaa3f6c7abcfa7bb67f2a9a862de5b6c8fb1b7bc8e4aa67c [INFO] running `Command { std: "docker" "start" "-a" "9867859059b9d685aaa3f6c7abcfa7bb67f2a9a862de5b6c8fb1b7bc8e4aa67c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9867859059b9d685aaa3f6c7abcfa7bb67f2a9a862de5b6c8fb1b7bc8e4aa67c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9867859059b9d685aaa3f6c7abcfa7bb67f2a9a862de5b6c8fb1b7bc8e4aa67c", kill_on_drop: false }` [INFO] [stdout] 9867859059b9d685aaa3f6c7abcfa7bb67f2a9a862de5b6c8fb1b7bc8e4aa67c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0317ca7337975b814a71dc59778f1563c241cd674ad8b91f540120cd2dd12542 [INFO] running `Command { std: "docker" "start" "-a" "0317ca7337975b814a71dc59778f1563c241cd674ad8b91f540120cd2dd12542", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Checking unicode-ident v1.0.6 [INFO] [stderr] Compiling anyhow v1.0.72 [INFO] [stderr] Checking quote v1.0.31 [INFO] [stderr] Checking syn v2.0.26 [INFO] [stderr] Checking tern v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/test.rs:23:18 [INFO] [stdout] | [INFO] [stdout] 23 | let res = t!(!(a > b) ? b : c); [INFO] [stdout] | ^^^^^^^^ help: try: `(a <= b)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `v.get(0)` [INFO] [stdout] --> tests/test.rs:52:20 [INFO] [stdout] | [INFO] [stdout] 52 | let res = t!((*v.get(0).context("no first")?) == 1 ? "equals 1" : "not 1"); [INFO] [stdout] | ^^^^^^^^ help: try: `v.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `v.get(0)` [INFO] [stdout] --> tests/test.rs:63:20 [INFO] [stdout] | [INFO] [stdout] 63 | let res = t!((*v.get(0).context("no first")?) == inner::NUM ? "equals 10" : "not 10"); [INFO] [stdout] | ^^^^^^^^ help: try: `v.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `v.get(0)` [INFO] [stdout] --> tests/test.rs:67:11 [INFO] [stdout] | [INFO] [stdout] 67 | (*v.get(0).context("no first")? as inner::Test) == inner::NUM [INFO] [stdout] | ^^^^^^^^ help: try: `v.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `v.get(0)` [INFO] [stdout] --> tests/test.rs:74:11 [INFO] [stdout] | [INFO] [stdout] 74 | (*v.get(0).context("no first")?) == ::new() [INFO] [stdout] | ^^^^^^^^ help: try: `v.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> tests/test.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | fn new() -> usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/test.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | let v = vec![1, 3, 5, 7]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: you can use an array directly: `[1, 3, 5, 7]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/test.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | let v = vec![10, 3, 5, 7]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[10, 3, 5, 7]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.17s [INFO] running `Command { std: "docker" "inspect" "0317ca7337975b814a71dc59778f1563c241cd674ad8b91f540120cd2dd12542", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0317ca7337975b814a71dc59778f1563c241cd674ad8b91f540120cd2dd12542", kill_on_drop: false }` [INFO] [stdout] 0317ca7337975b814a71dc59778f1563c241cd674ad8b91f540120cd2dd12542