[INFO] cloning repository https://github.com/lleokaganov/wsuart [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/lleokaganov/wsuart" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flleokaganov%2Fwsuart", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flleokaganov%2Fwsuart'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1f69ff4db6cd4d172fdfa8afda5ee54db50c1c29 [INFO] linting lleokaganov/wsuart against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flleokaganov%2Fwsuart" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/lleokaganov/wsuart [INFO] finished tweaking git repo https://github.com/lleokaganov/wsuart [INFO] tweaked toml for git repo https://github.com/lleokaganov/wsuart written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/lleokaganov/wsuart on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/lleokaganov/wsuart already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded base64ct v1.8.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 970f1fe1b8e0618fd04c7b0de19cfee6b480b8e7057d0f956af7c0663320d071 [INFO] running `Command { std: "docker" "start" "-a" "970f1fe1b8e0618fd04c7b0de19cfee6b480b8e7057d0f956af7c0663320d071", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "970f1fe1b8e0618fd04c7b0de19cfee6b480b8e7057d0f956af7c0663320d071", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "970f1fe1b8e0618fd04c7b0de19cfee6b480b8e7057d0f956af7c0663320d071", kill_on_drop: false }` [INFO] [stdout] 970f1fe1b8e0618fd04c7b0de19cfee6b480b8e7057d0f956af7c0663320d071 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8a1fef4f6818af4e249905de4e06117578e9384de874e3ce1a4632de564c5b28 [INFO] running `Command { std: "docker" "start" "-a" "8a1fef4f6818af4e249905de4e06117578e9384de874e3ce1a4632de564c5b28", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Checking percent-encoding v2.3.2 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Checking unescaper v0.1.8 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking serialport v4.8.1 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking x25519-dalek v2.0.1 [INFO] [stderr] Checking ed25519-dalek v2.2.0 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking tungstenite v0.21.0 [INFO] [stderr] Checking tokio-tungstenite v0.21.0 [INFO] [stderr] Checking wsuart v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: using `clone` on type `GenericArray, B1>, B0>, B0>, B0>>` which implements the `Copy` trait [INFO] [stdout] --> src/crypto25519.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | XNonce::from_slice(&out).clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*XNonce::from_slice(&out)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[u8; 32]` which implements the `Copy` trait [INFO] [stdout] --> src/crypto25519.rs:71:18 [INFO] [stdout] | [INFO] [stdout] 71 | let mut sk = seed.clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*seed` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `Bad` [INFO] [stdout] --> src/crypto25519.rs:110:1 [INFO] [stdout] | [INFO] [stdout] 110 | / pub enum DecryptError { [INFO] [stdout] 111 | | BadNonce, [INFO] [stdout] 112 | | BadSignature, [INFO] [stdout] 113 | | BadFormat, [INFO] [stdout] 114 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/crypto25519.rs:131:8 [INFO] [stdout] | [INFO] [stdout] 131 | if !ed_he_public.verify(nonce_and_cipher, &Signature::from_bytes(&sig_arr)).is_ok() { return Err(DecryptError::BadSignature); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ed_he_public.verify(nonce_and_cipher, &Signature::from_bytes(&sig_arr)).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GenericArray, B1>, B0>, B0>, B0>>` which implements the `Copy` trait [INFO] [stdout] --> src/crypto25519.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | XNonce::from_slice(&out).clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*XNonce::from_slice(&out)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[u8; 32]` which implements the `Copy` trait [INFO] [stdout] --> src/crypto25519.rs:71:18 [INFO] [stdout] | [INFO] [stdout] 71 | let mut sk = seed.clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*seed` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/config.rs:34:37 [INFO] [stdout] | [INFO] [stdout] 34 | ),hex::encode_upper(&crate::crypto25519::seed()), hex::encode_upper(&crate::crypto25519::seed()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `crate::crypto25519::seed()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `Bad` [INFO] [stdout] --> src/crypto25519.rs:110:1 [INFO] [stdout] | [INFO] [stdout] 110 | / pub enum DecryptError { [INFO] [stdout] 111 | | BadNonce, [INFO] [stdout] 112 | | BadSignature, [INFO] [stdout] 113 | | BadFormat, [INFO] [stdout] 114 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/config.rs:34:85 [INFO] [stdout] | [INFO] [stdout] 34 | ),hex::encode_upper(&crate::crypto25519::seed()), hex::encode_upper(&crate::crypto25519::seed()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `crate::crypto25519::seed()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/crypto25519.rs:131:8 [INFO] [stdout] | [INFO] [stdout] 131 | if !ed_he_public.verify(nonce_and_cipher, &Signature::from_bytes(&sig_arr)).is_ok() { return Err(DecryptError::BadSignature); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ed_he_public.verify(nonce_and_cipher, &Signature::from_bytes(&sig_arr)).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/config.rs:40:39 [INFO] [stdout] | [INFO] [stdout] 40 | let seed_x = <[u8; 32]>::from_hex(&seed_x_hex).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `seed_x_hex` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/config.rs:43:40 [INFO] [stdout] | [INFO] [stdout] 43 | let seed_ed = <[u8; 32]>::from_hex(&seed_ed_hex).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `seed_ed_hex` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[u8; 32]` which implements the `Copy` trait [INFO] [stdout] --> src/config.rs:54:20 [INFO] [stdout] | [INFO] [stdout] 54 | secret_ed: secret_ed.as_bytes().clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*secret_ed.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/config.rs:34:37 [INFO] [stdout] | [INFO] [stdout] 34 | ),hex::encode_upper(&crate::crypto25519::seed()), hex::encode_upper(&crate::crypto25519::seed()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `crate::crypto25519::seed()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/config.rs:34:85 [INFO] [stdout] | [INFO] [stdout] 34 | ),hex::encode_upper(&crate::crypto25519::seed()), hex::encode_upper(&crate::crypto25519::seed()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `crate::crypto25519::seed()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/config.rs:40:39 [INFO] [stdout] | [INFO] [stdout] 40 | let seed_x = <[u8; 32]>::from_hex(&seed_x_hex).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `seed_x_hex` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/config.rs:43:40 [INFO] [stdout] | [INFO] [stdout] 43 | let seed_ed = <[u8; 32]>::from_hex(&seed_ed_hex).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `seed_ed_hex` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[u8; 32]` which implements the `Copy` trait [INFO] [stdout] --> src/config.rs:54:20 [INFO] [stdout] | [INFO] [stdout] 54 | secret_ed: secret_ed.as_bytes().clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*secret_ed.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/uart.rs:46:40 [INFO] [stdout] | [INFO] [stdout] 46 | .unwrap_or_else(|e| { err_exit(&format!("UART open failed: {} ({})", MY_CONFIG.uart, e)) }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("UART open failed: {} ({})", MY_CONFIG.uart, e)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/uart.rs:91:29 [INFO] [stdout] | [INFO] [stdout] 91 | let mut tio = tcgetattr(&fd).unwrap(); [INFO] [stdout] | ^^^ help: change this to: `fd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/uart.rs:106:15 [INFO] [stdout] | [INFO] [stdout] 106 | tcsetattr(&fd, SetArg::TCSANOW, &tio).unwrap(); [INFO] [stdout] | ^^^ help: change this to: `fd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/uart.rs:46:40 [INFO] [stdout] | [INFO] [stdout] 46 | .unwrap_or_else(|e| { err_exit(&format!("UART open failed: {} ({})", MY_CONFIG.uart, e)) }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("UART open failed: {} ({})", MY_CONFIG.uart, e)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/uart.rs:91:29 [INFO] [stdout] | [INFO] [stdout] 91 | let mut tio = tcgetattr(&fd).unwrap(); [INFO] [stdout] | ^^^ help: change this to: `fd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/uart.rs:106:15 [INFO] [stdout] | [INFO] [stdout] 106 | tcsetattr(&fd, SetArg::TCSANOW, &tio).unwrap(); [INFO] [stdout] | ^^^ help: change this to: `fd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ws.rs:139:13 [INFO] [stdout] | [INFO] [stdout] 139 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 138 - eprintln!("WS unknown command: {} {}", cmd, std::str::from_utf8(&body).unwrap_or("")); [INFO] [stdout] 139 - return; [INFO] [stdout] 138 + eprintln!("WS unknown command: {} {}", cmd, std::str::from_utf8(&body).unwrap_or("")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ws.rs:143:13 [INFO] [stdout] | [INFO] [stdout] 143 | / if s.starts_with(r#"{"action":"login""#) { [INFO] [stdout] 144 | | crate::config::err_exit(format!("\nA device with these keys is not registered:\n{}-{}\n", [INFO] [stdout] 145 | | hex::encode_upper(&MY_CONFIG.public_x), [INFO] [stdout] 146 | | hex::encode_upper(MY_CONFIG.public_ed.as_bytes()) [INFO] [stdout] 147 | | )); [INFO] [stdout] 148 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 142 ~ Message::Text(s) [INFO] [stdout] 143 ~ if s.starts_with(r#"{"action":"login""#) => { [INFO] [stdout] 144 | crate::config::err_exit(format!("\nA device with these keys is not registered:\n{}-{}\n", [INFO] [stdout] ... [INFO] [stdout] 148 | } [INFO] [stdout] 149 ~ // eprintln!("WS text message: {}", s); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/ws.rs:92:20 [INFO] [stdout] | [INFO] [stdout] 92 | if MY_CONFIG.uart == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `MY_CONFIG.uart.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ws.rs:139:13 [INFO] [stdout] | [INFO] [stdout] 139 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 138 - eprintln!("WS unknown command: {} {}", cmd, std::str::from_utf8(&body).unwrap_or("")); [INFO] [stdout] 139 - return; [INFO] [stdout] 138 + eprintln!("WS unknown command: {} {}", cmd, std::str::from_utf8(&body).unwrap_or("")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ws.rs:143:13 [INFO] [stdout] | [INFO] [stdout] 143 | / if s.starts_with(r#"{"action":"login""#) { [INFO] [stdout] 144 | | crate::config::err_exit(format!("\nA device with these keys is not registered:\n{}-{}\n", [INFO] [stdout] 145 | | hex::encode_upper(&MY_CONFIG.public_x), [INFO] [stdout] 146 | | hex::encode_upper(MY_CONFIG.public_ed.as_bytes()) [INFO] [stdout] 147 | | )); [INFO] [stdout] 148 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 142 ~ Message::Text(s) [INFO] [stdout] 143 ~ if s.starts_with(r#"{"action":"login""#) => { [INFO] [stdout] 144 | crate::config::err_exit(format!("\nA device with these keys is not registered:\n{}-{}\n", [INFO] [stdout] ... [INFO] [stdout] 148 | } [INFO] [stdout] 149 ~ // eprintln!("WS text message: {}", s); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/ws.rs:92:20 [INFO] [stdout] | [INFO] [stdout] 92 | if MY_CONFIG.uart == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `MY_CONFIG.uart.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 43.61s [INFO] running `Command { std: "docker" "inspect" "8a1fef4f6818af4e249905de4e06117578e9384de874e3ce1a4632de564c5b28", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8a1fef4f6818af4e249905de4e06117578e9384de874e3ce1a4632de564c5b28", kill_on_drop: false }` [INFO] [stdout] 8a1fef4f6818af4e249905de4e06117578e9384de874e3ce1a4632de564c5b28