[INFO] cloning repository https://github.com/lleokaganov/aguardia_server [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/lleokaganov/aguardia_server" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flleokaganov%2Faguardia_server", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flleokaganov%2Faguardia_server'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1846055e04b632cb1838197d69fcfcacb11a39f6 [INFO] linting lleokaganov/aguardia_server against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flleokaganov%2Faguardia_server" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/lleokaganov/aguardia_server [INFO] finished tweaking git repo https://github.com/lleokaganov/aguardia_server [INFO] tweaked toml for git repo https://github.com/lleokaganov/aguardia_server written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/lleokaganov/aguardia_server on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/lleokaganov/aguardia_server already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serde_spanned v1.0.2 [INFO] [stderr] Downloaded actix-ws v0.3.0 [INFO] [stderr] Downloaded toml v0.9.7 [INFO] [stderr] Downloaded actix-files v0.6.9 [INFO] [stderr] Downloaded regex-lite v0.1.7 [INFO] [stderr] Downloaded actix-http v3.11.1 [INFO] [stderr] Downloaded lettre v0.11.19 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 13611a1ccd1fe38e6f150073afa54c60e488e8bd18a6cfbcc067f6f22463344b [INFO] running `Command { std: "docker" "start" "-a" "13611a1ccd1fe38e6f150073afa54c60e488e8bd18a6cfbcc067f6f22463344b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "13611a1ccd1fe38e6f150073afa54c60e488e8bd18a6cfbcc067f6f22463344b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "13611a1ccd1fe38e6f150073afa54c60e488e8bd18a6cfbcc067f6f22463344b", kill_on_drop: false }` [INFO] [stdout] 13611a1ccd1fe38e6f150073afa54c60e488e8bd18a6cfbcc067f6f22463344b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1453b7ad240e13e0d63313056ae80ad4b05b4791631d0f1711a18cd342e869d1 [INFO] running `Command { std: "docker" "start" "-a" "1453b7ad240e13e0d63313056ae80ad4b05b4791631d0f1711a18cd342e869d1", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.176 [INFO] [stderr] Compiling cc v1.2.39 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Compiling zerofrom v0.1.6 [INFO] [stderr] Compiling stable_deref_trait v1.2.0 [INFO] [stderr] Compiling bytes v1.10.1 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling writeable v0.6.1 [INFO] [stderr] Compiling litemap v0.8.0 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking socket2 v0.6.0 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking signal-hook-registry v1.4.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking potential_utf v0.1.3 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Compiling smallvec v1.15.1 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking tokio v1.47.1 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Compiling zerocopy v0.8.27 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking getrandom v0.3.3 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling foreign-types-shared v0.1.1 [INFO] [stderr] Compiling foreign-types v0.3.2 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking serde_json v1.0.145 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Compiling object v0.32.2 [INFO] [stderr] Compiling icu_normalizer_data v2.0.0 [INFO] [stderr] Compiling icu_properties_data v2.0.1 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling futures-core v0.3.31 [INFO] [stderr] Compiling tracing-core v0.1.34 [INFO] [stderr] Compiling bitflags v2.9.4 [INFO] [stderr] Compiling derive_more-impl v2.0.1 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking actix-utils v3.0.1 [INFO] [stderr] Compiling bytestring v1.5.0 [INFO] [stderr] Checking actix-service v2.0.3 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking actix-rt v2.11.0 [INFO] [stderr] Checking tokio-util v0.7.16 [INFO] [stderr] Compiling instant v0.1.13 [INFO] [stderr] Compiling openssl-probe v0.1.6 [INFO] [stderr] Compiling regex-lite v0.1.7 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking derive_more v2.0.1 [INFO] [stderr] Compiling actix-router v0.5.3 [INFO] [stderr] Compiling ar_archive_writer v0.2.0 [INFO] [stderr] Compiling lock_api v0.4.13 [INFO] [stderr] Checking actix-codec v0.5.2 [INFO] [stderr] Checking deranged v0.5.4 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Compiling psm v0.1.28 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Compiling ppv-lite86 v0.2.21 [INFO] [stderr] Checking local-channel v0.1.5 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking time-core v0.1.6 [INFO] [stderr] Checking foldhash v0.1.5 [INFO] [stderr] Compiling futures-sink v0.3.31 [INFO] [stderr] Checking language-tags v0.3.2 [INFO] [stderr] Compiling darling_core v0.21.3 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling form_urlencoded v1.2.2 [INFO] [stderr] Checking time v0.3.44 [INFO] [stderr] Checking actix-http v3.11.1 [INFO] [stderr] Checking actix-server v2.6.0 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling actix-web-codegen v4.3.0 [INFO] [stderr] Compiling parking_lot v0.11.2 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling hmac v0.12.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling stacker v0.1.22 [INFO] [stderr] Compiling dirs-sys v0.3.7 [INFO] [stderr] Compiling actix-macros v0.2.4 [INFO] [stderr] Compiling tokio-native-tls v0.3.1 [INFO] [stderr] Compiling unicase v2.8.1 [INFO] [stderr] Compiling futures-task v0.3.31 [INFO] [stderr] Checking impl-more v0.1.9 [INFO] [stderr] Compiling atoi v1.0.0 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking actix-web v4.11.0 [INFO] [stderr] Compiling sqlformat v0.2.6 [INFO] [stderr] Compiling sqlx-rt v0.6.3 [INFO] [stderr] Compiling darling_macro v0.21.3 [INFO] [stderr] Compiling crossbeam-queue v0.3.12 [INFO] [stderr] Compiling dirs v4.0.0 [INFO] [stderr] Compiling tokio-stream v0.1.17 [INFO] [stderr] Compiling hkdf v0.12.4 [INFO] [stderr] Compiling futures-intrusive v0.4.2 [INFO] [stderr] Compiling hashlink v0.8.4 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Compiling futures-channel v0.3.31 [INFO] [stderr] Compiling sha2 v0.10.9 [INFO] [stderr] Compiling thiserror v1.0.69 [INFO] [stderr] Compiling md-5 v0.10.6 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling v_htmlescape v0.15.8 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Compiling whoami v1.6.1 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling base64 v0.13.1 [INFO] [stderr] Checking winnow v0.7.13 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling darling v0.21.3 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking toml_datetime v0.7.2 [INFO] [stderr] Checking serde_spanned v1.0.2 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Compiling serde_with_macros v3.14.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking chumsky v0.9.3 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking toml_parser v1.0.3 [INFO] [stderr] Checking email-encoding v0.4.1 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking toml v0.9.7 [INFO] [stderr] Checking hostname v0.4.2 [INFO] [stderr] Checking thread_local v1.1.9 [INFO] [stderr] Checking email_address v0.2.9 [INFO] [stderr] Compiling sqlx-core v0.6.3 [INFO] [stderr] Checking http-range v0.1.5 [INFO] [stderr] Checking quoted_printable v0.5.1 [INFO] [stderr] Checking serde_with v3.14.1 [INFO] [stderr] Checking actix-files v0.6.9 [INFO] [stderr] Checking config v0.15.18 [INFO] [stderr] Checking tracing-subscriber v0.3.20 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking ed25519-dalek v2.2.0 [INFO] [stderr] Checking lettre v0.11.19 [INFO] [stderr] Checking x25519-dalek v2.0.1 [INFO] [stderr] Checking actix-cors v0.7.1 [INFO] [stderr] Checking actix-ws v0.3.0 [INFO] [stderr] Checking secrecy v0.10.3 [INFO] [stderr] Compiling sqlx-macros v0.6.3 [INFO] [stderr] Checking sqlx v0.6.3 [INFO] [stderr] Checking aguardia_server v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/handlers_ws.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use actix_ws; [INFO] [stdout] | ^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/handlers_ws.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use actix_ws; [INFO] [stdout] | ^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | return err("Invalid cmd"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - return err("Invalid cmd"); [INFO] [stdout] 67 + err("Invalid cmd") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server_0x00.rs:284:5 [INFO] [stdout] | [INFO] [stdout] 284 | return Err("Not implemented".into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 284 - return Err("Not implemented".into()); [INFO] [stdout] 284 + Err("Not implemented".into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/server_0x00.rs:107:51 [INFO] [stdout] | [INFO] [stdout] 107 | .await.map_err(|e| format!("DB err: {}", e.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/server_0x00.rs:161:13 [INFO] [stdout] | [INFO] [stdout] 161 | &hub_state, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `hub_state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/server_0x00.rs:202:69 [INFO] [stdout] | [INFO] [stdout] 202 | .execute(pool).await.map_err(|e| format!("DB err: {}", e.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/server_0x00.rs:220:72 [INFO] [stdout] | [INFO] [stdout] 220 | .fetch_optional(pool).await.map_err(|e| format!("DB err: {}", e.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/server_0x00.rs:234:69 [INFO] [stdout] | [INFO] [stdout] 234 | .execute(pool).await.map_err(|e| format!("DB err: {}", e.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/server_0x00.rs:237:69 [INFO] [stdout] | [INFO] [stdout] 237 | .execute(pool).await.map_err(|e| format!("DB err: {}", e.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/server_0x00.rs:261:51 [INFO] [stdout] | [INFO] [stdout] 261 | .await.map_err(|e| format!("DB err: {}", e.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/server_0x00.rs:280:99 [INFO] [stdout] | [INFO] [stdout] 280 | .bind(data_id).bind(device_id).execute(pool).await.map_err(|e| format!("DB err: {}", e.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `row` after checking its variant with `is_none` [INFO] [stdout] --> src/handlers_ws.rs:235:46 [INFO] [stdout] | [INFO] [stdout] 85 | if row.is_none() { [INFO] [stdout] | ---------------- help: try: `if let Some() = row` [INFO] [stdout] ... [INFO] [stdout] 235 | let (id, public_x): (i32, Vec) = row.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/handlers_ws.rs:94:38 [INFO] [stdout] | [INFO] [stdout] 94 | let hash = hex::encode_upper(&hash); [INFO] [stdout] | ^^^^^ help: change this to: `hash` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/crypto25519.rs:31:44 [INFO] [stdout] | [INFO] [stdout] 31 | pk.verify(data, &Signature::from_bytes(&sig)).is_ok() [INFO] [stdout] | ^^^^ help: change this to: `sig` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GenericArray, B1>, B0>, B0>, B0>>` which implements the `Copy` trait [INFO] [stdout] --> src/crypto25519.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | XNonce::from_slice(&out).clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*XNonce::from_slice(&out)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[u8; 32]` which implements the `Copy` trait [INFO] [stdout] --> src/crypto25519.rs:89:18 [INFO] [stdout] | [INFO] [stdout] 89 | let mut sk = seed.clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*seed` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `Bad` [INFO] [stdout] --> src/crypto25519.rs:128:1 [INFO] [stdout] | [INFO] [stdout] 128 | / pub enum DecryptError { [INFO] [stdout] 129 | | BadNonce, [INFO] [stdout] 130 | | BadSignature, [INFO] [stdout] 131 | | BadFormat, [INFO] [stdout] 132 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/crypto25519.rs:149:8 [INFO] [stdout] | [INFO] [stdout] 149 | if !ed_he_public.verify(nonce_and_cipher, &Signature::from_bytes(&sig_arr)).is_ok() { return Err(DecryptError::BadSignature); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ed_he_public.verify(nonce_and_cipher, &Signature::from_bytes(&sig_arr)).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/crypto25519.rs:185:37 [INFO] [stdout] | [INFO] [stdout] 185 | let decoded = base64_to_bin(&data).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/crypto25519.rs:216:55 [INFO] [stdout] | [INFO] [stdout] 216 | let enc = encrypt_message(&x_pk_he, &x_sk_my, &text.as_bytes(), &nonce); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `text.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/crypto25519.rs:256:9 [INFO] [stdout] | [INFO] [stdout] 256 | assert_eq!(*ok, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 256 - assert_eq!(*ok, true); [INFO] [stdout] 256 + assert!(*ok); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[u8; 32]` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:87:20 [INFO] [stdout] | [INFO] [stdout] 87 | secret_ed: secret_ed.as_bytes().clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*secret_ed.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:105:8 [INFO] [stdout] | [INFO] [stdout] 105 | if CONFIG.seed_x == "" || CONFIG.seed_ed == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `CONFIG.seed_x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:105:31 [INFO] [stdout] | [INFO] [stdout] 105 | if CONFIG.seed_x == "" || CONFIG.seed_ed == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `CONFIG.seed_ed.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:109:27 [INFO] [stdout] | [INFO] [stdout] 109 | hex::encode_upper(&crypto25519::seed()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `crypto25519::seed()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:110:27 [INFO] [stdout] | [INFO] [stdout] 110 | hex::encode_upper(&crypto25519::seed()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `crypto25519::seed()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | return err("Invalid cmd"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - return err("Invalid cmd"); [INFO] [stdout] 67 + err("Invalid cmd") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server_0x00.rs:284:5 [INFO] [stdout] | [INFO] [stdout] 284 | return Err("Not implemented".into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 284 - return Err("Not implemented".into()); [INFO] [stdout] 284 + Err("Not implemented".into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/server_0x00.rs:107:51 [INFO] [stdout] | [INFO] [stdout] 107 | .await.map_err(|e| format!("DB err: {}", e.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/server_0x00.rs:161:13 [INFO] [stdout] | [INFO] [stdout] 161 | &hub_state, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `hub_state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/server_0x00.rs:202:69 [INFO] [stdout] | [INFO] [stdout] 202 | .execute(pool).await.map_err(|e| format!("DB err: {}", e.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/server_0x00.rs:220:72 [INFO] [stdout] | [INFO] [stdout] 220 | .fetch_optional(pool).await.map_err(|e| format!("DB err: {}", e.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/server_0x00.rs:234:69 [INFO] [stdout] | [INFO] [stdout] 234 | .execute(pool).await.map_err(|e| format!("DB err: {}", e.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/server_0x00.rs:237:69 [INFO] [stdout] | [INFO] [stdout] 237 | .execute(pool).await.map_err(|e| format!("DB err: {}", e.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/server_0x00.rs:261:51 [INFO] [stdout] | [INFO] [stdout] 261 | .await.map_err(|e| format!("DB err: {}", e.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/server_0x00.rs:280:99 [INFO] [stdout] | [INFO] [stdout] 280 | .bind(data_id).bind(device_id).execute(pool).await.map_err(|e| format!("DB err: {}", e.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `row` after checking its variant with `is_none` [INFO] [stdout] --> src/handlers_ws.rs:235:46 [INFO] [stdout] | [INFO] [stdout] 85 | if row.is_none() { [INFO] [stdout] | ---------------- help: try: `if let Some() = row` [INFO] [stdout] ... [INFO] [stdout] 235 | let (id, public_x): (i32, Vec) = row.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/handlers_ws.rs:94:38 [INFO] [stdout] | [INFO] [stdout] 94 | let hash = hex::encode_upper(&hash); [INFO] [stdout] | ^^^^^ help: change this to: `hash` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/crypto25519.rs:31:44 [INFO] [stdout] | [INFO] [stdout] 31 | pk.verify(data, &Signature::from_bytes(&sig)).is_ok() [INFO] [stdout] | ^^^^ help: change this to: `sig` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GenericArray, B1>, B0>, B0>, B0>>` which implements the `Copy` trait [INFO] [stdout] --> src/crypto25519.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | XNonce::from_slice(&out).clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*XNonce::from_slice(&out)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[u8; 32]` which implements the `Copy` trait [INFO] [stdout] --> src/crypto25519.rs:89:18 [INFO] [stdout] | [INFO] [stdout] 89 | let mut sk = seed.clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*seed` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `Bad` [INFO] [stdout] --> src/crypto25519.rs:128:1 [INFO] [stdout] | [INFO] [stdout] 128 | / pub enum DecryptError { [INFO] [stdout] 129 | | BadNonce, [INFO] [stdout] 130 | | BadSignature, [INFO] [stdout] 131 | | BadFormat, [INFO] [stdout] 132 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/crypto25519.rs:149:8 [INFO] [stdout] | [INFO] [stdout] 149 | if !ed_he_public.verify(nonce_and_cipher, &Signature::from_bytes(&sig_arr)).is_ok() { return Err(DecryptError::BadSignature); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ed_he_public.verify(nonce_and_cipher, &Signature::from_bytes(&sig_arr)).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[u8; 32]` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:87:20 [INFO] [stdout] | [INFO] [stdout] 87 | secret_ed: secret_ed.as_bytes().clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*secret_ed.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:105:8 [INFO] [stdout] | [INFO] [stdout] 105 | if CONFIG.seed_x == "" || CONFIG.seed_ed == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `CONFIG.seed_x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:105:31 [INFO] [stdout] | [INFO] [stdout] 105 | if CONFIG.seed_x == "" || CONFIG.seed_ed == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `CONFIG.seed_ed.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:109:27 [INFO] [stdout] | [INFO] [stdout] 109 | hex::encode_upper(&crypto25519::seed()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `crypto25519::seed()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:110:27 [INFO] [stdout] | [INFO] [stdout] 110 | hex::encode_upper(&crypto25519::seed()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `crypto25519::seed()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 33s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: sqlx-core v0.6.3 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 5` [INFO] running `Command { std: "docker" "inspect" "1453b7ad240e13e0d63313056ae80ad4b05b4791631d0f1711a18cd342e869d1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1453b7ad240e13e0d63313056ae80ad4b05b4791631d0f1711a18cd342e869d1", kill_on_drop: false }` [INFO] [stdout] 1453b7ad240e13e0d63313056ae80ad4b05b4791631d0f1711a18cd342e869d1