[INFO] cloning repository https://github.com/liuqcd/rmeter_workspace [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/liuqcd/rmeter_workspace" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fliuqcd%2Frmeter_workspace", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fliuqcd%2Frmeter_workspace'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 16aea974e628f2840701db2a127db3fad2989e62 [INFO] linting liuqcd/rmeter_workspace against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fliuqcd%2Frmeter_workspace" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/liuqcd/rmeter_workspace [INFO] finished tweaking git repo https://github.com/liuqcd/rmeter_workspace [INFO] tweaked toml for git repo https://github.com/liuqcd/rmeter_workspace written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/liuqcd/rmeter_workspace on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/liuqcd/rmeter_workspace already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded russh-sftp v2.1.1 [INFO] [stderr] Downloaded askama_parser v0.13.0 [INFO] [stderr] Downloaded bcrypt-pbkdf v0.10.0 [INFO] [stderr] Downloaded ssh-encoding v0.2.0 [INFO] [stderr] Downloaded pkcs5 v0.7.1 [INFO] [stderr] Downloaded askama_derive v0.13.1 [INFO] [stderr] Downloaded ndarray-stats v0.6.0 [INFO] [stderr] Downloaded flurry v0.5.2 [INFO] [stderr] Downloaded internal-russh-forked-ssh-key v0.6.10+upstream-0.6.7 [INFO] [stderr] Downloaded async-ssh2-tokio v0.10.0 [INFO] [stderr] Downloaded russh v0.52.1 [INFO] [stderr] Downloaded p521 v0.13.3 [INFO] [stderr] Downloaded seize v0.3.3 [INFO] [stderr] Downloaded ssh-cipher v0.2.0 [INFO] [stderr] Downloaded pageant v0.0.3 [INFO] [stderr] Downloaded russh-cryptovec v0.52.0 [INFO] [stderr] Downloaded russh-util v0.52.0 [INFO] [stderr] Downloaded askama v0.13.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f273b08ff79fc75ab2f13cbdd4400bed298031179b09c57a296dfd13c252e791 [INFO] running `Command { std: "docker" "start" "-a" "f273b08ff79fc75ab2f13cbdd4400bed298031179b09c57a296dfd13c252e791", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f273b08ff79fc75ab2f13cbdd4400bed298031179b09c57a296dfd13c252e791", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f273b08ff79fc75ab2f13cbdd4400bed298031179b09c57a296dfd13c252e791", kill_on_drop: false }` [INFO] [stdout] f273b08ff79fc75ab2f13cbdd4400bed298031179b09c57a296dfd13c252e791 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4e61440e07650339d4e8fb4a209ce90ed13e8515c15b0b25905ba450cf1d28cd [INFO] running `Command { std: "docker" "start" "-a" "4e61440e07650339d4e8fb4a209ce90ed13e8515c15b0b25905ba450cf1d28cd", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.176 [INFO] [stderr] Compiling unicode-ident v1.0.19 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking base64ct v1.8.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking log v0.4.28 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Checking anstyle v1.0.11 [INFO] [stderr] Checking anstyle-query v1.1.4 [INFO] [stderr] Checking iana-time-zone v0.1.64 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Compiling crunchy v0.2.4 [INFO] [stderr] Checking clap_lex v0.7.5 [INFO] [stderr] Checking anstream v0.6.20 [INFO] [stderr] Checking der v0.7.10 [INFO] [stderr] Compiling cfg-if v1.0.3 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Checking clap_builder v4.5.48 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking block-padding v0.3.3 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Checking fern v0.7.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling getrandom v0.2.16 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling matrixmultiply v0.3.10 [INFO] [stderr] Compiling thiserror v2.0.16 [INFO] [stderr] Checking regex-syntax v0.8.6 [INFO] [stderr] Checking crc32fast v1.5.0 [INFO] [stderr] Compiling proc-macro-error-attr2 v2.0.0 [INFO] [stderr] Checking seize v0.3.3 [INFO] [stderr] Checking flate2 v1.1.2 [INFO] [stderr] Compiling basic-toml v0.1.10 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking ff v0.13.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking salsa20 v0.10.2 [INFO] [stderr] Checking cbc v0.1.2 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking scrypt v0.11.0 [INFO] [stderr] Checking signal-hook-registry v1.4.6 [INFO] [stderr] Checking socket2 v0.6.0 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking ssh-encoding v0.2.0 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking pkcs5 v0.7.1 [INFO] [stderr] Checking num-bigint-dig v0.8.4 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking blowfish v0.9.1 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking password-hash v0.5.0 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking ssh-cipher v0.2.0 [INFO] [stderr] Checking bcrypt-pbkdf v0.10.0 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Checking argon2 v0.5.3 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking regex-automata v0.4.11 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking flurry v0.5.2 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking hex-literal v0.4.1 [INFO] [stderr] Checking hashbrown v0.16.0 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Checking rsa v0.9.8 [INFO] [stderr] Checking unicode-width v0.2.1 [INFO] [stderr] Checking primeorder v0.13.6 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking bytecount v0.6.9 [INFO] [stderr] Checking papergrid v0.14.0 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking ndarray v0.16.1 [INFO] [stderr] Checking indexmap v2.11.4 [INFO] [stderr] Checking p384 v0.13.1 [INFO] [stderr] Checking p521 v0.13.3 [INFO] [stderr] Checking p256 v0.13.2 [INFO] [stderr] Compiling proc-macro-error2 v2.0.1 [INFO] [stderr] Checking noisy_float v0.2.0 [INFO] [stderr] Checking percent-encoding v2.3.2 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking rmeter_workspace v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking regex v1.11.3 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling clap_derive v4.5.47 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling thiserror-impl v2.0.16 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking tokio v1.47.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling enum_dispatch v0.3.13 [INFO] [stderr] Compiling delegate v0.13.4 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling tabled_derive v0.10.0 [INFO] [stderr] Checking ed25519-dalek v2.2.0 [INFO] [stderr] Checking internal-russh-forked-ssh-key v0.6.10+upstream-0.6.7 [INFO] [stderr] Checking ndarray-stats v0.6.0 [INFO] [stderr] Checking clap v4.5.48 [INFO] [stderr] Checking rscript v0.1.0 (/opt/rustwide/workdir/rscript) [INFO] [stdout] warning: unused import: `arg` [INFO] [stdout] --> rscript/src/main.rs:1:31 [INFO] [stdout] | [INFO] [stdout] 1 | use clap::{ArgAction, Parser, arg}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `arg` [INFO] [stdout] --> rscript/src/main.rs:1:31 [INFO] [stdout] | [INFO] [stdout] 1 | use clap::{ArgAction, Parser, arg}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking tabled v0.18.0 [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> rscript/src/main.rs:107:5 [INFO] [stdout] | [INFO] [stdout] 107 | / if let Some(ref force) = args.force { [INFO] [stdout] 108 | | if *force && work_dir.exists() && work_dir.is_dir() { [INFO] [stdout] 109 | | std::fs::remove_dir_all(work_dir)?; [INFO] [stdout] 110 | | } [INFO] [stdout] 111 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 107 ~ if let Some(ref force) = args.force [INFO] [stdout] 108 ~ && *force && work_dir.exists() && work_dir.is_dir() { [INFO] [stdout] 109 | std::fs::remove_dir_all(work_dir)?; [INFO] [stdout] 110 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> rscript/src/main.rs:114:25 [INFO] [stdout] | [INFO] [stdout] 114 | std::fs::create_dir(&work_dir).map_err(|e| anyhow!("work_dir: {:?}, {}", &work_dir, e))?; [INFO] [stdout] | ^^^^^^^^^ help: change this to: `work_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> rscript/src/main.rs:129:5 [INFO] [stdout] | [INFO] [stdout] 129 | / if let Some(ref properties) = args.properties { [INFO] [stdout] 130 | | if *properties { [INFO] [stdout] 131 | | std::fs::copy( [INFO] [stdout] 132 | | tempdir_jmeter.join("test.properties"), [INFO] [stdout] ... | [INFO] [stdout] 136 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 129 ~ if let Some(ref properties) = args.properties [INFO] [stdout] 130 ~ && *properties { [INFO] [stdout] 131 | std::fs::copy( [INFO] [stdout] ... [INFO] [stdout] 134 | )?; [INFO] [stdout] 135 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking rmeter v0.1.0 (/opt/rustwide/workdir/rmeter) [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> rscript/src/main.rs:107:5 [INFO] [stdout] | [INFO] [stdout] 107 | / if let Some(ref force) = args.force { [INFO] [stdout] 108 | | if *force && work_dir.exists() && work_dir.is_dir() { [INFO] [stdout] 109 | | std::fs::remove_dir_all(work_dir)?; [INFO] [stdout] 110 | | } [INFO] [stdout] 111 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 107 ~ if let Some(ref force) = args.force [INFO] [stdout] 108 ~ && *force && work_dir.exists() && work_dir.is_dir() { [INFO] [stdout] 109 | std::fs::remove_dir_all(work_dir)?; [INFO] [stdout] 110 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> rscript/src/main.rs:114:25 [INFO] [stdout] | [INFO] [stdout] 114 | std::fs::create_dir(&work_dir).map_err(|e| anyhow!("work_dir: {:?}, {}", &work_dir, e))?; [INFO] [stdout] | ^^^^^^^^^ help: change this to: `work_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> rscript/src/main.rs:129:5 [INFO] [stdout] | [INFO] [stdout] 129 | / if let Some(ref properties) = args.properties { [INFO] [stdout] 130 | | if *properties { [INFO] [stdout] 131 | | std::fs::copy( [INFO] [stdout] 132 | | tempdir_jmeter.join("test.properties"), [INFO] [stdout] ... | [INFO] [stdout] 136 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 129 ~ if let Some(ref properties) = args.properties [INFO] [stdout] 130 ~ && *properties { [INFO] [stdout] 131 | std::fs::copy( [INFO] [stdout] ... [INFO] [stdout] 134 | )?; [INFO] [stdout] 135 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `arg` [INFO] [stdout] --> rmeter/src/client.rs:2:31 [INFO] [stdout] | [INFO] [stdout] 2 | use clap::{ArgAction, Parser, arg}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `arg` [INFO] [stdout] --> rmeter/src/client.rs:2:31 [INFO] [stdout] | [INFO] [stdout] 2 | use clap::{ArgAction, Parser, arg}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> rmeter/src/client.rs:141:9 [INFO] [stdout] | [INFO] [stdout] 141 | /// 与jmeter -JLoopOrRampupCount= 等价 [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 141 | /// 与jmeter -JLoopOrRampupCount= 等价 [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:64:18 [INFO] [stdout] | [INFO] [stdout] 64 | vec.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:82:41 [INFO] [stdout] | [INFO] [stdout] 82 | ... params.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> rmeter/src/client.rs:141:9 [INFO] [stdout] | [INFO] [stdout] 141 | /// 与jmeter -JLoopOrRampupCount= 等价 [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 141 | /// 与jmeter -JLoopOrRampupCount= 等价 [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:85:41 [INFO] [stdout] | [INFO] [stdout] 85 | ... params.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:86:41 [INFO] [stdout] | [INFO] [stdout] 86 | ... params.push(format!("{}", line)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `line.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:90:29 [INFO] [stdout] | [INFO] [stdout] 90 | params.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:91:29 [INFO] [stdout] | [INFO] [stdout] 91 | params.push(format!("{}", "server.rmi.ssl.disable=false")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"server.rmi.ssl.disable=false".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:92:29 [INFO] [stdout] | [INFO] [stdout] 92 | params.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:93:29 [INFO] [stdout] | [INFO] [stdout] 93 | params.push(format!("{}", "summariser.interval=10")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"summariser.interval=10".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:94:29 [INFO] [stdout] | [INFO] [stdout] 94 | params.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:95:29 [INFO] [stdout] | [INFO] [stdout] 95 | params.push(format!("{}", "jmeter.save.saveservice.timestamp_format=yyyyMMdd-HHmmss.SSS")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"jmeter.save.saveservice.timestamp_format=yyyyMMdd-HHmmss.SSS".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:96:29 [INFO] [stdout] | [INFO] [stdout] 96 | params.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:97:29 [INFO] [stdout] | [INFO] [stdout] 97 | params.push(format!("{}", "server.rmi.ssl.disable=false")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"server.rmi.ssl.disable=false".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:110:29 [INFO] [stdout] | [INFO] [stdout] 110 | params.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:111:29 [INFO] [stdout] | [INFO] [stdout] 111 | params.push(format!("{}", p)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `p.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:119:21 [INFO] [stdout] | [INFO] [stdout] 119 | params.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:121:21 [INFO] [stdout] | [INFO] [stdout] 121 | params.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:123:21 [INFO] [stdout] | [INFO] [stdout] 123 | params.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:125:21 [INFO] [stdout] | [INFO] [stdout] 125 | params.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:127:21 [INFO] [stdout] | [INFO] [stdout] 127 | params.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:129:21 [INFO] [stdout] | [INFO] [stdout] 129 | params.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:131:21 [INFO] [stdout] | [INFO] [stdout] 131 | params.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:133:21 [INFO] [stdout] | [INFO] [stdout] 133 | params.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:64:18 [INFO] [stdout] | [INFO] [stdout] 64 | vec.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:82:41 [INFO] [stdout] | [INFO] [stdout] 82 | ... params.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:85:41 [INFO] [stdout] | [INFO] [stdout] 85 | ... params.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:86:41 [INFO] [stdout] | [INFO] [stdout] 86 | ... params.push(format!("{}", line)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `line.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:90:29 [INFO] [stdout] | [INFO] [stdout] 90 | params.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:91:29 [INFO] [stdout] | [INFO] [stdout] 91 | params.push(format!("{}", "server.rmi.ssl.disable=false")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"server.rmi.ssl.disable=false".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:92:29 [INFO] [stdout] | [INFO] [stdout] 92 | params.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:93:29 [INFO] [stdout] | [INFO] [stdout] 93 | params.push(format!("{}", "summariser.interval=10")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"summariser.interval=10".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:94:29 [INFO] [stdout] | [INFO] [stdout] 94 | params.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:95:29 [INFO] [stdout] | [INFO] [stdout] 95 | params.push(format!("{}", "jmeter.save.saveservice.timestamp_format=yyyyMMdd-HHmmss.SSS")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"jmeter.save.saveservice.timestamp_format=yyyyMMdd-HHmmss.SSS".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:96:29 [INFO] [stdout] | [INFO] [stdout] 96 | params.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:97:29 [INFO] [stdout] | [INFO] [stdout] 97 | params.push(format!("{}", "server.rmi.ssl.disable=false")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"server.rmi.ssl.disable=false".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:110:29 [INFO] [stdout] | [INFO] [stdout] 110 | params.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:111:29 [INFO] [stdout] | [INFO] [stdout] 111 | params.push(format!("{}", p)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `p.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:119:21 [INFO] [stdout] | [INFO] [stdout] 119 | params.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:121:21 [INFO] [stdout] | [INFO] [stdout] 121 | params.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:123:21 [INFO] [stdout] | [INFO] [stdout] 123 | params.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:125:21 [INFO] [stdout] | [INFO] [stdout] 125 | params.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:127:21 [INFO] [stdout] | [INFO] [stdout] 127 | params.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:129:21 [INFO] [stdout] | [INFO] [stdout] 129 | params.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:131:21 [INFO] [stdout] | [INFO] [stdout] 131 | params.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> rmeter/src/jmeter.rs:133:21 [INFO] [stdout] | [INFO] [stdout] 133 | params.push(format!("-J")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-J".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Compiling askama_parser v0.13.0 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking bitflags v2.9.4 [INFO] [stderr] Checking russh-cryptovec v0.52.0 [INFO] [stderr] Compiling askama_derive v0.13.1 [INFO] [stderr] Checking russh-util v0.52.0 [INFO] [stderr] Checking tokio-util v0.7.16 [INFO] [stderr] Checking russh v0.52.1 [INFO] [stderr] Checking russh-sftp v2.1.1 [INFO] [stderr] Checking askama v0.13.1 [INFO] [stderr] Checking rnmon v0.1.0 (/opt/rustwide/workdir/rnmon) [INFO] [stdout] warning: variant `SYS_SUMM` should have an upper camel case name [INFO] [stdout] --> rnmon/src/askama/html.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | SYS_SUMM, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper camel case: `SysSumm` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `CPU_SUMM` should have an upper camel case name [INFO] [stdout] --> rnmon/src/askama/html.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | CPU_SUMM, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper camel case: `CpuSumm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `CPU_ALL` should have an upper camel case name [INFO] [stdout] --> rnmon/src/askama/html.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | CPU_ALL, [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper camel case: `CpuAll` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `MEM_FREE` should have an upper camel case name [INFO] [stdout] --> rnmon/src/askama/html.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | MEM_FREE, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper camel case: `MemFree` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `MEM_ACTIVE` should have an upper camel case name [INFO] [stdout] --> rnmon/src/askama/html.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | MEM_ACTIVE, [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper camel case: `MemActive` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `MEM_SWAP` should have an upper camel case name [INFO] [stdout] --> rnmon/src/askama/html.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | MEM_SWAP, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper camel case: `MemSwap` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `DISKBUSY_AWMN` should have an upper camel case name [INFO] [stdout] --> rnmon/src/askama/html.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | DISKBUSY_AWMN, [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `DiskbusyAwmn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `arg` [INFO] [stdout] --> rnmon/src/main.rs:4:31 [INFO] [stdout] | [INFO] [stdout] 4 | use clap::{ArgAction, Parser, arg}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `SYS_SUMM` should have an upper camel case name [INFO] [stdout] --> rnmon/src/askama/html.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | SYS_SUMM, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper camel case: `SysSumm` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `CPU_SUMM` should have an upper camel case name [INFO] [stdout] --> rnmon/src/askama/html.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | CPU_SUMM, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper camel case: `CpuSumm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `CPU_ALL` should have an upper camel case name [INFO] [stdout] --> rnmon/src/askama/html.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | CPU_ALL, [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper camel case: `CpuAll` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `MEM_FREE` should have an upper camel case name [INFO] [stdout] --> rnmon/src/askama/html.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | MEM_FREE, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper camel case: `MemFree` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `MEM_ACTIVE` should have an upper camel case name [INFO] [stdout] --> rnmon/src/askama/html.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | MEM_ACTIVE, [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper camel case: `MemActive` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `MEM_SWAP` should have an upper camel case name [INFO] [stdout] --> rnmon/src/askama/html.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | MEM_SWAP, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper camel case: `MemSwap` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `DISKBUSY_AWMN` should have an upper camel case name [INFO] [stdout] --> rnmon/src/askama/html.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | DISKBUSY_AWMN, [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `DiskbusyAwmn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `arg` [INFO] [stdout] --> rnmon/src/main.rs:4:31 [INFO] [stdout] | [INFO] [stdout] 4 | use clap::{ArgAction, Parser, arg}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> rnmon/src/askama/html.rs:46:1 [INFO] [stdout] | [INFO] [stdout] 46 | / impl ToString for ChartsName { [INFO] [stdout] 47 | | fn to_string(&self) -> String { [INFO] [stdout] 48 | | match self { [INFO] [stdout] 49 | | ChartsName::SYS_SUMM => "SYS_SUMM".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 60 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Echarts` [INFO] [stdout] --> rnmon/src/askama/js.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | / pub fn new() -> Self { [INFO] [stdout] 37 | | Self {} [INFO] [stdout] 38 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 35 + impl Default for Echarts { [INFO] [stdout] 36 + fn default() -> Self { [INFO] [stdout] 37 + Self::new() [INFO] [stdout] 38 + } [INFO] [stdout] 39 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> rnmon/src/askama/html.rs:46:1 [INFO] [stdout] | [INFO] [stdout] 46 | / impl ToString for ChartsName { [INFO] [stdout] 47 | | fn to_string(&self) -> String { [INFO] [stdout] 48 | | match self { [INFO] [stdout] 49 | | ChartsName::SYS_SUMM => "SYS_SUMM".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 60 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Echarts` [INFO] [stdout] --> rnmon/src/askama/js.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | / pub fn new() -> Self { [INFO] [stdout] 37 | | Self {} [INFO] [stdout] 38 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 35 + impl Default for Echarts { [INFO] [stdout] 36 + fn default() -> Self { [INFO] [stdout] 37 + Self::new() [INFO] [stdout] 38 + } [INFO] [stdout] 39 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> rnmon/src/main.rs:147:12 [INFO] [stdout] | [INFO] [stdout] 147 | if self.run_nmon_args.mem_free || self.run_nmon_args.mem_active || self.run_nmon_args.mem_active { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 147 - if self.run_nmon_args.mem_free || self.run_nmon_args.mem_active || self.run_nmon_args.mem_active { [INFO] [stdout] 147 + if !(!self.run_nmon_args.mem_free && !self.run_nmon_args.mem_active) { [INFO] [stdout] | [INFO] [stdout] 147 - if self.run_nmon_args.mem_free || self.run_nmon_args.mem_active || self.run_nmon_args.mem_active { [INFO] [stdout] 147 + if self.run_nmon_args.mem_free || self.run_nmon_args.mem_active { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rnmon/src/main.rs:191:39 [INFO] [stdout] | [INFO] [stdout] 191 | res.push(NmonData::new(p, &cell).unwrap()); [INFO] [stdout] | ^^^^^ help: change this to: `cell` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rnmon/src/main.rs:255:9 [INFO] [stdout] | [INFO] [stdout] 255 | res_nmon_txt.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `res_nmon_txt.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> rnmon/src/main.rs:397:9 [INFO] [stdout] | [INFO] [stdout] 397 | while let Some(line) = line_iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for line in line_iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> rnmon/src/main.rs:436:51 [INFO] [stdout] | [INFO] [stdout] 436 | lens.insert(name.to_string(), 0 as usize); [INFO] [stdout] | ^^^^^^^^^^ help: try: `0_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> rnmon/src/main.rs:462:54 [INFO] [stdout] | [INFO] [stdout] 462 | ... f32::from_str(e).expect(&format!( [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 463 | | ... "filename: {}, line: {:?}\n, e: {}, ", [INFO] [stdout] 464 | | ... &filename, line, e, [INFO] [stdout] 465 | | ... )) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 462 ~ f32::from_str(e).unwrap_or_else(|_| panic!("filename: {}, line: {:?}\n, e: {}, ", [INFO] [stdout] 463 + &filename, line, e)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> rnmon/src/main.rs:472:25 [INFO] [stdout] | [INFO] [stdout] 472 | *l = *l + 1; [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `*l += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> rnmon/src/main.rs:480:39 [INFO] [stdout] | [INFO] [stdout] 480 | let mut vec_len: Vec = lens.values().map(|l| *l).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `lens.values().copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> rnmon/src/main.rs:550:15 [INFO] [stdout] | [INFO] [stdout] 550 | zzzz: &Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 550 ~ zzzz: &[DateTime], [INFO] [stdout] 551 | // zzzz: Array1>, [INFO] [stdout] ... [INFO] [stdout] 564 | header, [INFO] [stdout] 565 ~ zzzz: zzzz.to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> rnmon/src/main.rs:556:75 [INFO] [stdout] | [INFO] [stdout] 556 | Array2::from_shape_vec((rowsize, colsize).set_f(false), data).expect(&format!( [INFO] [stdout] | ___________________________________________________________________________^ [INFO] [stdout] 557 | | "{}文件,{}指标从vec转化为Array2({}, {})失败", [INFO] [stdout] 558 | | &filename, name, rowsize, colsize [INFO] [stdout] 559 | | )); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 556 ~ Array2::from_shape_vec((rowsize, colsize).set_f(false), data).unwrap_or_else(|_| panic!("{}文件,{}指标从vec转化为Array2({}, {})失败", [INFO] [stdout] 557 ~ &filename, name, rowsize, colsize)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> rnmon/src/main.rs:147:12 [INFO] [stdout] | [INFO] [stdout] 147 | if self.run_nmon_args.mem_free || self.run_nmon_args.mem_active || self.run_nmon_args.mem_active { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 147 - if self.run_nmon_args.mem_free || self.run_nmon_args.mem_active || self.run_nmon_args.mem_active { [INFO] [stdout] 147 + if !(!self.run_nmon_args.mem_free && !self.run_nmon_args.mem_active) { [INFO] [stdout] | [INFO] [stdout] 147 - if self.run_nmon_args.mem_free || self.run_nmon_args.mem_active || self.run_nmon_args.mem_active { [INFO] [stdout] 147 + if self.run_nmon_args.mem_free || self.run_nmon_args.mem_active { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rnmon/src/main.rs:191:39 [INFO] [stdout] | [INFO] [stdout] 191 | res.push(NmonData::new(p, &cell).unwrap()); [INFO] [stdout] | ^^^^^ help: change this to: `cell` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> rnmon/src/main.rs:255:9 [INFO] [stdout] | [INFO] [stdout] 255 | res_nmon_txt.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `res_nmon_txt.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> rnmon/src/main.rs:397:9 [INFO] [stdout] | [INFO] [stdout] 397 | while let Some(line) = line_iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for line in line_iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> rnmon/src/main.rs:436:51 [INFO] [stdout] | [INFO] [stdout] 436 | lens.insert(name.to_string(), 0 as usize); [INFO] [stdout] | ^^^^^^^^^^ help: try: `0_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> rnmon/src/main.rs:462:54 [INFO] [stdout] | [INFO] [stdout] 462 | ... f32::from_str(e).expect(&format!( [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 463 | | ... "filename: {}, line: {:?}\n, e: {}, ", [INFO] [stdout] 464 | | ... &filename, line, e, [INFO] [stdout] 465 | | ... )) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 462 ~ f32::from_str(e).unwrap_or_else(|_| panic!("filename: {}, line: {:?}\n, e: {}, ", [INFO] [stdout] 463 + &filename, line, e)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> rnmon/src/main.rs:472:25 [INFO] [stdout] | [INFO] [stdout] 472 | *l = *l + 1; [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `*l += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> rnmon/src/main.rs:480:39 [INFO] [stdout] | [INFO] [stdout] 480 | let mut vec_len: Vec = lens.values().map(|l| *l).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `lens.values().copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> rnmon/src/main.rs:550:15 [INFO] [stdout] | [INFO] [stdout] 550 | zzzz: &Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 550 ~ zzzz: &[DateTime], [INFO] [stdout] 551 | // zzzz: Array1>, [INFO] [stdout] ... [INFO] [stdout] 564 | header, [INFO] [stdout] 565 ~ zzzz: zzzz.to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> rnmon/src/main.rs:556:75 [INFO] [stdout] | [INFO] [stdout] 556 | Array2::from_shape_vec((rowsize, colsize).set_f(false), data).expect(&format!( [INFO] [stdout] | ___________________________________________________________________________^ [INFO] [stdout] 557 | | "{}文件,{}指标从vec转化为Array2({}, {})失败", [INFO] [stdout] 558 | | &filename, name, rowsize, colsize [INFO] [stdout] 559 | | )); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 556 ~ Array2::from_shape_vec((rowsize, colsize).set_f(false), data).unwrap_or_else(|_| panic!("{}文件,{}指标从vec转化为Array2({}, {})失败", [INFO] [stdout] 557 ~ &filename, name, rowsize, colsize)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking async-ssh2-tokio v0.10.0 [INFO] [stderr] Checking rssh v0.1.2 (/opt/rustwide/workdir/rssh) [INFO] [stdout] warning: unused import: `arg` [INFO] [stdout] --> rssh/src/ssh.rs:8:32 [INFO] [stdout] | [INFO] [stdout] 8 | use clap::{Parser, Subcommand, arg}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `arg` [INFO] [stdout] --> rssh/src/main.rs:7:31 [INFO] [stdout] | [INFO] [stdout] 7 | use clap::{ArgAction, Parser, arg}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `arg` [INFO] [stdout] --> rssh/src/ssh.rs:8:32 [INFO] [stdout] | [INFO] [stdout] 8 | use clap::{Parser, Subcommand, arg}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `arg` [INFO] [stdout] --> rssh/src/main.rs:7:31 [INFO] [stdout] | [INFO] [stdout] 7 | use clap::{ArgAction, Parser, arg}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> rssh/src/ssh/server.rs:256:9 [INFO] [stdout] | [INFO] [stdout] 223 | / let auth_method = match &self.auth { [INFO] [stdout] 224 | | Auth::Password(pwd) => { [INFO] [stdout] 225 | | let auth_method = AuthMethod::Password(pwd.to_string()); [INFO] [stdout] 226 | | Some(auth_method) [INFO] [stdout] ... | [INFO] [stdout] 254 | | Auth::LocalSsh => None [INFO] [stdout] 255 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 256 | auth_method [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 223 ~ [INFO] [stdout] 224 ~ match &self.auth { [INFO] [stdout] 225 + Auth::Password(pwd) => { [INFO] [stdout] 226 + let auth_method = AuthMethod::Password(pwd.to_string()); [INFO] [stdout] 227 + Some(auth_method) [INFO] [stdout] 228 + }, [INFO] [stdout] 229 + Auth::PrivateKey { key_data, key_pass } => { [INFO] [stdout] 230 + let auth_method = AuthMethod::PrivateKey { [INFO] [stdout] 231 + key_data: key_data.to_string(), [INFO] [stdout] 232 + key_pass: key_pass.clone(), [INFO] [stdout] 233 + }; [INFO] [stdout] 234 + Some(auth_method) [INFO] [stdout] 235 + }, [INFO] [stdout] 236 + Auth::PrivateKeyFile { [INFO] [stdout] 237 + key_file_path, [INFO] [stdout] 238 + key_pass, [INFO] [stdout] 239 + } => { [INFO] [stdout] 240 + // ~/.ssh/id_ed25519 [INFO] [stdout] 241 + let private_key_file_path: PathBuf = [INFO] [stdout] 242 + [home.clone(), ".ssh".into(), "id_ed25519".into()] [INFO] [stdout] 243 + .iter() [INFO] [stdout] 244 + .collect(); [INFO] [stdout] 245 + let key_file_path = match key_file_path { [INFO] [stdout] 246 + None => private_key_file_path, [INFO] [stdout] 247 + Some(path) => path.to_path_buf(), [INFO] [stdout] 248 + }; [INFO] [stdout] 249 + let auth_method = AuthMethod::PrivateKeyFile { [INFO] [stdout] 250 + key_file_path, [INFO] [stdout] 251 + key_pass: key_pass.clone(), [INFO] [stdout] 252 + }; [INFO] [stdout] 253 + Some(auth_method) [INFO] [stdout] 254 + }, [INFO] [stdout] 255 + Auth::LocalSsh => None [INFO] [stdout] 256 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> rssh/src/ssh/server.rs:256:9 [INFO] [stdout] | [INFO] [stdout] 223 | / let auth_method = match &self.auth { [INFO] [stdout] 224 | | Auth::Password(pwd) => { [INFO] [stdout] 225 | | let auth_method = AuthMethod::Password(pwd.to_string()); [INFO] [stdout] 226 | | Some(auth_method) [INFO] [stdout] ... | [INFO] [stdout] 254 | | Auth::LocalSsh => None [INFO] [stdout] 255 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 256 | auth_method [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 223 ~ [INFO] [stdout] 224 ~ match &self.auth { [INFO] [stdout] 225 + Auth::Password(pwd) => { [INFO] [stdout] 226 + let auth_method = AuthMethod::Password(pwd.to_string()); [INFO] [stdout] 227 + Some(auth_method) [INFO] [stdout] 228 + }, [INFO] [stdout] 229 + Auth::PrivateKey { key_data, key_pass } => { [INFO] [stdout] 230 + let auth_method = AuthMethod::PrivateKey { [INFO] [stdout] 231 + key_data: key_data.to_string(), [INFO] [stdout] 232 + key_pass: key_pass.clone(), [INFO] [stdout] 233 + }; [INFO] [stdout] 234 + Some(auth_method) [INFO] [stdout] 235 + }, [INFO] [stdout] 236 + Auth::PrivateKeyFile { [INFO] [stdout] 237 + key_file_path, [INFO] [stdout] 238 + key_pass, [INFO] [stdout] 239 + } => { [INFO] [stdout] 240 + // ~/.ssh/id_ed25519 [INFO] [stdout] 241 + let private_key_file_path: PathBuf = [INFO] [stdout] 242 + [home.clone(), ".ssh".into(), "id_ed25519".into()] [INFO] [stdout] 243 + .iter() [INFO] [stdout] 244 + .collect(); [INFO] [stdout] 245 + let key_file_path = match key_file_path { [INFO] [stdout] 246 + None => private_key_file_path, [INFO] [stdout] 247 + Some(path) => path.to_path_buf(), [INFO] [stdout] 248 + }; [INFO] [stdout] 249 + let auth_method = AuthMethod::PrivateKeyFile { [INFO] [stdout] 250 + key_file_path, [INFO] [stdout] 251 + key_pass: key_pass.clone(), [INFO] [stdout] 252 + }; [INFO] [stdout] 253 + Some(auth_method) [INFO] [stdout] 254 + }, [INFO] [stdout] 255 + Auth::LocalSsh => None [INFO] [stdout] 256 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `LocalSsh` [INFO] [stdout] --> rssh/src/ssh.rs:257:5 [INFO] [stdout] | [INFO] [stdout] 257 | / pub fn new() -> Self { [INFO] [stdout] 258 | | LocalSsh {} [INFO] [stdout] 259 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 256 + impl Default for LocalSsh { [INFO] [stdout] 257 + fn default() -> Self { [INFO] [stdout] 258 + Self::new() [INFO] [stdout] 259 + } [INFO] [stdout] 260 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::path::PathBuf` [INFO] [stdout] --> rssh/src/main.rs:97:45 [INFO] [stdout] | [INFO] [stdout] 97 | let server = ssh::parse_server_json(PathBuf::from(config))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `LocalSsh` [INFO] [stdout] --> rssh/src/ssh.rs:257:5 [INFO] [stdout] | [INFO] [stdout] 257 | / pub fn new() -> Self { [INFO] [stdout] 258 | | LocalSsh {} [INFO] [stdout] 259 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 256 + impl Default for LocalSsh { [INFO] [stdout] 257 + fn default() -> Self { [INFO] [stdout] 258 + Self::new() [INFO] [stdout] 259 + } [INFO] [stdout] 260 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::path::PathBuf` [INFO] [stdout] --> rssh/src/main.rs:97:45 [INFO] [stdout] | [INFO] [stdout] 97 | let server = ssh::parse_server_json(PathBuf::from(config))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 26s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: num-bigint-dig v0.8.4 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 3` [INFO] running `Command { std: "docker" "inspect" "4e61440e07650339d4e8fb4a209ce90ed13e8515c15b0b25905ba450cf1d28cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4e61440e07650339d4e8fb4a209ce90ed13e8515c15b0b25905ba450cf1d28cd", kill_on_drop: false }` [INFO] [stdout] 4e61440e07650339d4e8fb4a209ce90ed13e8515c15b0b25905ba450cf1d28cd