[INFO] cloning repository https://github.com/liquid-07/mujick [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/liquid-07/mujick" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fliquid-07%2Fmujick", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fliquid-07%2Fmujick'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3b10446197603ad82198b39de815675b54165136 [INFO] linting liquid-07/mujick against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fliquid-07%2Fmujick" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/liquid-07/mujick [INFO] finished tweaking git repo https://github.com/liquid-07/mujick [INFO] tweaked toml for git repo https://github.com/liquid-07/mujick written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/liquid-07/mujick on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/liquid-07/mujick already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded lofty_attr v0.11.1 [INFO] [stderr] Downloaded owo-colors v4.2.1 [INFO] [stderr] Downloaded ogg_pager v0.7.0 [INFO] [stderr] Downloaded toml_edit v0.23.4 [INFO] [stderr] Downloaded rodio v0.21.1 [INFO] [stderr] Downloaded flexi_logger v0.31.7 [INFO] [stderr] Downloaded lofty v0.22.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ccca191fa1d39aea9b1bfc47d41deb91cde61e73ecdd3cdafecfe67f250905e6 [INFO] running `Command { std: "docker" "start" "-a" "ccca191fa1d39aea9b1bfc47d41deb91cde61e73ecdd3cdafecfe67f250905e6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ccca191fa1d39aea9b1bfc47d41deb91cde61e73ecdd3cdafecfe67f250905e6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ccca191fa1d39aea9b1bfc47d41deb91cde61e73ecdd3cdafecfe67f250905e6", kill_on_drop: false }` [INFO] [stdout] ccca191fa1d39aea9b1bfc47d41deb91cde61e73ecdd3cdafecfe67f250905e6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 77f52bd0c64d3f6ce91905d846fb69ba2fca5a8fcb56aad9e45783181a6440e5 [INFO] running `Command { std: "docker" "start" "-a" "77f52bd0c64d3f6ce91905d846fb69ba2fca5a8fcb56aad9e45783181a6440e5", kill_on_drop: false }` [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling zerofrom v0.1.6 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Compiling thiserror-impl v2.0.16 [INFO] [stderr] Compiling serde_json v1.0.143 [INFO] [stderr] Compiling cc v1.2.34 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling lock_api v0.4.13 [INFO] [stderr] Checking potential_utf v0.1.2 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Compiling foldhash v0.1.5 [INFO] [stderr] Checking hashbrown v0.15.4 [INFO] [stderr] Compiling form_urlencoded v1.2.2 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Compiling yoke v0.8.0 [INFO] [stderr] Checking symphonia-core v0.5.5 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Compiling socket2 v0.6.0 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Compiling futures-util v0.3.31 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Compiling zerovec v0.11.4 [INFO] [stderr] Compiling zerotrie v0.2.2 [INFO] [stderr] Compiling tokio v1.47.1 [INFO] [stderr] Compiling tracing v0.1.41 [INFO] [stderr] Compiling crc v3.3.0 [INFO] [stderr] Compiling concurrent-queue v2.5.0 [INFO] [stderr] Compiling hashlink v0.10.0 [INFO] [stderr] Compiling indexmap v2.11.0 [INFO] [stderr] Compiling crossbeam-queue v0.3.12 [INFO] [stderr] Compiling futures-intrusive v0.5.0 [INFO] [stderr] Compiling spin v0.9.8 [INFO] [stderr] Compiling event-listener v5.4.1 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Compiling base64 v0.22.1 [INFO] [stderr] Checking symphonia-metadata v0.5.5 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Compiling flume v0.11.1 [INFO] [stderr] Compiling tinystr v0.8.1 [INFO] [stderr] Checking symphonia-utils-xiph v0.5.5 [INFO] [stderr] Compiling atoi v2.0.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking signal-hook v0.3.18 [INFO] [stderr] Compiling icu_locale_core v2.0.0 [INFO] [stderr] Compiling object v0.36.7 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Compiling owo-colors v4.2.1 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking tracing-subscriber v0.3.19 [INFO] [stderr] Compiling libsqlite3-sys v0.30.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling color-spantrace v0.3.0 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Checking gimli v0.31.1 [INFO] [stderr] Compiling thiserror v2.0.16 [INFO] [stderr] Compiling rustix v1.0.8 [INFO] [stderr] Checking extended v0.1.0 [INFO] [stderr] Compiling icu_provider v2.0.0 [INFO] [stderr] Compiling cpal v0.16.0 [INFO] [stderr] Checking symphonia-format-riff v0.5.5 [INFO] [stderr] Compiling futures-executor v0.3.31 [INFO] [stderr] Checking tracing-error v0.2.1 [INFO] [stderr] Checking rustix v0.38.44 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking alsa v0.9.1 [INFO] [stderr] Compiling derive_more-impl v2.0.1 [INFO] [stderr] Checking crc32fast v1.5.0 [INFO] [stderr] Checking symphonia-codec-vorbis v0.5.5 [INFO] [stderr] Checking symphonia-format-isomp4 v0.5.5 [INFO] [stderr] Checking symphonia-format-ogg v0.5.5 [INFO] [stderr] Checking symphonia-bundle-flac v0.5.5 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Checking symphonia-bundle-mp3 v0.5.5 [INFO] [stderr] Checking symphonia-codec-pcm v0.5.5 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking symphonia-codec-aac v0.5.5 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking castaway v0.2.3 [INFO] [stderr] Checking addr2line v0.24.2 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking dasp_sample v0.11.0 [INFO] [stderr] Compiling indoc v2.0.6 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking rustc-demangle v0.1.25 [INFO] [stderr] Checking anstream v0.6.20 [INFO] [stderr] Checking compact_str v0.8.1 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking ogg_pager v0.7.0 [INFO] [stderr] Checking symphonia v0.5.5 [INFO] [stderr] Checking derive_more v2.0.1 [INFO] [stderr] Compiling instability v0.3.7 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking flate2 v1.1.2 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Checking lru v0.12.5 [INFO] [stderr] Compiling lofty_attr v0.11.1 [INFO] [stderr] Checking jiff v0.2.15 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking rodio v0.21.1 [INFO] [stderr] Checking lofty v0.22.4 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Compiling tokio-stream v0.1.17 [INFO] [stderr] Checking flexi_logger v0.31.7 [INFO] [stderr] Checking backtrace v0.3.75 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Compiling url v2.5.7 [INFO] [stderr] Compiling serde_urlencoded v0.7.1 [INFO] [stderr] Checking color-eyre v0.6.5 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking sqlx-core v0.8.6 [INFO] [stderr] Checking unicode-truncate v1.1.0 [INFO] [stderr] Checking ratatui v0.29.0 [INFO] [stderr] Checking sqlx-sqlite v0.8.6 [INFO] [stderr] Compiling sqlx-macros-core v0.8.6 [INFO] [stderr] Compiling sqlx-macros v0.8.6 [INFO] [stderr] Checking sqlx v0.8.6 [INFO] [stderr] Checking Mujick v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Duplicate` [INFO] [stdout] --> src/main.rs:1:20 [INFO] [stdout] | [INFO] [stdout] 1 | use flexi_logger::{Duplicate, FileSpec}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Decoder`, `OutputStreamBuilder`, `OutputStream`, `Sink`, and `Source` [INFO] [stdout] --> src/main.rs:2:13 [INFO] [stdout] | [INFO] [stdout] 2 | use rodio::{Decoder, OutputStream, OutputStreamBuilder, Sink, Source}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ ^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::BufReader` [INFO] [stdout] --> src/main.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::BufReader; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Arc` and `Mutex` [INFO] [stdout] --> src/main.rs:5:17 [INFO] [stdout] | [INFO] [stdout] 5 | use std::sync::{Arc, Mutex}; [INFO] [stdout] | ^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::thread` [INFO] [stdout] --> src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::thread; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time::Duration` [INFO] [stdout] --> src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::time::Duration; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::database::repository` [INFO] [stdout] --> src/audio/audio_service.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::database::repository; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::hash::Hash` [INFO] [stdout] --> src/audio/audio_service.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::hash::Hash; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Duplicate` [INFO] [stdout] --> src/main.rs:1:20 [INFO] [stdout] | [INFO] [stdout] 1 | use flexi_logger::{Duplicate, FileSpec}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Decoder`, `OutputStreamBuilder`, `OutputStream`, `Sink`, and `Source` [INFO] [stdout] --> src/main.rs:2:13 [INFO] [stdout] | [INFO] [stdout] 2 | use rodio::{Decoder, OutputStream, OutputStreamBuilder, Sink, Source}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ ^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::BufReader` [INFO] [stdout] --> src/main.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::BufReader; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Arc` and `Mutex` [INFO] [stdout] --> src/main.rs:5:17 [INFO] [stdout] | [INFO] [stdout] 5 | use std::sync::{Arc, Mutex}; [INFO] [stdout] | ^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::thread` [INFO] [stdout] --> src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::thread; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time::Duration` [INFO] [stdout] --> src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::time::Duration; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::database::repository` [INFO] [stdout] --> src/audio/audio_service.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::database::repository; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::hash::Hash` [INFO] [stdout] --> src/audio/audio_service.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::hash::Hash; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: glob import doesn't reexport anything with visibility `pub` because no imported item is public enough [INFO] [stdout] --> src/audio/mod.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub use mujick_data_initializer::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the most public imported item is `pub(crate)` [INFO] [stdout] --> src/audio/mod.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub use mujick_data_initializer::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: reduce the glob import's visibility or increase visibility of imported items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/database/repository.rs:1:20 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::audio::{self, AudioDetails, AudioType}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Path` [INFO] [stdout] --> src/database/repository.rs:5:17 [INFO] [stdout] | [INFO] [stdout] 5 | use std::path::{Path, PathBuf}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `KeyModifiers` [INFO] [stdout] --> src/gui/control.rs:1:57 [INFO] [stdout] | [INFO] [stdout] 1 | use crossterm::event::{KeyCode, KeyEvent, KeyEventKind, KeyModifiers}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: glob import doesn't reexport anything with visibility `pub` because no imported item is public enough [INFO] [stdout] --> src/audio/mod.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub use mujick_data_initializer::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the most public imported item is `pub(crate)` [INFO] [stdout] --> src/audio/mod.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub use mujick_data_initializer::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: reduce the glob import's visibility or increase visibility of imported items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Alignment` [INFO] [stdout] --> src/gui/gui.rs:10:14 [INFO] [stdout] | [INFO] [stdout] 10 | layout::{Alignment, Constraint, Direction, Layout, Rect}, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/database/repository.rs:1:20 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::audio::{self, AudioDetails, AudioType}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Path` [INFO] [stdout] --> src/database/repository.rs:5:17 [INFO] [stdout] | [INFO] [stdout] 5 | use std::path::{Path, PathBuf}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `KeyModifiers` [INFO] [stdout] --> src/gui/control.rs:1:57 [INFO] [stdout] | [INFO] [stdout] 1 | use crossterm::event::{KeyCode, KeyEvent, KeyEventKind, KeyModifiers}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::gui::control::handel_controls` [INFO] [stdout] --> src/gui/gui.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | use crate::gui::control::handel_controls; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Alignment` [INFO] [stdout] --> src/gui/gui.rs:10:14 [INFO] [stdout] | [INFO] [stdout] 10 | layout::{Alignment, Constraint, Direction, Layout, Rect}, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::gui::control::handel_controls` [INFO] [stdout] --> src/gui/gui.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | use crate::gui::control::handel_controls; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Widget` [INFO] [stdout] --> src/gui/song_area.rs:6:46 [INFO] [stdout] | [INFO] [stdout] 6 | use ratatui::widgets::{Block, Borders, Tabs, Widget}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `IntoEnumIterator` [INFO] [stdout] --> src/gui/song_tab.rs:15:42 [INFO] [stdout] | [INFO] [stdout] 15 | use strum::{Display, EnumIter, FromRepr, IntoEnumIterator}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `log::log` [INFO] [stdout] --> src/gui/song_view.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use log::log; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Paragraph` [INFO] [stdout] --> src/gui/song_view.rs:7:67 [INFO] [stdout] | [INFO] [stdout] 7 | use ratatui::widgets::{Block, Borders, List, ListItem, ListState, Paragraph, StatefulWidget}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Widget` [INFO] [stdout] --> src/gui/song_area.rs:6:46 [INFO] [stdout] | [INFO] [stdout] 6 | use ratatui::widgets::{Block, Borders, Tabs, Widget}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Deserialize` and `Serialize` [INFO] [stdout] --> src/gui/song_view.rs:8:13 [INFO] [stdout] | [INFO] [stdout] 8 | use serde::{Deserialize, Serialize}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::database::repository` [INFO] [stdout] --> src/main.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use crate::database::repository; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `IntoEnumIterator` [INFO] [stdout] --> src/gui/song_tab.rs:15:42 [INFO] [stdout] | [INFO] [stdout] 15 | use strum::{Display, EnumIter, FromRepr, IntoEnumIterator}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `log::log` [INFO] [stdout] --> src/gui/song_view.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use log::log; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Paragraph` [INFO] [stdout] --> src/gui/song_view.rs:7:67 [INFO] [stdout] | [INFO] [stdout] 7 | use ratatui::widgets::{Block, Borders, List, ListItem, ListState, Paragraph, StatefulWidget}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Deserialize` and `Serialize` [INFO] [stdout] --> src/gui/song_view.rs:8:13 [INFO] [stdout] | [INFO] [stdout] 8 | use serde::{Deserialize, Serialize}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::database::repository` [INFO] [stdout] --> src/main.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use crate::database::repository; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `audio_details_list` [INFO] [stdout] --> src/audio/mujick_data_initializer.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | let audio_details_list = repository::get_all_audios().await.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_audio_details_list` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `audio_details_list` [INFO] [stdout] --> src/audio/mujick_data_initializer.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | let audio_details_list = repository::get_all_audios().await.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_audio_details_list` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `paragraph` [INFO] [stdout] --> src/gui/gui.rs:219:9 [INFO] [stdout] | [INFO] [stdout] 219 | let paragraph = Paragraph::new(content) [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_paragraph` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `paragraph_songlist` [INFO] [stdout] --> src/gui/gui.rs:223:9 [INFO] [stdout] | [INFO] [stdout] 223 | let paragraph_songlist = Paragraph::new("soemthing agas") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_paragraph_songlist` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `app` [INFO] [stdout] --> src/gui/play_area.rs:47:57 [INFO] [stdout] | [INFO] [stdout] 47 | fn render_control_area(f: &mut Frame<'_>, layout: Rect, app: &AppState) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_app` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `app` [INFO] [stdout] --> src/gui/play_area.rs:70:56 [INFO] [stdout] | [INFO] [stdout] 70 | fn render_audio_description(f: &mut Frame, area: Rect, app: &AppState) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_app` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `app` [INFO] [stdout] --> src/gui/play_area.rs:118:50 [INFO] [stdout] | [INFO] [stdout] 118 | fn render_progressbar(f: &mut Frame, area: Rect, app: &AppState) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_app` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `paragraph` [INFO] [stdout] --> src/gui/gui.rs:219:9 [INFO] [stdout] | [INFO] [stdout] 219 | let paragraph = Paragraph::new(content) [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_paragraph` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `paragraph_songlist` [INFO] [stdout] --> src/gui/gui.rs:223:9 [INFO] [stdout] | [INFO] [stdout] 223 | let paragraph_songlist = Paragraph::new("soemthing agas") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_paragraph_songlist` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `app` [INFO] [stdout] --> src/gui/play_area.rs:47:57 [INFO] [stdout] | [INFO] [stdout] 47 | fn render_control_area(f: &mut Frame<'_>, layout: Rect, app: &AppState) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_app` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/gui/song_area.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | for i in 1..100 { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/gui/song_area.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | for i in 1..100 {} [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `app` [INFO] [stdout] --> src/gui/play_area.rs:70:56 [INFO] [stdout] | [INFO] [stdout] 70 | fn render_audio_description(f: &mut Frame, area: Rect, app: &AppState) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_app` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `app` [INFO] [stdout] --> src/gui/play_area.rs:118:50 [INFO] [stdout] | [INFO] [stdout] 118 | fn render_progressbar(f: &mut Frame, area: Rect, app: &AppState) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_app` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `app_state` [INFO] [stdout] --> src/gui/song_tab.rs:73:60 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn render_tab1(self, area: Rect, buf: &mut Buffer, app_state: &mut AppState) { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_app_state` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/gui/song_area.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | for i in 1..100 { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/gui/song_area.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | for i in 1..100 {} [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `app_state` [INFO] [stdout] --> src/gui/song_tab.rs:73:60 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn render_tab1(self, area: Rect, buf: &mut Buffer, app_state: &mut AppState) { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_app_state` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `init` is never used [INFO] [stdout] --> src/audio/audio_service.rs:14:15 [INFO] [stdout] | [INFO] [stdout] 14 | pub(crate) fn init() {} [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `search_audios_ref` is never used [INFO] [stdout] --> src/audio/audio_service.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn search_audios_ref<'a>( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `filter_by_criteria` is never used [INFO] [stdout] --> src/audio/audio_service.rs:33:8 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn filter_by_criteria(category: &CRITERIA, audio_details: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `filter_by_criteria_value` is never used [INFO] [stdout] --> src/audio/audio_service.rs:56:8 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn filter_by_criteria_value( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `refresh` is never used [INFO] [stdout] --> src/audio/audio_service.rs:83:14 [INFO] [stdout] | [INFO] [stdout] 83 | pub async fn refresh(audio_path_list: Vec<&PathBuf>) -> Result, AudioError> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `refresh_audio` is never used [INFO] [stdout] --> src/audio/mujick_data_initializer.rs:37:21 [INFO] [stdout] | [INFO] [stdout] 37 | pub(crate) async fn refresh_audio( [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `total_number_of_cpu` is never used [INFO] [stdout] --> src/audio/scanner.rs:89:4 [INFO] [stdout] | [INFO] [stdout] 89 | fn total_number_of_cpu() -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_path_of_audios` is never used [INFO] [stdout] --> src/database/repository.rs:61:10 [INFO] [stdout] | [INFO] [stdout] 61 | async fn get_path_of_audios() -> Result, Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `is_playing` is never read [INFO] [stdout] --> src/gui/gui.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 42 | pub struct AppState { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 43 | pub should_exit: bool, [INFO] [stdout] 44 | pub is_playing: bool, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `handle_key` is never used [INFO] [stdout] --> src/gui/gui.rs:94:4 [INFO] [stdout] | [INFO] [stdout] 94 | fn handle_key(key: KeyEvent, app_state: &mut AppState) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `COMPLETED` is never used [INFO] [stdout] --> src/gui/play_area.rs:13:7 [INFO] [stdout] | [INFO] [stdout] 13 | const COMPLETED: Color = tailwind::BLUE.c800; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `block` is never used [INFO] [stdout] --> src/gui/song_tab.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 39 | impl SelectedTab { [INFO] [stdout] | ---------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 81 | pub fn block(self) -> Block<'static> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (12/7) [INFO] [stdout] --> src/audio/audio_file.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | / pub fn new( [INFO] [stdout] 23 | | path: PathBuf, [INFO] [stdout] 24 | | audio_type: AudioType, [INFO] [stdout] 25 | | title: String, [INFO] [stdout] ... | [INFO] [stdout] 34 | | year: u32, [INFO] [stdout] 35 | | ) -> Self { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `init` is never used [INFO] [stdout] --> src/audio/audio_service.rs:14:15 [INFO] [stdout] | [INFO] [stdout] 14 | pub(crate) fn init() {} [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `search_audios_ref` is never used [INFO] [stdout] --> src/audio/audio_service.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn search_audios_ref<'a>( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `filter_by_criteria` is never used [INFO] [stdout] --> src/audio/audio_service.rs:33:8 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn filter_by_criteria(category: &CRITERIA, audio_details: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `filter_by_criteria_value` is never used [INFO] [stdout] --> src/audio/audio_service.rs:56:8 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn filter_by_criteria_value( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `refresh` is never used [INFO] [stdout] --> src/audio/audio_service.rs:83:14 [INFO] [stdout] | [INFO] [stdout] 83 | pub async fn refresh(audio_path_list: Vec<&PathBuf>) -> Result, AudioError> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `refresh_audio` is never used [INFO] [stdout] --> src/audio/mujick_data_initializer.rs:37:21 [INFO] [stdout] | [INFO] [stdout] 37 | pub(crate) async fn refresh_audio( [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `total_number_of_cpu` is never used [INFO] [stdout] --> src/audio/scanner.rs:89:4 [INFO] [stdout] | [INFO] [stdout] 89 | fn total_number_of_cpu() -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_path_of_audios` is never used [INFO] [stdout] --> src/database/repository.rs:61:10 [INFO] [stdout] | [INFO] [stdout] 61 | async fn get_path_of_audios() -> Result, Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `is_playing` is never read [INFO] [stdout] --> src/gui/gui.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 42 | pub struct AppState { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 43 | pub should_exit: bool, [INFO] [stdout] 44 | pub is_playing: bool, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `handle_key` is never used [INFO] [stdout] --> src/gui/gui.rs:94:4 [INFO] [stdout] | [INFO] [stdout] 94 | fn handle_key(key: KeyEvent, app_state: &mut AppState) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `COMPLETED` is never used [INFO] [stdout] --> src/gui/play_area.rs:13:7 [INFO] [stdout] | [INFO] [stdout] 13 | const COMPLETED: Color = tailwind::BLUE.c800; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `block` is never used [INFO] [stdout] --> src/gui/song_tab.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 39 | impl SelectedTab { [INFO] [stdout] | ---------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 81 | pub fn block(self) -> Block<'static> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (12/7) [INFO] [stdout] --> src/audio/audio_file.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | / pub fn new( [INFO] [stdout] 23 | | path: PathBuf, [INFO] [stdout] 24 | | audio_type: AudioType, [INFO] [stdout] 25 | | title: String, [INFO] [stdout] ... | [INFO] [stdout] 34 | | year: u32, [INFO] [stdout] 35 | | ) -> Self { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/audio/audio_service.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 17 | audio_name: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 17 - audio_name: &String, [INFO] [stdout] 17 + audio_name: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/audio/audio_service.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 17 | audio_name: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 17 - audio_name: &String, [INFO] [stdout] 17 + audio_name: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/audio/audio_service.rs:45:14 [INFO] [stdout] | [INFO] [stdout] 45 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/audio/audio_service.rs:45:14 [INFO] [stdout] | [INFO] [stdout] 45 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-binding `let` on a future [INFO] [stdout] --> src/audio/audio_service.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | let _ = insert_audio_details(&details); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider awaiting the future or dropping explicitly with `std::mem::drop` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future [INFO] [stdout] = note: `#[warn(clippy::let_underscore_future)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-binding `let` on a future [INFO] [stdout] --> src/audio/audio_service.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | let _ = insert_audio_details(&details); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider awaiting the future or dropping explicitly with `std::mem::drop` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future [INFO] [stdout] = note: `#[warn(clippy::let_underscore_future)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/audio/scanner.rs:20:17 [INFO] [stdout] | [INFO] [stdout] 20 | .filter(|e| is_music_file(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `is_music_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/audio/scanner.rs:36:37 [INFO] [stdout] | [INFO] [stdout] 36 | let probe = Probe::open(&audio_file); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `audio_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/audio/scanner.rs:73:48 [INFO] [stdout] | [INFO] [stdout] 73 | properties.bit_depth().map(|v| v as u8), [INFO] [stdout] | ^^^^^^^ help: try: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/audio/scanner.rs:20:17 [INFO] [stdout] | [INFO] [stdout] 20 | .filter(|e| is_music_file(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `is_music_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/audio/scanner.rs:36:37 [INFO] [stdout] | [INFO] [stdout] 36 | let probe = Probe::open(&audio_file); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `audio_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/audio/scanner.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | / match AudioType::from_path(&path) { [INFO] [stdout] 103 | | AudioType::Unknown => false, [INFO] [stdout] 104 | | _ => true, [INFO] [stdout] 105 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 102 - match AudioType::from_path(&path) { [INFO] [stdout] 103 - AudioType::Unknown => false, [INFO] [stdout] 104 - _ => true, [INFO] [stdout] 105 - } [INFO] [stdout] 102 + !matches!(AudioType::from_path(&path), AudioType::Unknown) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/audio/scanner.rs:73:48 [INFO] [stdout] | [INFO] [stdout] 73 | properties.bit_depth().map(|v| v as u8), [INFO] [stdout] | ^^^^^^^ help: try: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/database/repository.rs:47:15 [INFO] [stdout] | [INFO] [stdout] 47 | .bind(&metadata.path.to_str().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `metadata.path.to_str().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/database/repository.rs:48:15 [INFO] [stdout] | [INFO] [stdout] 48 | .bind(&metadata.audio_type.as_str()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `metadata.audio_type.as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/audio/scanner.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | / match AudioType::from_path(&path) { [INFO] [stdout] 103 | | AudioType::Unknown => false, [INFO] [stdout] 104 | | _ => true, [INFO] [stdout] 105 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 102 - match AudioType::from_path(&path) { [INFO] [stdout] 103 - AudioType::Unknown => false, [INFO] [stdout] 104 - _ => true, [INFO] [stdout] 105 - } [INFO] [stdout] 102 + !matches!(AudioType::from_path(&path), AudioType::Unknown) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/database/repository.rs:47:15 [INFO] [stdout] | [INFO] [stdout] 47 | .bind(&metadata.path.to_str().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `metadata.path.to_str().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/database/repository.rs:48:15 [INFO] [stdout] | [INFO] [stdout] 48 | .bind(&metadata.audio_type.as_str()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `metadata.audio_type.as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/gui/control.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | if app_state.show_popup == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `app_state.show_popup` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/gui/control.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | / if app_state.music_filter_type_index > 0 { [INFO] [stdout] 52 | | app_state.music_filter_type_index = app_state.music_filter_type_index - 1; [INFO] [stdout] 53 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 50 ~ KeyCode::Up [INFO] [stdout] 51 ~ if app_state.music_filter_type_index > 0 => { [INFO] [stdout] 52 | app_state.music_filter_type_index = app_state.music_filter_type_index - 1; [INFO] [stdout] 53 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/gui/control.rs:39:21 [INFO] [stdout] | [INFO] [stdout] 39 | app_state.music_filter_type_index = app_state.music_filter_type_index + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `app_state.music_filter_type_index += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/gui/control.rs:46:21 [INFO] [stdout] | [INFO] [stdout] 46 | app_state.selected_music_index = app_state.selected_music_index + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `app_state.selected_music_index += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/gui/control.rs:52:17 [INFO] [stdout] | [INFO] [stdout] 52 | app_state.music_filter_type_index = app_state.music_filter_type_index - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `app_state.music_filter_type_index -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/gui/control.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | if app_state.show_popup == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `app_state.show_popup` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/gui/control.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | / if app_state.music_filter_type_index > 0 { [INFO] [stdout] 52 | | app_state.music_filter_type_index = app_state.music_filter_type_index - 1; [INFO] [stdout] 53 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 50 ~ KeyCode::Up [INFO] [stdout] 51 ~ if app_state.music_filter_type_index > 0 => { [INFO] [stdout] 52 | app_state.music_filter_type_index = app_state.music_filter_type_index - 1; [INFO] [stdout] 53 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/gui/control.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | / if app_state.search_cursor > 0 { [INFO] [stdout] 82 | | app_state.search_cursor -= 1; [INFO] [stdout] 83 | | app_state.search_input.remove(app_state.search_cursor); [INFO] [stdout] 84 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 80 ~ KeyCode::Backspace [INFO] [stdout] 81 ~ if app_state.search_cursor > 0 => { [INFO] [stdout] 82 | app_state.search_cursor -= 1; [INFO] [stdout] 83 | app_state.search_input.remove(app_state.search_cursor); [INFO] [stdout] 84 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/gui/control.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 87 | / if app_state.search_cursor > 0 { [INFO] [stdout] 88 | | app_state.search_cursor -= 1; [INFO] [stdout] 89 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 86 ~ KeyCode::Left [INFO] [stdout] 87 ~ if app_state.search_cursor > 0 => { [INFO] [stdout] 88 | app_state.search_cursor -= 1; [INFO] [stdout] 89 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/gui/control.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 92 | / if app_state.search_cursor < app_state.search_input.len() { [INFO] [stdout] 93 | | app_state.search_cursor += 1; [INFO] [stdout] 94 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 91 ~ KeyCode::Right [INFO] [stdout] 92 ~ if app_state.search_cursor < app_state.search_input.len() => { [INFO] [stdout] 93 | app_state.search_cursor += 1; [INFO] [stdout] 94 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/gui/control.rs:39:21 [INFO] [stdout] | [INFO] [stdout] 39 | app_state.music_filter_type_index = app_state.music_filter_type_index + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `app_state.music_filter_type_index += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CRITERIA` contains a capitalized acronym [INFO] [stdout] --> src/gui/criteria.rs:3:10 [INFO] [stdout] | [INFO] [stdout] 3 | pub enum CRITERIA { [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Criteria` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/gui/control.rs:46:21 [INFO] [stdout] | [INFO] [stdout] 46 | app_state.selected_music_index = app_state.selected_music_index + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `app_state.selected_music_index += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ALL` contains a capitalized acronym [INFO] [stdout] --> src/gui/criteria.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | ALL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `All` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/gui/control.rs:52:17 [INFO] [stdout] | [INFO] [stdout] 52 | app_state.music_filter_type_index = app_state.music_filter_type_index - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `app_state.music_filter_type_index -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PLAYLIST` contains a capitalized acronym [INFO] [stdout] --> src/gui/criteria.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | PLAYLIST(Option), [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Playlist` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `GENRE` contains a capitalized acronym [INFO] [stdout] --> src/gui/criteria.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | GENRE(Option), [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Genre` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ARTIST` contains a capitalized acronym [INFO] [stdout] --> src/gui/criteria.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | ARTIST(Option), [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Artist` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `YEAR` contains a capitalized acronym [INFO] [stdout] --> src/gui/criteria.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | YEAR(Option), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Year` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/gui/control.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | / if app_state.search_cursor > 0 { [INFO] [stdout] 82 | | app_state.search_cursor -= 1; [INFO] [stdout] 83 | | app_state.search_input.remove(app_state.search_cursor); [INFO] [stdout] 84 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 80 ~ KeyCode::Backspace [INFO] [stdout] 81 ~ if app_state.search_cursor > 0 => { [INFO] [stdout] 82 | app_state.search_cursor -= 1; [INFO] [stdout] 83 | app_state.search_input.remove(app_state.search_cursor); [INFO] [stdout] 84 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/gui/control.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 87 | / if app_state.search_cursor > 0 { [INFO] [stdout] 88 | | app_state.search_cursor -= 1; [INFO] [stdout] 89 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 86 ~ KeyCode::Left [INFO] [stdout] 87 ~ if app_state.search_cursor > 0 => { [INFO] [stdout] 88 | app_state.search_cursor -= 1; [INFO] [stdout] 89 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/gui/control.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 92 | / if app_state.search_cursor < app_state.search_input.len() { [INFO] [stdout] 93 | | app_state.search_cursor += 1; [INFO] [stdout] 94 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 91 ~ KeyCode::Right [INFO] [stdout] 92 ~ if app_state.search_cursor < app_state.search_input.len() => { [INFO] [stdout] 93 | app_state.search_cursor += 1; [INFO] [stdout] 94 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `UNKNOWN` contains a capitalized acronym [INFO] [stdout] --> src/gui/criteria.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | UNKNOWN, [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Unknown` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/gui/mod.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | mod gui; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CRITERIA` contains a capitalized acronym [INFO] [stdout] --> src/gui/criteria.rs:3:10 [INFO] [stdout] | [INFO] [stdout] 3 | pub enum CRITERIA { [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Criteria` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ALL` contains a capitalized acronym [INFO] [stdout] --> src/gui/criteria.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | ALL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `All` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PLAYLIST` contains a capitalized acronym [INFO] [stdout] --> src/gui/criteria.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | PLAYLIST(Option), [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Playlist` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `GENRE` contains a capitalized acronym [INFO] [stdout] --> src/gui/criteria.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | GENRE(Option), [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Genre` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ARTIST` contains a capitalized acronym [INFO] [stdout] --> src/gui/criteria.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | ARTIST(Option), [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Artist` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `YEAR` contains a capitalized acronym [INFO] [stdout] --> src/gui/criteria.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | YEAR(Option), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Year` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `UNKNOWN` contains a capitalized acronym [INFO] [stdout] --> src/gui/criteria.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | UNKNOWN, [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Unknown` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/gui/gui.rs:109:13 [INFO] [stdout] | [INFO] [stdout] 109 | / if app_state.music_filter_type_index > 0 { [INFO] [stdout] 110 | | app_state.music_filter_type_index = app_state.music_filter_type_index - 1; [INFO] [stdout] 111 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 108 ~ KeyCode::Up [INFO] [stdout] 109 ~ if app_state.music_filter_type_index > 0 => { [INFO] [stdout] 110 | app_state.music_filter_type_index = app_state.music_filter_type_index - 1; [INFO] [stdout] 111 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/gui/gui.rs:105:17 [INFO] [stdout] | [INFO] [stdout] 105 | app_state.music_filter_type_index = app_state.music_filter_type_index + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `app_state.music_filter_type_index += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/gui/gui.rs:110:17 [INFO] [stdout] | [INFO] [stdout] 110 | app_state.music_filter_type_index = app_state.music_filter_type_index - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `app_state.music_filter_type_index -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/gui/mod.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | mod gui; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/gui/gui.rs:125:8 [INFO] [stdout] | [INFO] [stdout] 125 | if app.show_popup == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `app.show_popup` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui/gui.rs:129:41 [INFO] [stdout] | [INFO] [stdout] 129 | render_left(frame, inner_layout[0], &app); [INFO] [stdout] | ^^^^ help: change this to: `app` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/gui/gui.rs:134:8 [INFO] [stdout] | [INFO] [stdout] 134 | if app.show_popup == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!app.show_popup` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/gui/gui.rs:109:13 [INFO] [stdout] | [INFO] [stdout] 109 | / if app_state.music_filter_type_index > 0 { [INFO] [stdout] 110 | | app_state.music_filter_type_index = app_state.music_filter_type_index - 1; [INFO] [stdout] 111 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 108 ~ KeyCode::Up [INFO] [stdout] 109 ~ if app_state.music_filter_type_index > 0 => { [INFO] [stdout] 110 | app_state.music_filter_type_index = app_state.music_filter_type_index - 1; [INFO] [stdout] 111 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/gui/gui.rs:105:17 [INFO] [stdout] | [INFO] [stdout] 105 | app_state.music_filter_type_index = app_state.music_filter_type_index + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `app_state.music_filter_type_index += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/gui/gui.rs:110:17 [INFO] [stdout] | [INFO] [stdout] 110 | app_state.music_filter_type_index = app_state.music_filter_type_index - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `app_state.music_filter_type_index -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/gui/gui.rs:125:8 [INFO] [stdout] | [INFO] [stdout] 125 | if app.show_popup == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `app.show_popup` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui/gui.rs:129:41 [INFO] [stdout] | [INFO] [stdout] 129 | render_left(frame, inner_layout[0], &app); [INFO] [stdout] | ^^^^ help: change this to: `app` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/gui/gui.rs:134:8 [INFO] [stdout] | [INFO] [stdout] 134 | if app.show_popup == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!app.show_popup` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/gui/play_area.rs:113:17 [INFO] [stdout] | [INFO] [stdout] 113 | .widths(&[Constraint::Length(15), Constraint::Length(30)]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[Constraint::Length(15), Constraint::Length(30)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/gui/play_area.rs:113:17 [INFO] [stdout] | [INFO] [stdout] 113 | .widths(&[Constraint::Length(15), Constraint::Length(30)]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[Constraint::Length(15), Constraint::Length(30)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> src/gui/song_tab.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | / match self { [INFO] [stdout] 90 | | // Self::Tab1 => tailwind::BLUE, [INFO] [stdout] 91 | | // Self::Tab2 => tailwind::EMERALD, [INFO] [stdout] 92 | | _ => tailwind::BLUE, [INFO] [stdout] 93 | | } [INFO] [stdout] | |_________^ help: consider using the match body instead: `tailwind::BLUE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> src/gui/song_tab.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | / match self { [INFO] [stdout] 90 | | // Self::Tab1 => tailwind::BLUE, [INFO] [stdout] 91 | | // Self::Tab2 => tailwind::EMERALD, [INFO] [stdout] 92 | | _ => tailwind::BLUE, [INFO] [stdout] 93 | | } [INFO] [stdout] | |_________^ help: consider using the match body instead: `tailwind::BLUE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `available_width [INFO] [stdout] .saturating_sub(song.title.len() + duration_width + 6)` is never smaller than `0` and has therefore no effect [INFO] [stdout] --> src/gui/song_view.rs:58:31 [INFO] [stdout] | [INFO] [stdout] 58 | let spacing = available_width [INFO] [stdout] | _______________________________^ [INFO] [stdout] 59 | | .saturating_sub(song.title.len() + duration_width + 6) [INFO] [stdout] 60 | | .max(0); [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_min_or_max [INFO] [stdout] = note: `#[warn(clippy::unnecessary_min_or_max)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 58 ~ let spacing = available_width [INFO] [stdout] 59 ~ .saturating_sub(song.title.len() + duration_width + 6); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `available_width [INFO] [stdout] .saturating_sub(song.title.len() + duration_width + 6)` is never smaller than `0` and has therefore no effect [INFO] [stdout] --> src/gui/song_view.rs:58:31 [INFO] [stdout] | [INFO] [stdout] 58 | let spacing = available_width [INFO] [stdout] | _______________________________^ [INFO] [stdout] 59 | | .saturating_sub(song.title.len() + duration_width + 6) [INFO] [stdout] 60 | | .max(0); [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_min_or_max [INFO] [stdout] = note: `#[warn(clippy::unnecessary_min_or_max)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 58 ~ let spacing = available_width [INFO] [stdout] 59 ~ .saturating_sub(song.title.len() + duration_width + 6); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:51:29 [INFO] [stdout] | [INFO] [stdout] 51 | let _sink = rodio::play(&stream_handle.mixer(), file).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `stream_handle.mixer()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:51:29 [INFO] [stdout] | [INFO] [stdout] 51 | let _sink = rodio::play(&stream_handle.mixer(), file).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `stream_handle.mixer()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 54.63s [INFO] running `Command { std: "docker" "inspect" "77f52bd0c64d3f6ce91905d846fb69ba2fca5a8fcb56aad9e45783181a6440e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "77f52bd0c64d3f6ce91905d846fb69ba2fca5a8fcb56aad9e45783181a6440e5", kill_on_drop: false }` [INFO] [stdout] 77f52bd0c64d3f6ce91905d846fb69ba2fca5a8fcb56aad9e45783181a6440e5