[INFO] cloning repository https://github.com/liqimai/clevis [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/liqimai/clevis" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fliqimai%2Fclevis", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fliqimai%2Fclevis'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f183eabebe692952a381a7489740ffe67fbf4359 [INFO] linting liqimai/clevis against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fliqimai%2Fclevis" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/liqimai/clevis [INFO] finished tweaking git repo https://github.com/liqimai/clevis [INFO] tweaked toml for git repo https://github.com/liqimai/clevis written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/liqimai/clevis on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/liqimai/clevis already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded clap v3.2.21 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 349254b77bdfdf797d4d5dba6fb2b394c6dafa1965b945094d9dbe6f8e95d281 [INFO] running `Command { std: "docker" "start" "-a" "349254b77bdfdf797d4d5dba6fb2b394c6dafa1965b945094d9dbe6f8e95d281", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "349254b77bdfdf797d4d5dba6fb2b394c6dafa1965b945094d9dbe6f8e95d281", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "349254b77bdfdf797d4d5dba6fb2b394c6dafa1965b945094d9dbe6f8e95d281", kill_on_drop: false }` [INFO] [stdout] 349254b77bdfdf797d4d5dba6fb2b394c6dafa1965b945094d9dbe6f8e95d281 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9a07eaf56824bac58b70942d6d8e37a8c40d546b4fb6211791021cc0135553bd [INFO] running `Command { std: "docker" "start" "-a" "9a07eaf56824bac58b70942d6d8e37a8c40d546b4fb6211791021cc0135553bd", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking os_str_bytes v6.3.0 [INFO] [stderr] Checking once_cell v1.14.0 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling clap_derive v3.2.18 [INFO] [stderr] Checking clap v3.2.21 [INFO] [stderr] Checking clevis v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:99:29 [INFO] [stdout] | [INFO] [stdout] 99 | corner: Point { x: x, y: y }, [INFO] [stdout] | ^^^^ help: replace it with: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:99:35 [INFO] [stdout] | [INFO] [stdout] 99 | corner: Point { x: x, y: y }, [INFO] [stdout] | ^^^^ help: replace it with: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:99:29 [INFO] [stdout] | [INFO] [stdout] 99 | corner: Point { x: x, y: y }, [INFO] [stdout] | ^^^^ help: replace it with: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:99:35 [INFO] [stdout] | [INFO] [stdout] 99 | corner: Point { x: x, y: y }, [INFO] [stdout] | ^^^^ help: replace it with: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/app.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | return (join_handle, tx); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 - return (join_handle, tx); [INFO] [stdout] 99 + (join_handle, tx) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/app.rs:90:23 [INFO] [stdout] | [INFO] [stdout] 90 | while let Ok(_) = rx.recv() { [INFO] [stdout] | ----------^^^^^------------ help: try: `while rx.recv().is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/app.rs:91:27 [INFO] [stdout] | [INFO] [stdout] 91 | while let Ok(_) = rx.try_recv() {} [INFO] [stdout] | ----------^^^^^---------------- help: try: `while rx.try_recv().is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/app.rs:92:17 [INFO] [stdout] | [INFO] [stdout] 92 | / match render() { [INFO] [stdout] 93 | | Err(error) => log::error!("{}", error), [INFO] [stdout] 94 | | Ok(_) => (), [INFO] [stdout] 95 | | }; [INFO] [stdout] | |_________________^ help: try: `if let Err(error) = render() { log::error!("{}", error) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/app.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 106 | / match self.execute(cmd) { [INFO] [stdout] 107 | | Err(error) => log::error!("{}", error), [INFO] [stdout] 108 | | Ok(()) => (), [INFO] [stdout] 109 | | } [INFO] [stdout] | |_________________^ help: try: `if let Err(error) = self.execute(cmd) { log::error!("{}", error) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/app.rs:117:17 [INFO] [stdout] | [INFO] [stdout] 117 | / match self.execute(cmd) { [INFO] [stdout] 118 | | Err(error) => log::error!("{}", error), [INFO] [stdout] 119 | | Ok(()) => (), [INFO] [stdout] 120 | | } [INFO] [stdout] | |_________________^ help: try: `if let Err(error) = self.execute(cmd) { log::error!("{}", error) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/app.rs:121:17 [INFO] [stdout] | [INFO] [stdout] 121 | / match self.render_shapes() { [INFO] [stdout] 122 | | Err(error) => log::error!("{}", error), [INFO] [stdout] 123 | | Ok(()) => (), [INFO] [stdout] 124 | | } [INFO] [stdout] | |_________________^ help: try: `if let Err(error) = self.render_shapes() { log::error!("{}", error) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/app.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | return (join_handle, tx); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 - return (join_handle, tx); [INFO] [stdout] 99 + (join_handle, tx) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/app.rs:90:23 [INFO] [stdout] | [INFO] [stdout] 90 | while let Ok(_) = rx.recv() { [INFO] [stdout] | ----------^^^^^------------ help: try: `while rx.recv().is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/app.rs:91:27 [INFO] [stdout] | [INFO] [stdout] 91 | while let Ok(_) = rx.try_recv() {} [INFO] [stdout] | ----------^^^^^---------------- help: try: `while rx.try_recv().is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/app.rs:92:17 [INFO] [stdout] | [INFO] [stdout] 92 | / match render() { [INFO] [stdout] 93 | | Err(error) => log::error!("{}", error), [INFO] [stdout] 94 | | Ok(_) => (), [INFO] [stdout] 95 | | }; [INFO] [stdout] | |_________________^ help: try: `if let Err(error) = render() { log::error!("{}", error) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/app.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 106 | / match self.execute(cmd) { [INFO] [stdout] 107 | | Err(error) => log::error!("{}", error), [INFO] [stdout] 108 | | Ok(()) => (), [INFO] [stdout] 109 | | } [INFO] [stdout] | |_________________^ help: try: `if let Err(error) = self.execute(cmd) { log::error!("{}", error) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/app.rs:117:17 [INFO] [stdout] | [INFO] [stdout] 117 | / match self.execute(cmd) { [INFO] [stdout] 118 | | Err(error) => log::error!("{}", error), [INFO] [stdout] 119 | | Ok(()) => (), [INFO] [stdout] 120 | | } [INFO] [stdout] | |_________________^ help: try: `if let Err(error) = self.execute(cmd) { log::error!("{}", error) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/app.rs:121:17 [INFO] [stdout] | [INFO] [stdout] 121 | / match self.render_shapes() { [INFO] [stdout] 122 | | Err(error) => log::error!("{}", error), [INFO] [stdout] 123 | | Ok(()) => (), [INFO] [stdout] 124 | | } [INFO] [stdout] | |_________________^ help: try: `if let Err(error) = self.render_shapes() { log::error!("{}", error) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing an `Option` with `None` [INFO] [stdout] --> src/command/delete.rs:36:21 [INFO] [stdout] | [INFO] [stdout] 36 | let shape = mem::replace(&mut self.deleted, None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider `Option::take()` instead: `self.deleted.take()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_option_with_none [INFO] [stdout] = note: `#[warn(clippy::mem_replace_option_with_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant slicing of the whole range [INFO] [stdout] --> src/commander/cli_commander.rs:81:51 [INFO] [stdout] | [INFO] [stdout] 81 | let caps = RE_POINT.captures(&line).ok_or(&err_msg[..])?; [INFO] [stdout] | ^^^^^^^^^^^^ help: use the original value instead: `err_msg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing [INFO] [stdout] = note: `#[warn(clippy::redundant_slicing)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant slicing of the whole range [INFO] [stdout] --> src/commander/cli_commander.rs:84:20 [INFO] [stdout] | [INFO] [stdout] 84 | .ok_or(&err_msg[..])? [INFO] [stdout] | ^^^^^^^^^^^^ help: use the original value instead: `err_msg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/commander/cli_commander.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | / match self.stdout.write_all(b"> ") { [INFO] [stdout] 96 | | Err(error) => return Some(Err(error)), [INFO] [stdout] 97 | | Ok(_) => (), [INFO] [stdout] 98 | | } [INFO] [stdout] | |_________^ help: try: `if let Err(error) = self.stdout.write_all(b"> ") { return Some(Err(error)) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/commander/cli_commander.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | / match self.stdout.flush() { [INFO] [stdout] 100 | | Err(error) => return Some(Err(error)), [INFO] [stdout] 101 | | Ok(_) => (), [INFO] [stdout] 102 | | } [INFO] [stdout] | |_________^ help: try: `if let Err(error) = self.stdout.flush() { return Some(Err(error)) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/commander/cli_commander.rs:139:21 [INFO] [stdout] | [INFO] [stdout] 139 | / match res { [INFO] [stdout] 140 | | Err(error) => io::stdout() [INFO] [stdout] 141 | | .lock() [INFO] [stdout] 142 | | .write_all(format!("{}\n", error).as_bytes()) [INFO] [stdout] 143 | | .unwrap(), [INFO] [stdout] 144 | | Ok(_) => (), [INFO] [stdout] 145 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 139 ~ if let Err(error) = res { io::stdout() [INFO] [stdout] 140 + .lock() [INFO] [stdout] 141 + .write_all(format!("{}\n", error).as_bytes()) [INFO] [stdout] 142 + .unwrap() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:59:38 [INFO] [stdout] | [INFO] [stdout] 59 | let caps = RE_CMD_POINT.captures(&line).ok_or(&err_msg[..])?; [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:89:42 [INFO] [stdout] | [INFO] [stdout] 89 | let caps = RE_CMD_RECTANGLE.captures(&line).ok_or(&err_msg[..])?; [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&cmd1.name).is_none()` [INFO] [stdout] --> src/command/draw_shape.rs:97:24 [INFO] [stdout] | [INFO] [stdout] 97 | assert!(shapes.get(&cmd1.name).is_none()); [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!shapes.contains_key(&cmd1.name)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:128:37 [INFO] [stdout] | [INFO] [stdout] 128 | let caps = RE_CMD_LINE.captures(&line).ok_or(&err_msg[..])?; [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing an `Option` with `None` [INFO] [stdout] --> src/command/delete.rs:36:21 [INFO] [stdout] | [INFO] [stdout] 36 | let shape = mem::replace(&mut self.deleted, None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider `Option::take()` instead: `self.deleted.take()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_option_with_none [INFO] [stdout] = note: `#[warn(clippy::mem_replace_option_with_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:162:39 [INFO] [stdout] | [INFO] [stdout] 162 | let caps = RE_CMD_CIRCLE.captures(&line).ok_or(&err_msg[..])?; [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:198:39 [INFO] [stdout] | [INFO] [stdout] 198 | let caps = RE_CMD_SQUARE.captures(&line).ok_or(&err_msg[..])?; [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:230:37 [INFO] [stdout] | [INFO] [stdout] 230 | let caps = RE_CMD_MOVE.captures(&line).ok_or(&err_msg[..])?; [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant slicing of the whole range [INFO] [stdout] --> src/commander/cli_commander.rs:81:51 [INFO] [stdout] | [INFO] [stdout] 81 | let caps = RE_POINT.captures(&line).ok_or(&err_msg[..])?; [INFO] [stdout] | ^^^^^^^^^^^^ help: use the original value instead: `err_msg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing [INFO] [stdout] = note: `#[warn(clippy::redundant_slicing)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant slicing of the whole range [INFO] [stdout] --> src/commander/cli_commander.rs:84:20 [INFO] [stdout] | [INFO] [stdout] 84 | .ok_or(&err_msg[..])? [INFO] [stdout] | ^^^^^^^^^^^^ help: use the original value instead: `err_msg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/commander/cli_commander.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | / match self.stdout.write_all(b"> ") { [INFO] [stdout] 96 | | Err(error) => return Some(Err(error)), [INFO] [stdout] 97 | | Ok(_) => (), [INFO] [stdout] 98 | | } [INFO] [stdout] | |_________^ help: try: `if let Err(error) = self.stdout.write_all(b"> ") { return Some(Err(error)) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/commander/cli_commander.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | / match self.stdout.flush() { [INFO] [stdout] 100 | | Err(error) => return Some(Err(error)), [INFO] [stdout] 101 | | Ok(_) => (), [INFO] [stdout] 102 | | } [INFO] [stdout] | |_________^ help: try: `if let Err(error) = self.stdout.flush() { return Some(Err(error)) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:249:26 [INFO] [stdout] | [INFO] [stdout] 249 | RE_CMD_UNDO.captures(&line).ok_or(&err_msg[..])?; [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/commander/cli_commander.rs:139:21 [INFO] [stdout] | [INFO] [stdout] 139 | / match res { [INFO] [stdout] 140 | | Err(error) => io::stdout() [INFO] [stdout] 141 | | .lock() [INFO] [stdout] 142 | | .write_all(format!("{}\n", error).as_bytes()) [INFO] [stdout] 143 | | .unwrap(), [INFO] [stdout] 144 | | Ok(_) => (), [INFO] [stdout] 145 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 139 ~ if let Err(error) = res { io::stdout() [INFO] [stdout] 140 + .lock() [INFO] [stdout] 141 + .write_all(format!("{}\n", error).as_bytes()) [INFO] [stdout] 142 + .unwrap() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:265:26 [INFO] [stdout] | [INFO] [stdout] 265 | RE_CMD_REDO.captures(&line).ok_or(&err_msg[..])?; [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:284:39 [INFO] [stdout] | [INFO] [stdout] 284 | let caps = RE_CMD_DELETE.captures(&line).ok_or(&err_msg[..])?; [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:59:38 [INFO] [stdout] | [INFO] [stdout] 59 | let caps = RE_CMD_POINT.captures(&line).ok_or(&err_msg[..])?; [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:89:42 [INFO] [stdout] | [INFO] [stdout] 89 | let caps = RE_CMD_RECTANGLE.captures(&line).ok_or(&err_msg[..])?; [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:128:37 [INFO] [stdout] | [INFO] [stdout] 128 | let caps = RE_CMD_LINE.captures(&line).ok_or(&err_msg[..])?; [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:162:39 [INFO] [stdout] | [INFO] [stdout] 162 | let caps = RE_CMD_CIRCLE.captures(&line).ok_or(&err_msg[..])?; [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:198:39 [INFO] [stdout] | [INFO] [stdout] 198 | let caps = RE_CMD_SQUARE.captures(&line).ok_or(&err_msg[..])?; [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:230:37 [INFO] [stdout] | [INFO] [stdout] 230 | let caps = RE_CMD_MOVE.captures(&line).ok_or(&err_msg[..])?; [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:249:26 [INFO] [stdout] | [INFO] [stdout] 249 | RE_CMD_UNDO.captures(&line).ok_or(&err_msg[..])?; [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:44:48 [INFO] [stdout] | [INFO] [stdout] 44 | static ref PATTERN_CMD_POINT: String = vec!( [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 45 | | r"^\s*(?i:point)", [INFO] [stdout] 46 | | r"(?P\w+)", [INFO] [stdout] 47 | | r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 48 | | r"(?P(\+|-)?[[:digit:]]+)\s*$", [INFO] [stdout] 49 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 44 ~ static ref PATTERN_CMD_POINT: String = [r"^\s*(?i:point)", [INFO] [stdout] 45 + r"(?P\w+)", [INFO] [stdout] 46 + r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 47 + r"(?P(\+|-)?[[:digit:]]+)\s*$"] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:72:52 [INFO] [stdout] | [INFO] [stdout] 72 | static ref PATTERN_CMD_RECTANGLE: String = vec!( [INFO] [stdout] | ____________________________________________________^ [INFO] [stdout] 73 | | r"^\s*(?i:rectangle)", [INFO] [stdout] 74 | | r"(?P\w+)", [INFO] [stdout] 75 | | r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] ... | [INFO] [stdout] 78 | | r"(?P(\+|-)?[[:digit:]]+)\s*$", [INFO] [stdout] 79 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 72 ~ static ref PATTERN_CMD_RECTANGLE: String = [r"^\s*(?i:rectangle)", [INFO] [stdout] 73 + r"(?P\w+)", [INFO] [stdout] 74 + r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 75 + r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 76 + r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 77 + r"(?P(\+|-)?[[:digit:]]+)\s*$"] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:111:47 [INFO] [stdout] | [INFO] [stdout] 111 | static ref PATTERN_CMD_LINE: String = vec!( [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 112 | | r"^\s*(?i:line)", [INFO] [stdout] 113 | | r"(?P\w+)", [INFO] [stdout] 114 | | r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] ... | [INFO] [stdout] 117 | | r"(?P(\+|-)?[[:digit:]]+)\s*$", [INFO] [stdout] 118 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 111 ~ static ref PATTERN_CMD_LINE: String = [r"^\s*(?i:line)", [INFO] [stdout] 112 + r"(?P\w+)", [INFO] [stdout] 113 + r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 114 + r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 115 + r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 116 + r"(?P(\+|-)?[[:digit:]]+)\s*$"] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:146:49 [INFO] [stdout] | [INFO] [stdout] 146 | static ref PATTERN_CMD_CIRCLE: String = vec!( [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 147 | | r"^\s*(?i:circle)", [INFO] [stdout] 148 | | r"(?P\w+)", [INFO] [stdout] 149 | | r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 150 | | r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 151 | | r"(?P(\+|-)?[[:digit:]]+)\s*$", [INFO] [stdout] 152 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 146 ~ static ref PATTERN_CMD_CIRCLE: String = [r"^\s*(?i:circle)", [INFO] [stdout] 147 + r"(?P\w+)", [INFO] [stdout] 148 + r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 149 + r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 150 + r"(?P(\+|-)?[[:digit:]]+)\s*$"] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:182:49 [INFO] [stdout] | [INFO] [stdout] 182 | static ref PATTERN_CMD_SQUARE: String = vec!( [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 183 | | r"^\s*(?i:square)", [INFO] [stdout] 184 | | r"(?P\w+)", [INFO] [stdout] 185 | | r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 186 | | r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 187 | | r"(?P(\+|-)?[[:digit:]]+)\s*$", [INFO] [stdout] 188 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 182 ~ static ref PATTERN_CMD_SQUARE: String = [r"^\s*(?i:square)", [INFO] [stdout] 183 + r"(?P\w+)", [INFO] [stdout] 184 + r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 185 + r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 186 + r"(?P(\+|-)?[[:digit:]]+)\s*$"] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:215:47 [INFO] [stdout] | [INFO] [stdout] 215 | static ref PATTERN_CMD_MOVE: String = vec!( [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 216 | | r"^\s*(?i:move)", [INFO] [stdout] 217 | | r"(?P\w+)", [INFO] [stdout] 218 | | r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 219 | | r"(?P(\+|-)?[[:digit:]]+)\s*$", [INFO] [stdout] 220 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 215 ~ static ref PATTERN_CMD_MOVE: String = [r"^\s*(?i:move)", [INFO] [stdout] 216 + r"(?P\w+)", [INFO] [stdout] 217 + r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 218 + r"(?P(\+|-)?[[:digit:]]+)\s*$"] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:240:47 [INFO] [stdout] | [INFO] [stdout] 240 | static ref PATTERN_CMD_UNDO: String = vec!(r"^\s*(?i:undo)\s*$",).join(r"\s+"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[r"^\s*(?i:undo)\s*$"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:256:47 [INFO] [stdout] | [INFO] [stdout] 256 | static ref PATTERN_CMD_REDO: String = vec!(r"^\s*(?i:redo)\s*$",).join(r"\s+"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[r"^\s*(?i:redo)\s*$"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:275:13 [INFO] [stdout] | [INFO] [stdout] 275 | vec!(r"^\s*(?i:delete)", r"(?P\w+)\s*$",).join(r"\s+"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[r"^\s*(?i:delete)", r"(?P\w+)\s*$"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:265:26 [INFO] [stdout] | [INFO] [stdout] 265 | RE_CMD_REDO.captures(&line).ok_or(&err_msg[..])?; [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:284:39 [INFO] [stdout] | [INFO] [stdout] 284 | let caps = RE_CMD_DELETE.captures(&line).ok_or(&err_msg[..])?; [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:301:17 [INFO] [stdout] | [INFO] [stdout] 301 | assert!(!point("aaa bbb cc cc").is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `point("aaa bbb cc cc").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:314:17 [INFO] [stdout] | [INFO] [stdout] 314 | assert!(!rectangle("aaa bbb cc cc").is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rectangle("aaa bbb cc cc").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:327:17 [INFO] [stdout] | [INFO] [stdout] 327 | assert!(!line("aaa bbb cc cc").is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `line("aaa bbb cc cc").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:340:17 [INFO] [stdout] | [INFO] [stdout] 340 | assert!(!circle("aaa bbb cc cc").is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `circle("aaa bbb cc cc").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:353:17 [INFO] [stdout] | [INFO] [stdout] 353 | assert!(!square("aaa bbb cc cc").is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `square("aaa bbb cc cc").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/render.rs:122:28 [INFO] [stdout] | [INFO] [stdout] 122 | buff.render_shapes(&shapes).unwrap(); [INFO] [stdout] | ^^^^^^^ help: change this to: `shapes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:44:48 [INFO] [stdout] | [INFO] [stdout] 44 | static ref PATTERN_CMD_POINT: String = vec!( [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 45 | | r"^\s*(?i:point)", [INFO] [stdout] 46 | | r"(?P\w+)", [INFO] [stdout] 47 | | r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 48 | | r"(?P(\+|-)?[[:digit:]]+)\s*$", [INFO] [stdout] 49 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 44 ~ static ref PATTERN_CMD_POINT: String = [r"^\s*(?i:point)", [INFO] [stdout] 45 + r"(?P\w+)", [INFO] [stdout] 46 + r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 47 + r"(?P(\+|-)?[[:digit:]]+)\s*$"] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:72:52 [INFO] [stdout] | [INFO] [stdout] 72 | static ref PATTERN_CMD_RECTANGLE: String = vec!( [INFO] [stdout] | ____________________________________________________^ [INFO] [stdout] 73 | | r"^\s*(?i:rectangle)", [INFO] [stdout] 74 | | r"(?P\w+)", [INFO] [stdout] 75 | | r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] ... | [INFO] [stdout] 78 | | r"(?P(\+|-)?[[:digit:]]+)\s*$", [INFO] [stdout] 79 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 72 ~ static ref PATTERN_CMD_RECTANGLE: String = [r"^\s*(?i:rectangle)", [INFO] [stdout] 73 + r"(?P\w+)", [INFO] [stdout] 74 + r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 75 + r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 76 + r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 77 + r"(?P(\+|-)?[[:digit:]]+)\s*$"] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:111:47 [INFO] [stdout] | [INFO] [stdout] 111 | static ref PATTERN_CMD_LINE: String = vec!( [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 112 | | r"^\s*(?i:line)", [INFO] [stdout] 113 | | r"(?P\w+)", [INFO] [stdout] 114 | | r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] ... | [INFO] [stdout] 117 | | r"(?P(\+|-)?[[:digit:]]+)\s*$", [INFO] [stdout] 118 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 111 ~ static ref PATTERN_CMD_LINE: String = [r"^\s*(?i:line)", [INFO] [stdout] 112 + r"(?P\w+)", [INFO] [stdout] 113 + r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 114 + r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 115 + r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 116 + r"(?P(\+|-)?[[:digit:]]+)\s*$"] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:146:49 [INFO] [stdout] | [INFO] [stdout] 146 | static ref PATTERN_CMD_CIRCLE: String = vec!( [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 147 | | r"^\s*(?i:circle)", [INFO] [stdout] 148 | | r"(?P\w+)", [INFO] [stdout] 149 | | r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 150 | | r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 151 | | r"(?P(\+|-)?[[:digit:]]+)\s*$", [INFO] [stdout] 152 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 146 ~ static ref PATTERN_CMD_CIRCLE: String = [r"^\s*(?i:circle)", [INFO] [stdout] 147 + r"(?P\w+)", [INFO] [stdout] 148 + r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 149 + r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 150 + r"(?P(\+|-)?[[:digit:]]+)\s*$"] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:182:49 [INFO] [stdout] | [INFO] [stdout] 182 | static ref PATTERN_CMD_SQUARE: String = vec!( [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 183 | | r"^\s*(?i:square)", [INFO] [stdout] 184 | | r"(?P\w+)", [INFO] [stdout] 185 | | r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 186 | | r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 187 | | r"(?P(\+|-)?[[:digit:]]+)\s*$", [INFO] [stdout] 188 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 182 ~ static ref PATTERN_CMD_SQUARE: String = [r"^\s*(?i:square)", [INFO] [stdout] 183 + r"(?P\w+)", [INFO] [stdout] 184 + r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 185 + r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 186 + r"(?P(\+|-)?[[:digit:]]+)\s*$"] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:215:47 [INFO] [stdout] | [INFO] [stdout] 215 | static ref PATTERN_CMD_MOVE: String = vec!( [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 216 | | r"^\s*(?i:move)", [INFO] [stdout] 217 | | r"(?P\w+)", [INFO] [stdout] 218 | | r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 219 | | r"(?P(\+|-)?[[:digit:]]+)\s*$", [INFO] [stdout] 220 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 215 ~ static ref PATTERN_CMD_MOVE: String = [r"^\s*(?i:move)", [INFO] [stdout] 216 + r"(?P\w+)", [INFO] [stdout] 217 + r"(?P(\+|-)?[[:digit:]]+)", [INFO] [stdout] 218 + r"(?P(\+|-)?[[:digit:]]+)\s*$"] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:240:47 [INFO] [stdout] | [INFO] [stdout] 240 | static ref PATTERN_CMD_UNDO: String = vec!(r"^\s*(?i:undo)\s*$",).join(r"\s+"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[r"^\s*(?i:undo)\s*$"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:256:47 [INFO] [stdout] | [INFO] [stdout] 256 | static ref PATTERN_CMD_REDO: String = vec!(r"^\s*(?i:redo)\s*$",).join(r"\s+"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[r"^\s*(?i:redo)\s*$"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/commander/cli_commander/parse_cmd.rs:275:13 [INFO] [stdout] | [INFO] [stdout] 275 | vec!(r"^\s*(?i:delete)", r"(?P\w+)\s*$",).join(r"\s+"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[r"^\s*(?i:delete)", r"(?P\w+)\s*$"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.87s [INFO] running `Command { std: "docker" "inspect" "9a07eaf56824bac58b70942d6d8e37a8c40d546b4fb6211791021cc0135553bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9a07eaf56824bac58b70942d6d8e37a8c40d546b4fb6211791021cc0135553bd", kill_on_drop: false }` [INFO] [stdout] 9a07eaf56824bac58b70942d6d8e37a8c40d546b4fb6211791021cc0135553bd