[INFO] cloning repository https://github.com/lionesslie/Q-Chat [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/lionesslie/Q-Chat" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flionesslie%2FQ-Chat", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flionesslie%2FQ-Chat'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ff7c8248a1787d119f0373d80a6ae5129c883cea [INFO] linting lionesslie/Q-Chat against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flionesslie%2FQ-Chat" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/lionesslie/Q-Chat [INFO] finished tweaking git repo https://github.com/lionesslie/Q-Chat [INFO] tweaked toml for git repo https://github.com/lionesslie/Q-Chat written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/lionesslie/Q-Chat on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/lionesslie/Q-Chat already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: file `/workspace/builds/worker-1-tc1/source/src/main.rs` found to be present in multiple build targets: [INFO] [stderr] * `lib` target `q_chat` [INFO] [stderr] * `bin` target `q-chat` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded dlopen2_derive v0.4.3 [INFO] [stderr] Downloaded webview2-com-macros v0.8.1 [INFO] [stderr] Downloaded sanitize-filename v0.6.0 [INFO] [stderr] Downloaded dtoa v1.0.11 [INFO] [stderr] Downloaded actix-multipart-derive v0.7.0 [INFO] [stderr] Downloaded actix-web-actors v4.3.1+deprecated [INFO] [stderr] Downloaded toml_edit v0.25.3+spec-1.1.0 [INFO] [stderr] Downloaded actix-ws v0.3.1 [INFO] [stderr] Downloaded actix-multipart v0.7.2 [INFO] [stderr] Downloaded actix-tls v3.5.0 [INFO] [stderr] Downloaded jiff-static v0.2.22 [INFO] [stderr] Downloaded objc2-web-kit v0.2.2 [INFO] [stderr] Downloaded wry v0.47.2 [INFO] [stderr] Downloaded aws-lc-rs v1.16.1 [INFO] [stderr] Downloaded jiff v0.2.22 [INFO] [stderr] Downloaded tao v0.33.0 [INFO] [stderr] Downloaded aws-lc-sys v0.38.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8e6ed1b41225543d678e23b821e769712784aba891c661903a6eeb0fd5ebe2eb [INFO] running `Command { std: "docker" "start" "-a" "8e6ed1b41225543d678e23b821e769712784aba891c661903a6eeb0fd5ebe2eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8e6ed1b41225543d678e23b821e769712784aba891c661903a6eeb0fd5ebe2eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8e6ed1b41225543d678e23b821e769712784aba891c661903a6eeb0fd5ebe2eb", kill_on_drop: false }` [INFO] [stdout] 8e6ed1b41225543d678e23b821e769712784aba891c661903a6eeb0fd5ebe2eb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 54595d5b20ffb57570e9072c48fa4e78ca946fd25e0cbc3b703a9981c0bd1adc [INFO] running `Command { std: "docker" "start" "-a" "54595d5b20ffb57570e9072c48fa4e78ca946fd25e0cbc3b703a9981c0bd1adc", kill_on_drop: false }` [INFO] [stderr] warning: file `/opt/rustwide/workdir/src/main.rs` found to be present in multiple build targets: [INFO] [stderr] * `lib` target `q_chat` [INFO] [stderr] * `bin` target `q-chat` [INFO] [stderr] Compiling unicode-ident v1.0.24 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Compiling target-lexicon v0.12.16 [INFO] [stderr] Compiling version-compare v0.2.1 [INFO] [stderr] Compiling indexmap v2.13.0 [INFO] [stderr] Checking pin-project-lite v0.2.17 [INFO] [stderr] Checking futures-core v0.3.32 [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Checking slab v0.4.12 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Compiling cmake v0.1.57 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Compiling dunce v1.0.5 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Compiling aws-lc-rs v1.16.1 [INFO] [stderr] Compiling zerocopy v0.8.40 [INFO] [stderr] Checking futures-sink v0.3.32 [INFO] [stderr] Checking rustls-pki-types v1.14.0 [INFO] [stderr] Compiling zstd-sys v2.0.16+zstd.1.5.7 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Checking regex-syntax v0.8.10 [INFO] [stderr] Compiling gio v0.18.4 [INFO] [stderr] Compiling num-conv v0.2.0 [INFO] [stderr] Compiling cfg-expr v0.15.8 [INFO] [stderr] Compiling time-core v0.1.8 [INFO] [stderr] Compiling aws-lc-sys v0.38.0 [INFO] [stderr] Compiling rustls v0.23.37 [INFO] [stderr] Checking futures-io v0.3.32 [INFO] [stderr] Checking deranged v0.5.8 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking actix-utils v3.0.1 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling time-macros v0.2.27 [INFO] [stderr] Checking actix-service v2.0.3 [INFO] [stderr] Compiling log v0.4.29 [INFO] [stderr] Checking simd-adler32 v0.3.8 [INFO] [stderr] Compiling semver v1.0.27 [INFO] [stderr] Compiling bytes v1.11.1 [INFO] [stderr] Compiling tracing-core v0.1.36 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Checking bytestring v1.5.0 [INFO] [stderr] Compiling regex-lite v0.1.9 [INFO] [stderr] Compiling tracing v0.1.44 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking brotli v8.0.2 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking local-channel v0.1.5 [INFO] [stderr] Compiling x11 v2.21.0 [INFO] [stderr] Checking flate2 v1.1.9 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Compiling field-offset v0.3.6 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Compiling gtk v0.18.2 [INFO] [stderr] Compiling getrandom v0.4.2 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Compiling toml_datetime v0.6.3 [INFO] [stderr] Compiling serde_spanned v0.6.9 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Compiling actix-router v0.5.4 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Compiling rustix v1.1.4 [INFO] [stderr] Compiling unicase v2.9.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking time v0.3.47 [INFO] [stderr] Compiling cookie v0.18.1 [INFO] [stderr] Checking linux-raw-sys v0.12.1 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Compiling toml_edit v0.20.2 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Compiling wry v0.47.2 [INFO] [stderr] Checking dpi v0.1.2 [INFO] [stderr] Compiling parse-size v1.1.0 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Checking iana-time-zone v0.1.65 [INFO] [stderr] Checking jiff v0.2.22 [INFO] [stderr] Checking uuid v1.21.0 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking rustls-pemfile v2.2.0 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Checking cookie v0.16.2 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking env_filter v1.0.0 [INFO] [stderr] Checking sanitize-filename v0.6.0 [INFO] [stderr] Checking tempfile v3.26.0 [INFO] [stderr] Compiling toml v0.8.2 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling proc-macro-crate v2.0.2 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling system-deps v6.2.2 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Compiling futures-macro v0.3.32 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling tokio-macros v2.6.1 [INFO] [stderr] Compiling glib-macros v0.18.5 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling glib-sys v0.18.1 [INFO] [stderr] Compiling gobject-sys v0.18.0 [INFO] [stderr] Compiling gio-sys v0.18.1 [INFO] [stderr] Compiling gdk-sys v0.18.2 [INFO] [stderr] Compiling cairo-sys-rs v0.18.2 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.18.0 [INFO] [stderr] Compiling pango-sys v0.18.0 [INFO] [stderr] Compiling atk-sys v0.18.2 [INFO] [stderr] Compiling gtk-sys v0.18.2 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling actix-macros v0.2.4 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Compiling derive_more-impl v2.1.1 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Compiling soup3-sys v0.5.0 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Compiling javascriptcore-rs-sys v1.1.1 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Compiling webkit2gtk-sys v2.0.1 [INFO] [stderr] Compiling gdkx11-sys v0.18.2 [INFO] [stderr] Compiling actix-web-codegen v4.3.0 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Compiling gtk3-macros v0.18.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling dlopen2_derive v0.4.3 [INFO] [stderr] Compiling derive_more v0.99.20 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking dlopen2 v0.7.0 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking env_logger v0.11.9 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Checking gdkwayland-sys v0.18.2 [INFO] [stderr] Compiling actix-multipart-derive v0.7.0 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking futures-executor v0.3.32 [INFO] [stderr] Checking glib v0.18.5 [INFO] [stderr] Checking derive_more v2.1.1 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_plain v1.0.2 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking actix-rt v2.11.0 [INFO] [stderr] Checking actix-server v2.6.0 [INFO] [stderr] Checking actix-codec v0.5.2 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking actix v0.13.5 [INFO] [stderr] Checking cairo-rs v0.18.5 [INFO] [stderr] Checking atk v0.18.2 [INFO] [stderr] Checking javascriptcore-rs v1.1.2 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking actix-tls v3.5.0 [INFO] [stderr] Checking actix-http v3.12.0 [INFO] [stderr] Checking actix-web v4.13.0 [INFO] [stderr] Checking actix-files v0.6.10 [INFO] [stderr] Checking actix-multipart v0.7.2 [INFO] [stderr] Checking actix-ws v0.3.1 [INFO] [stderr] Checking actix-web-actors v4.3.1+deprecated [INFO] [stderr] Checking gdk-pixbuf v0.18.5 [INFO] [stderr] Checking pango v0.18.3 [INFO] [stderr] Checking soup3 v0.5.0 [INFO] [stderr] Checking gdk v0.18.2 [INFO] [stderr] Checking gdkx11 v0.18.2 [INFO] [stderr] Checking webkit2gtk v2.0.1 [INFO] [stderr] Checking tao v0.33.0 [INFO] [stderr] Checking q-chat v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `parking_lot::RwLock` [INFO] [stdout] --> src/storage.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use parking_lot::RwLock; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::Arc` [INFO] [stdout] --> src/storage.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::sync::Arc; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde::Deserialize` [INFO] [stdout] --> src/projects.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use serde::Deserialize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `parking_lot::RwLock` [INFO] [stdout] --> src/storage.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use parking_lot::RwLock; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::Arc` [INFO] [stdout] --> src/storage.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::sync::Arc; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde::Deserialize` [INFO] [stdout] --> src/projects.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use serde::Deserialize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ws.rs:84:20 [INFO] [stdout] | [INFO] [stdout] 84 | let (response, mut session, mut msg_stream) = actix_ws::handle(&req, body)?; [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ws.rs:84:20 [INFO] [stdout] | [INFO] [stdout] 84 | let (response, mut session, mut msg_stream) = actix_ws::handle(&req, body)?; [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `room_id` [INFO] [stdout] --> src/ws.rs:151:42 [INFO] [stdout] | [INFO] [stdout] 151 | ... for (room_id, room_data) in &rooms { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_room_id` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `room_id` [INFO] [stdout] --> src/ws.rs:151:42 [INFO] [stdout] | [INFO] [stdout] 151 | ... for (room_id, room_data) in &rooms { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_room_id` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `send_to_room_members` is never used [INFO] [stdout] --> src/ws.rs:57:8 [INFO] [stdout] | [INFO] [stdout] 24 | impl WsState { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 57 | fn send_to_room_members(&self, storage: &Storage, room_id: &str, msg: &str) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `send_to_room_members` is never used [INFO] [stdout] --> src/ws.rs:57:8 [INFO] [stdout] | [INFO] [stdout] 24 | impl WsState { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 57 | fn send_to_room_members(&self, storage: &Storage, room_id: &str, msg: &str) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/projects.rs:73:32 [INFO] [stdout] | [INFO] [stdout] 73 | if let Err(_) = f.write_all(&chunk) { [INFO] [stdout] | -------^^^^^^---------------------- help: try: `if f.write_all(&chunk).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/projects.rs:92:27 [INFO] [stdout] | [INFO] [stdout] 92 | while let Some(_) = field.next().await {} [INFO] [stdout] | ----------^^^^^^^--------------------- help: try: `while field.next().await.is_some()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/projects.rs:118:16 [INFO] [stdout] | [INFO] [stdout] 118 | if let std::io::Result::Ok(_) = std::fs::write(&img_path, &image_data) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^----------------------------------------- help: try: `if std::fs::write(&img_path, &image_data).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `WsState` [INFO] [stdout] --> src/ws.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / pub fn new() -> Self { [INFO] [stdout] 26 | | let (tx, _) = broadcast::channel(1024); [INFO] [stdout] 27 | | WsState { [INFO] [stdout] 28 | | connections: RwLock::new(HashMap::new()), [INFO] [stdout] ... | [INFO] [stdout] 33 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 24 + impl Default for WsState { [INFO] [stdout] 25 + fn default() -> Self { [INFO] [stdout] 26 + Self::new() [INFO] [stdout] 27 + } [INFO] [stdout] 28 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/ws.rs:244:59 [INFO] [stdout] | [INFO] [stdout] 244 | ... pm.entry(key).or_insert_with(Vec::new).push(pm_msg.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/projects.rs:73:32 [INFO] [stdout] | [INFO] [stdout] 73 | if let Err(_) = f.write_all(&chunk) { [INFO] [stdout] | -------^^^^^^---------------------- help: try: `if f.write_all(&chunk).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/projects.rs:92:27 [INFO] [stdout] | [INFO] [stdout] 92 | while let Some(_) = field.next().await {} [INFO] [stdout] | ----------^^^^^^^--------------------- help: try: `while field.next().await.is_some()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/projects.rs:118:16 [INFO] [stdout] | [INFO] [stdout] 118 | if let std::io::Result::Ok(_) = std::fs::write(&img_path, &image_data) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^----------------------------------------- help: try: `if std::fs::write(&img_path, &image_data).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/ws.rs:433:71 [INFO] [stdout] | [INFO] [stdout] 433 | ... vs.entry(channel.clone()).or_insert_with(HashSet::new).insert(username.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `WsState` [INFO] [stdout] --> src/ws.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / pub fn new() -> Self { [INFO] [stdout] 26 | | let (tx, _) = broadcast::channel(1024); [INFO] [stdout] 27 | | WsState { [INFO] [stdout] 28 | | connections: RwLock::new(HashMap::new()), [INFO] [stdout] ... | [INFO] [stdout] 33 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 24 + impl Default for WsState { [INFO] [stdout] 25 + fn default() -> Self { [INFO] [stdout] 26 + Self::new() [INFO] [stdout] 27 + } [INFO] [stdout] 28 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/ws.rs:244:59 [INFO] [stdout] | [INFO] [stdout] 244 | ... pm.entry(key).or_insert_with(Vec::new).push(pm_msg.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/storage.rs:135:21 [INFO] [stdout] | [INFO] [stdout] 135 | let mut users = vec![user_a, user_b]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[user_a, user_b]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/ws.rs:433:71 [INFO] [stdout] | [INFO] [stdout] 433 | ... vs.entry(channel.clone()).or_insert_with(HashSet::new).insert(username.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/storage.rs:135:21 [INFO] [stdout] | [INFO] [stdout] 135 | let mut users = vec![user_a, user_b]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[user_a, user_b]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/bin/launcher.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | / /// The actix-web server runs in the background. [INFO] [stdout] 6 | | [INFO] [stdout] | |_^ [INFO] [stdout] 7 | use tao::event::{Event, WindowEvent}; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the crate use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 3 ~ //! Q-Chat Desktop Launcher [INFO] [stdout] 4 ~ //! Opens a native window with the Q-Chat interface. [INFO] [stdout] 5 ~ //! The actix-web server runs in the background. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/bin/launcher.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | / /// The actix-web server runs in the background. [INFO] [stdout] 6 | | [INFO] [stdout] | |_^ [INFO] [stdout] 7 | use tao::event::{Event, WindowEvent}; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the crate use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 3 ~ //! Q-Chat Desktop Launcher [INFO] [stdout] 4 ~ //! Opens a native window with the Q-Chat interface. [INFO] [stdout] 5 ~ //! The actix-web server runs in the background. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/bin/launcher.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | / match event { [INFO] [stdout] 57 | | Event::WindowEvent { [INFO] [stdout] 58 | | event: WindowEvent::CloseRequested, [INFO] [stdout] 59 | | .. [INFO] [stdout] ... | [INFO] [stdout] 63 | | _ => {} [INFO] [stdout] 64 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 56 ~ if let Event::WindowEvent { [INFO] [stdout] 57 + event: WindowEvent::CloseRequested, [INFO] [stdout] 58 + .. [INFO] [stdout] 59 + } = event { [INFO] [stdout] 60 + *control_flow = ControlFlow::Exit; [INFO] [stdout] 61 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/bin/launcher.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | / match event { [INFO] [stdout] 57 | | Event::WindowEvent { [INFO] [stdout] 58 | | event: WindowEvent::CloseRequested, [INFO] [stdout] 59 | | .. [INFO] [stdout] ... | [INFO] [stdout] 63 | | _ => {} [INFO] [stdout] 64 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 56 ~ if let Event::WindowEvent { [INFO] [stdout] 57 + event: WindowEvent::CloseRequested, [INFO] [stdout] 58 + .. [INFO] [stdout] 59 + } = event { [INFO] [stdout] 60 + *control_flow = ControlFlow::Exit; [INFO] [stdout] 61 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `parking_lot::RwLock` [INFO] [stdout] --> src/storage.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use parking_lot::RwLock; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::Arc` [INFO] [stdout] --> src/storage.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::sync::Arc; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde::Deserialize` [INFO] [stdout] --> src/projects.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use serde::Deserialize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `parking_lot::RwLock` [INFO] [stdout] --> src/storage.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use parking_lot::RwLock; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::Arc` [INFO] [stdout] --> src/storage.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::sync::Arc; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde::Deserialize` [INFO] [stdout] --> src/projects.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use serde::Deserialize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ws.rs:84:20 [INFO] [stdout] | [INFO] [stdout] 84 | let (response, mut session, mut msg_stream) = actix_ws::handle(&req, body)?; [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ws.rs:84:20 [INFO] [stdout] | [INFO] [stdout] 84 | let (response, mut session, mut msg_stream) = actix_ws::handle(&req, body)?; [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `room_id` [INFO] [stdout] --> src/ws.rs:151:42 [INFO] [stdout] | [INFO] [stdout] 151 | ... for (room_id, room_data) in &rooms { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_room_id` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `send_to_room_members` is never used [INFO] [stdout] --> src/ws.rs:57:8 [INFO] [stdout] | [INFO] [stdout] 24 | impl WsState { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 57 | fn send_to_room_members(&self, storage: &Storage, room_id: &str, msg: &str) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `room_id` [INFO] [stdout] --> src/ws.rs:151:42 [INFO] [stdout] | [INFO] [stdout] 151 | ... for (room_id, room_data) in &rooms { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_room_id` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `send_to_room_members` is never used [INFO] [stdout] --> src/ws.rs:57:8 [INFO] [stdout] | [INFO] [stdout] 24 | impl WsState { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 57 | fn send_to_room_members(&self, storage: &Storage, room_id: &str, msg: &str) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/projects.rs:73:32 [INFO] [stdout] | [INFO] [stdout] 73 | if let Err(_) = f.write_all(&chunk) { [INFO] [stdout] | -------^^^^^^---------------------- help: try: `if f.write_all(&chunk).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/projects.rs:92:27 [INFO] [stdout] | [INFO] [stdout] 92 | while let Some(_) = field.next().await {} [INFO] [stdout] | ----------^^^^^^^--------------------- help: try: `while field.next().await.is_some()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/projects.rs:118:16 [INFO] [stdout] | [INFO] [stdout] 118 | if let std::io::Result::Ok(_) = std::fs::write(&img_path, &image_data) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^----------------------------------------- help: try: `if std::fs::write(&img_path, &image_data).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `WsState` [INFO] [stdout] --> src/ws.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / pub fn new() -> Self { [INFO] [stdout] 26 | | let (tx, _) = broadcast::channel(1024); [INFO] [stdout] 27 | | WsState { [INFO] [stdout] 28 | | connections: RwLock::new(HashMap::new()), [INFO] [stdout] ... | [INFO] [stdout] 33 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 24 + impl Default for WsState { [INFO] [stdout] 25 + fn default() -> Self { [INFO] [stdout] 26 + Self::new() [INFO] [stdout] 27 + } [INFO] [stdout] 28 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/ws.rs:244:59 [INFO] [stdout] | [INFO] [stdout] 244 | ... pm.entry(key).or_insert_with(Vec::new).push(pm_msg.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/ws.rs:433:71 [INFO] [stdout] | [INFO] [stdout] 433 | ... vs.entry(channel.clone()).or_insert_with(HashSet::new).insert(username.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/storage.rs:135:21 [INFO] [stdout] | [INFO] [stdout] 135 | let mut users = vec![user_a, user_b]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[user_a, user_b]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/projects.rs:73:32 [INFO] [stdout] | [INFO] [stdout] 73 | if let Err(_) = f.write_all(&chunk) { [INFO] [stdout] | -------^^^^^^---------------------- help: try: `if f.write_all(&chunk).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/projects.rs:92:27 [INFO] [stdout] | [INFO] [stdout] 92 | while let Some(_) = field.next().await {} [INFO] [stdout] | ----------^^^^^^^--------------------- help: try: `while field.next().await.is_some()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/projects.rs:118:16 [INFO] [stdout] | [INFO] [stdout] 118 | if let std::io::Result::Ok(_) = std::fs::write(&img_path, &image_data) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^----------------------------------------- help: try: `if std::fs::write(&img_path, &image_data).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `WsState` [INFO] [stdout] --> src/ws.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / pub fn new() -> Self { [INFO] [stdout] 26 | | let (tx, _) = broadcast::channel(1024); [INFO] [stdout] 27 | | WsState { [INFO] [stdout] 28 | | connections: RwLock::new(HashMap::new()), [INFO] [stdout] ... | [INFO] [stdout] 33 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 24 + impl Default for WsState { [INFO] [stdout] 25 + fn default() -> Self { [INFO] [stdout] 26 + Self::new() [INFO] [stdout] 27 + } [INFO] [stdout] 28 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/ws.rs:244:59 [INFO] [stdout] | [INFO] [stdout] 244 | ... pm.entry(key).or_insert_with(Vec::new).push(pm_msg.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/ws.rs:433:71 [INFO] [stdout] | [INFO] [stdout] 433 | ... vs.entry(channel.clone()).or_insert_with(HashSet::new).insert(username.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/storage.rs:135:21 [INFO] [stdout] | [INFO] [stdout] 135 | let mut users = vec![user_a, user_b]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[user_a, user_b]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 12s [INFO] running `Command { std: "docker" "inspect" "54595d5b20ffb57570e9072c48fa4e78ca946fd25e0cbc3b703a9981c0bd1adc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "54595d5b20ffb57570e9072c48fa4e78ca946fd25e0cbc3b703a9981c0bd1adc", kill_on_drop: false }` [INFO] [stdout] 54595d5b20ffb57570e9072c48fa4e78ca946fd25e0cbc3b703a9981c0bd1adc